ErnadoO / ext-phpbb-directory

tests/controller/controller_base.php

Doc Comments +4 added lines, -1 removed lines

@@ -36,7 +36,7 @@ 
 	/**
 	* Define the extensions to be tested
 	*
-	* @return array vendor/name of extension(s) to test
+	* @return string[] vendor/name of extension(s) to test
 	*/
 	static protected function setup_extensions()
 	{
@@ -221,6 +221,9 @@ 
 		$this->core_categorie->set_extension_manager($phpbb_extension_manager);
 	}
 
+	/**
+	 * @param \ernadoo\phpbbdirectory\cron\task\core\prune_categorie[] $tasks
+	 */
 	private function create_cron_manager($tasks)
 	{
 		global $phpbb_root_path, $phpEx;

Indentation +4 added lines, -4 removed lines

@@ -34,10 +34,10 @@
 	protected $user;
 
 	/**
-	* Define the extensions to be tested
-	*
-	* @return array vendor/name of extension(s) to test
-	*/
+	 * Define the extensions to be tested
+	 *
+	 * @return array vendor/name of extension(s) to test
+	 */
 	static protected function setup_extensions()
 	{
 		return array('ernadoo/phpbbdirectory');

Spacing +4 added lines, -4 removed lines

@@ -51,8 +51,8 @@ 
 
 		parent::setUp();
 
-		$table_categories	= 'phpbb_directory_cats';
-		$tables_comments	= 'phpbb_directory_comments';
+		$table_categories = 'phpbb_directory_cats';
+		$tables_comments = 'phpbb_directory_comments';
 		$tables_links		= 'phpbb_directory_links';
 		$tables_votes		= 'phpbb_directory_votes';
 		$tables_watch		= 'phpbb_directory_watch';
@@ -100,7 +100,7 @@ 
 
 		$this->helper->expects($this->any())
 			->method('render')
-			->willReturnCallback(function ($template_file, $page_title = '', $status_code = 200, $display_online_list = false) {
+			->willReturnCallback(function($template_file, $page_title = '', $status_code = 200, $display_online_list = false) {
 				return new \Symfony\Component\HttpFoundation\Response($template_file, $status_code);
 		});
 		$this->helper
@@ -131,7 +131,7 @@ 
 		$phpbb_container->set('path_helper', $phpbb_path_helper);
 		$phpbb_container->set('ext.manager', $phpbb_extension_manager);
 		$phpbb_container->set('user', $this->user);
-		$phpbb_container->setParameter('core.cache_dir', $phpbb_root_path . 'cache/' . PHPBB_ENVIRONMENT . '/');
+		$phpbb_container->setParameter('core.cache_dir', $phpbb_root_path.'cache/'.PHPBB_ENVIRONMENT.'/');
 
 		$context = new \phpbb\template\context();
 		$twig_extension = new \phpbb\template\twig\extension($context, $this->lang);

Braces +2 added lines, -1 removed lines

@@ -100,7 +100,8 @@
 
 		$this->helper->expects($this->any())
 			->method('render')
-			->willReturnCallback(function ($template_file, $page_title = '', $status_code = 200, $display_online_list = false) {
+			->willReturnCallback(function ($template_file, $page_title = '', $status_code = 200, $display_online_list = false)
+			{
 				return new \Symfony\Component\HttpFoundation\Response($template_file, $status_code);
 		});
 		$this->helper

tests/controller/phpbbdirectory_base_test.php

Indentation +13 added lines, -13 removed lines

@@ -22,8 +22,8 @@ 
 	}
 
 	/**
-	* Setup test environment
-	*/
+	 * Setup test environment
+	 */
 	public function setUp()
 	{
 		parent::setUp();
@@ -61,10 +61,10 @@ 
 	}
 
 	/**
-	* Test data for the test_display_base() function
-	*
-	* @return array Array of test data
-	*/
+	 * Test data for the test_display_base() function
+	 *
+	 * @return array Array of test data
+	 */
 	public function display_base_data()
 	{
 		return array(
@@ -73,10 +73,10 @@ 
 	}
 
 	/**
-	* Test controller display
-	*
-	* @dataProvider display_base_data
-	*/
+	 * Test controller display
+	 *
+	 * @dataProvider display_base_data
+	 */
 	public function test_display_base($status_code, $page_content)
 	{
 		$controller = $this->get_controller();
@@ -87,9 +87,9 @@ 
 	}
 
 	/**
-	* Test base case scenario
-	*
-	*/
+	 * Test base case scenario
+	 *
+	 */
 	public function test_for_root_categories()
 	{
 		$this->template->expects($this->exactly(2))

Spacing +1 added lines, -1 removed lines

@@ -18,7 +18,7 @@
 {
 	public function getDataSet()
 	{
-		return $this->createMySQLXMLDataSet(__DIR__ . './fixtures/fixture_base.xml');
+		return $this->createMySQLXMLDataSet(__DIR__.'./fixtures/fixture_base.xml');
 	}
 
 	/**

tests/controller/phpbbdirectory_cats_test.php

Indentation +42 added lines, -42 removed lines

@@ -22,8 +22,8 @@ 
 	}
 
 	/**
-	* Setup test environment
-	*/
+	 * Setup test environment
+	 */
 	public function setUp()
 	{
 		parent::setUp();
@@ -65,10 +65,10 @@ 
 	}
 
 	/**
-	* Test data for the test_display_cat_by_id() function
-	*
-	* @return array Array of test data
-	*/
+	 * Test data for the test_display_cat_by_id() function
+	 *
+	 * @return array Array of test data
+	 */
 	public function display_cat_by_id_data()
 	{
 		return array(
@@ -77,10 +77,10 @@ 
 	}
 
 	/**
-	* Test controller display
-	*
-	* @dataProvider display_cat_by_id_data
-	*/
+	 * Test controller display
+	 *
+	 * @dataProvider display_cat_by_id_data
+	 */
 	public function test_display_cat_by_id($cat_id, $page, $status_code)
 	{
 		$controller = $this->get_controller();
@@ -121,10 +121,10 @@ 
 	}
 
 	/**
-	* Test data for the test_display_cat_fails() function
-	*
-	* @return array Array of test data
-	*/
+	 * Test data for the test_display_cat_fails() function
+	 *
+	 * @return array Array of test data
+	 */
 	public function display_cat_fails_data()
 	{
 		return array(
@@ -133,10 +133,10 @@ 
 	}
 
 	/**
-	* Test controller display throws 404 exceptions
-	*
-	* @dataProvider display_cat_fails_data
-	*/
+	 * Test controller display throws 404 exceptions
+	 *
+	 * @dataProvider display_cat_fails_data
+	 */
 	public function test_display_cat_fails($cat_id, $page, $status_code, $page_content)
 	{
 		$controller = $this->get_controller();
@@ -153,10 +153,10 @@ 
 	}
 
 	/**
-	* Test data for the test_category_one_page() function
-	*
-	* @return array Array of test data
-	*/
+	 * Test data for the test_category_one_page() function
+	 *
+	 * @return array Array of test data
+	 */
 	public function category_one_page_data()
 	{
 		return array(
@@ -165,10 +165,10 @@ 
 	}
 
 	/**
-	* Test base case scenario
-	*
-	* @dataProvider category_one_page_data
-	*/
+	 * Test base case scenario
+	 *
+	 * @dataProvider category_one_page_data
+	 */
 	function test_category_one_page($cat_id, $cat_name, $parent_cat_id, $nb_links)
 	{
 		$controller = $this->get_controller();
@@ -178,10 +178,10 @@ 
 	}
 
 	/**
-	* Test data for the test_category_no_links() function
-	*
-	* @return array Array of test data
-	*/
+	 * Test data for the test_category_no_links() function
+	 *
+	 * @return array Array of test data
+	 */
 	public function category_no_links_data()
 	{
 		return array(
@@ -190,10 +190,10 @@ 
 	}
 
 	/**
-	* Test base case scenario
-	*
-	* @dataProvider category_no_links_data
-	*/
+	 * Test base case scenario
+	 *
+	 * @dataProvider category_no_links_data
+	 */
 	function test_category_no_links($cat_id, $cat_name, $nb_links)
 	{
 		$this->template->expects($this->at(3))
@@ -209,10 +209,10 @@ 
 	}
 
 	/**
-	* Test data for the test_category_with_pages() function
-	*
-	* @return array Array of test data
-	*/
+	 * Test data for the test_category_with_pages() function
+	 *
+	 * @return array Array of test data
+	 */
 	public function category_with_pages_data()
 	{
 		return array(
@@ -222,10 +222,10 @@ 
 	}
 
 	/**
-	* Test base case scenario
-	*
-	* @dataProvider category_with_pages_data
-	*/
+	 * Test base case scenario
+	 *
+	 * @dataProvider category_with_pages_data
+	 */
 	public function test_category_with_pages($cat_id, $cat_name, $parent_cat_id, $parent_cat_name, $nb_links, $page = 1, $sort_days = 0)
 	{
 		$controller = $this->get_controller();

Spacing +1 added lines, -1 removed lines

@@ -18,7 +18,7 @@
 {
 	public function getDataSet()
 	{
-		return $this->createMySQLXMLDataSet(__DIR__ . './fixtures/fixture_categories.xml');
+		return $this->createMySQLXMLDataSet(__DIR__.'./fixtures/fixture_categories.xml');
 	}
 
 	/**

tests/routing/categories_routing_loader_test.php

Indentation +17 added lines, -17 removed lines

@@ -13,10 +13,10 @@ 
 class categories_routing_loader_test extends \phpbb_database_test_case
 {
 	/**
-	* Define the extensions to be tested
-	*
-	* @return array vendor/name of extension(s) to test
-	*/
+	 * Define the extensions to be tested
+	 *
+	 * @return array vendor/name of extension(s) to test
+	 */
 	static protected function setup_extensions()
 	{
 		return array('ernadoo/phpbbdirectory');
@@ -50,10 +50,10 @@ 
 	}
 
 	/**
-	* Get the route collection from the categories_loader
-	*
-	* @return \Symfony\Component\Routing\RouteCollection
-	*/
+	 * Get the route collection from the categories_loader
+	 *
+	 * @return \Symfony\Component\Routing\RouteCollection
+	 */
 	public function get_categories_route_collection()
 	{
 		$collection = $this->loader->load('ernadoo_phpbbdirectory_route_controller', 'pages_extension');
@@ -65,10 +65,10 @@ 
 	}
 
 	/**
-	* Data set for test_page_loader
-	*
-	* @return array
-	*/
+	 * Data set for test_page_loader
+	 *
+	 * @return array
+	 */
 	public function page_loader_data()
 	{
 		return array(
@@ -79,11 +79,11 @@ 
 	}
 
 	/**
-	* @dataProvider page_loader_data
-	*
-	* @param int    $id       Id of a categorie
-	* @param string $expected Expected route of a categorie
-	*/
+	 * @dataProvider page_loader_data
+	 *
+	 * @param int    $id       Id of a categorie
+	 * @param string $expected Expected route of a categorie
+	 */
 	public function test_page_loader($id, $expected)
 	{
 		// Get a route instance

Spacing +2 added lines, -2 removed lines

@@ -33,7 +33,7 @@ 
 
 	public function getDataSet()
 	{
-		return $this->createMySQLXMLDataSet(__DIR__ . '/fixtures/categories.xml');
+		return $this->createMySQLXMLDataSet(__DIR__.'/fixtures/categories.xml');
 	}
 
 	public function setUp()
@@ -87,7 +87,7 @@ 
 	public function test_page_loader($id, $expected)
 	{
 		// Get a route instance
-		$route = $this->collection->get('ernadoo_phpbbdirectory_dynamic_route_' . $id);
+		$route = $this->collection->get('ernadoo_phpbbdirectory_dynamic_route_'.$id);
 
 		// Assert the roue is an instance of Route
 		$this->assertInstanceOf('Symfony\Component\Routing\Route', $route, 'A route instance could not be made.');