Inspection of "update docblock and add logging" - Erdiko/erdiko - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( aa5b38...ae8892 )

by John

created 2017-01-26 19:09 UTC

Status

Indentation +47 added lines, -47 removed lines patch added patch discarded remove patch

@@ -24,65 +24,65 @@
 block discarded – undo
  * Hooks
  */
 \erdiko\core\ToroHook::add("404", function ($vars = array()) {
-	// Toro::serve Legacy
-	$vars['debug'] = \erdiko\core\ErrorHandler::isDebug();
-	if (empty($vars['message'])) {
-		$vars['message'] = "Sorry, we cannot find that page.";
-	}
-	if (empty($vars['error'])) {
-		$vars['error'] = $vars['message'];
-	}
-	if (!isset($vars['path_info'])) {
-		$vars['path_info'] = "";
-	}
+    // Toro::serve Legacy
+    $vars['debug'] = \erdiko\core\ErrorHandler::isDebug();
+    if (empty($vars['message'])) {
+        $vars['message'] = "Sorry, we cannot find that page.";
+    }
+    if (empty($vars['error'])) {
+        $vars['error'] = $vars['message'];
+    }
+    if (!isset($vars['path_info'])) {
+        $vars['path_info'] = "";
+    }
 
-	Erdiko::log(\Psr\Log\LogLevel::ERROR, "404 {$vars['path_info']} {$vars['error']}");
-	$vars['code'] = 404;
+    Erdiko::log(\Psr\Log\LogLevel::ERROR, "404 {$vars['path_info']} {$vars['error']}");
+    $vars['code'] = 404;
 
-	$theme = new \erdiko\core\Theme( 'bootstrap' );
-	$theme->addCss( 'font-awesome',
-		'//maxcdn.bootstrapcdn.com/font-awesome/4.1.0/css/font-awesome.min.css' );
-	$theme->addCss( 'font-awesome-animation',
-		'/themes/bootstrap/css/font-awesome-animation.css' );
+    $theme = new \erdiko\core\Theme( 'bootstrap' );
+    $theme->addCss( 'font-awesome',
+        '//maxcdn.bootstrapcdn.com/font-awesome/4.1.0/css/font-awesome.min.css' );
+    $theme->addCss( 'font-awesome-animation',
+        '/themes/bootstrap/css/font-awesome-animation.css' );
 
-	$response = new \erdiko\core\Response( $theme );
-	$response->setContent( \Erdiko::getView('error', $vars) );
-	$response->send();
+    $response = new \erdiko\core\Response( $theme );
+    $response->setContent( \Erdiko::getView('error', $vars) );
+    $response->send();
 });
 
 \erdiko\core\ToroHook::add("500", function ($vars = array()) {
-	// Toro::serve Legacy
-	$vars['debug'] = \erdiko\core\ErrorHandler::isDebug();
-	$vars['code'] = 500;
-	$vars['message'] = "Sorry, something went wrong.";
-	Erdiko::log(\Psr\Log\LogLevel::ERROR, "{$vars['code']}: {$vars['path_info']} {$vars['error']}");
+    // Toro::serve Legacy
+    $vars['debug'] = \erdiko\core\ErrorHandler::isDebug();
+    $vars['code'] = 500;
+    $vars['message'] = "Sorry, something went wrong.";
+    Erdiko::log(\Psr\Log\LogLevel::ERROR, "{$vars['code']}: {$vars['path_info']} {$vars['error']}");
 
-	$theme = new \erdiko\core\Theme( 'bootstrap' );
-	$theme->addCss( 'font-awesome',
-		'//maxcdn.bootstrapcdn.com/font-awesome/4.1.0/css/font-awesome.min.css' );
-	$theme->addCss( 'font-awesome-animation',
-		'/themes/bootstrap/css/font-awesome-animation.css' );
+    $theme = new \erdiko\core\Theme( 'bootstrap' );
+    $theme->addCss( 'font-awesome',
+        '//maxcdn.bootstrapcdn.com/font-awesome/4.1.0/css/font-awesome.min.css' );
+    $theme->addCss( 'font-awesome-animation',
+        '/themes/bootstrap/css/font-awesome-animation.css' );
 
-	$response = new \erdiko\core\Response( $theme );
-	$response->setContent( \Erdiko::getView('error', $vars) );
-	$response->send();
+    $response = new \erdiko\core\Response( $theme );
+    $response->setContent( \Erdiko::getView('error', $vars) );
+    $response->send();
 });
 
 // Error management & beautify output.
 \erdiko\core\ToroHook::add("general_error", function ($vars = array()) {
-	$vars['debug'] = \erdiko\core\ErrorHandler::isDebug();
-	if(!isset($vars['path_info'])){
-		$vars['path_info'] = $_SERVER['REQUEST_URI'];
-	}
-	Erdiko::log(\Psr\Log\LogLevel::ERROR, "{$vars['code']}: {$vars['path_info']} {$vars['error']}");
+    $vars['debug'] = \erdiko\core\ErrorHandler::isDebug();
+    if(!isset($vars['path_info'])){
+        $vars['path_info'] = $_SERVER['REQUEST_URI'];
+    }
+    Erdiko::log(\Psr\Log\LogLevel::ERROR, "{$vars['code']}: {$vars['path_info']} {$vars['error']}");
 
-	$theme = new \erdiko\core\Theme('bootstrap');
-	$theme->addCss('font-awesome',
-		'//maxcdn.bootstrapcdn.com/font-awesome/4.1.0/css/font-awesome.min.css');
-	$theme->addCss('font-awesome-animation',
-		'/themes/bootstrap/css/font-awesome-animation.css');
+    $theme = new \erdiko\core\Theme('bootstrap');
+    $theme->addCss('font-awesome',
+        '//maxcdn.bootstrapcdn.com/font-awesome/4.1.0/css/font-awesome.min.css');
+    $theme->addCss('font-awesome-animation',
+        '/themes/bootstrap/css/font-awesome-animation.css');
 
-	$response = new \erdiko\core\Response($theme);
-	$response->setContent(\Erdiko::getView('error', $vars));
-	$response->send();
+    $response = new \erdiko\core\Response($theme);
+    $response->setContent(\Erdiko::getView('error', $vars));
+    $response->send();
 });
\ No newline at end of file

Please login to merge, or discard this patch.

Spacing +18 added lines, -18 removed lines patch added patch discarded remove patch

@@ -23,7 +23,7 @@  discard block
 block discarded – undo
 /**
  * Hooks
  */
-\erdiko\core\ToroHook::add("404", function ($vars = array()) {
+\erdiko\core\ToroHook::add("404", function($vars = array()) {
 	// Toro::serve Legacy
 	$vars['debug'] = \erdiko\core\ErrorHandler::isDebug();
 	if (empty($vars['message'])) {
@@ -39,39 +39,39 @@  discard block
 block discarded – undo
 	Erdiko::log(\Psr\Log\LogLevel::ERROR, "404 {$vars['path_info']} {$vars['error']}");
 	$vars['code'] = 404;
 
-	$theme = new \erdiko\core\Theme( 'bootstrap' );
-	$theme->addCss( 'font-awesome',
-		'//maxcdn.bootstrapcdn.com/font-awesome/4.1.0/css/font-awesome.min.css' );
-	$theme->addCss( 'font-awesome-animation',
-		'/themes/bootstrap/css/font-awesome-animation.css' );
+	$theme = new \erdiko\core\Theme('bootstrap');
+	$theme->addCss('font-awesome',
+		'//maxcdn.bootstrapcdn.com/font-awesome/4.1.0/css/font-awesome.min.css');
+	$theme->addCss('font-awesome-animation',
+		'/themes/bootstrap/css/font-awesome-animation.css');
 
-	$response = new \erdiko\core\Response( $theme );
-	$response->setContent( \Erdiko::getView('error', $vars) );
+	$response = new \erdiko\core\Response($theme);
+	$response->setContent(\Erdiko::getView('error', $vars));
 	$response->send();
 });
 
-\erdiko\core\ToroHook::add("500", function ($vars = array()) {
+\erdiko\core\ToroHook::add("500", function($vars = array()) {
 	// Toro::serve Legacy
 	$vars['debug'] = \erdiko\core\ErrorHandler::isDebug();
 	$vars['code'] = 500;
 	$vars['message'] = "Sorry, something went wrong.";
 	Erdiko::log(\Psr\Log\LogLevel::ERROR, "{$vars['code']}: {$vars['path_info']} {$vars['error']}");
 
-	$theme = new \erdiko\core\Theme( 'bootstrap' );
-	$theme->addCss( 'font-awesome',
-		'//maxcdn.bootstrapcdn.com/font-awesome/4.1.0/css/font-awesome.min.css' );
-	$theme->addCss( 'font-awesome-animation',
-		'/themes/bootstrap/css/font-awesome-animation.css' );
+	$theme = new \erdiko\core\Theme('bootstrap');
+	$theme->addCss('font-awesome',
+		'//maxcdn.bootstrapcdn.com/font-awesome/4.1.0/css/font-awesome.min.css');
+	$theme->addCss('font-awesome-animation',
+		'/themes/bootstrap/css/font-awesome-animation.css');
 
-	$response = new \erdiko\core\Response( $theme );
-	$response->setContent( \Erdiko::getView('error', $vars) );
+	$response = new \erdiko\core\Response($theme);
+	$response->setContent(\Erdiko::getView('error', $vars));
 	$response->send();
 });
 
 // Error management & beautify output.
-\erdiko\core\ToroHook::add("general_error", function ($vars = array()) {
+\erdiko\core\ToroHook::add("general_error", function($vars = array()) {
 	$vars['debug'] = \erdiko\core\ErrorHandler::isDebug();
-	if(!isset($vars['path_info'])){
+	if (!isset($vars['path_info'])) {
 		$vars['path_info'] = $_SERVER['REQUEST_URI'];
 	}
 	Erdiko::log(\Psr\Log\LogLevel::ERROR, "{$vars['code']}: {$vars['path_info']} {$vars['error']}");

Please login to merge, or discard this patch.

public/default/index.php 1 patch

Indentation +2 added lines, -2 removed lines patch added patch discarded remove patch

@@ -12,8 +12,8 @@
 block discarded – undo
 include_once dirname(dirname(__DIR__))."/app/bootstrap.php";
 
 try {
-	\erdiko\core\ErrorHandler::init(); // Front-end error management
-	Erdiko::serve();
+    \erdiko\core\ErrorHandler::init(); // Front-end error management
+    Erdiko::serve();
 
 } catch (\Exception $e) {
     echo $e->getMessage();

Please login to merge, or discard this patch.

		@@ -24,65 +24,65 @@
		block discarded – undo
24	24	* Hooks
25	25	*/
26	26	\erdiko\core\ToroHook::add("404", function ($vars = array()) {
27		- // Toro::serve Legacy
28		- $vars['debug'] = \erdiko\core\ErrorHandler::isDebug();
29		- if (empty($vars['message'])) {
30		- $vars['message'] = "Sorry, we cannot find that page.";
31		- }
32		- if (empty($vars['error'])) {
33		- $vars['error'] = $vars['message'];
34		- }
35		- if (!isset($vars['path_info'])) {
36		- $vars['path_info'] = "";
37		- }
	27	+ // Toro::serve Legacy
	28	+ $vars['debug'] = \erdiko\core\ErrorHandler::isDebug();
	29	+ if (empty($vars['message'])) {
	30	+ $vars['message'] = "Sorry, we cannot find that page.";
	31	+ }
	32	+ if (empty($vars['error'])) {
	33	+ $vars['error'] = $vars['message'];
	34	+ }
	35	+ if (!isset($vars['path_info'])) {
	36	+ $vars['path_info'] = "";
	37	+ }
38	38
39		- Erdiko::log(\Psr\Log\LogLevel::ERROR, "404 {$vars['path_info']} {$vars['error']}");
40		- $vars['code'] = 404;
	39	+ Erdiko::log(\Psr\Log\LogLevel::ERROR, "404 {$vars['path_info']} {$vars['error']}");
	40	+ $vars['code'] = 404;
41	41
42		- $theme = new \erdiko\core\Theme( 'bootstrap' );
43		- $theme->addCss( 'font-awesome',
44		- '//maxcdn.bootstrapcdn.com/font-awesome/4.1.0/css/font-awesome.min.css' );
45		- $theme->addCss( 'font-awesome-animation',
46		- '/themes/bootstrap/css/font-awesome-animation.css' );
	42	+ $theme = new \erdiko\core\Theme( 'bootstrap' );
	43	+ $theme->addCss( 'font-awesome',
	44	+ '//maxcdn.bootstrapcdn.com/font-awesome/4.1.0/css/font-awesome.min.css' );
	45	+ $theme->addCss( 'font-awesome-animation',
	46	+ '/themes/bootstrap/css/font-awesome-animation.css' );
47	47
48		- $response = new \erdiko\core\Response( $theme );
49		- $response->setContent( \Erdiko::getView('error', $vars) );
50		- $response->send();
	48	+ $response = new \erdiko\core\Response( $theme );
	49	+ $response->setContent( \Erdiko::getView('error', $vars) );
	50	+ $response->send();
51	51	});
52	52
53	53	\erdiko\core\ToroHook::add("500", function ($vars = array()) {
54		- // Toro::serve Legacy
55		- $vars['debug'] = \erdiko\core\ErrorHandler::isDebug();
56		- $vars['code'] = 500;
57		- $vars['message'] = "Sorry, something went wrong.";
58		- Erdiko::log(\Psr\Log\LogLevel::ERROR, "{$vars['code']}: {$vars['path_info']} {$vars['error']}");
	54	+ // Toro::serve Legacy
	55	+ $vars['debug'] = \erdiko\core\ErrorHandler::isDebug();
	56	+ $vars['code'] = 500;
	57	+ $vars['message'] = "Sorry, something went wrong.";
	58	+ Erdiko::log(\Psr\Log\LogLevel::ERROR, "{$vars['code']}: {$vars['path_info']} {$vars['error']}");
59	59
60		- $theme = new \erdiko\core\Theme( 'bootstrap' );
61		- $theme->addCss( 'font-awesome',
62		- '//maxcdn.bootstrapcdn.com/font-awesome/4.1.0/css/font-awesome.min.css' );
63		- $theme->addCss( 'font-awesome-animation',
64		- '/themes/bootstrap/css/font-awesome-animation.css' );
	60	+ $theme = new \erdiko\core\Theme( 'bootstrap' );
	61	+ $theme->addCss( 'font-awesome',
	62	+ '//maxcdn.bootstrapcdn.com/font-awesome/4.1.0/css/font-awesome.min.css' );
	63	+ $theme->addCss( 'font-awesome-animation',
	64	+ '/themes/bootstrap/css/font-awesome-animation.css' );
65	65
66		- $response = new \erdiko\core\Response( $theme );
67		- $response->setContent( \Erdiko::getView('error', $vars) );
68		- $response->send();
	66	+ $response = new \erdiko\core\Response( $theme );
	67	+ $response->setContent( \Erdiko::getView('error', $vars) );
	68	+ $response->send();
69	69	});
70	70
71	71	// Error management & beautify output.
72	72	\erdiko\core\ToroHook::add("general_error", function ($vars = array()) {
73		- $vars['debug'] = \erdiko\core\ErrorHandler::isDebug();
74		- if(!isset($vars['path_info'])){
75		- $vars['path_info'] = $_SERVER['REQUEST_URI'];
76		- }
77		- Erdiko::log(\Psr\Log\LogLevel::ERROR, "{$vars['code']}: {$vars['path_info']} {$vars['error']}");
	73	+ $vars['debug'] = \erdiko\core\ErrorHandler::isDebug();
	74	+ if(!isset($vars['path_info'])){
	75	+ $vars['path_info'] = $_SERVER['REQUEST_URI'];
	76	+ }
	77	+ Erdiko::log(\Psr\Log\LogLevel::ERROR, "{$vars['code']}: {$vars['path_info']} {$vars['error']}");
78	78
79		- $theme = new \erdiko\core\Theme('bootstrap');
80		- $theme->addCss('font-awesome',
81		- '//maxcdn.bootstrapcdn.com/font-awesome/4.1.0/css/font-awesome.min.css');
82		- $theme->addCss('font-awesome-animation',
83		- '/themes/bootstrap/css/font-awesome-animation.css');
	79	+ $theme = new \erdiko\core\Theme('bootstrap');
	80	+ $theme->addCss('font-awesome',
	81	+ '//maxcdn.bootstrapcdn.com/font-awesome/4.1.0/css/font-awesome.min.css');
	82	+ $theme->addCss('font-awesome-animation',
	83	+ '/themes/bootstrap/css/font-awesome-animation.css');
84	84
85		- $response = new \erdiko\core\Response($theme);
86		- $response->setContent(\Erdiko::getView('error', $vars));
87		- $response->send();
	85	+ $response = new \erdiko\core\Response($theme);
	86	+ $response->setContent(\Erdiko::getView('error', $vars));
	87	+ $response->send();
88	88	});
89	89	\ No newline at end of file

		@@ -23,7 +23,7 @@ discard block
		block discarded – undo
23	23	/**
24	24	* Hooks
25	25	*/
26		-\erdiko\core\ToroHook::add("404", function ($vars = array()) {
	26	+\erdiko\core\ToroHook::add("404", function($vars = array()) {
27	27	// Toro::serve Legacy
28	28	$vars['debug'] = \erdiko\core\ErrorHandler::isDebug();
29	29	if (empty($vars['message'])) {
		@@ -39,39 +39,39 @@ discard block
		block discarded – undo
39	39	Erdiko::log(\Psr\Log\LogLevel::ERROR, "404 {$vars['path_info']} {$vars['error']}");
40	40	$vars['code'] = 404;
41	41
42		- $theme = new \erdiko\core\Theme( 'bootstrap' );
43		- $theme->addCss( 'font-awesome',
44		- '//maxcdn.bootstrapcdn.com/font-awesome/4.1.0/css/font-awesome.min.css' );
45		- $theme->addCss( 'font-awesome-animation',
46		- '/themes/bootstrap/css/font-awesome-animation.css' );
	42	+ $theme = new \erdiko\core\Theme('bootstrap');
	43	+ $theme->addCss('font-awesome',
	44	+ '//maxcdn.bootstrapcdn.com/font-awesome/4.1.0/css/font-awesome.min.css');
	45	+ $theme->addCss('font-awesome-animation',
	46	+ '/themes/bootstrap/css/font-awesome-animation.css');
47	47
48		- $response = new \erdiko\core\Response( $theme );
49		- $response->setContent( \Erdiko::getView('error', $vars) );
	48	+ $response = new \erdiko\core\Response($theme);
	49	+ $response->setContent(\Erdiko::getView('error', $vars));
50	50	$response->send();
51	51	});
52	52
53		-\erdiko\core\ToroHook::add("500", function ($vars = array()) {
	53	+\erdiko\core\ToroHook::add("500", function($vars = array()) {
54	54	// Toro::serve Legacy
55	55	$vars['debug'] = \erdiko\core\ErrorHandler::isDebug();
56	56	$vars['code'] = 500;
57	57	$vars['message'] = "Sorry, something went wrong.";
58	58	Erdiko::log(\Psr\Log\LogLevel::ERROR, "{$vars['code']}: {$vars['path_info']} {$vars['error']}");
59	59
60		- $theme = new \erdiko\core\Theme( 'bootstrap' );
61		- $theme->addCss( 'font-awesome',
62		- '//maxcdn.bootstrapcdn.com/font-awesome/4.1.0/css/font-awesome.min.css' );
63		- $theme->addCss( 'font-awesome-animation',
64		- '/themes/bootstrap/css/font-awesome-animation.css' );
	60	+ $theme = new \erdiko\core\Theme('bootstrap');
	61	+ $theme->addCss('font-awesome',
	62	+ '//maxcdn.bootstrapcdn.com/font-awesome/4.1.0/css/font-awesome.min.css');
	63	+ $theme->addCss('font-awesome-animation',
	64	+ '/themes/bootstrap/css/font-awesome-animation.css');
65	65
66		- $response = new \erdiko\core\Response( $theme );
67		- $response->setContent( \Erdiko::getView('error', $vars) );
	66	+ $response = new \erdiko\core\Response($theme);
	67	+ $response->setContent(\Erdiko::getView('error', $vars));
68	68	$response->send();
69	69	});
70	70
71	71	// Error management & beautify output.
72		-\erdiko\core\ToroHook::add("general_error", function ($vars = array()) {
	72	+\erdiko\core\ToroHook::add("general_error", function($vars = array()) {
73	73	$vars['debug'] = \erdiko\core\ErrorHandler::isDebug();
74		- if(!isset($vars['path_info'])){
	74	+ if (!isset($vars['path_info'])) {
75	75	$vars['path_info'] = $_SERVER['REQUEST_URI'];
76	76	}
77	77	Erdiko::log(\Psr\Log\LogLevel::ERROR, "{$vars['code']}: {$vars['path_info']} {$vars['error']}");

		@@ -12,8 +12,8 @@
		block discarded – undo
12	12	include_once dirname(dirname(__DIR__))."/app/bootstrap.php";
13	13
14	14	try {
15		- \erdiko\core\ErrorHandler::init(); // Front-end error management
16		- Erdiko::serve();
	15	+ \erdiko\core\ErrorHandler::init(); // Front-end error management
	16	+ Erdiko::serve();
17	17
18	18	} catch (\Exception $e) {
19	19	echo $e->getMessage();

Erdiko / erdiko

Push — master ( aa5b38...ae8892 )

Status

Category

Indentation +47 added lines, -47 removed lines patch added patch discarded remove patch

Spacing +18 added lines, -18 removed lines patch added patch discarded remove patch

Indentation +2 added lines, -2 removed lines patch added patch discarded remove patch