Ecodev / my-ichtus

tests/ApplicationTest/Service/AccountingTest.php

Indentation +1 added lines, -3 removed lines

@@ -82,6 +82,4 @@
         }
 
         $this->expectExceptionMessage('Le bouclement a déjà été fait au 2019-12-31 23:59:59');
-        $this->accounting->close($closingDate, $output);
-    }
-}
+        $this->accounting->close($closingDate, $output
\ No newline at end of file

Switch Indentation +1 added lines, -3 removed lines

@@ -82,6 +82,4 @@
         }
 
         $this->expectExceptionMessage('Le bouclement a déjà été fait au 2019-12-31 23:59:59');
-        $this->accounting->close($closingDate, $output);
-    }
-}
+        $this->accounting->close($closingDate, $output
\ No newline at end of file

Spacing +1 added lines, -3 removed lines

@@ -82,6 +82,4 @@
         }
 
         $this->expectExceptionMessage('Le bouclement a déjà été fait au 2019-12-31 23:59:59');
-        $this->accounting->close($closingDate, $output);
-    }
-}
+        $this->accounting->close($closingDate, $output
\ No newline at end of file

Braces +1 added lines, -3 removed lines

@@ -82,6 +82,4 @@
         }
 
         $this->expectExceptionMessage('Le bouclement a déjà été fait au 2019-12-31 23:59:59');
-        $this->accounting->close($closingDate, $output);
-    }
-}
+        $this->accounting->close($closingDate, $output
\ No newline at end of file

Upper-Lower-Casing +1 added lines, -3 removed lines

@@ -82,6 +82,4 @@
         }
 
         $this->expectExceptionMessage('Le bouclement a déjà été fait au 2019-12-31 23:59:59');
-        $this->accounting->close($closingDate, $output);
-    }
-}
+        $this->accounting->close($closingDate, $output
\ No newline at end of file

config/autoload/global.php

Spacing +1 added lines, -1 removed lines

@@ -27,7 +27,7 @@
     ],
     'banking' => [
         'iban' => 'CH2730000001200061375', // QR-IBAN without spaces (eg: CH7030123036078110002)
-        'paymentTo' => 'PostFinance AG, 3030 Bern',  // Bank coordinate the payment will be made to, eg: 'Banque Alternative Suisse SA'
+        'paymentTo' => 'PostFinance AG, 3030 Bern', // Bank coordinate the payment will be made to, eg: 'Banque Alternative Suisse SA'
         'paymentFor' => 'Club nautique Ichtus' . PHP_EOL . '2072 St-Blaise', // Name and address of account holder, 2-3 lines separated by \n
     ],
     'accounting' => [

server/Application/Repository/AccountRepository.php

Indentation +1 added lines, -3 removed lines

@@ -198,6 +198,4 @@
 
         $count = $this->getEntityManager()->getConnection()->executeStatement($sql);
 
-        return $count;
-    }
-}
+        return $count
\ No newline at end of file

Switch Indentation +1 added lines, -3 removed lines

@@ -198,6 +198,4 @@
 
         $count = $this->getEntityManager()->getConnection()->executeStatement($sql);
 
-        return $count;
-    }
-}
+        return $count
\ No newline at end of file

Braces +1 added lines, -3 removed lines

@@ -198,6 +198,4 @@
 
         $count = $this->getEntityManager()->getConnection()->executeStatement($sql);
 
-        return $count;
-    }
-}
+        return $count
\ No newline at end of file

Upper-Lower-Casing +1 added lines, -3 removed lines

@@ -198,6 +198,4 @@
 
         $count = $this->getEntityManager()->getConnection()->executeStatement($sql);
 
-        return $count;
-    }
-}
+        return $count
\ No newline at end of file

Spacing +4 added lines, -6 removed lines

@@ -68,7 +68,7 @@ 
      */
     public function getOneById(int $id): Account
     {
-        $account = $this->getAclFilter()->runWithoutAcl(fn () => $this->findOneById($id));
+        $account = $this->getAclFilter()->runWithoutAcl(fn() => $this->findOneById($id));
 
         if (!$account) {
             throw new Exception('Account #' . $id . ' not found');
@@ -95,7 +95,7 @@ 
             $user = $user->getOwner();
         }
 
-        $account = $this->getAclFilter()->runWithoutAcl(fn () => $this->findOneByOwner($user));
+        $account = $this->getAclFilter()->runWithoutAcl(fn() => $this->findOneByOwner($user));
 
         if (!$account) {
             $account = new Account();
@@ -106,7 +106,7 @@ 
 
             $config = $container->get('config');
             $parentCode = (int) $config['accounting']['customerDepositsAccountCode'];
-            $parent = $this->getAclFilter()->runWithoutAcl(fn () => $this->findOneByCode($parentCode));
+            $parent = $this->getAclFilter()->runWithoutAcl(fn() => $this->findOneByCode($parentCode));
 
             // Find the max account code, using the liability parent code as prefix
             if (!$this->maxCode) {
@@ -192,6 +192,4 @@ 
 
         $count = $this->getEntityManager()->getConnection()->executeStatement($sql);
 
-        return $count;
-    }
-}
+        return $count
\ No newline at end of file

server/Application/Service/Accounting.php

Indentation +1 added lines, -6 removed lines

@@ -304,9 +304,4 @@
                     $user->getId(),
                     $user->getName(),
                     $user->getOwner()->getId(),
-                    $user->getOwner()->getName()
-                )
-            );
-        }
-    }
-}
+                    $user->getOwner
\ No newline at end of file

Switch Indentation +1 added lines, -6 removed lines

@@ -304,9 +304,4 @@
                     $user->getId(),
                     $user->getName(),
                     $user->getOwner()->getId(),
-                    $user->getOwner()->getName()
-                )
-            );
-        }
-    }
-}
+                    $user->getOwner
\ No newline at end of file

Spacing +1 added lines, -6 removed lines

@@ -304,9 +304,4 @@
                     $user->getId(),
                     $user->getName(),
                     $user->getOwner()->getId(),
-                    $user->getOwner()->getName()
-                )
-            );
-        }
-    }
-}
+                    $user->getOwner
\ No newline at end of file

Braces +1 added lines, -6 removed lines

@@ -304,9 +304,4 @@
                     $user->getId(),
                     $user->getName(),
                     $user->getOwner()->getId(),
-                    $user->getOwner()->getName()
-                )
-            );
-        }
-    }
-}
+                    $user->getOwner
\ No newline at end of file

Upper-Lower-Casing +1 added lines, -6 removed lines

@@ -304,9 +304,4 @@
                     $user->getId(),
                     $user->getName(),
                     $user->getOwner()->getId(),
-                    $user->getOwner()->getName()
-                )
-            );
-        }
-    }
-}
+                    $user->getOwner
\ No newline at end of file

server/Application/Api/Input/Operator/BookableBookingCount/AbstractOperatorType.php

Indentation +1 added lines, -5 removed lines

@@ -49,8 +49,4 @@
                         EXISTS (
                             SELECT $bookingAlias.id FROM $bookingClass $bookingAlias
                             WHERE $bookingAlias.bookable = $alias.id AND $bookingAlias.endDate IS NULL
-                            HAVING COUNT($bookingAlias.id) $dqlOperator :$param
-                        )
-            STRING;
-    }
-}
+                            HAVING COUNT($bookingAlias.id) $dqlOperator :$param
\ No newline at end of file

Switch Indentation +1 added lines, -5 removed lines

@@ -49,8 +49,4 @@
                         EXISTS (
                             SELECT $bookingAlias.id FROM $bookingClass $bookingAlias
                             WHERE $bookingAlias.bookable = $alias.id AND $bookingAlias.endDate IS NULL
-                            HAVING COUNT($bookingAlias.id) $dqlOperator :$param
-                        )
-            STRING;
-    }
-}
+                            HAVING COUNT($bookingAlias.id) $dqlOperator :$param
\ No newline at end of file

Spacing +1 added lines, -5 removed lines

@@ -49,8 +49,4 @@
                         EXISTS (
                             SELECT $bookingAlias.id FROM $bookingClass $bookingAlias
                             WHERE $bookingAlias.bookable = $alias.id AND $bookingAlias.endDate IS NULL
-                            HAVING COUNT($bookingAlias.id) $dqlOperator :$param
-                        )
-            STRING;
-    }
-}
+                            HAVING COUNT($bookingAlias.id) $dqlOperator :$param
\ No newline at end of file

Braces +1 added lines, -5 removed lines

@@ -49,8 +49,4 @@
                         EXISTS (
                             SELECT $bookingAlias.id FROM $bookingClass $bookingAlias
                             WHERE $bookingAlias.bookable = $alias.id AND $bookingAlias.endDate IS NULL
-                            HAVING COUNT($bookingAlias.id) $dqlOperator :$param
-                        )
-            STRING;
-    }
-}
+                            HAVING COUNT($bookingAlias.id) $dqlOperator :$param
\ No newline at end of file

Upper-Lower-Casing +1 added lines, -5 removed lines

@@ -49,8 +49,4 @@
                         EXISTS (
                             SELECT $bookingAlias.id FROM $bookingClass $bookingAlias
                             WHERE $bookingAlias.bookable = $alias.id AND $bookingAlias.endDate IS NULL
-                            HAVING COUNT($bookingAlias.id) $dqlOperator :$param
-                        )
-            STRING;
-    }
-}
+                            HAVING COUNT($bookingAlias.id) $dqlOperator :$param
\ No newline at end of file

bin/generate-client-configuration.php

Indentation +1 added lines, -1 removed lines

@@ -19,4 +19,4 @@
     export const localConfig = $json;
     STRING;
 
-file_put_contents('client/app/shared/generated-config.ts', $code);
+file_put_contents('client/app/shared/generated-config.ts', $code
\ No newline at end of file

Switch Indentation +1 added lines, -1 removed lines

@@ -19,4 +19,4 @@
     export const localConfig = $json;
     STRING;
 
-file_put_contents('client/app/shared/generated-config.ts', $code);
+file_put_contents('client/app/shared/generated-config.ts', $code
\ No newline at end of file

Spacing +1 added lines, -1 removed lines

@@ -19,4 +19,4 @@
     export const localConfig = $json;
     STRING;
 
-file_put_contents('client/app/shared/generated-config.ts', $code);
+file_put_contents('client/app/shared/generated-config.ts', $code
\ No newline at end of file

Braces +1 added lines, -1 removed lines

@@ -19,4 +19,4 @@
     export const localConfig = $json;
     STRING;
 
-file_put_contents('client/app/shared/generated-config.ts', $code);
+file_put_contents('client/app/shared/generated-config.ts', $code
\ No newline at end of file

Upper-Lower-Casing +1 added lines, -1 removed lines

@@ -19,4 +19,4 @@
     export const localConfig = $json;
     STRING;
 
-file_put_contents('client/app/shared/generated-config.ts', $code);
+file_put_contents('client/app/shared/generated-config.ts', $code
\ No newline at end of file

server/Application/Service/MessageQueuer.php

Spacing +2 added lines, -2 removed lines

@@ -118,7 +118,7 @@ 
     private function queueBalanceForEachUsers(array $users): int
     {
         foreach ($users as $user) {
-            $bookables = $user->getRunningBookings()->map(fn (Booking $booking) => $booking->getBookable());
+            $bookables = $user->getRunningBookings()->map(fn(Booking $booking) => $booking->getBookable());
 
             $this->queueBalance($user, $bookables);
         }
@@ -153,7 +153,7 @@ 
 
         // Fallback to family owner if any
         if (!$email && $user->getOwner()) {
-            $email = $this->userRepository->getAclFilter()->runWithoutAcl(fn () => $user->getOwner()->getEmail());
+            $email = $this->userRepository->getAclFilter()->runWithoutAcl(fn() => $user->getOwner()->getEmail());
 
             $this->toFamilyOwner = true;
         }

server/Application/Model/User.php

Spacing +1 added lines, -1 removed lines

@@ -529,7 +529,7 @@
      */
     public function getRunningBookings(): Collection
     {
-        return $this->bookings->filter(fn (Booking $booking) => $booking->getStatus() === BookingStatusType::BOOKED && $booking->getEndDate() === null);
+        return $this->bookings->filter(fn(Booking $booking) => $booking->getStatus() === BookingStatusType::BOOKED && $booking->getEndDate() === null);
     }
 
     /**

server/Application/Model/Bookable.php

Spacing +2 added lines, -2 removed lines

@@ -370,7 +370,7 @@ 
         }
 
         // Only consider approved and unterminated bookings
-        $bookings = $this->getBookings()->filter(fn (Booking $booking): bool => !$booking->getEndDate() && $booking->getStatus() !== BookingStatusType::APPLICATION)->toArray();
+        $bookings = $this->getBookings()->filter(fn(Booking $booking): bool => !$booking->getEndDate() && $booking->getStatus() !== BookingStatusType::APPLICATION)->toArray();
 
         return $bookings;
     }
@@ -402,7 +402,7 @@ 
             return [];
         }
 
-        $bookings = $this->getBookings()->filter(fn (Booking $booking): bool => !$booking->getEndDate())->toArray();
+        $bookings = $this->getBookings()->filter(fn(Booking $booking): bool => !$booking->getEndDate())->toArray();
 
         return $bookings;
     }