EGroupware / egroupware

api/src/Mail/Smtp/Ldap.php

Spacing +43 added lines, -44 removed lines

@@ -164,7 +164,7 @@ 
 	 *
 	 * @param string $defaultDomain =null
 	 */
-	function __construct($defaultDomain=null)
+	function __construct($defaultDomain = null)
 	{
 		parent::__construct($defaultDomain);
 
@@ -212,9 +212,8 @@ 
 	 */
 	function addAccount($_hookValues)
 	{
-		$mailLocalAddress = $_hookValues['account_email'] ? $_hookValues['account_email'] :
-			Api\Accounts::email($_hookValues['account_firstname'],
-				$_hookValues['account_lastname'],$_hookValues['account_lid'],$this->defaultDomain);
+		$mailLocalAddress = $_hookValues['account_email'] ? $_hookValues['account_email'] : Api\Accounts::email($_hookValues['account_firstname'],
+				$_hookValues['account_lastname'], $_hookValues['account_lid'], $this->defaultDomain);
 
 		$ds = $this->getLdapConnection();
 
@@ -226,13 +225,13 @@ 
 		}
 		$allValues 	= ldap_get_entries($ds, $sri);
 		$accountDN 	= $allValues[0]['dn'];
-		$objectClasses	= $allValues[0]['objectclass'];
+		$objectClasses = $allValues[0]['objectclass'];
 		unset($objectClasses['count']);
 
 		// add our mail schema, if not already set
-		if(!in_array(static::SCHEMA,$objectClasses) && !in_array(strtolower(static::SCHEMA),$objectClasses))
+		if (!in_array(static::SCHEMA, $objectClasses) && !in_array(strtolower(static::SCHEMA), $objectClasses))
 		{
-			$objectClasses[]	= static::SCHEMA;
+			$objectClasses[] = static::SCHEMA;
 		}
 		// the new code for postfix+cyrus+ldap
 		$newData = array(
@@ -263,7 +262,7 @@ 
 		{
 			error_log(__METHOD__.'('.array2string(func_get_args()).") --> ldap_mod_replace(,'$accountDN',".
 				array2string($newData).') returning '.array2string($ret).
-				(!$ret?' ('.ldap_error($ds).')':''));
+				(!$ret ? ' ('.ldap_error($ds).')' : ''));
 		}
 		return $ret;
 	}
@@ -277,7 +276,7 @@ 
 	 */
 	function addAccountExtra(array $_hookValues, array $allValues, array &$newData)
 	{
-		unset($_hookValues, $allValues, $newData);	// not used, but required by function signature
+		unset($_hookValues, $allValues, $newData); // not used, but required by function signature
 	}
 
 	/**
@@ -288,24 +287,24 @@ 
 	 */
 	function getAccountEmailAddress($_accountName)
 	{
-		$emailAddresses	= array();
+		$emailAddresses = array();
 		$ds = $this->getLdapConnection();
 		$filter = '(&'.static::USER_FILTER.'('.static::USER_ATTR.'='.Api\Ldap::quote($_accountName).'))';
-		$attributes	= array('dn', static::MAIL_ATTR, static::ALIAS_ATTR);
+		$attributes = array('dn', static::MAIL_ATTR, static::ALIAS_ATTR);
 		$sri = @ldap_search($ds, $this->search_base, $filter, $attributes);
 
 		if ($sri)
 		{
-			$realName = trim($GLOBALS['egw_info']['user']['account_firstname'] . (!empty($GLOBALS['egw_info']['user']['account_firstname']) ? ' ' : '') . $GLOBALS['egw_info']['user']['account_lastname']);
+			$realName = trim($GLOBALS['egw_info']['user']['account_firstname'].(!empty($GLOBALS['egw_info']['user']['account_firstname']) ? ' ' : '').$GLOBALS['egw_info']['user']['account_lastname']);
 			$allValues = ldap_get_entries($ds, $sri);
 
-			if(isset($allValues[0][static::MAIL_ATTR]))
+			if (isset($allValues[0][static::MAIL_ATTR]))
 			{
-				foreach($allValues[0][static::MAIL_ATTR] as $key => $value)
+				foreach ($allValues[0][static::MAIL_ATTR] as $key => $value)
 				{
 					if ($key === 'count') continue;
 
-					$emailAddresses[] = array (
+					$emailAddresses[] = array(
 						'name'		=> $realName,
 						'address'	=> $value,
 						'type'		=> !$key ? 'default' : 'alternate',
@@ -314,7 +313,7 @@ 
 			}
 			if (static::ALIAS_ATTR && isset($allValues[0][static::ALIAS_ATTR]))
 			{
-				foreach(self::getAttributePrefix($allValues[0][static::ALIAS_ATTR], static::ALIAS_PREFIX) as $value)
+				foreach (self::getAttributePrefix($allValues[0][static::ALIAS_ATTR], static::ALIAS_PREFIX) as $value)
 				{
 					$emailAddresses[] = array(
 						'name'		=> $realName,
@@ -341,7 +340,7 @@ 
 	 * @return array with values for keys 'mailLocalAddress', 'mailAlternateAddress' (array), 'mailForwardingAddress' (array),
 	 * 	'accountStatus' ("active"), 'quotaLimit' and 'deliveryMode' ("forwardOnly")
 	 */
-	function getUserData($user, $match_uid_at_domain=false)
+	function getUserData($user, $match_uid_at_domain = false)
 	{
 		$userData = array(
 			'mailbox' => array(),
@@ -401,7 +400,7 @@ 
 			$allValues = ldap_get_entries($ldap, $sri);
 			if ($this->debug) error_log(__METHOD__."('$user') --> ldap_search(, '$this->search_base', '$filter') --> ldap_get_entries=".array2string($allValues[0]));
 
-			foreach($allValues as $key => $values)
+			foreach ($allValues as $key => $values)
 			{
 				if ($key === 'count') continue;
 
@@ -504,16 +503,16 @@ 
 					// remember if server returned forward-attribute
 					$this->forward_attr_returned = isset($values[static::FORWARD_ATTR]);
 
-					$userData['mailForwardingAddress']	= self::getAttributePrefix($values[static::FORWARD_ATTR], static::FORWARD_PREFIX);
+					$userData['mailForwardingAddress'] = self::getAttributePrefix($values[static::FORWARD_ATTR], static::FORWARD_PREFIX);
 				}
 
-				if (static::MAILBOX_ATTR) $userData['mailMessageStore']	= $values[static::MAILBOX_ATTR][0];
+				if (static::MAILBOX_ATTR) $userData['mailMessageStore'] = $values[static::MAILBOX_ATTR][0];
 
 				$userData['deliveryMode'] = $deliveryMode;
 
 				// eg. suse stores all email addresses as aliases
 				if (static::REQUIRE_MAIL_AS_ALIAS &&
-					($k = array_search($userData['mailLocalAddress'],$userData['mailAlternateAddress'])) !== false)
+					($k = array_search($userData['mailLocalAddress'], $userData['mailAlternateAddress'])) !== false)
 				{
 					unset($userData['mailAlternateAddress'][$k]);
 					$userData['mailAlternateAddress'] = array_values($userData['mailAlternateAddress']);
@@ -547,9 +546,9 @@ 
 	 * @return boolean true on success, false on error writing to ldap
 	 */
 	function setUserData($_uidnumber, array $_mailAlternateAddress, array $_mailForwardingAddress, $_deliveryMode,
-		$_accountStatus, $_mailLocalAddress, $_quota, $_forwarding_only=false, $_setMailbox=null)
+		$_accountStatus, $_mailLocalAddress, $_quota, $_forwarding_only = false, $_setMailbox = null)
 	{
-		unset($_forwarding_only);	// not used
+		unset($_forwarding_only); // not used
 
 		if (static::USERID_ATTR)
 		{
@@ -569,15 +568,15 @@ 
 		$allValues 	= ldap_get_entries($ldap, $sri);
 
 		$accountDN 	= $allValues[0]['dn'];
-		$uid	   	= $allValues[0][static::USER_ATTR][0];
-		$objectClasses	= $allValues[0]['objectclass'];
+		$uid = $allValues[0][static::USER_ATTR][0];
+		$objectClasses = $allValues[0]['objectclass'];
 
 		unset($objectClasses['count']);
 
-		if(!in_array(static::SCHEMA,$objectClasses) && !in_array(strtolower(static::SCHEMA),$objectClasses))
+		if (!in_array(static::SCHEMA, $objectClasses) && !in_array(strtolower(static::SCHEMA), $objectClasses))
 		{
-			$objectClasses[]	= static::SCHEMA;
-			$newData['objectclass']	= $objectClasses;
+			$objectClasses[] = static::SCHEMA;
+			$newData['objectclass'] = $objectClasses;
 		}
 
 		sort($_mailAlternateAddress);
@@ -590,7 +589,7 @@ 
 			self::setAttributePrefix($newData[static::ALIAS_ATTR], $_mailAlternateAddress, static::ALIAS_PREFIX);
 
 			// all email must be stored as alias for suse
-			if (static::REQUIRE_MAIL_AS_ALIAS && !in_array($_mailLocalAddress,(array)$_mailAlternateAddress))
+			if (static::REQUIRE_MAIL_AS_ALIAS && !in_array($_mailLocalAddress, (array)$_mailAlternateAddress))
 			{
 				self::setAttributePrefix($newData[static::ALIAS_ATTR], $_mailLocalAddress, static::ALIAS_PREFIX);
 			}
@@ -628,12 +627,12 @@ 
 		if (static::QUOTA_ATTR)
 		{
 			self::setAttributePrefix($newData[static::QUOTA_ATTR],
-				(int)$_quota > 0 ? (int)$_quota*static::QUOTA_FACTOR : array(), static::QUOTA_PREFIX);
+				(int)$_quota > 0 ? (int)$_quota * static::QUOTA_FACTOR : array(), static::QUOTA_PREFIX);
 		}
 		// does schema support enabling/disabling mail via attribute
 		if (static::MAIL_ENABLE_ATTR)
 		{
-			$newData[static::MAIL_ENABLE_ATTR]	= $_accountStatus ?
+			$newData[static::MAIL_ENABLE_ATTR] = $_accountStatus ?
 				(static::MAIL_ENABLED == self::MAIL_ENABLED_USE_MAIL ? $_mailLocalAddress : static::MAIL_ENABLED) : array();
 		}
 		// if we have no mail-enabled attribute, but require primary mail in aliases-attr
@@ -681,7 +680,7 @@ 
 			$uid = $GLOBALS['egw']->accounts->id2name($_accountID);
 			$filter = '(&'.static::USER_FILTER.'('.static::USER_ATTR.'='.Api\Ldap::quote($uid).'))';
 		}
-		$attributes	= array('dn', static::MAIL_ATTR, static::FORWARD_ATTR, 'objectclass');
+		$attributes = array('dn', static::MAIL_ATTR, static::FORWARD_ATTR, 'objectclass');
 		if (static::FORWARD_ONLY_ATTR)
 		{
 			$attributes[] = static::FORWARD_ONLY_ATTR;
@@ -692,12 +691,12 @@ 
 		{
 			$newData = array();
 			$allValues = ldap_get_entries($ds, $sri);
-			$objectClasses  = $allValues[0]['objectclass'];
-			$newData['objectclass']	= $allValues[0]['objectclass'];
+			$objectClasses = $allValues[0]['objectclass'];
+			$newData['objectclass'] = $allValues[0]['objectclass'];
 
 			unset($newData['objectclass']['count']);
 
-			if(!in_array(static::SCHEMA,$objectClasses))
+			if (!in_array(static::SCHEMA, $objectClasses))
 			{
 				$newData['objectclass'][] = static::SCHEMA;
 			}
@@ -707,9 +706,9 @@ 
 				$newData[static::FORWARD_ATTR] = $allValues[0][static::FORWARD_ATTR];
 				$forwards = self::getAttributePrefix($newData[static::FORWARD_ATTR], static::FORWARD_PREFIX);
 
-				if(!empty($_forwardingAddress))
+				if (!empty($_forwardingAddress))
 				{
-					if($forwards)
+					if ($forwards)
 					{
 						if (!is_array($_forwardingAddress))
 						{
@@ -752,7 +751,7 @@ 
 			}
 			if ($this->debug) error_log(__METHOD__.'('.array2string(func_get_args()).") --> ldap_mod_replace(,'{$allValues[0]['dn']}',".array2string($newData).')');
 
-			return ldap_modify ($ds, $allValues[0]['dn'], $newData);
+			return ldap_modify($ds, $allValues[0]['dn'], $newData);
 		}
 	}
 
@@ -794,9 +793,9 @@ 
 		unset($entries['count']);
 
 		$mailboxes = array();
-		foreach($entries as $entry)
+		foreach ($entries as $entry)
 		{
-			if ($entry[static::USER_ATTR][0] == 'anonymous') continue;	// anonymous is never a mail-user!
+			if ($entry[static::USER_ATTR][0] == 'anonymous') continue; // anonymous is never a mail-user!
 			list($mailbox) = explode('@', $entry[static::MAILBOX_ATTR ? static::MAILBOX_ATTR : static::MAIL_ATTR][0]);
 			$mailboxes[$entry[static::USER_ATTR][0]] = $mailbox;
 		}
@@ -810,13 +809,13 @@ 
 	 * @param string|array $values value(s) to set
 	 * @param string $prefix ='' prefix to use or ''
 	 */
-	protected static function setAttributePrefix(&$attribute, $values, $prefix='')
+	protected static function setAttributePrefix(&$attribute, $values, $prefix = '')
 	{
 		//$attribute_in = $attribute;
 		if (empty($attribute)) $attribute = array();
 		if (!is_array($attribute)) $attribute = (array)$attribute;
 
-		foreach((array)$values as $value)
+		foreach ((array)$values as $value)
 		{
 			$attribute[] = $prefix.$value;
 		}
@@ -831,7 +830,7 @@ 
 	 * @param boolean $remove =true remove returned values from $attribute
 	 * @return array with values (prefix removed) or array() if nothing found
 	 */
-	protected static function getAttributePrefix(&$attribute, $prefix='', $remove=true)
+	protected static function getAttributePrefix(&$attribute, $prefix = '', $remove = true)
 	{
 		//$attribute_in = $attribute;
 		$values = array();
@@ -840,7 +839,7 @@ 
 		{
 			unset($attribute['count']);
 
-			foreach($attribute as $key => $value)
+			foreach ($attribute as $key => $value)
 			{
 				if (!$prefix || stripos($value, $prefix) === 0)
 				{