EGroupware / egroupware

api/src/Storage.php

Spacing +108 added lines, -110 removed lines

@@ -118,41 +118,41 @@ 
 	 * @param boolean $allow_multiple_values =false should we allow AND store multiple values (1:N relations)
 	 * @param string $timestamp_type =null default null=leave them as is, 'ts'|'integer' use integer unix timestamps, 'object' use DateTime objects
 	 */
-	function __construct($app,$table,$extra_table,$column_prefix='',
-		$extra_key='_name',$extra_value='_value',$extra_id='_id',
-		Db $db=null,$no_clone=true,$allow_multiple_values=false,$timestamp_type=null)
+	function __construct($app, $table, $extra_table, $column_prefix = '',
+		$extra_key = '_name', $extra_value = '_value', $extra_id = '_id',
+		Db $db = null, $no_clone = true, $allow_multiple_values = false, $timestamp_type = null)
 	{
 		// calling the Storage\Base constructor
-		parent::__construct($app,$table,$db,$column_prefix,$no_clone,$timestamp_type);
+		parent::__construct($app, $table, $db, $column_prefix, $no_clone, $timestamp_type);
 
 		$this->allow_multiple_values = $allow_multiple_values;
 		$this->extra_table = $extra_table;
-		if (!$this->extra_id) $this->extra_id = $this->autoinc_id;	// default to auto id of regular table
+		if (!$this->extra_id) $this->extra_id = $this->autoinc_id; // default to auto id of regular table
 
 		// if names from columns of extra table are only postfixes (starting with _), prepend column prefix
-		if (!($prefix=$column_prefix))
+		if (!($prefix = $column_prefix))
 		{
-			list($prefix) = explode('_',$this->autoinc_id);
+			list($prefix) = explode('_', $this->autoinc_id);
 		}
-		elseif(substr($prefix,-1) == '_')
+		elseif (substr($prefix, -1) == '_')
 		{
-			$prefix = substr($prefix,0,-1);	// remove trailing underscore from column prefix parameter
+			$prefix = substr($prefix, 0, -1); // remove trailing underscore from column prefix parameter
 		}
-		foreach(array(
+		foreach (array(
 			'extra_id' => $extra_id,
 			'extra_key' => $extra_key,
 			'extra_value' => $extra_value
 		) as $col => $val)
 		{
 			$this->$col = $col_name = $val;
-			if ($col_name[0] == '_') $this->$col = $prefix . $val;
+			if ($col_name[0] == '_') $this->$col = $prefix.$val;
 		}
 		// some sanity checks, maybe they should be active only for development
-		if (!($extra_defs = $this->db->get_table_definitions($app,$extra_table)))
+		if (!($extra_defs = $this->db->get_table_definitions($app, $extra_table)))
 		{
 			throw new Exception\WrongParameter("extra table $extra_table is NOT defined!");
 		}
-		foreach(array('extra_id','extra_key','extra_value') as $col)
+		foreach (array('extra_id', 'extra_key', 'extra_value') as $col)
 		{
 			if (!$this->$col || !isset($extra_defs['fd'][$this->$col]))
 			{
@@ -177,23 +177,23 @@ 
 	 * @param array $field_names =null custom fields to read, default all
 	 * @return array id => $this->cf_field(name) => value
 	 */
-	function read_customfields($ids,$field_names=null)
+	function read_customfields($ids, $field_names = null)
 	{
 		if (is_null($field_names)) $field_names = array_keys($this->customfields);
 
-		foreach((array)$ids as $key => $id)
+		foreach ((array)$ids as $key => $id)
 		{
 			if (!(int)$id && is_array($ids)) unset($ids[$key]);
 		}
-		if (!$ids || !$field_names) return array();	// nothing to do
+		if (!$ids || !$field_names) return array(); // nothing to do
 
 		$entries = array();
-		foreach($this->db->select($this->extra_table,'*',array(
+		foreach ($this->db->select($this->extra_table, '*', array(
 			$this->extra_id => $ids,
 			$this->extra_key => $field_names,
-		),__LINE__,__FILE__,false,'',$this->app) as $row)
+		), __LINE__, __FILE__, false, '', $this->app) as $row)
 		{
-			$entry =& $entries[$row[$this->extra_id]];
+			$entry = & $entries[$row[$this->extra_id]];
 			if (!is_array($entry)) $entry = array();
 			$field = $this->get_cf_field($row[$this->extra_key]);
 
@@ -216,7 +216,7 @@ 
 	* @param array $extra_cols =array() extra-data to be saved
 	* @return bool false on success, errornumber on failure
 	*/
-	function save_customfields(&$data, array $extra_cols=array())
+	function save_customfields(&$data, array $extra_cols = array())
 	{
 		$id = isset($data[$this->autoinc_id]) ? $data[$this->autoinc_id] : $data[$this->db_key_cols[$this->autoinc_id]];
 
@@ -233,22 +233,21 @@ 
 			$is_multiple = $this->is_multiple($name);
 
 			// we explicitly need to delete fields, if value is empty or field allows multiple values or we have no unique index
-			if(empty($data[$field]) || $is_multiple || !$this->extra_has_unique_index)
+			if (empty($data[$field]) || $is_multiple || !$this->extra_has_unique_index)
 			{
-				$this->db->delete($this->extra_table,$where,__LINE__,__FILE__,$this->app);
-				if (empty($data[$field])) continue;	// nothing else to do for empty values
+				$this->db->delete($this->extra_table, $where, __LINE__, __FILE__, $this->app);
+				if (empty($data[$field])) continue; // nothing else to do for empty values
 			}
-			foreach($is_multiple && !is_array($data[$field]) ? explode(',',$data[$field]) :
-				// regular custom fields (!$is_multiple) eg. addressbook store multiple values comma-separated
+			foreach ($is_multiple && !is_array($data[$field]) ? explode(',', $data[$field]) : // regular custom fields (!$is_multiple) eg. addressbook store multiple values comma-separated
 				(array)(!$is_multiple && is_array($data[$field]) ? implode(',', $data[$field]) : $data[$field]) as $value)
 			{
-				if (!$this->db->insert($this->extra_table,array($this->extra_value => $value)+$extra_cols,$where,__LINE__,__FILE__,$this->app))
+				if (!$this->db->insert($this->extra_table, array($this->extra_value => $value) + $extra_cols, $where, __LINE__, __FILE__, $this->app))
 				{
 					return $this->db->Errno;
 				}
 			}
 		}
-		return false;	// no error
+		return false; // no error
 	}
 
 	/**
@@ -264,7 +263,7 @@ 
 
 		if ($this->customfields)
 		{
-			foreach(array_keys($this->customfields) as $name)
+			foreach (array_keys($this->customfields) as $name)
 			{
 				if (isset($new[$field = $this->get_cf_field($name)]))
 				{
@@ -284,16 +283,16 @@ 
 	 * @param string $join sql to do a join, added as is after the table-name, eg. ", table2 WHERE x=y" or
 	 * @return array|boolean data if row could be retrived else False
 	 */
-	function read($keys,$extra_cols='',$join='')
+	function read($keys, $extra_cols = '', $join = '')
 	{
-		if (!parent::read($keys,$extra_cols,$join))
+		if (!parent::read($keys, $extra_cols, $join))
 		{
 			return false;
 		}
 		if (($id = (int)$this->data[$this->db_key_cols[$this->autoinc_id]]) && $this->customfields &&
 			($cfs = $this->read_customfields($id)))
 		{
-			$this->data = array_merge($this->data,$cfs[$id]);
+			$this->data = array_merge($this->data, $cfs[$id]);
 		}
 		return $this->data;
 	}
@@ -307,14 +306,14 @@ 
 	 * @param string|array $extra_where =null extra where clause, eg. to check an etag, returns true if no affected rows!
 	 * @return int|boolean 0 on success, or errno != 0 on error, or true if $extra_where is given and no rows affected
 	 */
-	function save($keys=null,$extra_where=null)
+	function save($keys = null, $extra_where = null)
 	{
 		if (is_array($keys) && count($keys) && !isset($keys[0]))	// allow to use an etag, eg array('etag=etag+1')
 		{
 			$this->data_merge($keys);
 			$keys = null;
 		}
-		$ret = parent::save($keys,$extra_where);
+		$ret = parent::save($keys, $extra_where);
 
 		if ($ret == 0 && $this->customfields)
 		{
@@ -332,26 +331,26 @@ 
 	 * @param boolean $only_return_ids =false return $ids of delete call to db object, but not run it (can be used by extending classes!)
 	 * @return int|array affected rows, should be 1 if ok, 0 if an error or array with id's if $only_return_ids
 	 */
-	function delete($keys=null,$only_return_ids=false)
+	function delete($keys = null, $only_return_ids = false)
 	{
 		if ($this->customfields || $only_return_ids)
 		{
-			$query = parent::delete($keys,true);
+			$query = parent::delete($keys, true);
 			// check if query contains more then the id's
 			if (!isset($query[$this->autoinc_id]) || count($query) != 1)
 			{
-				foreach($this->db->select($this->table_name,$this->autoinc_id,$query,__LINE__,__FILE__,false,'',$this->app) as $row)
+				foreach ($this->db->select($this->table_name, $this->autoinc_id, $query, __LINE__, __FILE__, false, '', $this->app) as $row)
 				{
 					$ids[] = $row[$this->autoinc_id];
 				}
-				if (!$ids) return 0;	// no rows affected
+				if (!$ids) return 0; // no rows affected
 			}
 			else
 			{
 				$ids = (array)$query[$this->autoinc_id];
 			}
 			if ($only_return_ids) return $ids;
-			$this->db->delete($this->extra_table,array($this->extra_id => $ids),__LINE__,__FILE__);
+			$this->db->delete($this->extra_table, array($this->extra_id => $ids), __LINE__, __FILE__);
 		}
 		return parent::delete($keys);
 	}
@@ -374,32 +373,32 @@ 
 	 * @param string|array $extra_cols =array()
 	 * @return int total number of rows
 	 */
-	function get_rows($query,&$rows,&$readonlys,$join='',$need_full_no_count=false,$only_keys=false,$extra_cols=array())
+	function get_rows($query, &$rows, &$readonlys, $join = '', $need_full_no_count = false, $only_keys = false, $extra_cols = array())
 	{
-		parent::get_rows($query,$rows,$readonlys,$join,$need_full_no_count,$only_keys,$extra_cols);
+		parent::get_rows($query, $rows, $readonlys, $join, $need_full_no_count, $only_keys, $extra_cols);
 
-		$selectcols = $query['selectcols'] ? (is_string($query['selectcols']) ? explode(',',$query['selectcols']) :$query['selectcols']): array();
+		$selectcols = $query['selectcols'] ? (is_string($query['selectcols']) ? explode(',', $query['selectcols']) : $query['selectcols']) : array();
 
-		if ($rows && $this->customfields && (!$selectcols || in_array('customfields',$selectcols)))
+		if ($rows && $this->customfields && (!$selectcols || in_array('customfields', $selectcols)))
 		{
 			$id2keys = array();
-			foreach($rows as $key => $row)
+			foreach ($rows as $key => $row)
 			{
 				$id2keys[$row[$this->db_key_cols[$this->autoinc_id]]] = $key;
 			}
 			// check if only certain cf's to show
 			if (!in_array('customfields', $selectcols))
 			{
-				foreach($selectcols as $col)
+				foreach ($selectcols as $col)
 				{
 					if ($this->is_cf($col)) $fields[] = $this->get_cf_name($col);
 				}
 			}
-			if (($cfs = $this->read_customfields(array_keys($id2keys),$fields)))
+			if (($cfs = $this->read_customfields(array_keys($id2keys), $fields)))
 			{
-				foreach($cfs as $id => $data)
+				foreach ($cfs as $id => $data)
 				{
-					$rows[$id2keys[$id]] = array_merge($rows[$id2keys[$id]],$data);
+					$rows[$id2keys[$id]] = array_merge($rows[$id2keys[$id]], $data);
 				}
 			}
 		}
@@ -416,9 +415,9 @@ 
 	 */
 	public function cf_match($_pattern)
 	{
-		static $private_cfs=null;
+		static $private_cfs = null;
 
-		if (!$this->customfields) return '';	// no custom-fields --> no search
+		if (!$this->customfields) return ''; // no custom-fields --> no search
 
 		$sql = ' OR '.$this->table_name.'.'.$this->autoinc_id.' IN (SELECT '.$this->autoinc_id.
 			' FROM '.$this->extra_table.' WHERE '.$this->extra_value.' '.
@@ -429,7 +428,7 @@ 
 		if (!isset($private_cfs))
 		{
 			$private_cfs = array_diff_key(
-				Storage\Customfields::get($this->app, true, null, $this->db),	// true: get private cfs too
+				Storage\Customfields::get($this->app, true, null, $this->db), // true: get private cfs too
 				$this->customfields);
 			//error_log(__METHOD__."() private_cfs=".array2string($private_cfs));
 		}
@@ -460,7 +459,7 @@ 
 	 * @param boolean $need_full_no_count =false If true an unlimited query is run to determine the total number of rows, default false
 	 * @return array|NULL array of matching rows (the row is an array of the cols) or NULL
 	 */
-	function &search($criteria,$only_keys=True,$order_by='',$extra_cols='',$wildcard='',$empty=False,$op='AND',$start=false,$filter=null,$join='',$need_full_no_count=false)
+	function &search($criteria, $only_keys = True, $order_by = '', $extra_cols = '', $wildcard = '', $empty = False, $op = 'AND', $start = false, $filter = null, $join = '', $need_full_no_count = false)
 	{
 		//error_log(__METHOD__.'('.array2string(array_combine(array_slice(array('criteria','only_keys','order_by','extra_cols','wildcard','empty','op','start','filter','join','need_full_no_count'), 0, count(func_get_args())), func_get_args())).')');
 
@@ -468,7 +467,7 @@ 
 		if (!$this->customfields && strpos($order_by, self::CF_PREFIX) === false &&
 			strpos(implode(',', array_keys($filter ? $filter : [])), self::CF_PREFIX) === false)
 		{
-			return parent::search($criteria,$only_keys,$order_by,$extra_cols,$wildcard,$empty,$op,$start,$filter,$join,$need_full_no_count);
+			return parent::search($criteria, $only_keys, $order_by, $extra_cols, $wildcard, $empty, $op, $start, $filter, $join, $need_full_no_count);
 		}
 		if ($only_keys === false)
 		{
@@ -477,7 +476,7 @@ 
 		$extra_join_added = $join && strpos($join, $this->extra_join) !== false;
 		if ($criteria && is_string($criteria))
 		{
-			$extra_join_added = true;	// we have NOT added the join, as we use a sub-query and therefore not need it
+			$extra_join_added = true; // we have NOT added the join, as we use a sub-query and therefore not need it
 
 			$criteria = $this->search2criteria($criteria, $wildcard, $op);
 		}
@@ -489,10 +488,10 @@ 
 				// we should check if the CF is (still) available, but that makes the slow search even slower :(
 				if (($negate = $criteria[$this->extra_value][0] === '!'))
 				{
-					$criteria[$this->extra_value] = substr($criteria[$this->extra_value],1);
+					$criteria[$this->extra_value] = substr($criteria[$this->extra_value], 1);
 				}
-				$criteria[] = $this->extra_table.'.'.$this->extra_value . ' ' .($negate ? 'NOT ' : '').
-					$this->db->capabilities[Db::CAPABILITY_CASE_INSENSITIV_LIKE]. ' ' .
+				$criteria[] = $this->extra_table.'.'.$this->extra_value.' '.($negate ? 'NOT ' : '').
+					$this->db->capabilities[Db::CAPABILITY_CASE_INSENSITIV_LIKE].' '.
 					$this->db->quote($wildcard.$criteria[$this->extra_value].$wildcard);
 				unset($criteria[$this->extra_value]);
 			}
@@ -501,13 +500,13 @@ 
 			{
 				if ($criteria[$this->autoinc_id])
 				{
-					$criteria[] = $this->db->expression($this->table_name,$this->table_name.'.',
+					$criteria[] = $this->db->expression($this->table_name, $this->table_name.'.',
 						array($this->autoinc_id => $criteria[$this->autoinc_id]));
 				}
 				unset($criteria[$this->autoinc_id]);
 			}
 			// replace ambiguous column with (an exact match of) table_name.column
-			foreach($criteria as $name => $val)
+			foreach ($criteria as $name => $val)
 			{
 				// only add extra_join, if we really need it
 				if (!$extra_join_added && (
@@ -519,9 +518,9 @@ 
 					$extra_join_added = true;
 				}
 				$extra_columns = $this->db->get_table_definitions($this->app, $this->extra_table);
-				if(is_string($name) && $extra_columns['fd'][array_search($name, $this->db_cols)])
+				if (is_string($name) && $extra_columns['fd'][array_search($name, $this->db_cols)])
 				{
-					$criteria[] = $this->db->expression($this->table_name,$this->table_name.'.',array(
+					$criteria[] = $this->db->expression($this->table_name, $this->table_name.'.', array(
 						array_search($name, $this->db_cols) => $val,
 					));
 					unset($criteria[$name]);
@@ -533,12 +532,12 @@ 
 						$name = substr($name, 1);
 						if (($negate = $criteria[$name][0] === '!'))
 						{
-							$val = substr($val,1);
+							$val = substr($val, 1);
 						}
-						$cfcriteria[] = '(' . $this->extra_table.'.'.$this->extra_value . ' ' .($negate ? 'NOT ' : '').
-							$this->db->capabilities[Db::CAPABILITY_CASE_INSENSITIV_LIKE]. ' ' .
-							$this->db->quote($wildcard.$val.$wildcard) . ' AND ' .
-							$this->extra_table.'.'.$this->extra_key . ' = ' . $this->db->quote($name) .
+						$cfcriteria[] = '('.$this->extra_table.'.'.$this->extra_value.' '.($negate ? 'NOT ' : '').
+							$this->db->capabilities[Db::CAPABILITY_CASE_INSENSITIV_LIKE].' '.
+							$this->db->quote($wildcard.$val.$wildcard).' AND '.
+							$this->extra_table.'.'.$this->extra_key.' = '.$this->db->quote($name).
 							')';
 						unset($criteria[self::CF_PREFIX.$name]);
 					}
@@ -550,49 +549,49 @@ 
 					}
 				}
 			}
-			if ($cfcriteria && $op =='OR') $criteria[] = implode(' OR ',$cfcriteria);
+			if ($cfcriteria && $op == 'OR') $criteria[] = implode(' OR ', $cfcriteria);
 		}
-		if($only_keys === true)
+		if ($only_keys === true)
 		{
 			// Expand to keys here, so table_name can be prepended below
 			$only_keys = array_values($this->db_key_cols);
 		}
 		// replace ambiguous column with (an exact match of) table_name.column
-		if(is_array($only_keys))
+		if (is_array($only_keys))
 		{
-			foreach($only_keys as $key => &$col)
+			foreach ($only_keys as $key => &$col)
 			{
-				if(is_numeric($key) && in_array($col, $this->db_cols, true))
+				if (is_numeric($key) && in_array($col, $this->db_cols, true))
 				{
-					$col = $this->table_name .'.'.array_search($col, $this->db_cols).' AS '.$col;
+					$col = $this->table_name.'.'.array_search($col, $this->db_cols).' AS '.$col;
 				}
 			}
 		}
 		// check if we order by a custom field --> join cf table for given cf and order by it's value
-		if (strpos($order_by,self::CF_PREFIX) !== false)
+		if (strpos($order_by, self::CF_PREFIX) !== false)
 		{
 			// if $order_by contains more then order by columns (eg. group by) split it off before
 			if (($pos = stripos($order_by, 'order by')) !== false)
 			{
-				$group_by = substr($order_by, 0, $pos+9);
-				$order_by = substr($order_by, $pos+9);
+				$group_by = substr($order_by, 0, $pos + 9);
+				$order_by = substr($order_by, $pos + 9);
 			}
 			// fields to order by, as cutomfields may have names with spaces, we examine each order by criteria
-			$fields2order = explode(',',$order_by);
-			foreach($fields2order as $v)
+			$fields2order = explode(',', $order_by);
+			foreach ($fields2order as $v)
 			{
-				if (strpos($v,self::CF_PREFIX) !== false)
+				if (strpos($v, self::CF_PREFIX) !== false)
 				{
 					// we found a customfield, so we split that part by space char in order to get Sorting Direction and Fieldname
-					$buff = explode(' ',trim($v));
+					$buff = explode(' ', trim($v));
 					$orderDir = array_pop($buff);
-					$key = substr(trim(implode(' ',$buff)), 1);
+					$key = substr(trim(implode(' ', $buff)), 1);
 					if (!isset($this->customfields[$key]))
 					{
 						$order_by = preg_replace('/'.preg_quote($v, '/').',?/', '', $order_by);
-						continue;	// ignore unavaiable CF
+						continue; // ignore unavaiable CF
 					}
-					switch($this->customfields[$key]['type'])
+					switch ($this->customfields[$key]['type'])
 					{
 						case 'int':
 							$order_by = str_replace($v, 'extra_order.'.$this->extra_value.' IS NULL,'.
@@ -630,26 +629,26 @@ 
 		{
 			$_cfnames = array_keys($this->customfields);
 			$extra_filter = null;
-			foreach($filter as $name => $val)
+			foreach ($filter as $name => $val)
 			{
 				// replace ambiguous auto-id with (an exact match of) table_name.autoid
 				if (is_string($name) && $name == $this->autoinc_id)
 				{
 					if ((int)$filter[$this->autoinc_id])
 					{
-						$filter[] = $this->db->expression($this->table_name,$this->table_name.'.',array(
+						$filter[] = $this->db->expression($this->table_name, $this->table_name.'.', array(
 							$this->autoinc_id => $filter[$this->autoinc_id],
 						));
 					}
 					unset($filter[$this->autoinc_id]);
 				}
 				// replace ambiguous column with (an exact match of) table_name.column
-				elseif (is_string($name) && $val!=null && in_array($name, $this->db_cols))
+				elseif (is_string($name) && $val != null && in_array($name, $this->db_cols))
 				{
 					$extra_columns = $this->db->get_table_definitions($this->app, $this->extra_table);
 					if ($extra_columns['fd'][array_search($name, $this->db_cols)])
 					{
-						$filter[] = $this->db->expression($this->table_name,$this->table_name.'.',array(
+						$filter[] = $this->db->expression($this->table_name, $this->table_name.'.', array(
 							array_search($name, $this->db_cols) => $val,
 						));
 						unset($filter[$name]);
@@ -661,59 +660,59 @@ 
 					if (!isset($this->customfields[$cf_name]))
 					{
 						unset($filter[$name]);
-						continue;	// ignore unavailable CF
+						continue; // ignore unavailable CF
 					}
 					if (!empty($val))	// empty -> dont filter
 					{
 						if ($val[0] === '!')	// negative filter
 						{
-							$sql_filter = 'extra_filter.'.$this->extra_value.'!='.$this->db->quote(substr($val,1));
+							$sql_filter = 'extra_filter.'.$this->extra_value.'!='.$this->db->quote(substr($val, 1));
 						}
 						else	// using Db::expression to allow to use array() with possible values or NULL
 						{
-							if($this->customfields[$cf_name]['type'] == 'select' &&
+							if ($this->customfields[$cf_name]['type'] == 'select' &&
 								$this->customfields[$cf_name]['rows'] > 1)
 							{
 								// Multi-select - any entry with the filter value selected matches
-								$sql_filter = str_replace($this->extra_value,'extra_filter.'.
-									$this->extra_value,$this->db->expression($this->extra_table,array(
-										$this->db->concat("','",$this->extra_value,"','").' '.$this->db->capabilities[Db::CAPABILITY_CASE_INSENSITIV_LIKE].' '.$this->db->quote('%,'.$val.',%')
+								$sql_filter = str_replace($this->extra_value, 'extra_filter.'.
+									$this->extra_value, $this->db->expression($this->extra_table, array(
+										$this->db->concat("','", $this->extra_value, "','").' '.$this->db->capabilities[Db::CAPABILITY_CASE_INSENSITIV_LIKE].' '.$this->db->quote('%,'.$val.',%')
 									))
 								);
 							}
 							elseif ($this->customfields[$cf_name]['type'] == 'text')
 							{
-								$sql_filter = str_replace($this->extra_value,'extra_filter.'.$this->extra_value,
-										$this->db->expression($this->extra_table,array(
+								$sql_filter = str_replace($this->extra_value, 'extra_filter.'.$this->extra_value,
+										$this->db->expression($this->extra_table, array(
 										$this->extra_value.' '.$this->db->capabilities[Db::CAPABILITY_CASE_INSENSITIV_LIKE].' '.$this->db->quote($wildcard.$val.$wildcard)
 									))
 								);
 							}
 							else
 							{
-								$sql_filter = str_replace($this->extra_value,'extra_filter.'.
-									$this->extra_value,$this->db->expression($this->extra_table,array($this->extra_value => $val)));
+								$sql_filter = str_replace($this->extra_value, 'extra_filter.'.
+									$this->extra_value, $this->db->expression($this->extra_table, array($this->extra_value => $val)));
 							}
 						}
 						// need to use a LEFT JOIN for negative search or to allow NULL values
-						$need_left_join = $val[0] === '!' || strpos($sql_filter,'IS NULL') !== false ? ' LEFT ' : '';
-						$join .= str_replace('extra_filter','extra_filter'.$extra_filter,$need_left_join.$this->extra_join_filter.
+						$need_left_join = $val[0] === '!' || strpos($sql_filter, 'IS NULL') !== false ? ' LEFT ' : '';
+						$join .= str_replace('extra_filter', 'extra_filter'.$extra_filter, $need_left_join.$this->extra_join_filter.
 							' AND extra_filter.'.$this->extra_key.'='.$this->db->quote($cf_name).
 							' AND '.$sql_filter);
 						++$extra_filter;
 					}
 					unset($filter[$name]);
 				}
-				elseif(is_int($name) && $this->is_cf($val))	// lettersearch: #cfname LIKE 's%'
+				elseif (is_int($name) && $this->is_cf($val))	// lettersearch: #cfname LIKE 's%'
 				{
-					$_cf = explode(' ',$val);
-					foreach($_cf as $cf_np)
+					$_cf = explode(' ', $val);
+					foreach ($_cf as $cf_np)
 					{
 						// building cf_name by glueing parts together (, in case someone used whitespace in their custom field names)
-						$tcf_name = ($tcf_name?$tcf_name.' ':'').$cf_np;
+						$tcf_name = ($tcf_name ? $tcf_name.' ' : '').$cf_np;
 						// reacts on the first one found that matches an existing customfield, should be better then the old behavior of
 						// simply splitting by " " and using the first part
-						if ($this->is_cf($tcf_name) && ($cfn = $this->get_cf_name($tcf_name)) && array_search($cfn,(array)$_cfnames,true)!==false )
+						if ($this->is_cf($tcf_name) && ($cfn = $this->get_cf_name($tcf_name)) && array_search($cfn, (array)$_cfnames, true) !== false)
 						{
 							$cf = $tcf_name;
 							break;
@@ -721,10 +720,10 @@ 
 					}
 					unset($filter[$name]);
 					$cf_name = $this->get_cf_name($cf);
-					if (!isset($this->customfields[$cf_name])) continue;	// ignore unavailable CF
-					$join .= str_replace('extra_filter','extra_filter'.$extra_filter,$this->extra_join_filter.
+					if (!isset($this->customfields[$cf_name])) continue; // ignore unavailable CF
+					$join .= str_replace('extra_filter', 'extra_filter'.$extra_filter, $this->extra_join_filter.
 						' AND extra_filter.'.$this->extra_key.'='.$this->db->quote($cf_name).
-						' AND '.str_replace($cf,'extra_filter.'.$this->extra_value,$val));
+						' AND '.str_replace($cf, 'extra_filter.'.$this->extra_value, $val));
 					++$extra_filter;
 				}
 			}
@@ -735,15 +734,14 @@ 
 			if (is_array($only_keys))
 			{
 				$only_keys = array_values($only_keys);
-				$only_keys[0] = 'DISTINCT '.($only_keys[0] != $this->autoinc_id ? $only_keys[0] :
-					$this->table_name.'.'.$this->autoinc_id.' AS '.$this->autoinc_id);
+				$only_keys[0] = 'DISTINCT '.($only_keys[0] != $this->autoinc_id ? $only_keys[0] : $this->table_name.'.'.$this->autoinc_id.' AS '.$this->autoinc_id);
 			}
 			else
 			{
 				$only_keys = 'DISTINCT '.$only_keys;
 			}
 		}
-		return parent::search($criteria,$only_keys,$order_by,$extra_cols,$wildcard,$empty,$op,$start,$filter,$join,$need_full_no_count);
+		return parent::search($criteria, $only_keys, $order_by, $extra_cols, $wildcard, $empty, $op, $start, $filter, $join, $need_full_no_count);
 	}
 
 	/**
@@ -765,7 +763,7 @@ 
 	 */
 	function get_cf_name($field)
 	{
-		return substr($field,1);
+		return substr($field, 1);
 	}
 
 	/**
@@ -787,7 +785,7 @@ 
 	 */
 	function is_multiple($name)
 	{
-		return $this->allow_multiple_values && in_array($this->customfields[$name]['type'],array('select','select-account')) &&
+		return $this->allow_multiple_values && in_array($this->customfields[$name]['type'], array('select', 'select-account')) &&
 			$this->customfields[$name]['rows'] > 1;
 	}
 }

Braces +74 added lines, -17 removed lines

@@ -127,7 +127,11 @@ 
 
 		$this->allow_multiple_values = $allow_multiple_values;
 		$this->extra_table = $extra_table;
-		if (!$this->extra_id) $this->extra_id = $this->autoinc_id;	// default to auto id of regular table
+		if (!$this->extra_id)
+		{
+			$this->extra_id = $this->autoinc_id;
+		}
+		// default to auto id of regular table
 
 		// if names from columns of extra table are only postfixes (starting with _), prepend column prefix
 		if (!($prefix=$column_prefix))
@@ -145,7 +149,10 @@ 
 		) as $col => $val)
 		{
 			$this->$col = $col_name = $val;
-			if ($col_name[0] == '_') $this->$col = $prefix . $val;
+			if ($col_name[0] == '_')
+			{
+				$this->$col = $prefix . $val;
+			}
 		}
 		// some sanity checks, maybe they should be active only for development
 		if (!($extra_defs = $this->db->get_table_definitions($app,$extra_table)))
@@ -179,13 +186,23 @@ 
 	 */
 	function read_customfields($ids,$field_names=null)
 	{
-		if (is_null($field_names)) $field_names = array_keys($this->customfields);
+		if (is_null($field_names))
+		{
+			$field_names = array_keys($this->customfields);
+		}
 
 		foreach((array)$ids as $key => $id)
 		{
-			if (!(int)$id && is_array($ids)) unset($ids[$key]);
+			if (!(int)$id && is_array($ids))
+			{
+				unset($ids[$key]);
+			}
+		}
+		if (!$ids || !$field_names)
+		{
+			return array();
 		}
-		if (!$ids || !$field_names) return array();	// nothing to do
+		// nothing to do
 
 		$entries = array();
 		foreach($this->db->select($this->extra_table,'*',array(
@@ -194,7 +211,10 @@ 
 		),__LINE__,__FILE__,false,'',$this->app) as $row)
 		{
 			$entry =& $entries[$row[$this->extra_id]];
-			if (!is_array($entry)) $entry = array();
+			if (!is_array($entry))
+			{
+				$entry = array();
+			}
 			$field = $this->get_cf_field($row[$this->extra_key]);
 
 			if ($this->allow_multiple_values && $this->is_multiple($row[$this->extra_key]))
@@ -224,7 +244,10 @@ 
 
 		foreach (array_keys((array)$this->customfields) as $name)
 		{
-			if (!isset($data[$field = $this->get_cf_field($name)])) continue;
+			if (!isset($data[$field = $this->get_cf_field($name)]))
+			{
+				continue;
+			}
 
 			$where = array(
 				$this->extra_id    => $id,
@@ -236,7 +259,11 @@ 
 			if(empty($data[$field]) || $is_multiple || !$this->extra_has_unique_index)
 			{
 				$this->db->delete($this->extra_table,$where,__LINE__,__FILE__,$this->app);
-				if (empty($data[$field])) continue;	// nothing else to do for empty values
+				if (empty($data[$field]))
+				{
+					continue;
+				}
+				// nothing else to do for empty values
 			}
 			foreach($is_multiple && !is_array($data[$field]) ? explode(',',$data[$field]) :
 				// regular custom fields (!$is_multiple) eg. addressbook store multiple values comma-separated
@@ -309,9 +336,12 @@ 
 	 */
 	function save($keys=null,$extra_where=null)
 	{
-		if (is_array($keys) && count($keys) && !isset($keys[0]))	// allow to use an etag, eg array('etag=etag+1')
+		if (is_array($keys) && count($keys) && !isset($keys[0]))
+		{
+			// allow to use an etag, eg array('etag=etag+1')
 		{
 			$this->data_merge($keys);
+		}
 			$keys = null;
 		}
 		$ret = parent::save($keys,$extra_where);
@@ -344,13 +374,20 @@ 
 				{
 					$ids[] = $row[$this->autoinc_id];
 				}
-				if (!$ids) return 0;	// no rows affected
+				if (!$ids)
+				{
+					return 0;
+				}
+				// no rows affected
 			}
 			else
 			{
 				$ids = (array)$query[$this->autoinc_id];
 			}
-			if ($only_return_ids) return $ids;
+			if ($only_return_ids)
+			{
+				return $ids;
+			}
 			$this->db->delete($this->extra_table,array($this->extra_id => $ids),__LINE__,__FILE__);
 		}
 		return parent::delete($keys);
@@ -392,7 +429,10 @@ 
 			{
 				foreach($selectcols as $col)
 				{
-					if ($this->is_cf($col)) $fields[] = $this->get_cf_name($col);
+					if ($this->is_cf($col))
+					{
+						$fields[] = $this->get_cf_name($col);
+					}
 				}
 			}
 			if (($cfs = $this->read_customfields(array_keys($id2keys),$fields)))
@@ -418,7 +458,11 @@ 
 	{
 		static $private_cfs=null;
 
-		if (!$this->customfields) return '';	// no custom-fields --> no search
+		if (!$this->customfields)
+		{
+			return '';
+		}
+		// no custom-fields --> no search
 
 		$sql = ' OR '.$this->table_name.'.'.$this->autoinc_id.' IN (SELECT '.$this->autoinc_id.
 			' FROM '.$this->extra_table.' WHERE '.$this->extra_value.' '.
@@ -550,7 +594,10 @@ 
 					}
 				}
 			}
-			if ($cfcriteria && $op =='OR') $criteria[] = implode(' OR ',$cfcriteria);
+			if ($cfcriteria && $op =='OR')
+			{
+				$criteria[] = implode(' OR ',$cfcriteria);
+			}
 		}
 		if($only_keys === true)
 		{
@@ -663,11 +710,14 @@ 
 						unset($filter[$name]);
 						continue;	// ignore unavailable CF
 					}
-					if (!empty($val))	// empty -> dont filter
+					if (!empty($val))
+					{
+						// empty -> dont filter
 					{
 						if ($val[0] === '!')	// negative filter
 						{
 							$sql_filter = 'extra_filter.'.$this->extra_value.'!='.$this->db->quote(substr($val,1));
+					}
 						}
 						else	// using Db::expression to allow to use array() with possible values or NULL
 						{
@@ -704,9 +754,12 @@ 
 					}
 					unset($filter[$name]);
 				}
-				elseif(is_int($name) && $this->is_cf($val))	// lettersearch: #cfname LIKE 's%'
+				elseif(is_int($name) && $this->is_cf($val))
+				{
+					// lettersearch: #cfname LIKE 's%'
 				{
 					$_cf = explode(' ',$val);
+				}
 					foreach($_cf as $cf_np)
 					{
 						// building cf_name by glueing parts together (, in case someone used whitespace in their custom field names)
@@ -721,7 +774,11 @@ 
 					}
 					unset($filter[$name]);
 					$cf_name = $this->get_cf_name($cf);
-					if (!isset($this->customfields[$cf_name])) continue;	// ignore unavailable CF
+					if (!isset($this->customfields[$cf_name]))
+					{
+						continue;
+					}
+					// ignore unavailable CF
 					$join .= str_replace('extra_filter','extra_filter'.$extra_filter,$this->extra_join_filter.
 						' AND extra_filter.'.$this->extra_key.'='.$this->db->quote($cf_name).
 						' AND '.str_replace($cf,'extra_filter.'.$this->extra_value,$val));

api/src/Storage/Base.php

Spacing +220 added lines, -220 removed lines

@@ -179,7 +179,7 @@ 
 	 * @param string $timestamp_type =null default null=leave them as is, 'ts'|'integer' use integer unix timestamps,
 	 * 	'object' use Api\DateTime objects or 'string' use DB timestamp (Y-m-d H:i:s) string
 	 */
-	function __construct($app='',$table='',Api\Db $db=null,$column_prefix='',$no_clone=false,$timestamp_type=null)
+	function __construct($app = '', $table = '', Api\Db $db = null, $column_prefix = '', $no_clone = false, $timestamp_type = null)
 	{
 		// ease the transition to api
 		if ($app == 'phpgwapi') $app = 'api';
@@ -200,11 +200,11 @@ 
 
 			if (!$no_clone) $this->db->set_app($app);
 
-			if ($table) $this->setup_table($app,$table,$column_prefix);
+			if ($table) $this->setup_table($app, $table, $column_prefix);
 		}
 		$this->init();
 
-		if ((int) $this->debug >= 4)
+		if ((int)$this->debug >= 4)
 		{
 			echo "<p>".__METHOD__."('$app','$table')</p>\n";
 			_debug_array($this);
@@ -219,21 +219,21 @@ 
 	 * 	null=leave them as is, 'ts'|'integer' use integer unix timestamps, 'object' use Api\DateTime objects,
 	 *  'string' use DB timestamp (Y-m-d H:i:s) string
 	 */
-	public function set_times($timestamp_type=false)
+	public function set_times($timestamp_type = false)
 	{
 		if ($timestamp_type !== false) $this->timestamp_type = $timestamp_type;
 
 		// set current time
-		switch($this->timestamp_type)
+		switch ($this->timestamp_type)
 		{
 			case 'object':
 				$this->now = new Api\DateTime('now');
 				break;
 			case 'string':
-				$this->now = Api\DateTime::to('now',Api\DateTime::DATABASE);
+				$this->now = Api\DateTime::to('now', Api\DateTime::DATABASE);
 				break;
 			default:
-				$this->now = Api\DateTime::to('now','ts');
+				$this->now = Api\DateTime::to('now', 'ts');
 		}
 		$this->tz_offset_s = Api\DateTime::tz_offset_s();
 	}
@@ -247,10 +247,10 @@ 
 	 * @param string $table table-name
 	 * @param string $colum_prefix ='' column prefix to automatic remove from the column-name, if the column name starts with it
 	 */
-	function setup_table($app,$table,$colum_prefix='')
+	function setup_table($app, $table, $colum_prefix = '')
 	{
 		$this->table_name = $table;
-		$this->table_def = $this->db->get_table_definitions($app,$table);
+		$this->table_def = $this->db->get_table_definitions($app, $table);
 		if (!$this->table_def || !is_array($this->table_def['fd']))
 		{
 			throw new Api\Exception\WrongParameter(__METHOD__."('$app','$table'): No table definition for '$table' found !!!");
@@ -258,14 +258,14 @@ 
 		$this->db_key_cols = $this->db_data_cols = $this->db_cols = array();
 		$this->autoinc_id = '';
 		$len_prefix = strlen($colum_prefix);
-		foreach($this->table_def['fd'] as $col => $def)
+		foreach ($this->table_def['fd'] as $col => $def)
 		{
 			$name = $col;
-			if ($len_prefix && substr($name,0,$len_prefix) == $colum_prefix)
+			if ($len_prefix && substr($name, 0, $len_prefix) == $colum_prefix)
 			{
-				$name = substr($col,$len_prefix);
+				$name = substr($col, $len_prefix);
 			}
-			if (in_array($col,$this->table_def['pk']))
+			if (in_array($col, $this->table_def['pk']))
 			{
 				$this->db_key_cols[$col] = $name;
 			}
@@ -281,13 +281,13 @@ 
 			}
 			if ($def['type'] == 'bool') $this->has_bools = true;
 
-			foreach($this->table_def['uc'] as $k => $uni_index)
+			foreach ($this->table_def['uc'] as $k => $uni_index)
 			{
-				if (is_array($uni_index) && in_array($name,$uni_index))
+				if (is_array($uni_index) && in_array($name, $uni_index))
 				{
 					$this->db_uni_cols[$k][$col] = $name;
 				}
-				elseif($name === $uni_index)
+				elseif ($name === $uni_index)
 				{
 					$this->db_uni_cols[$col] = $name;
 				}
@@ -302,9 +302,9 @@ 
 	function convert_all_timestamps()
 	{
 		$check_already_included = !empty($this->timestamps);
-		foreach($this->table_def['fd'] as $name => $data)
+		foreach ($this->table_def['fd'] as $name => $data)
 		{
-			if ($data['type'] == 'timestamp' && (!$check_already_included || !in_array($name,$this->timestamps)))
+			if ($data['type'] == 'timestamp' && (!$check_already_included || !in_array($name, $this->timestamps)))
 			{
 				$this->timestamps[] = $name;
 			}
@@ -318,22 +318,22 @@ 
 	 */
 	function data_merge($new)
 	{
-		if ((int) $this->debug >= 4) echo "<p>so_sql::data_merge(".print_r($new,true).")</p>\n";
+		if ((int)$this->debug >= 4) echo "<p>so_sql::data_merge(".print_r($new, true).")</p>\n";
 
 		if (!is_array($new) || !count($new))
 		{
 			return;
 		}
-		foreach($this->db_cols as $db_col => $col)
+		foreach ($this->db_cols as $db_col => $col)
 		{
-			if (array_key_exists($col,$new))
+			if (array_key_exists($col, $new))
 			{
 				$this->data[$col] = $new[$col];
 			}
 		}
-		foreach($this->non_db_cols as $db_col => $col)
+		foreach ($this->non_db_cols as $db_col => $col)
 		{
-			if (array_key_exists($col,$new))
+			if (array_key_exists($col, $new))
 			{
 				$this->data[$col] = $new[$col];
 			}
@@ -342,7 +342,7 @@ 
 		{
 			$this->data[self::USER_TIMEZONE_READ] = $new[self::USER_TIMEZONE_READ];
 		}
-		if ((int) $this->debug >= 4) _debug_array($this->data);
+		if ((int)$this->debug >= 4) _debug_array($this->data);
 	}
 
 	/**
@@ -366,7 +366,7 @@ 
 	 * @param array $data =null if given works on that array and returns result, else works on internal data-array
 	 * @return array
 	 */
-	function db2data($data=null)
+	function db2data($data = null)
 	{
 		if (!is_array($data))
 		{
@@ -374,7 +374,7 @@ 
 		}
 		if ($this->timestamps)
 		{
-			foreach($this->timestamps as $name)
+			foreach ($this->timestamps as $name)
 			{
 				if (isset($data[$name]) && $data[$name])
 				{
@@ -384,7 +384,7 @@ 
 					}
 					else
 					{
-						$data[$name] = Api\DateTime::server2user($data[$name],$this->timestamp_type);
+						$data[$name] = Api\DateTime::server2user($data[$name], $this->timestamp_type);
 					}
 				}
 			}
@@ -400,7 +400,7 @@ 
 					throw new Api\Exception\WrongParameter(__METHOD__."(): No table definition for '$this->table' found !!!");
 				}
 			}
-			foreach($this->table_def['fd'] as $col => $def)
+			foreach ($this->table_def['fd'] as $col => $def)
 			{
 				if ($def['type'] == 'bool' && isset($data[$col]))
 				{
@@ -432,7 +432,7 @@ 
 	 * @param array $data =null if given works on that array and returns result, else works on internal data-array
 	 * @return array
 	 */
-	function data2db($data=null)
+	function data2db($data = null)
 	{
 		if (!is_array($data))
 		{
@@ -440,11 +440,11 @@ 
 		}
 		if ($this->timestamps)
 		{
-			foreach($this->timestamps as $name)
+			foreach ($this->timestamps as $name)
 			{
 				if (isset($data[$name]) && $data[$name])
 				{
-					$data[$name] = Api\DateTime::user2server($data[$name],$this->timestamp_type);
+					$data[$name] = Api\DateTime::user2server($data[$name], $this->timestamp_type);
 				}
 			}
 		}
@@ -457,7 +457,7 @@ 
 	 * @param array $keys =array() array with keys in form internalName => value
 	 * @return array internal data after init
 	 */
-	function init($keys=array())
+	function init($keys = array())
 	{
 		$this->data = array();
 
@@ -481,7 +481,7 @@ 
 	 * @param string $join ='' sql to do a join, added as is after the table-name, eg. ", table2 WHERE x=y" or
 	 * @return array|boolean data if row could be retrived else False
 	 */
-	function read($keys,$extra_cols='',$join='')
+	function read($keys, $extra_cols = '', $join = '')
 	{
 		if (!is_array($keys))
 		{
@@ -502,16 +502,16 @@ 
 		}
 		if (!$query)	// no primary key in keys, lets try the data_cols for a unique key
 		{
-			foreach($this->db_uni_cols as $db_col => $col)
+			foreach ($this->db_uni_cols as $db_col => $col)
 			{
 				if (!is_array($col) && $this->data[$col] != '')
 				{
 					$query[$db_col] = $this->data[$col];
 				}
-				elseif(is_array($col))
+				elseif (is_array($col))
 				{
 					$q = array();
-					foreach($col as $db_c => $c)
+					foreach ($col as $db_c => $c)
 					{
 						if ($this->data[$col] == '')
 						{
@@ -526,7 +526,7 @@ 
 		}
 		if (!$query)	// no unique key in keys, lets try everything else
 		{
-			foreach($this->db_data_cols as $db_col => $col)
+			foreach ($this->db_data_cols as $db_col => $col)
 			{
 				if ($this->data[$col] != '')
 				{
@@ -542,27 +542,27 @@ 
 		}
 		if ($join)	// Prefix the columns with the table-name, as they might exist in the join
 		{
-			foreach($query as $col => $val)
+			foreach ($query as $col => $val)
 			{
-				if (is_int($col) || strpos($join,$col) === false) continue;
-				$query[] = $this->db->expression($this->table_name,$this->table_name.'.',array($col=>$val));
+				if (is_int($col) || strpos($join, $col) === false) continue;
+				$query[] = $this->db->expression($this->table_name, $this->table_name.'.', array($col=>$val));
 				unset($query[$col]);
 			}
 		}
 		// copy direct SQL parts from $keys
-		for($i = 0; is_array($keys) && isset($keys[$i]); ++$i)
+		for ($i = 0; is_array($keys) && isset($keys[$i]); ++$i)
 		{
 			$query[] = $keys[$i];
 		}
-		foreach($this->db->select($this->table_name,'*'.($extra_cols?','.(is_array($extra_cols)?implode(',',$extra_cols):$extra_cols):''),
-			$query,__LINE__,__FILE__,False,'',$this->app,0,$join) as $row)
+		foreach ($this->db->select($this->table_name, '*'.($extra_cols ? ','.(is_array($extra_cols) ?implode(',', $extra_cols) : $extra_cols) : ''),
+			$query, __LINE__, __FILE__, False, '', $this->app, 0, $join) as $row)
 		{
 			$cols = $this->db_cols;
 			if ($extra_cols)	// extra columns to report
 			{
-				foreach(is_array($extra_cols) ? $extra_cols : array($extra_cols) as $col)
+				foreach (is_array($extra_cols) ? $extra_cols : array($extra_cols) as $col)
 				{
-					if (FALSE!==stripos($col,' as ')) $col = preg_replace('/^.* as *([a-z0-9_]+) *$/i','\\1',$col);
+					if (FALSE !== stripos($col, ' as ')) $col = preg_replace('/^.* as *([a-z0-9_]+) *$/i', '\\1', $col);
 					$cols[$col] = $col;
 				}
 			}
@@ -575,7 +575,7 @@ 
 			// store user timezone used for reading
 			$this->data[self::USER_TIMEZONE_READ] = Api\DateTime::$user_timezone->getName();
 
-			if ((int) $this->debug >= 4)
+			if ((int)$this->debug >= 4)
 			{
 				echo "data =\n"; _debug_array($this->data);
 			}
@@ -585,7 +585,7 @@ 
 		{
 			unset($this->data[$this->db_key_cols[$this->autoinc_id]]);
 		}
-		if ((int) $this->debug >= 4) echo "nothing found !!!</p>\n";
+		if ((int)$this->debug >= 4) echo "nothing found !!!</p>\n";
 
 		$this->db2data();
 
@@ -599,7 +599,7 @@ 
 	 * @param string|array $extra_where =null extra where clause, eg. to check an etag, returns true if no affected rows!
 	 * @return int|boolean 0 on success, or errno != 0 on error, or true if $extra_where is given and no rows affected
 	 */
-	function save($keys=null,$extra_where=null)
+	function save($keys = null, $extra_where = null)
 	{
 		if (is_array($keys) && count($keys)) $this->data_merge($keys);
 
@@ -618,65 +618,65 @@ 
 		}
 		$this->data2db();
 
-		if ((int) $this->debug >= 4) { echo "so_sql::save(".print_r($keys,true).") autoinc_id='$this->autoinc_id', data="; _debug_array($this->data); }
+		if ((int)$this->debug >= 4) { echo "so_sql::save(".print_r($keys, true).") autoinc_id='$this->autoinc_id', data="; _debug_array($this->data); }
 
 		if ($this->autoinc_id && !$this->data[$this->db_key_cols[$this->autoinc_id]])	// insert with auto id
 		{
-			foreach($this->db_cols as $db_col => $col)
+			foreach ($this->db_cols as $db_col => $col)
 			{
 				if (!$this->autoinc_id || $db_col != $this->autoinc_id)	// not write auto-inc-id
 				{
-					if (!array_key_exists($col,$this->data) && 	// handling of unset columns in $this->data
-						(isset($this->table_def['fd'][$db_col]['default']) ||	// we have a default value
+					if (!array_key_exists($col, $this->data) && // handling of unset columns in $this->data
+						(isset($this->table_def['fd'][$db_col]['default']) || // we have a default value
 						 !isset($this->table_def['fd'][$db_col]['nullable']) || $this->table_def['fd'][$db_col]['nullable']))	// column is nullable
 					{
-						continue;	// no need to write that (unset) column
+						continue; // no need to write that (unset) column
 					}
 					if ($this->table_def['fd'][$db_col]['type'] == 'varchar' &&
 						strlen($this->data[$col]) > $this->table_def['fd'][$db_col]['precision'])
 					{
 						// truncate the field to mamimum length, if upper layers didn't care
-						$data[$db_col] = substr($this->data[$col],0,$this->table_def['fd'][$db_col]['precision']);
+						$data[$db_col] = substr($this->data[$col], 0, $this->table_def['fd'][$db_col]['precision']);
 					}
 					else
 					{
-						$data[$db_col] = (string) $this->data[$col] === '' && $this->empty_on_write == 'NULL' ? null : $this->data[$col];
+						$data[$db_col] = (string)$this->data[$col] === '' && $this->empty_on_write == 'NULL' ? null : $this->data[$col];
 					}
 				}
 			}
-			$this->db->insert($this->table_name,$data,false,__LINE__,__FILE__,$this->app);
+			$this->db->insert($this->table_name, $data, false, __LINE__, __FILE__, $this->app);
 
 			if ($this->autoinc_id)
 			{
-				$this->data[$this->db_key_cols[$this->autoinc_id]] = $this->db->get_last_insert_id($this->table_name,$this->autoinc_id);
+				$this->data[$this->db_key_cols[$this->autoinc_id]] = $this->db->get_last_insert_id($this->table_name, $this->autoinc_id);
 			}
 		}
 		else // insert in table without auto id or update of existing row, dont write colums unset in $this->data
 		{
-			foreach($this->db_data_cols as $db_col => $col)
+			foreach ($this->db_data_cols as $db_col => $col)
 			{
 				// we need to update columns set to null: after a $this->data[$col]=null:
 				// - array_key_exits($col,$this->data) === true
 				// - isset($this->data[$col]) === false
-				if (!array_key_exists($col,$this->data) &&	// handling of unset columns in $this->data
-					($this->autoinc_id ||			// update of table with auto id or
-					 isset($this->table_def['fd'][$db_col]['default']) ||	// we have a default value or
+				if (!array_key_exists($col, $this->data) && // handling of unset columns in $this->data
+					($this->autoinc_id || // update of table with auto id or
+					 isset($this->table_def['fd'][$db_col]['default']) || // we have a default value or
 					 !isset($this->table_def['fd'][$db_col]['nullable']) || $this->table_def['fd'][$db_col]['nullable']))	// column is nullable
 				{
-					continue;	// no need to write that (unset) column
+					continue; // no need to write that (unset) column
 				}
-				$data[$db_col] = !is_object($this->data[$col]) && (string) $this->data[$col] === '' && $this->empty_on_write == 'NULL' ? null : $this->data[$col];
+				$data[$db_col] = !is_object($this->data[$col]) && (string)$this->data[$col] === '' && $this->empty_on_write == 'NULL' ? null : $this->data[$col];
 			}
 			// allow to add direct sql updates, eg. "etag=etag+1" with int keys
 			if (is_array($keys) && isset($keys[0]))
 			{
-				for($n=0; isset($keys[$n]); ++$n)
+				for ($n = 0; isset($keys[$n]); ++$n)
 				{
 					$data[] = $keys[$n];
 				}
 			}
 			$keys = $extra_where;
-			foreach($this->db_key_cols as $db_col => $col)
+			foreach ($this->db_key_cols as $db_col => $col)
 			{
 				$keys[$db_col] = $this->data[$col];
 			}
@@ -687,16 +687,16 @@ 
 			}
 			if ($this->autoinc_id)
 			{
-				$this->db->update($this->table_name,$data,$keys,__LINE__,__FILE__,$this->app);
+				$this->db->update($this->table_name, $data, $keys, __LINE__, __FILE__, $this->app);
 				if (($nothing_affected = !$this->db->Errno && !$this->db->affected_rows()) && $extra_where)
 				{
-					return true;	// extra_where not met, eg. etag wrong
+					return true; // extra_where not met, eg. etag wrong
 				}
 			}
 			// always try an insert if we have no autoinc_id, as we dont know if the data exists
 			if (!$this->autoinc_id || $nothing_affected)
 			{
-				$this->db->insert($this->table_name,$data,$keys,__LINE__,__FILE__,$this->app);
+				$this->db->insert($this->table_name, $data, $keys, __LINE__, __FILE__, $this->app);
 			}
 		}
 		$this->db2data();
@@ -711,7 +711,7 @@ 
 	 * @param boolean $merge =true if true $fields will be merged with $this->data (after update!), otherwise $this->data will be just $fields
 	 * @return int|boolean 0 on success, or errno != 0 on error, or true if $extra_where is given and no rows affected
 	 */
-	function update($_fields,$merge=true)
+	function update($_fields, $merge = true)
 	{
 		if ($merge) $this->data_merge($_fields);
 
@@ -719,23 +719,23 @@ 
 
 		// extract the keys from $fields or - if not set there - from $this->data
 		$keys = array();
-		foreach($this->db_key_cols as $col => $name)
+		foreach ($this->db_key_cols as $col => $name)
 		{
 			$keys[$col] = isset($fields[$name]) ? $fields[$name] : $this->data[$name];
 			unset($fields[$name]);
 		}
 		// extract the data from $fields
 		$data = array();
-		foreach($this->db_data_cols as $col => $name)
+		foreach ($this->db_data_cols as $col => $name)
 		{
-			if (array_key_exists($name,$fields))
+			if (array_key_exists($name, $fields))
 			{
 				$data[$col] = $fields[$name];
 				unset($fields[$name]);
 			}
 		}
 		// add direct sql like 'etag=etag+1' (it has integer keys)
-		foreach($fields as $key => $value)
+		foreach ($fields as $key => $value)
 		{
 			if (is_int($key))
 			{
@@ -744,9 +744,9 @@ 
 		}
 		if (!$data)
 		{
-			return 0;	// nothing to update
+			return 0; // nothing to update
 		}
-		if (!$this->db->update($this->table_name,$data,$keys,__LINE__,__FILE__,$this->app))
+		if (!$this->db->update($this->table_name, $data, $keys, __LINE__, __FILE__, $this->app))
 		{
 			return $this->db->Errno;
 		}
@@ -760,7 +760,7 @@ 
 	 * @param boolean $only_return_query =false return $query of delete call to db object, but not run it (used by so_sql_cf!)
 	 * @return int|array affected rows, should be 1 if ok, 0 if an error or array with id's if $only_return_ids
 	 */
-	function delete($keys=null,$only_return_query=false)
+	function delete($keys = null, $only_return_query = false)
 	{
 		if ($this->autoinc_id && $keys && !is_array($keys))
 		{
@@ -774,7 +774,7 @@ 
 		else	// data and keys are supplied in $keys
 		{
 			$data = $keys; $keys = array();
-			foreach($this->db_cols as $db_col => $col)
+			foreach ($this->db_cols as $db_col => $col)
 			{
 				if (isset($data[$col]))
 				{
@@ -782,7 +782,7 @@ 
 				}
 			}
 			// keep sql fragments (with integer key)
-			foreach($data as $key => $val)
+			foreach ($data as $key => $val)
 			{
 				if (is_int($key))
 				{
@@ -792,7 +792,7 @@ 
 		}
 		$data = $this->data2db($data);
 
-		foreach($keys as $db_col => $col)
+		foreach ($keys as $db_col => $col)
 		{
 			if (is_int($db_col))
 			{
@@ -805,7 +805,7 @@ 
 		}
 		if ($only_return_query) return $query;
 
-		$this->db->delete($this->table_name,$query,__LINE__,__FILE__,$this->app);
+		$this->db->delete($this->table_name, $query, __LINE__, __FILE__, $this->app);
 
 		return $this->db->affected_rows();
 	}
@@ -833,15 +833,15 @@ 
 	 * @todo return an interator instead of an array
 	 * @return array|NULL array of matching rows (the row is an array of the cols) or NULL
 	 */
-	function &search($criteria,$only_keys=True,$order_by='',$extra_cols='',$wildcard='',$empty=False,$op='AND',$start=false,$filter=null,$join='',$need_full_no_count=false)
+	function &search($criteria, $only_keys = True, $order_by = '', $extra_cols = '', $wildcard = '', $empty = False, $op = 'AND', $start = false, $filter = null, $join = '', $need_full_no_count = false)
 	{
 		//error_log(__METHOD__.'('.array2string(array_combine(array_slice(array('criteria','only_keys','order_by','extra_cols','wildcard','empty','op','start','filter','join','need_full_no_count'), 0, count(func_get_args())), func_get_args())).')');
-		if ((int) $this->debug >= 4) echo "<p>so_sql::search(".print_r($criteria,true).",'$only_keys','$order_by',".print_r($extra_cols,true).",'$wildcard','$empty','$op','$start',".print_r($filter,true).",'$join')</p>\n";
+		if ((int)$this->debug >= 4) echo "<p>so_sql::search(".print_r($criteria, true).",'$only_keys','$order_by',".print_r($extra_cols, true).",'$wildcard','$empty','$op','$start',".print_r($filter, true).",'$join')</p>\n";
 
 		// if extending class or instanciator set columns to search, convert string criteria to array
 		if ($criteria && !is_array($criteria))
 		{
-			$search = $this->search2criteria($criteria,$wildcard,$op);
+			$search = $this->search2criteria($criteria, $wildcard, $op);
 			$criteria = array($search);
 		}
 		if (!is_array($criteria))
@@ -858,19 +858,19 @@ 
 			$data2db_filter = $this->data2db($filter);
 			if (!is_array($data2db_filter)) {
 				echo function_backtrace()."<br/>\n";
-				echo "filter=";_debug_array($filter);
-				echo "data2db(filter)=";_debug_array($data2db_filter);
+				echo "filter="; _debug_array($filter);
+				echo "data2db(filter)="; _debug_array($data2db_filter);
 			}
-			foreach($data2db_filter as $col => $val)
+			foreach ($data2db_filter as $col => $val)
 			{
 				if ($val !== '')
 				{
 					// check if a db-internal name conversation necessary
-					if (!is_int($col) && ($c = array_search($col,$this->db_cols)))
+					if (!is_int($col) && ($c = array_search($col, $this->db_cols)))
 					{
-						$col = $this->table_name . '.' . $c;
+						$col = $this->table_name.'.'.$c;
 					}
-					if(is_int($col))
+					if (is_int($col))
 					{
 						$db_filter[] = $val;
 					}
@@ -888,35 +888,35 @@ 
 			{
 				if ($op != 'AND')
 				{
-					$db_filter[] = '('.$this->db->column_data_implode(' '.$op.' ',$query).')';
+					$db_filter[] = '('.$this->db->column_data_implode(' '.$op.' ', $query).')';
 				}
 				else
 				{
-					$db_filter = array_merge($db_filter,$query);
+					$db_filter = array_merge($db_filter, $query);
 				}
 			}
 			$query = $db_filter;
 		}
-		if ((int) $this->debug >= 4)
+		if ((int)$this->debug >= 4)
 		{
-			echo "<p>so_sql::search(,only_keys=$only_keys,order_by='$order_by',wildcard='$wildcard',empty=$empty,$op,start='$start',".print_r($filter,true).") query=".print_r($query,true).", total='$this->total'</p>\n";
+			echo "<p>so_sql::search(,only_keys=$only_keys,order_by='$order_by',wildcard='$wildcard',empty=$empty,$op,start='$start',".print_r($filter, true).") query=".print_r($query, true).", total='$this->total'</p>\n";
 			echo "<br>criteria = "; _debug_array($criteria);
 		}
 		if ($only_keys === true)
 		{
 			$colums = array_keys($this->db_key_cols);
-			foreach($colums as &$column)
+			foreach ($colums as &$column)
 			{
-				$column = $this->table_name . '.' . $column;
+				$column = $this->table_name.'.'.$column;
 			}
 		}
 		elseif (is_array($only_keys))
 		{
 			$colums = array();
-			foreach($only_keys as $key => $col)
+			foreach ($only_keys as $key => $col)
 			{
 				//Convert ambiguous columns to prefixed tablename.column name
-				$colums[] = ($db_col = array_search($col,$this->db_cols)) ?  $this->table_name .'.'.$db_col.' AS '.$col :$col;
+				$colums[] = ($db_col = array_search($col, $this->db_cols)) ? $this->table_name.'.'.$db_col.' AS '.$col : $col;
 			}
 		}
 		elseif (!$only_keys)
@@ -946,20 +946,20 @@ 
 			{
 				$colums[$key] = $this->table_name.'.'.$this->autoinc_id.' AS '.$this->autoinc_id;
 			}
-			elseif (!is_array($colums) && strpos($colums,$this->autoinc_id) !== false)
+			elseif (!is_array($colums) && strpos($colums, $this->autoinc_id) !== false)
 			{
-				$colums = preg_replace('/(?<! AS)([ ,]+)'.preg_quote($this->autoinc_id).'([ ,]+)/','\\1'.$this->table_name.'.'.$this->autoinc_id.' AS '.$this->autoinc_id.'\\2',$colums);
+				$colums = preg_replace('/(?<! AS)([ ,]+)'.preg_quote($this->autoinc_id).'([ ,]+)/', '\\1'.$this->table_name.'.'.$this->autoinc_id.' AS '.$this->autoinc_id.'\\2', $colums);
 			}
 		}
-		$num_rows = 0;	// as spec. in max_matches in the user-prefs
-		if (is_array($start)) list($start,$num_rows) = $start;
+		$num_rows = 0; // as spec. in max_matches in the user-prefs
+		if (is_array($start)) list($start, $num_rows) = $start;
 
 		// fix GROUP BY clause to contain all non-aggregate selected columns
-		if ($order_by && stripos($order_by,'GROUP BY') !== false)
+		if ($order_by && stripos($order_by, 'GROUP BY') !== false)
 		{
 			$order_by = $this->fix_group_by_columns($order_by, $colums, $this->table_name, $this->autoinc_id);
 		}
-		elseif ($order_by && stripos($order_by,'ORDER BY')===false && stripos($order_by,'GROUP BY')===false && stripos($order_by,'HAVING')===false)
+		elseif ($order_by && stripos($order_by, 'ORDER BY') === false && stripos($order_by, 'GROUP BY') === false && stripos($order_by, 'HAVING') === false)
 		{
 			$order_by = 'ORDER BY '.$order_by;
 		}
@@ -982,9 +982,9 @@ 
 				);
 				if (!$union_cols)	// union used the colum-names of the first query
 				{
-					$union_cols = $this->_get_columns($only_keys,$extra_cols);
+					$union_cols = $this->_get_columns($only_keys, $extra_cols);
 				}
-				return true;	// waiting for further calls, before running the union-query
+				return true; // waiting for further calls, before running the union-query
 			}
 			// running the union query now
 			if ($start !== false)	// need to get the total too, saved in $this->total
@@ -995,10 +995,10 @@ 
 				}
 				else	// cant do a count, have to run the query without limit
 				{
-					$this->total = $this->db->union($union,__LINE__,__FILE__)->NumRows();
+					$this->total = $this->db->union($union, __LINE__, __FILE__)->NumRows();
 				}
 			}
-			$rs = $this->db->union($union,__LINE__,__FILE__,$order_by,$start,$num_rows);
+			$rs = $this->db->union($union, __LINE__, __FILE__, $order_by, $start, $num_rows);
 			if ($this->debug) error_log(__METHOD__."() ".$this->db->Query_ID->sql);
 
 			$cols = $union_cols;
@@ -1012,21 +1012,21 @@ 
 				{
 					$mysql_calc_rows = 'SQL_CALC_FOUND_ROWS ';
 				}
-				elseif (!$need_full_no_count && (!$join || stripos($join,'LEFT JOIN')!==false))
+				elseif (!$need_full_no_count && (!$join || stripos($join, 'LEFT JOIN') !== false))
 				{
-					$this->total = $this->db->select($this->table_name,'COUNT(*)',$query,__LINE__,__FILE__,false,'',$this->app,0,$join)->fetchColumn();
+					$this->total = $this->db->select($this->table_name, 'COUNT(*)', $query, __LINE__, __FILE__, false, '', $this->app, 0, $join)->fetchColumn();
 				}
 				else	// cant do a count, have to run the query without limit
 				{
-					$this->total = $this->db->select($this->table_name,$colums,$query,__LINE__,__FILE__,false,$order_by,false,0,$join)->NumRows();
+					$this->total = $this->db->select($this->table_name, $colums, $query, __LINE__, __FILE__, false, $order_by, false, 0, $join)->NumRows();
 				}
 			}
-			$rs = $this->db->select($this->table_name,$mysql_calc_rows.$colums,$query,__LINE__,__FILE__,
-				$start,$order_by,$this->app,$num_rows,$join);
+			$rs = $this->db->select($this->table_name, $mysql_calc_rows.$colums, $query, __LINE__, __FILE__,
+				$start, $order_by, $this->app, $num_rows, $join);
 			if ($this->debug) error_log(__METHOD__."() ".$this->db->Query_ID->sql);
-			$cols = $this->_get_columns($only_keys,$extra_cols);
+			$cols = $this->_get_columns($only_keys, $extra_cols);
 		}
-		if ((int) $this->debug >= 4) echo "<p>sql='{$this->db->Query_ID->sql}'</p>\n";
+		if ((int)$this->debug >= 4) echo "<p>sql='{$this->db->Query_ID->sql}'</p>\n";
 
 		if ($mysql_calc_rows)
 		{
@@ -1035,14 +1035,14 @@ 
 		// ToDo: Implement that as an iterator, as $rs is also an interator and we could return one instead of an array
 		if ($this->search_return_iterator)
 		{
-			return new Db2DataIterator($this,$rs);
+			return new Db2DataIterator($this, $rs);
 		}
 		$arr = array();
 		$n = 0;
-		if ($rs) foreach($rs as $row)
+		if ($rs) foreach ($rs as $row)
 		{
 			$data = array();
-			foreach($cols as $db_col => $col)
+			foreach ($cols as $db_col => $col)
 			{
 				$data[$col] = (isset($row[$db_col]) ? $row[$db_col] : $row[$col]);
 			}
@@ -1066,7 +1066,7 @@ 
 	protected function parse_search(Array $_criteria, $wildcard, $empty, $op)
 	{
 		$criteria = $this->data2db($_criteria);
-		foreach($criteria as $col => $val)
+		foreach ($criteria as $col => $val)
 		{
 			if (is_int($col))
 			{
@@ -1074,7 +1074,7 @@ 
 			}
 			elseif ($empty || $val != '')
 			{
-				if (!($db_col = array_search($col,$this->db_cols)))
+				if (!($db_col = array_search($col, $this->db_cols)))
 				{
 					$db_col = $col;
 				}
@@ -1085,7 +1085,7 @@ 
 						$this->table_def['fd'][$db_col]['nullable'] !== false)
 					{
 						unset($criteria[$col]);
-						$query[] =  '(' . $db_col . ' IS NULL OR ' . $db_col . " = '')";
+						$query[] = '('.$db_col.' IS NULL OR '.$db_col." = '')";
 					}
 					else
 					{
@@ -1093,10 +1093,10 @@ 
 					}
 				}
 				elseif ($wildcard || $criteria[$col][0] == '!' ||
-					is_string($criteria[$col]) && (strpos($criteria[$col],'*')!==false || strpos($criteria[$col],'?')!==false))
+					is_string($criteria[$col]) && (strpos($criteria[$col], '*') !== false || strpos($criteria[$col], '?') !== false))
 				{
 					// if search pattern alread contains a wildcard, do NOT add further ones automatic
-					if (is_string($criteria[$col]) && (strpos($criteria[$col],'*')!==false || strpos($criteria[$col],'?')!==false))
+					if (is_string($criteria[$col]) && (strpos($criteria[$col], '*') !== false || strpos($criteria[$col], '?') !== false))
 					{
 						$wildcard = '';
 					}
@@ -1105,19 +1105,19 @@ 
 					if ($criteria[$col][0] == '!')
 					{
 						$cmp_op = ' NOT'.$cmp_op;
-						$criteria[$col] = substr($criteria[$col],1);
+						$criteria[$col] = substr($criteria[$col], 1);
 						$negate = true;
 					}
-					foreach(explode(' ',$criteria[$col]) as $crit)
+					foreach (explode(' ', $criteria[$col]) as $crit)
 					{
 						$query[] = ($negate ? ' ('.$db_col.' IS NULL OR ' : '').$db_col.$cmp_op.
-							$this->db->quote($wildcard.str_replace(array('%','_','*','?'),array('\\%','\\_','%','_'),$crit).$wildcard).
+							$this->db->quote($wildcard.str_replace(array('%', '_', '*', '?'), array('\\%', '\\_', '%', '_'), $crit).$wildcard).
 							($negate ? ') ' : '');
 					}
 				}
-				elseif (strpos($db_col,'.') !== false)	// we have a table-name specified
+				elseif (strpos($db_col, '.') !== false)	// we have a table-name specified
 				{
-					list($table,$only_col) = explode('.',$db_col);
+					list($table, $only_col) = explode('.', $db_col);
 					$type = $this->db->get_column_attribute($only_col, $table, true, 'type');
 					if (empty($type))
 					{
@@ -1125,15 +1125,15 @@ 
 					}
 					if (is_array($val) && count($val) > 1)
 					{
-						foreach($val as &$v)
+						foreach ($val as &$v)
 						{
 							$v = $this->db->quote($v, $type);
 						}
-						$query[] = $sql = $db_col.' IN (' .implode(',',$val).')';
+						$query[] = $sql = $db_col.' IN ('.implode(',', $val).')';
 					}
 					else
 					{
-						$query[] = $db_col.'='.$this->db->quote(is_array($val)?array_shift($val):$val,$type);
+						$query[] = $db_col.'='.$this->db->quote(is_array($val) ?array_shift($val) : $val, $type);
 					}
 				}
 				else
@@ -1142,7 +1142,7 @@ 
 				}
 			}
 		}
-		if (is_array($query) && $op != 'AND') $query = $this->db->column_data_implode(' '.$op.' ',$query);
+		if (is_array($query) && $op != 'AND') $query = $this->db->column_data_implode(' '.$op.' ', $query);
 		return $query;
 	}
 
@@ -1166,7 +1166,7 @@ 
 		$matches = null;
 		if (substr($GLOBALS['egw']->db->Type, 0, 5) == 'mysql' || !preg_match('/(GROUP BY .*)(HAVING.*|ORDER BY.*)?$/iU', $group_by, $matches))
 		{
-			return $group_by;	// nothing to do
+			return $group_by; // nothing to do
 		}
 		$changes = 0;
 		$group_by_cols = preg_split('/, */', trim(substr($matches[1], 9)));
@@ -1176,9 +1176,9 @@ 
 			$columns = preg_split('/, */', $columns);
 
 			// fix columns containing commas as part of function calls
-			for($n = 0; $n < count($columns); ++$n)
+			for ($n = 0; $n < count($columns); ++$n)
 			{
-				$col =& $columns[$n];
+				$col = & $columns[$n];
 				while (substr_count($col, '(') > substr_count($col, ')') && ++$n < count($columns))
 				{
 					$col .= ','.$columns[$n];
@@ -1187,7 +1187,7 @@ 
 			}
 			unset($col);
 		}
-		foreach($columns as $n => $col)
+		foreach ($columns as $n => $col)
 		{
 			if ($col == '*')
 			{
@@ -1200,7 +1200,7 @@ 
 			{
 				if (($pos = stripos($col, 'DISTINCT ')) !== false)
 				{
-					$col = substr($col, $pos+9);
+					$col = substr($col, $pos + 9);
 				}
 				$alias = $col;
 				if (stripos($col, ' AS ')) list($col, $alias) = preg_split('/ +AS +/i', $col);
@@ -1218,7 +1218,7 @@ 
 		$ret = $group_by;
 		if ($changes)
 		{
-			$ret = str_replace($matches[1], 'GROUP BY '.implode(',', $group_by_cols).' ',  $group_by);
+			$ret = str_replace($matches[1], 'GROUP BY '.implode(',', $group_by_cols).' ', $group_by);
 			//error_log(__METHOD__."('$group_by', ".array2string($columns).") group_by_cols=".array2string($group_by_cols)." changed to $ret");
 		}
 		return $ret;
@@ -1238,12 +1238,12 @@ 
 	 * @param array $search_cols =array() List of columns to search.  If not provided, all columns in $this->db_cols will be considered
 	 * @return array or column => value pairs
 	 */
-	public function search2criteria($_pattern,&$wildcard='',&$op='AND',$extra_col=null, $search_cols = array())
+	public function search2criteria($_pattern, &$wildcard = '', &$op = 'AND', $extra_col = null, $search_cols = array())
 	{
 		$pattern = trim($_pattern);
 		// This function can get called multiple times.  Make sure it doesn't re-process.
 		if (empty($pattern) || is_array($pattern)) return $pattern;
-		if(strpos($pattern, 'CAST(COALESCE(') !== false)
+		if (strpos($pattern, 'CAST(COALESCE(') !== false)
 		{
 			return $pattern;
 		}
@@ -1260,24 +1260,24 @@ 
 		$numeric_columns = array();
 
 		// Special handling for an ID search, #<int>
-		if(strpos($_pattern, '#') === 0 && is_numeric(substr($_pattern, 1)))
+		if (strpos($_pattern, '#') === 0 && is_numeric(substr($_pattern, 1)))
 		{
-			return array('(' . $this->table_name.'.'. $this->autoinc_id . '=' . (int)substr($_pattern,1) . ')');
+			return array('('.$this->table_name.'.'.$this->autoinc_id.'='.(int)substr($_pattern, 1).')');
 		}
-		if(!$search_cols)
+		if (!$search_cols)
 		{
 			$search_cols = $this->get_default_search_columns();
 		}
 		// Concat all fields to be searched together, so the conditions operate across the whole record
-		foreach($search_cols as $col)
+		foreach ($search_cols as $col)
 		{
 			$col_name = $col;
 			$table = $this->table_name;
-			if (strpos($col,'.') !== false)
+			if (strpos($col, '.') !== false)
 			{
-				list($table,$col_name) = explode('.',$col);
+				list($table, $col_name) = explode('.', $col);
 			}
-			$table_def = $table == $this->table_name ? $this->table_def : $this->db->get_table_definitions(true,$table);
+			$table_def = $table == $this->table_name ? $this->table_def : $this->db->get_table_definitions(true, $table);
 			if ($table_def['fd'][$col_name] && in_array($table_def['fd'][$col_name]['type'], $numeric_types))
 			{
 				$numeric_columns[] = $col;
@@ -1285,11 +1285,11 @@ 
 			}
 			if ($this->db->Type == 'mysql' && $table_def['fd'][$col_name]['type'] === 'ascii' && preg_match('/[\x80-\xFF]/', $_pattern))
 			{
-				continue;	// will only give sql error
+				continue; // will only give sql error
 			}
-			$columns[] = sprintf($this->db->capabilities[Api\Db::CAPABILITY_CAST_AS_VARCHAR],"COALESCE($col,'')");
+			$columns[] = sprintf($this->db->capabilities[Api\Db::CAPABILITY_CAST_AS_VARCHAR], "COALESCE($col,'')");
 		}
-		if(!$columns)
+		if (!$columns)
 		{
 			return array();
 		}
@@ -1298,9 +1298,9 @@ 
 		$break = ' ';
 		$token = strtok($pattern, $break);
 
-		while($token)
+		while ($token)
 		{
-			if($token == strtoupper(lang('AND')) || $token == 'AND')
+			if ($token == strtoupper(lang('AND')) || $token == 'AND')
 			{
 				$token = '+'.strtok($break);
 			}
@@ -1313,10 +1313,10 @@ 
 			{
 				$token = '-'.strtok($break);
 			}
-			if ($token[0]=='"')
+			if ($token[0] == '"')
 			{
-				$token = substr($token, 1,strlen($token));
- 				if(substr($token, -1) != '"')
+				$token = substr($token, 1, strlen($token));
+ 				if (substr($token, -1) != '"')
 				{
 					$token .= ' '.strtok('"');
 				}
@@ -1327,16 +1327,16 @@ 
 			}
 
 			// prepend and append extra wildcard %, if pattern does NOT already contain wildcards
-			if (strpos($token,'*') === false && strpos($token,'?') === false)
+			if (strpos($token, '*') === false && strpos($token, '?') === false)
 			{
-				$wildcard = '%';	// if pattern contains no wildcards, add them before AND after the pattern
+				$wildcard = '%'; // if pattern contains no wildcards, add them before AND after the pattern
 			}
 			else
 			{
-				$wildcard = '';		// no extra wildcard, if pattern already contains some
+				$wildcard = ''; // no extra wildcard, if pattern already contains some
 			}
 
-			switch($token[0])
+			switch ($token[0])
 			{
 				case '+':
 					$op = 'AND';
@@ -1351,9 +1351,9 @@ 
 					$op = 'OR';
 					break;
 			}
-			$search_token = $wildcard.str_replace(array('%','_','*','?'),array('\\%','\\_','%','_'),$token).$wildcard;
-			$token_filter = ' '.call_user_func_array(array($GLOBALS['egw']->db,'concat'),$columns).' '.
-				$this->db->capabilities['case_insensitive_like'] . ' ' .
+			$search_token = $wildcard.str_replace(array('%', '_', '*', '?'), array('\\%', '\\_', '%', '_'), $token).$wildcard;
+			$token_filter = ' '.call_user_func_array(array($GLOBALS['egw']->db, 'concat'), $columns).' '.
+				$this->db->capabilities['case_insensitive_like'].' '.
 				$GLOBALS['egw']->db->quote($search_token);
 
 			// if we have customfields and this is Api\Storage (not Api\Storage\Base)
@@ -1365,26 +1365,26 @@ 
 
 			// Compare numeric token as equality for numeric columns
 			// skip user-wildcards (*,?) in is_numeric test, but not SQL wildcards, which get escaped and give sql-error
-			if (is_numeric(str_replace(array('*','?'), '', $token)))
+			if (is_numeric(str_replace(array('*', '?'), '', $token)))
 			{
 				$numeric_filter = array();
-				foreach($numeric_columns as $col)
+				foreach ($numeric_columns as $col)
 				{
-					if($wildcard == '')
+					if ($wildcard == '')
 					{
 						// Token has a wildcard from user, use LIKE
-						$numeric_filter[] = "($col IS NOT NULL AND CAST($col AS CHAR) " .
-							$this->db->capabilities['case_insensitive_like'] . ' ' .
-							$GLOBALS['egw']->db->quote(str_replace(array('*','?'), array('%','_'), $token)) . ')';
+						$numeric_filter[] = "($col IS NOT NULL AND CAST($col AS CHAR) ".
+							$this->db->capabilities['case_insensitive_like'].' '.
+							$GLOBALS['egw']->db->quote(str_replace(array('*', '?'), array('%', '_'), $token)).')';
 					}
 					else
 					{
 						$numeric_filter[] = "($col IS NOT NULL AND $col = $token)";
 					}
 				}
-				if(count($numeric_filter) > 0)
+				if (count($numeric_filter) > 0)
 				{
-					$token_filter .= ' OR ' . implode(' OR ', $numeric_filter);
+					$token_filter .= ' OR '.implode(' OR ', $numeric_filter);
 				}
 			}
 			$criteria[$op][] = '('.$token_filter.')';
@@ -1392,32 +1392,32 @@ 
 			$token = strtok($break);
 		}
 
-		if($criteria['NOT'])
+		if ($criteria['NOT'])
 		{
-			$filter[] = 'NOT (' . implode(' OR ', $criteria['NOT']) . ') ';
+			$filter[] = 'NOT ('.implode(' OR ', $criteria['NOT']).') ';
 		}
-		if($criteria['AND'])
+		if ($criteria['AND'])
 		{
-			$filter[] = implode(' AND ', $criteria['AND']) . ' ';
+			$filter[] = implode(' AND ', $criteria['AND']).' ';
 		}
-		if($criteria['OR'])
+		if ($criteria['OR'])
 		{
-			$filter[] = '(' . implode(' OR ', $criteria['OR']) . ') ';
+			$filter[] = '('.implode(' OR ', $criteria['OR']).') ';
 		}
 
-		if(count($filter))
+		if (count($filter))
 		{
-			$result = '(' . implode(' AND ', $filter) . ')';
+			$result = '('.implode(' AND ', $filter).')';
 		}
 
 		// OR extra column on the end so a null or blank won't block a hit in the main columns
 		if ($extra_col)
 		{
-			$result .= (strlen($result) ? ' OR ' : ' ') . "$extra_col = " . $GLOBALS['egw']->db->quote($pattern);
+			$result .= (strlen($result) ? ' OR ' : ' ')."$extra_col = ".$GLOBALS['egw']->db->quote($pattern);
 		}
 
 		$op = 'OR';
-		return array('(' . $result . ')');
+		return array('('.$result.')');
 	}
 
 	/**
@@ -1436,21 +1436,21 @@ 
 		$numeric_types = array('auto', 'int', 'float', 'double');
 
 		// Skip some numeric columns that don't make sense to search if we have to default to all columns
-		if(is_null($this->columns_to_search))
+		if (is_null($this->columns_to_search))
 		{
-			foreach($search_cols as $key => &$col)
+			foreach ($search_cols as $key => &$col)
 			{
 				// If the name as given isn't a real column name, and adding the prefix doesn't help, skip it
-				if(!$this->table_def['fd'][$col] && !($col = $this->prefix.array_search($col, $search_cols))) {
+				if (!$this->table_def['fd'][$col] && !($col = $this->prefix.array_search($col, $search_cols))) {
 					// Can't search this column
 					unset($search_cols[$key]);
 					continue;
 				}
-				if(in_array($this->table_def['fd'][$col]['type'], $numeric_types))
+				if (in_array($this->table_def['fd'][$col]['type'], $numeric_types))
 				{
-					foreach($skip_columns_with as $bad)
+					foreach ($skip_columns_with as $bad)
 					{
-						if(strpos($col, $bad) !== false)
+						if (strpos($col, $bad) !== false)
 						{
 							unset($search_cols[$key]);
 							continue 2;
@@ -1472,7 +1472,7 @@ 
 	 * @param string|array $extra_cols ='' string or array of strings to be added to the SELECT, eg. "count(*) as num"
 	 * @return array with columns as db-name => internal-name pairs
 	 */
-	function _get_columns($only_keys,$extra_cols)
+	function _get_columns($only_keys, $extra_cols)
 	{
 		//echo "_get_columns() only_keys="; _debug_array($only_keys); echo "extra_cols="; _debug_array($extra_cols);
 		if ($only_keys === true)	// only primary key
@@ -1483,7 +1483,7 @@ 
 		{
 			$cols = array();
 			$distinct_checked = false;
-			foreach(is_array($only_keys) ? $only_keys : explode(',', $only_keys) as $col)
+			foreach (is_array($only_keys) ? $only_keys : explode(',', $only_keys) as $col)
 			{
 				if (!$distinct_checked)
 				{
@@ -1492,17 +1492,17 @@ 
 				}
 				if (!$col || $col == '*' || $col == $this->table_name.'.*')	// all columns
 				{
-					$cols = array_merge($cols,$this->db_cols);
+					$cols = array_merge($cols, $this->db_cols);
 				}
 				else	// only the specified columns
 				{
-					if (stripos($col,'as'))	// if there's already an explicit naming of the column, just use it
+					if (stripos($col, 'as'))	// if there's already an explicit naming of the column, just use it
 					{
-						$col = preg_replace('/^.*as +([a-z0-9_]+) *$/i','\\1',$col);
+						$col = preg_replace('/^.*as +([a-z0-9_]+) *$/i', '\\1', $col);
 						$cols[$col] = $col;
 						continue;
 					}
-					if (($db_col = array_search($col,$this->db_cols)) !== false)
+					if (($db_col = array_search($col, $this->db_cols)) !== false)
 					{
 						$cols[$db_col] = $col;
 					}
@@ -1515,10 +1515,10 @@ 
 		}
 		if ($extra_cols)	// extra columns to report
 		{
-			foreach(is_array($extra_cols) ? $extra_cols : explode(',',$extra_cols) as $col)
+			foreach (is_array($extra_cols) ? $extra_cols : explode(',', $extra_cols) as $col)
 			{
-				if (stripos($col,'as ')!==false) $col = preg_replace('/^.*as +([a-z0-9_]+) *$/i','\\1',$col);
-				if (($db_col = array_search($col,$this->db_cols)) !== false)
+				if (stripos($col, 'as ') !== false) $col = preg_replace('/^.*as +([a-z0-9_]+) *$/i', '\\1', $col);
+				if (($db_col = array_search($col, $this->db_cols)) !== false)
 				{
 					$cols[$db_col] = $col;
 				}
@@ -1545,12 +1545,12 @@ 
 	 * @param string|array $extra_cols =array()
 	 * @return int total number of rows
 	 */
-	function get_rows($query,&$rows,&$readonlys,$join='',$need_full_no_count=false,$only_keys=false,$extra_cols=array())
+	function get_rows($query, &$rows, &$readonlys, $join = '', $need_full_no_count = false, $only_keys = false, $extra_cols = array())
 	{
-		unset($readonlys);	// required by function signature, but not used in this default implementation
-		if ((int) $this->debug >= 4)
+		unset($readonlys); // required by function signature, but not used in this default implementation
+		if ((int)$this->debug >= 4)
 		{
-			echo "<p>so_sql::get_rows(".print_r($query,true).",,)</p>\n";
+			echo "<p>so_sql::get_rows(".print_r($query, true).",,)</p>\n";
 		}
 		$criteria = array();
 		$op = 'AND';
@@ -1558,11 +1558,11 @@ 
 		{
 			$criteria = $query['search'];
 		}
-		$rows = $this->search($criteria,$only_keys,$query['order']?$query['order'].' '.$query['sort']:'',$extra_cols,
-			'',false,$op,$query['num_rows']?array((int)$query['start'],$query['num_rows']):(int)$query['start'],
-			$query['col_filter'],$join,$need_full_no_count);
+		$rows = $this->search($criteria, $only_keys, $query['order'] ? $query['order'].' '.$query['sort'] : '', $extra_cols,
+			'', false, $op, $query['num_rows'] ? array((int)$query['start'], $query['num_rows']) : (int)$query['start'],
+			$query['col_filter'], $join, $need_full_no_count);
 
-		if (!$rows) $rows = array();	// otherwise false returned from search would be returned as array(false)
+		if (!$rows) $rows = array(); // otherwise false returned from search would be returned as array(false)
 
 		return $this->total;
 	}
@@ -1573,7 +1573,7 @@ 
 	 * @param array $data =null data-set to check, defaults to $this->data
 	 * @return int 0: all keys are unique, 1: first key not unique, 2: ...
 	 */
-	function not_unique($data=null)
+	function not_unique($data = null)
 	{
 		if (!is_array($data))
 		{
@@ -1586,12 +1586,12 @@ 
 		{
 			$uni_keys[] = $this->db_key_cols;
 		}
-		foreach($uni_keys as $db_col => $col)
+		foreach ($uni_keys as $db_col => $col)
 		{
 			if (is_array($col))
 			{
 				$query = array();
-				foreach($col as $db_c => $c)
+				foreach ($col as $db_c => $c)
 				{
 					$query[$db_c] = $data[$c];
 				}
@@ -1600,17 +1600,17 @@ 
 			{
 				$query = array($db_col => $data[$col]);
 			}
-			foreach($this->db->select($this->table_name,$this->db_key_cols,$query,__LINE__,__FILE__,false,'',$this->app) as $other)
+			foreach ($this->db->select($this->table_name, $this->db_key_cols, $query, __LINE__, __FILE__, false, '', $this->app) as $other)
 			{
-				foreach($this->db_key_cols as $key_col)
+				foreach ($this->db_key_cols as $key_col)
 				{
 					if ($data[$key_col] != $other[$key_col])
 					{
-						if ((int) $this->debug >= 4)
+						if ((int)$this->debug >= 4)
 						{
 							echo "<p>not_unique in ".array2string($col)." as for '$key_col': '${data[$key_col]}' != '${other[$key_col]}'</p>\n";
 						}
-						return $n;	// different entry => $n not unique
+						return $n; // different entry => $n not unique
 					}
 				}
 			}
@@ -1631,7 +1631,7 @@ 
 	 * @param string $order ='' order, default '' = same as (first) $value_col
 	 * @return array with key_col => value_col pairs or array if more then one value_col given (keys as in value_col)
 	 */
-	function query_list($value_col,$key_col='',$filter=array(),$order='')
+	function query_list($value_col, $key_col = '', $filter = array(), $order = '')
 	{
 		static $cache = array();
 
@@ -1644,16 +1644,16 @@ 
 		if (!is_array($value_col)) $value_col = array($value_col);
 
 		$cols = $ret = array();
-		foreach($value_col as $key => $col)
+		foreach ($value_col as $key => $col)
 		{
 			$matches = null;
-			$cols[$key] = preg_match('/AS ([a-z_0-9]+)$/i',$col,$matches) ? $matches[1] : $col;
+			$cols[$key] = preg_match('/AS ([a-z_0-9]+)$/i', $col, $matches) ? $matches[1] : $col;
 		}
 		if (!$order) $order = current($cols);
 
-		if (($search =& $this->search(array(),($key_col ? $key_col.',' : 'DISTINCT ').implode(',',$value_col),$order,'','',false,'AND',false,$filter)))
+		if (($search = & $this->search(array(), ($key_col ? $key_col.',' : 'DISTINCT ').implode(',', $value_col), $order, '', '', false, 'AND', false, $filter)))
 		{
-			if (preg_match('/AS ([a-z_0-9]+)$/i',$key_col,$matches))
+			if (preg_match('/AS ([a-z_0-9]+)$/i', $key_col, $matches))
 			{
 				$key_col = $matches[1];
 			}
@@ -1661,12 +1661,12 @@ 
 			{
 				$key_col = current($cols);
 			}
-			foreach($search as $row)
+			foreach ($search as $row)
 			{
 				if (count($cols) > 1)
 				{
 					$data = array();
-					foreach($cols as $key => $col)
+					foreach ($cols as $key => $col)
 					{
 						$data[$key] = $row[$col];
 					}
@@ -1678,7 +1678,7 @@ 
 				if ($data) $ret[$row[$key_col]] = $data;
 			}
 		}
-		return $cache[$cache_key] =& $ret;
+		return $cache[$cache_key] = & $ret;
 	}
 
 	/**
@@ -1687,13 +1687,13 @@ 
 	 * @param string $column =null name of column or null for all (default)
 	 * @return array|string array with internal-name => comment pairs, or string with comment, if $column given
 	 */
-	public function get_comments($column=null)
+	public function get_comments($column = null)
 	{
-		static $comments=null;
+		static $comments = null;
 
 		if (is_null($comments))
 		{
-			foreach($this->db_cols as $db_col => $col)
+			foreach ($this->db_cols as $db_col => $col)
 			{
 				$comments[$col] = $this->table_def['fd'][$db_col]['comment'];
 			}

Upper-Lower-Casing +1 added lines, -1 removed lines

@@ -1063,7 +1063,7 @@
 	 * @return Array
 	 * @throws Api\Db\Exception
 	 */
-	protected function parse_search(Array $_criteria, $wildcard, $empty, $op)
+	protected function parse_search(array $_criteria, $wildcard, $empty, $op)
 	{
 		$criteria = $this->data2db($_criteria);
 		foreach($criteria as $col => $val)