EGroupware / egroupware

install-cli.php

Spacing +19 added lines, -19 removed lines

@@ -35,7 +35,7 @@ 
  * @license http://opensource.org/licenses/gpl-license.php GPL - GNU General Public License
  */
 
-chdir(__DIR__);	// to enable relative pathes to work
+chdir(__DIR__); // to enable relative pathes to work
 
 if (php_sapi_name() !== 'cli')	// security precaution: forbit calling setup-cli as web-page
 {
@@ -49,11 +49,11 @@ 
 $argv = $_SERVER['argv'];
 $cmd  = array_shift($argv);
 
-foreach($argv as $n => $arg)
+foreach ($argv as $n => $arg)
 {
 	if ($arg[0] === '-')
 	{
-		switch($arg)
+		switch ($arg)
 		{
 			case '-v':
 			case '--verbose':
@@ -78,7 +78,7 @@ 
 
 if (count($argv) > 1) usage("Too many arguments!");
 
-function usage($err=null)
+function usage($err = null)
 {
 	global $cmd;
 
@@ -99,9 +99,9 @@ 
 );
 
 // check if the necessary binaries are installed
-foreach($bins as $name => $binaries)
+foreach ($bins as $name => $binaries)
 {
-	foreach((array)$binaries as $bin)
+	foreach ((array)$binaries as $bin)
 	{
 		if (file_exists($bin) && is_executable($bin))
 		{
@@ -119,7 +119,7 @@ 
 	{
 		$bins[$name] = $$name = false;
 		error_log("Could not find $name command!");
-		if (!in_array($name, ['npm','grunt']))
+		if (!in_array($name, ['npm', 'grunt']))
 		{
 			exit(1);
 		}
@@ -131,7 +131,7 @@ 
 	}
 }
 
-if ($verbose) echo "Using following binaries: ".json_encode ($bins, JSON_UNESCAPED_SLASHES)."\n";
+if ($verbose) echo "Using following binaries: ".json_encode($bins, JSON_UNESCAPED_SLASHES)."\n";
 
 if (!extension_loaded('curl')) die("Required PHP extesion 'curl' missing! You need to install php-curl package.\n\n");
 
@@ -140,14 +140,14 @@ 
 if (!$git || !file_exists(__DIR__.'/.git') || !is_dir(__DIR__.'/.git') ||
 	!exec($git.' branch --no-color', $output, $ret) || $ret)
 {
-	foreach($output as $line)
+	foreach ($output as $line)
 	{
 		error_log($line);
 	}
 	error_log("Could not identify git branch (you need to use git clone or composer create-project --prefer-source --keep-vcs egroupware/egroupware)!");
 	exit(1);
 }
-foreach($output as $line)
+foreach ($output as $line)
 {
 	if ($line[0] == '*')
 	{
@@ -194,7 +194,7 @@ 
 echo "Updating to: $target\n";
 
 // Update EGroupware itself and further apps installed via git
-foreach(scandir(__DIR__) as $dir)
+foreach (scandir(__DIR__) as $dir)
 {
 	if ($dir !== '..' && file_exists(__DIR__.'/'.$dir.'/.git') &&
 		// these apps / dirs are managed by composer, no need to run manual updates
@@ -244,9 +244,9 @@ 
  * @param boolean $return_name =true true: just return name, false: full release object
  * @return array|string|null null if no release found
  */
-function get_latest_release($prerelease=false, $return_name=true)
+function get_latest_release($prerelease = false, $return_name = true)
 {
-	foreach(github_api('/repos/egroupware/egroupware/releases', [], 'GET') as $release)
+	foreach (github_api('/repos/egroupware/egroupware/releases', [], 'GET') as $release)
 	{
 		if ($prerelease || $release['prerelease'] === false)
 		{
@@ -266,7 +266,7 @@ 
  * @throws Exception
  * @return array with response
  */
-function github_api($_url, $data, $method='POST', $upload=null, $content_type=null)
+function github_api($_url, $data, $method = 'POST', $upload = null, $content_type = null)
 {
 	global /*$config,*/ $verbose;
 
@@ -279,7 +279,7 @@ 
 	curl_setopt($c, CURLOPT_TIMEOUT, 240);
 	curl_setopt($c, CURLOPT_FOLLOWLOCATION, true);
 
-	switch($method)
+	switch ($method)
 	{
 		case 'POST':
 			curl_setopt($c, CURLOPT_POST, true);
@@ -287,13 +287,13 @@ 
 			curl_setopt($c, CURLOPT_POSTFIELDS, $data);
 			break;
 		case 'GET':
-			if(count($data)) $url .= '?' . http_build_query($data);
+			if (count($data)) $url .= '?'.http_build_query($data);
 			break;
 		case 'FILE':
 			curl_setopt($c, CURLOPT_HTTPHEADER, array("Content-type: $content_type"));
 			curl_setopt($c, CURLOPT_POST, true);
 			curl_setopt($c, CURLOPT_POSTFIELDS, file_get_contents($upload));
-			if(count($data)) $url .= '?' . http_build_query($data);
+			if (count($data)) $url .= '?'.http_build_query($data);
 			break;
 		default:
 			throw new Exception(__FUNCTION__.": Unknown/unimplemented method=$method!");
@@ -301,7 +301,7 @@ 
 	curl_setopt($c, CURLOPT_URL, $url);
 
 	if (is_string($data)) $short_data = strlen($data) > 100 ? substr($data, 0, 100).' ...' : $data;
-	if ($verbose) echo "Sending $method request to $url ".(isset($short_data)&&$method!='GET'?$short_data:'')."\n";
+	if ($verbose) echo "Sending $method request to $url ".(isset($short_data) && $method != 'GET' ? $short_data : '')."\n";
 
 	if (($response = curl_exec($c)) === false)
 	{
@@ -309,7 +309,7 @@ 
 		curl_setopt($c, CURLOPT_HEADER, true);
 		curl_setopt($c, CURLOPT_RETURNTRANSFER, false);
 		curl_exec($c);
-		throw new Exception("$method request to $url failed ".(isset($short_data)&&$method!='GET'?$short_data:''));
+		throw new Exception("$method request to $url failed ".(isset($short_data) && $method != 'GET' ? $short_data : ''));
 	}
 
 	if ($verbose) echo (strlen($response) > 200 ? substr($response, 0, 200).' ...' : $response)."\n";

Braces +60 added lines, -15 removed lines

@@ -37,10 +37,13 @@ 
 
 chdir(__DIR__);	// to enable relative pathes to work
 
-if (php_sapi_name() !== 'cli')	// security precaution: forbit calling setup-cli as web-page
+if (php_sapi_name() !== 'cli')
+{
+	// security precaution: forbit calling setup-cli as web-page
 {
 	die('<h1>install-cli.php must NOT be called as web-page --> exiting !!!</h1>');
 }
+}
 error_reporting(E_ALL & ~E_NOTICE & ~E_STRICT);
 
 // parse arguments
@@ -76,7 +79,10 @@ 
 	}
 }
 
-if (count($argv) > 1) usage("Too many arguments!");
+if (count($argv) > 1)
+{
+	usage("Too many arguments!");
+}
 
 function usage($err=null)
 {
@@ -131,9 +137,15 @@ 
 	}
 }
 
-if ($verbose) echo "Using following binaries: ".json_encode ($bins, JSON_UNESCAPED_SLASHES)."\n";
+if ($verbose)
+{
+	echo "Using following binaries: ".json_encode ($bins, JSON_UNESCAPED_SLASHES)."\n";
+}
 
-if (!extension_loaded('curl')) die("Required PHP extesion 'curl' missing! You need to install php-curl package.\n\n");
+if (!extension_loaded('curl'))
+{
+	die("Required PHP extesion 'curl' missing! You need to install php-curl package.\n\n");
+}
 
 // check if we are on a git clone
 $output = array();
@@ -165,7 +177,10 @@ 
 {
 	$channel = isset($matches[1]) ? 'release' : 'bugfix';
 }
-if ($verbose) echo "Currently using branch: $branch --> $channel channel\n";
+if ($verbose)
+{
+	echo "Currently using branch: $branch --> $channel channel\n";
+}
 
 if ($argv)
 {
@@ -216,24 +231,36 @@ 
 			$cmd .= "; $git pull --rebase";
 		}
 		$cmd .= "; test -z $($git stash list) || echo $git stash pop";
-		if ($verbose) echo "$cmd\n";
+		if ($verbose)
+		{
+			echo "$cmd\n";
+		}
 		system($cmd);
 	}
 }
 
 // update composer managed dependencies
 $cmd = $composer.' install';
-if ($verbose) echo "$cmd\n";
+if ($verbose)
+{
+	echo "$cmd\n";
+}
 system($cmd);
 
 // update npm dependencies and run grunt to minify javascript and css
 if ($npm && $grunt)
 {
 	$cmd = $npm.' install';
-	if ($verbose) echo "$cmd\n";
+	if ($verbose)
+	{
+		echo "$cmd\n";
+	}
 	system($cmd);
 
-	if ($verbose) echo "$grunt\n";
+	if ($verbose)
+	{
+		echo "$grunt\n";
+	}
 	system($grunt);
 }
 
@@ -283,25 +310,40 @@ 
 	{
 		case 'POST':
 			curl_setopt($c, CURLOPT_POST, true);
-			if (is_array($data)) $data = json_encode($data, JSON_FORCE_OBJECT);
+			if (is_array($data))
+			{
+				$data = json_encode($data, JSON_FORCE_OBJECT);
+			}
 			curl_setopt($c, CURLOPT_POSTFIELDS, $data);
 			break;
 		case 'GET':
-			if(count($data)) $url .= '?' . http_build_query($data);
+			if(count($data))
+			{
+				$url .= '?' . http_build_query($data);
+			}
 			break;
 		case 'FILE':
 			curl_setopt($c, CURLOPT_HTTPHEADER, array("Content-type: $content_type"));
 			curl_setopt($c, CURLOPT_POST, true);
 			curl_setopt($c, CURLOPT_POSTFIELDS, file_get_contents($upload));
-			if(count($data)) $url .= '?' . http_build_query($data);
+			if(count($data))
+			{
+				$url .= '?' . http_build_query($data);
+			}
 			break;
 		default:
 			throw new Exception(__FUNCTION__.": Unknown/unimplemented method=$method!");
 	}
 	curl_setopt($c, CURLOPT_URL, $url);
 
-	if (is_string($data)) $short_data = strlen($data) > 100 ? substr($data, 0, 100).' ...' : $data;
-	if ($verbose) echo "Sending $method request to $url ".(isset($short_data)&&$method!='GET'?$short_data:'')."\n";
+	if (is_string($data))
+	{
+		$short_data = strlen($data) > 100 ? substr($data, 0, 100).' ...' : $data;
+	}
+	if ($verbose)
+	{
+		echo "Sending $method request to $url ".(isset($short_data)&&$method!='GET'?$short_data:'')."\n";
+	}
 
 	if (($response = curl_exec($c)) === false)
 	{
@@ -312,7 +354,10 @@ 
 		throw new Exception("$method request to $url failed ".(isset($short_data)&&$method!='GET'?$short_data:''));
 	}
 
-	if ($verbose) echo (strlen($response) > 200 ? substr($response, 0, 200).' ...' : $response)."\n";
+	if ($verbose)
+	{
+		echo (strlen($response) > 200 ? substr($response, 0, 200).' ...' : $response)."\n";
+	}
 
 	curl_close($c);
 

Upper-Lower-Casing +1 added lines, -1 removed lines

@@ -301,7 +301,7 @@
 	curl_setopt($c, CURLOPT_URL, $url);
 
 	if (is_string($data)) $short_data = strlen($data) > 100 ? substr($data, 0, 100).' ...' : $data;
-	if ($verbose) echo "Sending $method request to $url ".(isset($short_data)&&$method!='GET'?$short_data:'')."\n";
+	if ($verbose) echo "sending $method request to $url ".(isset($short_data)&&$method!='GET'?$short_data:'')."\n";
 
 	if (($response = curl_exec($c)) === false)
 	{