EGroupware / egroupware

addressbook/inc/class.addressbook_contactform.inc.php

Doc Comments +11 added lines, -15 removed lines

@@ -30,14 +30,12 @@ 
 	/**
 	 * Shows the contactform and stores the submitted data
 	 *
-	 * @param array $content=null submitted eTemplate content
-	 * @param int $addressbook=null int owner-id of addressbook to save contacts too
-	 * @param array $fields=null field-names to show
-	 * @param string $msg=null message to show after submitting the form
-	 * @param string $email=null comma-separated email addresses
-	 * @param string $tpl_name=null custom etemplate to use
-	 * @param string $subject=null subject for email
-	 * @param string $copytoreceiver=false send a copy of notification to receiver
+	 * @param array $content submitted eTemplate content
+	 * @param int $addressbook int owner-id of addressbook to save contacts too
+	 * @param array $fields field-names to show
+	 * @param string $tpl_name custom etemplate to use
+	 * @param string $subject subject for email
+	 * @param string $copytoreceiver send a copy of notification to receiver
 	 * @return string html content
 	 */
 	function display(array $content=null,$addressbook=null,$fields=null,$msg=null,$email=null,$tpl_name=null,$subject=null,$copytoreceiver=false,$sel_options=array())
@@ -49,13 +47,11 @@ 
 	 * Shows the contactform and stores the submitted data ($content is a var parameter, eg. for extending classes)
 	 *
 	 * @param array &$content=null submitted eTemplate content
-	 * @param int $addressbook=null int owner-id of addressbook to save contacts too
-	 * @param array $fields=null field-names to show
-	 * @param string $msg=null message to show after submitting the form
-	 * @param string $email=null comma-separated email addresses
-	 * @param string $tpl_name=null custom etemplate to use
-	 * @param string $subject=null subject for email
-	 * @param string $copytoreceiver=false send a copy of notification to receiver
+	 * @param int $addressbook int owner-id of addressbook to save contacts too
+	 * @param array $fields field-names to show
+	 * @param string $tpl_name custom etemplate to use
+	 * @param string $subject subject for email
+	 * @param string $copytoreceiver send a copy of notification to receiver
 	 * @return string html content
 	 */
 	function display_var(array &$content=null,$addressbook=null,$fields=null,$msg=null,$email=null,$tpl_name=null,$subject=null,$copytoreceiver=false,$sel_options=array())

Spacing +25 added lines, -25 removed lines

@@ -40,9 +40,9 @@ 
 	 * @param string $copytoreceiver=false send a copy of notification to receiver
 	 * @return string html content
 	 */
-	function display(array $content=null,$addressbook=null,$fields=null,$msg=null,$email=null,$tpl_name=null,$subject=null,$copytoreceiver=false,$sel_options=array())
+	function display(array $content = null, $addressbook = null, $fields = null, $msg = null, $email = null, $tpl_name = null, $subject = null, $copytoreceiver = false, $sel_options = array())
 	{
-		return $this->display_var($content,$addressbook,$fields,$msg,$email,$tpl_name,$subject,$copytoreceiver,$sel_options);
+		return $this->display_var($content, $addressbook, $fields, $msg, $email, $tpl_name, $subject, $copytoreceiver, $sel_options);
 	}
 
 	/**
@@ -58,23 +58,23 @@ 
 	 * @param string $copytoreceiver=false send a copy of notification to receiver
 	 * @return string html content
 	 */
-	function display_var(array &$content=null,$addressbook=null,$fields=null,$msg=null,$email=null,$tpl_name=null,$subject=null,$copytoreceiver=false,$sel_options=array())
+	function display_var(array &$content = null, $addressbook = null, $fields = null, $msg = null, $email = null, $tpl_name = null, $subject = null, $copytoreceiver = false, $sel_options = array())
 	{
 		#error_log( "<p>addressbook_contactform::display(".print_r($content,true).",$addressbook,".print_r($fields,true).",$msg,$tpl_name)</p>\n");
-		if (empty($tpl_name) && !empty($content['tpl_form_name'])) $tpl_name =$content['tpl_form_name'];
+		if (empty($tpl_name) && !empty($content['tpl_form_name'])) $tpl_name = $content['tpl_form_name'];
 		$tpl = new etemplate($tpl_name ? $tpl_name : 'addressbook.contactform');
 		// initializing some fields
-		if (!$fields) $fields = array('org_name','n_fn','email','tel_work','url','note','captcha');
+		if (!$fields) $fields = array('org_name', 'n_fn', 'email', 'tel_work', 'url', 'note', 'captcha');
 		$submitted = false;
 		// check if submitted
 		if (is_array($content))
 		{
-			if ((isset($content['captcha_result']) && $content['captcha'] != $content['captcha_result']) ||	// no correct captcha OR
-				(time() - $content['start_time'] < 10 &&				// bot indicator (less then 10 sec to fill out the form and
+			if ((isset($content['captcha_result']) && $content['captcha'] != $content['captcha_result']) || // no correct captcha OR
+				(time() - $content['start_time'] < 10 && // bot indicator (less then 10 sec to fill out the form and
 				!$GLOBALS['egw_info']['etemplate']['java_script']))	// javascript disabled)
 			{
 				$submitted = "truebutfalse";
-				$tpl->set_validation_error('captcha',lang('Wrong - try again ...'));
+				$tpl->set_validation_error('captcha', lang('Wrong - try again ...'));
 			}
 			elseif ($content['submitit'])
 			{
@@ -82,11 +82,11 @@ 
 				$contact = new Api\Contacts();
 				if ($content['owner'])	// save the contact in the addressbook
 				{
-					$content['private'] = 0;	// in case default_private is set
+					$content['private'] = 0; // in case default_private is set
 					if (($id = $contact->save($content)))
 					{
 						// check for fileuploads and attach the found files
-						foreach($content as $name => $value)
+						foreach ($content as $name => $value)
 						{
 							if (is_array($value) && isset($value['tmp_name']) && is_readable($value['tmp_name']))
 							{
@@ -95,7 +95,7 @@ 
 								// edit rights for the addressbook used to store the new entry,
 								// which is clearly not wanted securitywise
 								Vfs::$is_root = true;
-								Link::link('addressbook',$id,Link::VFS_APPNAME,$value,$name);
+								Link::link('addressbook', $id, Link::VFS_APPNAME, $value, $name);
 								Vfs::$is_root = false;
 							}
 						}
@@ -114,7 +114,7 @@ 
 					{
 						$tracking = new Api\Contacts\Tracking($contact);
 					}
-					if ($tracking->do_notifications($contact->data2db($content),null))
+					if ($tracking->do_notifications($contact->data2db($content), null))
 					{
 						return '<p align="center">'.$content['msg'].'</p>';
 					}
@@ -137,7 +137,7 @@ 
 			$preserv['email_copytoreceiver'] = $copytoreceiver;
 			#if (!$fields) $fields = array('org_name','n_fn','email','tel_work','url','note','captcha');
 			$custom = 1;
-			foreach($fields as $name)
+			foreach ($fields as $name)
 			{
 				if ($name[0] == '#')	// custom field
 				{
@@ -148,10 +148,10 @@ 
 					}
 					$content['show']['custom'.$custom] = true;
 					$content['customfield'][$custom] = $name;
-					$content['customlabel'][$custom] = $contact->customfields[substr($name,1)]['label'];
+					$content['customlabel'][$custom] = $contact->customfields[substr($name, 1)]['label'];
 					++$custom;
 				}
-				elseif($name == 'adr_one_locality')
+				elseif ($name == 'adr_one_locality')
 				{
 					if (!($content['show'][$name] = $GLOBALS['egw_info']['user']['preferences']['addressbook']['addr_format']))
 					{
@@ -172,18 +172,18 @@ 
 			unset($content['submitit']);
 			$custom = 1;
 			// fieldnames are "defined" by the commit attempt, that way, we do not have to remember them
-			foreach($content as $name => $value) {
-				$preserv[$name]=$value;
+			foreach ($content as $name => $value) {
+				$preserv[$name] = $value;
 				if ($name[0] == '#')     // custom field
 				{
 					static $contact;
 					if (is_null($contact)) $contact = new Api\Contacts();
 					$content['show']['custom'.$custom] = true;
 					$content['customfield'][$custom] = $name;
-					$content['customlabel'][$custom] = $contact->customfields[substr($name,1)]['label'];
+					$content['customlabel'][$custom] = $contact->customfields[substr($name, 1)]['label'];
 					++$custom;
 				}
-				elseif($name == 'adr_one_locality')
+				elseif ($name == 'adr_one_locality')
 				{
 					if (!($content['show'][$name] = $GLOBALS['egw_info']['user']['preferences']['addressbook']['addr_format']))
 					{
@@ -204,17 +204,17 @@ 
 		if ($msg) $preserv['msg'] = $msg;
 
 		// a simple calculation captcha
-		$num1 = rand(1,99);
-		$num2 = rand(1,99);
+		$num1 = rand(1, 99);
+		$num2 = rand(1, 99);
 		if ($num2 > $num1)	// keep the result positive
 		{
 			$n = $num1; $num1 = $num2; $num2 = $n;
 		}
-		if (in_array('captcha',$fields))
+		if (in_array('captcha', $fields))
 		{
-			$content['captcha_task'] = sprintf('%d - %d =',$num1,$num2);
-			$preserv['captcha_result'] = $num1-$num2;
+			$content['captcha_task'] = sprintf('%d - %d =', $num1, $num2);
+			$preserv['captcha_result'] = $num1 - $num2;
 		}
-		return $tpl->exec($this->callback,$content,$sel_options,array(),$preserv);
+		return $tpl->exec($this->callback, $content, $sel_options, array(), $preserv);
 	}
 }

Braces +46 added lines, -13 removed lines

@@ -61,28 +61,41 @@ 
 	function display_var(array &$content=null,$addressbook=null,$fields=null,$msg=null,$email=null,$tpl_name=null,$subject=null,$copytoreceiver=false,$sel_options=array())
 	{
 		#error_log( "<p>addressbook_contactform::display(".print_r($content,true).",$addressbook,".print_r($fields,true).",$msg,$tpl_name)</p>\n");
-		if (empty($tpl_name) && !empty($content['tpl_form_name'])) $tpl_name =$content['tpl_form_name'];
+		if (empty($tpl_name) && !empty($content['tpl_form_name']))
+		{
+			$tpl_name =$content['tpl_form_name'];
+		}
 		$tpl = new etemplate($tpl_name ? $tpl_name : 'addressbook.contactform');
 		// initializing some fields
-		if (!$fields) $fields = array('org_name','n_fn','email','tel_work','url','note','captcha');
+		if (!$fields)
+		{
+			$fields = array('org_name','n_fn','email','tel_work','url','note','captcha');
+		}
 		$submitted = false;
 		// check if submitted
 		if (is_array($content))
 		{
 			if ((isset($content['captcha_result']) && $content['captcha'] != $content['captcha_result']) ||	// no correct captcha OR
 				(time() - $content['start_time'] < 10 &&				// bot indicator (less then 10 sec to fill out the form and
-				!$GLOBALS['egw_info']['etemplate']['java_script']))	// javascript disabled)
+				!$GLOBALS['egw_info']['etemplate']['java_script']))
+			{
+				// javascript disabled)
 			{
 				$submitted = "truebutfalse";
+			}
 				$tpl->set_validation_error('captcha',lang('Wrong - try again ...'));
 			}
 			elseif ($content['submitit'])
 			{
 				$submitted = true;
 				$contact = new Api\Contacts();
-				if ($content['owner'])	// save the contact in the addressbook
+				if ($content['owner'])
+				{
+					// save the contact in the addressbook
 				{
-					$content['private'] = 0;	// in case default_private is set
+					$content['private'] = 0;
+				}
+				// in case default_private is set
 					if (($id = $contact->save($content)))
 					{
 						// check for fileuploads and attach the found files
@@ -139,9 +152,12 @@ 
 			$custom = 1;
 			foreach($fields as $name)
 			{
-				if ($name[0] == '#')	// custom field
+				if ($name[0] == '#')
+				{
+					// custom field
 				{
 					static $contact;
+				}
 					if (is_null($contact))
 					{
 						$contact = new Api\Contacts();
@@ -172,12 +188,19 @@ 
 			unset($content['submitit']);
 			$custom = 1;
 			// fieldnames are "defined" by the commit attempt, that way, we do not have to remember them
-			foreach($content as $name => $value) {
+			foreach($content as $name => $value)
+			{
 				$preserv[$name]=$value;
-				if ($name[0] == '#')     // custom field
+				if ($name[0] == '#')
+				{
+					// custom field
 				{
 					static $contact;
-					if (is_null($contact)) $contact = new Api\Contacts();
+				}
+					if (is_null($contact))
+					{
+						$contact = new Api\Contacts();
+					}
 					$content['show']['custom'.$custom] = true;
 					$content['customfield'][$custom] = $name;
 					$content['customlabel'][$custom] = $contact->customfields[substr($name,1)]['label'];
@@ -200,15 +223,25 @@ 
 		}
 		$content['addr_format'] = $GLOBALS['egw_info']['user']['preferences']['addressbook']['addr_format'];
 
-		if ($addressbook) $preserv['owner'] = $addressbook;
-		if ($msg) $preserv['msg'] = $msg;
+		if ($addressbook)
+		{
+			$preserv['owner'] = $addressbook;
+		}
+		if ($msg)
+		{
+			$preserv['msg'] = $msg;
+		}
 
 		// a simple calculation captcha
 		$num1 = rand(1,99);
 		$num2 = rand(1,99);
-		if ($num2 > $num1)	// keep the result positive
+		if ($num2 > $num1)
+		{
+			// keep the result positive
 		{
-			$n = $num1; $num1 = $num2; $num2 = $n;
+			$n = $num1;
+		}
+		$num1 = $num2; $num2 = $n;
 		}
 		if (in_array('captcha',$fields))
 		{

addressbook/inc/class.addressbook_groupdav.inc.php

Doc Comments +5 added lines, -5 removed lines

@@ -106,7 +106,7 @@ 
 	 * @param array &$files
 	 * @param int $user account_id
 	 * @param string $id =''
-	 * @return mixed boolean true on success, false on failure or string with http status (eg. '404 Not Found')
+	 * @return boolean boolean true on success, false on failure or string with http status (eg. '404 Not Found')
 	 */
 	function propfind($path,&$options,&$files,$user,$id='')
 	{
@@ -188,7 +188,7 @@ 
 	 *
 	 * @param string $path
 	 * @param array& $filter
-	 * @param array|boolean $start =false false=return all or array(start,num)
+	 * @param integer[] $start =false false=return all or array(start,num)
 	 * @return array with "files" array with values for keys path and props
 	 */
 	function &propfind_callback($path,array &$filter,$start=false,$report_not_found_multiget_ids=true)
@@ -539,7 +539,7 @@ 
 	 * @param array &$options
 	 * @param int $id
 	 * @param int $user =null account_id
-	 * @return mixed boolean true on success, false on failure or string with http status (eg. '404 Not Found')
+	 * @return string|boolean boolean true on success, false on failure or string with http status (eg. '404 Not Found')
 	 */
 	function get(&$options,$id,$user=null)
 	{
@@ -566,7 +566,7 @@ 
 	 * @param int $id
 	 * @param int $user =null account_id of owner, default null
 	 * @param string $prefix =null user prefix from path (eg. /ralf from /ralf/addressbook)
-	 * @return mixed boolean true on success, false on failure or string with http status (eg. '404 Not Found')
+	 * @return string|boolean boolean true on success, false on failure or string with http status (eg. '404 Not Found')
 	 */
 	function put(&$options,$id,$user=null,$prefix=null)
 	{
@@ -1024,7 +1024,7 @@ 
 	 *
 	 * @param int $acl Acl::READ, Acl::EDIT or Acl::DELETE
 	 * @param array|int $contact contact-array or id
-	 * @return boolean null if entry does not exist, false if no access, true if access permitted
+	 * @return null|boolean null if entry does not exist, false if no access, true if access permitted
 	 */
 	function check_access($acl,$contact)
 	{

Spacing +125 added lines, -126 removed lines

@@ -76,7 +76,7 @@ 
 		// LDAP does NOT have a carddav_name attribute --> stick with id mapped to LDAP attribute uid
 		if (version_compare($GLOBALS['egw_info']['apps']['phpgwapi']['version'], '1.9.007', '<') ||
 			$this->bo->contact_repository != 'sql' ||
-			$this->bo->account_repository != 'sql' && strpos($_SERVER['REQUEST_URI'].'/','/addressbook-accounts/') !== false)
+			$this->bo->account_repository != 'sql' && strpos($_SERVER['REQUEST_URI'].'/', '/addressbook-accounts/') !== false)
 		{
 			self::$path_extension = '.vcf';
 		}
@@ -88,11 +88,11 @@ 
 		if ($this->debug) error_log(__METHOD__."() contact_repository={$this->bo->contact_repository}, account_repository={$this->bo->account_repository}, REQUEST_URI=$_SERVER[REQUEST_URI] --> path_attr=".self::$path_attr.", path_extension=".self::$path_extension);
 
 		$this->home_set_pref = $GLOBALS['egw_info']['user']['preferences']['groupdav']['addressbook-home-set'];
-		$this->home_set_pref = $this->home_set_pref ? explode(',',$this->home_set_pref) : array();
+		$this->home_set_pref = $this->home_set_pref ? explode(',', $this->home_set_pref) : array();
 
 		// silently switch "Sync all into one" preference on for OS X addressbook, as it only supports one AB
 		// this restores behavior before Lion (10.7), where AB synced all ABs contained in addressbook-home-set
-		if (substr(self::get_agent(),0,9) == 'cfnetwork' && !in_array('O',$this->home_set_pref))
+		if (substr(self::get_agent(), 0, 9) == 'cfnetwork' && !in_array('O', $this->home_set_pref))
 		{
 			$this->home_set_pref[] = 'O';
 		}
@@ -108,13 +108,13 @@ 
 	 * @param string $id =''
 	 * @return mixed boolean true on success, false on failure or string with http status (eg. '404 Not Found')
 	 */
-	function propfind($path,&$options,&$files,$user,$id='')
+	function propfind($path, &$options, &$files, $user, $id = '')
 	{
 		$filter = array();
 		// If "Sync selected addressbooks into one" is set
-		if ($user && $user == $GLOBALS['egw_info']['user']['account_id'] && in_array('O',$this->home_set_pref))
+		if ($user && $user == $GLOBALS['egw_info']['user']['account_id'] && in_array('O', $this->home_set_pref))
 		{
-			$filter['owner'] = array_keys($this->get_shared(true));	// true: ignore all-in-one pref
+			$filter['owner'] = array_keys($this->get_shared(true)); // true: ignore all-in-one pref
 			$filter['owner'][] = $user;
 		}
 		// show addressbook of a single user?
@@ -127,11 +127,11 @@ 
 
 		// process REPORT filters or multiget href's
 		$nresults = null;
-		if (($id || $options['root']['name'] != 'propfind') && !$this->_report_filters($options,$filter,$id, $nresults))
+		if (($id || $options['root']['name'] != 'propfind') && !$this->_report_filters($options, $filter, $id, $nresults))
 		{
 			return false;
 		}
-		if ($id) $path = dirname($path).'/';	// carddav_name get's added anyway in the callback
+		if ($id) $path = dirname($path).'/'; // carddav_name get's added anyway in the callback
 
 		if ($this->debug) error_log(__METHOD__."($path,".array2string($options).",,$user,$id) filter=".array2string($filter));
 
@@ -139,7 +139,7 @@ 
 		if (!($filter['address_data'] = $options['props'] == 'all' &&
 			$options['root']['ns'] == Api\CalDAV::CARDDAV) && is_array($options['props']))
 		{
-			foreach($options['props'] as $prop)
+			foreach ($options['props'] as $prop)
 			{
 				if ($prop['name'] == 'address-data')
 				{
@@ -158,7 +158,7 @@ 
 
 			$this->sync_collection_token = null;
 
-			$filter['order'] = 'contact_modified ASC';	// return oldest modifications first
+			$filter['order'] = 'contact_modified ASC'; // return oldest modifications first
 			$filter['sync-collection'] = true;
 		}
 
@@ -172,13 +172,13 @@ 
 			if ($options['root']['name'] == 'sync-collection' && $this->bo->total > $nresults)
 			{
 				--$this->sync_collection_token;
-				$files['sync-token-params'][] = true;	// tel get_sync_collection_token that we have more entries
+				$files['sync-token-params'][] = true; // tel get_sync_collection_token that we have more entries
 			}
 		}
 		else
 		{
 			// return iterator, calling ourself to return result in chunks
-			$files['files'] = new Api\CalDAV\PropfindIterator($this,$path,$filter,$files['files']);
+			$files['files'] = new Api\CalDAV\PropfindIterator($this, $path, $filter, $files['files']);
 		}
 		return true;
 	}
@@ -191,7 +191,7 @@ 
 	 * @param array|boolean $start =false false=return all or array(start,num)
 	 * @return array with "files" array with values for keys path and props
 	 */
-	function &propfind_callback($path,array &$filter,$start=false,$report_not_found_multiget_ids=true)
+	function &propfind_callback($path, array &$filter, $start = false, $report_not_found_multiget_ids = true)
 	{
 		//error_log(__METHOD__."('$path', ".array2string($filter).", ".array2string($start).", $report_not_found_multiget_ids)");
 		$starttime = microtime(true);
@@ -219,18 +219,18 @@ 
 		if (isset($filter[self::$path_attr]))
 		{
 			if (!is_array($filter[self::$path_attr])) $filter[self::$path_attr] = (array)$filter[self::$path_attr];
-			$requested_multiget_ids =& $filter[self::$path_attr];
+			$requested_multiget_ids = & $filter[self::$path_attr];
 		}
 
 		$files = array();
 		// we query etag and modified, as LDAP does not have the strong sql etag
-		$cols = array('id','uid','etag','modified','n_fn');
-		if (!in_array(self::$path_attr,$cols)) $cols[] = self::$path_attr;
+		$cols = array('id', 'uid', 'etag', 'modified', 'n_fn');
+		if (!in_array(self::$path_attr, $cols)) $cols[] = self::$path_attr;
 		// we need tid for sync-collection report
 		if (array_key_exists('tid', $filter) && !isset($filter['tid']) && !in_array('tid', $cols)) $cols[] = 'tid';
-		if (($contacts =& $this->bo->search(array(),$cols,$order,'','',False,'AND',$start,$filter)))
+		if (($contacts = & $this->bo->search(array(), $cols, $order, '', '', False, 'AND', $start, $filter)))
 		{
-			foreach($contacts as &$contact)
+			foreach ($contacts as &$contact)
 			{
 				// remove contact from requested multiget ids, to be able to report not found urls
 				if ($requested_multiget_ids && ($k = array_search($contact[self::$path_attr], $requested_multiget_ids)) !== false)
@@ -250,9 +250,9 @@ 
 				);
 				if ($address_data)
 				{
-					$content = $handler->getVCard($contact['id'],$this->charset,false);
+					$content = $handler->getVCard($contact['id'], $this->charset, false);
 					$props['getcontentlength'] = bytes($content);
-					$props[] = Api\CalDAV::mkprop(Api\CalDAV::CARDDAV,'address-data',$content,true);
+					$props[] = Api\CalDAV::mkprop(Api\CalDAV::CARDDAV, 'address-data', $content, true);
 				}
 				$files[] = $this->add_resource($path, $contact, $props);
 			}
@@ -283,10 +283,10 @@ 
 				}
 			}
 			// add groups after contacts, but only if enabled and NOT for '/addressbook/' (!isset($filter['owner'])
-			if (in_array('D',$this->home_set_pref) && (string)$filter['owner'] !== '0')
+			if (in_array('D', $this->home_set_pref) && (string)$filter['owner'] !== '0')
 			{
 				$where = array(
-					'list_owner' => isset($filter['owner'])?$filter['owner']:array_keys($this->bo->grants)
+					'list_owner' => isset($filter['owner']) ? $filter['owner'] : array_keys($this->bo->grants)
 				);
 				// add sync-token to support sync-collection report
 				if ($sync_collection_report)
@@ -299,20 +299,20 @@ 
 					$where['list_'.self::$path_attr] = $filter[self::$path_attr];
 				}
 				//error_log(__METHOD__."() filter=".array2string($filter).", do_groups=".in_array('D',$this->home_set_pref).", where=".array2string($where));
-				if (($lists = $this->bo->read_lists($where,'contact_uid',$where['list_owner'])))	// limit to contacts in same AB!
+				if (($lists = $this->bo->read_lists($where, 'contact_uid', $where['list_owner'])))	// limit to contacts in same AB!
 				{
-					foreach($lists as $list)
+					foreach ($lists as $list)
 					{
 						$list[self::$path_attr] = $list['list_carddav_name'];
 						$etag = $list['list_id'].':'.$list['list_etag'];
 						// for all-in-one addressbook, add selected ABs to etag
 						if (isset($filter['owner']) && is_array($filter['owner']))
 						{
-							$etag .= ':'.implode('-',$filter['owner']);
+							$etag .= ':'.implode('-', $filter['owner']);
 						}
 						$props = array(
 							'getcontenttype' => Api\CalDAV::mkprop('getcontenttype', 'text/vcard'),
-							'getlastmodified' => Api\DateTime::to($list['list_modified'],'ts'),
+							'getlastmodified' => Api\DateTime::to($list['list_modified'], 'ts'),
 							'displayname' => $list['list_name'],
 							'getetag' => '"'.$etag.'"',
 						);
@@ -320,7 +320,7 @@ 
 						{
 							$content = $handler->getGroupVCard($list);
 							$props['getcontentlength'] = bytes($content);
-							$props[] = Api\CalDAV::mkprop(Api\CalDAV::CARDDAV,'address-data',$content,true);
+							$props[] = Api\CalDAV::mkprop(Api\CalDAV::CARDDAV, 'address-data', $content, true);
 						}
 						$files[] = $this->add_resource($path, $list, $props);
 
@@ -330,7 +330,7 @@ 
 							unset($requested_multiget_ids[$k]);
 						}
 
-						if ($sync_collection_report && $this->sync_collection_token < ($ts=$GLOBALS['egw']->db->from_timestamp($list['list_modified'])))
+						if ($sync_collection_report && $this->sync_collection_token < ($ts = $GLOBALS['egw']->db->from_timestamp($list['list_modified'])))
 						{
 							$this->sync_collection_token = $ts;
 						}
@@ -340,7 +340,7 @@ 
 			// report not found multiget urls
 			if ($report_not_found_multiget_ids && $requested_multiget_ids)
 			{
-				foreach($requested_multiget_ids as $id)
+				foreach ($requested_multiget_ids as $id)
 				{
 					$files[] = array('path' => $path.$id.self::$path_extension);
 				}
@@ -360,7 +360,7 @@ 
 	 * @param int &$nresult on return limit for number or results or unchanged/null
 	 * @return boolean true if filter could be processed
 	 */
-	function _report_filters($options,&$filters,$id, &$nresults)
+	function _report_filters($options, &$filters, $id, &$nresults)
 	{
 		if ($options['filters'])
 		{
@@ -385,17 +385,17 @@ 
 			$prop_filters = array();
 
 			$matches = $prop_test = $column = null;
-			foreach($options['filters'] as $n => $filter)
+			foreach ($options['filters'] as $n => $filter)
 			{
-				if (!is_int($n)) continue;	// eg. attributes of filter xml element
+				if (!is_int($n)) continue; // eg. attributes of filter xml element
 
-				switch((string)$filter['name'])
+				switch ((string)$filter['name'])
 				{
 					case 'param-filter':
 						$this->caldav->log(__METHOD__."(...) param-filter='{$filter['attrs']['name']}' not (yet) implemented!");
 						break;
 					case 'prop-filter':	// can be multiple prop-filter, see example
-						if ($matches) $prop_filters[] = implode($prop_test=='allof'?' AND ':' OR ',$matches);
+						if ($matches) $prop_filters[] = implode($prop_test == 'allof' ? ' AND ' : ' OR ', $matches);
 						$matches = array();
 						$prop_filter = strtoupper($filter['attrs']['name']);
 						$prop_test = isset($filter['attrs']['test']) ? $filter['attrs']['test'] : 'anyof';
@@ -408,11 +408,11 @@ 
 						if (!isset($this->filter_prop2cal[$prop_filter]))	// eg. not existing NICKNAME in EGroupware
 						{
 							if ($this->debug || $prop_filter != 'NICKNAME') error_log(__METHOD__."(...) text-match: $prop_filter {$filter['attrs']['match-type']} '{$filter['data']}' unknown property '$prop_filter' --> ignored");
-							$column = false;	// to ignore following data too
+							$column = false; // to ignore following data too
 						}
 						else
 						{
-							switch($filter['attrs']['collation'])	// todo: which other collations allowed, we are allways unicode
+							switch ($filter['attrs']['collation'])	// todo: which other collations allowed, we are allways unicode
 							{
 								case 'i;unicode-casemap':
 								default:
@@ -432,20 +432,20 @@ 
 							if ($column)	// false for properties not known to EGroupware
 							{
 								$value = str_replace(array('%', '_'), array('\\%', '\\_'), $filter['data']);
-								switch($match_type)
+								switch ($match_type)
 								{
 									case 'equals':
-										$sql_filter = $column . $comp . $GLOBALS['egw']->db->quote($value);
+										$sql_filter = $column.$comp.$GLOBALS['egw']->db->quote($value);
 										break;
 									default:
 									case 'contains':
-										$sql_filter = $column . $comp . $GLOBALS['egw']->db->quote('%'.$value.'%');
+										$sql_filter = $column.$comp.$GLOBALS['egw']->db->quote('%'.$value.'%');
 										break;
 									case 'starts-with':
-										$sql_filter = $column . $comp . $GLOBALS['egw']->db->quote($value.'%');
+										$sql_filter = $column.$comp.$GLOBALS['egw']->db->quote($value.'%');
 										break;
 									case 'ends-with':
-										$sql_filter = $column . $comp . $GLOBALS['egw']->db->quote('%'.$value);
+										$sql_filter = $column.$comp.$GLOBALS['egw']->db->quote('%'.$value);
 										break;
 								}
 								$matches[] = ($negate_condition ? 'NOT ' : '').$sql_filter;
@@ -461,10 +461,10 @@ 
 						break;
 				}
 			}
-			if ($matches) $prop_filters[] = implode($prop_test=='allof'?' AND ':' OR ',$matches);
+			if ($matches) $prop_filters[] = implode($prop_test == 'allof' ? ' AND ' : ' OR ', $matches);
 			if ($prop_filters)
 			{
-				$filters[] = $filter = '(('.implode($filter_test=='allof'?') AND (':') OR (', $prop_filters).'))';
+				$filters[] = $filter = '(('.implode($filter_test == 'allof' ? ') AND (' : ') OR (', $prop_filters).'))';
 				if ($this->debug) error_log(__METHOD__."(path=$options[path], ...) sql-filter: $filter");
 			}
 		}
@@ -474,9 +474,9 @@ 
 		    <B:nresults>10</B:nresults>
 		  </B:limit>
 		*/
-		foreach((array)$options['other'] as $option)
+		foreach ((array)$options['other'] as $option)
 		{
-			switch($option['name'])
+			switch ($option['name'])
 			{
 				case 'nresults':
 					$nresults = (int)$option['data'];
@@ -485,7 +485,7 @@ 
 				case 'limit':
 					break;
 				case 'href':
-					break;	// from addressbook-multiget, handled below
+					break; // from addressbook-multiget, handled below
 				// rfc 6578 sync-report
 				case 'sync-token':
 					if (!empty($option['data']))
@@ -493,7 +493,7 @@ 
 						$parts = explode('/', $option['data']);
 						$sync_token = array_pop($parts);
 						$filters[] = 'contact_modified>'.(int)$sync_token;
-						$filters['tid'] = null;	// to return deleted entries too
+						$filters['tid'] = null; // to return deleted entries too
 					}
 					break;
 				case 'sync-level':
@@ -511,23 +511,23 @@ 
 		if ($options['root']['name'] == 'addressbook-multiget')
 		{
 			$ids = array();
-			foreach($options['other'] as $option)
+			foreach ($options['other'] as $option)
 			{
 				if ($option['name'] == 'href')
 				{
-					$parts = explode('/',$option['data']);
+					$parts = explode('/', $option['data']);
 					if (($id = urldecode(array_pop($parts))))
 					{
-						$ids[] = self::$path_extension ? basename($id,self::$path_extension) : $id;
+						$ids[] = self::$path_extension ? basename($id, self::$path_extension) : $id;
 					}
 				}
 			}
 			if ($ids) $filters[self::$path_attr] = $ids;
-			if ($this->debug) error_log(__METHOD__."(...) addressbook-multiget: ids=".implode(',',$ids));
+			if ($this->debug) error_log(__METHOD__."(...) addressbook-multiget: ids=".implode(',', $ids));
 		}
 		elseif ($id)
 		{
-			$filters[self::$path_attr] = self::$path_extension ? basename($id,self::$path_extension) : $id;
+			$filters[self::$path_attr] = self::$path_extension ? basename($id, self::$path_extension) : $id;
 		}
 		//error_log(__METHOD__."() options[other]=".array2string($options['other'])." --> filters=".array2string($filters));
 		return true;
@@ -541,17 +541,16 @@ 
 	 * @param int $user =null account_id
 	 * @return mixed boolean true on success, false on failure or string with http status (eg. '404 Not Found')
 	 */
-	function get(&$options,$id,$user=null)
+	function get(&$options, $id, $user = null)
 	{
-		unset($user);	// not used, but required by function signature
+		unset($user); // not used, but required by function signature
 
-		if (!is_array($contact = $this->_common_get_put_delete('GET',$options,$id)))
+		if (!is_array($contact = $this->_common_get_put_delete('GET', $options, $id)))
 		{
 			return $contact;
 		}
 		$handler = self::_get_handler();
-		$options['data'] = $contact['list_id'] ? $handler->getGroupVCard($contact) :
-			$handler->getVCard($contact['id'],$this->charset,false);
+		$options['data'] = $contact['list_id'] ? $handler->getGroupVCard($contact) : $handler->getVCard($contact['id'], $this->charset, false);
 		// e.g. Evolution does not understand 'text/vcard'
 		$options['mimetype'] = 'text/x-vcard; charset='.$this->charset;
 		header('Content-Encoding: identity');
@@ -568,11 +567,11 @@ 
 	 * @param string $prefix =null user prefix from path (eg. /ralf from /ralf/addressbook)
 	 * @return mixed boolean true on success, false on failure or string with http status (eg. '404 Not Found')
 	 */
-	function put(&$options,$id,$user=null,$prefix=null)
+	function put(&$options, $id, $user = null, $prefix = null)
 	{
 		if ($this->debug) error_log(__METHOD__.'('.array2string($options).",$id,$user)");
 
-		$oldContact = $this->_common_get_put_delete('PUT',$options,$id);
+		$oldContact = $this->_common_get_put_delete('PUT', $options, $id);
 		if (!is_null($oldContact) && !is_array($oldContact))
 		{
 			if ($this->debug) error_log(__METHOD__."(,'$id', $user, '$prefix') returning ".array2string($oldContact));
@@ -597,7 +596,7 @@ 
 					switch (strtolower($key))
 					{
 						case 'charset':
-							$charset = strtoupper(substr($value,1,-1));
+							$charset = strtoupper(substr($value, 1, -1));
 					}
 				}
 			}
@@ -624,7 +623,7 @@ 
 
 		if (!$is_group && is_array($contact['cat_id']))
 		{
-			$contact['cat_id'] = implode(',',$this->bo->find_or_add_categories($contact['cat_id'], $contactId));
+			$contact['cat_id'] = implode(',', $this->bo->find_or_add_categories($contact['cat_id'], $contactId));
 		}
 		elseif ($contactId > 0)
 		{
@@ -648,12 +647,12 @@ 
 			$contact['carddav_name'] = $id;
 
 			// only set owner, if user is explicitly specified in URL (check via prefix, NOT for /addressbook/) or sync-all-in-one!)
-			if ($prefix && !in_array('O',$this->home_set_pref) && $user)
+			if ($prefix && !in_array('O', $this->home_set_pref) && $user)
 			{
 				$contact['owner'] = $user;
 			}
 			// check if default addressbook is synced and not Api\Accounts, if not use (always synced) personal addressbook
-			elseif(!$this->bo->default_addressbook || !in_array($this->bo->default_addressbook,$this->home_set_pref))
+			elseif (!$this->bo->default_addressbook || !in_array($this->bo->default_addressbook, $this->home_set_pref))
 			{
 				$contact['owner'] = $GLOBALS['egw_info']['user']['account_id'];
 			}
@@ -664,7 +663,7 @@ 
 			}
 			// check if user has add rights for addressbook
 			// done here again, as _common_get_put_delete knows nothing about default addressbooks...
-			if (!($this->bo->grants[$contact['owner']] & Acl::ADD))
+			if (!($this->bo->grants[$contact['owner']]&Acl::ADD))
 			{
 				if ($this->debug) error_log(__METHOD__."(,'$id', $user, '$prefix') returning '403 Forbidden'");
 				return '403 Forbidden';
@@ -681,7 +680,7 @@ 
 				$this->check_return_representation($options, $id, $user);
 				return '412 Precondition Failed';
 			}
-			return '403 Forbidden';	// happens when writing new entries in AB's without ADD rights
+			return '403 Forbidden'; // happens when writing new entries in AB's without ADD rights
 		}
 
 		if (empty($contact['etag']) || empty($contact['cardav_name']))
@@ -714,16 +713,16 @@ 
 	 * @param array|false $oldContact
 	 * @return int|boolean $list_id or false on error
 	 */
-	function save_group(array &$contact, $oldContact=null)
+	function save_group(array &$contact, $oldContact = null)
 	{
 		$data = array('list_name' => $contact['n_fn']);
 		if (!isset($contact['owner'])) $contact['owner'] = $GLOBALS['egw_info']['user']['account_id'];
-		foreach(array('id','carddav_name','uid','owner') as $name)
+		foreach (array('id', 'carddav_name', 'uid', 'owner') as $name)
 		{
 			$data['list_'.$name] = $contact[$name];
 		}
 		//error_log(__METHOD__.'('.array2string($contact).', '.array2string($oldContact).') data='.array2string($data));
-		if (($list_id=$this->bo->add_list(array('list_'.self::$path_attr => $contact[self::$path_attr]),
+		if (($list_id = $this->bo->add_list(array('list_'.self::$path_attr => $contact[self::$path_attr]),
 			$contact['owner'], null, $data)))
 		{
 			// update members given in $contact['##X-ADDRESSBOOKSERVER-MEMBER']
@@ -736,14 +735,14 @@ 
 			{
 				$new_members = array($new_members);
 			}
-			foreach($new_members as &$uid)
+			foreach ($new_members as &$uid)
 			{
-				$uid = substr($uid,9);	// cut off "urn:uuid:" prefix
+				$uid = substr($uid, 9); // cut off "urn:uuid:" prefix
 			}
 			if ($oldContact)
 			{
-				$to_add = array_diff($new_members,$oldContact['members']);
-				$to_delete = array_diff($oldContact['members'],$new_members);
+				$to_add = array_diff($new_members, $oldContact['members']);
+				$to_delete = array_diff($oldContact['members'], $new_members);
 			}
 			else
 			{
@@ -754,9 +753,9 @@ 
 			{
 				$to_add_ids = $to_delete_ids = array();
 				$filter = array('uid' => $to_delete ? array_merge($to_add, $to_delete) : $to_add);
-				if (($contacts =& $this->bo->search(array(), array('id', 'uid'),'','','',False,'AND',false,$filter)))
+				if (($contacts = & $this->bo->search(array(), array('id', 'uid'), '', '', '', False, 'AND', false, $filter)))
 				{
-					foreach($contacts as $c)
+					foreach ($contacts as $c)
 					{
 						if ($to_delete && in_array($c['uid'], $to_delete))
 						{
@@ -786,9 +785,9 @@ 
 	 * @param int $user
 	 * @return string
 	 */
-	public function getctag($path,$user)
+	public function getctag($path, $user)
 	{
-		static $ctags = array();	// a little per request caching, in case ctag and sync-token is both requested
+		static $ctags = array(); // a little per request caching, in case ctag and sync-token is both requested
 		if (isset($ctags[$path])) return $ctags[$path];
 
 		$user_in = $user;
@@ -796,9 +795,9 @@ 
 		if (is_null($user) || $user === '' || $path == '/addressbook/') $user = null;
 
 		// If "Sync selected addressbooks into one" is set --> ctag need to take selected AB's into account too
-		if ($user && $user == $GLOBALS['egw_info']['user']['account_id'] && in_array('O',$this->home_set_pref))
+		if ($user && $user == $GLOBALS['egw_info']['user']['account_id'] && in_array('O', $this->home_set_pref))
 		{
-			$user = array_merge((array)$user,array_keys($this->get_shared(true)));	// true: ignore all-in-one pref
+			$user = array_merge((array)$user, array_keys($this->get_shared(true))); // true: ignore all-in-one pref
 
 			// include accounts ctag, if accounts stored different from contacts (eg.in LDAP or ADS)
 			if ($this->bo->so_accounts && in_array('0', $user))
@@ -809,7 +808,7 @@ 
 		$ctag = $this->bo->get_ctag($user);
 
 		// include lists-ctag, if enabled
-		if (in_array('D',$this->home_set_pref))
+		if (in_array('D', $this->home_set_pref))
 		{
 			$lists_ctag = $this->bo->lists_ctag($user);
 		}
@@ -842,34 +841,34 @@ 
 	 * @param int $user =null account_id of owner of collection
 	 * @return array
 	 */
-	public function extra_properties(array $props, $displayname, $base_uri=null, $user=null)
+	public function extra_properties(array $props, $displayname, $base_uri = null, $user = null)
 	{
-		unset($displayname, $base_uri, $user);	// not used, but required by function signature
+		unset($displayname, $base_uri, $user); // not used, but required by function signature
 
 		if (!isset($props['addressbook-description']))
 		{
 			// default addressbook description: can be overwritten via PROPPATCH, in which case it's already set
-			$props['addressbook-description'] = Api\CalDAV::mkprop(Api\CalDAV::CARDDAV,'addressbook-description',$props['displayname']);
+			$props['addressbook-description'] = Api\CalDAV::mkprop(Api\CalDAV::CARDDAV, 'addressbook-description', $props['displayname']);
 		}
 		// setting an max image size, so iOS scales the images before transmitting them
 		// we currently scale down to width of 240px, which tests shown to be ~20k
-		$props['max-image-size'] = Api\CalDAV::mkprop(Api\CalDAV::CARDDAV,'max-image-size',24*1024);
+		$props['max-image-size'] = Api\CalDAV::mkprop(Api\CalDAV::CARDDAV, 'max-image-size', 24 * 1024);
 
 		// supported reports (required property for CardDAV)
 		$props['supported-report-set'] = array(
-			'addressbook-query' => Api\CalDAV::mkprop('supported-report',array(
-				Api\CalDAV::mkprop('report',array(
-					Api\CalDAV::mkprop(Api\CalDAV::CARDDAV,'addressbook-query',''))))),
-			'addressbook-multiget' => Api\CalDAV::mkprop('supported-report',array(
-				Api\CalDAV::mkprop('report',array(
-					Api\CalDAV::mkprop(Api\CalDAV::CARDDAV,'addressbook-multiget',''))))),
+			'addressbook-query' => Api\CalDAV::mkprop('supported-report', array(
+				Api\CalDAV::mkprop('report', array(
+					Api\CalDAV::mkprop(Api\CalDAV::CARDDAV, 'addressbook-query', ''))))),
+			'addressbook-multiget' => Api\CalDAV::mkprop('supported-report', array(
+				Api\CalDAV::mkprop('report', array(
+					Api\CalDAV::mkprop(Api\CalDAV::CARDDAV, 'addressbook-multiget', ''))))),
 		);
 		// only advertice rfc 6578 sync-collection report, if "delete-prevention" is switched on (deleted entries get marked deleted but not actualy deleted
 		if ($GLOBALS['egw_info']['server']['history'])
 		{
-			$props['supported-report-set']['sync-collection'] = Api\CalDAV::mkprop('supported-report',array(
-				Api\CalDAV::mkprop('report',array(
-					Api\CalDAV::mkprop('sync-collection','')))));
+			$props['supported-report-set']['sync-collection'] = Api\CalDAV::mkprop('supported-report', array(
+				Api\CalDAV::mkprop('report', array(
+					Api\CalDAV::mkprop('sync-collection', '')))));
 		}
 		return $props;
 	}
@@ -881,7 +880,7 @@ 
 	 */
 	private function _get_handler()
 	{
-		$handler = new addressbook_vcal('addressbook','text/vcard');
+		$handler = new addressbook_vcal('addressbook', 'text/vcard');
 		$supportedFields = $handler->supportedFields;
 		// Apple iOS or OS X addressbook
 		if ($this->agent == 'cfnetwork' || $this->agent == 'dataaccess')
@@ -894,11 +893,11 @@ 
 			unset($supportedFields['TEL;CELL;WORK']);
 			$supportedFields['TEL;IPHONE'] = array('tel_cell_private');
 			unset($supportedFields['TEL;CELL;HOME']);
-			$databaseFields['X-ABSHOWAS'] = $supportedFields['X-ABSHOWAS'] = array('fileas_type');	// Horde vCard class uses uppercase prop-names!
+			$databaseFields['X-ABSHOWAS'] = $supportedFields['X-ABSHOWAS'] = array('fileas_type'); // Horde vCard class uses uppercase prop-names!
 
 			// Apple Addressbook pre Lion (OS X 10.7) messes up CLASS and CATEGORIES (Lion cant set them but leaves them alone)
 			$matches = null;
-			if (preg_match('|CFNetwork/([0-9]+)|i', $_SERVER['HTTP_USER_AGENT'],$matches) && $matches[1] < 520 ||
+			if (preg_match('|CFNetwork/([0-9]+)|i', $_SERVER['HTTP_USER_AGENT'], $matches) && $matches[1] < 520 ||
 				// iOS 5.1.1 does not display CLASS or CATEGORY, but wrongly escapes multiple, comma-separated categories
 				// and appends CLASS: PUBLIC to an empty NOTE: field --> leaving them out for iOS
 				$this->agent == 'dataaccess')
@@ -908,7 +907,7 @@ 
 				unset($supportedFields['CATEGORIES']);
 				unset($databaseFields['CATEGORIES']);
 			}
-			if (preg_match('|CFNetwork/([0-9]+)|i', $_SERVER['HTTP_USER_AGENT'],$matches) && $matches[1] < 520)
+			if (preg_match('|CFNetwork/([0-9]+)|i', $_SERVER['HTTP_USER_AGENT'], $matches) && $matches[1] < 520)
 			{
 				// gd cant parse or resize images stored from snow leopard addressbook: gd-jpeg:
 				// - JPEG library reports unrecoverable error
@@ -920,7 +919,7 @@ 
 			}
 			$handler->setDatabaseFields($databaseFields);
 		}
-		$handler->setSupportedFields('GroupDAV',$this->agent,$supportedFields);
+		$handler->setSupportedFields('GroupDAV', $this->agent, $supportedFields);
 		return $handler;
 	}
 
@@ -931,9 +930,9 @@ 
 	 * @param int $id
 	 * @return mixed boolean true on success, false on failure or string with http status (eg. '404 Not Found')
 	 */
-	function delete(&$options,$id)
+	function delete(&$options, $id)
 	{
-		if (!is_array($contact = $this->_common_get_put_delete('DELETE',$options,$id)))
+		if (!is_array($contact = $this->_common_get_put_delete('DELETE', $options, $id)))
 		{
 			return $contact;
 		}
@@ -941,7 +940,7 @@ 
 		{
 			$ok = $this->bo->delete_list($contact['list_id']) !== false;
 		}
-		elseif (($ok = $this->bo->delete($contact['id'],self::etag2value($this->http_if_match))) === 0)
+		elseif (($ok = $this->bo->delete($contact['id'], self::etag2value($this->http_if_match))) === 0)
 		{
 			return '412 Precondition Failed';
 		}
@@ -958,9 +957,9 @@ 
 	 * @param string $path =null
 	 * @return array|boolean array with entry, false if no read rights, null if $id does not exist
 	 */
-	function read($id, $path=null)
+	function read($id, $path = null)
 	{
-		static $non_deleted_tids=null;
+		static $non_deleted_tids = null;
 		if (is_null($non_deleted_tids))
 		{
 			$tids = $this->bo->content_types;
@@ -970,7 +969,7 @@ 
 		$contact = $this->bo->read(array(self::$path_attr => $id, 'tid' => $non_deleted_tids));
 
 		// if contact not found and accounts stored NOT like contacts, try reading it without path-extension as id
-		if (is_null($contact) && $this->bo->so_accounts && ($c = $this->bo->read($test=basename($id, '.vcf'))))
+		if (is_null($contact) && $this->bo->so_accounts && ($c = $this->bo->read($test = basename($id, '.vcf'))))
 		{
 			$contact = $c;
 		}
@@ -979,9 +978,9 @@ 
 		// bo->read_list(..., true) limits returned uid to same owner's addressbook, as iOS and OS X addressbooks
 		// only understands/shows that and if return more, save_lists would delete the others ones on update!
 		$limit_in_ab = true;
-		list(,$account_lid,$app) = explode('/',$path);	// eg. /<username>/addressbook/<id>
+		list(,$account_lid, $app) = explode('/', $path); // eg. /<username>/addressbook/<id>
 		// /<username>/addressbook/ with home_set_prefs containing 'O'=all-in-one contains selected ab's
-		if($account_lid == $GLOBALS['egw_info']['user']['account_lid'] && $app == 'addressbook' && in_array('O',$this->home_set_pref))
+		if ($account_lid == $GLOBALS['egw_info']['user']['account_lid'] && $app == 'addressbook' && in_array('O', $this->home_set_pref))
 		{
 			$limit_in_ab = array_keys($this->get_shared(true));
 			$limit_in_ab[] = $GLOBALS['egw_info']['user']['account_id'];
@@ -992,28 +991,28 @@ 
 		{
 			$limit_in_ab = array_keys($this->bo->grants);
 		}*/
-		if (!$contact && ($contact = $this->bo->read_lists(array('list_'.self::$path_attr => $id),'contact_uid',$limit_in_ab)))
+		if (!$contact && ($contact = $this->bo->read_lists(array('list_'.self::$path_attr => $id), 'contact_uid', $limit_in_ab)))
 		{
 			$contact = array_shift($contact);
 			$contact['n_fn'] = $contact['n_family'] = $contact['list_name'];
-			foreach(array('owner','id','carddav_name','modified','modifier','created','creator','etag','uid') as $name)
+			foreach (array('owner', 'id', 'carddav_name', 'modified', 'modifier', 'created', 'creator', 'etag', 'uid') as $name)
 			{
 				$contact[$name] = $contact['list_'.$name];
 			}
 			// if NOT limited to containing AB ($limit_in_ab === true), add that limit to etag
 			if ($limit_in_ab !== true)
 			{
-				$contact['etag'] .= ':'.implode('-',$limit_in_ab);
+				$contact['etag'] .= ':'.implode('-', $limit_in_ab);
 			}
 		}
-		elseif($contact === array())	// not found from read_lists()
+		elseif ($contact === array())	// not found from read_lists()
 		{
 			$contact = null;
 		}
 
 		if ($contact && $contact['tid'] == Api\Contacts::DELETED_TYPE)
 		{
-			$contact = null;	// handle deleted events, as not existing (404 Not Found)
+			$contact = null; // handle deleted events, as not existing (404 Not Found)
 		}
 		if ($this->debug > 1) error_log(__METHOD__."('$id') returning ".array2string($contact));
 		return $contact;
@@ -1026,9 +1025,9 @@ 
 	 * @param array|int $contact contact-array or id
 	 * @return boolean null if entry does not exist, false if no access, true if access permitted
 	 */
-	function check_access($acl,$contact)
+	function check_access($acl, $contact)
 	{
-		return $this->bo->check_perms($acl, $contact, true);	// true = deny to delete accounts
+		return $this->bo->check_perms($acl, $contact, true); // true = deny to delete accounts
 	}
 
 	/**
@@ -1056,15 +1055,15 @@ 
 	 * @param boolean $ignore_all_in_one =false if true, return selected addressbooks and not array() for all-in-one
 	 * @return array account_id => account_lid pairs
 	 */
-	function get_shared($ignore_all_in_one=false)
+	function get_shared($ignore_all_in_one = false)
 	{
 		$shared = array();
 
 		// if "Sync all selected addressbook into one" is set --> no (additional) shared addressbooks
-		if (!$ignore_all_in_one && in_array('O',$this->home_set_pref)) return array();
+		if (!$ignore_all_in_one && in_array('O', $this->home_set_pref)) return array();
 
 		// replace symbolic id's with real nummeric id's
-		foreach(array(
+		foreach (array(
 			'G' => $GLOBALS['egw_info']['user']['account_primary_group'],
 			'U' => '0',
 		) as $sym => $id)
@@ -1074,11 +1073,11 @@ 
 				$this->home_set_pref[$key] = $id;
 			}
 		}
-		foreach(array_keys($this->bo->get_addressbooks(Acl::READ)) as $id)
+		foreach (array_keys($this->bo->get_addressbooks(Acl::READ)) as $id)
 		{
 			if (($id || !$GLOBALS['egw_info']['user']['preferences']['addressbook']['hide_accounts']) &&
-				$GLOBALS['egw_info']['user']['account_id'] != $id &&	// no current user and no accounts, if disabled in ab prefs
-				(in_array('A',$this->home_set_pref) || in_array((string)$id,$this->home_set_pref)) &&
+				$GLOBALS['egw_info']['user']['account_id'] != $id && // no current user and no accounts, if disabled in ab prefs
+				(in_array('A', $this->home_set_pref) || in_array((string)$id, $this->home_set_pref)) &&
 				is_numeric($id) && ($owner = $id ? $this->accounts->id2name($id) : 'accounts'))
 			{
 				$shared[$id] = 'addressbook-'.$owner;
@@ -1098,14 +1097,14 @@ 
 	public static function groupdav_root_props(array $data)
 	{
 		$data['props']['addressbook-home-set'] = Api\CalDAV::mkprop(Api\CalDAV::CARDDAV, 'addressbook-home-set', array(
-			Api\CalDAV::mkprop('href',$data['caldav']->base_uri.'/'.$GLOBALS['egw_info']['user']['account_lid'].'/')));
+			Api\CalDAV::mkprop('href', $data['caldav']->base_uri.'/'.$GLOBALS['egw_info']['user']['account_lid'].'/')));
 
 		$data['props']['principal-address'] = Api\CalDAV::mkprop(Api\CalDAV::CARDDAV, 'principal-address',
 				$GLOBALS['egw_info']['user']['preferences']['addressbook']['hide_accounts'] ? '' : array(
-				Api\CalDAV::mkprop('href',$data['caldav']->base_uri.'/addressbook-accounts/'.$GLOBALS['egw_info']['user']['person_id'].'.vcf')));
+				Api\CalDAV::mkprop('href', $data['caldav']->base_uri.'/addressbook-accounts/'.$GLOBALS['egw_info']['user']['person_id'].'.vcf')));
 
 		$data['props']['directory-gateway'] = Api\CalDAV::mkprop(Api\CalDAV::CARDDAV, 'directory-gateway', array(
-			Api\CalDAV::mkprop('href',$data['caldav']->base_uri.'/addressbook/')));
+			Api\CalDAV::mkprop('href', $data['caldav']->base_uri.'/addressbook/')));
 	}
 
 	/**
@@ -1128,8 +1127,8 @@ 
 			$user = $hook_data['account_id'];
 			$addressbook_bo = new Api\Contacts();
 			$addressbooks += $addressbook_bo->get_addressbooks(Acl::READ, null, $user);
-			if ($user > 0)  unset($addressbooks[$user]);	// allways synced
-			unset($addressbooks[$user.'p']);// ignore (optional) private addressbook for now
+			if ($user > 0)  unset($addressbooks[$user]); // allways synced
+			unset($addressbooks[$user.'p']); // ignore (optional) private addressbook for now
 		}
 
 		// allow to force no other addressbooks
@@ -1156,9 +1155,9 @@ 
 			'label'  => 'Addressbooks to sync in addition to personal addressbook',
 			'name'   => 'addressbook-home-set',
 			'help'   => lang('Only supported by a few fully conformant clients (eg. from Apple). If you have to enter a URL, it will most likely not be supported!').
-				'<br/>'.lang('They will be sub-folders in users home (%1 attribute).','CardDAV "addressbook-home-set"').
-				'<br/>'.lang('Select "%1", if your client does not support multiple addressbooks.',lang('Sync all selected into one')).
-				'<br/>'.lang('Select "%1", if your client support groups, eg. OS X or iOS addressbook.',lang('Distribution lists as groups')),
+				'<br/>'.lang('They will be sub-folders in users home (%1 attribute).', 'CardDAV "addressbook-home-set"').
+				'<br/>'.lang('Select "%1", if your client does not support multiple addressbooks.', lang('Sync all selected into one')).
+				'<br/>'.lang('Select "%1", if your client support groups, eg. OS X or iOS addressbook.', lang('Distribution lists as groups')),
 			'values' => $addressbooks,
 			'xmlrpc' => True,
 			'admin'  => False,

Braces +163 added lines, -40 removed lines

@@ -85,7 +85,10 @@ 
 			self::$path_attr = 'carddav_name';
 			self::$path_extension = '';
 		}
-		if ($this->debug) error_log(__METHOD__."() contact_repository={$this->bo->contact_repository}, account_repository={$this->bo->account_repository}, REQUEST_URI=$_SERVER[REQUEST_URI] --> path_attr=".self::$path_attr.", path_extension=".self::$path_extension);
+		if ($this->debug)
+		{
+			error_log(__METHOD__."() contact_repository={$this->bo->contact_repository}, account_repository={$this->bo->account_repository}, REQUEST_URI=$_SERVER[REQUEST_URI] --> path_attr=".self::$path_attr.", path_extension=".self::$path_extension);
+		}
 
 		$this->home_set_pref = $GLOBALS['egw_info']['user']['preferences']['groupdav']['addressbook-home-set'];
 		$this->home_set_pref = $this->home_set_pref ? explode(',',$this->home_set_pref) : array();
@@ -123,7 +126,10 @@ 
 			$filter['owner'] = $user;
 		}
 		// should we hide the accounts addressbook
-		if ($GLOBALS['egw_info']['user']['preferences']['addressbook']['hide_accounts']) $filter['account_id'] = null;
+		if ($GLOBALS['egw_info']['user']['preferences']['addressbook']['hide_accounts'])
+		{
+			$filter['account_id'] = null;
+		}
 
 		// process REPORT filters or multiget href's
 		$nresults = null;
@@ -131,9 +137,16 @@ 
 		{
 			return false;
 		}
-		if ($id) $path = dirname($path).'/';	// carddav_name get's added anyway in the callback
+		if ($id)
+		{
+			$path = dirname($path).'/';
+		}
+		// carddav_name get's added anyway in the callback
 
-		if ($this->debug) error_log(__METHOD__."($path,".array2string($options).",,$user,$id) filter=".array2string($filter));
+		if ($this->debug)
+		{
+			error_log(__METHOD__."($path,".array2string($options).",,$user,$id) filter=".array2string($filter));
+		}
 
 		// check if we have to return the full contact data or just the etag's
 		if (!($filter['address_data'] = $options['props'] == 'all' &&
@@ -218,16 +231,25 @@ 
 
 		if (isset($filter[self::$path_attr]))
 		{
-			if (!is_array($filter[self::$path_attr])) $filter[self::$path_attr] = (array)$filter[self::$path_attr];
+			if (!is_array($filter[self::$path_attr]))
+			{
+				$filter[self::$path_attr] = (array)$filter[self::$path_attr];
+			}
 			$requested_multiget_ids =& $filter[self::$path_attr];
 		}
 
 		$files = array();
 		// we query etag and modified, as LDAP does not have the strong sql etag
 		$cols = array('id','uid','etag','modified','n_fn');
-		if (!in_array(self::$path_attr,$cols)) $cols[] = self::$path_attr;
+		if (!in_array(self::$path_attr,$cols))
+		{
+			$cols[] = self::$path_attr;
+		}
 		// we need tid for sync-collection report
-		if (array_key_exists('tid', $filter) && !isset($filter['tid']) && !in_array('tid', $cols)) $cols[] = 'tid';
+		if (array_key_exists('tid', $filter) && !isset($filter['tid']) && !in_array('tid', $cols))
+		{
+			$cols[] = 'tid';
+		}
 		if (($contacts =& $this->bo->search(array(),$cols,$order,'','',False,'AND',$start,$filter)))
 		{
 			foreach($contacts as &$contact)
@@ -271,7 +293,10 @@ 
 			{
 				$accounts_filter = $filter_in;
 				$accounts_filter['owner'] = '0';
-				if ($sync_collection_report) $token_was = $this->sync_collection_token;
+				if ($sync_collection_report)
+				{
+					$token_was = $this->sync_collection_token;
+				}
 				self::$path_attr = 'id';
 				self::$path_extension = '.vcf';
 				$files = array_merge($files, $this->propfind_callback($path, $accounts_filter, false, false));
@@ -294,16 +319,22 @@ 
 					list(,$sync_token) = explode('>', $filter[0]);
 					$where[] = 'list_modified>FROM_UNIXTIME('.(int)$sync_token.')';
 				}
-				if (isset($filter[self::$path_attr]))	// multiget report?
+				if (isset($filter[self::$path_attr]))
+				{
+					// multiget report?
 				{
 					$where['list_'.self::$path_attr] = $filter[self::$path_attr];
 				}
+				}
 				//error_log(__METHOD__."() filter=".array2string($filter).", do_groups=".in_array('D',$this->home_set_pref).", where=".array2string($where));
-				if (($lists = $this->bo->read_lists($where,'contact_uid',$where['list_owner'])))	// limit to contacts in same AB!
+				if (($lists = $this->bo->read_lists($where,'contact_uid',$where['list_owner'])))
+				{
+					// limit to contacts in same AB!
 				{
 					foreach($lists as $list)
 					{
 						$list[self::$path_attr] = $list['list_carddav_name'];
+				}
 						$etag = $list['list_id'].':'.$list['list_etag'];
 						// for all-in-one addressbook, add selected ABs to etag
 						if (isset($filter['owner']) && is_array($filter['owner']))
@@ -347,7 +378,10 @@ 
 			}
 		}
 
-		if ($this->debug) error_log(__METHOD__."($path,".array2string($filter).','.array2string($start).") took ".(microtime(true) - $starttime).' to return '.count($files).' items');
+		if ($this->debug)
+		{
+			error_log(__METHOD__."($path,".array2string($filter).','.array2string($start).") took ".(microtime(true) - $starttime).' to return '.count($files).' items');
+		}
 		return $files;
 	}
 
@@ -387,7 +421,11 @@ 
 			$matches = $prop_test = $column = null;
 			foreach($options['filters'] as $n => $filter)
 			{
-				if (!is_int($n)) continue;	// eg. attributes of filter xml element
+				if (!is_int($n))
+				{
+					continue;
+				}
+				// eg. attributes of filter xml element
 
 				switch((string)$filter['name'])
 				{
@@ -395,19 +433,28 @@ 
 						$this->caldav->log(__METHOD__."(...) param-filter='{$filter['attrs']['name']}' not (yet) implemented!");
 						break;
 					case 'prop-filter':	// can be multiple prop-filter, see example
-						if ($matches) $prop_filters[] = implode($prop_test=='allof'?' AND ':' OR ',$matches);
+						if ($matches)
+						{
+							$prop_filters[] = implode($prop_test=='allof'?' AND ':' OR ',$matches);
+						}
 						$matches = array();
 						$prop_filter = strtoupper($filter['attrs']['name']);
 						$prop_test = isset($filter['attrs']['test']) ? $filter['attrs']['test'] : 'anyof';
-						if ($this->debug > 1) error_log(__METHOD__."(...) prop-filter='$prop_filter', test='$prop_test'");
+						if ($this->debug > 1)
+						{
+							error_log(__METHOD__."(...) prop-filter='$prop_filter', test='$prop_test'");
+						}
 						break;
 					case 'is-not-defined':
 						$matches[] = '('.$column."='' OR ".$column.' IS NULL)';
 						break;
 					case 'text-match':	// prop-filter can have multiple text-match, see example
-						if (!isset($this->filter_prop2cal[$prop_filter]))	// eg. not existing NICKNAME in EGroupware
+						if (!isset($this->filter_prop2cal[$prop_filter]))
+						{
+							// eg. not existing NICKNAME in EGroupware
 						{
 							if ($this->debug || $prop_filter != 'NICKNAME') error_log(__METHOD__."(...) text-match: $prop_filter {$filter['attrs']['match-type']} '{$filter['data']}' unknown property '$prop_filter' --> ignored");
+						}
 							$column = false;	// to ignore following data too
 						}
 						else
@@ -420,8 +467,14 @@ 
 									break;
 							}
 							$column = $this->filter_prop2cal[strtoupper($prop_filter)];
-							if (strpos($column, '_') === false) $column = 'contact_'.$column;
-							if (!isset($filters['order'])) $filters['order'] = $column;
+							if (strpos($column, '_') === false)
+							{
+								$column = 'contact_'.$column;
+							}
+							if (!isset($filters['order']))
+							{
+								$filters['order'] = $column;
+							}
 							$match_type = $filter['attrs']['match-type'];
 							$negate_condition = isset($filter['attrs']['negate-condition']) && $filter['attrs']['negate-condition'] == 'yes';
 						}
@@ -429,9 +482,12 @@ 
 					case '':	// data of text-match element
 						if (isset($filter['data']) && isset($column))
 						{
-							if ($column)	// false for properties not known to EGroupware
+							if ($column)
+							{
+								// false for properties not known to EGroupware
 							{
 								$value = str_replace(array('%', '_'), array('\\%', '\\_'), $filter['data']);
+							}
 								switch($match_type)
 								{
 									case 'equals':
@@ -450,7 +506,10 @@ 
 								}
 								$matches[] = ($negate_condition ? 'NOT ' : '').$sql_filter;
 
-								if ($this->debug > 1) error_log(__METHOD__."(...) text-match: $prop_filter $match_type' '{$filter['data']}'");
+								if ($this->debug > 1)
+								{
+									error_log(__METHOD__."(...) text-match: $prop_filter $match_type' '{$filter['data']}'");
+								}
 							}
 							unset($column);
 							break;
@@ -461,11 +520,17 @@ 
 						break;
 				}
 			}
-			if ($matches) $prop_filters[] = implode($prop_test=='allof'?' AND ':' OR ',$matches);
+			if ($matches)
+			{
+				$prop_filters[] = implode($prop_test=='allof'?' AND ':' OR ',$matches);
+			}
 			if ($prop_filters)
 			{
 				$filters[] = $filter = '(('.implode($filter_test=='allof'?') AND (':') OR (', $prop_filters).'))';
-				if ($this->debug) error_log(__METHOD__."(path=$options[path], ...) sql-filter: $filter");
+				if ($this->debug)
+				{
+					error_log(__METHOD__."(path=$options[path], ...) sql-filter: $filter");
+				}
 			}
 		}
 		// parse limit from $options['other']
@@ -522,8 +587,14 @@ 
 					}
 				}
 			}
-			if ($ids) $filters[self::$path_attr] = $ids;
-			if ($this->debug) error_log(__METHOD__."(...) addressbook-multiget: ids=".implode(',',$ids));
+			if ($ids)
+			{
+				$filters[self::$path_attr] = $ids;
+			}
+			if ($this->debug)
+			{
+				error_log(__METHOD__."(...) addressbook-multiget: ids=".implode(',',$ids));
+			}
 		}
 		elseif ($id)
 		{
@@ -570,12 +641,18 @@ 
 	 */
 	function put(&$options,$id,$user=null,$prefix=null)
 	{
-		if ($this->debug) error_log(__METHOD__.'('.array2string($options).",$id,$user)");
+		if ($this->debug)
+		{
+			error_log(__METHOD__.'('.array2string($options).",$id,$user)");
+		}
 
 		$oldContact = $this->_common_get_put_delete('PUT',$options,$id);
 		if (!is_null($oldContact) && !is_array($oldContact))
 		{
-			if ($this->debug) error_log(__METHOD__."(,'$id', $user, '$prefix') returning ".array2string($oldContact));
+			if ($this->debug)
+			{
+				error_log(__METHOD__."(,'$id', $user, '$prefix') returning ".array2string($oldContact));
+			}
 			return $oldContact;
 		}
 
@@ -666,15 +743,24 @@ 
 			// done here again, as _common_get_put_delete knows nothing about default addressbooks...
 			if (!($this->bo->grants[$contact['owner']] & Acl::ADD))
 			{
-				if ($this->debug) error_log(__METHOD__."(,'$id', $user, '$prefix') returning '403 Forbidden'");
+				if ($this->debug)
+				{
+					error_log(__METHOD__."(,'$id', $user, '$prefix') returning '403 Forbidden'");
+				}
 				return '403 Forbidden';
 			}
 		}
-		if ($this->http_if_match) $contact['etag'] = self::etag2value($this->http_if_match);
+		if ($this->http_if_match)
+		{
+			$contact['etag'] = self::etag2value($this->http_if_match);
+		}
 
 		if (!($save_ok = $is_group ? $this->save_group($contact, $oldContact) : $this->bo->save($contact)))
 		{
-			if ($this->debug) error_log(__METHOD__."(,$id) save(".array2string($contact).") failed, Ok=$save_ok");
+			if ($this->debug)
+			{
+				error_log(__METHOD__."(,$id) save(".array2string($contact).") failed, Ok=$save_ok");
+			}
 			if ($save_ok === 0)
 			{
 				// honor Prefer: return=representation for 412 too (no need for client to explicitly reload)
@@ -703,7 +789,10 @@ 
 		// send evtl. necessary respose headers: Location, etag, ...
 		$this->put_response_headers($contact, $options['path'], $retval, self::$path_attr != 'id');
 
-		if ($this->debug > 1) error_log(__METHOD__."(,'$id', $user, '$prefix') returning ".array2string($retval));
+		if ($this->debug > 1)
+		{
+			error_log(__METHOD__."(,'$id', $user, '$prefix') returning ".array2string($retval));
+		}
 		return $retval;
 	}
 
@@ -717,7 +806,10 @@ 
 	function save_group(array &$contact, $oldContact=null)
 	{
 		$data = array('list_name' => $contact['n_fn']);
-		if (!isset($contact['owner'])) $contact['owner'] = $GLOBALS['egw_info']['user']['account_id'];
+		if (!isset($contact['owner']))
+		{
+			$contact['owner'] = $GLOBALS['egw_info']['user']['account_id'];
+		}
 		foreach(array('id','carddav_name','uid','owner') as $name)
 		{
 			$data['list_'.$name] = $contact[$name];
@@ -769,13 +861,22 @@ 
 					}
 				}
 				//error_log('to_add_ids='.array2string($to_add_ids).', to_delete_ids='.array2string($to_delete_ids));
-				if ($to_add_ids) $this->bo->add2list($to_add_ids, $list_id, array());
-				if ($to_delete_ids) $this->bo->remove_from_list($to_delete_ids, $list_id);
+				if ($to_add_ids)
+				{
+					$this->bo->add2list($to_add_ids, $list_id, array());
+				}
+				if ($to_delete_ids)
+				{
+					$this->bo->remove_from_list($to_delete_ids, $list_id);
+				}
 			}
 			// reread as update of list-members updates etag and modified
 	 		$contact = $this->bo->read_list($list_id);
 		}
-		if ($this->debug > 1) error_log(__METHOD__.'('.array2string($contact).', '.array2string($oldContact).') on return contact='.array2string($data).' returning '.array2string($list_id));
+		if ($this->debug > 1)
+		{
+			error_log(__METHOD__.'('.array2string($contact).', '.array2string($oldContact).') on return contact='.array2string($data).' returning '.array2string($list_id));
+		}
  		return $list_id;
 	}
 
@@ -789,11 +890,17 @@ 
 	public function getctag($path,$user)
 	{
 		static $ctags = array();	// a little per request caching, in case ctag and sync-token is both requested
-		if (isset($ctags[$path])) return $ctags[$path];
+		if (isset($ctags[$path]))
+		{
+			return $ctags[$path];
+		}
 
 		$user_in = $user;
 		// not showing addressbook of a single user?
-		if (is_null($user) || $user === '' || $path == '/addressbook/') $user = null;
+		if (is_null($user) || $user === '' || $path == '/addressbook/')
+		{
+			$user = null;
+		}
 
 		// If "Sync selected addressbooks into one" is set --> ctag need to take selected AB's into account too
 		if ($user && $user == $GLOBALS['egw_info']['user']['account_id'] && in_array('O',$this->home_set_pref))
@@ -1006,16 +1113,22 @@ 
 				$contact['etag'] .= ':'.implode('-',$limit_in_ab);
 			}
 		}
-		elseif($contact === array())	// not found from read_lists()
+		elseif($contact === array())
+		{
+			// not found from read_lists()
 		{
 			$contact = null;
 		}
+		}
 
 		if ($contact && $contact['tid'] == Api\Contacts::DELETED_TYPE)
 		{
 			$contact = null;	// handle deleted events, as not existing (404 Not Found)
 		}
-		if ($this->debug > 1) error_log(__METHOD__."('$id') returning ".array2string($contact));
+		if ($this->debug > 1)
+		{
+			error_log(__METHOD__."('$id') returning ".array2string($contact));
+		}
 		return $contact;
 	}
 
@@ -1045,7 +1158,10 @@ 
 		// remove add and delete grants for accounts (for admins too)
 		// as accounts can not be created as contacts, they eg. need further data
 		// and admins might not recognice they delete an account incl. its data
-		if (isset($grants[0])) $grants[0] &= ~(EGW_ACL_ADD|EGW_ACL_DELETE);
+		if (isset($grants[0]))
+		{
+			$grants[0] &= ~(EGW_ACL_ADD|EGW_ACL_DELETE);
+		}
 
 		return $grants;
 	}
@@ -1061,7 +1177,10 @@ 
 		$shared = array();
 
 		// if "Sync all selected addressbook into one" is set --> no (additional) shared addressbooks
-		if (!$ignore_all_in_one && in_array('O',$this->home_set_pref)) return array();
+		if (!$ignore_all_in_one && in_array('O',$this->home_set_pref))
+		{
+			return array();
+		}
 
 		// replace symbolic id's with real nummeric id's
 		foreach(array(
@@ -1128,7 +1247,11 @@ 
 			$user = $hook_data['account_id'];
 			$addressbook_bo = new Api\Contacts();
 			$addressbooks += $addressbook_bo->get_addressbooks(Acl::READ, null, $user);
-			if ($user > 0)  unset($addressbooks[$user]);	// allways synced
+			if ($user > 0)
+			{
+				unset($addressbooks[$user]);
+			}
+			// allways synced
 			unset($addressbooks[$user.'p']);// ignore (optional) private addressbook for now
 		}
 

addressbook/inc/class.addressbook_hooks.inc.php

Doc Comments +2 added lines, -2 removed lines

@@ -423,7 +423,7 @@ 
 	 * Register addressbook for group-acl
 	 *
 	 * @param array $args hook-params (not used)
-	 * @return boolean|string true=standard group acl link, of string with link
+	 * @return boolean true=standard group acl link, of string with link
 	 */
 	static function group_acl($args)
 	{
@@ -437,7 +437,7 @@ 
 	 * For which groups should no group acl be used: addressbook always
 	 *
 	 * @param string|array $data
-	 * @return boolean|array true, false or array with group-account_id's
+	 * @return boolean true, false or array with group-account_id's
 	 */
 	static function not_enum_group_acls($data)
 	{

Spacing +39 added lines, -39 removed lines

@@ -43,37 +43,37 @@ 
 						'link'    => false,
 						'icon'    => false,
 					),
-					'menuOpened'  => true,	// display it open by default
+					'menuOpened'  => true, // display it open by default
 				));
 			}
 			// Magic etemplate2 favorites menu (from nextmatch widget)
 			display_sidebox($appname, lang('Favorites'), Framework\Favorites::list_favorites('addressbook'));
 
 			$file = array(
-				'Addressbook list' => Egw::link('/index.php',array(
+				'Addressbook list' => Egw::link('/index.php', array(
 					'menuaction' => 'addressbook.addressbook_ui.index',
 					'ajax' => 'true')),
 				array(
-					'text' => lang('Add %1',lang(Link::get_registry($appname, 'entry'))),
+					'text' => lang('Add %1', lang(Link::get_registry($appname, 'entry'))),
 					'no_lang' => true,
 					'link' => "javascript:egw.open('','$appname','add')"
 				),
 				'Advanced search' => "javascript:egw_openWindowCentered2('".
-					Egw::link('/index.php',array('menuaction' => 'addressbook.addressbook_ui.search'),false).
+					Egw::link('/index.php', array('menuaction' => 'addressbook.addressbook_ui.search'), false).
 					"','_blank',870,610,'yes')",
-				'Placeholders'    => Egw::link('/index.php','menuaction=api.EGroupware\\Api\\Contacts\\Merge.show_replacements')
+				'Placeholders'    => Egw::link('/index.php', 'menuaction=api.EGroupware\\Api\\Contacts\\Merge.show_replacements')
 			);
-			display_sidebox($appname,lang('Addressbook menu'),$file);
+			display_sidebox($appname, lang('Addressbook menu'), $file);
 		}
 
 		if ($GLOBALS['egw_info']['user']['apps']['admin'] && $location != 'preferences')
 		{
 			$file = Array(
-				'Site configuration' => Egw::link('/index.php',array(
+				'Site configuration' => Egw::link('/index.php', array(
 					'menuaction' => 'admin.uiconfig.index',
 					'appname'    => $appname,
 				)),
-				'Global Categories'  => Egw::link('/index.php',array(
+				'Global Categories'  => Egw::link('/index.php', array(
 					'menuaction' => 'admin.admin_categories.index',
 					'appname'    => $appname,
 					'global_cats'=> True,
@@ -82,7 +82,7 @@ 
 			// custom fields are not availible in LDAP
 			if ($GLOBALS['egw_info']['server']['contact_repository'] != 'ldap')
 			{
-				$file['Custom fields'] = Egw::link('/index.php',array(
+				$file['Custom fields'] = Egw::link('/index.php', array(
 					'menuaction' => 'admin.customfields.index',
 					'appname'    => $appname,
 					'use_private'=> 1,
@@ -91,11 +91,11 @@ 
 			}
 			if ($location == 'admin')
 			{
-				display_section($appname,$file);
+				display_section($appname, $file);
 			}
 			else
 			{
-				display_sidebox($appname,lang('Admin'),$file);
+				display_sidebox($appname, lang('Admin'), $file);
 			}
 		}
 	}
@@ -122,7 +122,7 @@ 
 			'label'  => 'Default addressbook for adding contacts',
 			'name'   => 'add_default',
 			'help'   => 'Which addressbook should be selected when adding a contact AND you have no add rights to the current addressbook.',
-			'values' => !$hook_data['setup'] ? ExecMethod('addressbook.addressbook_ui.get_addressbooks',Acl::ADD) : array(),
+			'values' => !$hook_data['setup'] ? ExecMethod('addressbook.addressbook_ui.get_addressbooks', Acl::ADD) : array(),
 			'xmlrpc' => True,
 			'admin'  => False,
 		);
@@ -154,7 +154,7 @@ 
 			'name'   => 'link_title',
 			'values' => array(
 				'n_fileas' => lang('own sorting').' ('.lang('default').': '.lang('Company').': '.lang('lastname').', '.lang('firstname').')',
-			)+$fileas_options,	// plus all fileas types
+			) + $fileas_options, // plus all fileas types
 			'help'   => 'What should links to the addressbook display in other applications. Empty values will be left out. You need to log in anew, if you change this setting!',
 			'xmlrpc' => True,
 			'admin'  => false,
@@ -199,7 +199,7 @@ 
 			'~edit~'    => lang('Edit contact'),
 			'infolog' => lang('Open %1 CRM view', lang('infolog')),
 		);
-		if($GLOBALS['egw_info']['user']['apps']['tracker'])
+		if ($GLOBALS['egw_info']['user']['apps']['tracker'])
 		{
 			$crm_list_options['tracker'] = lang('Open %1 CRM view', lang('tracker'));
 		}
@@ -246,8 +246,8 @@ 
 				'label'  => 'Default document to insert contacts',
 				'name'   => 'default_document',
 				'help'   => lang('If you specify a document (full vfs path) here, %1 displays an extra document icon for each entry. That icon allows to download the specified document with the data inserted.', lang('addressbook')).' '.
-					lang('The document can contain placeholder like {{%1}}, to be replaced with the data.','n_fn').' '.
-					lang('The following document-types are supported:'). implode(',',Api\Storage\Merge::get_file_extensions()),
+					lang('The document can contain placeholder like {{%1}}, to be replaced with the data.', 'n_fn').' '.
+					lang('The following document-types are supported:').implode(',', Api\Storage\Merge::get_file_extensions()),
 				'run_lang' => false,
 				'xmlrpc' => True,
 				'admin'  => False,
@@ -257,9 +257,9 @@ 
 				'size'   => 60,
 				'label'  => 'Directory with documents to insert contacts',
 				'name'   => 'document_dir',
-				'help'   => lang('If you specify a directory (full vfs path) here, %1 displays an action for each document. That action allows to download the specified document with the data inserted.',lang('addressbook')).' '.
-					lang('The document can contain placeholder like {{%1}}, to be replaced with the data.','n_fn').' '.
-					lang('The following document-types are supported:'). implode(',',Api\Storage\Merge::get_file_extensions()),
+				'help'   => lang('If you specify a directory (full vfs path) here, %1 displays an action for each document. That action allows to download the specified document with the data inserted.', lang('addressbook')).' '.
+					lang('The document can contain placeholder like {{%1}}, to be replaced with the data.', 'n_fn').' '.
+					lang('The following document-types are supported:').implode(',', Api\Storage\Merge::get_file_extensions()),
 				'run_lang' => false,
 				'xmlrpc' => True,
 				'admin'  => False,
@@ -343,7 +343,7 @@ 
 	 */
 	static function search_link($location)
 	{
-		unset($location);	// not used, but required by function signature
+		unset($location); // not used, but required by function signature
 
 		$links = array(
 			'query' => 'api.EGroupware\\Api\\Contacts.link_query',
@@ -369,9 +369,9 @@ 
 			'add_app'    => 'link_app',
 			'add_id'     => 'link_id',
 			'add_popup'  => '870x610',
-			'file_access_user' => true,	// file_access supports 4th parameter $user
+			'file_access_user' => true, // file_access supports 4th parameter $user
 			'file_access'=> 'api.EGroupware\\Api\\Contacts.file_access',
-			'default_types' => array('n' => array('name' => 'contact', 'options' => array('icon' => 'navbar.png','template' => 'addressbook.edit'))),
+			'default_types' => array('n' => array('name' => 'contact', 'options' => array('icon' => 'navbar.png', 'template' => 'addressbook.edit'))),
 			// registers an addtional type 'addressbook-email', returning only contacts with email, title has email appended
 			'additional' => array(
 				'addressbook-email' => array(
@@ -398,7 +398,7 @@ 
 	 */
 	static function getAppExportLimit($location)
 	{
-		unset($location);	// not used, but required by function signature
+		unset($location); // not used, but required by function signature
 
 		return $GLOBALS['egw_info']['server']['contact_export_limit'];
 	}
@@ -411,11 +411,11 @@ 
 	 */
 	static function calendar_resources($args)
 	{
-		unset($args);	// not used, but required by function signature
+		unset($args); // not used, but required by function signature
 
 		return array(
-			'type' => 'c',// one char type-identifiy for this resources
-			'info' => 'api.EGroupware\\Api\\Contacts.calendar_info',// info method, returns array with id, type & name for a given id
+			'type' => 'c', // one char type-identifiy for this resources
+			'info' => 'api.EGroupware\\Api\\Contacts.calendar_info', // info method, returns array with id, type & name for a given id
 		);
 	}
 
@@ -427,7 +427,7 @@ 
 	 */
 	static function group_acl($args)
 	{
-		unset($args);	// not used, but required by function signature
+		unset($args); // not used, but required by function signature
 
 		// addressbook uses group-acl, only if contacts-backend is NOT LDAP, as the ACL can not be modified there
 		return $GLOBALS['egw_info']['server']['contact_repository'] != 'ldap';
@@ -441,7 +441,7 @@ 
 	 */
 	static function not_enum_group_acls($data)
 	{
-		unset($data);	// not used, but required by function signature
+		unset($data); // not used, but required by function signature
 
 		return true;
 	}
@@ -454,7 +454,7 @@ 
 	 */
 	public static function acl_rights($params)
 	{
-		unset($params);	// not used, but required by function signature
+		unset($params); // not used, but required by function signature
 
 		return array(
 			Acl::READ    => 'read',
@@ -472,7 +472,7 @@ 
 	 */
 	public static function categories($data)
 	{
-		unset($data);	// not used, but required by function signature
+		unset($data); // not used, but required by function signature
 
 		return true;
 	}
@@ -489,10 +489,10 @@ 
 
 		// get the list of account fields
 		$own_account_acl = array();
-		foreach($bocontacts->contact_fields as $field => $label)
+		foreach ($bocontacts->contact_fields as $field => $label)
 		{
 			// some fields the user should never be allowed to edit or are covert by an other attribute (n_fn for all n_*)
-			if (!in_array($field,array('id','tid','owner','created','creator','modified','modifier','private','n_prefix','n_given','n_middle','n_family','n_suffix')))
+			if (!in_array($field, array('id', 'tid', 'owner', 'created', 'creator', 'modified', 'modifier', 'private', 'n_prefix', 'n_given', 'n_middle', 'n_family', 'n_suffix')))
 			{
 				$own_account_acl[$field] = $label;
 			}
@@ -500,7 +500,7 @@ 
 		$own_account_acl['link_to'] = 'Links';
 		if ($config['account_repository'] != 'ldap')	// no custom-fields in ldap
 		{
-			foreach(Api\Storage\Customfields::get('addressbook') as $name => $data)
+			foreach (Api\Storage\Customfields::get('addressbook') as $name => $data)
 			{
 				$own_account_acl['#'.$name] = $data['label'];
 			}
@@ -511,26 +511,26 @@ 
 		// Remove country codes as an option, it will be added by BO constructor
 		unset($org_fields['adr_one_countrycode'], $org_fields['adr_two_countrycode']);
 
-		$supported_fields = $bocontacts->get_fields('supported',null,0);	// fields supported by the backend (ldap schemas!)
+		$supported_fields = $bocontacts->get_fields('supported', null, 0); // fields supported by the backend (ldap schemas!)
 		// get the list of account fields
 		$copy_fields = array();
-		foreach($bocontacts->contact_fields as $field => $label)
+		foreach ($bocontacts->contact_fields as $field => $label)
 		{
 			// some fields the user should never be allowed to copy or are coverted by an other attribute (n_fn for all n_*)
-			if (!in_array($field,array('id','tid','created','creator','modified','modifier','account_id','uid','etag','n_fn')))
+			if (!in_array($field, array('id', 'tid', 'created', 'creator', 'modified', 'modifier', 'account_id', 'uid', 'etag', 'n_fn')))
 			{
 				$copy_fields[$field] = $label;
 			}
 		}
 		if ($config['contact_repository'] != 'ldap')	// no custom-fields in ldap
 		{
-			foreach(Api\Storage\Customfields::get('addressbook') as $name => $data)
+			foreach (Api\Storage\Customfields::get('addressbook') as $name => $data)
 			{
 				$copy_fields['#'.$name] = $data['label'];
 			}
 		}
 		// Remove country codes as an option, it will be added by UI constructor
-		if(in_array('adr_one_countrycode', $supported_fields))
+		if (in_array('adr_one_countrycode', $supported_fields))
 		{
 			unset($copy_fields['adr_one_countrycode'], $copy_fields['adr_two_countrycode']);
 		}
@@ -551,7 +551,7 @@ 
 		$ret = array(
 			'sel_options' => array(
 				'own_account_acl' => $own_account_acl,
-				'org_fileds_to_update' => $org_fields,	// typo has to stay, as it was there allways and we would loose existing config :(
+				'org_fileds_to_update' => $org_fields, // typo has to stay, as it was there allways and we would loose existing config :(
 				'copy_fields' => $copy_fields,
 				'fileas' => $bocontacts->fileas_options(),
 				'contact_repository' => $repositories,

Upper-Lower-Casing +1 added lines, -1 removed lines

@@ -108,7 +108,7 @@
 
 		if ($GLOBALS['egw_info']['user']['apps']['admin'] && !Api\Header\UserAgent::mobile())
 		{
-			$file = Array(
+			$file = array(
 				'Site configuration' => Egw::link('/index.php',array(
 					'menuaction' => 'infolog.infolog_ui.admin' )),
 				'Global Categories'  => Egw::link('/index.php',array(

Braces +12 added lines, -3 removed lines

@@ -498,11 +498,14 @@ 
 			}
 		}
 		$own_account_acl['link_to'] = 'Links';
-		if ($config['account_repository'] != 'ldap')	// no custom-fields in ldap
+		if ($config['account_repository'] != 'ldap')
+		{
+			// no custom-fields in ldap
 		{
 			foreach(Api\Storage\Customfields::get('addressbook') as $name => $data)
 			{
 				$own_account_acl['#'.$name] = $data['label'];
+		}
 			}
 		}
 
@@ -522,11 +525,14 @@ 
 				$copy_fields[$field] = $label;
 			}
 		}
-		if ($config['contact_repository'] != 'ldap')	// no custom-fields in ldap
+		if ($config['contact_repository'] != 'ldap')
+		{
+			// no custom-fields in ldap
 		{
 			foreach(Api\Storage\Customfields::get('addressbook') as $name => $data)
 			{
 				$copy_fields['#'.$name] = $data['label'];
+		}
 			}
 		}
 		// Remove country codes as an option, it will be added by UI constructor
@@ -559,7 +565,10 @@ 
 			)
 		);
 
-		if (empty($config['geolocation_url']))	$ret ['geolocation_url'] = $geoLocation[0]['value'];
+		if (empty($config['geolocation_url']))
+		{
+			$ret ['geolocation_url'] = $geoLocation[0]['value'];
+		}
 		return $ret;
 	}
 }

addressbook/inc/class.addressbook_import_contacts_csv.inc.php

Doc Comments +2 added lines, -4 removed lines

@@ -44,9 +44,7 @@ 
 
 	/**
 	 * imports entries according to given definition object.
-	 * @param resource $_stream
-	 * @param string $_charset
-	 * @param definition $_definition
+	 * @param importexport_definition $_definition
 	 */
 	public function init(importexport_definition &$_definition ) {
 
@@ -84,7 +82,7 @@ 
 	 *
 	 * Updates the count of actions taken
 	 *
-	 * @return boolean success
+	 * @return null|boolean success
 	 */
 	protected function import_record(importexport_iface_egw_record &$record, &$import_csv)
 	{

Indentation +26 added lines, -26 removed lines

@@ -381,38 +381,38 @@
 	}
 
 	/**
-        * Returns warnings that were encountered during importing
-        * Maximum of one warning message per record, but you can append if you need to
-        *
-        * @return Array (
-        *       record_# => warning message
-        *       )
-        */
-        public function get_warnings() {
+	 * Returns warnings that were encountered during importing
+	 * Maximum of one warning message per record, but you can append if you need to
+	 *
+	 * @return Array (
+	 *       record_# => warning message
+	 *       )
+	 */
+		public function get_warnings() {
 		return $this->warnings;
 	}
 
 	/**
-        * Returns errors that were encountered during importing
-        * Maximum of one error message per record, but you can append if you need to
-        *
-        * @return Array (
-        *       record_# => error message
-        *       )
-        */
-        public function get_errors() {
+	 * Returns errors that were encountered during importing
+	 * Maximum of one error message per record, but you can append if you need to
+	 *
+	 * @return Array (
+	 *       record_# => error message
+	 *       )
+	 */
+		public function get_errors() {
 		return $this->errors;
 	}
 
 	/**
-        * Returns a list of actions taken, and the number of records for that action.
-        * Actions are things like 'insert', 'update', 'delete', and may be different for each plugin.
-        *
-        * @return Array (
-        *       action => record count
-        * )
-        */
-        public function get_results() {
-                return $this->results;
-        }
+	 * Returns a list of actions taken, and the number of records for that action.
+	 * Actions are things like 'insert', 'update', 'delete', and may be different for each plugin.
+	 *
+	 * @return Array (
+	 *       action => record count
+	 * )
+	 */
+		public function get_results() {
+				return $this->results;
+		}
 }

Spacing +57 added lines, -57 removed lines

@@ -15,14 +15,14 @@ 
 /**
  * class import_csv for addressbook
  */
-class addressbook_import_contacts_csv extends importexport_basic_import_csv  {
+class addressbook_import_contacts_csv extends importexport_basic_import_csv {
 
 	/**
 	 * conditions for actions
 	 *
 	 * @var array
 	 */
-	protected static $conditions = array( 'exists', 'equal' );
+	protected static $conditions = array('exists', 'equal');
 
 	/**
 	 * @var bocontacts
@@ -48,7 +48,7 @@ 
 	 * @param string $_charset
 	 * @param definition $_definition
 	 */
-	public function init(importexport_definition &$_definition ) {
+	public function init(importexport_definition&$_definition) {
 
 		// fetch the addressbook bo
 		$this->bocontacts = new Api\Contacts();
@@ -59,17 +59,17 @@ 
 		$this->lookups = array(
 			'tid' => array('n'=>'contact')
 		);
-		foreach($this->bocontacts->content_types as $tid => $data)
+		foreach ($this->bocontacts->content_types as $tid => $data)
 		{
 			$this->lookups['tid'][$tid] = $data['name'];
 		}
 
 		// set contact owner
-		$contact_owner = isset( $_definition->plugin_options['contact_owner'] ) ?
+		$contact_owner = isset($_definition->plugin_options['contact_owner']) ?
 			$_definition->plugin_options['contact_owner'] : $this->user;
 
 		// Import into importer's personal addressbook
-		if($contact_owner == 'personal')
+		if ($contact_owner == 'personal')
 		{
 			$contact_owner = $this->user;
 		}
@@ -86,15 +86,15 @@ 
 	 *
 	 * @return boolean success
 	 */
-	protected function import_record(importexport_iface_egw_record &$record, &$import_csv)
+	protected function import_record(importexport_iface_egw_record&$record, &$import_csv)
 	{
 
 		// Set owner, unless it's supposed to come from CSV file
-		if($this->definition->plugin_options['owner_from_csv'] && $record->owner) {
-			if(!is_numeric($record->owner)) {
+		if ($this->definition->plugin_options['owner_from_csv'] && $record->owner) {
+			if (!is_numeric($record->owner)) {
 				// Automatically handle text owner without explicit translation
 				$new_owner = importexport_helper_functions::account_name2id($record->owner);
-				if($new_owner == '') {
+				if ($new_owner == '') {
 					$this->errors[$import_csv->get_current_position()] = lang(
 						'Unable to convert "%1" to account ID.  Using plugin setting (%2) for owner.',
 						$record->owner,
@@ -110,7 +110,7 @@ 
 		}
 
 		// Check that owner (addressbook) is allowed
-		if(!array_key_exists($record->owner, $this->bocontacts->get_addressbooks()))
+		if (!array_key_exists($record->owner, $this->bocontacts->get_addressbooks()))
 		{
 			$this->errors[$import_csv->get_current_position()] = lang("Unable to import into %1, using %2",
 				Api\Accounts::username($record->owner),
@@ -121,18 +121,18 @@ 
 
 		// Do not allow owner == 0 (accounts) without an account_id
 		// It causes the contact to be filed as an account, and can't delete
-		if(!$record->owner && !$record->account_id)
+		if (!$record->owner && !$record->account_id)
 		{
 			$record->owner = $GLOBALS['egw_info']['user']['account_id'];
 		}
 
 		// Do not import into non-existing type, warn and change
-		if(!$record->tid || !$this->lookups['tid'][$record->tid])
+		if (!$record->tid || !$this->lookups['tid'][$record->tid])
 		{
 			// Avoid lots of warnings about type (2 types are contact and deleted)
-			if(!$this->type_warned || count($this->lookups['tid']) == 2 )
+			if (!$this->type_warned || count($this->lookups['tid']) == 2)
 			{
-				$this->warnings[$import_csv->get_current_position()] = lang('Unknown type %1, imported as %2',$record->tid,lang($this->lookups['tid']['n']));
+				$this->warnings[$import_csv->get_current_position()] = lang('Unknown type %1, imported as %2', $record->tid, lang($this->lookups['tid']['n']));
 				$this->type_warned = true;
 			}
 			$record->tid = 'n';
@@ -141,45 +141,45 @@ 
 		// Also handle categories in their own field
 		$record_array = $record->get_record_array();
 		$more_categories = array();
-		foreach($this->definition->plugin_options['field_mapping'] as $field_name) {
-			if(!array_key_exists($field_name, $record_array) ||
-				substr($field_name,0,3) != 'cat' || !$record->$field_name || $field_name == 'cat_id') continue;
+		foreach ($this->definition->plugin_options['field_mapping'] as $field_name) {
+			if (!array_key_exists($field_name, $record_array) ||
+				substr($field_name, 0, 3) != 'cat' || !$record->$field_name || $field_name == 'cat_id') continue;
 			list(, $cat_id) = explode('-', $field_name);
-			if(is_numeric($record->$field_name) && $record->$field_name != 1) {
+			if (is_numeric($record->$field_name) && $record->$field_name != 1) {
 				// Column has a single category ID
 				$more_categories[] = $record->$field_name;
-			} elseif($record->$field_name == '1' ||
+			} elseif ($record->$field_name == '1' ||
 				(!is_numeric($record->$field_name) && strtolower($record->$field_name) == strtolower(lang('Yes')))) {
 				// Each category got its own column.  '1' is the database value, lang('yes') is the human value
 				$more_categories[] = $cat_id;
 			} else {
 				// Text categories
-				$more_categories = array_merge($more_categories, importexport_helper_functions::cat_name2id(is_array($record->$field_name) ? $record->$field_name : explode(',',$record->$field_name), $cat_id));
+				$more_categories = array_merge($more_categories, importexport_helper_functions::cat_name2id(is_array($record->$field_name) ? $record->$field_name : explode(',', $record->$field_name), $cat_id));
 			}
 		}
-		if(count($more_categories) > 0) $record->cat_id = array_merge(is_array($record->cat_id) ? $record->cat_id : explode(',',$record->cat_id), $more_categories);
+		if (count($more_categories) > 0) $record->cat_id = array_merge(is_array($record->cat_id) ? $record->cat_id : explode(',', $record->cat_id), $more_categories);
 
 		// Private set but missing causes hidden entries
-		if(array_key_exists('private', $record_array) && (!isset($record_array['private']) || $record_array['private'] == '')) unset($record->private);
+		if (array_key_exists('private', $record_array) && (!isset($record_array['private']) || $record_array['private'] == '')) unset($record->private);
 
 		// Format birthday as backend requires - converter should give timestamp
-		if($record->bday && is_numeric($record->bday))
+		if ($record->bday && is_numeric($record->bday))
 		{
 			$time = new Api\DateTime($record->bday);
 			$record->bday = $time->format('Y-m-d');
 		}
 
-		if ( $this->definition->plugin_options['conditions'] ) {
-			foreach ( $this->definition->plugin_options['conditions'] as $condition ) {
+		if ($this->definition->plugin_options['conditions']) {
+			foreach ($this->definition->plugin_options['conditions'] as $condition) {
 				$contacts = array();
-				switch ( $condition['type'] ) {
+				switch ($condition['type']) {
 					// exists
 					case 'exists' :
-						if($record_array[$condition['string']]) {
-							$searchcondition = array( $condition['string'] => $record_array[$condition['string']]);
+						if ($record_array[$condition['string']]) {
+							$searchcondition = array($condition['string'] => $record_array[$condition['string']]);
 							// if we use account_id for the condition, we need to set the owner for filtering, as this
 							// enables Api\Contacts\Storage to decide what backend is to be used
-							if ($condition['string']=='account_id') $searchcondition['owner']=0;
+							if ($condition['string'] == 'account_id') $searchcondition['owner'] = 0;
 							$contacts = $this->bocontacts->search(
 								//array( $condition['string'] => $record[$condition['string']],),
 								'',
@@ -188,37 +188,37 @@ 
 								$searchcondition
 							);
 						}
-						if ( is_array( $contacts ) && count( array_keys( $contacts ) ) >= 1 ) {
+						if (is_array($contacts) && count(array_keys($contacts)) >= 1) {
 							// apply action to all contacts matching this exists condition
 							$action = $condition['true'];
-							foreach ( (array)$contacts as $contact ) {
+							foreach ((array)$contacts as $contact) {
 								$record->id = $contact['id'];
-								if ( $this->definition->plugin_options['update_cats'] == 'add' ) {
-									if ( !is_array( $contact['cat_id'] ) ) $contact['cat_id'] = explode( ',', $contact['cat_id'] );
-									if ( !is_array( $record_array['cat_id'] ) ) $record->cat_id = explode( ',', $record->cat_id );
-									$record->cat_id = implode( ',', array_unique( array_merge( $record->cat_id, $contact['cat_id'] ) ) );
+								if ($this->definition->plugin_options['update_cats'] == 'add') {
+									if (!is_array($contact['cat_id'])) $contact['cat_id'] = explode(',', $contact['cat_id']);
+									if (!is_array($record_array['cat_id'])) $record->cat_id = explode(',', $record->cat_id);
+									$record->cat_id = implode(',', array_unique(array_merge($record->cat_id, $contact['cat_id'])));
 								}
-								$success = $this->action(  $action['action'], $record, $import_csv->get_current_position() );
+								$success = $this->action($action['action'], $record, $import_csv->get_current_position());
 							}
 						} else {
 							$action = $condition['false'];
-							$success = ($this->action(  $action['action'], $record, $import_csv->get_current_position() ));
+							$success = ($this->action($action['action'], $record, $import_csv->get_current_position()));
 						}
 						break;
 					case 'equal':
 						// Match on field
 						$result = $this->equal($record, $condition);
-						if($result)
+						if ($result)
 						{
 							// Apply true action to any matching records found
 							$action = $condition['true'];
-							$success = ($this->action(  $action['action'], $record, $import_csv->get_current_position() ));
+							$success = ($this->action($action['action'], $record, $import_csv->get_current_position()));
 						}
 						else
 						{
 							// Apply false action if no matching records found
 							$action = $condition['false'];
-							$success = ($this->action(  $action['action'], $record, $import_csv->get_current_position() ));
+							$success = ($this->action($action['action'], $record, $import_csv->get_current_position()));
 						}
 						break;
 
@@ -231,7 +231,7 @@ 
 			}
 		} else {
 			// unconditional insert
-			$success = $this->action( 'insert', $record, $import_csv->get_current_position() );
+			$success = $this->action('insert', $record, $import_csv->get_current_position());
 		}
 		return $success;
 	}
@@ -243,21 +243,21 @@ 
 	 * @param importexport_iface_egw_record $record contact data for the action
 	 * @return bool success or not
 	 */
-	protected function action ( $_action, importexport_iface_egw_record &$record, $record_num = 0 ) {
+	protected function action($_action, importexport_iface_egw_record&$record, $record_num = 0) {
 		$_data = $record->get_record_array();
 		switch ($_action) {
 			case 'none' :
 				return true;
 			case 'delete':
-				if($_data['id'])
+				if ($_data['id'])
 				{
-					if ( $this->dry_run ) {
+					if ($this->dry_run) {
 						//print_r($_data);
 						$this->results[$_action]++;
 						return true;
 					}
 					$result = $this->bocontacts->delete($_data);
-					if($result && $result === true)
+					if ($result && $result === true)
 					{
 						$this->results[$_action]++;
 					}
@@ -272,14 +272,14 @@ 
 				// Only update if there are changes
 				$old = $this->bocontacts->read($_data['id']);
 				// if we get countrycodes as countryname, try to translate them -> the rest should be handled by bo classes.
-				foreach(array('adr_one_', 'adr_two_') as $c_prefix) {
-					if (strlen(trim($_data[$c_prefix.'countryname']))==2)
+				foreach (array('adr_one_', 'adr_two_') as $c_prefix) {
+					if (strlen(trim($_data[$c_prefix.'countryname'])) == 2)
 						$_data[$c_prefix.'countryname'] = $GLOBALS['egw']->country->get_full_name(trim($_data[$c_prefix.'countryname']), true);
 				}
 				// Don't change a user account into a contact
-				if($old['owner'] == 0) {
+				if ($old['owner'] == 0) {
 					unset($_data['owner']);
-				} elseif(!$this->definition->plugin_options['change_owner']) {
+				} elseif (!$this->definition->plugin_options['change_owner']) {
 					// Don't change addressbook of an existing contact
 					unset($_data['owner']);
 				}
@@ -287,7 +287,7 @@ 
 				// Merge to deal with fields not in import record
 				$_data = array_merge($old, $_data);
 				$changed = $this->tracking->changed_fields($_data, $old);
-				if(count($changed) == 0) {
+				if (count($changed) == 0) {
 					return true;
 				} else {
 					//error_log(__METHOD__.__LINE__.array2string($changed).' Old:'.$old['adr_one_countryname'].' ('.$old['adr_one_countrycode'].') New:'.$_data['adr_one_countryname'].' ('.$_data['adr_one_countryname'].')');
@@ -298,22 +298,22 @@ 
 
 				// Fall through
 			case 'insert' :
-				if($_action == 'insert') {
+				if ($_action == 'insert') {
 					// Addressbook backend doesn't like inserting with ID specified, it screws up the owner & etag
 					unset($_data['id']);
 				}
-				if(!isset($_data['org_name'])) {
+				if (!isset($_data['org_name'])) {
 					// org_name is a trigger to update n_fileas
 					$_data['org_name'] = '';
 				}
 
-				if ( $this->dry_run ) {
+				if ($this->dry_run) {
 					//print_r($_data);
 					$this->results[$_action]++;
 					return true;
 				} else {
-					$result = $this->bocontacts->save( $_data, $this->is_admin);
-					if(!$result) {
+					$result = $this->bocontacts->save($_data, $this->is_admin);
+					if (!$result) {
 						$this->errors[$record_num] = $this->bocontacts->error;
 					} else {
 						$this->results[$_action]++;
@@ -323,7 +323,7 @@ 
 					return $result;
 				}
 			default:
-				throw new Api\Exception('Unsupported action: '. $_action);
+				throw new Api\Exception('Unsupported action: '.$_action);
 
 		}
 	}

Braces +126 added lines, -51 removed lines

@@ -15,7 +15,8 @@ 
 /**
  * class import_csv for addressbook
  */
-class addressbook_import_contacts_csv extends importexport_basic_import_csv  {
+class addressbook_import_contacts_csv extends importexport_basic_import_csv
+{
 
 	/**
 	 * conditions for actions
@@ -48,7 +49,8 @@ 
 	 * @param string $_charset
 	 * @param definition $_definition
 	 */
-	public function init(importexport_definition &$_definition ) {
+	public function init(importexport_definition &$_definition )
+	{
 
 		// fetch the addressbook bo
 		$this->bocontacts = new Api\Contacts();
@@ -90,22 +92,29 @@ 
 	{
 
 		// Set owner, unless it's supposed to come from CSV file
-		if($this->definition->plugin_options['owner_from_csv'] && $record->owner) {
-			if(!is_numeric($record->owner)) {
+		if($this->definition->plugin_options['owner_from_csv'] && $record->owner)
+		{
+			if(!is_numeric($record->owner))
+			{
 				// Automatically handle text owner without explicit translation
 				$new_owner = importexport_helper_functions::account_name2id($record->owner);
-				if($new_owner == '') {
+				if($new_owner == '')
+				{
 					$this->errors[$import_csv->get_current_position()] = lang(
 						'Unable to convert "%1" to account ID.  Using plugin setting (%2) for owner.',
 						$record->owner,
 						Api\Accounts::username($this->user)
 					);
 					$record->owner = $this->user;
-				} else {
+				}
+				else
+				{
 					$record->owner = $new_owner;
 				}
 			}
-		} else {
+		}
+		else
+		{
 			$record->owner = $this->user;
 		}
 
@@ -141,26 +150,41 @@ 
 		// Also handle categories in their own field
 		$record_array = $record->get_record_array();
 		$more_categories = array();
-		foreach($this->definition->plugin_options['field_mapping'] as $field_name) {
+		foreach($this->definition->plugin_options['field_mapping'] as $field_name)
+		{
 			if(!array_key_exists($field_name, $record_array) ||
-				substr($field_name,0,3) != 'cat' || !$record->$field_name || $field_name == 'cat_id') continue;
+				substr($field_name,0,3) != 'cat' || !$record->$field_name || $field_name == 'cat_id')
+			{
+				continue;
+			}
 			list(, $cat_id) = explode('-', $field_name);
-			if(is_numeric($record->$field_name) && $record->$field_name != 1) {
+			if(is_numeric($record->$field_name) && $record->$field_name != 1)
+			{
 				// Column has a single category ID
 				$more_categories[] = $record->$field_name;
-			} elseif($record->$field_name == '1' ||
-				(!is_numeric($record->$field_name) && strtolower($record->$field_name) == strtolower(lang('Yes')))) {
+			}
+			elseif($record->$field_name == '1' ||
+				(!is_numeric($record->$field_name) && strtolower($record->$field_name) == strtolower(lang('Yes'))))
+			{
 				// Each category got its own column.  '1' is the database value, lang('yes') is the human value
 				$more_categories[] = $cat_id;
-			} else {
+			}
+			else
+			{
 				// Text categories
 				$more_categories = array_merge($more_categories, importexport_helper_functions::cat_name2id(is_array($record->$field_name) ? $record->$field_name : explode(',',$record->$field_name), $cat_id));
 			}
 		}
-		if(count($more_categories) > 0) $record->cat_id = array_merge(is_array($record->cat_id) ? $record->cat_id : explode(',',$record->cat_id), $more_categories);
+		if(count($more_categories) > 0)
+		{
+			$record->cat_id = array_merge(is_array($record->cat_id) ? $record->cat_id : explode(',',$record->cat_id), $more_categories);
+		}
 
 		// Private set but missing causes hidden entries
-		if(array_key_exists('private', $record_array) && (!isset($record_array['private']) || $record_array['private'] == '')) unset($record->private);
+		if(array_key_exists('private', $record_array) && (!isset($record_array['private']) || $record_array['private'] == ''))
+		{
+			unset($record->private);
+		}
 
 		// Format birthday as backend requires - converter should give timestamp
 		if($record->bday && is_numeric($record->bday))
@@ -169,17 +193,24 @@ 
 			$record->bday = $time->format('Y-m-d');
 		}
 
-		if ( $this->definition->plugin_options['conditions'] ) {
-			foreach ( $this->definition->plugin_options['conditions'] as $condition ) {
+		if ( $this->definition->plugin_options['conditions'] )
+		{
+			foreach ( $this->definition->plugin_options['conditions'] as $condition )
+			{
 				$contacts = array();
-				switch ( $condition['type'] ) {
+				switch ( $condition['type'] )
+				{
 					// exists
 					case 'exists' :
-						if($record_array[$condition['string']]) {
+						if($record_array[$condition['string']])
+						{
 							$searchcondition = array( $condition['string'] => $record_array[$condition['string']]);
 							// if we use account_id for the condition, we need to set the owner for filtering, as this
 							// enables Api\Contacts\Storage to decide what backend is to be used
-							if ($condition['string']=='account_id') $searchcondition['owner']=0;
+							if ($condition['string']=='account_id')
+							{
+								$searchcondition['owner']=0;
+							}
 							$contacts = $this->bocontacts->search(
 								//array( $condition['string'] => $record[$condition['string']],),
 								'',
@@ -188,19 +219,30 @@ 
 								$searchcondition
 							);
 						}
-						if ( is_array( $contacts ) && count( array_keys( $contacts ) ) >= 1 ) {
+						if ( is_array( $contacts ) && count( array_keys( $contacts ) ) >= 1 )
+						{
 							// apply action to all contacts matching this exists condition
 							$action = $condition['true'];
-							foreach ( (array)$contacts as $contact ) {
+							foreach ( (array)$contacts as $contact )
+							{
 								$record->id = $contact['id'];
-								if ( $this->definition->plugin_options['update_cats'] == 'add' ) {
-									if ( !is_array( $contact['cat_id'] ) ) $contact['cat_id'] = explode( ',', $contact['cat_id'] );
-									if ( !is_array( $record_array['cat_id'] ) ) $record->cat_id = explode( ',', $record->cat_id );
+								if ( $this->definition->plugin_options['update_cats'] == 'add' )
+								{
+									if ( !is_array( $contact['cat_id'] ) )
+									{
+										$contact['cat_id'] = explode( ',', $contact['cat_id'] );
+									}
+									if ( !is_array( $record_array['cat_id'] ) )
+									{
+										$record->cat_id = explode( ',', $record->cat_id );
+									}
 									$record->cat_id = implode( ',', array_unique( array_merge( $record->cat_id, $contact['cat_id'] ) ) );
 								}
 								$success = $this->action(  $action['action'], $record, $import_csv->get_current_position() );
 							}
-						} else {
+						}
+						else
+						{
 							$action = $condition['false'];
 							$success = ($this->action(  $action['action'], $record, $import_csv->get_current_position() ));
 						}
@@ -227,9 +269,14 @@ 
 						die('condition / action not supported!!!');
 						break;
 				}
-				if ($action['stop']) break;
+				if ($action['stop'])
+				{
+					break;
+				}
 			}
-		} else {
+		}
+		else
+		{
 			// unconditional insert
 			$success = $this->action( 'insert', $record, $import_csv->get_current_position() );
 		}
@@ -243,15 +290,18 @@ 
 	 * @param importexport_iface_egw_record $record contact data for the action
 	 * @return bool success or not
 	 */
-	protected function action ( $_action, importexport_iface_egw_record &$record, $record_num = 0 ) {
+	protected function action ( $_action, importexport_iface_egw_record &$record, $record_num = 0 )
+	{
 		$_data = $record->get_record_array();
-		switch ($_action) {
+		switch ($_action)
+		{
 			case 'none' :
 				return true;
 			case 'delete':
 				if($_data['id'])
 				{
-					if ( $this->dry_run ) {
+					if ( $this->dry_run )
+					{
 						//print_r($_data);
 						$this->results[$_action]++;
 						return true;
@@ -272,14 +322,20 @@ 
 				// Only update if there are changes
 				$old = $this->bocontacts->read($_data['id']);
 				// if we get countrycodes as countryname, try to translate them -> the rest should be handled by bo classes.
-				foreach(array('adr_one_', 'adr_two_') as $c_prefix) {
+				foreach(array('adr_one_', 'adr_two_') as $c_prefix)
+				{
 					if (strlen(trim($_data[$c_prefix.'countryname']))==2)
-						$_data[$c_prefix.'countryname'] = $GLOBALS['egw']->country->get_full_name(trim($_data[$c_prefix.'countryname']), true);
+					{
+											$_data[$c_prefix.'countryname'] = $GLOBALS['egw']->country->get_full_name(trim($_data[$c_prefix.'countryname']), true);
+					}
 				}
 				// Don't change a user account into a contact
-				if($old['owner'] == 0) {
+				if($old['owner'] == 0)
+				{
 					unset($_data['owner']);
-				} elseif(!$this->definition->plugin_options['change_owner']) {
+				}
+				elseif(!$this->definition->plugin_options['change_owner'])
+				{
 					// Don't change addressbook of an existing contact
 					unset($_data['owner']);
 				}
@@ -287,9 +343,12 @@ 
 				// Merge to deal with fields not in import record
 				$_data = array_merge($old, $_data);
 				$changed = $this->tracking->changed_fields($_data, $old);
-				if(count($changed) == 0) {
+				if(count($changed) == 0)
+				{
 					return true;
-				} else {
+				}
+				else
+				{
 					//error_log(__METHOD__.__LINE__.array2string($changed).' Old:'.$old['adr_one_countryname'].' ('.$old['adr_one_countrycode'].') New:'.$_data['adr_one_countryname'].' ('.$_data['adr_one_countryname'].')');
 				}
 
@@ -298,24 +357,32 @@ 
 
 				// Fall through
 			case 'insert' :
-				if($_action == 'insert') {
+				if($_action == 'insert')
+				{
 					// Addressbook backend doesn't like inserting with ID specified, it screws up the owner & etag
 					unset($_data['id']);
 				}
-				if(!isset($_data['org_name'])) {
+				if(!isset($_data['org_name']))
+				{
 					// org_name is a trigger to update n_fileas
 					$_data['org_name'] = '';
 				}
 
-				if ( $this->dry_run ) {
+				if ( $this->dry_run )
+				{
 					//print_r($_data);
 					$this->results[$_action]++;
 					return true;
-				} else {
+				}
+				else
+				{
 					$result = $this->bocontacts->save( $_data, $this->is_admin);
-					if(!$result) {
+					if(!$result)
+					{
 						$this->errors[$record_num] = $this->bocontacts->error;
-					} else {
+					}
+					else
+					{
 						$this->results[$_action]++;
 						// This does nothing (yet?) but update the identifier
 						$record->save($result);
@@ -333,7 +400,8 @@ 
 	 *
 	 * @return string name
 	 */
-	public static function get_name() {
+	public static function get_name()
+	{
 		return lang('Addressbook CSV import');
 	}
 
@@ -342,7 +410,8 @@ 
 	 *
 	 * @return string descriprion
 	 */
-	public static function get_description() {
+	public static function get_description()
+	{
 		return lang("Imports contacts into your Addressbook from a CSV File. CSV means 'Comma Seperated Values'. However in the options Tab you can also choose other seperators.");
 	}
 
@@ -351,7 +420,8 @@ 
 	 *
 	 * @return string suffix (comma seperated)
 	 */
-	public static function get_filesuffix() {
+	public static function get_filesuffix()
+	{
 		return 'csv';
 	}
 
@@ -367,7 +437,8 @@ 
 	 * 		preserv		=> array,
 	 * )
 	 */
-	public function get_options_etpl() {
+	public function get_options_etpl()
+	{
 		// lets do it!
 	}
 
@@ -376,7 +447,8 @@ 
 	 *
 	 * @return string etemplate name
 	 */
-	public function get_selectors_etpl() {
+	public function get_selectors_etpl()
+	{
 		// lets do it!
 	}
 
@@ -388,7 +460,8 @@ 
         *       record_# => warning message
         *       )
         */
-        public function get_warnings() {
+        public function get_warnings()
+        {
 		return $this->warnings;
 	}
 
@@ -400,7 +473,8 @@ 
         *       record_# => error message
         *       )
         */
-        public function get_errors() {
+        public function get_errors()
+        {
 		return $this->errors;
 	}
 
@@ -412,7 +486,8 @@ 
         *       action => record count
         * )
         */
-        public function get_results() {
+        public function get_results()
+        {
                 return $this->results;
         }
 }

admin/admin-cli.php

Doc Comments -1 removed lines

@@ -532,7 +532,6 @@
 /**
  * Read the IMAP ACLs
  *
- * @param array $args admin-account[@domain],admin-password,accout_lid[,pw]
  * @return int 0 on success
  */
 function do_subscribe_other($account_lid,$pw=null)

Spacing +73 added lines, -73 removed lines

@@ -15,7 +15,7 @@ 
 use EGroupware\Api\Framework;
 use EGroupware\Api\Vfs;
 
-chdir(dirname(__FILE__));	// to enable our relative pathes to work
+chdir(dirname(__FILE__)); // to enable our relative pathes to work
 
 if (php_sapi_name() !== 'cli')	// security precaution: forbit calling admin-cli as web-page
 {
@@ -33,33 +33,33 @@ 
 }
 
 // allow to specify instance by using a username with appended @domain-name
-$arg0s = explode(',',@array_shift($arguments));
-@list($user,$domain) = explode('@',$arg0s[0]);
-load_egw($user,$arg0s[1],$domain);
+$arg0s = explode(',', @array_shift($arguments));
+@list($user, $domain) = explode('@', $arg0s[0]);
+load_egw($user, $arg0s[1], $domain);
 
-switch($action)
+switch ($action)
 {
 	case '--edit-user':
 		return do_edit_user($arg0s);
 
 	case '--add-user':	// like --edit-account, but always runs addaccount hook
-		return do_edit_user($arg0s,true);
+		return do_edit_user($arg0s, true);
 
 	case '--change-pw':
 		return do_change_pw($arg0s);
 
 	case '--delete-user':
-		return do_delete_account($arg0s[2],$arg0s[3]);
+		return do_delete_account($arg0s[2], $arg0s[3]);
 
 	case '--edit-group':
 		return do_edit_group($arg0s);
 
 	case '--delete-group':
-		return do_delete_account($arg0s[2],0,false);
+		return do_delete_account($arg0s[2], 0, false);
 
 	case '--allow-app':
 	case '--deny-app':
-		return do_account_app($arg0s,$action == '--allow-app');
+		return do_account_app($arg0s, $action == '--allow-app');
 
 	case '--change-account-id':
 		return do_change_account_id($arg0s);
@@ -79,21 +79,21 @@ 
 
 	default:
 		// we allow to call admin_cmd classes directly, if they define the constant SETUP_CLI_CALLABLE
-		if (substr($action,0,2) == '--' && class_exists($class = str_replace('-','_',substr($action,2))) &&
-			is_subclass_of($class,'admin_cmd') && @constant($class.'::SETUP_CLI_CALLABLE'))
+		if (substr($action, 0, 2) == '--' && class_exists($class = str_replace('-', '_', substr($action, 2))) &&
+			is_subclass_of($class, 'admin_cmd') && @constant($class.'::SETUP_CLI_CALLABLE'))
 		{
 			$args = array();
-			$args['domain'] = array_shift($arg0s);	// domain must be first argument, to ensure right domain get's selected in header-include
-			foreach($arg0s as $arg)
+			$args['domain'] = array_shift($arg0s); // domain must be first argument, to ensure right domain get's selected in header-include
+			foreach ($arg0s as $arg)
 			{
-				list($name,$value) = explode('=',$arg,2);
-				if(property_exists('admin_cmd',$name))		// dont allow to overwrite admin_cmd properties
+				list($name, $value) = explode('=', $arg, 2);
+				if (property_exists('admin_cmd', $name))		// dont allow to overwrite admin_cmd properties
 				{
-					throw new Api\Exception\WrongUserinput(lang("Invalid argument '%1' !!!",$arg),90);
+					throw new Api\Exception\WrongUserinput(lang("Invalid argument '%1' !!!", $arg), 90);
 				}
-				if (substr($name,-1) == ']')	// allow 1-dim. arrays
+				if (substr($name, -1) == ']')	// allow 1-dim. arrays
 				{
-					list($name,$sub) = explode('[',substr($name,0,-1),2);
+					list($name, $sub) = explode('[', substr($name, 0, -1), 2);
 					$args[$name][$sub] = $value;
 				}
 				else
@@ -117,12 +117,12 @@ 
  */
 function run_command(admin_cmd $cmd)
 {
-	global $arguments,$user,$arg0s,$domain;
+	global $arguments, $user, $arg0s, $domain;
 
 	$skip_checks = false;
 	while ($arguments && ($extra = array_shift($arguments)))
 	{
-		switch($extra)
+		switch ($extra)
 		{
 			case '--schedule':	// schedule the command instead of running it directly
 				$time = admin_cmd::parse_date(array_shift($arguments));
@@ -152,15 +152,15 @@ 
 			case '--header-access':
 				if ($cmd instanceof setup_cmd)
 				{
-					list($user,$pw) = explode(',',array_shift($arguments),2);
-					$cmd->set_header_secret($user,$pw);
+					list($user, $pw) = explode(',', array_shift($arguments), 2);
+					$cmd->set_header_secret($user, $pw);
 				}
 				break;
 
 			default:
 				//fail(99,lang('Unknown option %1',$extra);
-				echo lang('Unknown option %1',$extra)."\n\n";
-				usage('',99);
+				echo lang('Unknown option %1', $extra)."\n\n";
+				usage('', 99);
 				break;
 		}
 	}
@@ -179,7 +179,7 @@ 
 		{
 			$url = $GLOBALS['egw_info']['server']['webserver_url'].'/json.php?menuaction=admin.admin_hooks.ajax_clear_cache';
 			if ($url[0] == '/') $url = 'http://'.(!empty($domain) && $domain != 'default' ? $domain : 'localhost').$url;
-			$data = file_get_contents($url, false, Framework::proxy_context($user,$arg0s[1]));
+			$data = file_get_contents($url, false, Framework::proxy_context($user, $arg0s[1]));
 			error_log("file_get_contents('$url') returned ".array2string($data));
 			if ($data && strpos($data, '"success"') !== false)
 			{
@@ -218,13 +218,13 @@ 
 	{
 		//fail(1,lang("Wrong admin-account or -password !!!"));
 		echo lang("Wrong admin-account or -password !!!")."\n\n";
-		usage('',1);
+		usage('', 1);
 	}
 	if (!$GLOBALS['egw_info']['user']['apps']['admin'])	// will be tested by the header too, but whould give html error-message
 	{
 		//fail(2,lang("Permission denied !!!"));
 		echo lang("Permission denied !!!")."\n\n";
-		usage('',2);
+		usage('', 2);
 	}
 	return $sessionid;
 }
@@ -236,7 +236,7 @@ 
  * @param string $passwd
  * @param string $domain
  */
-function load_egw($user,$passwd,$domain='default')
+function load_egw($user, $passwd, $domain = 'default')
 {
 	//echo "load_egw($user,$passwd,$domain)\n";
 	$_REQUEST['domain'] = $domain;
@@ -248,7 +248,7 @@ 
 
 	if (ini_get('session.save_handler') == 'files' && !is_writable(ini_get('session.save_path')) && is_dir('/tmp') && is_writable('/tmp'))
 	{
-		ini_set('session.save_path','/tmp');	// regular users may have no rights to apache's session dir
+		ini_set('session.save_path', '/tmp'); // regular users may have no rights to apache's session dir
 	}
 
 	$GLOBALS['egw_info'] = array(
@@ -260,7 +260,7 @@ 
 		)
 	);
 
-	if (substr($user,0,5) != 'root_')
+	if (substr($user, 0, 5) != 'root_')
 	{
 		include('../header.inc.php');
 	}
@@ -270,9 +270,9 @@ 
 		include('../header.inc.php');
 
 		if ($user == 'root_'.$GLOBALS['egw_info']['server']['header_admin_user'] &&
-			_check_pw($GLOBALS['egw_info']['server']['header_admin_password'],$passwd) ||
+			_check_pw($GLOBALS['egw_info']['server']['header_admin_password'], $passwd) ||
 			$user == 'root_'.$GLOBALS['egw_domain'][$_GET['domain']]['config_user'] &&
-			_check_pw($GLOBALS['egw_domain'][$_GET['domain']]['config_passwd'],$passwd))
+			_check_pw($GLOBALS['egw_domain'][$_GET['domain']]['config_passwd'], $passwd))
 		{
 			echo "\nRoot access granted!\n";
 			Vfs::$is_root = true;
@@ -291,10 +291,10 @@ 
  * @param string $pw
  * @return boolean
  */
-function _check_pw($hash_or_cleartext,$pw)
+function _check_pw($hash_or_cleartext, $pw)
 {
 	//echo "_check_pw($hash_or_cleartext,$pw) md5=".md5($pw)."\n";
-	if (preg_match('/^[0-9a-f]{32}$/',$hash_or_cleartext))
+	if (preg_match('/^[0-9a-f]{32}$/', $hash_or_cleartext))
 	{
 		return $hash_or_cleartext == md5($pw);
 	}
@@ -307,7 +307,7 @@ 
  * @param string $action =null
  * @param int $ret =0 exit-code
  */
-function usage($action=null,$ret=0)
+function usage($action = null, $ret = 0)
 {
 	unset($action);
 	$cmd = basename($_SERVER['argv'][0]);
@@ -350,14 +350,14 @@ 
  * @param boolean $allow true=allow, false=deny
  * @return int 0 on success
  */
-function do_account_app($args,$allow)
+function do_account_app($args, $allow)
 {
-	array_shift($args);	// admin-account
-	array_shift($args);	// admin-pw
+	array_shift($args); // admin-account
+	array_shift($args); // admin-pw
 	$account = array_shift($args);
 
 	include_once(EGW_INCLUDE_ROOT.'/admin/inc/class.admin_cmd_account_app.inc.php');
-	run_command(new admin_cmd_account_app($allow,$account,$args));
+	run_command(new admin_cmd_account_app($allow, $account, $args));
 }
 
 /**
@@ -367,9 +367,9 @@ 
  */
 function do_edit_group($args)
 {
-	array_shift($args);	// admin-account
-	array_shift($args);	// admin-pw
-	list($account,$new_account_name) = explode('=',array_shift($args));	// account[=new-account-name]
+	array_shift($args); // admin-account
+	array_shift($args); // admin-pw
+	list($account, $new_account_name) = explode('=', array_shift($args)); // account[=new-account-name]
 
 	$data = array(
 		'account_lid' => $new_account_name,
@@ -377,19 +377,19 @@ 
 		'account_members' => $args,
 	);
 	try {
-		admin_cmd::parse_account($account,false);
+		admin_cmd::parse_account($account, false);
 
-		foreach($data as &$value)	// existing account --> empty values mean dont change, not set them empty!
+		foreach ($data as &$value)	// existing account --> empty values mean dont change, not set them empty!
 		{
 			if ((string)$value === '') $value = null;
 		}
 	}
 	catch (Exception $e) {	// new group
-		unset($e);	// not used
+		unset($e); // not used
 		$data['account_lid'] = $account;
 		$account = false;
 	}
-	run_command(new admin_cmd_edit_group($account,$data));
+	run_command(new admin_cmd_edit_group($account, $data));
 }
 
 /**
@@ -399,12 +399,12 @@ 
  */
 function do_change_pw($args)
 {
-	array_shift($args);     // admin-account
-	array_shift($args);     // admin-pw
-	$account = array_shift($args);	// account
-	$password = array_shift($args);	// pw
+	array_shift($args); // admin-account
+	array_shift($args); // admin-pw
+	$account = array_shift($args); // account
+	$password = array_shift($args); // pw
 
-	run_command(new admin_cmd_change_pw($account,$password));
+	run_command(new admin_cmd_change_pw($account, $password));
 }
 
 /**
@@ -413,18 +413,18 @@ 
  * @param array $args admin-account[@domain],admin-password,account[=new-account-name],first-name,last-name,password,email,expires{never(default)|YYYY-MM-DD|already},can-change-pw{true(default)|false},anon-user{true|false(default)},primary-group{Default(default)|...}[,groups,...][,homedirectory,loginshell]
  * @param boolean $run_addaccount_hook =null default run hook depending on account existence, true=allways run addaccount hook
  */
-function do_edit_user($args,$run_addaccount_hook=null)
+function do_edit_user($args, $run_addaccount_hook = null)
 {
-	array_shift($args);	// admin-account
-	array_shift($args);	// admin-pw
-	list($account,$new_account_name) = explode('=',array_shift($args));	// account[=new-account-name]
+	array_shift($args); // admin-account
+	array_shift($args); // admin-pw
+	list($account, $new_account_name) = explode('=', array_shift($args)); // account[=new-account-name]
 
 	$data = array();
 	// do we need to support ldap only attributes: homedirectory and loginshell
 	if (($GLOBALS['egw_info']['server']['account_repository'] == 'ldap' ||
 		 empty($GLOBALS['egw_info']['server']['account_repository']) && $GLOBALS['egw_info']['server']['auth_type'] == 'ldap') &&
-		$GLOBALS['egw_info']['server']['ldap_extra_attributes'] && count($args) > 9 &&	// 9 = primary group
-		($last_arg = array_pop($dummy=$args)) && $last_arg[0] == '/')	// last argument start with a slash
+		$GLOBALS['egw_info']['server']['ldap_extra_attributes'] && count($args) > 9 && // 9 = primary group
+		($last_arg = array_pop($dummy = $args)) && $last_arg[0] == '/')	// last argument start with a slash
 	{
 		$data['loginshell'] = array_pop($args);
 		$data['homedirectory'] = array_pop($args);
@@ -442,19 +442,19 @@ 
 		'account_groups' => $args,
 	);
 	try {
-		admin_cmd::parse_account($account,true);
+		admin_cmd::parse_account($account, true);
 
-		foreach($data as &$value)	// existing account --> empty values mean dont change, not set them empty!
+		foreach ($data as &$value)	// existing account --> empty values mean dont change, not set them empty!
 		{
 			if ((string)$value === '') $value = null;
 		}
 	}
 	catch (Exception $e) {	// new account
-		unset($e);	// not used
+		unset($e); // not used
 		$data['account_lid'] = $account;
 		$account = false;
 	}
-	run_command(new admin_cmd_edit_user($account,$data,null,$run_addaccount_hook));
+	run_command(new admin_cmd_edit_user($account, $data, null, $run_addaccount_hook));
 }
 
 /**
@@ -465,9 +465,9 @@ 
  * @param boolean $is_user =true are we called for a user or group
  * @return int 0 on success, 2-4 otherwise (see source)
  */
-function do_delete_account($account,$new_user=0,$is_user=true)
+function do_delete_account($account, $new_user = 0, $is_user = true)
 {
-	run_command(new admin_cmd_delete_account($account,$new_user,$is_user));
+	run_command(new admin_cmd_delete_account($account, $new_user, $is_user));
 }
 
 /**
@@ -488,13 +488,13 @@ 
  */
 function do_change_account_id($args)
 {
-	if (count($args) < 4) usage();	// 4 means at least user,pw,from1,to1
+	if (count($args) < 4) usage(); // 4 means at least user,pw,from1,to1
 
 	$ids2change = array();
-	for($n = 2; $n < count($args); $n += 2)
+	for ($n = 2; $n < count($args); $n += 2)
 	{
 		$from = (int)$args[$n];
-		$to   = (int)$args[$n+1];
+		$to   = (int)$args[$n + 1];
 		$ids2change[$from] = $to;
 	}
 	run_command(new admin_cmd_change_account_id($ids2change));
@@ -510,22 +510,22 @@ 
  */
 function list_exit_codes()
 {
-	error_reporting(error_reporting() & ~E_NOTICE);
+	error_reporting(error_reporting()&~E_NOTICE);
 
 	$codes = array('Ok');
-	foreach(file(__FILE__) as $line)
+	foreach (file(__FILE__) as $line)
 	{
 		$matches = null;
-		if (preg_match('/fail\(([0-9]+),(.*)\);/',$line,$matches))
+		if (preg_match('/fail\(([0-9]+),(.*)\);/', $line, $matches))
 		{
 			//echo "Line $n: $matches[1]: $matches[2]\n";
 			@eval('$codes['.$matches[1].'] = '.$matches[2].';');
 		}
 	}
-	ksort($codes,SORT_NUMERIC);
-	foreach($codes as $num => $msg)
+	ksort($codes, SORT_NUMERIC);
+	foreach ($codes as $num => $msg)
 	{
-		echo $num."\t".str_replace("\n","\n\t",$msg)."\n";
+		echo $num."\t".str_replace("\n", "\n\t", $msg)."\n";
 	}
 }
 
@@ -535,7 +535,7 @@ 
  * @param array $args admin-account[@domain],admin-password,accout_lid[,pw]
  * @return int 0 on success
  */
-function do_subscribe_other($account_lid,$pw=null)
+function do_subscribe_other($account_lid, $pw = null)
 {
 	unset($account_lid, $pw);
 	/* ToDo: this cant work, not even in 14.x

Braces +37 added lines, -9 removed lines

@@ -17,10 +17,13 @@ 
 
 chdir(dirname(__FILE__));	// to enable our relative pathes to work
 
-if (php_sapi_name() !== 'cli')	// security precaution: forbit calling admin-cli as web-page
+if (php_sapi_name() !== 'cli')
+{
+	// security precaution: forbit calling admin-cli as web-page
 {
 	die('<h1>admin-cli.php must NOT be called as web-page --> exiting !!!</h1>');
 }
+}
 elseif ($_SERVER['argc'] > 1)
 {
 	$arguments = $_SERVER['argv'];
@@ -87,13 +90,19 @@ 
 			foreach($arg0s as $arg)
 			{
 				list($name,$value) = explode('=',$arg,2);
-				if(property_exists('admin_cmd',$name))		// dont allow to overwrite admin_cmd properties
+				if(property_exists('admin_cmd',$name))
+				{
+					// dont allow to overwrite admin_cmd properties
 				{
 					throw new Api\Exception\WrongUserinput(lang("Invalid argument '%1' !!!",$arg),90);
 				}
-				if (substr($name,-1) == ']')	// allow 1-dim. arrays
+				}
+				if (substr($name,-1) == ']')
+				{
+					// allow 1-dim. arrays
 				{
 					list($name,$sub) = explode('[',substr($name,0,-1),2);
+				}
 					$args[$name][$sub] = $value;
 				}
 				else
@@ -178,7 +187,10 @@ 
 		if (!$dry_run)
 		{
 			$url = $GLOBALS['egw_info']['server']['webserver_url'].'/json.php?menuaction=admin.admin_hooks.ajax_clear_cache';
-			if ($url[0] == '/') $url = 'http://'.(!empty($domain) && $domain != 'default' ? $domain : 'localhost').$url;
+			if ($url[0] == '/')
+			{
+				$url = 'http://'.(!empty($domain) && $domain != 'default' ? $domain : 'localhost').$url;
+			}
 			$data = file_get_contents($url, false, Framework::proxy_context($user,$arg0s[1]));
 			error_log("file_get_contents('$url') returned ".array2string($data));
 			if ($data && strpos($data, '"success"') !== false)
@@ -220,10 +232,13 @@ 
 		echo lang("Wrong admin-account or -password !!!")."\n\n";
 		usage('',1);
 	}
-	if (!$GLOBALS['egw_info']['user']['apps']['admin'])	// will be tested by the header too, but whould give html error-message
+	if (!$GLOBALS['egw_info']['user']['apps']['admin'])
+	{
+		// will be tested by the header too, but whould give html error-message
 	{
 		//fail(2,lang("Permission denied !!!"));
 		echo lang("Permission denied !!!")."\n\n";
+	}
 		usage('',2);
 	}
 	return $sessionid;
@@ -379,10 +394,13 @@ 
 	try {
 		admin_cmd::parse_account($account,false);
 
-		foreach($data as &$value)	// existing account --> empty values mean dont change, not set them empty!
+		foreach($data as &$value)
+		{
+			// existing account --> empty values mean dont change, not set them empty!
 		{
 			if ((string)$value === '') $value = null;
 		}
+		}
 	}
 	catch (Exception $e) {	// new group
 		unset($e);	// not used
@@ -424,9 +442,12 @@ 
 	if (($GLOBALS['egw_info']['server']['account_repository'] == 'ldap' ||
 		 empty($GLOBALS['egw_info']['server']['account_repository']) && $GLOBALS['egw_info']['server']['auth_type'] == 'ldap') &&
 		$GLOBALS['egw_info']['server']['ldap_extra_attributes'] && count($args) > 9 &&	// 9 = primary group
-		($last_arg = array_pop($dummy=$args)) && $last_arg[0] == '/')	// last argument start with a slash
+		($last_arg = array_pop($dummy=$args)) && $last_arg[0] == '/')
+	{
+		// last argument start with a slash
 	{
 		$data['loginshell'] = array_pop($args);
+	}
 		$data['homedirectory'] = array_pop($args);
 	}
 	$data += array(
@@ -444,10 +465,13 @@ 
 	try {
 		admin_cmd::parse_account($account,true);
 
-		foreach($data as &$value)	// existing account --> empty values mean dont change, not set them empty!
+		foreach($data as &$value)
+		{
+			// existing account --> empty values mean dont change, not set them empty!
 		{
 			if ((string)$value === '') $value = null;
 		}
+		}
 	}
 	catch (Exception $e) {	// new account
 		unset($e);	// not used
@@ -488,7 +512,11 @@ 
  */
 function do_change_account_id($args)
 {
-	if (count($args) < 4) usage();	// 4 means at least user,pw,from1,to1
+	if (count($args) < 4)
+	{
+		usage();
+	}
+	// 4 means at least user,pw,from1,to1
 
 	$ids2change = array();
 	for($n = 2; $n < count($args); $n += 2)

admin/inc/class.admin_accesslog.inc.php

Doc Comments +1 added lines, -2 removed lines

@@ -255,11 +255,10 @@
 	 *
 	 * @param type $action
 	 * @param type $checked
-	 * @param type $use_all
 	 * @param type $success
 	 * @param int $failed
 	 * @param type $action_msg
-	 * @return type number of failed
+	 * @return boolean number of failed
 	 */
 	function action($action,$checked,&$success,&$failed,&$action_msg)
 	{

Spacing +49 added lines, -49 removed lines

@@ -50,7 +50,7 @@ 
 	 */
 	function __construct()
 	{
-		$this->so = new Api\Storage\Base(self::APP,self::TABLE,null,'',true);
+		$this->so = new Api\Storage\Base(self::APP, self::TABLE, null, '', true);
 		$this->so->timestamps = array('li', 'lo', 'session_dla', 'notification_heartbeat');
 	}
 
@@ -63,19 +63,19 @@ 
 	 * @param array &$readonlys eg. to disable buttons based on acl, not use here, maybe in a derived class
 	 * @return int total number of rows
 	 */
-	function get_rows($query,&$rows,&$readonlys)
+	function get_rows($query, &$rows, &$readonlys)
 	{
 		$heartbeat_limit = Api\Session::heartbeat_limit();
 
 		if ($query['session_list'])	// filter active sessions
 		{
-			$query['col_filter']['lo'] = null;	// not logged out
+			$query['col_filter']['lo'] = null; // not logged out
 			$query['col_filter'][0] = 'session_dla > '.(int)(time() - $GLOBALS['egw_info']['server']['sessions_timeout']);
-			switch((string)$query['session_list'])
+			switch ((string)$query['session_list'])
 			{
 				case 'active':	// remove status != 'active', eg. CalDAV/eSync
 					$query['col_filter'][1] = "notification_heartbeat > $heartbeat_limit";
-					$query['col_filter'][3] = "session_php NOT LIKE '% %'";	// remove blocked, bad login, etc
+					$query['col_filter'][3] = "session_php NOT LIKE '% %'"; // remove blocked, bad login, etc
 					break;
 				default:
 					$query['col_filter'][1] = "(notification_heartbeat IS NULL OR notification_heartbeat > $heartbeat_limit)";
@@ -83,20 +83,20 @@ 
 			}
 			$query['col_filter'][2] = 'account_id>0';
 		}
-		$total = $this->so->get_rows($query,$rows,$readonlys);
+		$total = $this->so->get_rows($query, $rows, $readonlys);
 
 		$heartbeat_limit_user = Api\DateTime::server2user($heartbeat_limit, 'ts');
 
-		foreach($rows as &$row)
+		foreach ($rows as &$row)
 		{
 			$row['sessionstatus'] = 'success';
 			if ($row['notification_heartbeat'] > $heartbeat_limit_user)
 			{
 				$row['sessionstatus'] = 'active';
 			}
-			if (stripos($row['session_php'],'blocked') !== false ||
-				stripos($row['session_php'],'bad login') !== false ||
-				strpos($row['session_php'],' ') !== false)
+			if (stripos($row['session_php'], 'blocked') !== false ||
+				stripos($row['session_php'], 'bad login') !== false ||
+				strpos($row['session_php'], ' ') !== false)
 			{
 				$row['sessionstatus'] = $row['session_php'];
 			}
@@ -105,7 +105,7 @@ 
 				$row['sessionstatus'] = 'logged out';
 			}
 			// eg. for bad login or password
-			if (!$row['account_id']) $row['alt_loginid'] = ($row['loginid']?$row['loginid']:lang('none'));
+			if (!$row['account_id']) $row['alt_loginid'] = ($row['loginid'] ? $row['loginid'] : lang('none'));
 
 			// do not allow to kill or select own session
 			if ($GLOBALS['egw']->session->sessionid_access_log == $row['sessionid'] && $query['session_list'])
@@ -113,13 +113,13 @@ 
 				$row['class'] .= ' rowNoDelete ';
 			}
 			// do not allow to delete access log off active sessions
-			if (!$row['lo'] && $row['session_dla'] > time()-$GLOBALS['egw_info']['server']['sessions_timeout'] &&
+			if (!$row['lo'] && $row['session_dla'] > time() - $GLOBALS['egw_info']['server']['sessions_timeout'] &&
 				in_array($row['sessionstatus'], array('active', 'success')) && !$query['session_list'])
 			{
 				$row['class'] .= ' rowNoDelete ';
 			}
 			$row['sessionstatus'] = lang($row['sessionstatus']);
-			unset($row['session_php']);	// for security reasons, do NOT give real PHP sessionid to UI
+			unset($row['session_php']); // for security reasons, do NOT give real PHP sessionid to UI
 		}
 		if ($query['session_list'])
 		{
@@ -139,33 +139,33 @@ 
 	 * @param string $msg =''
 	 * @param boolean $sessions_list =false
 	 */
-	function index(array $content=null, $msg='', $sessions_list=false)
+	function index(array $content = null, $msg = '', $sessions_list = false)
 	{
 
 		if (is_array($content)) $sessions_list = $content['nm']['session_list'];
 
 		// check if user has access to requested functionality
-		if ($GLOBALS['egw']->acl->check($sessions_list ? 'current_sessions' : 'access_log_acces',1,'admin'))
+		if ($GLOBALS['egw']->acl->check($sessions_list ? 'current_sessions' : 'access_log_acces', 1, 'admin'))
 		{
 			$GLOBALS['egw']->redirect_link('/index.php');
 		}
 
-		if(!isset($content))
+		if (!isset($content))
 		{
 			$content['nm'] = array(
-				'get_rows'       =>	'admin.admin_accesslog.get_rows',	// I  method/callback to request the data for the rows eg. 'notes.bo.get_rows'
-				'no_filter'      => True,	// I  disable the 1. filter
-				'no_filter2'     => True,	// I  disable the 2. filter (params are the same as for filter)
-				'no_cat'         => True,	// I  disable the cat-selectbox
-				'header_left'    =>	false,	// I  template to show left of the range-value, left-aligned (optional)
-				'header_right'   =>	false,	// I  template to show right of the range-value, right-aligned (optional)
-				'never_hide'     => True,	// I  never hide the nextmatch-line if less then maxmatch entries
-				'lettersearch'   => false,	// I  show a lettersearch
-				'start'          =>	0,		// IO position in list
-				'order'          =>	'li',	// IO name of the column to sort after (optional for the sortheaders)
-				'sort'           =>	'DESC',	// IO direction of the sort: 'ASC' or 'DESC'
+				'get_rows'       =>	'admin.admin_accesslog.get_rows', // I  method/callback to request the data for the rows eg. 'notes.bo.get_rows'
+				'no_filter'      => True, // I  disable the 1. filter
+				'no_filter2'     => True, // I  disable the 2. filter (params are the same as for filter)
+				'no_cat'         => True, // I  disable the cat-selectbox
+				'header_left'    =>	false, // I  template to show left of the range-value, left-aligned (optional)
+				'header_right'   =>	false, // I  template to show right of the range-value, right-aligned (optional)
+				'never_hide'     => True, // I  never hide the nextmatch-line if less then maxmatch entries
+				'lettersearch'   => false, // I  show a lettersearch
+				'start'          =>	0, // IO position in list
+				'order'          =>	'li', // IO name of the column to sort after (optional for the sortheaders)
+				'sort'           =>	'DESC', // IO direction of the sort: 'ASC' or 'DESC'
 				//'default_cols'   => 	// I  columns to use if there's no user or default pref (! as first char uses all but the named columns), default all columns
-				'csv_fields'     =>	false,	// I  false=disable csv export, true or unset=enable it with auto-detected fieldnames,
+				'csv_fields'     =>	false, // I  false=disable csv export, true or unset=enable it with auto-detected fieldnames,
 								//or array with name=>label or name=>array('label'=>label,'type'=>type) pairs (type is a eT widget-type)
 				'actions'		=> $this->get_actions($sessions_list),
 				'placeholder_actions' => false,
@@ -196,12 +196,12 @@ 
 					'col_filter' => $content['nm']['col_filter']
 				);
 
-				@set_time_limit(0);			// switch off the execution time limit, as it's for big selections to small
-				$query['num_rows'] = -1;	// all
+				@set_time_limit(0); // switch off the execution time limit, as it's for big selections to small
+				$query['num_rows'] = -1; // all
 				$all = $readonlys = array();
-				$this->get_rows($query,$all,$readonlys);
+				$this->get_rows($query, $all, $readonlys);
 				$content['nm']['selected'] = array();
-				foreach($all as $session)
+				foreach ($all as $session)
 				{
 					$content['nm']['selected'][] = $session[$content['nm']['row_id']];
 				}
@@ -213,19 +213,19 @@ 
 			else
 			{
 				$success = $failed = $action = $action_msg = null;
-				if ($this->action($content['nm']['action'],$content['nm']['selected']
-					,$success,$failed,$action_msg,$msg))
+				if ($this->action($content['nm']['action'], $content['nm']['selected']
+					,$success, $failed, $action_msg, $msg))
 				{ // In case of action success
 					switch ($action_msg)
 					{
 						case'deleted':
-							$msg = lang('%1 log entries deleted.',$success);
+							$msg = lang('%1 log entries deleted.', $success);
 							break;
 						case'killed':
-							$msg = lang('%1 sessions killed',$success);
+							$msg = lang('%1 sessions killed', $success);
 					}
 				}
-				elseif($failed) // In case of action failiure
+				elseif ($failed) // In case of action failiure
 				{
 					switch ($action_msg)
 					{
@@ -242,7 +242,7 @@ 
 		$content['msg'] = $msg;
 		$content['percent'] = 100.0 * $GLOBALS['egw']->db->query(
 			'SELECT ((SELECT COUNT(*) FROM '.self::TABLE.' WHERE lo != 0) / COUNT(*)) FROM '.self::TABLE,
-			__LINE__,__FILE__)->fetchColumn();
+			__LINE__, __FILE__)->fetchColumn();
 
 		$tmpl = new Etemplate('admin.accesslog');
 		$tmpl->exec('admin.admin_accesslog.index', $content, array(), $readonlys, array(
@@ -261,7 +261,7 @@ 
 	 * @param type $action_msg
 	 * @return type number of failed
 	 */
-	function action($action,$checked,&$success,&$failed,&$action_msg)
+	function action($action, $checked, &$success, &$failed, &$action_msg)
 	{
 		$success = $failed = 0;
 		//error_log(__METHOD__.'selected:' . array2string($checked). 'action:' . $action);
@@ -269,14 +269,14 @@ 
 		{
 			case "delete":
 				$action_msg = "deleted";
-				$del_msg= $this->so->delete(array('sessionid' => $checked));
+				$del_msg = $this->so->delete(array('sessionid' => $checked));
 				if ($checked && $del_msg)
 				{
 					$success = $del_msg;
 				}
 				else
 				{
-					$failed ++;
+					$failed++;
 				}
 				break;
 			case "kill":
@@ -284,19 +284,19 @@ 
 				$sessionid = $checked;
 				if (($key = array_search($GLOBALS['egw']->session->sessionid_access_log, $sessionid)))
 				{
-						unset($sessionid[$key]);	// dont allow to kill own sessions
+						unset($sessionid[$key]); // dont allow to kill own sessions
 				}
-				if ($GLOBALS['egw']->acl->check('current_sessions',8,'admin'))
+				if ($GLOBALS['egw']->acl->check('current_sessions', 8, 'admin'))
 				{
-					$failed ++;
+					$failed++;
 				}
 				else
 				{
-					foreach((array)$sessionid as $id)
+					foreach ((array)$sessionid as $id)
 					{
 						$GLOBALS['egw']->session->destroy($id);
 					}
-					$success= count($sessionid);
+					$success = count($sessionid);
 				}
 				break;
 		}
@@ -316,7 +316,7 @@ 
 		if ($sessions_list)
 		{
 		//	error_log(__METHOD__. $sessions_list);
-			$actions= array(
+			$actions = array(
 				'kill' => array(
 					'caption' => 'Kill',
 					'confirm' => 'Kill this session',
@@ -329,7 +329,7 @@ 
 		}
 		else
 		{
-			$actions= array(
+			$actions = array(
 				'delete' => array(
 					'caption' => 'Delete',
 					'confirm' => 'Delete this entry',
@@ -361,7 +361,7 @@ 
 	 * @param array $content =null
 	 * @param string $msg =''
 	 */
-	function sessions(array $content=null, $msg='')
+	function sessions(array $content = null, $msg = '')
 	{
 		return $this->index($content, $msg, true);
 	}

Braces +22 added lines, -7 removed lines

@@ -67,9 +67,13 @@ 
 	{
 		$heartbeat_limit = Api\Session::heartbeat_limit();
 
-		if ($query['session_list'])	// filter active sessions
+		if ($query['session_list'])
+		{
+			// filter active sessions
 		{
-			$query['col_filter']['lo'] = null;	// not logged out
+			$query['col_filter']['lo'] = null;
+		}
+		// not logged out
 			$query['col_filter'][0] = 'session_dla > '.(int)(time() - $GLOBALS['egw_info']['server']['sessions_timeout']);
 			switch((string)$query['session_list'])
 			{
@@ -100,12 +104,16 @@ 
 			{
 				$row['sessionstatus'] = $row['session_php'];
 			}
-			if ($row['lo']) {
+			if ($row['lo'])
+			{
 				$row['total'] = ($row['lo'] - $row['li']) / 60;
 				$row['sessionstatus'] = 'logged out';
 			}
 			// eg. for bad login or password
-			if (!$row['account_id']) $row['alt_loginid'] = ($row['loginid']?$row['loginid']:lang('none'));
+			if (!$row['account_id'])
+			{
+				$row['alt_loginid'] = ($row['loginid']?$row['loginid']:lang('none'));
+			}
 
 			// do not allow to kill or select own session
 			if ($GLOBALS['egw']->session->sessionid_access_log == $row['sessionid'] && $query['session_list'])
@@ -142,7 +150,10 @@ 
 	function index(array $content=null, $msg='', $sessions_list=false)
 	{
 
-		if (is_array($content)) $sessions_list = $content['nm']['session_list'];
+		if (is_array($content))
+		{
+			$sessions_list = $content['nm']['session_list'];
+		}
 
 		// check if user has access to requested functionality
 		if ($GLOBALS['egw']->acl->check($sessions_list ? 'current_sessions' : 'access_log_acces',1,'admin'))
@@ -215,7 +226,8 @@ 
 				$success = $failed = $action = $action_msg = null;
 				if ($this->action($content['nm']['action'],$content['nm']['selected']
 					,$success,$failed,$action_msg,$msg))
-				{ // In case of action success
+				{
+// In case of action success
 					switch ($action_msg)
 					{
 						case'deleted':
@@ -225,12 +237,15 @@ 
 							$msg = lang('%1 sessions killed',$success);
 					}
 				}
-				elseif($failed) // In case of action failiure
+				elseif($failed)
+				{
+					// In case of action failiure
 				{
 					switch ($action_msg)
 					{
 						case'deleted':
 							$msg = lang('Error deleting log entry!');
+				}
 							break;
 						case'killed':
 							$msg = lang('Permission denied!');

admin/inc/class.admin_categories.inc.php

Doc Comments +2 added lines

@@ -679,6 +679,8 @@
 	 * @param int &$failed number of failed actions (not enought permissions)
 	 * @param string &$action_msg translated verb for the actions, to be used in a message like '%1 entries deleted'
 	 * @param array $query get_rows parameter
+	 * @param integer $success
+	 * @param integer $failed
 	 * @return boolean true if all actions succeded, false otherwise
 	 */
 	function action($_action, $checked, $use_all, &$success, &$failed, &$action_msg, array $query)

Spacing +125 added lines, -126 removed lines

@@ -63,7 +63,7 @@ 
 		{
 			throw new Api\Exception\NoPermission\Admin();
 		}
-		if ($GLOBALS['egw']->acl->check('global_categorie',1,'admin'))
+		if ($GLOBALS['egw']->acl->check('global_categorie', 1, 'admin'))
 		{
 			$GLOBALS['egw']->redirect_link('/index.php');
 		}
@@ -77,12 +77,12 @@ 
 	{
 		if (is_null(self::$acl_search))
 		{
-			self::$acl_search = !$GLOBALS['egw']->acl->check('global_categorie',2,'admin');
-			self::$acl_add    = !$GLOBALS['egw']->acl->check('global_categorie',4,'admin');
-			self::$acl_view   = !$GLOBALS['egw']->acl->check('global_categorie',8,'admin');
-			self::$acl_edit   = !$GLOBALS['egw']->acl->check('global_categorie',16,'admin');
-			self::$acl_delete = !$GLOBALS['egw']->acl->check('global_categorie',32,'admin');
-			self::$acl_add_sub= !$GLOBALS['egw']->acl->check('global_categorie',64,'admin');
+			self::$acl_search = !$GLOBALS['egw']->acl->check('global_categorie', 2, 'admin');
+			self::$acl_add    = !$GLOBALS['egw']->acl->check('global_categorie', 4, 'admin');
+			self::$acl_view   = !$GLOBALS['egw']->acl->check('global_categorie', 8, 'admin');
+			self::$acl_edit   = !$GLOBALS['egw']->acl->check('global_categorie', 16, 'admin');
+			self::$acl_delete = !$GLOBALS['egw']->acl->check('global_categorie', 32, 'admin');
+			self::$acl_add_sub = !$GLOBALS['egw']->acl->check('global_categorie', 64, 'admin');
 		}
 	}
 
@@ -92,11 +92,11 @@ 
 	 * @param array $content = null
 	 * @param string $msg = ''
 	 */
-	public function edit(array $content=null,$msg='')
+	public function edit(array $content = null, $msg = '')
 	{
 		// read the session, as the global_cats param is stored with it.
-		$appname = $content['appname'] ? $content['appname'] : ($_GET['appname']?$_GET['appname']:Api\Categories::GLOBAL_APPNAME);
-		$session = Api\Cache::getSession(__CLASS__.$appname,'nm');
+		$appname = $content['appname'] ? $content['appname'] : ($_GET['appname'] ? $_GET['appname'] : Api\Categories::GLOBAL_APPNAME);
+		$session = Api\Cache::getSession(__CLASS__.$appname, 'nm');
 		unset($session);
 		if (!isset($content))
 		{
@@ -104,7 +104,7 @@ 
 				($content = Categories::read($_GET['cat_id']))))
 			{
 				$content = array('data' => array());
-				if(isset($_GET['parent']) && $_GET['parent'] > 0)
+				if (isset($_GET['parent']) && $_GET['parent'] > 0)
 				{
 					// Sub-category - set some defaults from parent
 					$content['parent'] = (int)$_GET['parent'];
@@ -120,7 +120,7 @@ 
 					$appname = Categories::GLOBAL_APPNAME;
 				}
 			}
-			elseif ($content['appname'] != $appname || !self::$acl_edit || ( $content['owner'] != $GLOBALS['egw_info']['user']['account_id'] && $this->appname != 'admin'))
+			elseif ($content['appname'] != $appname || !self::$acl_edit || ($content['owner'] != $GLOBALS['egw_info']['user']['account_id'] && $this->appname != 'admin'))
 			{
 				// only allow to view category
 				$readonlys['__ALL__'] = true;
@@ -130,12 +130,12 @@ 
 		}
 		elseif ($content['button'] || $content['delete'])
 		{
-			$cats = new Categories($content['owner'] ? $content['owner'] : Categories::GLOBAL_ACCOUNT,$content['appname']);
+			$cats = new Categories($content['owner'] ? $content['owner'] : Categories::GLOBAL_ACCOUNT, $content['appname']);
 
 			if ($content['delete']['delete'] || $content['delete']['subs'])
 			{
 				$button = 'delete';
-				$delete_subs = $content['delete']['subs']?true:false;
+				$delete_subs = $content['delete']['subs'] ? true : false;
 			}
 			else
 			{
@@ -146,23 +146,23 @@ 
 
 			$refresh_app = $this->appname == 'preferences' ? $content['appname'] : $this->appname;
 
-			switch($button)
+			switch ($button)
 			{
 				case 'save':
 				case 'apply':
-					if(is_array($content['owner'])) $content['owner'] = implode(',',$content['owner']);
-					if($content['owner'] == '') $content['owner'] = 0;
+					if (is_array($content['owner'])) $content['owner'] = implode(',', $content['owner']);
+					if ($content['owner'] == '') $content['owner'] = 0;
 					if ($content['id'] && self::$acl_edit)
 					{
 
-						$data = $cats->id2name($content['id'],'data');
+						$data = $cats->id2name($content['id'], 'data');
 						try {
 							$cats->edit($content);
 							$msg = lang('Category saved.');
 						}
 						catch (Api\Exception\WrongUserinput $e)
 						{
-							$msg = lang('Unwilling to save category with current settings. Check for inconsistency:').$e->getMessage();	// display conflicts etc.
+							$msg = lang('Unwilling to save category with current settings. Check for inconsistency:').$e->getMessage(); // display conflicts etc.
 						}
 					}
 					elseif (!$content['id'] && (
@@ -181,15 +181,15 @@ 
 					// to reload the whole nextmatch instead of just the row
 					$change_color = ($data['color'] != $content['data']['color']);
 					// Nicely reload just the category window / iframe
-					if($change_color)
+					if ($change_color)
 					{
-						if(Api\Json\Response::isJSONResponse())
+						if (Api\Json\Response::isJSONResponse())
 						{
 							// Update category styles
-							Api\Json\Response::get()->apply('opener.egw.includeCSS',array(Categories::css($refresh_app == 'admin' ? Categories::GLOBAL_APPNAME : $refresh_app)));
-							if($this->appname != 'admin')
+							Api\Json\Response::get()->apply('opener.egw.includeCSS', array(Categories::css($refresh_app == 'admin' ? Categories::GLOBAL_APPNAME : $refresh_app)));
+							if ($this->appname != 'admin')
 							{
-								Api\Json\Response::get()->apply('opener.egw.show_preferences',array(
+								Api\Json\Response::get()->apply('opener.egw.show_preferences', array(
 									'cats',
 									$this->appname == 'admin' ? Categories::GLOBAL_APPNAME : array($refresh_app)
 								));
@@ -199,7 +199,7 @@ 
 							{
 								Categories::css($refresh_app == 'admin' ? Categories::GLOBAL_APPNAME : $refresh_app);
 								// Need to forcably re-load the iframe to avoid smart etemplate refresh
-								Api\Json\Response::get()->apply('opener.app.admin.load',array(
+								Api\Json\Response::get()->apply('opener.app.admin.load', array(
 									Framework::link('/index.php', array(
 										'menuaction' => $this->list_link,
 										'appname' => $appname
@@ -229,10 +229,10 @@ 
 				case 'delete':
 					if (self::$acl_delete)
 					{
-						$cats->delete($content['id'],$delete_subs,!$delete_subs);
+						$cats->delete($content['id'], $delete_subs, !$delete_subs);
 						$msg = lang('Category deleted.');
 
-						Framework::refresh_opener($msg, $refresh_app, $content['id'],'delete', $this->appname);
+						Framework::refresh_opener($msg, $refresh_app, $content['id'], 'delete', $this->appname);
 						Framework::window_close();
 						return;
 					}
@@ -247,19 +247,19 @@ 
 			Framework::refresh_opener($msg, $this->appname, $content['id'], $change_color ? null : 'update', $refresh_app);
 		}
 		$content['msg'] = $msg;
-		if(!$content['appname']) $content['appname'] = $appname;
-		if($content['data']['icon'])
+		if (!$content['appname']) $content['appname'] = $appname;
+		if ($content['data']['icon'])
 		{
-			$content['icon_url'] = $content['base_url'] . $content['data']['icon'];
+			$content['icon_url'] = $content['base_url'].$content['data']['icon'];
 		}
 
 		$sel_options['icon'] = self::get_icons();
 		$sel_options['owner'] = array();
 
 		// User's category - add current value to be able to preserve owner
-		if(!$content['id'])
+		if (!$content['id'])
 		{
-			if($this->appname != 'admin')
+			if ($this->appname != 'admin')
 			{
 				$content['owner'] = $GLOBALS['egw_info']['user']['account_id'];
 			}
@@ -269,24 +269,24 @@ 
 			}
 		}
 
-		if($this->appname != 'admin' && $content['owner'] > 0 )
+		if ($this->appname != 'admin' && $content['owner'] > 0)
 		{
 			$sel_options['owner'][$content['owner']] = Api\Accounts::username($content['owner']);
 		}
 		// Add 'All users', in case owner is readonlys
-		if($content['id'] && $content['owner'] == 0)
+		if ($content['id'] && $content['owner'] == 0)
 		{
 			$sel_options['owner'][0] = lang('All users');
 		}
-		if($this->appname == 'admin' || ($content['id'] && !((int)$content['owner'] > 0)))
+		if ($this->appname == 'admin' || ($content['id'] && !((int)$content['owner'] > 0)))
 		{
-			if($content['owner'] > 0)
+			if ($content['owner'] > 0)
 			{
 				$content['msg'] .= "\n".lang('owner "%1" removed, please select group-owner', Api\Accounts::username($content['owner']));
 				$content['owner'] = 0;
 			}
 			$sel_options['owner'][0] = lang('All users');
-			foreach($GLOBALS['egw']->accounts->search(array('type' => 'groups')) as $acc)
+			foreach ($GLOBALS['egw']->accounts->search(array('type' => 'groups')) as $acc)
 			{
 				if ($acc['account_type'] == 'g')
 				{
@@ -296,7 +296,7 @@ 
 			$content['no_private'] = true;
 		}
 
-		if($this->appname == 'admin')
+		if ($this->appname == 'admin')
 		{
 			$content['access'] = 'public';
 			// Allow admins access to all categories as parent
@@ -307,17 +307,17 @@ 
 			$readonlys['access'] = $content['owner'] != $GLOBALS['egw_info']['user']['account_id'];
 		}
 
-		Framework::includeJS('.','global_categories','admin');
+		Framework::includeJS('.', 'global_categories', 'admin');
 
-		$readonlys['button[delete]'] = !$content['id'] || !self::$acl_delete ||		// cant delete not yet saved category
+		$readonlys['button[delete]'] = !$content['id'] || !self::$acl_delete || // cant delete not yet saved category
 			$appname != $content['appname'] || // Can't edit a category from a different app
 			 ($this->appname != 'admin' && $content['owner'] != $GLOBALS['egw_info']['user']['account_id']);
 		// Make sure $content['owner'] is an array otherwise it wont show up values in the multiselectbox
-		if (!is_array($content['owner'])) $content['owner'] = explode(',',$content['owner']);
+		if (!is_array($content['owner'])) $content['owner'] = explode(',', $content['owner']);
 		$tmpl = new Etemplate('admin.categories.edit');
-		$tmpl->exec($this->edit_link,$content,$sel_options,$readonlys,$content+array(
+		$tmpl->exec($this->edit_link, $content, $sel_options, $readonlys, $content + array(
 			'old_parent' => $content['old_parent'] ? $content['old_parent'] : $content['parent'], 'appname' => $appname
-		),2);
+		), 2);
 	}
 
 	/**
@@ -326,7 +326,7 @@ 
 	 * @param string $icon = '' filename
 	 * @return string url
 	 */
-	static function icon_url($icon='')
+	static function icon_url($icon = '')
 	{
 		return $GLOBALS['egw_info']['server']['webserver_url'].self::ICON_PATH.'/'.$icon;
 	}
@@ -339,12 +339,12 @@ 
 	static function get_icons()
 	{
 		$icons = array();
-		if (file_exists($image_dir=EGW_SERVER_ROOT.self::ICON_PATH) && ($dir = dir($image_dir)))
+		if (file_exists($image_dir = EGW_SERVER_ROOT.self::ICON_PATH) && ($dir = dir($image_dir)))
 		{
 			$matches = null;
-			while(($file = $dir->read()))
+			while (($file = $dir->read()))
 			{
-				if (preg_match('/^(.*)\\.(png|gif|jpe?g)$/i',$file,$matches))
+				if (preg_match('/^(.*)\\.(png|gif|jpe?g)$/i', $file, $matches))
 				{
 					$icons[$file] = ucfirst($matches[1]);
 				}
@@ -363,13 +363,13 @@ 
 	 * @param array &$readonlys eg. to disable buttons based on Acl, not use here, maybe in a derived class
 	 * @return int total number of rows
 	 */
-	public function get_rows(&$query,&$rows,&$readonlys)
+	public function get_rows(&$query, &$rows, &$readonlys)
 	{
 		self::init_static();
 
 		$filter = array();
 		$globalcat = ($query['filter'] === Categories::GLOBAL_ACCOUNT || !$query['filter']);
-		if (isset($query['global_cats']) && $query['global_cats']===false)
+		if (isset($query['global_cats']) && $query['global_cats'] === false)
 		{
 			$globalcat = false;
 		}
@@ -377,49 +377,49 @@ 
 		// new column-filter access has highest priority
 		if (!empty($query['col_filter']['access']))$filter['access'] = $query['col_filter']['access'];
 
-		Api\Cache::setSession(__CLASS__.$query['appname'],'nm',$query);
+		Api\Cache::setSession(__CLASS__.$query['appname'], 'nm', $query);
 
-		if($query['filter'] > 0 || $query['col_filter']['owner'])
+		if ($query['filter'] > 0 || $query['col_filter']['owner'])
 		{
 			$owner = $query['col_filter']['owner'] ? $query['col_filter']['owner'] : $query['filter'];
 		}
-		if($query['col_filter']['app'])
+		if ($query['col_filter']['app'])
 		{
 			$filter['appname'] = $query['col_filter']['app'];
 		}
-		$GLOBALS['egw']->categories = $cats = new Categories($filter['owner'],$query['appname']);
-		$globals = isset($GLOBALS['egw_info']['user']['apps']['admin']) ? 'all_no_acl' : $globalcat;	// ignore Acl only for admins
+		$GLOBALS['egw']->categories = $cats = new Categories($filter['owner'], $query['appname']);
+		$globals = isset($GLOBALS['egw_info']['user']['apps']['admin']) ? 'all_no_acl' : $globalcat; // ignore Acl only for admins
 		$parent = $query['search'] ? false : 0;
-		$rows = $cats->return_sorted_array($query['start'],false,$query['search'],$query['sort'],$query['order'],$globals,$parent,true,$filter);
+		$rows = $cats->return_sorted_array($query['start'], false, $query['search'], $query['sort'], $query['order'], $globals, $parent, true, $filter);
 		$count = $cats->total_records;
-		foreach($rows as $key => &$row)
+		foreach ($rows as $key => &$row)
 		{
-			$row['owner'] = explode(',',$row['owner']);
-			if(($owner && !in_array($owner, $row['owner'])) || ((string)$query['filter'] === (string)Api\Categories::GLOBAL_ACCOUNT && $row['owner'][0] > 0))
+			$row['owner'] = explode(',', $row['owner']);
+			if (($owner && !in_array($owner, $row['owner'])) || ((string)$query['filter'] === (string)Api\Categories::GLOBAL_ACCOUNT && $row['owner'][0] > 0))
 			{
 				unset($rows[$key]);
 				$count--;
 				continue;
 			}
 
-			$row['level_spacer'] = str_repeat('    ',$row['level']);
+			$row['level_spacer'] = str_repeat('    ', $row['level']);
 
 			if ($row['data']['icon']) $row['icon_url'] = self::icon_url($row['data']['icon']);
 
 			$row['subs'] = count($row['children']);
 
 			$row['class'] = 'level'.$row['level'];
-			if($row['owner'][0] > 0 && !$GLOBALS['egw_info']['user']['apps']['admin'] && $row['owner'][0] != $GLOBALS['egw_info']['user']['account_id'])
+			if ($row['owner'][0] > 0 && !$GLOBALS['egw_info']['user']['apps']['admin'] && $row['owner'][0] != $GLOBALS['egw_info']['user']['account_id'])
 			{
 				$row['class'] .= ' rowNoEdit rowNoDelete ';
 			}
 			else if (!$GLOBALS['egw_info']['user']['apps']['admin'])
 			{
-				if(!$cats->check_perms(Acl::EDIT, $row['id']) || !self::$acl_edit)
+				if (!$cats->check_perms(Acl::EDIT, $row['id']) || !self::$acl_edit)
 				{
 					$row['class'] .= ' rowNoEdit';
 				}
-				if(!$cats->check_perms(Acl::DELETE, $row['id']) || !self::$acl_delete ||
+				if (!$cats->check_perms(Acl::DELETE, $row['id']) || !self::$acl_delete ||
 					// Only admins can delete globals
 					$cats->is_global($row['id']) && !$GLOBALS['egw_info']['user']['apps']['admin'])
 				{
@@ -427,7 +427,7 @@ 
 				}
 			}
 			// Can only edit (via context menu) Categories for the selected app (backend restriction)
-			if($row['appname'] != $query['appname'] || (array_sum($row['owner']) > 0))
+			if ($row['appname'] != $query['appname'] || (array_sum($row['owner']) > 0))
 			{
 				$row['class'] .= ' rowNoEdit ';
 			}
@@ -455,60 +455,60 @@ 
 	 * @param array $content = null
 	 * @param string $msg = ''
 	 */
-	public function index(array $content=null,$msg='')
+	public function index(array $content = null, $msg = '')
 	{
 		//_debug_array($_GET);
-		if ($this->appname != 'admin') Api\Translation::add_app('admin');	// need admin translations
+		if ($this->appname != 'admin') Api\Translation::add_app('admin'); // need admin translations
 
-		if(!isset($content))
+		if (!isset($content))
 		{
 			if (isset($_GET['msg'])) $msg = $_GET['msg'];
 
 			$appname = Categories::GLOBAL_APPNAME;
-			foreach(array($content['nm']['appname'], $_GET['cats_app'], $_GET['appname']) as $field)
+			foreach (array($content['nm']['appname'], $_GET['cats_app'], $_GET['appname']) as $field)
 			{
-				if($field)
+				if ($field)
 				{
 					$appname = $field;
 					break;
 				}
 			}
-			$content['nm'] = Api\Cache::getSession(__CLASS__.$appname,'nm');
+			$content['nm'] = Api\Cache::getSession(__CLASS__.$appname, 'nm');
 			if (!is_array($content['nm']))
 			{
 				$content['nm'] = array(
-					'get_rows'       =>	$this->get_rows,	// I  method/callback to request the data for the rows eg. 'notes.bo.get_rows'
+					'get_rows'       =>	$this->get_rows, // I  method/callback to request the data for the rows eg. 'notes.bo.get_rows'
 					'options-filter' => array(
 						'' => lang('All categories'),
 						Categories::GLOBAL_ACCOUNT => lang('Global categories'),
 						$GLOBALS['egw_info']['user']['account_id'] => lang('Own categories'),
 					),
-					'no_filter2'     => True,	// I  disable the 2. filter (params are the same as for filter)
-					'no_cat'         => True,	// I  disable the cat-selectbox
-					'header_left'    =>	false,	// I  template to show left of the range-value, left-aligned (optional)
-					'header_right'   =>	false,	// I  template to show right of the range-value, right-aligned (optional)
-					'never_hide'     => True,	// I  never hide the nextmatch-line if less then maxmatch entries
-					'lettersearch'   => false,	// I  show a lettersearch
-					'start'          =>	0,		// IO position in list
-					'order'          =>	'name',	// IO name of the column to sort after (optional for the sortheaders)
-					'sort'           =>	'ASC',	// IO direction of the sort: 'ASC' or 'DESC'
-					'default_cols'   => '!color,last_mod,subs,legacy_actions',	// I  columns to use if there's no user or default pref (! as first char uses all but the named columns), default all columns
-					'csv_fields'     =>	false,	// I  false=disable csv export, true or unset=enable it with auto-detected fieldnames,
+					'no_filter2'     => True, // I  disable the 2. filter (params are the same as for filter)
+					'no_cat'         => True, // I  disable the cat-selectbox
+					'header_left'    =>	false, // I  template to show left of the range-value, left-aligned (optional)
+					'header_right'   =>	false, // I  template to show right of the range-value, right-aligned (optional)
+					'never_hide'     => True, // I  never hide the nextmatch-line if less then maxmatch entries
+					'lettersearch'   => false, // I  show a lettersearch
+					'start'          =>	0, // IO position in list
+					'order'          =>	'name', // IO name of the column to sort after (optional for the sortheaders)
+					'sort'           =>	'ASC', // IO direction of the sort: 'ASC' or 'DESC'
+					'default_cols'   => '!color,last_mod,subs,legacy_actions', // I  columns to use if there's no user or default pref (! as first char uses all but the named columns), default all columns
+					'csv_fields'     =>	false, // I  false=disable csv export, true or unset=enable it with auto-detected fieldnames,
 									//or array with name=>label or name=>array('label'=>label,'type'=>type) pairs (type is a eT widget-type)
 					'no_search'      => !self::$acl_search,
 					'row_id'         => 'id',
 					'dataStorePrefix' => 'categories' // Avoid conflict with user list when in admin
 				);
-				$content['nm']['filter'] = $this->appname == 'admin'?Api\Categories::GLOBAL_ACCOUNT:$GLOBALS['egw_info']['user']['account_id'];
+				$content['nm']['filter'] = $this->appname == 'admin' ? Api\Categories::GLOBAL_ACCOUNT : $GLOBALS['egw_info']['user']['account_id'];
 			}
 			else
 			{
-				$content['nm']['start']=0;
+				$content['nm']['start'] = 0;
 			}
 			$content['nm']['appname'] = $appname = $_GET['appname'] ? $_GET['appname'] : $appname;
 			$content['nm']['actions'] = $this->get_actions($appname);
 			// switch filter off for super-global categories
-			if($appname == 'phpgw')
+			if ($appname == 'phpgw')
 			{
 				$content['nm']['no_filter'] = true;
 				// Make sure filter is set properly, could be different if user was looking at something else
@@ -516,18 +516,18 @@ 
 			}
 
 			$content['nm']['global_cats'] = true;
-			if (isset($_GET['global_cats']) && empty($_GET['global_cats'] ))
+			if (isset($_GET['global_cats']) && empty($_GET['global_cats']))
 			{
 				$content['nm']['global_cats'] = false;
 			}
 		}
-		elseif($content['nm']['action'])
+		elseif ($content['nm']['action'])
 		{
 			$appname = $content['nm']['appname'];
 			// Old buttons
-			foreach(array('delete') as $button)
+			foreach (array('delete') as $button)
 			{
-				if(isset($content['nm']['rows'][$button]))
+				if (isset($content['nm']['rows'][$button]))
 				{
 					list($id) = @each($content['nm']['rows'][$button]);
 					$content['nm']['action'] = $button;
@@ -542,39 +542,39 @@ 
 			else
 			{
 				// Action has an additional action - add / delete, etc.  Buttons named <multi-action>_action[action_name]
-				if(in_array($content['nm']['action'], array('owner')))
+				if (in_array($content['nm']['action'], array('owner')))
 				{
 					$action = $content['nm']['action'];
 					if ($content[$action.'_popup'])
 					{
-						$content = array_merge($content,$content[$action.'_popup']);
+						$content = array_merge($content, $content[$action.'_popup']);
 					}
-					$content['nm']['action'] .= '_' . key($content[$action . '_action']);
+					$content['nm']['action'] .= '_'.key($content[$action.'_action']);
 
-					if(is_array($content[$action]))
+					if (is_array($content[$action]))
 					{
-						$content[$action] = implode(',',$content[$action]);
+						$content[$action] = implode(',', $content[$action]);
 					}
-					$content['nm']['action'] .= '_' . $content[$action];
+					$content['nm']['action'] .= '_'.$content[$action];
 				}
 				$success = $failed = 0;
 				$action_msg = null;
-				if ($this->action($content['nm']['action'],$content['nm']['selected'],$content['nm']['select_all'],
-					$success,$failed,$action_msg,$content['nm']))
+				if ($this->action($content['nm']['action'], $content['nm']['selected'], $content['nm']['select_all'],
+					$success, $failed, $action_msg, $content['nm']))
 				{
-					$msg .= lang('%1 category(s) %2',$success,$action_msg);
+					$msg .= lang('%1 category(s) %2', $success, $action_msg);
 				}
-				elseif(empty($msg))
+				elseif (empty($msg))
 				{
-					$msg .= lang('%1 category(s) %2, %3 failed because of insufficent rights !!!',$success,$action_msg,$failed);
+					$msg .= lang('%1 category(s) %2, %3 failed because of insufficent rights !!!', $success, $action_msg, $failed);
 				}
 				Framework::refresh_opener($msg, $this->appname);
 				$msg = '';
 			}
 		}
 		$content['msg'] = $msg;
-		$content['nm']['add_link']= Framework::link('/index.php','menuaction='.$this->add_link . '&cat_id=&appname='.$appname);
-		$content['edit_link']= $this->edit_link.'&appname='.$appname;
+		$content['nm']['add_link'] = Framework::link('/index.php', 'menuaction='.$this->add_link.'&cat_id=&appname='.$appname);
+		$content['edit_link'] = $this->edit_link.'&appname='.$appname;
 		$content['owner'] = '';
 
 		$sel_options['appname'] = $this->get_app_list();
@@ -588,7 +588,7 @@ 
 		);
 
 		$sel_options['owner'][0] = lang('All users');
-		foreach($GLOBALS['egw']->accounts->search(array('type' => 'groups')) as $acc)
+		foreach ($GLOBALS['egw']->accounts->search(array('type' => 'groups')) as $acc)
 		{
 			if ($acc['account_type'] == 'g')
 			{
@@ -597,12 +597,12 @@ 
 		}
 
 		$readonlys['add'] = !self::$acl_add;
-		if(!$GLOBALS['egw_info']['user']['apps']['admin'])
+		if (!$GLOBALS['egw_info']['user']['apps']['admin'])
 		{
 			$readonlys['nm']['rows']['owner'] = true;
 			$readonlys['nm']['col_filter']['owner'] = true;
 		}
-		if($appname == Categories::GLOBAL_APPNAME) {
+		if ($appname == Categories::GLOBAL_APPNAME) {
 			$sel_options['app'] = array(''=>'');
 			$readonlys['nm']['rows']['app'] = true;
 		}
@@ -615,12 +615,12 @@ 
 		// Category styles
 		Categories::css($appname);
 
-		$tmpl->exec($this->list_link,$content,$sel_options,$readonlys,array(
+		$tmpl->exec($this->list_link, $content, $sel_options, $readonlys, array(
 			'nm' => $content['nm'],
 		));
 	}
 
-	protected function get_actions($appname=Api\Categories::GLOBAL_APPNAME) {
+	protected function get_actions($appname = Api\Categories::GLOBAL_APPNAME) {
 
 		$actions = array(
 			'open' => array(        // does edit if allowed, otherwise view
@@ -629,7 +629,7 @@ 
 				'allowOnMultiple' => false,
 				'url' => 'menuaction='.$this->edit_link.'&cat_id=$id&appname='.$appname,
 				'popup' => '600x380',
-				'group' => $group=1,
+				'group' => $group = 1,
 			),
 			'add' => array(
 				'caption' => 'Add',
@@ -664,7 +664,7 @@ 
 			),
 		);
 
-		if(!$GLOBALS['egw_info']['user']['apps']['admin'])
+		if (!$GLOBALS['egw_info']['user']['apps']['admin'])
 		{
 			unset($actions['owner']);
 		}
@@ -690,14 +690,14 @@ 
 		$success = $failed = 0;
 		if ($use_all)
 		{
-			@set_time_limit(0);                     // switch off the execution time limit, as it's for big selections to small
-			$query['num_rows'] = -1;        // all
+			@set_time_limit(0); // switch off the execution time limit, as it's for big selections to small
+			$query['num_rows'] = -1; // all
 			$result = $readonlys = array();
-			$this->get_rows($query,$result,$readonlys);
+			$this->get_rows($query, $result, $readonlys);
 			$checked = array();
-			foreach($result as $key => $info)
+			foreach ($result as $key => $info)
 			{
-				if(is_numeric($key))
+				if (is_numeric($key))
 				{
 					$checked[] = $info['id'];
 				}
@@ -705,19 +705,19 @@ 
 		}
 		$owner = $query['col_filter']['owner'] ? $query['col_filter']['owner'] : $query['filter'];
 		$app = $query['col_filter']['app'] ? $query['col_filter']['app'] : $query['appname'];
-		$cats = new Categories($owner,$app);
+		$cats = new Categories($owner, $app);
 
 		list($action, $settings) = explode('_', $_action, 2);
 
-		switch($action)
+		switch ($action)
 		{
 			case 'delete':
 				$action_msg = lang('deleted');
-				foreach($checked as $id)
+				foreach ($checked as $id)
 				{
-					if($cats->check_perms(Acl::DELETE, $id, (boolean)$GLOBALS['egw_info']['user']['apps']['admin']))
+					if ($cats->check_perms(Acl::DELETE, $id, (boolean)$GLOBALS['egw_info']['user']['apps']['admin']))
 					{
-						$cats->delete($id,$settings == 'sub',$settings != 'sub');
+						$cats->delete($id, $settings == 'sub', $settings != 'sub');
 						$success++;
 					}
 					else
@@ -731,20 +731,19 @@ 
 				list($add_remove, $ids_csv) = explode('_', $settings, 2);
 				$ids = explode(',', $ids_csv);
 				// Adding 'All users' removes all the others
-				if($add_remove == 'add' && array_search(Categories::GLOBAL_ACCOUNT,$ids) !== false) $ids = array(Categories::GLOBAL_ACCOUNT);
+				if ($add_remove == 'add' && array_search(Categories::GLOBAL_ACCOUNT, $ids) !== false) $ids = array(Categories::GLOBAL_ACCOUNT);
 
-				foreach($checked as $id)
+				foreach ($checked as $id)
 				{
 					if (!$data = $cats->read($id)) continue;
-					$data['owner'] = explode(',',$data['owner']);
-					if(array_search(Categories::GLOBAL_ACCOUNT,$data['owner']) !== false || $data['owner'][0] > 0)
+					$data['owner'] = explode(',', $data['owner']);
+					if (array_search(Categories::GLOBAL_ACCOUNT, $data['owner']) !== false || $data['owner'][0] > 0)
 					{
 						$data['owner'] = array();
 					}
 					$data['owner'] = $add_remove == 'add' ?
-						$ids == array(Categories::GLOBAL_ACCOUNT) ? $ids : array_merge($data['owner'],$ids) :
-						array_diff($data['owner'],$ids);
-					$data['owner'] = implode(',',array_unique($data['owner']));
+						$ids == array(Categories::GLOBAL_ACCOUNT) ? $ids : array_merge($data['owner'], $ids) : array_diff($data['owner'], $ids);
+					$data['owner'] = implode(',', array_unique($data['owner']));
 
 					if ($cats->edit($data))
 					{
@@ -775,7 +774,7 @@ 
 				continue;
 			}
 			// Skip apps that don't show in the app bar, they [usually] don't have Categories
-			if($data['status'] > 1 || in_array($app, array('home','admin','felamimail','sitemgr','sitemgr-link'))) continue;
+			if ($data['status'] > 1 || in_array($app, array('home', 'admin', 'felamimail', 'sitemgr', 'sitemgr-link'))) continue;
 			if ($GLOBALS['egw_info']['user']['apps'][$app])
 			{
 				$apps[$app] = $data['title'] ? $data['title'] : lang($app);

Braces +64 added lines, -17 removed lines

@@ -150,8 +150,14 @@ 
 			{
 				case 'save':
 				case 'apply':
-					if(is_array($content['owner'])) $content['owner'] = implode(',',$content['owner']);
-					if($content['owner'] == '') $content['owner'] = 0;
+					if(is_array($content['owner']))
+					{
+						$content['owner'] = implode(',',$content['owner']);
+					}
+					if($content['owner'] == '')
+					{
+						$content['owner'] = 0;
+					}
 					if ($content['id'] && self::$acl_edit)
 					{
 
@@ -247,7 +253,10 @@ 
 			Framework::refresh_opener($msg, $this->appname, $content['id'], $change_color ? null : 'update', $refresh_app);
 		}
 		$content['msg'] = $msg;
-		if(!$content['appname']) $content['appname'] = $appname;
+		if(!$content['appname'])
+		{
+			$content['appname'] = $appname;
+		}
 		if($content['data']['icon'])
 		{
 			$content['icon_url'] = $content['base_url'] . $content['data']['icon'];
@@ -302,7 +311,9 @@ 
 			// Allow admins access to all categories as parent
 			$content['all_cats'] = 'all_no_acl';
 			$readonlys['owner'] = false;
-		} else {
+		}
+		else
+		{
 			$readonlys['owner'] = true;
 			$readonlys['access'] = $content['owner'] != $GLOBALS['egw_info']['user']['account_id'];
 		}
@@ -313,7 +324,10 @@ 
 			$appname != $content['appname'] || // Can't edit a category from a different app
 			 ($this->appname != 'admin' && $content['owner'] != $GLOBALS['egw_info']['user']['account_id']);
 		// Make sure $content['owner'] is an array otherwise it wont show up values in the multiselectbox
-		if (!is_array($content['owner'])) $content['owner'] = explode(',',$content['owner']);
+		if (!is_array($content['owner']))
+		{
+			$content['owner'] = explode(',',$content['owner']);
+		}
 		$tmpl = new Etemplate('admin.categories.edit');
 		$tmpl->exec($this->edit_link,$content,$sel_options,$readonlys,$content+array(
 			'old_parent' => $content['old_parent'] ? $content['old_parent'] : $content['parent'], 'appname' => $appname
@@ -373,9 +387,15 @@ 
 		{
 			$globalcat = false;
 		}
-		if ($globalcat && $query['filter']) $filter['access'] = 'public';
+		if ($globalcat && $query['filter'])
+		{
+			$filter['access'] = 'public';
+		}
 		// new column-filter access has highest priority
-		if (!empty($query['col_filter']['access']))$filter['access'] = $query['col_filter']['access'];
+		if (!empty($query['col_filter']['access']))
+		{
+			$filter['access'] = $query['col_filter']['access'];
+		}
 
 		Api\Cache::setSession(__CLASS__.$query['appname'],'nm',$query);
 
@@ -404,7 +424,10 @@ 
 
 			$row['level_spacer'] = str_repeat('    ',$row['level']);
 
-			if ($row['data']['icon']) $row['icon_url'] = self::icon_url($row['data']['icon']);
+			if ($row['data']['icon'])
+			{
+				$row['icon_url'] = self::icon_url($row['data']['icon']);
+			}
 
 			$row['subs'] = count($row['children']);
 
@@ -435,13 +458,19 @@ 
 			$readonlys['nm']["add[$row[id]]"]    = !self::$acl_add_sub;
 			$readonlys['nm']["delete[$row[id]]"] = !self::$acl_delete;
 		}
-		if (true) $rows = $count <= $query['num_rows'] ? array_values($rows) : array_slice($rows, $query['start'], $query['num_rows']);
+		if (true)
+		{
+			$rows = $count <= $query['num_rows'] ? array_values($rows) : array_slice($rows, $query['start'], $query['num_rows']);
+		}
 		// make appname available for actions
 		$rows['appname'] = $query['appname'];
 		$rows['edit_link'] = $this->edit_link;
 
 		// disable access column for global Categories
-		if ($GLOBALS['egw_info']['flags']['currentapp'] == 'admin') $rows['no_access'] = true;
+		if ($GLOBALS['egw_info']['flags']['currentapp'] == 'admin')
+		{
+			$rows['no_access'] = true;
+		}
 
 		$GLOBALS['egw_info']['flags']['app_header'] = lang($this->appname).' - '.lang('categories').
 			($query['appname'] != Categories::GLOBAL_APPNAME ? ': '.lang($query['appname']) : '');
@@ -458,11 +487,18 @@ 
 	public function index(array $content=null,$msg='')
 	{
 		//_debug_array($_GET);
-		if ($this->appname != 'admin') Api\Translation::add_app('admin');	// need admin translations
+		if ($this->appname != 'admin')
+		{
+			Api\Translation::add_app('admin');
+		}
+		// need admin translations
 
 		if(!isset($content))
 		{
-			if (isset($_GET['msg'])) $msg = $_GET['msg'];
+			if (isset($_GET['msg']))
+			{
+				$msg = $_GET['msg'];
+			}
 
 			$appname = Categories::GLOBAL_APPNAME;
 			foreach(array($content['nm']['appname'], $_GET['cats_app'], $_GET['appname']) as $field)
@@ -602,7 +638,8 @@ 
 			$readonlys['nm']['rows']['owner'] = true;
 			$readonlys['nm']['col_filter']['owner'] = true;
 		}
-		if($appname == Categories::GLOBAL_APPNAME) {
+		if($appname == Categories::GLOBAL_APPNAME)
+		{
 			$sel_options['app'] = array(''=>'');
 			$readonlys['nm']['rows']['app'] = true;
 		}
@@ -620,7 +657,8 @@ 
 		));
 	}
 
-	protected function get_actions($appname=Api\Categories::GLOBAL_APPNAME) {
+	protected function get_actions($appname=Api\Categories::GLOBAL_APPNAME)
+	{
 
 		$actions = array(
 			'open' => array(        // does edit if allowed, otherwise view
@@ -731,11 +769,17 @@ 
 				list($add_remove, $ids_csv) = explode('_', $settings, 2);
 				$ids = explode(',', $ids_csv);
 				// Adding 'All users' removes all the others
-				if($add_remove == 'add' && array_search(Categories::GLOBAL_ACCOUNT,$ids) !== false) $ids = array(Categories::GLOBAL_ACCOUNT);
+				if($add_remove == 'add' && array_search(Categories::GLOBAL_ACCOUNT,$ids) !== false)
+				{
+					$ids = array(Categories::GLOBAL_ACCOUNT);
+				}
 
 				foreach($checked as $id)
 				{
-					if (!$data = $cats->read($id)) continue;
+					if (!$data = $cats->read($id))
+					{
+						continue;
+					}
 					$data['owner'] = explode(',',$data['owner']);
 					if(array_search(Categories::GLOBAL_ACCOUNT,$data['owner']) !== false || $data['owner'][0] > 0)
 					{
@@ -775,7 +819,10 @@ 
 				continue;
 			}
 			// Skip apps that don't show in the app bar, they [usually] don't have Categories
-			if($data['status'] > 1 || in_array($app, array('home','admin','felamimail','sitemgr','sitemgr-link'))) continue;
+			if($data['status'] > 1 || in_array($app, array('home','admin','felamimail','sitemgr','sitemgr-link')))
+			{
+				continue;
+			}
 			if ($GLOBALS['egw_info']['user']['apps'][$app])
 			{
 				$apps[$app] = $data['title'] ? $data['title'] : lang($app);

admin/inc/class.admin_cmd.inc.php

Doc Comments +5 added lines, -5 removed lines

@@ -443,10 +443,10 @@ 
 	 *
 	 * @static
 	 * @param array|string $criteria array of key and data cols, OR a SQL query (content for WHERE), fully quoted (!)
-	 * @param boolean|string|array $only_keys =true True returns only keys, False returns all cols. or
+	 * @param boolean $only_keys =true True returns only keys, False returns all cols. or
 	 *	comma seperated list or array of columns to return
 	 * @param string $order_by ='' fieldnames + {ASC|DESC} separated by colons ',', can also contain a GROUP BY (if it contains ORDER BY)
-	 * @param string|array $extra_cols ='' string or array of strings to be added to the SELECT, eg. "count(*) as num"
+	 * @param string $extra_cols ='' string or array of strings to be added to the SELECT, eg. "count(*) as num"
 	 * @param string $wildcard ='' appended befor and after each criteria
 	 * @param boolean $empty =false False=empty criteria are ignored in query, True=empty have to be empty in row
 	 * @param string $op ='AND' defaults to 'AND', can be set to 'OR' too, then criteria's are OR'ed together
@@ -696,7 +696,7 @@ 
 	 *
 	 * @param string|boolean|int $value
 	 * @param boolean $default =null
-	 * @return boolean
+	 * @return boolean|null
 	 * @throws Api\Exception\WrongUserinput(lang('Invalid value "%1" use yes or no!',$value),998);
 	 */
 	static function parse_boolean($value,$default=null)
@@ -925,7 +925,7 @@ 
 	 * Read data of a remote instance
 	 *
 	 * @param array|int $keys
-	 * @return array
+	 * @return string
 	 */
 	static function read_remote($keys)
 	{
@@ -1005,7 +1005,7 @@ 
 	 * Check if string is a md5 hash (32 chars of 0-9 or a-f)
 	 *
 	 * @param string $str
-	 * @return boolean
+	 * @return integer
 	 */
 	static function is_md5($str)
 	{

Indentation +5 added lines, -5 removed lines

@@ -239,11 +239,11 @@
 			unset($postdata[$name]);
 		}
 		$opts = array('http' =>
-		    array(
-		        'method'  => 'POST',
-		        'header'  => 'Content-type: application/x-www-form-urlencoded',
-		        'content' => http_build_query($postdata),
-		    )
+			array(
+				'method'  => 'POST',
+				'header'  => 'Content-type: application/x-www-form-urlencoded',
+				'content' => http_build_query($postdata),
+			)
 		);
 		$url = $remote['remote_url'].'/admin/remote.php?domain='.urlencode($remote['remote_domain']).'&secret='.urlencode($secret);
 		//echo "sending command to $url\n"; _debug_array($opts);

Spacing +98 added lines, -98 removed lines

@@ -23,14 +23,14 @@ 
 	const successful = 2;
 	const failed     = 3;
 	const pending    = 4;
-	const queued     = 5;	// command waits to be fetched from remote
+	const queued     = 5; // command waits to be fetched from remote
 
 	/**
 	 * Status which stil need passwords available
 	 *
 	 * @var array
 	 */
-	static $require_pw_stati = array(self::scheduled,self::pending,self::queued);
+	static $require_pw_stati = array(self::scheduled, self::pending, self::queued);
 
 	/**
 	 * The status of the command, one of either scheduled, successful, failed or deleted
@@ -107,7 +107,7 @@ 
 	 * @return string success message
 	 * @throws Exception()
 	 */
-	protected abstract function exec($check_only=false);
+	protected abstract function exec($check_only = false);
 
 	/**
 	 * Return a title / string representation for a given command, eg. to display it
@@ -132,7 +132,7 @@ 
 
 		$this->type = get_class($this);
 
-		foreach($data as $name => $value)
+		foreach ($data as $name => $value)
 		{
 			$this->$name = $name == 'data' && !is_array($value) ? json_php_unserialize($value) : $value;
 		}
@@ -151,13 +151,13 @@ 
 	 * @return mixed return value of the command
 	 * @throws Exceptions on error
 	 */
-	function run($time=null,$set_modifier=true,$skip_checks=false,$dry_run=false)
+	function run($time = null, $set_modifier = true, $skip_checks = false, $dry_run = false)
 	{
 		if (!is_null($time))
 		{
 			$this->scheduled = $time;
 			$this->status = admin_cmd::scheduled;
-			$ret = lang('Command scheduled to run at %1',date('Y-m-d H:i',$time));
+			$ret = lang('Command scheduled to run at %1', date('Y-m-d H:i', $time));
 			// running the checks of the arguments for local commands, if not explicitly requested to not run them
 			if (!$this->remote_id && !$skip_checks)
 			{
@@ -220,21 +220,21 @@ 
 	{
 		if (!($remote = $this->read_remote($this->remote_id)))
 		{
-			throw new Api\Exception\WrongUserinput(lang('Invalid remote id or name "%1"!',$this->remote_id),997);
+			throw new Api\Exception\WrongUserinput(lang('Invalid remote id or name "%1"!', $this->remote_id), 997);
 		}
 		if (!$this->uid)
 		{
-			$this->save();	// to get the uid
+			$this->save(); // to get the uid
 		}
 		$secret = md5($this->uid.$remote['remote_hash']);
 
 		$postdata = $this->as_array();
 		if (is_object($GLOBALS['egw']->translation))
 		{
-			$postdata = Api\Translation::convert($postdata,Api\Translation::charset(),'utf-8');
+			$postdata = Api\Translation::convert($postdata, Api\Translation::charset(), 'utf-8');
 		}
 		// dont send the id's which have no meaning on the remote install
-		foreach(array('id','creator','modifier','requested','remote_id') as $name)
+		foreach (array('id', 'creator', 'modifier', 'requested', 'remote_id') as $name)
 		{
 			unset($postdata[$name]);
 		}
@@ -260,12 +260,12 @@ 
 		}
 		if (is_object($GLOBALS['egw']->translation))
 		{
-			$message = Api\Translation::convert($message,'utf-8');
+			$message = Api\Translation::convert($message, 'utf-8');
 		}
 		$matches = null;
-		if (is_string($message) && preg_match('/^([0-9]+) (.*)$/',$message,$matches))
+		if (is_string($message) && preg_match('/^([0-9]+) (.*)$/', $message, $matches))
 		{
-			throw new Api\Exception($matches[2],(int)$matches[1]);
+			throw new Api\Exception($matches[2], (int)$matches[1]);
 		}
 		return $message;
 	}
@@ -290,7 +290,7 @@ 
 	 * @param boolean $set_modifier =true set the current user as modifier or 0 (= run by the system)
 	 * @return boolean true on success, false otherwise
 	 */
-	function save($set_modifier=true)
+	function save($set_modifier = true)
 	{
 		admin_cmd::_instanciate_sql();
 
@@ -305,13 +305,13 @@ 
 			$this->modifier = $set_modifier ? $GLOBALS['egw_info']['user']['account_id'] : 0;
 			if ($set_modifier) $this->modifier_email = admin_cmd::user_email();
 		}
-		if (version_compare(PHP_VERSION,'5.1.2','>'))
+		if (version_compare(PHP_VERSION, '5.1.2', '>'))
 		{
-			$vars = get_object_vars($this);	// does not work in php5.1.2 due a bug
+			$vars = get_object_vars($this); // does not work in php5.1.2 due a bug
 		}
 		else
 		{
-			foreach(array_keys(get_class_vars(__CLASS__)) as $name)
+			foreach (array_keys(get_class_vars(__CLASS__)) as $name)
 			{
 				$vars[$name] = $this->$name;
 			}
@@ -351,13 +351,13 @@ 
 	 * @param boolean $return_serialized =true true: return json serialized string, false: return array
 	 * @return string|array see $return_serialized
 	 */
-	static function mask_passwords($data, $return_serialized=true)
+	static function mask_passwords($data, $return_serialized = true)
 	{
 		if (!is_array($data))
 		{
 			$data = json_php_unserialize($data);
 		}
-		foreach($data as $key => &$value)
+		foreach ($data as $key => &$value)
 		{
 			if (is_array($value))
 			{
@@ -407,7 +407,7 @@ 
 		}
 		if (!class_exists($class = $data['type']) || $class == 'admin_cmd')
 		{
-			throw new Api\Exception\WrongParameter(lang('Unknown command %1!',$class),0);
+			throw new Api\Exception\WrongParameter(lang('Unknown command %1!', $class), 0);
 		}
 		$cmd = new $class($data);
 
@@ -415,7 +415,7 @@ 
 		{
 			return $cmd;
 		}
-		throw new Api\Exception\WrongParameter(lang('%1 is no command!',$class),0);
+		throw new Api\Exception\WrongParameter(lang('%1 is no command!', $class), 0);
 	}
 
 	/**
@@ -427,7 +427,7 @@ 
 	 * @param array $readonlys
 	 * @return int
 	 */
-	static function get_rows($query,&$rows,$readonlys)
+	static function get_rows($query, &$rows, $readonlys)
 	{
 		admin_cmd::_instanciate_sql();
 
@@ -435,7 +435,7 @@ 
 		{
 			$query['col_filter']['remote_id'] = null;
 		}
-		return admin_cmd::$sql->get_rows($query,$rows,$readonlys);
+		return admin_cmd::$sql->get_rows($query, $rows, $readonlys);
 	}
 
 	/**
@@ -454,11 +454,11 @@ 
 	 * @param array $filter =null if set (!=null) col-data pairs, to be and-ed (!) into the query without wildcards
 	 * @return array
 	 */
-	static function &search($criteria,$only_keys=True,$order_by='',$extra_cols='',$wildcard='',$empty=False,$op='AND',$start=false,$filter=null)
+	static function &search($criteria, $only_keys = True, $order_by = '', $extra_cols = '', $wildcard = '', $empty = False, $op = 'AND', $start = false, $filter = null)
 	{
 		admin_cmd::_instanciate_sql();
 
-		return admin_cmd::$sql->search($criteria,$only_keys,$order_by,$extra_cols,$wildcard,$empty,$op,$start,$filter);
+		return admin_cmd::$sql->search($criteria, $only_keys, $order_by, $extra_cols, $wildcard, $empty, $op, $start, $filter);
 	}
 
 	/**
@@ -470,7 +470,7 @@ 
 	{
 		if (is_null(admin_cmd::$sql))
 		{
-			admin_cmd::$sql = new Api\Storage\Base('admin','egw_admin_queue',null,'cmd_');
+			admin_cmd::$sql = new Api\Storage\Base('admin', 'egw_admin_queue', null, 'cmd_');
 		}
 	}
 
@@ -483,7 +483,7 @@ 
 	{
 		if (is_null(admin_cmd::$remote))
 		{
-			admin_cmd::$remote = new Api\Storage\Base('admin','egw_admin_remote');
+			admin_cmd::$remote = new Api\Storage\Base('admin', 'egw_admin_remote');
 		}
 	}
 
@@ -495,11 +495,11 @@ 
 	 */
 	function __get($property)
 	{
-		if (property_exists('admin_cmd',$property))
+		if (property_exists('admin_cmd', $property))
 		{
-			return $this->$property;	// making all (non static) class vars readonly available
+			return $this->$property; // making all (non static) class vars readonly available
 		}
-		switch($property)
+		switch ($property)
 		{
 			case 'accounts':
 				self::_instanciate_accounts();
@@ -516,9 +516,9 @@ 
 	 */
 	function __isset($property)
 	{
-		if (property_exists('admin_cmd',$property))
+		if (property_exists('admin_cmd', $property))
 		{
-			return isset($this->$property);	// making all (non static) class vars readonly available
+			return isset($this->$property); // making all (non static) class vars readonly available
 		}
 		return isset($this->data[$property]);
 	}
@@ -530,7 +530,7 @@ 
 	 * @param mixed $value
 	 * @return mixed
 	 */
-	function __set($property,$value)
+	function __set($property, $value)
 	{
 		$this->data[$property] = $value;
 	}
@@ -552,19 +552,19 @@ 
 	 */
 	function as_array()
 	{
-		if (version_compare(PHP_VERSION,'5.1.2','>'))
+		if (version_compare(PHP_VERSION, '5.1.2', '>'))
 		{
-			$vars = get_object_vars($this);	// does not work in php5.1.2 due a bug
+			$vars = get_object_vars($this); // does not work in php5.1.2 due a bug
 		}
 		else
 		{
-			foreach(array_keys(get_class_vars(__CLASS__)) as $name)
+			foreach (array_keys(get_class_vars(__CLASS__)) as $name)
 			{
 				$vars[$name] = $this->$name;
 			}
 		}
 		unset($vars['data']);
-		if ($this->data) $vars = array_merge($this->data,$vars);
+		if ($this->data) $vars = array_merge($this->data, $vars);
 
 		return $vars;
 	}
@@ -576,14 +576,14 @@ 
 	 * @param int $extra_deny =null further admin rights to check, eg. 16 = deny edit Api\Accounts
 	 * @throws Api\Exception\NoPermission\Admin
 	 */
-	protected function _check_admin($extra_acl=null,$extra_deny=null)
+	protected function _check_admin($extra_acl = null, $extra_deny = null)
 	{
 		if ($this->creator)
 		{
 			admin_cmd::_instanciate_acl($this->creator);
 			// todo: check only if and with $this->creator
-			if (!admin_cmd::$acl->check('run',1,'admin') &&		// creator is no longer admin
-				$extra_acl && $extra_deny && admin_cmd::$acl->check($extra_acl,$extra_deny,'admin'))	// creator is explicitly forbidden to do something
+			if (!admin_cmd::$acl->check('run', 1, 'admin') && // creator is no longer admin
+				$extra_acl && $extra_deny && admin_cmd::$acl->check($extra_acl, $extra_deny, 'admin'))	// creator is explicitly forbidden to do something
 			{
 				throw new Api\Exception\NoPermission\Admin();
 			}
@@ -599,13 +599,13 @@ 
 	 */
 	static function parse_apps(array $apps)
 	{
-		foreach($apps as $key => $name)
+		foreach ($apps as $key => $name)
 		{
 			if (!isset($GLOBALS['egw_info']['apps'][$name]))
 			{
-				foreach($GLOBALS['egw_info']['apps'] as $app => $data)	// check against title and localised name
+				foreach ($GLOBALS['egw_info']['apps'] as $app => $data)	// check against title and localised name
 				{
-					if (!strcasecmp($name,$data['title']) || !strcasecmp($name,lang($app)))
+					if (!strcasecmp($name, $data['title']) || !strcasecmp($name, lang($app)))
 					{
 						$apps[$key] = $name = $app;
 						break;
@@ -614,7 +614,7 @@ 
 			}
 			if (!isset($GLOBALS['egw_info']['apps'][$name]))
 			{
-				throw new Api\Exception\WrongUserinput(lang("Application '%1' not found (maybe not installed or misspelled)!",$name),8);
+				throw new Api\Exception\WrongUserinput(lang("Application '%1' not found (maybe not installed or misspelled)!", $name), 8);
 			}
 		}
 		return $apps;
@@ -629,20 +629,20 @@ 
 	 * @throws Api\Exception\WrongUserinput(lang("Unknown account: %1 !!!",$account),15);
 	 * @throws Api\Exception\WrongUserinput(lang("Wrong account type: %1 is NO %2 !!!",$account,$allow_only_user?lang('user'):lang('group')),15);
 	 */
-	static function parse_account($account,$allow_only_user=null)
+	static function parse_account($account, $allow_only_user = null)
 	{
 		admin_cmd::_instanciate_accounts();
 
 		if (!($type = admin_cmd::$accounts->exists($account)) ||
-			!is_numeric($id=$account) && !($id = admin_cmd::$accounts->name2id($account)))
+			!is_numeric($id = $account) && !($id = admin_cmd::$accounts->name2id($account)))
 		{
-			throw new Api\Exception\WrongUserinput(lang("Unknown account: %1 !!!",$account),15);
+			throw new Api\Exception\WrongUserinput(lang("Unknown account: %1 !!!", $account), 15);
 		}
 		if (!is_null($allow_only_user) && $allow_only_user !== ($type == 1))
 		{
-			throw new Api\Exception\WrongUserinput(lang("Wrong account type: %1 is NO %2 !!!",$account,$allow_only_user?lang('user'):lang('group')),15);
+			throw new Api\Exception\WrongUserinput(lang("Wrong account type: %1 is NO %2 !!!", $account, $allow_only_user ? lang('user') : lang('group')), 15);
 		}
-		if ($type == 2 && $id > 0) $id = -$id;	// groups use negative id's internally, fix it, if user given the wrong sign
+		if ($type == 2 && $id > 0) $id = -$id; // groups use negative id's internally, fix it, if user given the wrong sign
 
 		return $id;
 	}
@@ -656,14 +656,14 @@ 
 	 * @throws Api\Exception\WrongUserinput(lang("Unknown account: %1 !!!",$account),15);
 	 * @throws Api\Exception\WrongUserinput(lang("Wrong account type: %1 is NO %2 !!!",$account,$allow_only?lang('user'):lang('group')),15);
 	 */
-	static function parse_accounts($accounts,$allow_only_user=null)
+	static function parse_accounts($accounts, $allow_only_user = null)
 	{
 		if (!$accounts) return null;
 
 		$ids = array();
-		foreach(is_array($accounts) ? $accounts : explode(',',$accounts) as $account)
+		foreach (is_array($accounts) ? $accounts : explode(',', $accounts) as $account)
 		{
-			$ids[] = admin_cmd::parse_account($account,$allow_only_user);
+			$ids[] = admin_cmd::parse_account($account, $allow_only_user);
 		}
 		return $ids;
 	}
@@ -681,11 +681,11 @@ 
 		{
 			$datein = $date;
 			// convert german DD.MM.YYYY format into ISO YYYY-MM-DD format
-			$date = preg_replace('/^([0-9]{1,2})\.([0-9]{1,2})\.([0-9]{4})$/','\3-\2-\1',$date);
+			$date = preg_replace('/^([0-9]{1,2})\.([0-9]{1,2})\.([0-9]{4})$/', '\3-\2-\1', $date);
 
-			if (($date = strtotime($date))  === false)
+			if (($date = strtotime($date)) === false)
 			{
-				throw new Api\Exception\WrongUserinput(lang('Invalid formated date "%1"!',$datein),6);
+				throw new Api\Exception\WrongUserinput(lang('Invalid formated date "%1"!', $datein), 6);
 			}
 		}
 		return (int)$date;
@@ -699,7 +699,7 @@ 
 	 * @return boolean
 	 * @throws Api\Exception\WrongUserinput(lang('Invalid value "%1" use yes or no!',$value),998);
 	 */
-	static function parse_boolean($value,$default=null)
+	static function parse_boolean($value, $default = null)
 	{
 		if (is_bool($value) || is_int($value))
 		{
@@ -709,15 +709,15 @@ 
 		{
 			return $default;
 		}
-		if (in_array($value,array('1','yes','true',lang('yes'),lang('true'))))
+		if (in_array($value, array('1', 'yes', 'true', lang('yes'), lang('true'))))
 		{
 			return true;
 		}
-		if (in_array($value,array('0','no','false',lang('no'),lang('false'))))
+		if (in_array($value, array('0', 'no', 'false', lang('no'), lang('false'))))
 		{
 			return false;
 		}
-		throw new Api\Exception\WrongUserinput(lang('Invalid value "%1" use yes or no!',$value),998);
+		throw new Api\Exception\WrongUserinput(lang('Invalid value "%1" use yes or no!', $value), 998);
 	}
 
 	/**
@@ -735,9 +735,9 @@ 
 			'remote_id' => $id_or_name,
 			'remote_name' => $id_or_name,
 			'remote_domain' => $id_or_name,
-		),true,'','','',false,'OR')) || count($remotes) != 1)
+		), true, '', '', '', false, 'OR')) || count($remotes) != 1)
 		{
-			throw new Api\Exception\WrongUserinput(lang('Invalid remote id or name "%1"!',$id_or_name),997);
+			throw new Api\Exception\WrongUserinput(lang('Invalid remote id or name "%1"!', $id_or_name), 997);
 		}
 		return $remotes[0]['remote_id'];
 	}
@@ -754,7 +754,7 @@ 
 		{
 			if (!is_object($GLOBALS['egw']->accounts))
 			{
-				throw new Api\Exception\AssertionFailed(lang('%1 class not instanciated','accounts'),999);
+				throw new Api\Exception\AssertionFailed(lang('%1 class not instanciated', 'accounts'), 999);
 			}
 			admin_cmd::$accounts = $GLOBALS['egw']->accounts;
 		}
@@ -767,13 +767,13 @@ 
 	 * @param int $account =null account_id the class needs to be instanciated for, default need only account-independent methods
 	 * @throws Api\Exception\AssertionFailed(lang('%1 class not instanciated','acl'),999);
 	 */
-	protected function _instanciate_acl($account=null)
+	protected function _instanciate_acl($account = null)
 	{
 		if (!is_object(admin_cmd::$acl) || $account && admin_cmd::$acl->account_id != $account)
 		{
 			if (!is_object($GLOBALS['egw']->acl))
 			{
-				throw new Api\Exception\AssertionFailed(lang('%1 class not instanciated','acl'),999);
+				throw new Api\Exception\AssertionFailed(lang('%1 class not instanciated', 'acl'), 999);
 			}
 			if ($account && $GLOBALS['egw']->acl->account_id != $account)
 			{
@@ -793,20 +793,20 @@ 
 	 * @param $account_id =null account_id, default current user
 	 * @return string
 	 */
-	static function user_email($account_id=null)
+	static function user_email($account_id = null)
 	{
 		if ($account_id)
 		{
 			admin_cmd::_instanciate_accounts();
-			$fullname = admin_cmd::$accounts->id2name($account_id,'account_fullname');
-			$email = admin_cmd::$accounts->id2name($account_id,'account_email');
+			$fullname = admin_cmd::$accounts->id2name($account_id, 'account_fullname');
+			$email = admin_cmd::$accounts->id2name($account_id, 'account_email');
 		}
 		else
 		{
 			$fullname = $GLOBALS['egw_info']['user']['account_fullname'];
 			$email = $GLOBALS['egw_info']['user']['account_email'];
 		}
-		return $fullname . ($email ? ' <'.$email.'>' : '');
+		return $fullname.($email ? ' <'.$email.'>' : '');
 	}
 
 	/**
@@ -830,11 +830,11 @@ 
 		{
 			return false;
 		}
-		if (!($jobs = admin_cmd::search(array(),false,'cmd_scheduled','','',false,'AND',array(0,1),array(
+		if (!($jobs = admin_cmd::search(array(), false, 'cmd_scheduled', '', '', false, 'AND', array(0, 1), array(
 			'cmd_status' => admin_cmd::scheduled,
 		))))
 		{
-			return false;		// no schduled command, no need to setup the job
+			return false; // no schduled command, no need to setup the job
 		}
 		$next = $jobs[0];
 		if (($time = $next['scheduled']) < time())	// should run immediatly
@@ -844,11 +844,11 @@ 
 		$async = new Api\Asyncservice();
 
 		// we cant use this class as callback, as it's abstract and ExecMethod used by the async service instanciated the class!
-		list($app) = explode('_',$class=$next['type']);
+		list($app) = explode('_', $class = $next['type']);
 		$callback = $app.'.'.$class.'.run_queued_jobs';
 
-		$async->cancel_timer(admin_cmd::async_job_id);	// we delete it in case a job already exists
-		return $async->set_timer($time,admin_cmd::async_job_id,$callback,null,$next['creator']);
+		$async->cancel_timer(admin_cmd::async_job_id); // we delete it in case a job already exists
+		return $async->set_timer($time, admin_cmd::async_job_id, $callback, null, $next['creator']);
 	}
 
 	/**
@@ -858,27 +858,27 @@ 
 	 */
 	static function run_queued_jobs()
 	{
-		if (!($jobs = admin_cmd::search(array(),false,'cmd_scheduled','','',false,'AND',false,array(
+		if (!($jobs = admin_cmd::search(array(), false, 'cmd_scheduled', '', '', false, 'AND', false, array(
 			'cmd_status' => admin_cmd::scheduled,
 			'cmd_scheduled <= '.time(),
 		))))
 		{
-			return false;		// no schduled commands, no need to setup the job
+			return false; // no schduled commands, no need to setup the job
 		}
-		admin_cmd::$running_queued_jobs = true;	// stop admin_cmd::run() which calls admin_cmd::save() to install a new job
+		admin_cmd::$running_queued_jobs = true; // stop admin_cmd::run() which calls admin_cmd::save() to install a new job
 
-		foreach($jobs as $job)
+		foreach ($jobs as $job)
 		{
 			try {
 				$cmd = admin_cmd::instanciate($job);
-				$cmd->run(null,false);	// false = dont set current user as modifier, as job is run by the queue/system itself
+				$cmd->run(null, false); // false = dont set current user as modifier, as job is run by the queue/system itself
 			}
 			catch (Exception $e) {	// we need to mark that command as failed, to prevent further execution
 				unset($e);
 				admin_cmd::$sql->init($job);
 				admin_cmd::$sql->save(array(
 					'status' => admin_cmd::failed,
-					'error'  => lang('Unknown command %1!',$job['type']),
+					'error'  => lang('Unknown command %1!', $job['type']),
 					'errno'  => 0,
 					'data'   => self::mask_passwords($job['data']),
 				));
@@ -899,9 +899,9 @@ 
 		admin_cmd::_instanciate_remote();
 
 		$sites = array(lang('local'));
-		if (($remote = admin_cmd::$remote->query_list('remote_name','remote_id')))
+		if (($remote = admin_cmd::$remote->query_list('remote_name', 'remote_id')))
 		{
-			$sites = array_merge($sites,$remote);
+			$sites = array_merge($sites, $remote);
 		}
 		return $sites;
 	}
@@ -914,11 +914,11 @@ 
 	 * @param array &$readonlys
 	 * @return int
 	 */
-	static function get_remotes($query,&$rows,&$readonlys)
+	static function get_remotes($query, &$rows, &$readonlys)
 	{
 		admin_cmd::_instanciate_remote();
 
-		return admin_cmd::$remote->get_rows($query,$rows,$readonlys);
+		return admin_cmd::$remote->get_rows($query, $rows, $readonlys);
 	}
 
 	/**
@@ -946,7 +946,7 @@ 
 
 		if ($data['install_id'] && $data['config_passwd'])	// calculate hash
 		{
-			$data['remote_hash'] = self::remote_hash($data['install_id'],$data['config_passwd']);
+			$data['remote_hash'] = self::remote_hash($data['install_id'], $data['config_passwd']);
 		}
 		elseif (!$data['remote_hash'] && !($data['install_id'] && $data['config_passwd']))
 		{
@@ -958,12 +958,12 @@ 
 		// check if a unique key constrain would be violated by saving the entry
 		if (($num = admin_cmd::$remote->not_unique()))
 		{
-			$col = admin_cmd::$remote->table_def['uc'][$num-1];	// $num is 1 based!
-			throw new egw_exception_db_not_unique(lang('Value for column %1 is not unique!',$this->table_name.'.'.$col),$num);
+			$col = admin_cmd::$remote->table_def['uc'][$num - 1]; // $num is 1 based!
+			throw new egw_exception_db_not_unique(lang('Value for column %1 is not unique!', $this->table_name.'.'.$col), $num);
 		}
 		if (admin_cmd::$remote->save() != 0)
 		{
-			throw new Api\Db\Exception(lang('Error saving to db:').' '.$this->sql->db->Error.' ('.$this->sql->db->Errno.')',$this->sql->db->Errno);
+			throw new Api\Db\Exception(lang('Error saving to db:').' '.$this->sql->db->Error.' ('.$this->sql->db->Errno.')', $this->sql->db->Errno);
 		}
 		return admin_cmd::$remote->data['remote_id'];
 	}
@@ -975,11 +975,11 @@ 
 	 * @param string $config_passwd
 	 * @return string 32char md5 hash
 	 */
-	static function remote_hash($install_id,$config_passwd)
+	static function remote_hash($install_id, $config_passwd)
 	{
 		if (empty($config_passwd) || !self::is_md5($install_id))
 		{
-			throw new Api\Exception\WrongParameter(empty($config_passwd)?'Empty Api\Config password':'install_id no md5 hash');
+			throw new Api\Exception\WrongParameter(empty($config_passwd) ? 'Empty Api\Config password' : 'install_id no md5 hash');
 		}
 		if (!self::is_md5($config_passwd)) $config_passwd = md5($config_passwd);
 
@@ -1009,7 +1009,7 @@ 
 	 */
 	static function is_md5($str)
 	{
-		return preg_match('/^[0-9a-f]{32}$/',$str);
+		return preg_match('/^[0-9a-f]{32}$/', $str);
 	}
 
 	/**
@@ -1026,26 +1026,26 @@ 
 	 * @param string $config_passwd of the current domain
 	 * @throws Api\Exception\NoPermission
 	 */
-	function check_remote_access($secret,$config_passwd)
+	function check_remote_access($secret, $config_passwd)
 	{
 		// as a security measure remote administration need to be enabled under Admin > Site configuration
-		list(,$remote_admin_install_id) = explode('-',$this->uid);
-		$allowed_remote_admin_ids = $GLOBALS['egw_info']['server']['allow_remote_admin'] ? explode(',',$GLOBALS['egw_info']['server']['allow_remote_admin']) : array();
+		list(,$remote_admin_install_id) = explode('-', $this->uid);
+		$allowed_remote_admin_ids = $GLOBALS['egw_info']['server']['allow_remote_admin'] ? explode(',', $GLOBALS['egw_info']['server']['allow_remote_admin']) : array();
 
 		// to authenticate with the installation we use a secret, which is a md5 hash build from the uid
 		// of the command (to not allow to send new commands with an earsdroped secret) and the md5 hash
 		// of the md5 hash of the Api\Config password and the install_id (egw_admin_remote.remote_hash)
-		if (is_null($config_passwd) || is_numeric($this->uid) || !in_array($remote_admin_install_id,$allowed_remote_admin_ids) ||
-			$secret != ($md5=md5($this->uid.$this->remote_hash($GLOBALS['egw_info']['server']['install_id'],$config_passwd))))
+		if (is_null($config_passwd) || is_numeric($this->uid) || !in_array($remote_admin_install_id, $allowed_remote_admin_ids) ||
+			$secret != ($md5 = md5($this->uid.$this->remote_hash($GLOBALS['egw_info']['server']['install_id'], $config_passwd))))
 		{
 			//die("secret='$secret' != '$md5', is_null($config_passwd)=".is_null($config_passwd).", uid=$this->uid, remote_install_id=$remote_admin_install_id, allowed: ".implode(', ',$allowed_remote_admin_ids));
 			unset($md5);
 			$msg = lang('Permission denied!');
-			if (!in_array($remote_admin_install_id,$allowed_remote_admin_ids))
+			if (!in_array($remote_admin_install_id, $allowed_remote_admin_ids))
 			{
 				$msg .= "\n".lang('Remote administration need to be enabled in the remote instance under Admin > Site configuration!');
 			}
-			throw new Api\Exception\NoPermission($msg,0);
+			throw new Api\Exception\NoPermission($msg, 0);
 		}
 	}
 
@@ -1055,7 +1055,7 @@ 
 	 * @param int $len =16
 	 * @return string
 	 */
-	static function randomstring($len=16)
+	static function randomstring($len = 16)
 	{
 		return Api\Auth::randomstring($len);
 	}

Braces +53 added lines, -13 removed lines

@@ -183,7 +183,10 @@ 
 				{
 					$ret = $this->remote_exec($dry_run);
 				}
-				if (is_null($this->status)) $this->status = admin_cmd::successful;
+				if (is_null($this->status))
+				{
+					$this->status = admin_cmd::successful;
+				}
 			}
 			catch (Exception $e) {
 				$this->error = $e->getMessage();
@@ -277,7 +280,10 @@ 
 	 */
 	function delete()
 	{
-		if ($this->status != admin_cmd::scheduled) return false;
+		if ($this->status != admin_cmd::scheduled)
+		{
+			return false;
+		}
 
 		$this->status = admin_cmd::deleted;
 
@@ -303,7 +309,10 @@ 
 		{
 			$this->modified = time();
 			$this->modifier = $set_modifier ? $GLOBALS['egw_info']['user']['account_id'] : 0;
-			if ($set_modifier) $this->modifier_email = admin_cmd::user_email();
+			if ($set_modifier)
+			{
+				$this->modifier_email = admin_cmd::user_email();
+			}
 		}
 		if (version_compare(PHP_VERSION,'5.1.2','>'))
 		{
@@ -411,10 +420,13 @@ 
 		}
 		$cmd = new $class($data);
 
-		if ($cmd instanceof admin_cmd)	// dont allow others classes to be executed that way!
+		if ($cmd instanceof admin_cmd)
+		{
+			// dont allow others classes to be executed that way!
 		{
 			return $cmd;
 		}
+		}
 		throw new Api\Exception\WrongParameter(lang('%1 is no command!',$class),0);
 	}
 
@@ -564,7 +576,10 @@ 
 			}
 		}
 		unset($vars['data']);
-		if ($this->data) $vars = array_merge($this->data,$vars);
+		if ($this->data)
+		{
+			$vars = array_merge($this->data,$vars);
+		}
 
 		return $vars;
 	}
@@ -583,10 +598,13 @@ 
 			admin_cmd::_instanciate_acl($this->creator);
 			// todo: check only if and with $this->creator
 			if (!admin_cmd::$acl->check('run',1,'admin') &&		// creator is no longer admin
-				$extra_acl && $extra_deny && admin_cmd::$acl->check($extra_acl,$extra_deny,'admin'))	// creator is explicitly forbidden to do something
+				$extra_acl && $extra_deny && admin_cmd::$acl->check($extra_acl,$extra_deny,'admin'))
+			{
+				// creator is explicitly forbidden to do something
 			{
 				throw new Api\Exception\NoPermission\Admin();
 			}
+			}
 		}
 	}
 
@@ -603,11 +621,14 @@ 
 		{
 			if (!isset($GLOBALS['egw_info']['apps'][$name]))
 			{
-				foreach($GLOBALS['egw_info']['apps'] as $app => $data)	// check against title and localised name
+				foreach($GLOBALS['egw_info']['apps'] as $app => $data)
+				{
+					// check against title and localised name
 				{
 					if (!strcasecmp($name,$data['title']) || !strcasecmp($name,lang($app)))
 					{
 						$apps[$key] = $name = $app;
+				}
 						break;
 					}
 				}
@@ -642,7 +663,11 @@ 
 		{
 			throw new Api\Exception\WrongUserinput(lang("Wrong account type: %1 is NO %2 !!!",$account,$allow_only_user?lang('user'):lang('group')),15);
 		}
-		if ($type == 2 && $id > 0) $id = -$id;	// groups use negative id's internally, fix it, if user given the wrong sign
+		if ($type == 2 && $id > 0)
+		{
+			$id = -$id;
+		}
+		// groups use negative id's internally, fix it, if user given the wrong sign
 
 		return $id;
 	}
@@ -658,7 +683,10 @@ 
 	 */
 	static function parse_accounts($accounts,$allow_only_user=null)
 	{
-		if (!$accounts) return null;
+		if (!$accounts)
+		{
+			return null;
+		}
 
 		$ids = array();
 		foreach(is_array($accounts) ? $accounts : explode(',',$accounts) as $account)
@@ -677,9 +705,12 @@ 
 	 */
 	static function parse_date($date)
 	{
-		if (!is_numeric($date))	// we allow to input a timestamp
+		if (!is_numeric($date))
+		{
+			// we allow to input a timestamp
 		{
 			$datein = $date;
+		}
 			// convert german DD.MM.YYYY format into ISO YYYY-MM-DD format
 			$date = preg_replace('/^([0-9]{1,2})\.([0-9]{1,2})\.([0-9]{4})$/','\3-\2-\1',$date);
 
@@ -837,10 +868,13 @@ 
 			return false;		// no schduled command, no need to setup the job
 		}
 		$next = $jobs[0];
-		if (($time = $next['scheduled']) < time())	// should run immediatly
+		if (($time = $next['scheduled']) < time())
+		{
+			// should run immediatly
 		{
 			return admin_cmd::run_queued_jobs();
 		}
+		}
 		$async = new Api\Asyncservice();
 
 		// we cant use this class as callback, as it's abstract and ExecMethod used by the async service instanciated the class!
@@ -944,10 +978,13 @@ 
 	{
 		admin_cmd::_instanciate_remote();
 
-		if ($data['install_id'] && $data['config_passwd'])	// calculate hash
+		if ($data['install_id'] && $data['config_passwd'])
+		{
+			// calculate hash
 		{
 			$data['remote_hash'] = self::remote_hash($data['install_id'],$data['config_passwd']);
 		}
+		}
 		elseif (!$data['remote_hash'] && !($data['install_id'] && $data['config_passwd']))
 		{
 			throw new Api\Exception\WrongUserinput(lang('Either Install ID AND Api\Config password needed OR the remote hash!'));
@@ -981,7 +1018,10 @@ 
 		{
 			throw new Api\Exception\WrongParameter(empty($config_passwd)?'Empty Api\Config password':'install_id no md5 hash');
 		}
-		if (!self::is_md5($config_passwd)) $config_passwd = md5($config_passwd);
+		if (!self::is_md5($config_passwd))
+		{
+			$config_passwd = md5($config_passwd);
+		}
 
 		return md5($config_passwd.$install_id);
 	}

admin/inc/class.admin_cmd_account_app.inc.php

Doc Comments +1 added lines, -1 removed lines

@@ -20,7 +20,7 @@
 	/**
 	 * Constructor
 	 *
-	 * @param boolean|array $allow true=give rights, false=remove rights, or array with all 3 params
+	 * @param boolean $allow true=give rights, false=remove rights, or array with all 3 params
 	 * @param string|int $account =null account name or id
 	 * @param array|string $apps =null app-names
 	 */

Spacing +9 added lines, -9 removed lines

@@ -24,7 +24,7 @@ 
 	 * @param string|int $account =null account name or id
 	 * @param array|string $apps =null app-names
 	 */
-	function __construct($allow,$account=null,$apps=null)
+	function __construct($allow, $account = null, $apps = null)
 	{
 		if (!is_array($allow))
 		{
@@ -36,7 +36,7 @@ 
 		}
 		if (isset($allow['apps']) && !is_array($allow['apps']))
 		{
-			$allow['apps'] = explode(',',$allow['apps']);
+			$allow['apps'] = explode(',', $allow['apps']);
 		}
 		admin_cmd::__construct($allow);
 	}
@@ -50,11 +50,11 @@ 
 	 * @throws Api\Exception\WrongUserinput(lang("Unknown account: %1 !!!",$this->account),15);
 	 * @throws Api\Exception\WrongUserinput(lang("Application '%1' not found (maybe not installed or misspelled)!",$name),8);
 	 */
-	protected function exec($check_only=false)
+	protected function exec($check_only = false)
 	{
 		$account_id = admin_cmd::parse_account($this->account);
 		// check creator is still admin and not explicitly forbidden to edit accounts/groups
-		if ($this->creator) $this->_check_admin($account_id > 0 ? 'account_access' : 'group_access',16);
+		if ($this->creator) $this->_check_admin($account_id > 0 ? 'account_access' : 'group_access', 16);
 
 		$apps = admin_cmd::parse_apps($this->apps);
 
@@ -62,15 +62,15 @@ 
 
 		//echo "account=$this->account, account_id=$account_id, apps: ".implode(', ',$apps)."\n";
 		admin_cmd::_instanciate_acl($account_id);
-		foreach($apps as $app)
+		foreach ($apps as $app)
 		{
 			if ($this->allow)
 			{
-				admin_cmd::$acl->add_repository($app,'run',$account_id,1);
+				admin_cmd::$acl->add_repository($app, 'run', $account_id, 1);
 			}
 			else
 			{
-				admin_cmd::$acl->delete_repository($app,'run',$account_id);
+				admin_cmd::$acl->delete_repository($app, 'run', $account_id);
 			}
 		}
 		return lang('Applications run rights updated.');
@@ -83,7 +83,7 @@ 
 	 */
 	function __tostring()
 	{
-		return lang('%1 rights for %2 and applications %3',$this->allow ? lang('Grant') : lang('Remove'),
-			admin_cmd::display_account($this->account),implode(', ',$this->apps));
+		return lang('%1 rights for %2 and applications %3', $this->allow ? lang('Grant') : lang('Remove'),
+			admin_cmd::display_account($this->account), implode(', ', $this->apps));
 	}
 }

Braces +8 added lines, -2 removed lines

@@ -54,11 +54,17 @@
 	{
 		$account_id = admin_cmd::parse_account($this->account);
 		// check creator is still admin and not explicitly forbidden to edit accounts/groups
-		if ($this->creator) $this->_check_admin($account_id > 0 ? 'account_access' : 'group_access',16);
+		if ($this->creator)
+		{
+			$this->_check_admin($account_id > 0 ? 'account_access' : 'group_access',16);
+		}
 
 		$apps = admin_cmd::parse_apps($this->apps);
 
-		if ($check_only) return true;
+		if ($check_only)
+		{
+			return true;
+		}
 
 		//echo "account=$this->account, account_id=$account_id, apps: ".implode(', ',$apps)."\n";
 		admin_cmd::_instanciate_acl($account_id);