Completed
Push — master ( 9d054b...106a1b )
by Klaus
23:45 queued 04:19
created
api/src/Mailer.php 1 patch
Doc Comments   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -251,7 +251,7 @@  discard block
 block discarded – undo
251 251
 	/**
252 252
 	 * Add one or multiple addresses to Cc
253 253
 	 *
254
-	 * @param string|array|Horde_Mail_Rfc822_List $address
254
+	 * @param string $address
255 255
 	 * @param string $personal ='' only used if $address is a string
256 256
 	 */
257 257
 	function addCc($address, $personal=null)
@@ -270,7 +270,7 @@  discard block
 block discarded – undo
270 270
 	/**
271 271
 	 * Add one or multiple addresses to Bcc
272 272
 	 *
273
-	 * @param string|array|Horde_Mail_Rfc822_List $address
273
+	 * @param string $address
274 274
 	 * @param string $personal ='' only used if $address is a string
275 275
 	 */
276 276
 	function addBcc($address, $personal=null)
@@ -381,7 +381,7 @@  discard block
 block discarded – undo
381 381
 	/**
382 382
 	 * Adds an embedded image or other inline attachment
383 383
 	 *
384
-	 * @param string|resource $data Path to the attachment or open file-descriptor
384
+	 * @param string $data Path to the attachment or open file-descriptor
385 385
 	 * @param string $cid Content ID of the attachment.  Use this to identify
386 386
 	 *        the Id for accessing the image in an HTML form.
387 387
 	 * @param string $name Overrides the attachment name.
Please login to merge, or discard this patch.
api/src/Session.php 1 patch
Doc Comments   +3 added lines, -2 removed lines patch added patch discarded remove patch
@@ -311,6 +311,7 @@  discard block
 block discarded – undo
311 311
 	 * Encrypt the variables in the session
312 312
 	 *
313 313
 	 * Is called by self::__destruct().
314
+	 * @param string $kp3
314 315
 	 */
315 316
 	static function encrypt($kp3)
316 317
 	{
@@ -439,7 +440,7 @@  discard block
 block discarded – undo
439 440
 	 * @param boolean $no_session =false dont create a real session, eg. for GroupDAV clients using only basic auth, no cookie support
440 441
 	 * @param boolean $auth_check =true if false, the user is loged in without checking his password (eg. for single sign on), default = true
441 442
 	 * @param boolean $fail_on_forced_password_change =false true: do NOT create session, if password change requested
442
-	 * @return string|boolean session id or false if session was not created, $this->(cd_)reason contains cause
443
+	 * @return false|string session id or false if session was not created, $this->(cd_)reason contains cause
443 444
 	 */
444 445
 	function create($login,$passwd = '',$passwd_type = '',$no_session=false,$auth_check=true,$fail_on_forced_password_change=false)
445 446
 	{
@@ -1021,7 +1022,7 @@  discard block
 block discarded – undo
1021 1022
 	/**
1022 1023
 	 * Terminate a session
1023 1024
 	 *
1024
-	 * @param int|string $sessionid nummeric or php session id of session to be terminated
1025
+	 * @param string $sessionid nummeric or php session id of session to be terminated
1025 1026
 	 * @param string $kp3
1026 1027
 	 * @return boolean true on success, false on error
1027 1028
 	 */
Please login to merge, or discard this patch.
api/src/Storage.php 1 patch
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -366,7 +366,7 @@  discard block
 block discarded – undo
366 366
 	 * @param string $join ='' sql to do a join, added as is after the table-name, eg. ", table2 WHERE x=y" or
367 367
 	 *	"LEFT JOIN table2 ON (x=y)", Note: there's no quoting done on $join!
368 368
 	 * @param boolean $need_full_no_count =false If true an unlimited query is run to determine the total number of rows, default false
369
-	 * @param mixed $only_keys =false, see search
369
+	 * @param boolean $only_keys =false, see search
370 370
 	 * @param string|array $extra_cols =array()
371 371
 	 * @return int total number of rows
372 372
 	 */
@@ -734,7 +734,7 @@  discard block
 block discarded – undo
734 734
 	 * Check if cf is stored as 1:N relation in DB and array in memory
735 735
 	 *
736 736
 	 * @param string $name
737
-	 * @return string
737
+	 * @return boolean
738 738
 	 */
739 739
 	function is_multiple($name)
740 740
 	{
Please login to merge, or discard this patch.
api/src/Storage/Base.php 1 patch
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -704,7 +704,7 @@  discard block
 block discarded – undo
704 704
 	 *
705 705
 	 * @param array $_fields
706 706
 	 * @param boolean $merge =true if true $fields will be merged with $this->data (after update!), otherwise $this->data will be just $fields
707
-	 * @return int|boolean 0 on success, or errno != 0 on error, or true if $extra_where is given and no rows affected
707
+	 * @return integer 0 on success, or errno != 0 on error, or true if $extra_where is given and no rows affected
708 708
 	 */
709 709
 	function update($_fields,$merge=true)
710 710
 	{
@@ -1194,7 +1194,7 @@  discard block
 block discarded – undo
1194 1194
 	 * @param string &$wildcard ='' on return wildcard char to use, if pattern does not already contain wildcards!
1195 1195
 	 * @param string &$op ='AND' on return boolean operation to use, if pattern does not start with ! we use OR else AND
1196 1196
 	 * @param string $extra_col =null extra column to search
1197
-	 * @param array $search_cols =array() List of columns to search.  If not provided, all columns in $this->db_cols will be considered
1197
+	 * @param string[] $search_cols =array() List of columns to search.  If not provided, all columns in $this->db_cols will be considered
1198 1198
 	 * @return array or column => value pairs
1199 1199
 	 */
1200 1200
 	public function search2criteria($_pattern,&$wildcard='',&$op='AND',$extra_col=null, $search_cols = array())
Please login to merge, or discard this patch.
api/src/Storage/Customfields.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -159,7 +159,7 @@
 block discarded – undo
159 159
 	 * @param string $app
160 160
 	 * @param boolean $all_private_too =false should all the private fields be returned too, default no
161 161
 	 * @param string $only_type2 =null if given only return fields of type2 == $only_type2
162
-	 * @return boolen true: if there is a custom field useing html, false if not
162
+	 * @return boolean true: if there is a custom field useing html, false if not
163 163
 	 */
164 164
 	public static function use_html($app, $all_private_too=false, $only_type2=null)
165 165
 	{
Please login to merge, or discard this patch.
api/src/Storage/History.php 1 patch
Doc Comments   +2 added lines patch added patch discarded remove patch
@@ -112,6 +112,8 @@
 block discarded – undo
112 112
 
113 113
 	/**
114 114
 	 * Static function to add a history record
115
+	 * @param string $field_code
116
+	 * @param string $new_value
115 117
 	 */
116 118
 	public static function static_add($appname, $id, $user, $field_code, $new_value, $old_value = '')
117 119
 	{
Please login to merge, or discard this patch.
api/src/Storage/Merge.php 1 patch
Doc Comments   +14 added lines, -7 removed lines patch added patch discarded remove patch
@@ -368,9 +368,9 @@  discard block
 block discarded – undo
368 368
 	 *
369 369
 	 * Calls get_links() repeatedly to get all the combinations for the content.
370 370
 	 *
371
-	 * @param $app String appname
371
+	 * @param string $app String appname
372 372
 	 * @param $id String ID of record
373
-	 * @param $prefix
373
+	 * @param string $prefix
374 374
 	 * @param $content String document content
375 375
 	 */
376 376
 	protected function get_all_links($app, $id, $prefix, &$content)
@@ -530,7 +530,7 @@  discard block
 block discarded – undo
530 530
 	 * @param mixed $app_limit app_limit, if not set checks the global limit
531 531
 	 * @param string $checkas [AND|ISALLOWED], AND default; if set to ISALLOWED it is checked if Export is allowed
532 532
 	 *
533
-	 * @return bool - true if no export is allowed or a limit is set, false if there is no restriction
533
+	 * @return boolean|null - true if no export is allowed or a limit is set, false if there is no restriction
534 534
 	 */
535 535
 	public static function hasExportLimit($app_limit,$checkas='AND')
536 536
 	{
@@ -579,6 +579,9 @@  discard block
 block discarded – undo
579 579
 		return $content;
580 580
 	}
581 581
 
582
+	/**
583
+	 * @param string $mimetype
584
+	 */
582 585
 	protected function apply_styles (&$content, $mimetype, $mso_application_progid=null)
583 586
 	{
584 587
 		if (!isset($mso_application_progid))
@@ -1169,6 +1172,8 @@  discard block
 block discarded – undo
1169 1172
 
1170 1173
 	/**
1171 1174
 	 * Convert numeric values in spreadsheets into actual numeric values
1175
+	 * @param string $content
1176
+	 * @param string $mimetype
1172 1177
 	 */
1173 1178
 	protected function format_spreadsheet_numbers(&$content, $names, $mimetype)
1174 1179
 	{
@@ -1238,6 +1243,7 @@  discard block
 block discarded – undo
1238 1243
 
1239 1244
 	/**
1240 1245
 	 * Convert date / timestamp values in spreadsheets into actual date / timestamp values
1246
+	 * @param string $mimetype
1241 1247
 	 */
1242 1248
 	protected function format_spreadsheet_dates(&$content, $names, &$values, $mimetype)
1243 1249
 	{
@@ -1342,6 +1348,7 @@  discard block
 block discarded – undo
1342 1348
 	/**
1343 1349
 	 * Expand link_to custom fields with the merge replacements from the app
1344 1350
 	 * but only if the template uses them.
1351
+	 * @param string $app
1345 1352
 	 */
1346 1353
 	public function cf_link_to_expand($values, $content, &$replacements, $app = null)
1347 1354
 	{
@@ -1407,7 +1414,7 @@  discard block
 block discarded – undo
1407 1414
 	/**
1408 1415
 	 * Process special flags, such as IF or NELF
1409 1416
 	 *
1410
-	 * @param content Text to be examined and changed
1417
+	 * @param content string to be examined and changed
1411 1418
 	 * @param replacements array of markers => replacement
1412 1419
 	 *
1413 1420
 	 * @return changed content
@@ -1720,8 +1727,7 @@  discard block
 block discarded – undo
1720 1727
 	 * Get a list of document actions / files from the given directory
1721 1728
 	 *
1722 1729
 	 * @param string $dirs Directory(s comma or space separated) to search
1723
-	 * @param string $prefix='document_' prefix for array keys
1724
-	 * @param array|string $mime_filter=null allowed mime type(s), default all, negative filter if $mime_filter[0] === '!'
1730
+	 * @param array|string $mime_filter allowed mime type(s), default all, negative filter if $mime_filter[0] === '!'
1725 1731
 	 * @return array List of documents, suitable for a selectbox.  The key is document_<filename>.
1726 1732
 	 */
1727 1733
 	public static function get_documents($dirs, $prefix='document_', $mime_filter=null, $app='')
@@ -1988,7 +1994,8 @@  discard block
 block discarded – undo
1988 1994
 	 *
1989 1995
 	 * @param string &$document maybe relative path of document, on return true absolute path to existing document
1990 1996
 	 * @param string $dirs comma or whitespace separated directories
1991
-	 * @return string|boolean false if document exists, otherwise string with error-message
1997
+	 * @param string $document
1998
+	 * @return false|string false if document exists, otherwise string with error-message
1992 1999
 	 */
1993 2000
 	public static function check_document(&$document, $dirs)
1994 2001
 	{
Please login to merge, or discard this patch.
api/src/Storage/Tracking.php 1 patch
Doc Comments   +1 added lines, -2 removed lines patch added patch discarded remove patch
@@ -528,7 +528,7 @@  discard block
 block discarded – undo
528 528
 	 * @param array $data current entry
529 529
 	 * @param array $old = null old/last state of the entry or null for a new entry
530 530
 	 * @param boolean $deleted = null can be set to true to let the tracking know the item got deleted or undelted
531
-	 * @param array $email_notified=null if present will return the emails notified, if given emails in that list will not be notified
531
+	 * @param array $email_notified if present will return the emails notified, if given emails in that list will not be notified
532 532
 	 * @return boolean true on success, false on error (error messages are in $this->errors)
533 533
 	 */
534 534
 	public function do_notifications($data,$old,$deleted=null,&$email_notified=null)
@@ -824,7 +824,6 @@  discard block
 block discarded – undo
824 824
 	 * The default implementation prefers depending on the prefer_user_as_sender class-var the user over
825 825
 	 * what is returned by get_config('sender').
826 826
 	 *
827
-	 * @param int $user account_lid of user
828 827
 	 * @param array $data
829 828
 	 * @param array $old
830 829
 	 * @param bool $prefer_id returns the userid rather than email
Please login to merge, or discard this patch.
api/src/Translation.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -742,7 +742,7 @@
 block discarded – undo
742 742
 	 *
743 743
 	 * @param string $app application name
744 744
 	 * @param string $lang language code
745
-	 * @return the full path of the filename for the requested app and language
745
+	 * @return string full path of the filename for the requested app and language
746 746
 	 */
747 747
 	static function get_lang_file($app,$lang)
748 748
 	{
Please login to merge, or discard this patch.