EGroupware / egroupware

preferences/inc/class.preferences_settings.inc.php

Spacing +56 added lines, -57 removed lines

@@ -45,7 +45,7 @@ 
 	 * @param array $content =null
 	 * @param string $msg =''
 	 */
-	function index(array $content=null, $msg='')
+	function index(array $content = null, $msg = '')
 	{
 		$tpl = new Etemplate('preferences.settings');
 		if (!is_array($content))
@@ -70,7 +70,7 @@ 
 			{
 				list($button) = each($content['button']);
 				$appname = $content['old_appname'] ? $content['old_appname'] : 'common';
-				switch($button)
+				switch ($button)
 				{
 					case 'save':
 					case 'apply':
@@ -79,10 +79,10 @@ 
 						{
 							throw new Api\Exception\NoPermission\Admin;
 						}
-						list($type,$account_id) = explode(':', $content['old_type']);
+						list($type, $account_id) = explode(':', $content['old_type']);
 						// merge prefs of all tabs together again
 						$prefs = array();
-						foreach($content as $name => $val)
+						foreach ($content as $name => $val)
 						{
 							if (is_array($val) && strpos($name, 'tab') === 0)
 							{
@@ -100,7 +100,7 @@ 
 						$old_values = array_intersect_key($GLOBALS['egw_info']['user']['preferences']['common'], array_flip($require_reload));
 
 						$attribute = $type == 'group' ? 'user' : $type;
-						if (!($msg=$this->process_array($GLOBALS['egw']->preferences->$attribute, $prefs, $content['types'], $appname, $attribute)))
+						if (!($msg = $this->process_array($GLOBALS['egw']->preferences->$attribute, $prefs, $content['types'], $appname, $attribute)))
 						{
 							$msg_type = 'success';
 							$msg = lang('Preferences saved.');
@@ -124,14 +124,14 @@ 
 						// update client-side Api\Preferences in response
 						Framework::ajax_get_preference($appname);
 				}
-				if (in_array($button, array('save','cancel')))
+				if (in_array($button, array('save', 'cancel')))
 				{
 					Api\Json\Response::get()->call('egw.message', $msg, $msg_type);
 					Framework::window_close();
 				}
 			}
 			$appname = $content['appname'] ? $content['appname'] : 'common';
-			list($type,$account_id) = explode(':', $content['type']);
+			list($type, $account_id) = explode(':', $content['type']);
 			//_debug_array($prefs);
 		}
 		if ($account_id && $account_id != $GLOBALS['egw']->preferences->get_account_id())
@@ -150,7 +150,7 @@ 
 		$preserve['current_app'] = $content['current_app'];
 		$GLOBALS['egw_info']['flags']['currentapp'] = $content['current_app'] == 'common' ?
 			'preferences' : $content['current_app'];
-		Framework::includeCSS('preferences','app');
+		Framework::includeCSS('preferences', 'app');
 
 		// if not just saved, call validation before, to be able to show failed validation of current prefs
 		if (!isset($button))
@@ -182,7 +182,7 @@ 
 	 * @param boolean $only_verify =false
 	 * @return string with verification error or null on success
 	 */
-	function process_array(array &$repository, array $values, array $types, $appname, $type, $only_verify=false)
+	function process_array(array &$repository, array $values, array $types, $appname, $type, $only_verify = false)
 	{
 		//fetch application specific settings from a hook
 		$settings = Api\Hooks::single(array(
@@ -195,10 +195,10 @@ 
 
 		unset($prefs['']);
 		//_debug_array($values);exit;
-		foreach($values as $var => $value)
+		foreach ($values as $var => $value)
 		{
 			// type specific validation
-			switch((string)$types[$var])
+			switch ((string)$types[$var])
 			{
 				case 'password':	// dont write empty password-fields
 					if (empty($value)) continue 2;
@@ -211,7 +211,7 @@ 
 						// empty is always allowed
 
 						// If forced, empty == not set
-						if($type == 'forced')
+						if ($type == 'forced')
 						{
 							unset($prefs[$var]);
 							// need to call preferences::delete, to also set affective prefs!
@@ -223,19 +223,19 @@ 
 					{
 						if ($value[0] != '/' || !Vfs::stat($value) || Vfs::is_dir($value))
 						{
-							$error = lang('%1 is no existing vfs file!',htmlspecialchars($value));
+							$error = lang('%1 is no existing vfs file!', htmlspecialchars($value));
 						}
 					}
 					else
 					{
 						// split multiple comma or whitespace separated directories
 						// to still allow space or comma in dirnames, we also use the trailing slash of all pathes to split
-						foreach($types[$var] == 'vfs_dir' ? array($value) : preg_split('/[,\s]+\//', $value) as $n => $dir)
+						foreach ($types[$var] == 'vfs_dir' ? array($value) : preg_split('/[,\s]+\//', $value) as $n => $dir)
 						{
-							if ($n) $dir = '/'.$dir;	// re-adding trailing slash removed by split
+							if ($n) $dir = '/'.$dir; // re-adding trailing slash removed by split
 							if ($dir[0] != '/' || !Vfs::stat($dir) || !Vfs::is_dir($dir))
 							{
-								$error .= ($error ? ' ' : '').lang('%1 is no existing vfs directory!',$dir);
+								$error .= ($error ? ' ' : '').lang('%1 is no existing vfs directory!', $dir);
 							}
 						}
 					}
@@ -249,7 +249,7 @@ 
 
 			if (isset($value) && $value !== '' && $value !== '**NULL**' && $value !== array())
 			{
-				if (is_array($value) && !$settings[$var]['no_sel_options']) $value = implode(',',$value);	// multiselect
+				if (is_array($value) && !$settings[$var]['no_sel_options']) $value = implode(',', $value); // multiselect
 
 				$prefs[$var] = $value;
 
@@ -269,7 +269,7 @@ 
 		// if you return something else than False, it is treated as an error-msg and
 		// displayed to the user (the prefs are not saved)
 		//
-		if(($error .= Api\Hooks::single(array(
+		if (($error .= Api\Hooks::single(array(
 				'location' => 'verify_settings',
 				'prefs'    => &$repository[$appname],
 				'type'     => $type,
@@ -281,7 +281,7 @@ 
 			return $error;
 		}
 
-		if (!$only_verify) $GLOBALS['egw']->preferences->save_repository(True,$type);
+		if (!$only_verify) $GLOBALS['egw']->preferences->save_repository(True, $type);
 
 		// certain common prefs (language, template, ...) require the session to be re-created
 		if ($appname == 'common' && !$only_verify)
@@ -317,19 +317,19 @@ 
 		$sel_options = $readonlys = $content = $tabs = array();
 		// disable all but first tab and name current tab "tab1", for apps not using sections
 		$tab = 'tab1';
-		foreach($this->settings as $setting)
+		foreach ($this->settings as $setting)
 		{
 			if (!is_array($setting)) continue;
 			if ($type != 'forced' && (string)$GLOBALS['egw']->preferences->forced[$appname][$setting['name']] !== '')
 			{
-				continue;	// forced preferences are not displayed, unless we edit them
+				continue; // forced preferences are not displayed, unless we edit them
 			}
 			$types[$setting['name']] = $old_type = $setting['type'];
 
-			switch($old_type)
+			switch ($old_type)
 			{
 				case 'section':
-					$tab = 'tab'.(1+count($tabs));
+					$tab = 'tab'.(1 + count($tabs));
 					$tabs[] = array(
 						'id' => $tab,
 						'template' => 'preferences.settings.tab1',
@@ -344,24 +344,24 @@ 
 					if (is_array($setting['values'])) $vars += $setting['values'];
 					$GLOBALS['egw']->preferences->{$attribute}[$appname][$setting['name']] =
 						$GLOBALS['egw']->preferences->lang_notify($GLOBALS['egw']->preferences->{$attribute}[$appname][$setting['name']], $vars);
-					$types[$setting['name']] = $vars;	// store vars for re-translation, instead type "notify"
+					$types[$setting['name']] = $vars; // store vars for re-translation, instead type "notify"
 					if ($setting['help'] && ($setting['run_lang'] || !isset($setting['run_lang'])))
 					{
 						$setting['help'] = lang($setting['help']);
 					}
 					$setting['help'] .= '<p><b>'.lang('Substitutions and their meanings:').'</b>';
-					foreach($vars as $var => $var_help)
+					foreach ($vars as $var => $var_help)
 					{
 						$lname = ($lname = lang($var)) == $var.'*' ? $var : $lname;
 						$setting['help'] .= "<br>\n".'<b>$$'.$lname.'$$</b>: '.$var_help;
 					}
 					$setting['help'] .= "</p>\n";
-					$setting['run_lang'] = false;	// already done now
+					$setting['run_lang'] = false; // already done now
 					// handle as textarea
 				case 'textarea':
 					$setting['type'] = is_a($tpl, 'etemplate') ? 'textarea' : 'textbox';
 					$tpl->setElementAttribute($tab.'['.$setting['name'].']', 'multiline', 'true');
-					$tpl->setElementAttribute($tab. '[' . $setting['name'] . ']','width', '99%' );
+					$tpl->setElementAttribute($tab.'['.$setting['name'].']', 'width', '99%');
 					// anyway setting via css: width: 99%, height: 5em
 					// for old eT use size attribute
 					if (is_a($tpl, 'etemplate') && (!empty($setting['cols']) || !empty($setting['rows'])))
@@ -383,7 +383,7 @@ 
 				case 'multiselect':
 					$setting['type'] = 'select';
 					$tpl->setElementAttribute($tab.'['.$setting['name'].']', 'rows', 5);
-					if (!isset($setting['size'])) $setting['size'] = '5';	// old eT
+					if (!isset($setting['size'])) $setting['size'] = '5'; // old eT
 					break;
 				case 'color':
 					$setting['type'] = 'colorpicker';
@@ -391,7 +391,7 @@ 
 				case 'date-duration':
 					if (!isset($setting['size'])) $setting['size'] = 'm,dhm,24,1';
 					$attrs = explode(',', $setting['size']);
-					foreach(array("data_format","display_format", "hours_per_day", "empty_not_0", "short_labels") as $n => $name)
+					foreach (array("data_format", "display_format", "hours_per_day", "empty_not_0", "short_labels") as $n => $name)
 					{
 						if ((string)$attrs[$n] !== '') $tpl->setElementAttribute($tab.'['.$setting['name'].']', $name, $attrs[$n]);
 					}
@@ -399,7 +399,7 @@ 
 				case 'taglist':
 					if ($setting['no_sel_options'])
 					{
-						$tpl->setElementAttribute ($tab.'['.$setting['name'].']', 'autocomplete_url', '');
+						$tpl->setElementAttribute($tab.'['.$setting['name'].']', 'autocomplete_url', '');
 					}
 					break;
 			}
@@ -408,17 +408,17 @@ 
 			{
 				if ($old_type != 'multiselect' && $old_type != 'notify')
 				{
-					switch($type)
+					switch ($type)
 					{
 						case 'user':
-							$setting['values'] = array('' => lang('Use default'))+$setting['values'];
+							$setting['values'] = array('' => lang('Use default')) + $setting['values'];
 							break;
 						case 'default':
 						case 'group':
-							$setting['values'] = array('' => lang('No default'))+$setting['values'];
+							$setting['values'] = array('' => lang('No default')) + $setting['values'];
 							break;
 						case 'forced';
-							$setting['values'] = array('**NULL**' => lang('Users choice'))+$setting['values'];
+							$setting['values'] = array('**NULL**' => lang('Users choice')) + $setting['values'];
 							break;
 					}
 				}
@@ -427,8 +427,7 @@ 
 			if ($type == 'user')
 			{
 				$default = $GLOBALS['egw']->preferences->group[$appname][$setting['name']] ?
-					$GLOBALS['egw']->preferences->group[$appname][$setting['name']] :
-					$GLOBALS['egw']->preferences->default[$appname][$setting['name']];
+					$GLOBALS['egw']->preferences->group[$appname][$setting['name']] : $GLOBALS['egw']->preferences->default[$appname][$setting['name']];
 
 				// replace default value(s) for selectboxes with selectbox labels
 				if (isset($setting['values']) && is_array($setting['values']))
@@ -448,7 +447,7 @@ 
 				'name' => $setting['name'],
 				'type' => $setting['type'],
 				'label' => preg_replace('|<br[ /]*>|i', "\n", $setting['label']),
-				'help' => lang($setting['help']),	// is html
+				'help' => lang($setting['help']), // is html
 				'default' => (string)$default !== '' ? lang('Default').': '.$default : null,
 				'onchange' => $setting['onchange'],
 			);
@@ -473,7 +472,7 @@ 
 
 		$content['appname'] = $appname;
 		$sel_options['appname'] = array();
-		foreach(Api\Hooks::implemented('settings') as $app)
+		foreach (Api\Hooks::implemented('settings') as $app)
 		{
 			if ($app != 'preferences' && $GLOBALS['egw_info']['user']['apps'][$app])
 			{
@@ -499,7 +498,7 @@ 
 				$user_apps = $GLOBALS['egw']->acl->get_user_applications($id);
 				$sel_options['appname'] = array_intersect_key($sel_options['appname'], $user_apps);
 			}
-			foreach($GLOBALS['egw']->accounts->search(array('type' => 'groups', 'order' => 'account_lid')) as $account_id => $group)
+			foreach ($GLOBALS['egw']->accounts->search(array('type' => 'groups', 'order' => 'account_lid')) as $account_id => $group)
 			{
 				$sel_options['type']['group:'.$account_id] = lang('Preferences').' '.Api\Accounts::format_username($group['account_lid'], '', '', $account_id);
 			}
@@ -522,7 +521,7 @@ 
 	 * @param boolean $lang =true
 	 * @return string comma-separated and translated labels
 	 */
-	protected static function get_default_label($default, array $values, $lang=true)
+	protected static function get_default_label($default, array $values, $lang = true)
 	{
 		// explode comma-separated multiple default values
 		if (!is_array($default) && !isset($values[$default]) && strpos($default, ',') !== false)
@@ -533,7 +532,7 @@ 
 		{
 			$labels = (array)$default;
 		}
-		foreach($labels as &$def)
+		foreach ($labels as &$def)
 		{
 			if (isset($values[$def]))
 			{
@@ -541,7 +540,7 @@ 
 			}
 			else	// value could be in an optgroup
 			{
-				foreach($values as $value)
+				foreach ($values as $value)
 				{
 					if (is_array($value) && !isset($value['label']) && isset($value[$def]))
 					{
@@ -567,16 +566,16 @@ 
 	 * @param int|string $account_id =null account_id for user or group prefs, or "forced" or "default"
 	 * @return boolean
 	 */
-	protected function call_hook($appname, $type='user', $account_id=null)
+	protected function call_hook($appname, $type = 'user', $account_id = null)
 	{
 		$this->appname = $appname == 'common' ? 'preferences' : $appname;
 
 		// Set framework here to make sure we get the right settings for user's [newly] selected template
 		$GLOBALS['egw_info']['server']['template_set'] = $GLOBALS['egw']->preferences->data['common']['template_set'];
 		Api\Translation::add_app($this->appname);
-		if($this->appname != 'preferences')
+		if ($this->appname != 'preferences')
 		{
-			Api\Translation::add_app('preferences');	// we need the prefs translations too
+			Api\Translation::add_app('preferences'); // we need the prefs translations too
 		}
 
 		// make type available, to hooks from Egw\Applications can use it, eg. activesync
@@ -585,7 +584,7 @@ 
 			'type' => $type,
 			'account_id' => $account_id,
 		);
-		$GLOBALS['type'] = $type;	// old global variable
+		$GLOBALS['type'] = $type; // old global variable
 
 		// calling app specific settings hook
 		$settings = Api\Hooks::single($hook_data, $this->appname);
@@ -594,30 +593,30 @@ 
 		{
 			$this->settings = array_merge($this->settings, $settings);
 		}
-		elseif(isset($GLOBALS['settings']) && is_array($GLOBALS['settings']) && $GLOBALS['settings'])
+		elseif (isset($GLOBALS['settings']) && is_array($GLOBALS['settings']) && $GLOBALS['settings'])
 		{
 			$this->settings = array_merge($this->settings, $GLOBALS['settings']);
 		}
 		else
 		{
-			return False;	// no settings returned
+			return False; // no settings returned
 		}
 
 		// calling settings hook all apps can answer (for a specific app)
 		$hook_data['location'] = 'settings_'.$this->appname;
-		foreach(Api\Hooks::process($hook_data, $this->appname,true) as $settings)
+		foreach (Api\Hooks::process($hook_data, $this->appname, true) as $settings)
 		{
 			if (isset($settings) && is_array($settings) && $settings)
 			{
-				$this->settings = array_merge($this->settings,$settings);
+				$this->settings = array_merge($this->settings, $settings);
 			}
 		}
 		/* Remove ui-only settings */
-		if($this->xmlrpc)
+		if ($this->xmlrpc)
 		{
-			foreach($this->settings as $key => $valarray)
+			foreach ($this->settings as $key => $valarray)
 			{
-				if(!$valarray['xmlrpc'])
+				if (!$valarray['xmlrpc'])
 				{
 					unset($this->settings[$key]);
 				}
@@ -629,10 +628,10 @@ 
 			 This is not handled by the hooks class and is only valid if not using xml-rpc.
 			*/
 			$tmpl_settings = EGW_SERVER_ROOT.$GLOBALS['egw']->framework->template_dir.'/hook_settings.inc.php';
-			if($this->appname == 'preferences' && file_exists($tmpl_settings))
+			if ($this->appname == 'preferences' && file_exists($tmpl_settings))
 			{
 				include($tmpl_settings);
-				$this->settings = array_merge($this->settings,$GLOBALS['settings']);
+				$this->settings = array_merge($this->settings, $GLOBALS['settings']);
 			}
 		}
 		// check if we have a default/forced value from the settings hook,
@@ -653,9 +652,9 @@ 
 		}
 		if ($need_update)
 		{
-			$GLOBALS['egw']->preferences->save_repository(false,'default',true);
+			$GLOBALS['egw']->preferences->save_repository(false, 'default', true);
 		}
-		if($this->debug)
+		if ($this->debug)
 		{
 			_debug_array($this->settings);
 		}