View GitHub Repository ec-cube

Schedule Inspection
Subscribe
Failed Conditions
Pull Request — experimental/3.1 (#2529)
by Kentaro
34:12
created

10,827 +3 Covered Lines

16,563 -169 Total Lines

65.4 % +0.7% Code Coverage

PHP Classes Changes

 
 ⇢
100%
EntityEventScanner added
36.36%
 ↗
96.97%
 CustomerFavoriteProductRepository improved
65.16%
 ↗
95.93%
 OrderHelper improved
44.75%
 ↗
66.3%
 ProductController improved
76.03%
 ↗
96.74%
 OrderType improved
75.82%
 ↘
64.8%
 EccubePluginServiceProvider got worse
27.27%
 ↘
16.66%
 OrderService got worse
64.71%
 ↗
69.12%
 AddCartType improved
42.14%
 ↗
46.48%
 OrderItemType improved
35.57%
 ↘
33%
 ShoppingService got worse
95.35%
 ↗
97.14%
 TaxRuleEventSubscriber improved
⋮ view more  
62.12%
 ↛
 
 OrderDetailType removed

CRAP Changes

 
 ⇢
56
EccubePluginServiceProvider::registerServiceProvid... added
 
 ⇢
1
PluginRepository::findAllEnabled() added
 
 ⇢
1
EntityEventScanner::__construct() added
 
 ⇢
1
EntityEventScanner::getAnnotationClass() added
 
 ⇢
1
EntityEventScanner::createComponentDefinition() added
 
 ⇢
1
EntityEventScanner::generateExtend() added
11.0295
 ↘
11.0269
 Di::generateServiceProvider() improved
8.1174
 ↗
8.125
 EccubePluginServiceProvider::register() got worse
2.2846
 ↗
2.2925
 EccubeServiceProvider::register() got worse
3
 ↗
3.0175
 ShoppingService::setFormData() got worse
20.0034
 ↗
20.0546
 ProductClassController::index() got worse
9.4684
 ↘
9.0874
 AddCartType::buildForm() improved
13.2261
 ↘
12.4105
 Application::initialize() improved
7.0052
 ↗
8.0046
 ShoppingService::getFormDeliveryDates() got worse
2
 ↘
1
 CustomerFavoriteProductRepository::isFavorite() improved
2
 ↘
1
 OrderItemType::getBlockPrefix() improved
⋮ view more  
30
 ↛
 
 OrderHelper::createOrderItemsFromOrderDetails() removed
20
 ↛
 
 OrderHelper::createOrderDetailsFromCartItems() removed
13.6922
 ↛
 
 ShoppingService::isOrderProduct() removed
12.4044
 ↛
 
 OrderDetailType::buildForm() removed
12
 ↛
 
 ShoppingService::getNewOrderDetail() removed
6
 ↛
 
 EditController::calculate() removed
6
 ↛
 
 OrderHelper::addOrderDetails() removed
4.0119
 ↛
 
 ShoppingService::setStockUpdate() removed
2
 ↛
 
 OrderService::getSubTotal() removed
2
 ↛
 
 OrderService::setStockUpdate() removed
⋮ view more