Inspection of "編集可能対象のメールテンプレートを増やす #1924" - EC-CUBE/ec-cube - Measure and Improve Code Quality continuously with Scrutinizer

Failed Conditions

Pull Request — experimental/3.1 (#2672)

unknown

created 2017-12-01 02:55 UTC

Status

Doc Comments -1 removed lines patch added patch discarded remove patch

@@ -66,7 +66,6 @@
 block discarded – undo
     /**
      * 書き込みパスの取得
      *
-     * @param  boolean $isUser
      * @return string
      */
     public function getWriteTemplatePath()

Please login to merge, or discard this patch.

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -95,7 +95,7 @@
 block discarded – undo
         );
     
         foreach ($readPaths as $readPath) {
-            $filePath = $readPath . '/' . $fileName;
+            $filePath = $readPath.'/'.$fileName;
             $fs = new Filesystem();
             if ($fs->exists($filePath)) {
                 return array(

Please login to merge, or discard this patch.

src/Eccube/Service/MailService.php 1 patch

Spacing +9 added lines, -9 removed lines patch added patch discarded remove patch

@@ -83,7 +83,7 @@  discard block
 block discarded – undo
         ));
 
         $message = \Swift_Message::newInstance()
-            ->setSubject('[' . $this->BaseInfo->getShopName() . '] ' . $MailTemplate->getMailSubject())
+            ->setSubject('['.$this->BaseInfo->getShopName().'] '.$MailTemplate->getMailSubject())
             ->setFrom(array($this->BaseInfo->getEmail01() => $this->BaseInfo->getShopName()))
             ->setTo(array($Customer->getEmail()))
             ->setBcc($this->BaseInfo->getEmail01())
@@ -128,7 +128,7 @@  discard block
 block discarded – undo
         ));
 
         $message = \Swift_Message::newInstance()
-            ->setSubject('[' . $this->BaseInfo->getShopName() . '] ' . $MailTemplate->getMailSubject())
+            ->setSubject('['.$this->BaseInfo->getShopName().'] '.$MailTemplate->getMailSubject())
             ->setFrom(array($this->BaseInfo->getEmail01() => $this->BaseInfo->getShopName()))
             ->setTo(array($Customer->getEmail()))
             ->setBcc($this->BaseInfo->getEmail01())
@@ -174,7 +174,7 @@  discard block
 block discarded – undo
         ));
 
         $message = \Swift_Message::newInstance()
-            ->setSubject('[' . $this->BaseInfo->getShopName() . '] ' . $MailTemplate->getMailSubject())
+            ->setSubject('['.$this->BaseInfo->getShopName().'] '.$MailTemplate->getMailSubject())
             ->setFrom(array($this->BaseInfo->getEmail01() => $this->BaseInfo->getShopName()))
             ->setTo(array($email))
             ->setBcc($this->BaseInfo->getEmail01())
@@ -221,7 +221,7 @@  discard block
 block discarded – undo
 
         // 問い合わせ者にメール送信
         $message = \Swift_Message::newInstance()
-            ->setSubject('[' . $this->BaseInfo->getShopName() . '] ' . $MailTemplate->getMailSubject())
+            ->setSubject('['.$this->BaseInfo->getShopName().'] '.$MailTemplate->getMailSubject())
             ->setFrom(array($this->BaseInfo->getEmail02() => $this->BaseInfo->getShopName()))
             ->setTo(array($formData['email']))
             ->setBcc($this->BaseInfo->getEmail02())
@@ -278,7 +278,7 @@  discard block
 block discarded – undo
         ));
 
         $message = \Swift_Message::newInstance()
-            ->setSubject('[' . $this->BaseInfo->getShopName() . '] ' . $MailTemplate->getMailSubject())
+            ->setSubject('['.$this->BaseInfo->getShopName().'] '.$MailTemplate->getMailSubject())
             ->setFrom(array($this->BaseInfo->getEmail01() => $this->BaseInfo->getShopName()))
             ->setTo(array($Order->getEmail()))
             ->setBcc($this->BaseInfo->getEmail01())
@@ -327,7 +327,7 @@  discard block
 block discarded – undo
         ));
 
         $message = \Swift_Message::newInstance()
-            ->setSubject('[' . $this->BaseInfo->getShopName() . '] ' . $MailTemplate->getMailSubject())
+            ->setSubject('['.$this->BaseInfo->getShopName().'] '.$MailTemplate->getMailSubject())
             ->setFrom(array($this->BaseInfo->getEmail03() => $this->BaseInfo->getShopName()))
             ->setTo(array($Customer->getEmail()))
             ->setBcc($this->BaseInfo->getEmail01())
@@ -371,7 +371,7 @@  discard block
 block discarded – undo
         ));
 
         $message = \Swift_Message::newInstance()
-            ->setSubject('[' . $this->BaseInfo->getShopName() . '] ' . $formData['mail_subject'])
+            ->setSubject('['.$this->BaseInfo->getShopName().'] '.$formData['mail_subject'])
             ->setFrom(array($this->BaseInfo->getEmail01() => $this->BaseInfo->getShopName()))
             ->setTo(array($Order->getEmail()))
             ->setBcc($this->BaseInfo->getEmail01())
@@ -416,7 +416,7 @@  discard block
 block discarded – undo
         ));
 
         $message = \Swift_Message::newInstance()
-            ->setSubject('[' . $this->BaseInfo->getShopName() . '] ' . $MailTemplate->getMailSubject())
+            ->setSubject('['.$this->BaseInfo->getShopName().'] '.$MailTemplate->getMailSubject())
             ->setFrom(array($this->BaseInfo->getEmail01() => $this->BaseInfo->getShopName()))
             ->setTo(array($Customer->getEmail()))
             ->setBcc($this->BaseInfo->getEmail01())
@@ -461,7 +461,7 @@  discard block
 block discarded – undo
         ));
 
         $message = \Swift_Message::newInstance()
-            ->setSubject('[' . $this->BaseInfo->getShopName() . '] ' . $MailTemplate->getMailSubject())
+            ->setSubject('['.$this->BaseInfo->getShopName().'] '.$MailTemplate->getMailSubject())
             ->setFrom(array($this->BaseInfo->getEmail01() => $this->BaseInfo->getShopName()))
             ->setTo(array($Customer->getEmail()))
             ->setBcc($this->BaseInfo->getEmail01())

Please login to merge, or discard this patch.

		@@ -95,7 +95,7 @@
		block discarded – undo
95	95	);
96	96
97	97	foreach ($readPaths as $readPath) {
98		- $filePath = $readPath . '/' . $fileName;
	98	+ $filePath = $readPath.'/'.$fileName;
99	99	$fs = new Filesystem();
100	100	if ($fs->exists($filePath)) {
101	101	return array(

		@@ -83,7 +83,7 @@ discard block
		block discarded – undo
83	83	));
84	84
85	85	$message = \Swift_Message::newInstance()
86		- ->setSubject('[' . $this->BaseInfo->getShopName() . '] ' . $MailTemplate->getMailSubject())
	86	+ ->setSubject('['.$this->BaseInfo->getShopName().'] '.$MailTemplate->getMailSubject())
87	87	->setFrom(array($this->BaseInfo->getEmail01() => $this->BaseInfo->getShopName()))
88	88	->setTo(array($Customer->getEmail()))
89	89	->setBcc($this->BaseInfo->getEmail01())
		@@ -128,7 +128,7 @@ discard block
		block discarded – undo
128	128	));
129	129
130	130	$message = \Swift_Message::newInstance()
131		- ->setSubject('[' . $this->BaseInfo->getShopName() . '] ' . $MailTemplate->getMailSubject())
	131	+ ->setSubject('['.$this->BaseInfo->getShopName().'] '.$MailTemplate->getMailSubject())
132	132	->setFrom(array($this->BaseInfo->getEmail01() => $this->BaseInfo->getShopName()))
133	133	->setTo(array($Customer->getEmail()))
134	134	->setBcc($this->BaseInfo->getEmail01())
		@@ -174,7 +174,7 @@ discard block
		block discarded – undo
174	174	));
175	175
176	176	$message = \Swift_Message::newInstance()
177		- ->setSubject('[' . $this->BaseInfo->getShopName() . '] ' . $MailTemplate->getMailSubject())
	177	+ ->setSubject('['.$this->BaseInfo->getShopName().'] '.$MailTemplate->getMailSubject())
178	178	->setFrom(array($this->BaseInfo->getEmail01() => $this->BaseInfo->getShopName()))
179	179	->setTo(array($email))
180	180	->setBcc($this->BaseInfo->getEmail01())
		@@ -221,7 +221,7 @@ discard block
		block discarded – undo
221	221
222	222	// 問い合わせ者にメール送信
223	223	$message = \Swift_Message::newInstance()
224		- ->setSubject('[' . $this->BaseInfo->getShopName() . '] ' . $MailTemplate->getMailSubject())
	224	+ ->setSubject('['.$this->BaseInfo->getShopName().'] '.$MailTemplate->getMailSubject())
225	225	->setFrom(array($this->BaseInfo->getEmail02() => $this->BaseInfo->getShopName()))
226	226	->setTo(array($formData['email']))
227	227	->setBcc($this->BaseInfo->getEmail02())
		@@ -278,7 +278,7 @@ discard block
		block discarded – undo
278	278	));
279	279
280	280	$message = \Swift_Message::newInstance()
281		- ->setSubject('[' . $this->BaseInfo->getShopName() . '] ' . $MailTemplate->getMailSubject())
	281	+ ->setSubject('['.$this->BaseInfo->getShopName().'] '.$MailTemplate->getMailSubject())
282	282	->setFrom(array($this->BaseInfo->getEmail01() => $this->BaseInfo->getShopName()))
283	283	->setTo(array($Order->getEmail()))
284	284	->setBcc($this->BaseInfo->getEmail01())
		@@ -327,7 +327,7 @@ discard block
		block discarded – undo
327	327	));
328	328
329	329	$message = \Swift_Message::newInstance()
330		- ->setSubject('[' . $this->BaseInfo->getShopName() . '] ' . $MailTemplate->getMailSubject())
	330	+ ->setSubject('['.$this->BaseInfo->getShopName().'] '.$MailTemplate->getMailSubject())
331	331	->setFrom(array($this->BaseInfo->getEmail03() => $this->BaseInfo->getShopName()))
332	332	->setTo(array($Customer->getEmail()))
333	333	->setBcc($this->BaseInfo->getEmail01())
		@@ -371,7 +371,7 @@ discard block
		block discarded – undo
371	371	));
372	372
373	373	$message = \Swift_Message::newInstance()
374		- ->setSubject('[' . $this->BaseInfo->getShopName() . '] ' . $formData['mail_subject'])
	374	+ ->setSubject('['.$this->BaseInfo->getShopName().'] '.$formData['mail_subject'])
375	375	->setFrom(array($this->BaseInfo->getEmail01() => $this->BaseInfo->getShopName()))
376	376	->setTo(array($Order->getEmail()))
377	377	->setBcc($this->BaseInfo->getEmail01())
		@@ -416,7 +416,7 @@ discard block
		block discarded – undo
416	416	));
417	417
418	418	$message = \Swift_Message::newInstance()
419		- ->setSubject('[' . $this->BaseInfo->getShopName() . '] ' . $MailTemplate->getMailSubject())
	419	+ ->setSubject('['.$this->BaseInfo->getShopName().'] '.$MailTemplate->getMailSubject())
420	420	->setFrom(array($this->BaseInfo->getEmail01() => $this->BaseInfo->getShopName()))
421	421	->setTo(array($Customer->getEmail()))
422	422	->setBcc($this->BaseInfo->getEmail01())
		@@ -461,7 +461,7 @@ discard block
		block discarded – undo
461	461	));
462	462
463	463	$message = \Swift_Message::newInstance()
464		- ->setSubject('[' . $this->BaseInfo->getShopName() . '] ' . $MailTemplate->getMailSubject())
	464	+ ->setSubject('['.$this->BaseInfo->getShopName().'] '.$MailTemplate->getMailSubject())
465	465	->setFrom(array($this->BaseInfo->getEmail01() => $this->BaseInfo->getShopName()))
466	466	->setTo(array($Customer->getEmail()))
467	467	->setBcc($this->BaseInfo->getEmail01())

		@@ -66,7 +66,6 @@
		block discarded – undo
66	66	/**
67	67	* 書き込みパスの取得
68	68	*
69		- * @param boolean $isUser
70	69	* @return string
71	70	*/
72	71	public function getWriteTemplatePath()

EC-CUBE / ec-cube

Pull Request — experimental/3.1 (#2672)

Status

Category

Doc Comments -1 removed lines patch added patch discarded remove patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

Spacing +9 added lines, -9 removed lines patch added patch discarded remove patch