EC-CUBE / ec-cube

Failed Conditions

Pull Request — 4.0 (#3714)

by chihiro

created 2018-08-30 12:34 UTC

Changes

2 failure conditions met `issues.severity(>= MAJOR).new.exists` File Path Number of issues Eccube/Controller/ShippingMultipleController.php 1 src/Eccube/Controller/ShoppingController.php 4 src/Eccube/Entity/Order.php 1 src/Eccube/Form/Type/Shopping/OrderType.php 1 PurchaseFlow/Processor/AddPointProcessor.php 1 Processor/DeliveryFeeChangeValidator.php 1 Processor/PaymentChargeChangeValidator.php 1 src/Eccube/Service/PurchaseFlow/PurchaseFlow.php 1 `elements.rating(<= D).new.exists` Name PurchaseFlow\PurchaseFlow::validate() Eccube\Entity\OrderItem
	25 issues (11 major, 8 minor, 6 informational) were introduced. 14 issues were fixed.
	2 new patches (Doc Comments) are available.
	39 added classes/operations
		C	EmptyItemsValidator::validate() added
		B	AbstractShoppingController::executePurchaseFlow() added
		A	PointHelper::addPointDiscountItem() added
		A	ItemHolderPostValidator::execute() added
		A	AddPointProcessor::calculateAddPoint() added
		A	AddPointProcessor::supports() added
		A	DeliveryFeeChangeValidator::validate() added
		A	DeliveryFeePreprocessor::removeDeliveryFeeItem() added
		B	DeliveryFeePreprocessor::saveDeliveryFeeItem() added
		B	PointProcessor::addDiscountItem() added
B	↘	F	PurchaseFlow::validate() got worse
A	↘	B	PurchaseFlow got worse
C	↘	D	OrderItem got worse
view all

7.95

▶ ± 0

Test Coverage

73%

▶ ±0%

Head	Ryo Endo 2018-08-31 09:43 GMT+0900 Merge pull request #3714 from chihiro-adachi/improve/purchaseflow
⋮	43 more commits
Base	Chihiro Adachi 2018-08-30 12:33 UTC Merge pull request #3705 from okazy/delete-product-category-sort-no