EC-CUBE / ec-cube

src/Eccube/Form/Type/Admin/ShippingType.php

Unused Use Statements -2 removed lines

@@ -27,7 +27,6 @@ 
 use Doctrine\ORM\EntityRepository;
 use Eccube\Annotation\FormType;
 use Eccube\Annotation\Inject;
-use Eccube\Application;
 use Eccube\Common\Constant;
 use Eccube\Entity\BaseInfo;
 use Eccube\Form\Type\AddressType;
@@ -35,7 +34,6 @@ 
 use Eccube\Form\Type\NameType;
 use Eccube\Form\Type\TelType;
 use Eccube\Form\Type\ZipType;
-use Eccube\Repository\BaseInfoRepository;
 use Eccube\Repository\DeliveryRepository;
 use Symfony\Bridge\Doctrine\Form\Type\EntityType;
 use Symfony\Component\Form\AbstractType;

Spacing +7 added lines, -7 removed lines

@@ -199,7 +199,7 @@ 
                 'prototype' => true,
             ))
 
-            ->addEventListener(FormEvents::PRE_SET_DATA, function (FormEvent $event) {
+            ->addEventListener(FormEvents::PRE_SET_DATA, function(FormEvent $event) {
                 if ($this->BaseInfo->getOptionMultipleShipping() == Constant::ENABLED) {
                     $form = $event->getForm();
                     $form->add('OrderItems', CollectionType::class, array(
@@ -210,7 +210,7 @@ 
                     ));
                 }
             })
-            ->addEventListener(FormEvents::POST_SET_DATA, function (FormEvent $event) {
+            ->addEventListener(FormEvents::POST_SET_DATA, function(FormEvent $event) {
                 /** @var \Eccube\Entity\Shipping $data */
                 $data = $event->getData();
                 /** @var \Symfony\Component\Form\Form $form */
@@ -229,7 +229,7 @@ 
                     'choice_label' => 'delivery_time',
                     'placeholder' => '指定なし',
                     'required' => false,
-                    'query_builder' => function (EntityRepository $er) use($Delivery) {
+                    'query_builder' => function(EntityRepository $er) use($Delivery) {
                         return $er->createQueryBuilder('dt')
                             ->where('dt.Delivery = :Delivery')
                             ->setParameter('Delivery', $Delivery);
@@ -237,7 +237,7 @@ 
                 ));
 
             })
-            ->addEventListener(FormEvents::PRE_SUBMIT, function (FormEvent $event) {
+            ->addEventListener(FormEvents::PRE_SUBMIT, function(FormEvent $event) {
                 $data = $event->getData();
                 $form = $event->getForm();
                 if (!$data) {
@@ -257,14 +257,14 @@ 
                     'choice_label' => 'delivery_time',
                     'placeholder' => '指定なし',
                     'required' => false,
-                    'query_builder' => function (EntityRepository $er) use($Delivery) {
+                    'query_builder' => function(EntityRepository $er) use($Delivery) {
                         return $er->createQueryBuilder('dt')
                             ->where('dt.Delivery = :Delivery')
                             ->setParameter('Delivery', $Delivery);
                     },
                 ));
             })
-            ->addEventListener(FormEvents::POST_SUBMIT, function (FormEvent $event) {
+            ->addEventListener(FormEvents::POST_SUBMIT, function(FormEvent $event) {
                 if ($this->BaseInfo->getOptionMultipleShipping() == Constant::ENABLED) {
                     $form = $event->getForm();
                     $OrderItems = $form['OrderItems']->getData();
@@ -275,7 +275,7 @@ 
                     }
                 }
             })
-            ->addEventListener(FormEvents::POST_SUBMIT, function (FormEvent $event) {
+            ->addEventListener(FormEvents::POST_SUBMIT, function(FormEvent $event) {
                 $Shipping = $event->getData();
                 $Delivery = $Shipping->getDelivery();
                 $Shipping->setShippingDeliveryName($Delivery ? $Delivery : null);

src/Eccube/Service/Calculator/CalculateContext.php

Unused Use Statements -1 removed lines

@@ -4,7 +4,6 @@
 use Eccube\Entity\Order;
 use Eccube\Entity\PurchaseInterface;
 use Eccube\Entity\OrderItem;
-use Eccube\Service\Calculator\Strategy\CalculateStrategyInterface;
 
 class CalculateContext
 {

Spacing +1 added lines, -1 removed lines

@@ -23,7 +23,7 @@
         $this->buildCalculator($this->CalculateStrategies);
 
         /** @var OrderItem $OrderItem */
-        foreach($this->OrderItems as $OrderItem) {
+        foreach ($this->OrderItems as $OrderItem) {
             if ($OrderItem instanceof OrderItem) {
                 if (!$this->Order->getItems()->contains($OrderItem)) {
                     $OrderItem->setOrder($this->Order);

src/Eccube/Service/Calculator/Strategy/CalculateChargeStrategy.php

Unused Use Statements -4 removed lines

@@ -2,13 +2,9 @@
 namespace Eccube\Service\Calculator\Strategy;
 
 use Eccube\Application;
-use Eccube\Entity\Master\OrderItemType;
-use Eccube\Entity\Master\TaxType;
-use Eccube\Entity\Master\TaxDisplayType;
 use Eccube\Entity\Order;
 use Eccube\Entity\PurchaseInterface;
 use Eccube\Entity\OrderItem;
-use Eccube\Entity\Shipping;
 use Eccube\Repository\Master\OrderItemTypeRepository;
 use Eccube\Service\Calculator\OrderItemCollection;
 

src/Eccube/Service/Calculator/Strategy/CalculateTotalStrategy.php

Unused Use Statements -4 removed lines

@@ -2,14 +2,10 @@
 namespace Eccube\Service\Calculator\Strategy;
 
 use Eccube\Application;
-use Eccube\Entity\Master\OrderItemType;
-use Eccube\Entity\Master\TaxType;
-use Eccube\Entity\Master\TaxDisplayType;
 use Eccube\Entity\Cart;
 use Eccube\Entity\Order;
 use Eccube\Entity\PurchaseInterface;
 use Eccube\Entity\OrderItem;
-use Eccube\Entity\Shipping;
 use Eccube\Repository\Master\OrderItemTypeRepository;
 use Eccube\Service\Calculator\OrderItemCollection;
 

src/Eccube/Service/Calculator/Strategy/ChargeStrategy.php

Unused Use Statements -1 removed lines

@@ -8,7 +8,6 @@
 use Eccube\Entity\Order;
 use Eccube\Entity\PurchaseInterface;
 use Eccube\Entity\OrderItem;
-use Eccube\Entity\Shipping;
 use Eccube\Repository\Master\OrderItemTypeRepository;
 use Eccube\Service\Calculator\OrderItemCollection;
 

src/Eccube/Service/PurchaseFlow/Processor/StockReduceProcessor.php

Unused Use Statements -1 removed lines

@@ -3,7 +3,6 @@
 namespace Eccube\Service\PurchaseFlow\Processor;
 
 use Doctrine\DBAL\LockMode;
-use Eccube\Annotation\Inject;
 use Eccube\Common\Constant;
 use Eccube\Entity\ItemInterface;
 use Eccube\Entity\OrderItem;

src/Eccube/Service/TaxRuleService.php

Doc Comments +3 added lines, -3 removed lines

@@ -65,7 +65,7 @@ 
      * @param  int|null|\Eccube\Entity\ProductClass   $productClass 商品規格
      * @param  int|null|\Eccube\Entity\Master\Pref    $pref         都道府県
      * @param  int|null|\Eccube\Entity\Master\Country $country      国
-     * @return int
+     * @return double
      */
     public function getPriceIncTax($price, $product = null, $productClass = null, $pref = null, $country = null)
     {
@@ -92,8 +92,8 @@ 
     /**
      * 課税規則に応じて端数処理を行う
      *
-     * @param  float|integer $value    端数処理を行う数値
-     * @param  integer       $calcRule 課税規則
+     * @param  integer $value    端数処理を行う数値
+     * @param integer $RoundingType
      * @return double        端数処理後の数値
      */
     public function roundByRoundingType($value, $RoundingType)

src/Eccube/Service/Calculator/OrderItemCollection.php

Spacing +1 added lines, -1 removed lines

@@ -63,7 +63,7 @@
     public function hasProductByName($productName)
     {
         $OrderItems = $this->filter(
-            function (ItemInterface $OrderItem) use ($productName) {
+            function(ItemInterface $OrderItem) use ($productName) {
                 /* @var OrderItem $OrderItem */
                 return $OrderItem->getProductName() == $productName;
             });

src/Eccube/Service/PurchaseFlow/ItemCollection.php

Spacing +7 added lines, -7 removed lines

@@ -31,7 +31,7 @@ 
     public function getProductClasses()
     {
         return $this->filter(
-            function (ItemInterface $OrderItem) {
+            function(ItemInterface $OrderItem) {
                 return $OrderItem->isProduct();
             });
     }
@@ -39,7 +39,7 @@ 
     public function getDeliveryFees()
     {
         return $this->filter(
-            function (ItemInterface $OrderItem) {
+            function(ItemInterface $OrderItem) {
                 return $OrderItem->isDeliveryFee();
             });
     }
@@ -47,7 +47,7 @@ 
     public function getCharges()
     {
         return $this->filter(
-            function (ItemInterface $OrderItem) {
+            function(ItemInterface $OrderItem) {
                 return $OrderItem->isCharge();
             });
     }
@@ -55,7 +55,7 @@ 
     public function getDiscounts()
     {
         return $this->filter(
-            function (ItemInterface $OrderItem) {
+            function(ItemInterface $OrderItem) {
                 return $OrderItem->isDiscount();
             });
     }
@@ -68,7 +68,7 @@ 
     public function hasProductByName($productName)
     {
         $OrderItems = $this->filter(
-            function (ItemInterface $OrderItem) use ($productName) {
+            function(ItemInterface $OrderItem) use ($productName) {
                 /* @var OrderItem $OrderItem */
                 return $OrderItem->getProductName() == $productName;
             });
@@ -85,7 +85,7 @@ 
      */
     public function hasItemByOrderItemType($OrderItemType)
     {
-        $filteredItems = $this->filter(function (ItemInterface $OrderItem) use ($OrderItemType) {
+        $filteredItems = $this->filter(function(ItemInterface $OrderItem) use ($OrderItemType) {
             /* @var OrderItem $OrderItem */
             return $OrderItem->getOrderItemType() && $OrderItem->getOrderItemType()->getId() == $OrderItemType->getId();
         });
@@ -101,7 +101,7 @@ 
     public function sort()
     {
         $Items = $this->toArray();
-        usort($Items, function (ItemInterface $a, ItemInterface $b) {
+        usort($Items, function(ItemInterface $a, ItemInterface $b) {
             if ($a->getOrderItemType() === $b->getOrderItemType()) {
                 return ($a->getId() < $b->getId()) ? -1 : 1;
             } elseif ($a->isProduct()) {