Failed Conditions
Pull Request — experimental/sf (#3234)
by Kiyotaka
42:13
created

11,770 -81 Covered Lines

16,953 -186 Total Lines

69.4 % +0.3% Code Coverage

PHP Classes Changes

 
100%
TruncateHyphenListener added
 
100%
PhoneNumberType added
 
100%
PostalType added
48.21%
55.34%
ShoppingController improved
100%
96.3%
SaleLimitMultipleValidator got worse
27.31%
28.95%
NonMemberShoppingController improved
85.11%
84.09%
ContactController got worse
17.99%
18.92%
ShoppingService improved
68%
67.47%
EditController got worse
68.42%
68.04%
EditController got worse
96.67%
96.55%
ShippingType got worse
96.69%
96.61%
OrderRepository got worse
99.29%
99.25%
OrderHelper got worse
28.57%
 
ConvertTelListener removed
50%
 
FaxType removed
100%
 
TelType removed
100%
 
ZipType removed

CRAP Changes

 
3
PostalType::configureOptions() added
 
3
PhoneNumberType::configureOptions() added
 
1
PostalType::getParent() added
 
1
PostalType::getBlockPrefix() added
 
1
TruncateHyphenListener::getSubscribedEvents() added
 
1
TruncateHyphenListener::onPreSubmit() added
 
1
PhoneNumberType::__construct() added
 
1
PhoneNumberType::buildForm() added
 
1
PhoneNumberType::getParent() added
 
1
PhoneNumberType::getBlockPrefix() added
view more  
4.0005
4.0005
EditController::searchCustomer() improved
9.0039
9.0043
ShippingType::buildForm() got worse
4.0023
4.0039
EditController::searchCustomerById() got worse
11.0775
11.096
NonMemberShoppingController::index() got worse
3
3.0261
SaleLimitMultipleValidator::formatProductName() got worse
6.1553
6.1929
ContactController::index() got worse
19.7049
22.1191
EditController::edit() got worse
46.6055
42.6207
OrderRepository::getQueryBuilderBySearchData() improved
12
 
ShoppingController::customerValidation() removed
11
 
TelType::buildForm() removed
5
 
ZipType::buildForm() removed
2
 
ConvertTelListener::onPreSubmit() removed
2
 
FaxType::getBlockPrefix() removed
1
 
TelType::getBlockPrefix() removed
1
 
ZipType::__construct() removed
1
 
ZipType::buildView() removed
1
 
ZipType::configureOptions() removed
1
 
ZipType::getBlockPrefix() removed
view more