EC-CUBE / ec-cube

codeception/acceptance/AA0PluginInstallerCest.php

Unused Use Statements -1 removed lines

@@ -1,6 +1,5 @@
 <?php
 
-use Codeception\Util\Fixtures;
 use Page\Admin\OwnersPluginPage;
 
 /**

codeception/acceptance/EA01TopCest.php

Unused Use Statements -1 removed lines

@@ -1,7 +1,6 @@
 <?php
 
 use Codeception\Util\Fixtures;
-use Page\Admin\CustomerManagePage;
 use Page\Admin\OrderManagePage;
 use Page\Admin\TopPage;
 

Spacing +1 added lines, -1 removed lines

@@ -44,7 +44,7 @@
         // 購入された商品が受注管理画面のページにて反映されていることを確認
         $config = Fixtures::get('config');
         $findOrders = Fixtures::get('findOrders');
-        $NewOrders = array_filter($findOrders(), function ($Order) use ($config) {
+        $NewOrders = array_filter($findOrders(), function($Order) use ($config) {
             return $Order->getOrderStatus()->getId() == \Eccube\Entity\Master\OrderStatus::NEW;
         });
         $I->see(count($NewOrders), TopPage::$受付状況_新規受付数);

codeception/acceptance/EA02AuthenticationCest.php

Unused Use Statements -2 removed lines

@@ -1,7 +1,5 @@
 <?php
 
-use Codeception\Util\Fixtures;
-
 /**
  * @group admin
  * @group admin01

codeception/acceptance/EA07BasicinfoCest.php

Unused Use Statements -3 removed lines

@@ -1,8 +1,6 @@ 
 <?php
 
-use Codeception\Util\Fixtures;
 use Page\Admin\CsvSettingsPage;
-use Page\Admin\CustomerAgreementSettingPage;
 use Page\Admin\DeliveryEditPage;
 use Page\Admin\DeliveryManagePage;
 use Page\Admin\MailSettingsPage;
@@ -10,7 +8,6 @@ 
 use Page\Admin\PaymentManagePage;
 use Page\Admin\ShopSettingPage;
 use Page\Admin\TaxManagePage;
-use Page\Admin\TradelawSettingPage;
 
 /**
  * @group admin

codeception/acceptance/EF06OtherCest.php

Unused Use Statements -1 removed lines

@@ -1,7 +1,6 @@
 <?php
 
 use Codeception\Util\Fixtures;
-use Eccube\Entity\Master\CustomerStatus;
 
 /**
  * @group front

Spacing +1 added lines, -1 removed lines

@@ -81,7 +81,7 @@
         $createCustomer = Fixtures::get('createCustomer');
         $customer = $createCustomer();
         $I->resetEmails();
-        $I->submitForm('#form1',[
+        $I->submitForm('#form1', [
             'login_email' => $customer->getEmail()
         ]);
         $I->see('パスワード発行メールの送信 完了', 'div.ec-pageHeader h1');

src/Eccube/Controller/AbstractController.php

Doc Comments +4 added lines, -1 removed lines

@@ -153,6 +153,9 @@ 
         $this->addWarning('admin.delete.warning', 'admin');
     }
 
+    /**
+     * @param string $targetPath
+     */
     public function setLoginTargetPath($targetPath, $namespace = null)
     {
         if (is_null($namespace)) {
@@ -169,7 +172,7 @@ 
      * @param array  $path An array of path parameters
      * @param array  $query An array of query parameters
      *
-     * @return Response A Response instance
+     * @return \Symfony\Component\HttpFoundation\Response A Response instance
      */
     public function forwardToRoute($route, array $path = [], array $query = [])
     {

src/Eccube/Controller/Admin/AdminController.php

Doc Comments +14 added lines, -14 removed lines

@@ -334,10 +334,10 @@ 
     }
 
     /**
-     * @param $em
+     * @param \Doctrine\ORM\EntityManagerInterface $em
      * @param array $excludes
      *
-     * @return array
+     * @return null|Request
      */
     protected function findOrderStatus($em, array $excludes)
     {
@@ -354,10 +354,10 @@ 
     }
 
     /**
-     * @param $em
+     * @param \Doctrine\ORM\EntityManagerInterface $em
      * @param array $excludes
      *
-     * @return array
+     * @return null|Request
      */
     protected function getOrderEachStatus($em, array $excludes)
     {
@@ -387,11 +387,11 @@ 
     }
 
     /**
-     * @param $em
-     * @param $dateTime
+     * @param \Doctrine\ORM\EntityManagerInterface $em
+     * @param \DateTime $dateTime
      * @param array $excludes
      *
-     * @return array
+     * @return null|Request
      */
     protected function getSalesByMonth($em, $dateTime, array $excludes)
     {
@@ -425,11 +425,11 @@ 
     }
 
     /**
-     * @param $em
-     * @param $dateTime
+     * @param \Doctrine\ORM\EntityManagerInterface $em
+     * @param \DateTime $dateTime
      * @param array $excludes
      *
-     * @return array
+     * @return null|Request
      */
     protected function getSalesByDay($em, $dateTime, array $excludes)
     {
@@ -463,9 +463,9 @@ 
     }
 
     /**
-     * @param $em
+     * @param \Doctrine\ORM\EntityManagerInterface $em
      *
-     * @return mixed
+     * @return null|Request
      *
      * @throws NoResultException
      * @throws \Doctrine\ORM\NonUniqueResultException
@@ -486,9 +486,9 @@ 
     }
 
     /**
-     * @param $em
+     * @param \Doctrine\ORM\EntityManagerInterface $em
      *
-     * @return mixed
+     * @return null|Request
      *
      * @throws NoResultException
      * @throws \Doctrine\ORM\NonUniqueResultException

Unused Use Statements +1 added lines, -1 removed lines

@@ -14,8 +14,8 @@
 namespace Eccube\Controller\Admin;
 
 use Doctrine\ORM\NoResultException;
-use Doctrine\ORM\Query\ResultSetMapping;
 use Doctrine\ORM\QueryBuilder;
+use Doctrine\ORM\Query\ResultSetMapping;
 use Eccube\Controller\AbstractController;
 use Eccube\Entity\Master\OrderStatus;
 use Eccube\Entity\ProductStock;

src/Eccube/Controller/Admin/Content/FileController.php

Doc Comments +13 added lines

@@ -278,6 +278,10 @@ 
         return $paths;
     }
 
+    /**
+     * @param string $topDir
+     * @param Request $request
+     */
     private function getTree($topDir, $request)
     {
         $finder = Finder::create()->in($topDir)
@@ -314,6 +318,9 @@ 
         return $tree;
     }
 
+    /**
+     * @param string $nowDir
+     */
     private function getFileList($nowDir)
     {
         $topDir = $this->getuserDataDir();
@@ -366,6 +373,9 @@ 
         return str_replace('\\', '/', realpath($path));
     }
 
+    /**
+     * @param string $topDir
+     */
     protected function checkDir($targetDir, $topDir)
     {
         $targetDir = realpath($targetDir);
@@ -374,6 +384,9 @@ 
         return strpos($targetDir, $topDir) === 0;
     }
 
+    /**
+     * @return string
+     */
     private function convertStrFromServer($target)
     {
         if ($this->encode == self::SJIS) {

Spacing +1 added lines, -1 removed lines

@@ -317,7 +317,7 @@
     private function getFileList($nowDir)
     {
         $topDir = $this->getuserDataDir();
-        $filter = function (\SplFileInfo $file) use ($topDir) {
+        $filter = function(\SplFileInfo $file) use ($topDir) {
             $acceptPath = realpath($topDir);
             $targetPath = $file->getRealPath();
 

Unused Use Statements +4 added lines, -4 removed lines

@@ -14,22 +14,22 @@
 namespace Eccube\Controller\Admin\Content;
 
 use Eccube\Controller\AbstractController;
+use Eccube\Util\FilesystemUtil;
+use Sensio\Bundle\FrameworkExtraBundle\Configuration\Method;
 use Sensio\Bundle\FrameworkExtraBundle\Configuration\Route;
 use Sensio\Bundle\FrameworkExtraBundle\Configuration\Template;
-use Sensio\Bundle\FrameworkExtraBundle\Configuration\Method;
+use Symfony\Component\Filesystem\Exception\IOException;
 use Symfony\Component\Filesystem\Filesystem;
 use Symfony\Component\Finder\Finder;
 use Symfony\Component\Form\Extension\Core\Type\FileType;
 use Symfony\Component\Form\Extension\Core\Type\FormType;
 use Symfony\Component\Form\Extension\Core\Type\TextType;
 use Symfony\Component\HttpFoundation\BinaryFileResponse;
+use Symfony\Component\HttpFoundation\File\Exception\FileException;
 use Symfony\Component\HttpFoundation\Request;
 use Symfony\Component\HttpFoundation\ResponseHeaderBag;
 use Symfony\Component\HttpKernel\Exception\NotFoundHttpException;
-use Symfony\Component\HttpFoundation\File\Exception\FileException;
 use Symfony\Component\Validator\Constraints as Assert;
-use Eccube\Util\FilesystemUtil;
-use Symfony\Component\Filesystem\Exception\IOException;
 
 class FileController extends AbstractController
 {

src/Eccube/Controller/Admin/Customer/CustomerController.php

Doc Comments -1 removed lines

@@ -273,7 +273,6 @@
      *
      * @Route("/%eccube_admin_route%/customer/export", name="admin_customer_export")
      *
-     * @param Application $app
      * @param Request $request
      *
      * @return StreamedResponse

Spacing +2 added lines, -2 removed lines

@@ -288,7 +288,7 @@ 
         $em->getConfiguration()->setSQLLogger(null);
 
         $response = new StreamedResponse();
-        $response->setCallback(function () use ($request) {
+        $response->setCallback(function() use ($request) {
             // CSV種別を元に初期化.
             $this->csvExportService->initCsvType(CsvType::CSV_TYPE_CUSTOMER);
 
@@ -301,7 +301,7 @@ 
 
             // データ行の出力.
             $this->csvExportService->setExportQueryBuilder($qb);
-            $this->csvExportService->exportData(function ($entity, $csvService) use ($request) {
+            $this->csvExportService->exportData(function($entity, $csvService) use ($request) {
                 $Csvs = $csvService->getCsvs();
 
                 /** @var $Customer \Eccube\Entity\Customer */

Unused Use Statements +1 added lines, -1 removed lines

@@ -36,8 +36,8 @@
 use Symfony\Component\HttpFoundation\Request;
 use Symfony\Component\HttpFoundation\StreamedResponse;
 use Symfony\Component\HttpKernel\Exception\NotFoundHttpException;
-use Symfony\Component\Translation\TranslatorInterface;
 use Symfony\Component\Routing\Generator\UrlGeneratorInterface;
+use Symfony\Component\Translation\TranslatorInterface;
 
 class CustomerController extends AbstractController
 {