EC-CUBE / ec-cube

src/Eccube/Controller/Admin/Setting/System/MasterdataController.php

Spacing +1 added lines, -1 removed lines

@@ -172,7 +172,7 @@
                 $entity = new $entityName();
                 $sortNo = 0;
                 $ids = array_map(
-                    function ($v) {
+                    function($v) {
                         return $v['id'];
                     },
                     $data['data']

src/Eccube/Service/PluginService.php

Unused Use Statements -1 removed lines

@@ -33,7 +33,6 @@
 use Eccube\Entity\Plugin;
 use Eccube\Entity\PluginEventHandler;
 use Eccube\Exception\PluginException;
-use Eccube\Plugin\ConfigManager;
 use Eccube\Plugin\ConfigManager as PluginConfigManager;
 use Eccube\Repository\PluginEventHandlerRepository;
 use Eccube\Repository\PluginRepository;

Spacing +3 added lines, -3 removed lines

@@ -493,7 +493,7 @@ 
         @mkdir($outputDir);
 
         $enabledPluginCodes = array_map(
-            function ($p) { return $p->getCode(); },
+            function($p) { return $p->getCode(); },
             $this->pluginRepository->findAllEnabled()
         );
 
@@ -508,7 +508,7 @@ 
             }
         }
 
-        $enabledPluginEntityDirs = array_map(function ($code) {
+        $enabledPluginEntityDirs = array_map(function($code) {
             return $this->projectRoot."/app/Plugin/${code}/Entity";
         }, $enabledPluginCodes);
 
@@ -937,7 +937,7 @@ 
     {
         $result = array_keys($packages);
         if ($getVersion) {
-            $result = array_map(function ($package, $version) {
+            $result = array_map(function($package, $version) {
                 return $package.':'.$version;
             }, array_keys($packages), array_values($packages));
         }

Doc Comments +13 added lines, -7 removed lines

@@ -147,7 +147,7 @@ 
      * @param string $path   path to tar.gz/zip plugin file
      * @param int    $source
      *
-     * @return mixed
+     * @return boolean
      *
      * @throws PluginException
      * @throws \Exception
@@ -274,8 +274,8 @@ 
     }
 
     /**
-     * @param $archive
-     * @param $dir
+     * @param string $archive
+     * @param string $dir
      *
      * @throws PluginException
      */
@@ -344,6 +344,9 @@ 
         }
     }
 
+    /**
+     * @param string $yml
+     */
     public function readYml($yml)
     {
         if (file_exists($yml)) {
@@ -361,6 +364,9 @@ 
         // ディレクトリ名などに使われれるので厳しめ
     }
 
+    /**
+     * @param string $path
+     */
     public function deleteFile($path)
     {
         $f = new Filesystem();
@@ -381,7 +387,7 @@ 
     }
 
     /**
-     * @param $d
+     * @param string $d
      *
      * @throws PluginException
      */
@@ -456,7 +462,7 @@ 
 
     /**
      * @param $meta
-     * @param $method
+     * @param string $method
      */
     public function callPluginManagerMethod($meta, $method)
     {
@@ -997,7 +1003,7 @@ 
      * [プラグインコード]/Resource/assets
      * 配下に置かれているファイルが所定の位置へコピーされる
      *
-     * @param $pluginBaseDir
+     * @param string $pluginBaseDir
      * @param $pluginCode
      */
     public function copyAssets($pluginBaseDir, $pluginCode)
@@ -1033,7 +1039,7 @@ 
      * @param string $pluginVersion
      * @param string $remoteVersion
      *
-     * @return mixed
+     * @return boolean
      */
     public function isUpdate($pluginVersion, $remoteVersion)
     {

src/Eccube/ServiceProvider/PurchaseFlowServiceProvider.php

Spacing +12 added lines, -12 removed lines

@@ -17,11 +17,11 @@ 
 {
     public function register(Container $app)
     {
-        $app['eccube.purchase.context'] = $app->protect(function (ItemHolderInterface $origin = null, Customer $user = null) {
+        $app['eccube.purchase.context'] = $app->protect(function(ItemHolderInterface $origin = null, Customer $user = null) {
             return new PurchaseContext($origin, $user);
         });
 
-        $app['eccube.purchase.flow.cart.item_processors'] = function (Container $app) {
+        $app['eccube.purchase.flow.cart.item_processors'] = function(Container $app) {
             $processors = new ArrayCollection();
             $processors[] = new Processor\DisplayStatusValidator();
             $processors[] = new Processor\SaleLimitValidator();
@@ -31,7 +31,7 @@ 
             return $processors;
         };
 
-        $app['eccube.purchase.flow.cart.holder_processors'] = function (Container $app) {
+        $app['eccube.purchase.flow.cart.holder_processors'] = function(Container $app) {
             $processors = new ArrayCollection();
             $processors[] = new Processor\PaymentProcessor($app[DeliveryRepository::class]);
             $processors[] = new Processor\PaymentTotalLimitValidator($app['config']['max_total_fee']);
@@ -41,7 +41,7 @@ 
             return $processors;
         };
 
-        $app['eccube.purchase.flow.cart'] = function (Container $app) {
+        $app['eccube.purchase.flow.cart'] = function(Container $app) {
             $flow = new PurchaseFlow();
             $flow->setItemProcessors($app['eccube.purchase.flow.cart.item_processors']);
             $flow->setItemHolderProcessors($app['eccube.purchase.flow.cart.holder_processors']);
@@ -49,7 +49,7 @@ 
             return $flow;
         };
 
-        $app['eccube.purchase.flow.shopping.item_processors'] = function (Container $app) {
+        $app['eccube.purchase.flow.shopping.item_processors'] = function(Container $app) {
             $processors = new ArrayCollection();
             $processors[] = new Processor\StockValidator();
             $processors[] = new Processor\DisplayStatusValidator();
@@ -57,7 +57,7 @@ 
             return $processors;
         };
 
-        $app['eccube.purchase.flow.shopping.holder_processors'] = function (Container $app) {
+        $app['eccube.purchase.flow.shopping.holder_processors'] = function(Container $app) {
             $processors = new ArrayCollection();
             $processors[] = new Processor\PaymentTotalLimitValidator($app['config']['max_total_fee']);
             $processors[] = new Processor\DeliveryFeeProcessor($app['orm.em']);
@@ -71,7 +71,7 @@ 
             return $processors;
         };
 
-        $app['eccube.purchase.flow.shopping.purchase'] = function (Container $app) {
+        $app['eccube.purchase.flow.shopping.purchase'] = function(Container $app) {
             $processors = new ArrayCollection();
             if ($app[BaseInfo::class]->isOptionPoint()) {
                 $processors[] = new Processor\UsePointToCustomerPurchaseProcessor();
@@ -81,7 +81,7 @@ 
             return $processors;
         };
 
-        $app['eccube.purchase.flow.shopping'] = function (Container $app) {
+        $app['eccube.purchase.flow.shopping'] = function(Container $app) {
             $flow = new PurchaseFlow();
             $flow->setItemProcessors($app['eccube.purchase.flow.shopping.item_processors']);
             $flow->setItemHolderProcessors($app['eccube.purchase.flow.shopping.holder_processors']);
@@ -90,14 +90,14 @@ 
             return $flow;
         };
 
-        $app['eccube.purchase.flow.order.item_processors'] = function (Container $app) {
+        $app['eccube.purchase.flow.order.item_processors'] = function(Container $app) {
             $processors = new ArrayCollection();
             $processors[] = new Processor\StockValidator();
 
             return $processors;
         };
 
-        $app['eccube.purchase.flow.order.holder_processors'] = function (Container $app) {
+        $app['eccube.purchase.flow.order.holder_processors'] = function(Container $app) {
             $processors = new ArrayCollection();
             $processors[] = new Processor\PaymentTotalLimitValidator($app['config']['max_total_fee']);
             $processors[] = new Processor\UpdateDatePurchaseProcessor($app['config']);
@@ -110,7 +110,7 @@ 
             return $processors;
         };
 
-        $app['eccube.purchase.flow.order.purchase'] = function (Container $app) {
+        $app['eccube.purchase.flow.order.purchase'] = function(Container $app) {
             $processors = new ArrayCollection();
             $processors[] = new Processor\AdminOrderRegisterPurchaseProcessor($app);
             $processors[] = new Processor\OrderCodePurchaseProcessor($app['orm.em'], $app['config']['order_code']);
@@ -118,7 +118,7 @@ 
             return $processors;
         };
 
-        $app['eccube.purchase.flow.order'] = function (Container $app) {
+        $app['eccube.purchase.flow.order'] = function(Container $app) {
             $flow = new PurchaseFlow();
             $flow->setItemProcessors($app['eccube.purchase.flow.order.item_processors']);
             $flow->setItemHolderProcessors($app['eccube.purchase.flow.order.holder_processors']);

app/Acme/Controller/RoutingTestController.php

Doc Comments +1 added lines, -1 removed lines

@@ -27,7 +27,7 @@
      *
      * @param Application $app
      *
-     * @return \Symfony\Component\HttpFoundation\Response
+     * @return string
      */
     public function testAdmin(Application $app)
     {

codeception/_support/Interactions/DragAndDropBy.php

Doc Comments +3 added lines

@@ -12,6 +12,9 @@
 
 class DragAndDropBy extends WebDriverActions
 {
+    /**
+     * @param \Facebook\WebDriver\Remote\RemoteWebElement $source
+     */
     public function __construct(WebDriver $driver, $source, $x_offset, $y_offset)
     {
         parent::__construct($driver);

codeception/_support/Interactions/WaitAction.php

Doc Comments +3 added lines

@@ -14,6 +14,9 @@
      */
     private $timeout_in_second;
 
+    /**
+     * @param integer $timeout_in_second
+     */
     function __construct($timeout_in_second)
     {
         $this->timeout_in_second = $timeout_in_second;

codeception/_support/Page/Admin/CustomerManagePage.php

Doc Comments +12 added lines

@@ -48,12 +48,18 @@ 
         return $this;
     }
 
+    /**
+     * @param integer $rowNum
+     */
     public function 一覧_編集($rowNum)
     {
         $this->tester->click("#search_form > div.c-contentsArea__cols > div > div > div.card.rounded.border-0.mb-4 > div > table > tbody > tr:nth-child(${rowNum}) > td:nth-child(2) > a");
         return $this;
     }
 
+    /**
+     * @param integer $rowNum
+     */
     public function 一覧_削除($rowNum, $execute = true)
     {
         $this->tester->click("#search_form > div.c-contentsArea__cols > div > div > div.card.rounded.border-0.mb-4 > div > table > tbody > tr:nth-child(${rowNum}) > td.align-middle.pr-3 > div > div > a");
@@ -67,6 +73,9 @@ 
         return $this;
     }
 
+    /**
+     * @param integer $rowNum
+     */
     public function 一覧_仮会員メール再送($rowNum)
     {
         $this->tester->click(['xpath' => "//*[@id='search_form']//div/table/tbody/tr[${rowNum}]/td[6]/div/div[1]/a"]);
@@ -92,6 +101,9 @@ 
         $this->tester->click('#search_form > div.c-contentsArea__cols > div > div > div.row.justify-content-between.mb-2 > div.col-5.text-right > div:nth-child(2) > div > button:nth-child(2)');
     }
 
+    /**
+     * @param integer $rowNum
+     */
     public function 一覧_会員ID($rowNum)
     {
         return $this->tester->grabTextFrom("#search_form > div.c-contentsArea__cols > div > div > div.card.rounded.border-0.mb-4 > div > table > tbody > tr:nth-child(${rowNum}) > td.align-middle.pl-3");

codeception/_support/Page/Admin/ShippingEditPage.php

Doc Comments +51 added lines

@@ -19,6 +19,9 @@ 
         parent::__construct($I);
     }
 
+    /**
+     * @param \AcceptanceTester $I
+     */
     public static function go($I)
     {
         $page = new self($I);
@@ -26,6 +29,9 @@ 
         return $page;
     }
 
+    /**
+     * @param \AcceptanceTester $I
+     */
     public static function at($I)
     {
         $page = new self($I);
@@ -46,36 +52,54 @@ 
         return $this;
     }
 
+    /**
+     * @param string $value
+     */
     public function 入力_姓($value)
     {
         $this->tester->fillField(['id' => 'shipping_name_name01'], $value);
         return $this;
     }
 
+    /**
+     * @param string $value
+     */
     public function 入力_名($value)
     {
         $this->tester->fillField(['id' => 'shipping_name_name02'], $value);
         return $this;
     }
 
+    /**
+     * @param string $value
+     */
     public function 入力_セイ($value)
     {
         $this->tester->fillField(['id' => 'shipping_kana_kana01'], $value);
         return $this;
     }
 
+    /**
+     * @param string $value
+     */
     public function 入力_メイ($value)
     {
         $this->tester->fillField(['id' => 'shipping_kana_kana02'], $value);
         return $this;
     }
 
+    /**
+     * @param string $value
+     */
     public function 入力_郵便番号1($value)
     {
         $this->tester->fillField(['id' => 'shipping_zip_zip01'], $value);
         return $this;
     }
 
+    /**
+     * @param string $value
+     */
     public function 入力_郵便番号2($value)
     {
         $this->tester->fillField(['id' => 'shipping_zip_zip02'], $value);
@@ -88,48 +112,72 @@ 
         return $this;
     }
 
+    /**
+     * @param string $value
+     */
     public function 入力_市区町村名($value)
     {
         $this->tester->fillField(['id' => 'shipping_address_addr01'], $value);
         return $this;
     }
 
+    /**
+     * @param string $value
+     */
     public function 入力_番地_ビル名($value)
     {
         $this->tester->fillField(['id' => 'shipping_address_addr02'], $value);
         return $this;
     }
 
+    /**
+     * @param string $value
+     */
     public function 入力_電話番号1($value)
     {
         $this->tester->fillField(['id' => 'shipping_tel_tel01'], $value);
         return $this;
     }
 
+    /**
+     * @param string $value
+     */
     public function 入力_電話番号2($value)
     {
         $this->tester->fillField(['id' => 'shipping_tel_tel02'], $value);
         return $this;
     }
 
+    /**
+     * @param string $value
+     */
     public function 入力_電話番号3($value)
     {
         $this->tester->fillField(['id' => 'shipping_tel_tel03'], $value);
         return $this;
     }
 
+    /**
+     * @param string $value
+     */
     public function 入力_出荷伝票番号($value)
     {
         $this->tester->fillField(['id' => 'shipping_tracking_number'], $value);
         return $this;
     }
 
+    /**
+     * @param string[] $value
+     */
     public function 入力_配送業者($value)
     {
         $this->tester->selectOption(['id' => 'shipping_Delivery'], $value);
         return $this;
     }
 
+    /**
+     * @param string $value
+     */
     public function 入力_配達用メモ($value)
     {
         $this->tester->fillField(['id' => 'shipping_note'], $value);
@@ -144,6 +192,9 @@ 
         return $this;
     }
 
+    /**
+     * @param integer $rowNum
+     */
     public function 商品検索結果_選択($rowNum)
     {
         $this->tester->click(['xpath' => "//*[@id='searchItemsResult']/table/tbody/tr[${rowNum}]/td[5]/i"]);

codeception/_support/Page/Admin/ShippingManagePage.php

Doc Comments +6 added lines

@@ -58,6 +58,9 @@ 
         return $this;
     }
 
+    /**
+     * @param integer $rowNum
+     */
     public function 一覧_編集($rowNum)
     {
         $this->tester->click(['xpath' => "//*[@id='form_bulk']/div[2]/div/table/tbody/tr[${rowNum}]/td[2]/a"]);
@@ -117,6 +120,9 @@ 
         $this->tester->click('#form_bulk #btn_bulk_mail');
     }
 
+    /**
+     * @param integer $rowNum
+     */
     public function 一覧_チェックボックス($rowNum)
     {
         $this->tester->click(['xpath' => "//*[@id='form_bulk']/div[2]/div/table/tbody/tr[${rowNum}]/td[1]/input"]);