Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
Complex classes like CartService often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use CartService, and based on these observations, apply Extract Interface, too.
| 1 | <?php |
||
| 33 | class CartService |
||
|
|
|||
| 34 | { |
||
| 35 | /** |
||
| 36 | * @var Cart[] |
||
| 37 | */ |
||
| 38 | protected $carts; |
||
| 39 | |||
| 40 | /** |
||
| 41 | * @var SessionInterface |
||
| 42 | */ |
||
| 43 | protected $session; |
||
| 44 | |||
| 45 | /** |
||
| 46 | * @var \Doctrine\ORM\EntityManagerInterface |
||
| 47 | */ |
||
| 48 | protected $entityManager; |
||
| 49 | |||
| 50 | /** |
||
| 51 | * @var ItemHolderInterface |
||
| 52 | * |
||
| 53 | * @deprecated |
||
| 54 | */ |
||
| 55 | protected $cart; |
||
| 56 | |||
| 57 | /** |
||
| 58 | * @var ProductClassRepository |
||
| 59 | */ |
||
| 60 | protected $productClassRepository; |
||
| 61 | |||
| 62 | /** |
||
| 63 | * @var CartRepository |
||
| 64 | */ |
||
| 65 | protected $cartRepository; |
||
| 66 | |||
| 67 | /** |
||
| 68 | * @var CartItemComparator |
||
| 69 | */ |
||
| 70 | protected $cartItemComparator; |
||
| 71 | |||
| 72 | /** |
||
| 73 | * @var CartItemAllocator |
||
| 74 | */ |
||
| 75 | protected $cartItemAllocator; |
||
| 76 | |||
| 77 | /** |
||
| 78 | * @var OrderHelper |
||
| 79 | */ |
||
| 80 | protected $orderHelper; |
||
| 81 | |||
| 82 | /** |
||
| 83 | * @var OrderRepository |
||
| 84 | */ |
||
| 85 | protected $orderRepository; |
||
| 86 | |||
| 87 | /** |
||
| 88 | * @var TokenStorageInterface |
||
| 89 | */ |
||
| 90 | protected $tokenStorage; |
||
| 91 | |||
| 92 | /** |
||
| 93 | * @var AuthorizationCheckerInterface |
||
| 94 | */ |
||
| 95 | protected $authorizationChecker; |
||
| 96 | |||
| 97 | /** |
||
| 98 | * CartService constructor. |
||
| 99 | * |
||
| 100 | * @param SessionInterface $session |
||
| 101 | * @param EntityManagerInterface $entityManager |
||
| 102 | * @param ProductClassRepository $productClassRepository |
||
| 103 | * @param CartItemComparator $cartItemComparator |
||
| 104 | * @param CartItemAllocator $cartItemAllocator |
||
| 105 | * @param OrderHelper $orderHelper |
||
| 106 | * @param TokenStorageInterface $tokenStorage |
||
| 107 | * @param AuthorizationCheckerInterface $authorizationChecker |
||
| 108 | */ |
||
| 109 | 171 | public function __construct( |
|
| 132 | |||
| 133 | 131 | public function getCarts() |
|
| 144 | |||
| 145 | /** |
||
| 146 | * 会員が保持する永続化されたカートと、非会員時のカートをマージする. |
||
| 147 | * |
||
| 148 | * @param Customer $Customer |
||
| 149 | */ |
||
| 150 | public function mergeFromPersistedCart(Customer $Customer) |
||
| 163 | |||
| 164 | /** |
||
| 165 | * @return ItemHolderInterface|Cart |
||
| 166 | */ |
||
| 167 | 65 | public function getCart() |
|
| 177 | |||
| 178 | /** |
||
| 179 | * @param CartItem[] $cartItems |
||
| 180 | * |
||
| 181 | * @return CartItem[] |
||
| 182 | */ |
||
| 183 | 86 | protected function mergeAllCartItems($cartItems = []) |
|
| 194 | |||
| 195 | /** |
||
| 196 | * @param $cartItems |
||
| 197 | * @param $allCartItems |
||
| 198 | * |
||
| 199 | * @return array |
||
| 200 | */ |
||
| 201 | 86 | protected function mergeCartItems($cartItems, $allCartItems) |
|
| 220 | |||
| 221 | 86 | protected function restoreCarts($cartItems) |
|
| 267 | |||
| 268 | /** |
||
| 269 | * カートに商品を追加します. |
||
| 270 | * |
||
| 271 | * @param $ProductClass ProductClass 商品規格 |
||
| 272 | * @param $quantity int 数量 |
||
| 273 | * |
||
| 274 | * @return bool 商品を追加できた場合はtrue |
||
| 275 | */ |
||
| 276 | 85 | public function addProduct($ProductClass, $quantity = 1) |
|
| 307 | |||
| 308 | 2 | public function removeProduct($ProductClass) |
|
| 338 | |||
| 339 | 80 | public function save() |
|
| 357 | |||
| 358 | /** |
||
| 359 | * @param string $pre_order_id |
||
| 360 | * |
||
| 361 | * @return \Eccube\Service\CartService |
||
| 362 | */ |
||
| 363 | 52 | public function setPreOrderId($pre_order_id) |
|
| 369 | |||
| 370 | /** |
||
| 371 | * @return string |
||
| 372 | */ |
||
| 373 | 51 | public function getPreOrderId() |
|
| 377 | |||
| 378 | /** |
||
| 379 | * @return \Eccube\Service\CartService |
||
| 380 | */ |
||
| 381 | 10 | public function clear() |
|
| 402 | |||
| 403 | /** |
||
| 404 | * @param CartItemComparator $cartItemComparator |
||
| 405 | */ |
||
| 406 | 1 | public function setCartItemComparator($cartItemComparator) |
|
| 410 | |||
| 411 | /** |
||
| 412 | * 指定したインデックスにあるカートを優先にする |
||
| 413 | * |
||
| 414 | * @param int $index カートのインデックス |
||
| 415 | */ |
||
| 416 | 53 | public function setPrimary($index = 0) |
|
| 426 | |||
| 427 | 85 | protected function getUser() |
|
| 440 | |||
| 441 | 85 | protected function createCartKey($allocatedId, Customer $Customer = null) |
|
| 461 | } |
||
| 462 |