CartController::down() - Code Metrics - Inspection of "カート追加、購入時のバリデーション修正" - EC-CUBE/ec-cube - Measure and Improve Code Quality continuously with Scrutinizer

Failed Conditions

Pull Request — master (#1665)

by k-yamamura

created 2016-11-21 01:35 UTC

CartController::down() A

↳ Parent: CartController

Complexity

Conditions	4
Paths	18

Size

Total Lines	56
Code Lines	30

Duplication

Lines	56
Ratio	100 %

Code Coverage

Tests	21
CRAP Score	4.0105

Importance

Changes

Metric	Value
cc	4
eloc	30
nc	18
nop	3
dl	56
loc	56
ccs	21
cts	23
cp	0.913
crap	4.0105
rs	9.0544
c	0
b	0
f	0

How to fix Long Method

<?php
/*
 * This file is part of EC-CUBE
 *
 * Copyright(c) 2000-2015 LOCKON CO.,LTD. All Rights Reserved.
 *
 * http://www.lockon.co.jp/
 *
 * This program is free software; you can redistribute it and/or
 * modify it under the terms of the GNU General Public License
 * as published by the Free Software Foundation; either version 2
 * of the License, or (at your option) any later version.
 *
 * This program is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 * GNU General Public License for more details.
 *
 * You should have received a copy of the GNU General Public License
 * along with this program; if not, write to the Free Software
 * Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA  02111-1307, USA.
 */


namespace Eccube\Controller;

use Eccube\Application;
use Eccube\Event\EccubeEvents;
use Eccube\Event\EventArgs;
use Eccube\Exception\CartException;
use Symfony\Component\HttpFoundation\Request;

class CartController extends AbstractController

{
    /**
     * カート画面.
     *
     * @param Application $app
     * @param Request $request

     * @return \Symfony\Component\HttpFoundation\Response
     */
    public function index(Application $app, Request $request)
    {
        $Cart = $app['eccube.service.cart']->getCart();

        // FRONT_CART_INDEX_INITIALIZE
        $event = new EventArgs(
            array(),
            $request
        );
        $app['eccube.event.dispatcher']->dispatch(EccubeEvents::FRONT_CART_INDEX_INITIALIZE, $event);

        /* @var $BaseInfo \Eccube\Entity\BaseInfo */
        /* @var $Cart \Eccube\Entity\Cart */
        $BaseInfo = $app['eccube.repository.base_info']->get();

        $isDeliveryFree = false;
        $least = 0;
        $quantity = 0;
        if ($BaseInfo->getDeliveryFreeAmount()) {
            if ($BaseInfo->getDeliveryFreeAmount() <= $Cart->getTotalPrice()) {
                // 送料無料（金額）を超えている
                $isDeliveryFree = true;
            } else {
                $least = $BaseInfo->getDeliveryFreeAmount() - $Cart->getTotalPrice();
            }
        }

        if ($BaseInfo->getDeliveryFreeQuantity()) {
            if ($BaseInfo->getDeliveryFreeQuantity() <= $Cart->getTotalQuantity()) {
                // 送料無料（個数）を超えている
                $isDeliveryFree = true;
            } else {
                $quantity = $BaseInfo->getDeliveryFreeQuantity() - $Cart->getTotalQuantity();
            }
        }

        // FRONT_CART_INDEX_COMPLETE
        $event = new EventArgs(
            array(),
            $request
        );
        $app['eccube.event.dispatcher']->dispatch(EccubeEvents::FRONT_CART_INDEX_COMPLETE, $event);

        if ($event->hasResponse()) {
            return $event->getResponse();
        }

        return $app->render(
            'Cart/index.twig',
            array(
                'Cart' => $Cart,
                'least' => $least,
                'quantity' => $quantity,
                'is_delivery_free' => $isDeliveryFree,
            )
        );
    }

    /**
     * カートに商品を追加する.
     *
     * @param Application $app
     * @param Request $request

     * @return \Symfony\Component\HttpFoundation\RedirectResponse|\Symfony\Component\HttpFoundation\Response
     */
    public function add(Application $app, Request $request)
    {
        $productClassId = $request->get('product_class_id');
        $quantity = $request->request->has('quantity') ? $request->get('quantity') : 1;

        // FRONT_CART_ADD_INITIALIZE
        $event = new EventArgs(
            array(
                'productClassId' => $productClassId,
                'quantity' => $quantity,
            ),
            $request
        );
        $app['eccube.event.dispatcher']->dispatch(EccubeEvents::FRONT_CART_ADD_INITIALIZE, $event);

        try {


            $productClassId = $event->getArgument('productClassId');
            $quantity = $event->getArgument('quantity');

            log_info('カート追加処理開始', array('product_class_id' => $productClassId, 'quantity' => $quantity));

            $app['eccube.service.cart']->addProduct($productClassId, $quantity)->save();

            log_info('カート追加処理完了', array('product_class_id' => $productClassId, 'quantity' => $quantity));

            // FRONT_CART_ADD_COMPLETE
            $event = new EventArgs(
                array(
                    'productClassId' => $productClassId,
                    'quantity' => $quantity,
                ),
                $request
            );
            $app['eccube.event.dispatcher']->dispatch(EccubeEvents::FRONT_CART_ADD_COMPLETE, $event);

            if ($event->hasResponse()) {
                return $event->getResponse();
            }


        } catch (CartException $e) {


            log_info('カート追加エラー', array($e->getMessage()));

            // FRONT_CART_ADD_EXCEPTION
            $event = new EventArgs(
                array(
                    'exception' => $e,
                ),
                $request
            );
            $app['eccube.event.dispatcher']->dispatch(EccubeEvents::FRONT_CART_ADD_EXCEPTION, $event);

            if ($event->hasResponse()) {
                return $event->getResponse();
            }

            $app->addRequestError($e->getMessage());
        }

        return $app->redirect($app->url('cart'));
    }

    /**

     * カートに入っている商品の個数を1増やす.
     *
     * @param Application $app

     * @param Request $request

     * @param $productClassId

     * @return \Symfony\Component\HttpFoundation\RedirectResponse|\Symfony\Component\HttpFoundation\Response
     */
    public function up(Application $app, Request $request, $productClassId)

    {
        $this->isTokenValid($app);

        // FRONT_CART_UP_INITIALIZE
        $event = new EventArgs(
            array(
                'productClassId' => $productClassId,
            ),
            $request
        );
        $app['eccube.event.dispatcher']->dispatch(EccubeEvents::FRONT_CART_UP_INITIALIZE, $event);

        try {


            log_info('カート加算処理開始', array('product_class_id' => $productClassId));

            $productClassId = $event->getArgument('productClassId');

            $app['eccube.service.cart']->upProductQuantity($productClassId)->save();

            // FRONT_CART_UP_COMPLETE
            $event = new EventArgs(
                array(
                    'productClassId' => $productClassId,
                ),
                $request
            );
            $app['eccube.event.dispatcher']->dispatch(EccubeEvents::FRONT_CART_UP_COMPLETE, $event);

            if ($event->hasResponse()) {
                return $event->getResponse();
            }

            log_info('カート加算処理完了', array('product_class_id' => $productClassId));


        } catch (CartException $e) {


            log_info('カート加算エラー', array($e->getMessage()));

            // FRONT_CART_UP_EXCEPTION
            $event = new EventArgs(
                array(
                    'exception' => $e,
                ),
                $request
            );
            $app['eccube.event.dispatcher']->dispatch(EccubeEvents::FRONT_CART_UP_EXCEPTION, $event);

            if ($event->hasResponse()) {
                return $event->getResponse();
            }

            $app->addRequestError($e->getMessage());
        }

        return $app->redirect($app->url('cart'));
    }

    /**

     * カートに入っている商品の個数を1減らす.
     * マイナスになる場合は, 商品をカートから削除する.
     *
     * @param Application $app

     * @param Request $request

     * @param $productClassId

     * @return \Symfony\Component\HttpFoundation\RedirectResponse|\Symfony\Component\HttpFoundation\Response
     */
    public function down(Application $app, Request $request, $productClassId)

    {
        $this->isTokenValid($app);

        // FRONT_CART_DOWN_INITIALIZE
        $event = new EventArgs(
            array(
                'productClassId' => $productClassId,
            ),
            $request
        );
        $app['eccube.event.dispatcher']->dispatch(EccubeEvents::FRONT_CART_DOWN_INITIALIZE, $event);

        try {


            log_info('カート減算処理開始', array('product_class_id' => $productClassId));

            $productClassId = $event->getArgument('productClassId');
            $app['eccube.service.cart']->downProductQuantity($productClassId)->save();

            // FRONT_CART_UP_COMPLETE
            $event = new EventArgs(
                array(
                    'productClassId' => $productClassId,
                ),
                $request
            );
            $app['eccube.event.dispatcher']->dispatch(EccubeEvents::FRONT_CART_DOWN_COMPLETE, $event);

            if ($event->hasResponse()) {
                return $event->getResponse();
            }

            log_info('カート減算処理完了', array('product_class_id' => $productClassId));


        } catch (CartException $e) {
            log_info('カート減算エラー', array($e->getMessage()));

            // FRONT_CART_DOWN_EXCEPTION
            $event = new EventArgs(
                array(
                    'exception' => $e,
                ),
                $request
            );
            $app['eccube.event.dispatcher']->dispatch(EccubeEvents::FRONT_CART_DOWN_EXCEPTION, $event);

            if ($event->hasResponse()) {
                return $event->getResponse();
            }

            $app->addRequestError($e->getMessage());
        }

        return $app->redirect($app->url('cart'));
    }

    /**

     * カートに入っている商品を削除する.
     *
     * @param Application $app

     * @param Request $request

     * @param $productClassId

     * @return \Symfony\Component\HttpFoundation\RedirectResponse|\Symfony\Component\HttpFoundation\Response
     */
    public function remove(Application $app, Request $request, $productClassId)
    {
        $this->isTokenValid($app);

        log_info('カート削除処理開始', array('product_class_id' => $productClassId));

        // FRONT_CART_REMOVE_INITIALIZE
        $event = new EventArgs(
            array(
                'productClassId' => $productClassId,
            ),
            $request
        );
        $app['eccube.event.dispatcher']->dispatch(EccubeEvents::FRONT_CART_REMOVE_INITIALIZE, $event);

        $productClassId = $event->getArgument('productClassId');
        $app['eccube.service.cart']->removeProduct($productClassId)->save();

        log_info('カート削除処理完了', array('product_class_id' => $productClassId));

        // FRONT_CART_REMOVE_COMPLETE
        $event = new EventArgs(
            array(
                'productClassId' => $productClassId,
            ),
            $request
        );
        $app['eccube.event.dispatcher']->dispatch(EccubeEvents::FRONT_CART_REMOVE_COMPLETE, $event);

        if ($event->hasResponse()) {
            return $event->getResponse();
        }

        return $app->redirect($app->url('cart'));
    }

    /**

     * カートに商品を個数を指定して設定する.
     *
     * @param Application $app

     * @param Request $request

     * @param $productClassId

     * @param $quantity

     * @return \Symfony\Component\HttpFoundation\RedirectResponse|\Symfony\Component\HttpFoundation\Response
     * @throws CartException
     *
     * @deprecated since 3.0.0, to be removed in 3.1
     */
    public function setQuantity(Application $app, Request $request, $productClassId, $quantity)

    {
        $this->isTokenValid($app);

        $app['eccube.service.cart']->setProductQuantity($productClassId, $quantity)->save();

        return $app->redirect($app->url('cart'));
    }

    /**
     * カートをロック状態に設定し、購入確認画面へ遷移する.
     *
     * @param Application $app
     * @param Request $request

     * @return \Symfony\Component\HttpFoundation\RedirectResponse|\Symfony\Component\HttpFoundation\Response
     */
    public function buystep(Application $app, Request $request)
    {
        // FRONT_CART_BUYSTEP_INITIALIZE
        $event = new EventArgs(
            array(),
            $request
        );
        $app['eccube.event.dispatcher']->dispatch(EccubeEvents::FRONT_CART_BUYSTEP_INITIALIZE, $event);

        $app['eccube.service.cart']->lock();
        $app['eccube.service.cart']->save();

        // FRONT_CART_BUYSTEP_COMPLETE
        $event = new EventArgs(
            array(),
            $request
        );
        $app['eccube.event.dispatcher']->dispatch(EccubeEvents::FRONT_CART_BUYSTEP_COMPLETE, $event);

        if ($event->hasResponse()) {
            return $event->getResponse();
        }

        return $app->redirect($app->url('shopping'));
    }
}


1			<?php
2			/*
3			* This file is part of EC-CUBE
4			*
5			* Copyright(c) 2000-2015 LOCKON CO.,LTD. All Rights Reserved.
6			*
7			* http://www.lockon.co.jp/
8			*
9			* This program is free software; you can redistribute it and/or
10			* modify it under the terms of the GNU General Public License
11			* as published by the Free Software Foundation; either version 2
12			* of the License, or (at your option) any later version.
13			*
14			* This program is distributed in the hope that it will be useful,
15			* but WITHOUT ANY WARRANTY; without even the implied warranty of
16			* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
17			* GNU General Public License for more details.
18			*
19			* You should have received a copy of the GNU General Public License
20			* along with this program; if not, write to the Free Software
21			* Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA.
22			*/
23
24
25			namespace Eccube\Controller;
26
27			use Eccube\Application;
28			use Eccube\Event\EccubeEvents;
29			use Eccube\Event\EventArgs;
30			use Eccube\Exception\CartException;
31			use Symfony\Component\HttpFoundation\Request;
32
33			class CartController extends AbstractController
			0 ignored issues – show introduced 2015-11-21 02:41 UTC by Report Bug Copy Issue Report Missing class doc comment Loading history...
34			{
35			/**
36			* カート画面.
37			*
38			* @param Application $app
39			* @param Request $request
			0 ignored issues – show introduced 2016-02-14 23:45 UTC by Report Bug Copy Issue Report Expected 5 spaces after parameter type; 1 found Loading history...
40			* @return \Symfony\Component\HttpFoundation\Response
41			*/
42	31		public function index(Application $app, Request $request)
43			{
44	31		$Cart = $app['eccube.service.cart']->getCart();
45
46			// FRONT_CART_INDEX_INITIALIZE
47	31		$event = new EventArgs(
48	31		array(),
49			$request
50			);
51	31		$app['eccube.event.dispatcher']->dispatch(EccubeEvents::FRONT_CART_INDEX_INITIALIZE, $event);
52
53			/* @var $BaseInfo \Eccube\Entity\BaseInfo */
54			/* @var $Cart \Eccube\Entity\Cart */
55	31		$BaseInfo = $app['eccube.repository.base_info']->get();
56
57	31		$isDeliveryFree = false;
58	31		$least = 0;
59	31		$quantity = 0;
60	31		if ($BaseInfo->getDeliveryFreeAmount()) {
61			if ($BaseInfo->getDeliveryFreeAmount() <= $Cart->getTotalPrice()) {
62			// 送料無料（金額）を超えている
63			$isDeliveryFree = true;
64			} else {
65			$least = $BaseInfo->getDeliveryFreeAmount() - $Cart->getTotalPrice();
66			}
67			}
68
69	31		if ($BaseInfo->getDeliveryFreeQuantity()) {
70			if ($BaseInfo->getDeliveryFreeQuantity() <= $Cart->getTotalQuantity()) {
71			// 送料無料（個数）を超えている
72			$isDeliveryFree = true;
73			} else {
74			$quantity = $BaseInfo->getDeliveryFreeQuantity() - $Cart->getTotalQuantity();
75			}
76			}
77
78			// FRONT_CART_INDEX_COMPLETE
79	31		$event = new EventArgs(
80	31		array(),
81			$request
82			);
83	31		$app['eccube.event.dispatcher']->dispatch(EccubeEvents::FRONT_CART_INDEX_COMPLETE, $event);
84
85	31		if ($event->hasResponse()) {
86			return $event->getResponse();
87			}
88
89	31		return $app->render(
90	31		'Cart/index.twig',
91			array(
92	31		'Cart' => $Cart,
93	31		'least' => $least,
94	31		'quantity' => $quantity,
95	31		'is_delivery_free' => $isDeliveryFree,
96			)
97			);
98			}
99
100			/**
101			* カートに商品を追加する.
102			*
103			* @param Application $app
104			* @param Request $request
			0 ignored issues – show introduced 2016-02-16 07:15 UTC by Report Bug Copy Issue Report Expected 5 spaces after parameter type; 1 found Loading history...
105			* @return \Symfony\Component\HttpFoundation\RedirectResponse\|\Symfony\Component\HttpFoundation\Response
106			*/
107	76		public function add(Application $app, Request $request)
108			{
109	76		$productClassId = $request->get('product_class_id');
110	76		$quantity = $request->request->has('quantity') ? $request->get('quantity') : 1;
111
112			// FRONT_CART_ADD_INITIALIZE
113	76		$event = new EventArgs(
114			array(
115	76		'productClassId' => $productClassId,
116	76		'quantity' => $quantity,
117			),
118			$request
119			);
120	76		$app['eccube.event.dispatcher']->dispatch(EccubeEvents::FRONT_CART_ADD_INITIALIZE, $event);
121
122			try {
			0 ignored issues – show Coding Style introduced 2016-03-01 10:06 UTC by Report Bug Copy Issue Report Blank line found at start of control structure Loading history...
123
124	76		$productClassId = $event->getArgument('productClassId');
125	76		$quantity = $event->getArgument('quantity');
126
127	76		log_info('カート追加処理開始', array('product_class_id' => $productClassId, 'quantity' => $quantity));
128
129	76		$app['eccube.service.cart']->addProduct($productClassId, $quantity)->save();
130
131	75		log_info('カート追加処理完了', array('product_class_id' => $productClassId, 'quantity' => $quantity));
132
133			// FRONT_CART_ADD_COMPLETE
134	75		$event = new EventArgs(
135			array(
136	75		'productClassId' => $productClassId,
137	75		'quantity' => $quantity,
138			),
139			$request
140			);
141	75		$app['eccube.event.dispatcher']->dispatch(EccubeEvents::FRONT_CART_ADD_COMPLETE, $event);
142
143	75		if ($event->hasResponse()) {
144	75		return $event->getResponse();
145			}
146
			0 ignored issues – show Coding Style introduced 2016-10-25 11:16 UTC by Report Bug Copy Issue Report Blank line found at end of control structure Loading history...
147	1		} catch (CartException $e) {
			0 ignored issues – show Coding Style introduced 2016-10-25 11:16 UTC by Report Bug Copy Issue Report Blank line found at start of control structure Loading history...
148
149	1		log_info('カート追加エラー', array($e->getMessage()));
150
151			// FRONT_CART_ADD_EXCEPTION
152	1		$event = new EventArgs(
153			array(
154	1		'exception' => $e,
155			),
156			$request
157			);
158	1		$app['eccube.event.dispatcher']->dispatch(EccubeEvents::FRONT_CART_ADD_EXCEPTION, $event);
159
160	1		if ($event->hasResponse()) {
161			return $event->getResponse();
162			}
163
164	1		$app->addRequestError($e->getMessage());
165			}
166
167	76		return $app->redirect($app->url('cart'));
168			}
169
170			/**
			0 ignored issues – show introduced 2016-10-25 11:16 UTC by Report Bug Copy Issue Report Doc comment for parameter "$productClassId" missing Loading history...
171			* カートに入っている商品の個数を1増やす.
172			*
173			* @param Application $app
			0 ignored issues – show introduced 2016-10-25 11:16 UTC by Report Bug Copy Issue Report Expected 4 spaces after parameter type; 1 found Loading history...
174			* @param Request $request
			0 ignored issues – show introduced 2016-10-25 11:16 UTC by Report Bug Copy Issue Report Expected 8 spaces after parameter type; 1 found Loading history...
175			* @param $productClassId
			0 ignored issues – show introduced 2016-10-25 11:16 UTC by Report Bug Copy Issue Report Missing parameter name Loading history...
176			* @return \Symfony\Component\HttpFoundation\RedirectResponse\|\Symfony\Component\HttpFoundation\Response
177			*/
178	9	View Code Duplication	public function up(Application $app, Request $request, $productClassId)
			0 ignored issues – show Duplication introduced 2016-02-14 23:45 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
179			{
180	9		$this->isTokenValid($app);
181
182			// FRONT_CART_UP_INITIALIZE
183	9		$event = new EventArgs(
184			array(
185	9		'productClassId' => $productClassId,
186			),
187			$request
188			);
189	9		$app['eccube.event.dispatcher']->dispatch(EccubeEvents::FRONT_CART_UP_INITIALIZE, $event);
190
191			try {
			0 ignored issues – show Coding Style introduced 2016-03-01 10:06 UTC by Report Bug Copy Issue Report Blank line found at start of control structure Loading history...
192
193	9		log_info('カート加算処理開始', array('product_class_id' => $productClassId));
194
195	9		$productClassId = $event->getArgument('productClassId');
196
197	9		$app['eccube.service.cart']->upProductQuantity($productClassId)->save();
198
199			// FRONT_CART_UP_COMPLETE
200	6		$event = new EventArgs(
201			array(
202	6		'productClassId' => $productClassId,
203			),
204			$request
205			);
206	6		$app['eccube.event.dispatcher']->dispatch(EccubeEvents::FRONT_CART_UP_COMPLETE, $event);
207
208	6		if ($event->hasResponse()) {
209			return $event->getResponse();
210			}
211
212	6		log_info('カート加算処理完了', array('product_class_id' => $productClassId));
213
			0 ignored issues – show Coding Style introduced 2016-10-25 11:16 UTC by Report Bug Copy Issue Report Blank line found at end of control structure Loading history...
214	3		} catch (CartException $e) {
			0 ignored issues – show Coding Style introduced 2016-10-25 11:16 UTC by Report Bug Copy Issue Report Blank line found at start of control structure Loading history...
215
216	3		log_info('カート加算エラー', array($e->getMessage()));
217
218			// FRONT_CART_UP_EXCEPTION
219	3		$event = new EventArgs(
220			array(
221	3		'exception' => $e,
222			),
223			$request
224			);
225	3		$app['eccube.event.dispatcher']->dispatch(EccubeEvents::FRONT_CART_UP_EXCEPTION, $event);
226
227	3		if ($event->hasResponse()) {
228			return $event->getResponse();
229			}
230
231	3		$app->addRequestError($e->getMessage());
232			}
233
234	9		return $app->redirect($app->url('cart'));
235			}
236
237			/**
			0 ignored issues – show introduced 2016-10-25 11:16 UTC by Report Bug Copy Issue Report Doc comment for parameter "$productClassId" missing Loading history...
238			* カートに入っている商品の個数を1減らす.
239			* マイナスになる場合は, 商品をカートから削除する.
240			*
241			* @param Application $app
			0 ignored issues – show introduced 2016-10-25 11:16 UTC by Report Bug Copy Issue Report Expected 4 spaces after parameter type; 1 found Loading history...
242			* @param Request $request
			0 ignored issues – show introduced 2016-10-25 11:16 UTC by Report Bug Copy Issue Report Expected 8 spaces after parameter type; 1 found Loading history...
243			* @param $productClassId
			0 ignored issues – show introduced 2016-10-25 11:16 UTC by Report Bug Copy Issue Report Missing parameter name Loading history...
244			* @return \Symfony\Component\HttpFoundation\RedirectResponse\|\Symfony\Component\HttpFoundation\Response
245			*/
246	9	View Code Duplication	public function down(Application $app, Request $request, $productClassId)
			0 ignored issues – show Duplication introduced 2016-02-14 23:45 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
247			{
248	9		$this->isTokenValid($app);
249
250			// FRONT_CART_DOWN_INITIALIZE
251	9		$event = new EventArgs(
252			array(
253	9		'productClassId' => $productClassId,
254			),
255			$request
256			);
257	9		$app['eccube.event.dispatcher']->dispatch(EccubeEvents::FRONT_CART_DOWN_INITIALIZE, $event);
258
259			try {
			0 ignored issues – show Coding Style introduced 2016-10-25 11:16 UTC by Report Bug Copy Issue Report Blank line found at start of control structure Loading history...
260
261	9		log_info('カート減算処理開始', array('product_class_id' => $productClassId));
262
263	9		$productClassId = $event->getArgument('productClassId');
264	9		$app['eccube.service.cart']->downProductQuantity($productClassId)->save();
265
266			// FRONT_CART_UP_COMPLETE
267	7		$event = new EventArgs(
268			array(
269	7		'productClassId' => $productClassId,
270			),
271			$request
272			);
273	7		$app['eccube.event.dispatcher']->dispatch(EccubeEvents::FRONT_CART_DOWN_COMPLETE, $event);
274
275	7		if ($event->hasResponse()) {
276			return $event->getResponse();
277			}
278
279	7		log_info('カート減算処理完了', array('product_class_id' => $productClassId));
280
			0 ignored issues – show Coding Style introduced 2016-10-25 11:16 UTC by Report Bug Copy Issue Report Blank line found at end of control structure Loading history...
281	2		} catch (CartException $e) {
282	2		log_info('カート減算エラー', array($e->getMessage()));
283
284			// FRONT_CART_DOWN_EXCEPTION
285	2		$event = new EventArgs(
286			array(
287	2		'exception' => $e,
288			),
289			$request
290			);
291	2		$app['eccube.event.dispatcher']->dispatch(EccubeEvents::FRONT_CART_DOWN_EXCEPTION, $event);
292
293	2		if ($event->hasResponse()) {
294			return $event->getResponse();
295			}
296
297	2		$app->addRequestError($e->getMessage());
298			}
299
300	9		return $app->redirect($app->url('cart'));
301			}
302
303			/**
			0 ignored issues – show introduced 2016-10-25 11:16 UTC by Report Bug Copy Issue Report Doc comment for parameter "$productClassId" missing Loading history...
304			* カートに入っている商品を削除する.
305			*
306			* @param Application $app
			0 ignored issues – show introduced 2016-10-25 11:16 UTC by Report Bug Copy Issue Report Expected 4 spaces after parameter type; 1 found Loading history...
307			* @param Request $request
			0 ignored issues – show introduced 2016-10-25 11:16 UTC by Report Bug Copy Issue Report Expected 8 spaces after parameter type; 1 found Loading history...
308			* @param $productClassId
			0 ignored issues – show introduced 2016-10-25 11:16 UTC by Report Bug Copy Issue Report Missing parameter name Loading history...
309			* @return \Symfony\Component\HttpFoundation\RedirectResponse\|\Symfony\Component\HttpFoundation\Response
310			*/
311	2		public function remove(Application $app, Request $request, $productClassId)
312			{
313	2		$this->isTokenValid($app);
314
315	2		log_info('カート削除処理開始', array('product_class_id' => $productClassId));
316
317			// FRONT_CART_REMOVE_INITIALIZE
318	2		$event = new EventArgs(
319			array(
320	2		'productClassId' => $productClassId,
321			),
322			$request
323			);
324	2		$app['eccube.event.dispatcher']->dispatch(EccubeEvents::FRONT_CART_REMOVE_INITIALIZE, $event);
325
326	2		$productClassId = $event->getArgument('productClassId');
327	2		$app['eccube.service.cart']->removeProduct($productClassId)->save();
328
329	2		log_info('カート削除処理完了', array('product_class_id' => $productClassId));
330
331			// FRONT_CART_REMOVE_COMPLETE
332	2		$event = new EventArgs(
333			array(
334	2		'productClassId' => $productClassId,
335			),
336			$request
337			);
338	2		$app['eccube.event.dispatcher']->dispatch(EccubeEvents::FRONT_CART_REMOVE_COMPLETE, $event);
339
340	2		if ($event->hasResponse()) {
341			return $event->getResponse();
342			}
343
344	2		return $app->redirect($app->url('cart'));
345			}
346
347			/**
			0 ignored issues – show introduced 2016-02-14 23:45 UTC by Report Bug Copy Issue Report Doc comment for parameter "$quantity" missing Loading history... introduced 2016-10-25 11:16 UTC by Report Bug Copy Issue Report Doc comment for parameter "$productClassId" missing Loading history...
348			* カートに商品を個数を指定して設定する.
349			*
350			* @param Application $app
			0 ignored issues – show introduced 2016-10-25 11:16 UTC by Report Bug Copy Issue Report Expected 4 spaces after parameter type; 1 found Loading history...
351			* @param Request $request
			0 ignored issues – show introduced 2016-10-25 11:16 UTC by Report Bug Copy Issue Report Expected 8 spaces after parameter type; 1 found Loading history...
352			* @param $productClassId
			0 ignored issues – show introduced 2016-10-25 11:16 UTC by Report Bug Copy Issue Report Missing parameter name Loading history...
353			* @param $quantity
			0 ignored issues – show introduced 2016-02-14 23:45 UTC by Report Bug Copy Issue Report Missing parameter name Loading history...
354			* @return \Symfony\Component\HttpFoundation\RedirectResponse\|\Symfony\Component\HttpFoundation\Response
355			* @throws CartException
356			*
357			* @deprecated since 3.0.0, to be removed in 3.1
358			*/
359			public function setQuantity(Application $app, Request $request, $productClassId, $quantity)
			0 ignored issues – show Unused Code introduced 2016-02-14 23:45 UTC by Report Bug Copy Issue Report The parameter `$request` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
360			{
361			$this->isTokenValid($app);
362
363			$app['eccube.service.cart']->setProductQuantity($productClassId, $quantity)->save();
364
365			return $app->redirect($app->url('cart'));
366			}
367
368			/**
369			* カートをロック状態に設定し、購入確認画面へ遷移する.
370			*
371			* @param Application $app
372			* @param Request $request
			0 ignored issues – show introduced 2016-10-25 11:16 UTC by Report Bug Copy Issue Report Expected 5 spaces after parameter type; 1 found Loading history...
373			* @return \Symfony\Component\HttpFoundation\RedirectResponse\|\Symfony\Component\HttpFoundation\Response
374			*/
375	21		public function buystep(Application $app, Request $request)
376			{
377			// FRONT_CART_BUYSTEP_INITIALIZE
378	21		$event = new EventArgs(
379	21		array(),
380			$request
381			);
382	21		$app['eccube.event.dispatcher']->dispatch(EccubeEvents::FRONT_CART_BUYSTEP_INITIALIZE, $event);
383
384	21		$app['eccube.service.cart']->lock();
385	21		$app['eccube.service.cart']->save();
386
387			// FRONT_CART_BUYSTEP_COMPLETE
388	21		$event = new EventArgs(
389	21		array(),
390			$request
391			);
392	21		$app['eccube.event.dispatcher']->dispatch(EccubeEvents::FRONT_CART_BUYSTEP_COMPLETE, $event);
393
394	21		if ($event->hasResponse()) {
395			return $event->getResponse();
396			}
397
398	21		return $app->redirect($app->url('shopping'));
399			}
400			}
401

EC-CUBE / ec-cube

Pull Request — master (#1665)

CartController::down() A

Complexity

Size

Duplication

Code Coverage

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like