Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
| 1 | <?php |
||
| 33 | class CartController extends AbstractController |
||
|
|
|||
| 34 | { |
||
| 35 | /** |
||
| 36 | * カート画面. |
||
| 37 | * |
||
| 38 | * @param Application $app |
||
| 39 | * @param Request $request |
||
| 40 | * @return \Symfony\Component\HttpFoundation\Response |
||
| 41 | */ |
||
| 42 | 31 | public function index(Application $app, Request $request) |
|
| 99 | |||
| 100 | /** |
||
| 101 | * カートに商品を追加する. |
||
| 102 | * |
||
| 103 | * @param Application $app |
||
| 104 | * @param Request $request |
||
| 105 | * @return \Symfony\Component\HttpFoundation\RedirectResponse|\Symfony\Component\HttpFoundation\Response |
||
| 106 | */ |
||
| 107 | 76 | public function add(Application $app, Request $request) |
|
| 169 | |||
| 170 | /** |
||
| 171 | * カートに入っている商品の個数を1増やす. |
||
| 172 | * |
||
| 173 | * @param Application $app |
||
| 174 | * @param Request $request |
||
| 175 | * @param $productClassId |
||
| 176 | * @return \Symfony\Component\HttpFoundation\RedirectResponse|\Symfony\Component\HttpFoundation\Response |
||
| 177 | */ |
||
| 178 | 9 | View Code Duplication | public function up(Application $app, Request $request, $productClassId) |
| 236 | |||
| 237 | /** |
||
| 238 | * カートに入っている商品の個数を1減らす. |
||
| 239 | * マイナスになる場合は, 商品をカートから削除する. |
||
| 240 | * |
||
| 241 | * @param Application $app |
||
| 242 | * @param Request $request |
||
| 243 | * @param $productClassId |
||
| 244 | * @return \Symfony\Component\HttpFoundation\RedirectResponse|\Symfony\Component\HttpFoundation\Response |
||
| 245 | */ |
||
| 246 | 9 | View Code Duplication | public function down(Application $app, Request $request, $productClassId) |
| 247 | { |
||
| 248 | 9 | $this->isTokenValid($app); |
|
| 249 | |||
| 250 | // FRONT_CART_DOWN_INITIALIZE |
||
| 251 | 9 | $event = new EventArgs( |
|
| 252 | array( |
||
| 253 | 9 | 'productClassId' => $productClassId, |
|
| 254 | ), |
||
| 255 | $request |
||
| 256 | ); |
||
| 257 | 9 | $app['eccube.event.dispatcher']->dispatch(EccubeEvents::FRONT_CART_DOWN_INITIALIZE, $event); |
|
| 258 | |||
| 259 | try { |
||
| 260 | |||
| 261 | 9 | log_info('カート減算処理開始', array('product_class_id' => $productClassId)); |
|
| 262 | |||
| 263 | 9 | $productClassId = $event->getArgument('productClassId'); |
|
| 264 | 9 | $app['eccube.service.cart']->downProductQuantity($productClassId)->save(); |
|
| 265 | |||
| 266 | // FRONT_CART_UP_COMPLETE |
||
| 267 | 7 | $event = new EventArgs( |
|
| 268 | array( |
||
| 269 | 7 | 'productClassId' => $productClassId, |
|
| 270 | ), |
||
| 271 | $request |
||
| 272 | ); |
||
| 273 | 7 | $app['eccube.event.dispatcher']->dispatch(EccubeEvents::FRONT_CART_DOWN_COMPLETE, $event); |
|
| 274 | |||
| 275 | 7 | if ($event->hasResponse()) { |
|
| 276 | return $event->getResponse(); |
||
| 277 | } |
||
| 278 | |||
| 279 | 7 | log_info('カート減算処理完了', array('product_class_id' => $productClassId)); |
|
| 280 | |||
| 281 | 2 | } catch (CartException $e) { |
|
| 282 | 2 | log_info('カート減算エラー', array($e->getMessage())); |
|
| 283 | |||
| 284 | // FRONT_CART_DOWN_EXCEPTION |
||
| 285 | 2 | $event = new EventArgs( |
|
| 286 | array( |
||
| 287 | 2 | 'exception' => $e, |
|
| 288 | ), |
||
| 289 | $request |
||
| 290 | ); |
||
| 291 | 2 | $app['eccube.event.dispatcher']->dispatch(EccubeEvents::FRONT_CART_DOWN_EXCEPTION, $event); |
|
| 292 | |||
| 293 | 2 | if ($event->hasResponse()) { |
|
| 294 | return $event->getResponse(); |
||
| 295 | } |
||
| 296 | |||
| 297 | 2 | $app->addRequestError($e->getMessage()); |
|
| 298 | } |
||
| 299 | |||
| 300 | 9 | return $app->redirect($app->url('cart')); |
|
| 301 | } |
||
| 302 | |||
| 303 | /** |
||
| 304 | * カートに入っている商品を削除する. |
||
| 305 | * |
||
| 306 | * @param Application $app |
||
| 307 | * @param Request $request |
||
| 308 | * @param $productClassId |
||
| 309 | * @return \Symfony\Component\HttpFoundation\RedirectResponse|\Symfony\Component\HttpFoundation\Response |
||
| 310 | */ |
||
| 311 | 2 | public function remove(Application $app, Request $request, $productClassId) |
|
| 346 | |||
| 347 | /** |
||
| 348 | * カートに商品を個数を指定して設定する. |
||
| 349 | * |
||
| 350 | * @param Application $app |
||
| 351 | * @param Request $request |
||
| 352 | * @param $productClassId |
||
| 353 | * @param $quantity |
||
| 354 | * @return \Symfony\Component\HttpFoundation\RedirectResponse|\Symfony\Component\HttpFoundation\Response |
||
| 355 | * @throws CartException |
||
| 356 | * |
||
| 357 | * @deprecated since 3.0.0, to be removed in 3.1 |
||
| 358 | */ |
||
| 359 | public function setQuantity(Application $app, Request $request, $productClassId, $quantity) |
||
| 367 | |||
| 368 | /** |
||
| 369 | * カートをロック状態に設定し、購入確認画面へ遷移する. |
||
| 370 | * |
||
| 371 | * @param Application $app |
||
| 372 | * @param Request $request |
||
| 373 | * @return \Symfony\Component\HttpFoundation\RedirectResponse|\Symfony\Component\HttpFoundation\Response |
||
| 374 | */ |
||
| 375 | 21 | public function buystep(Application $app, Request $request) |
|
| 400 | } |
||
| 401 |