OrderDetailCollection::hasProductByName() - Code Metrics - Inspection of "namespace を Acme に変更" - EC-CUBE/ec-cube - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — experimental/3.1 (#2154)

by Kentaro

created 2017-02-28 09:14 UTC

OrderDetailCollection::hasProductByName() A

↳ Parent: OrderDetailCollection

Complexity

Conditions	1
Paths	1

Size

Total Lines	8
Code Lines	5

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	6
CRAP Score	1

Importance

Changes

Metric	Value
cc	1
eloc	5
nc	1
nop	1
dl	0
loc	8
ccs	6
cts	6
cp	1
crap	1
rs	9.4285
c	0
b	0
f	0

<?php

namespace Eccube\Service\Calculator;

use Eccube\Entity\Order;
use Eccube\Entity\OrderDetail;

class OrderDetailCollection extends \ArrayIterator

{
    public function __construct($OrderDetails, $flags = 0)

    {
        // $OrderDetails が Collection だったら toArray(); する
        parent::__construct($OrderDetails, $flags);
    }

    // 明細種別ごとに返すメソッド作る
    public function getProductClasses()

    {
        return new self(array_filter(
            $this->getArrayCopy(),
            function ($OrderDetail) {
                if ($OrderDetail->getProductClass()) {
                    return true;
                }
                return false;

            }
        ));
    }

    /**

     * 同名の明細が存在するかどうか.
     *
     * TODO 暫定対応. 本来は明細種別でチェックする.
     */

    public function hasProductByName($productName)
    {
        $OrderDetails = array_filter($this->getArrayCopy(),
                                     function ($OrderDetail) use ($productName) {
                                         return $OrderDetail->getProductName() == $productName;
                                     });
        return !empty($OrderDetails);

    }
    // map, filter, reduce も実装したい
}


1		<?php
2
3		namespace Eccube\Service\Calculator;
4
5		use Eccube\Entity\Order;
6		use Eccube\Entity\OrderDetail;
7
8		class OrderDetailCollection extends \ArrayIterator
		0 ignored issues – show introduced 2016-12-15 10:20 UTC by Report Bug Copy Issue Report Missing class doc comment Loading history...
9		{
10	12	public function __construct($OrderDetails, $flags = 0)
		0 ignored issues – show introduced 2016-12-15 10:20 UTC by Report Bug Copy Issue Report Missing function doc comment Loading history...
11		{
12		// $OrderDetails が Collection だったら toArray(); する
13	12	parent::__construct($OrderDetails, $flags);
14		}
15
16		// 明細種別ごとに返すメソッド作る
17	1	public function getProductClasses()
		0 ignored issues – show introduced 2016-12-15 10:20 UTC by Report Bug Copy Issue Report You must use "/**" style comments for a function comment Loading history...
18		{
19	1	return new self(array_filter(
20	1	$this->getArrayCopy(),
21		function ($OrderDetail) {
22	1	if ($OrderDetail->getProductClass()) {
23	1	return true;
24		}
25	1	return false;
		0 ignored issues – show introduced 2016-12-15 10:20 UTC by Report Bug Copy Issue Report Missing blank line before return statement Loading history...
26	1	}
27		));
28		}
29
30		/**
		0 ignored issues – show introduced 2017-02-28 16:18 UTC by Report Bug Copy Issue Report Doc comment for parameter "$productName" missing Loading history...
31		* 同名の明細が存在するかどうか.
32		*
33		* TODO 暫定対応. 本来は明細種別でチェックする.
34		*/
		0 ignored issues – show introduced 2017-02-28 16:18 UTC by Report Bug Copy Issue Report Missing @return tag in function comment Loading history...
35	12	public function hasProductByName($productName)
36		{
37	12	$OrderDetails = array_filter($this->getArrayCopy(),
38	12	function ($OrderDetail) use ($productName) {
39	12	return $OrderDetail->getProductName() == $productName;
40	12	});
41	12	return !empty($OrderDetails);
		0 ignored issues – show introduced 2017-02-28 16:18 UTC by Report Bug Copy Issue Report Missing blank line before return statement Loading history...
42		}
43		// map, filter, reduce も実装したい
44		}
45

EC-CUBE / ec-cube

Pull Request — experimental/3.1 (#2154)

OrderDetailCollection::hasProductByName() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like