Eccube\Service\Calculator\OrderDetailCollection

Complexity

Total Complexity

4

Size/Duplication

Total Lines	37
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	0

Test Coverage

Coverage

100%

Importance

Changes

0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	5	1
A	getProductClasses()	0	12	2
A	hasProductByName()	0	8	1

<?php

namespace Eccube\Service\Calculator;

use Eccube\Entity\Order;
use Eccube\Entity\OrderDetail;

class OrderDetailCollection extends \ArrayIterator

Missing class doc comment

{
    public function __construct($OrderDetails, $flags = 0)

Missing function doc comment

    {
        // $OrderDetails が Collection だったら toArray(); する
        parent::__construct($OrderDetails, $flags);
    }

    // 明細種別ごとに返すメソッド作る
    public function getProductClasses()

You must use "/**" style comments for a function comment

    {
        return new self(array_filter(
            $this->getArrayCopy(),
            function ($OrderDetail) {
                if ($OrderDetail->getProductClass()) {
                    return true;
                }
                return false;

Missing blank line before return statement

            }
        ));
    }

    /**

Doc comment for parameter "$productName" missing

     * 同名の明細が存在するかどうか.
     *
     * TODO 暫定対応. 本来は明細種別でチェックする.
     */

Missing @return tag in function comment

    public function hasProductByName($productName)
    {
        $OrderDetails = array_filter($this->getArrayCopy(),
                                     function ($OrderDetail) use ($productName) {
                                         return $OrderDetail->getProductName() == $productName;
                                     });
        return !empty($OrderDetails);

Missing blank line before return statement

    }
    // map, filter, reduce も実装したい
}