Eccube\Service\Calculator\CalculateContext

Complexity

Total Complexity

9

Size/Duplication

Total Lines	55
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	1

Test Coverage

Coverage

87.5%

Importance

Changes

0

5 Methods

Rating	Name	Duplication	Size	Complexity
A	getCalculateStrategies()	0	4	1
A	executeCalculator()	0	15	4
A	calculateOrder()	0	13	2
A	setCalculateStrategies()	0	4	1
A	setOrder()	0	6	1

<?php
namespace Eccube\Service\Calculator;

use Eccube\Entity\Order;
use Eccube\Entity\OrderDetail;

class CalculateContext

Missing class doc comment

{
    protected $Order;
    protected $OrderDetails = []; // Collection になってる？

    // $app['eccube.calculate.strategies'] に DI する

37% of this comment could be valid code. Did you maybe forget this after debugging?

    protected $CalculateStrategies;

    public function executeCalculator()

Missing function doc comment

    {
        foreach ($this->CalculateStrategies as $Strategy) {
            $Strategy->execute($this->OrderDetails);
        }

        foreach($this->OrderDetails as $OrderDetail) {
            if (!$this->Order->getOrderDetails()->contains($OrderDetail)) {
                $OrderDetail->setOrder($this->Order);
                $this->Order->addOrderDetail($OrderDetail);
                // ここのタイミングで Persist 可能?
            }
        }
        return $this->calculateOrder($this->Order);

Missing blank line before return statement

    }

    public function calculateOrder(Order $Order)

Missing function doc comment

    {
        // OrderDetails の計算結果を Order にセットする
        $subTotal = $Order->calculateSubTotal();
        $Order->setSubtotal($subTotal);
        $total = $Order->getTotalPrice();
        if ($total < 0) {
            $total = 0;
        }
        $Order->setTotal($total);
        $Order->setPaymentTotal($total);
        return $Order;

Missing blank line before return statement

    }

    public function setCalculateStrategies(\Doctrine\Common\Collections\ArrayCollection $strategies)

Missing function doc comment

    {
        $this->CalculateStrategies = $strategies;
    }

    public function getCalculateStrategies()

Missing function doc comment

    {
        return $this->CalculateStrategies;
    }

    public function setOrder(Order $Order)

Missing function doc comment

    {
        $this->Order = $Order;
        // ArrayIterator のラップしたクラスを作って明細種別ごとに管理したい
        $this->OrderDetails = new OrderDetailCollection($Order->getOrderDetails()->toArray());

It seems like new \Eccube\Service\Calculator\OrderDetailCollection($Order->getOrderDetails()->toArray()) of type object<Eccube\Service\Calculator\OrderDetailCollection> is incompatible with the declared type array of property $OrderDetails.

    }
}