CalculateContext::executeCalculator() - Code Metrics - Inspection of "namespace を Acme に変更" - EC-CUBE/ec-cube - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — experimental/3.1 (#2154)

by Kentaro

created 2017-02-28 09:14 UTC

CalculateContext::executeCalculator() A

↳ Parent: CalculateContext

Complexity

Conditions	4
Paths	6

Size

Total Lines	15
Code Lines	8

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	8
CRAP Score	4

Importance

Changes

Metric	Value
cc	4
eloc	8
nc	6
nop	0
dl	0
loc	15
ccs	8
cts	8
cp	1
crap	4
rs	9.2
c	0
b	0
f	0

<?php
namespace Eccube\Service\Calculator;

use Eccube\Entity\Order;
use Eccube\Entity\OrderDetail;

class CalculateContext

{
    protected $Order;
    protected $OrderDetails = []; // Collection になってる？

    // $app['eccube.calculate.strategies'] に DI する

    protected $CalculateStrategies;

    public function executeCalculator()

    {
        foreach ($this->CalculateStrategies as $Strategy) {
            $Strategy->execute($this->OrderDetails);
        }

        foreach($this->OrderDetails as $OrderDetail) {
            if (!$this->Order->getOrderDetails()->contains($OrderDetail)) {
                $OrderDetail->setOrder($this->Order);
                $this->Order->addOrderDetail($OrderDetail);
                // ここのタイミングで Persist 可能?
            }
        }
        return $this->calculateOrder($this->Order);

    }

    public function calculateOrder(Order $Order)

    {
        // OrderDetails の計算結果を Order にセットする
        $subTotal = $Order->calculateSubTotal();
        $Order->setSubtotal($subTotal);
        $total = $Order->getTotalPrice();
        if ($total < 0) {
            $total = 0;
        }
        $Order->setTotal($total);
        $Order->setPaymentTotal($total);
        return $Order;

    }

    public function setCalculateStrategies(\Doctrine\Common\Collections\ArrayCollection $strategies)

    {
        $this->CalculateStrategies = $strategies;
    }

    public function getCalculateStrategies()

    {
        return $this->CalculateStrategies;
    }

    public function setOrder(Order $Order)

    {
        $this->Order = $Order;
        // ArrayIterator のラップしたクラスを作って明細種別ごとに管理したい
        $this->OrderDetails = new OrderDetailCollection($Order->getOrderDetails()->toArray());

    }
}


1		<?php
2		namespace Eccube\Service\Calculator;
3
4		use Eccube\Entity\Order;
5		use Eccube\Entity\OrderDetail;
6
7		class CalculateContext
		0 ignored issues – show introduced 2016-12-15 10:20 UTC by Report Bug Copy Issue Report Missing class doc comment Loading history...
8		{
9		protected $Order;
10		protected $OrderDetails = []; // Collection になってる？
11
12		// $app['eccube.calculate.strategies'] に DI する
		0 ignored issues – show Unused Code Comprehensibility introduced 2016-12-15 10:20 UTC by Report Bug Copy Issue Report `37%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
13		protected $CalculateStrategies;
14
15	12	public function executeCalculator()
		0 ignored issues – show introduced 2016-12-15 10:20 UTC by Report Bug Copy Issue Report Missing function doc comment Loading history...
16		{
17	12	foreach ($this->CalculateStrategies as $Strategy) {
18	12	$Strategy->execute($this->OrderDetails);
19		}
20
21	12	foreach($this->OrderDetails as $OrderDetail) {
22	12	if (!$this->Order->getOrderDetails()->contains($OrderDetail)) {
23	12	$OrderDetail->setOrder($this->Order);
24	12	$this->Order->addOrderDetail($OrderDetail);
25		// ここのタイミングで Persist 可能?
26		}
27		}
28	12	return $this->calculateOrder($this->Order);
		0 ignored issues – show introduced 2017-02-28 16:18 UTC by Report Bug Copy Issue Report Missing blank line before return statement Loading history...
29		}
30
31	12	public function calculateOrder(Order $Order)
		0 ignored issues – show introduced 2016-12-15 10:20 UTC by Report Bug Copy Issue Report Missing function doc comment Loading history...
32		{
33		// OrderDetails の計算結果を Order にセットする
34	12	$subTotal = $Order->calculateSubTotal();
35	12	$Order->setSubtotal($subTotal);
36	12	$total = $Order->getTotalPrice();
37	12	if ($total < 0) {
38		$total = 0;
39		}
40	12	$Order->setTotal($total);
41	12	$Order->setPaymentTotal($total);
42	12	return $Order;
		0 ignored issues – show introduced 2016-12-15 10:20 UTC by Report Bug Copy Issue Report Missing blank line before return statement Loading history...
43		}
44
45	12	public function setCalculateStrategies(\Doctrine\Common\Collections\ArrayCollection $strategies)
		0 ignored issues – show introduced 2016-12-15 10:20 UTC by Report Bug Copy Issue Report Missing function doc comment Loading history...
46		{
47	12	$this->CalculateStrategies = $strategies;
48		}
49
50		public function getCalculateStrategies()
		0 ignored issues – show introduced 2017-02-21 06:06 UTC by Report Bug Copy Issue Report Missing function doc comment Loading history...
51		{
52		return $this->CalculateStrategies;
53		}
54
55	12	public function setOrder(Order $Order)
		0 ignored issues – show introduced 2016-12-15 10:20 UTC by Report Bug Copy Issue Report Missing function doc comment Loading history...
56		{
57	12	$this->Order = $Order;
58		// ArrayIterator のラップしたクラスを作って明細種別ごとに管理したい
59	12	$this->OrderDetails = new OrderDetailCollection($Order->getOrderDetails()->toArray());
		0 ignored issues – show Documentation Bug introduced 2017-02-28 16:18 UTC by Report Bug Copy Issue Report It seems like `new \Eccube\Service\Calc...erDetails()->toArray())` of type `object<Eccube\Service\Ca...\OrderDetailCollection>` is incompatible with the declared type `array` of property `$OrderDetails`. Our type inference engine has found an assignment to a property that is incompatible with the declared type of that property. Either this assignment is in error or the assigned type should be added to the documentation/type hint for that property.. Loading history...
60		}
61		}
62

EC-CUBE / ec-cube

Pull Request — experimental/3.1 (#2154)

CalculateContext::executeCalculator() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like