Failed Conditions
Pull Request — experimental/3.1 (#2486)
by
unknown
68:04 queued 25:47
created

11,196 -2 Covered Lines

17,160 +108 Total Lines

65.2 % -0.4% Code Coverage

PHP Classes Changes

 
47.83%
StrictArrayCollection added
 
100%
ItemComparerCollection added
 
100%
OrderItemTypeComparer added
 
100%
PriceComparer added
 
100%
ProductClassComparer added
 
100%
TaxComparer added
 
100%
AddItemProcessor added
33.33%
66.67%
PurchaseContext improved
100%
66.67%
PaymentTotalNegativeValidator got worse
62.9%
32.26%
CartController got worse
100%
75%
Cash got worse
54.71%
37.69%
ShoppingController got worse
66.3%
80%
ProductController improved
100%
88.89%
DisplayStatusValidator got worse
90.77%
83.08%
CartService got worse
92.86%
85.71%
StockValidator got worse
35.85%
30.66%
ShoppingService got worse
view more  

CRAP Changes

 
6
StrictArrayCollection::map() added
 
6
CartService::addQuantity() added
 
4
OrderItemTypeComparer::compare() added
 
4
TaxComparer::compare() added
 
3
ProductClassComparer::compare() added
 
3
AddItemProcessor::process() added
 
3
ItemComparerCollection::compare() added
 
2.0625
StrictArrayCollection::set() added
 
2
StrictArrayCollection::__construct() added
 
2
PurchaseFlow::addItem() added
view more  
2.2698
2.236
EccubeServiceProvider::register() improved
3
3.0416
DisplayStatusValidator::validate() got worse
21.0601
21.0037
ProductClassController::index() improved
5.0187
5.1502
StockValidator::validate() got worse
2
2.1481
PaymentTotalNegativeValidator::validate() got worse
1
2
ApplicationTrait::addRequestError() got worse
1
2
Cash::setRequest() got worse
2
1
ProcessResult::isSuccess() improved
1
2
ProcessResult::getMessage() got worse
2
1
PurchaseContext::getOriginHolder() improved
view more  
2
 
AddCartType::__construct() removed