Failed Conditions
Pull Request — experimental/sf (#3236)
by Kentaro
132:46 queued 125:39
created
src/Eccube/Command/PluginGenerateCommand.php 1 patch
Doc Comments   +21 added lines patch added patch discarded remove patch
@@ -147,6 +147,9 @@  discard block
 block discarded – undo
147 147
         return $version;
148 148
     }
149 149
 
150
+    /**
151
+     * @param string $pluginDir
152
+     */
150 153
     protected function createDirectories($pluginDir)
151 154
     {
152 155
         $dirs = [
@@ -165,6 +168,9 @@  discard block
 block discarded – undo
165 168
         }
166 169
     }
167 170
 
171
+    /**
172
+     * @param string $pluginDir
173
+     */
168 174
     protected function createConfig($pluginDir, $name, $code, $version)
169 175
     {
170 176
         $source = <<<EOL
@@ -176,12 +182,18 @@  discard block
 block discarded – undo
176 182
         $this->fs->dumpFile($pluginDir.'/config.yml', $source);
177 183
     }
178 184
 
185
+    /**
186
+     * @param string $pluginDir
187
+     */
179 188
     protected function createMessages($pluginDir)
180 189
     {
181 190
         $this->fs->dumpFile($pluginDir.'/Resource/locale/messages.ja.yaml', '');
182 191
         $this->fs->dumpFile($pluginDir.'/Resource/locale/validators.ja.yaml', '');
183 192
     }
184 193
 
194
+    /**
195
+     * @param string $pluginDir
196
+     */
185 197
     protected function createTwigBlock($pluginDir, $code)
186 198
     {
187 199
         $source = <<<EOL
@@ -206,6 +218,9 @@  discard block
 block discarded – undo
206 218
         $this->fs->dumpFile($pluginDir.'/TwigBlock.php', $source);
207 219
     }
208 220
 
221
+    /**
222
+     * @param string $pluginDir
223
+     */
209 224
     protected function createNav($pluginDir, $code)
210 225
     {
211 226
         $source = <<<EOL
@@ -230,6 +245,9 @@  discard block
 block discarded – undo
230 245
         $this->fs->dumpFile($pluginDir.'/Nav.php', $source);
231 246
     }
232 247
 
248
+    /**
249
+     * @param string $pluginDir
250
+     */
233 251
     protected function createEvent($pluginDir, $code)
234 252
     {
235 253
         $source = <<<EOL
@@ -254,6 +272,9 @@  discard block
 block discarded – undo
254 272
         $this->fs->dumpFile($pluginDir.'/Event.php', $source);
255 273
     }
256 274
 
275
+    /**
276
+     * @param string $pluginDir
277
+     */
257 278
     protected function createConfigController($pluginDir, $code)
258 279
     {
259 280
         $snakecased = Container::underscore($code);
Please login to merge, or discard this patch.
src/Eccube/Service/PurchaseFlow/Processor/PointProcessor.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -179,7 +179,7 @@
 block discarded – undo
179 179
      * 明細追加処理.
180 180
      *
181 181
      * @param ItemHolderInterface $itemHolder
182
-     * @param $discount
182
+     * @param integer $discount
183 183
      */
184 184
     private function addPointDiscountItem(ItemHolderInterface $itemHolder, $discount)
185 185
     {
Please login to merge, or discard this patch.
src/Eccube/Entity/Payment.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -348,7 +348,7 @@
 block discarded – undo
348 348
     }
349 349
 
350 350
     /**
351
-     * @return boolean
351
+     * @return integer
352 352
      */
353 353
     public function isVisible()
354 354
     {
Please login to merge, or discard this patch.
src/Eccube/EventListener/SecurityListener.php 1 patch
Unused Use Statements   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -21,10 +21,10 @@
 block discarded – undo
21 21
 use Eccube\Service\PurchaseFlow\PurchaseFlow;
22 22
 use Symfony\Component\EventDispatcher\EventSubscriberInterface;
23 23
 use Symfony\Component\HttpFoundation\RequestStack;
24
+use Symfony\Component\Security\Core\AuthenticationEvents;
24 25
 use Symfony\Component\Security\Core\Event\AuthenticationFailureEvent;
25 26
 use Symfony\Component\Security\Http\Event\InteractiveLoginEvent;
26 27
 use Symfony\Component\Security\Http\SecurityEvents;
27
-use Symfony\Component\Security\Core\AuthenticationEvents;
28 28
 
29 29
 class SecurityListener implements EventSubscriberInterface
30 30
 {
Please login to merge, or discard this patch.
src/Eccube/DependencyInjection/EccubeExtension.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -161,6 +161,9 @@
 block discarded – undo
161 161
         return empty($tables) ? false : true;
162 162
     }
163 163
 
164
+    /**
165
+     * @param string $pluginDir
166
+     */
164 167
     protected function getPluginDirectories($pluginDir)
165 168
     {
166 169
         $finder = (new Finder())
Please login to merge, or discard this patch.
src/Eccube/Service/PurchaseFlow/Processor/PaymentValidator.php 1 patch
Unused Use Statements   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -19,8 +19,8 @@
 block discarded – undo
19 19
 use Eccube\Entity\Master\SaleType;
20 20
 use Eccube\Entity\Payment;
21 21
 use Eccube\Repository\DeliveryRepository;
22
-use Eccube\Service\PurchaseFlow\PurchaseContext;
23 22
 use Eccube\Service\PurchaseFlow\ItemHolderValidator;
23
+use Eccube\Service\PurchaseFlow\PurchaseContext;
24 24
 
25 25
 /**
26 26
  * 支払い方法が一致しない明細がないかどうか.
Please login to merge, or discard this patch.
src/Eccube/Service/PurchaseFlow/ProcessResult.php 1 patch
Doc Comments   +6 added lines patch added patch discarded remove patch
@@ -32,11 +32,17 @@
 block discarded – undo
32 32
         $this->message = $message;
33 33
     }
34 34
 
35
+    /**
36
+     * @param string $message
37
+     */
35 38
     public static function warn($message)
36 39
     {
37 40
         return new self(self::WARNING, $message);
38 41
     }
39 42
 
43
+    /**
44
+     * @param string $message
45
+     */
40 46
     public static function error($message)
41 47
     {
42 48
         return new self(self::ERROR, $message);
Please login to merge, or discard this patch.