CompareContext::compare() - Code Metrics - Inspection of "カート追加処理の実装例" - EC-CUBE/ec-cube - Measure and Improve Code Quality continuously with Scrutinizer

Failed Conditions

Pull Request — experimental/3.1 (#2273)

unknown

created 2017-04-15 06:02 UTC

CompareContext::compare() A

↳ Parent: CompareContext

Complexity

Conditions	3
Paths	3

Size

Total Lines	11
Code Lines	5

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	3
eloc	5
nc	3
nop	2
dl	0
loc	11
rs	9.4285
c	0
b	0
f	0

<?php

namespace Eccube\Service\CartComparator;

class CompareContext

{
    /** @var \Doctrine\Common\Collections\ArrayCollection */
    protected $compareStrategies;

    function __construct()

    {
        $this->compareStrategies = new \Doctrine\Common\Collections\ArrayCollection();
    }

    /**

     * @param $CartItem1

     * @param $CartItem2

     * @return bool
     */
    public function compare($CartItem1, $CartItem2)
    {
        $result = !$this->compareStrategies->isEmpty();

        /** @var \Eccube\Service\CartComparator\Strategy\CartComparatorStrategyInterface $strategy */
        foreach ($this->compareStrategies as $strategy) {
            $result = $result && $strategy->compare($CartItem1, $CartItem2);
        }

        return $result;
    }

    /**
     * @param Strategy\CartComparatorStrategyInterface $strategy
     * @return $this
     */
    public function addStrategy(\Eccube\Service\CartComparator\Strategy\CartComparatorStrategyInterface $strategy)
    {
        $this->compareStrategies->add($strategy);

        return $this;
    }

    /**
     * @return \Doctrine\Common\Collections\ArrayCollection
     */
    public function getStrategies()
    {
        return $this->compareStrategies;
    }
}


1			<?php
2
3			namespace Eccube\Service\CartComparator;
4
5			class CompareContext
			0 ignored issues – show introduced 2017-04-15 06:40 UTC by Report Bug Copy Issue Report Missing class doc comment Loading history...
6			{
7			/** @var \Doctrine\Common\Collections\ArrayCollection */
8			protected $compareStrategies;
9
10			function __construct()
			0 ignored issues – show Best Practice introduced 2017-04-15 06:40 UTC by Report Bug Copy Issue Report It is generally recommended to explicitly declare the visibility for methods. Adding explicit visibility (`private`, `protected`, or `public`) is generally recommend to communicate to other developers how, and from where this method is intended to be used. Loading history... introduced 2017-04-15 06:40 UTC by Report Bug Copy Issue Report Missing function doc comment Loading history... introduced 2017-04-15 06:40 UTC by Report Bug Copy Issue Report No scope modifier specified for function "__construct" Loading history... Comprehensibility Best Practice introduced 2017-04-15 06:40 UTC by Report Bug Copy Issue Report It is recommend to declare an explicit visibility for `__construct`. Generally, we recommend to declare visibility for all methods in your source code. This has the advantage of clearly communication to other developers, and also yourself, how this method should be consumed. If you are not sure which visibility to choose, it is a good idea to start with the most restrictive visibility, and then raise visibility as needed, i.e. start with `private`, and only raise it to `protected` if a sub-class needs to have access, or `public` if an external class needs access. Loading history...
11			{
12			$this->compareStrategies = new \Doctrine\Common\Collections\ArrayCollection();
13			}
14
15			/**
			0 ignored issues – show introduced 2017-04-15 06:40 UTC by Report Bug Copy Issue Report Doc comment for parameter "$CartItem1" missing Loading history... introduced 2017-04-15 06:40 UTC by Report Bug Copy Issue Report Doc comment for parameter "$CartItem2" missing Loading history...
16			* @param $CartItem1
			0 ignored issues – show introduced 2017-04-15 06:40 UTC by Report Bug Copy Issue Report Missing parameter name Loading history...
17			* @param $CartItem2
			0 ignored issues – show introduced 2017-04-15 06:40 UTC by Report Bug Copy Issue Report Missing parameter name Loading history...
18			* @return bool
19			*/
20			public function compare($CartItem1, $CartItem2)
21			{
22			$result = !$this->compareStrategies->isEmpty();
23
24			/** @var \Eccube\Service\CartComparator\Strategy\CartComparatorStrategyInterface $strategy */
25			foreach ($this->compareStrategies as $strategy) {
26			$result = $result && $strategy->compare($CartItem1, $CartItem2);
27			}
28
29			return $result;
30			}
31
32			/**
33			* @param Strategy\CartComparatorStrategyInterface $strategy
34			* @return $this
35			*/
36			public function addStrategy(\Eccube\Service\CartComparator\Strategy\CartComparatorStrategyInterface $strategy)
37			{
38			$this->compareStrategies->add($strategy);
39
40			return $this;
41			}
42
43			/**
44			* @return \Doctrine\Common\Collections\ArrayCollection
45			*/
46			public function getStrategies()
47			{
48			return $this->compareStrategies;
49			}
50			}
51

EC-CUBE / ec-cube

Pull Request — experimental/3.1 (#2273)

CompareContext::compare() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like