Eccube\Service\CartComparator\CompareContext

Complexity

Total Complexity

6

Size/Duplication

Total Lines	46
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	1

Importance

Changes

0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	4	1
A	compare()	0	11	3
A	addStrategy()	0	6	1
A	getStrategies()	0	4	1

<?php

namespace Eccube\Service\CartComparator;

class CompareContext

Missing class doc comment

{
    /** @var \Doctrine\Common\Collections\ArrayCollection */
    protected $compareStrategies;

    function __construct()

It is generally recommended to explicitly declare the visibility for methods.

Missing function doc comment

No scope modifier specified for function "__construct"

It is recommend to declare an explicit visibility for __construct.

    {
        $this->compareStrategies = new \Doctrine\Common\Collections\ArrayCollection();
    }

    /**

Doc comment for parameter "$CartItem1" missing

Doc comment for parameter "$CartItem2" missing

     * @param $CartItem1

Missing parameter name

     * @param $CartItem2

Missing parameter name

     * @return bool
     */
    public function compare($CartItem1, $CartItem2)
    {
        $result = !$this->compareStrategies->isEmpty();

        /** @var \Eccube\Service\CartComparator\Strategy\CartComparatorStrategyInterface $strategy */
        foreach ($this->compareStrategies as $strategy) {
            $result = $result && $strategy->compare($CartItem1, $CartItem2);
        }

        return $result;
    }

    /**
     * @param Strategy\CartComparatorStrategyInterface $strategy
     * @return $this
     */
    public function addStrategy(\Eccube\Service\CartComparator\Strategy\CartComparatorStrategyInterface $strategy)
    {
        $this->compareStrategies->add($strategy);

        return $this;
    }

    /**
     * @return \Doctrine\Common\Collections\ArrayCollection
     */
    public function getStrategies()
    {
        return $this->compareStrategies;
    }
}