EC-CUBE / ec-cube

Failed Conditions

Pull Request — experimental/3.1 (#2641)

by Kiyotaka

created 2017-11-21 00:43 UTC

Changes

2 failure conditions met `issues.label("coding-style").new.count > 5` `issues.severity(>= MAJOR).new.exists` File Path Number of issues src/Eccube/Service/CartService.php 2 src/Eccube/Service/ShoppingService.php 1 composer.lock 2
	61 issues (2 critical, 3 major, 7 minor, 11 informational, 38 unknown) were introduced. 20 issues were fixed.
	4 new patches (Spacing, Doc Comments) are available.
	18 added classes/operations
		C	CartController::execPurchaseFlow() added
		C	ProductController::addCart() added
		B	CartService::mergeAllCartItems() added
		A	ProductClassComparator::compare() added
		A	CartService::getCarts() added
		B	ProductController::addFavorite() added
		A	ProductClassComparator added
		A	SaleTypeType::configureOptions() added
		B	ProductController::checkVisibility() added
		A	SaleTypeType::getBlockPrefix() added
D	↗	B	ProductController::detail() improved
A	↘	B	CartService::removeProduct() got worse
A	↘	B	CartService got worse
A	↘	B	EccubeServiceProvider::register() got worse
view all

6.76

▶ ± 0

Test Coverage

65%

▶ ±0%

Head	Kiyotaka Oku 2017-11-21 00:43 GMT+0000 Merge 8ce04ce9074ca5977ca723469348af10571ab65a into d01ac3d14cb832eaec05eb14b175bb9e2bc76276
⋮	12 more commits
Base	Chihiro Adachi 2017-11-17 07:40 UTC Merge pull request #2561 from EC-CUBE/feature-boolean