Failed Conditions
Push — master ( 665691...df30c6 )
by k-yamamura
40:07
created
src/Eccube/Controller/Admin/Product/ProductController.php 1 patch
Spacing   +11 added lines, -11 removed lines patch added patch discarded remove patch
@@ -177,7 +177,7 @@  discard block
 block discarded – undo
177 177
             foreach ($images as $img) {
178 178
                 foreach ($img as $image) {
179 179
                     $extension = $image->getClientOriginalExtension();
180
-                    $filename = date('mdHis') . uniqid('_') . '.' . $extension;
180
+                    $filename = date('mdHis').uniqid('_').'.'.$extension;
181 181
                     $image->move($app['config']['image_temp_realdir'], $filename);
182 182
                     $files[] = $filename;
183 183
                 }
@@ -239,7 +239,7 @@  discard block
 block discarded – undo
239 239
         $app['eccube.event.dispatcher']->dispatch(EccubeEvents::ADMIN_PRODUCT_EDIT_INITIALIZE, $event);
240 240
 
241 241
         if (!$has_class) {
242
-            $ProductClass->setStockUnlimited((boolean)$ProductClass->getStockUnlimited());
242
+            $ProductClass->setStockUnlimited((boolean) $ProductClass->getStockUnlimited());
243 243
             $form['class']->setData($ProductClass);
244 244
         }
245 245
 
@@ -337,7 +337,7 @@  discard block
 block discarded – undo
337 337
                     $app['orm.em']->persist($ProductImage);
338 338
 
339 339
                     // 移動
340
-                    $file = new File($app['config']['image_temp_realdir'] . '/' . $add_image);
340
+                    $file = new File($app['config']['image_temp_realdir'].'/'.$add_image);
341 341
                     $file->move($app['config']['image_save_realdir']);
342 342
                 }
343 343
 
@@ -357,7 +357,7 @@  discard block
 block discarded – undo
357 357
 
358 358
                     // 削除
359 359
                     $fs = new Filesystem();
360
-                    $fs->remove($app['config']['image_save_realdir'] . '/' . $delete_image);
360
+                    $fs->remove($app['config']['image_save_realdir'].'/'.$delete_image);
361 361
                 }
362 362
                 $app['orm.em']->persist($Product);
363 363
                 $app['orm.em']->flush();
@@ -463,7 +463,7 @@  discard block
 block discarded – undo
463 463
                 foreach ($deleteImages as $deleteImage) {
464 464
                     try {
465 465
                         $fs = new Filesystem();
466
-                        $fs->remove($app['config']['image_save_realdir'] . '/' . $deleteImage);
466
+                        $fs->remove($app['config']['image_save_realdir'].'/'.$deleteImage);
467 467
                     } catch (\Exception $e) {
468 468
                         // エラーが発生しても無視する
469 469
                     }
@@ -527,10 +527,10 @@  discard block
 block discarded – undo
527 527
 
528 528
                     // 画像ファイルを新規作成
529 529
                     $extension = pathinfo($Image->getFileName(), PATHINFO_EXTENSION);
530
-                    $filename = date('mdHis') . uniqid('_') . '.' . $extension;
530
+                    $filename = date('mdHis').uniqid('_').'.'.$extension;
531 531
                     try {
532 532
                         $fs = new Filesystem();
533
-                        $fs->copy($app['config']['image_save_realdir'] . '/' . $Image->getFileName(), $app['config']['image_save_realdir'] . '/' . $filename);
533
+                        $fs->copy($app['config']['image_save_realdir'].'/'.$Image->getFileName(), $app['config']['image_save_realdir'].'/'.$filename);
534 534
                     } catch (\Exception $e) {
535 535
                         // エラーが発生しても無視する
536 536
                     }
@@ -585,7 +585,7 @@  discard block
 block discarded – undo
585 585
         $em->getConfiguration()->setSQLLogger(null);
586 586
 
587 587
         $response = new StreamedResponse();
588
-        $response->setCallback(function () use ($app, $request) {
588
+        $response->setCallback(function() use ($app, $request) {
589 589
 
590 590
             // CSV種別を元に初期化.
591 591
             $app['eccube.service.csv.export']->initCsvType(CsvType::CSV_TYPE_PRODUCT);
@@ -609,7 +609,7 @@  discard block
 block discarded – undo
609 609
 
610 610
             // データ行の出力.
611 611
             $app['eccube.service.csv.export']->setExportQueryBuilder($qb);
612
-            $app['eccube.service.csv.export']->exportData(function ($entity, $csvService) {
612
+            $app['eccube.service.csv.export']->exportData(function($entity, $csvService) {
613 613
 
614 614
                 $Csvs = $csvService->getCsvs();
615 615
 
@@ -641,9 +641,9 @@  discard block
 block discarded – undo
641 641
         });
642 642
 
643 643
         $now = new \DateTime();
644
-        $filename = 'product_' . $now->format('YmdHis') . '.csv';
644
+        $filename = 'product_'.$now->format('YmdHis').'.csv';
645 645
         $response->headers->set('Content-Type', 'application/octet-stream');
646
-        $response->headers->set('Content-Disposition', 'attachment; filename=' . $filename);
646
+        $response->headers->set('Content-Disposition', 'attachment; filename='.$filename);
647 647
         $response->send();
648 648
 
649 649
         return $response;
Please login to merge, or discard this patch.
src/Eccube/Application.php 1 patch
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -29,7 +29,6 @@
 block discarded – undo
29 29
 use Symfony\Component\EventDispatcher\EventSubscriberInterface;
30 30
 use Symfony\Component\Finder\Finder;
31 31
 use Symfony\Component\Yaml\Yaml;
32
-use Monolog\Logger;
33 32
 
34 33
 class FormEventSubscriber implements EventSubscriberInterface
35 34
 {
Please login to merge, or discard this patch.
src/Eccube/Controller/ProductController.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -106,7 +106,7 @@
 block discarded – undo
106 106
             ));
107 107
             $addCartForm = $builder->getForm();
108 108
 
109
-            if ($request->getMethod() === 'POST' && (string)$Product->getId() === $request->get('product_id')) {
109
+            if ($request->getMethod() === 'POST' && (string) $Product->getId() === $request->get('product_id')) {
110 110
                 $addCartForm->handleRequest($request);
111 111
 
112 112
                 if ($addCartForm->isValid()) {
Please login to merge, or discard this patch.
src/Eccube/Controller/Admin/Product/ProductClassController.php 2 patches
Doc Comments   +5 added lines patch added patch discarded remove patch
@@ -510,6 +510,8 @@  discard block
 block discarded – undo
510 510
     /**
511 511
      * 登録、更新時のエラー画面表示
512 512
      *
513
+     * @param Application $app
514
+     * @param boolean $not_product_class
513 515
      */
514 516
     protected function render($app, $Product, $ProductClass, $not_product_class, $classForm, $error = null)
515 517
     {
@@ -559,6 +561,7 @@  discard block
 block discarded – undo
559 561
 
560 562
     /**
561 563
      * 規格1と規格2を組み合わせた商品規格を作成
564
+     * @param Application $app
562 565
      */
563 566
     private function createProductClasses($app, Product $Product, ClassName $ClassName1 = null, ClassName $ClassName2 = null)
564 567
     {
@@ -646,6 +649,7 @@  discard block
 block discarded – undo
646 649
      *
647 650
      * @param $productClassDest コピー先となる商品規格
648 651
      * @param $productClassOrig コピー元となる商品規格
652
+     * @param Application $app
649 653
      */
650 654
     private function setDefualtProductClass($app, $productClassDest, $productClassOrig) {
651 655
         $productClassDest->setDeliveryDate($productClassOrig->getDeliveryDate());
@@ -687,6 +691,7 @@  discard block
 block discarded – undo
687 691
      * 商品規格を登録
688 692
      *
689 693
      * @param $ProductClasses 登録される商品規格
694
+     * @param Application $app
690 695
      */
691 696
     private function insertProductClass($app, $Product, $ProductClasses) {
692 697
 
Please login to merge, or discard this patch.
Indentation   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -138,7 +138,7 @@
 block discarded – undo
138 138
                                 'allow_add' => true,
139 139
                                 'allow_delete' => true,
140 140
                                 'data' => $ProductClasses,
141
-                             ));
141
+                                ));
142 142
 
143 143
                         $event = new EventArgs(
144 144
                             array(
Please login to merge, or discard this patch.
src/Eccube/Application/ApplicationTrait.php 1 patch
Spacing   +10 added lines, -10 removed lines patch added patch discarded remove patch
@@ -20,32 +20,32 @@  discard block
 block discarded – undo
20 20
      */
21 21
     public function addSuccess($message, $namespace = 'front')
22 22
     {
23
-        $this['session']->getFlashBag()->add('eccube.' . $namespace . '.success', $message);
23
+        $this['session']->getFlashBag()->add('eccube.'.$namespace.'.success', $message);
24 24
     }
25 25
 
26 26
     public function addError($message, $namespace = 'front')
27 27
     {
28
-        $this['session']->getFlashBag()->add('eccube.' . $namespace . '.error', $message);
28
+        $this['session']->getFlashBag()->add('eccube.'.$namespace.'.error', $message);
29 29
     }
30 30
 
31 31
     public function addDanger($message, $namespace = 'front')
32 32
     {
33
-        $this['session']->getFlashBag()->add('eccube.' . $namespace . '.danger', $message);
33
+        $this['session']->getFlashBag()->add('eccube.'.$namespace.'.danger', $message);
34 34
     }
35 35
 
36 36
     public function addWarning($message, $namespace = 'front')
37 37
     {
38
-        $this['session']->getFlashBag()->add('eccube.' . $namespace . '.warning', $message);
38
+        $this['session']->getFlashBag()->add('eccube.'.$namespace.'.warning', $message);
39 39
     }
40 40
 
41 41
     public function addInfo($message, $namespace = 'front')
42 42
     {
43
-        $this['session']->getFlashBag()->add('eccube.' . $namespace . '.info', $message);
43
+        $this['session']->getFlashBag()->add('eccube.'.$namespace.'.info', $message);
44 44
     }
45 45
 
46 46
     public function addRequestError($message, $namespace = 'front')
47 47
     {
48
-        $this['session']->getFlashBag()->set('eccube.' . $namespace . '.request.error', $message);
48
+        $this['session']->getFlashBag()->set('eccube.'.$namespace.'.request.error', $message);
49 49
     }
50 50
 
51 51
     public function clearMessage()
@@ -64,7 +64,7 @@  discard block
 block discarded – undo
64 64
         if (is_null($namespace)) {
65 65
             $this['session']->getFlashBag()->set('eccube.login.target.path', $targetPath);
66 66
         } else {
67
-            $this['session']->getFlashBag()->set('eccube.' . $namespace . '.login.target.path', $targetPath);
67
+            $this['session']->getFlashBag()->set('eccube.'.$namespace.'.login.target.path', $targetPath);
68 68
         }
69 69
     }
70 70
 
@@ -234,14 +234,14 @@  discard block
 block discarded – undo
234 234
         $eventName = $view;
235 235
         if ($this->isAdminRequest()) {
236 236
             // 管理画面の場合、event名に「Admin/」を付ける
237
-            $eventName = 'Admin/' . $view;
237
+            $eventName = 'Admin/'.$view;
238 238
         }
239
-        $this['monolog']->debug('Template Event Name : ' . $eventName);
239
+        $this['monolog']->debug('Template Event Name : '.$eventName);
240 240
 
241 241
         $this['eccube.event.dispatcher']->dispatch($eventName, $event);
242 242
 
243 243
         if ($response instanceof StreamedResponse) {
244
-            $response->setCallback(function () use ($twig, $view, $parameters) {
244
+            $response->setCallback(function() use ($twig, $view, $parameters) {
245 245
                 $twig->display($view, $parameters);
246 246
             });
247 247
         } else {
Please login to merge, or discard this patch.
src/Eccube/Controller/Admin/Content/BlockController.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -113,13 +113,13 @@  discard block
 block discarded – undo
113 113
                 // ファイル生成・更新
114 114
                 $tplDir = $app['config']['block_realdir'];
115 115
 
116
-                $filePath = $tplDir . '/' . $Block->getFileName() . '.twig';
116
+                $filePath = $tplDir.'/'.$Block->getFileName().'.twig';
117 117
 
118 118
                 $fs = new Filesystem();
119 119
                 $fs->dumpFile($filePath, $form->get('block_html')->getData());
120 120
                 // 更新でファイル名を変更した場合、以前のファイルを削除
121 121
                 if ($Block->getFileName() != $previous_filename && !is_null($previous_filename)) {
122
-                    $oldFilePath = $tplDir . $previous_filename;
122
+                    $oldFilePath = $tplDir.$previous_filename;
123 123
                     if ($fs->exists($oldFilePath)) {
124 124
                         $fs->remove($oldFilePath);
125 125
                     }
@@ -171,7 +171,7 @@  discard block
 block discarded – undo
171 171
         // テンプレートが変更されていた場合、DBからはブロック削除されるがtwigファイルは残る
172 172
         if ($Block->getDeletableFlg() > 0) {
173 173
             $tplDir = $app['config']['block_realdir'];
174
-            $file = $tplDir . '/' . $Block->getFileName() . '.twig';
174
+            $file = $tplDir.'/'.$Block->getFileName().'.twig';
175 175
             $fs = new Filesystem();
176 176
             if ($fs->exists($file)) {
177 177
                 $fs->remove($file);
Please login to merge, or discard this patch.
src/Eccube/Controller/Admin/Customer/CustomerEditController.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -88,7 +88,7 @@
 block discarded – undo
88 88
                         ->setCompanyName($Customer->getCompanyName())
89 89
                         ->setZip01($Customer->getZip01())
90 90
                         ->setZip02($Customer->getZip02())
91
-                        ->setZipcode($Customer->getZip01() . $Customer->getZip02())
91
+                        ->setZipcode($Customer->getZip01().$Customer->getZip02())
92 92
                         ->setPref($Customer->getPref())
93 93
                         ->setAddr01($Customer->getAddr01())
94 94
                         ->setAddr02($Customer->getAddr02())
Please login to merge, or discard this patch.