Eccube\Service\Calculator\ShipmentItemCollection

Complexity

Total Complexity

8

Size/Duplication

Total Lines	62
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	0

Importance

Changes

0

6 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	5	1
A	getProductClasses()	0	4	1
A	getDeliveryFees()	0	4	1
A	subCollection()	0	7	2
A	hasProductByName()	0	9	1
A	hasItemByOrderItemType()	0	8	2

<?php

namespace Eccube\Service\Calculator;

use Eccube\Entity\Master\OrderItemType;
use Eccube\Entity\ShipmentItem;

class ShipmentItemCollection extends \ArrayIterator

Missing class doc comment

{
    public function __construct($ShipmentItems, $flags = 0)

Missing function doc comment

    {
        // $ShipmentItems が Collection だったら toArray(); する
        parent::__construct($ShipmentItems, $flags);
    }

    // 明細種別ごとに返すメソッド作る
    public function getProductClasses()

You must use "/**" style comments for a function comment

    {
        return $this->subCollection(OrderItemType::PRODUCT);
    }

    public function getDeliveryFees()

Missing function doc comment

    {
        return $this->subCollection(OrderItemType::DELIVERY_FEE);
    }

    /**
     * 指定した受注明細区分だけの明細を取得.
     * @param int $orderItemTypeId 受注明細区分ID
     * @return ShipmentItemCollection
     */
    private function subCollection($orderItemTypeId)
    {
        return new self(array_filter($this->getArrayCopy(), function($ShipmentItem) use ($orderItemTypeId) {

Expected 1 space after FUNCTION keyword; 0 found

            /* @var ShipmentItem $ShipmentItem */
            return $ShipmentItem->getOrderItemType() && $ShipmentItem->getOrderItemType()->getId() == $orderItemTypeId;
        }));
    }

    /**

Doc comment for parameter "$productName" missing

     * 同名の明細が存在するかどうか.
     *
     * TODO 暫定対応. 本来は明細種別でチェックする.
     */

Missing @return tag in function comment

    public function hasProductByName($productName)

Declare public methods first, then protected ones and finally private ones

    {
        $ShipmentItems = array_filter($this->getArrayCopy(),
                                     function ($ShipmentItem) use ($productName) {
                                         /* @var ShipmentItem $ShipmentItem */
                                         return $ShipmentItem->getProductName() == $productName;
                                     });
        return !empty($ShipmentItems);

Missing blank line before return statement

    }
    // map, filter, reduce も実装したい

    /**
     * 指定した受注明細区分の明細が存在するかどうか
     * @param OrderItemType $OrderItemType 受注区分
     * @return boolean
     */
    public function hasItemByOrderItemType($OrderItemType)
    {
        $filteredItems = array_filter($this->getArrayCopy(), function($ShipmentItem) use ($OrderItemType) {

Expected 1 space after FUNCTION keyword; 0 found

            /* @var ShipmentItem $ShipmentItem */
            return $ShipmentItem->getOrderItemType() && $ShipmentItem->getOrderItemType()->getId() == $OrderItemType->getId();
        });
        return !empty($filteredItems);

Missing blank line before return statement

    }
}