Summary - Inspection of "Merge pull request #2322 from nanasess/shipping_ma..." - EC-CUBE/ec-cube - Measure and Improve Code Quality continuously with Scrutinizer

Failed Conditions

by chihiro

created 2017-05-18 03:43 UTC

3 failure conditions met `issues.label("coding-style").new.count > 5` `issues.severity(>= MAJOR).new.exists` File Path Number of issues Eccube/Controller/Admin/Order/EditController.php 2 Controller/Admin/Shipping/EditController.php 5 src/Eccube/Service/CalculateService.php 1 src/Eccube/Service/Calculator/CalculateContext.php 1 src/Eccube/Service/OrderHelper.php 4 `elements.rating(<= D).new.exists` Name Shipping\EditController::edit() ShippingController::index() ShipmentItemType::buildForm() ShippingRepository::getQueryBuilderBySearchDataForAdmin()
	93 issues (13 major, 6 minor, 29 informational, 45 unknown) were introduced. 25 issues were fixed.
	17 new patches (Doc Comments, Unused Use Statements, Spacing, Indentation) are available.
	14 added classes/operations
		F	ShippingRepository::getQueryBuilderBySearchDataForAdmin() added
		D	EditController::edit() added
		D	ShippingController::index() added
		C	EditController::searchProduct() added
		A	ShipmentItemCollection::__construct() added
		A	ShipmentItemCollection::getProductClasses() added
		A	ShipmentItemCollection::getDeliveryFees() added
		A	ShipmentItemCollection::subCollection() added
		A	ShipmentItemCollection::hasProductByName() added
		A	ShipmentItemCollection::hasItemByOrderItemType() added
D	↗	C	ShippingType::buildForm() improved
C	↘	D	ShipmentItemType::buildForm() got worse
C	↗	B	OrderType::buildForm() improved
F	↗	D	EditController::index() improved
A	↘	B	ShippingRepository got worse
view all

6.83

▶ ± 0

Test Coverage

71%

▶ ±0%

Head	chihiro-adachi 2017-05-18 12:43 GMT+0900 Merge pull request #2322 from nanasess/shipping_management
⋮	42 more commits
Base	Yangsin 2017-05-18 02:26 UTC Merge pull request #2321 from chihiro-adachi/dev-form-render

EC-CUBE / ec-cube