EC-CUBE / ec-cube

Failed Conditions

Pull Request — master (#1537)

by k-yamamura

created 2016-04-13 00:45 UTC

Changes

3 failure conditions met `issues.label("coding-style").new.count > 5` `issues.severity(>= MAJOR).new.exists` File Path Number of issues src/Eccube/Controller/ShoppingController.php 1 `elements.rating(<= D).new.exists` Name ShoppingController::confirm()
	125 issues (1 major, 1 minor, 19 informational, 104 unknown) were introduced. 122 issues were fixed.
	1 new patch (Spacing) is available.
	10 added classes/operations
		A	ShoppingService::setOrderUpdateData() added
		A	ShoppingService::setFormData() added
		A	ShoppingService::calculateDeliveryFee() added
		B	ShoppingService::processPurchase() added
		A	ShoppingService::isDiscount() added
		A	ShoppingService::setDiscount() added
		A	ShoppingService::calculatePrice() added
		A	ShoppingService::setOrderStatus() added
		A	ShoppingService::sendOrderMail() added
		A	ShoppingService::notifyComplete() added
B	↗	A	ShoppingService::getAmount() improved
C	↘	D	ShoppingController::confirm() got worse

6.85

▶ ± 0

Test Coverage

74%

▶ ±0%

Head	k-yamamura 2016-04-13 00:45 GMT+0000 Merge d87491e38abba30e25d5966615695fe45ff89472 into eeb44cba165b535f89418405f9978b8429fd97ab
⋮	14 more commits
Base	chihiro-adachi 2016-04-07 04:32 UTC Merge pull request #1496 from shhirose/forgot_reset_title_typo