Completed
Push — master ( c8c0f9...82094b )
by Maxime
19:00
created
src/Distilleries/Expendable/Helpers/Security.php 3 patches
Doc Comments   +5 added lines, -1 removed lines patch added patch discarded remove patch
@@ -301,6 +301,10 @@  discard block
 block discarded – undo
301 301
       * @param boolean $is_image TRUE if this is an image
302 302
       * @return string The string with the evil attributes removed
303 303
       */
304
+
305
+    /**
306
+     * @param boolean $evilAttribute
307
+     */
304 308
     protected function _remove_evil_attributes($str, $is_image, $evilAttribute)
305 309
     {
306 310
         // All javascript event handlers (e.g. onload, onclick, onmouseover), style, and xmlns
@@ -429,7 +433,7 @@  discard block
 block discarded – undo
429 433
      * things like j a v a s c r i p t
430 434
      *
431 435
      * @param	type
432
-     * @return	type
436
+     * @return	string
433 437
      */
434 438
     protected function _compact_exploded_words($matches)
435 439
     {
Please login to merge, or discard this patch.
Spacing   +23 added lines, -23 removed lines patch added patch discarded remove patch
@@ -19,7 +19,7 @@  discard block
 block discarded – undo
19 19
      * @var string
20 20
      * @access protected
21 21
      */
22
-    protected $_xss_hash			= '';
22
+    protected $_xss_hash = '';
23 23
 
24 24
     /**
25 25
      * List of never allowed strings
@@ -174,7 +174,7 @@  discard block
 block discarded – undo
174 174
         }
175 175
         else
176 176
         {
177
-            $str = str_replace(array('<?', '?' . '>'), array('&lt;?', '?&gt;'), $str);
177
+            $str = str_replace(array('<?', '?'.'>'), array('&lt;?', '?&gt;'), $str);
178 178
         }
179 179
 
180 180
         /*
@@ -194,12 +194,12 @@  discard block
 block discarded – undo
194 194
 
195 195
             for ($i = 0, $wordlen = strlen($word); $i < $wordlen; $i++)
196 196
             {
197
-                $temp .= substr($word, $i, 1) . "\s*";
197
+                $temp .= substr($word, $i, 1)."\s*";
198 198
             }
199 199
 
200 200
             // We only want to do this when it is followed by a non-word character
201 201
             // That way valid stuff like "dealer to" does not become "dealerto"
202
-            $str = preg_replace_callback('#(' . substr($temp, 0, -3) . ')(\W)#is', array($this, '_compact_exploded_words'), $str);
202
+            $str = preg_replace_callback('#('.substr($temp, 0, -3).')(\W)#is', array($this, '_compact_exploded_words'), $str);
203 203
         }
204 204
 
205 205
         /*
@@ -244,7 +244,7 @@  discard block
 block discarded – undo
244 244
            * Becomes: &lt;blink&gt;
245 245
            */
246 246
         $naughty = 'alert|applet|audio|basefont|base|behavior|bgsound|blink|body|embed|expression|form|frameset|frame|head|html|ilayer|iframe|input|isindex|layer|link|meta|object|plaintext|style|script|textarea|title|video|xml|xss';
247
-        $str     = preg_replace_callback('#<(/*\s*)(' . $naughty . ')([^><]*)([><]*)#is', array($this, '_sanitize_naughty_html'), $str);
247
+        $str     = preg_replace_callback('#<(/*\s*)('.$naughty.')([^><]*)([><]*)#is', array($this, '_sanitize_naughty_html'), $str);
248 248
 
249 249
         /*
250 250
            * Sanitize naughty scripting elements
@@ -325,7 +325,7 @@  discard block
 block discarded – undo
325 325
         do
326 326
         {
327 327
             $str = preg_replace(
328
-                "#<(/?[^><]+?)([^A-Za-z\-])(" . implode('|', $evil_attributes) . ")(\s*=\s*)([\"][^>]*?[\"]|[\'][^>]*?[\']|[^>]*?)([\s><])([><]*)#i",
328
+                "#<(/?[^><]+?)([^A-Za-z\-])(".implode('|', $evil_attributes).")(\s*=\s*)([\"][^>]*?[\"]|[\'][^>]*?[\']|[^>]*?)([\s><])([><]*)#i",
329 329
                 "<$1$6",
330 330
                 $str, -1, $count
331 331
             );
@@ -353,7 +353,7 @@  discard block
 block discarded – undo
353 353
      * @param	string
354 354
      * @return	string
355 355
      */
356
-    public function entity_decode($str, $charset='UTF-8')
356
+    public function entity_decode($str, $charset = 'UTF-8')
357 357
     {
358 358
         if (stristr($str, '&') === FALSE)
359 359
         {
@@ -396,21 +396,21 @@  discard block
 block discarded – undo
396 396
             '?',
397 397
             "%20",
398 398
             "%22",
399
-            "%3c",		// <
400
-            "%253c",	// <
401
-            "%3e",		// >
402
-            "%0e",		// >
403
-            "%28",		// (
404
-            "%29",		// )
405
-            "%2528",	// (
406
-            "%26",		// &
407
-            "%24",		// $
408
-            "%3f",		// ?
409
-            "%3b",		// ;
399
+            "%3c", // <
400
+            "%253c", // <
401
+            "%3e", // >
402
+            "%0e", // >
403
+            "%28", // (
404
+            "%29", // )
405
+            "%2528", // (
406
+            "%26", // &
407
+            "%24", // $
408
+            "%3f", // ?
409
+            "%3b", // ;
410 410
             "%3d"		// =
411 411
         );
412 412
 
413
-        if ( ! $relative_path)
413
+        if (!$relative_path)
414 414
         {
415 415
             $bad[] = './';
416 416
             $bad[] = '/';
@@ -600,7 +600,7 @@  discard block
 block discarded – undo
600 600
          * Just as above, adds a semicolon if missing.
601 601
          *
602 602
          */
603
-        $str = preg_replace('#(&\#x?)([0-9A-F]+);?#i',"\\1\\2;",$str);
603
+        $str = preg_replace('#(&\#x?)([0-9A-F]+);?#i', "\\1\\2;", $str);
604 604
 
605 605
 
606 606
         return $str;
@@ -638,11 +638,11 @@  discard block
 block discarded – undo
638 638
 
639 639
         if ($url_encoded)
640 640
         {
641
-            $non_displayables[] = '/%0[0-8bcef]/';	// url encoded 00-08, 11, 12, 14, 15
642
-            $non_displayables[] = '/%1[0-9a-f]/';	// url encoded 16-31
641
+            $non_displayables[] = '/%0[0-8bcef]/'; // url encoded 00-08, 11, 12, 14, 15
642
+            $non_displayables[] = '/%1[0-9a-f]/'; // url encoded 16-31
643 643
         }
644 644
 
645
-        $non_displayables[] = '/[\x00-\x08\x0B\x0C\x0E-\x1F\x7F]+/S';	// 00-08, 11, 12, 14-31, 127
645
+        $non_displayables[] = '/[\x00-\x08\x0B\x0C\x0E-\x1F\x7F]+/S'; // 00-08, 11, 12, 14-31, 127
646 646
 
647 647
         do
648 648
         {
Please login to merge, or discard this patch.
Braces   +2 added lines, -4 removed lines patch added patch discarded remove patch
@@ -171,8 +171,7 @@  discard block
 block discarded – undo
171 171
             // closing tags every so often so we skip those and only
172 172
             // do the long opening tags.
173 173
             $str = preg_replace('/<\?(php)/i', "&lt;?\\1", $str);
174
-        }
175
-        else
174
+        } else
176 175
         {
177 176
             $str = str_replace(array('<?', '?' . '>'), array('&lt;?', '?&gt;'), $str);
178 177
         }
@@ -307,8 +306,7 @@  discard block
 block discarded – undo
307 306
         if ($evilAttribute)
308 307
         {
309 308
             $evil_attributes = array('on\w*', 'style', 'xmlns');
310
-        }
311
-        else
309
+        } else
312 310
         {
313 311
             $evil_attributes = array('on\w*', 'xmlns');
314 312
         }
Please login to merge, or discard this patch.
src/Distilleries/Expendable/Http/Middleware/XSS.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -13,7 +13,7 @@
 block discarded – undo
13 13
 
14 14
         $input = $request->all();
15 15
 
16
-        array_walk_recursive($input, function (&$input) {
16
+        array_walk_recursive($input, function(&$input) {
17 17
 
18 18
             $input = (new Security)->xss_clean($input);
19 19
 
Please login to merge, or discard this patch.