Distilleries\Expendable\Models\Permission::getArea()

Complexity

Conditions	4
Paths	6

Size

Total Lines	33
Code Lines	17

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	18
CRAP Score	4

Importance

Changes

0

<?php namespace Distilleries\Expendable\Models;

    public function getArea()

    {

        $roles    = Role::all();

        $services = Service::orderBy('action')->get();

        $services = $services->toArray();


        $groupedServices = [];


        foreach ($services as $service)

        {

            $actions = preg_split('/@/', $service['action']);

It seems like $service['action'] can also be of type Illuminate\Database\Eloquent\Builder&Illuminate\Database\Eloquent\Relations\Relation and Illuminate\Database\Eloquent\Relations\Relation; however, parameter $subject of preg_split() does only seem to accept string, maybe add an additional type check?

            if (count($actions) >= 2)

It seems like $actions can also be of type false; however, parameter $var of count() does only seem to accept Countable|array, maybe add an additional type check?

            {

                $groupedServices[$actions[0]][] = [

                    'id'      => $service['id'],

                    'libelle' => $actions[1]

                ];

            }


        }


        $result = [];

        foreach ($roles as $role)

        {

            $result[] = [

                'libelle' => $role->libelle,

The property libelle does not seem to exist on Distilleries\Expendable\Models\Role. Are you sure there is no database migration missing?

                'id'      => $role->id,

                'choices' => $groupedServices

            ];

        }


        return $result;

    }

}