Distilleries\Expendable\Models\Permission

Complexity

Total Complexity

10

Size/Duplication

Total Lines	73
Duplicated Lines	0 %

Test Coverage

Coverage

100%

Importance

Changes

0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	service()	0	3	1
A	getAreaSelected()	0	19	4
A	getArea()	0	33	4
A	role()	0	3	1

<?php namespace Distilleries\Expendable\Models;


class Permission extends BaseModel {


    protected $fillable = [

        'id',

        'role_id',

        'service_id'

    ];



    public function role()

    {

        return $this->belongsTo('Distilleries\Expendable\Models\Role');

    }


    public function service()

    {

        return $this->belongsTo('Distilleries\Expendable\Models\Service');

    }


    public function getArea()

    {

        $roles    = Role::all();

        $services = Service::orderBy('action')->get();

        $services = $services->toArray();


        $groupedServices = [];


        foreach ($services as $service)

        {

            $actions = preg_split('/@/', $service['action']);

It seems like $service['action'] can also be of type Illuminate\Database\Eloquent\Builder&Illuminate\Database\Eloquent\Relations\Relation and Illuminate\Database\Eloquent\Relations\Relation; however, parameter $subject of preg_split() does only seem to accept string, maybe add an additional type check?

            if (count($actions) >= 2)

It seems like $actions can also be of type false; however, parameter $var of count() does only seem to accept Countable|array, maybe add an additional type check?

            {

                $groupedServices[$actions[0]][] = [

                    'id'      => $service['id'],

                    'libelle' => $actions[1]

                ];

            }


        }


        $result = [];

        foreach ($roles as $role)

        {

            $result[] = [

                'libelle' => $role->libelle,

The property libelle does not seem to exist on Distilleries\Expendable\Models\Role. Are you sure there is no database migration missing?

                'id'      => $role->id,

                'choices' => $groupedServices

            ];

        }


        return $result;

    }


    public function getAreaSelected()

    {

        $roles  = Role::get();

        $result = [];


        foreach ($roles as $role)

        {

            if (empty($result[$role->id]))

            {

                $result[$role->id] = [];

            }


            foreach ($role->permissions as $permission)

            {

                $result[$role->id][] = $permission->service_id;

            }

        }


        return $result;

    }

}