AuthenticateOnceWithBasicAuth::handle() - Code Metrics - Distilleries/Expendable - Measure and Improve Code Quality continuously with Scrutinizer

AuthenticateOnceWithBasicAuth::handle() A
last analyzed 2019-07-10 10:00 UTC

↳ Parent: AuthenticateOnceWithBasicAuth

Complexity

Conditions	5
Paths	3

Size

Total Lines	16
Code Lines	6

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	5
CRAP Score	5.583

Importance

Changes	2
Bugs	0	Features	0

Metric	Value
eloc	6
c	2
b	0
f	0
dl	0
loc	16
ccs	5
cts	7
cp	0.7143
rs	9.6111
cc	5
nc	3
nop	4
crap	5.583

<?php namespace Distilleries\Expendable\Http\Middleware;

use Closure;
use Illuminate\Auth\Middleware\AuthenticateWithBasicAuth;

class AuthenticateOnceWithBasicAuth extends AuthenticateWithBasicAuth {


    /**
     * Handle an incoming request.
     * @param \Illuminate\Http\Request $request
     * @param Closure $next
     * @param null $guard

     * @param null $field

     * @return mixed
     */
    public function handle($request, Closure $next, $guard = null, $field = null)
    {
        $ipsAuth = env('BASIC_AUTH_IP', '');
        $ipsAuth = explode(',', $ipsAuth);


        if (env('BASIC_AUTH', false) == true)
        {
            if (empty($ipsAuth) || !in_array($request->ip(), $ipsAuth))
            {
                return $this->auth->guard($guard)->basic() ?: $next($request);
class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
if ($a->getObject()) {
            }

        }

        return $next($request);
    }

}

1		<?php namespace Distilleries\Expendable\Http\Middleware;
2
3		use Closure;
4		use Illuminate\Auth\Middleware\AuthenticateWithBasicAuth;
5
6		class AuthenticateOnceWithBasicAuth extends AuthenticateWithBasicAuth {
7
8
9		/**
10		* Handle an incoming request.
11		* @param \Illuminate\Http\Request $request
12		* @param Closure $next
13		* @param null $guard
		0 ignored issues – show Documentation Bug introduced 2019-02-20 16:50 UTC by Report Bug Copy Issue Report Are you sure the doc-type for parameter `$guard` is correct as it would always require `null` to be passed? Loading history...
14		* @param null $field
		0 ignored issues – show Documentation Bug introduced 2019-02-20 16:50 UTC by Report Bug Copy Issue Report Are you sure the doc-type for parameter `$field` is correct as it would always require `null` to be passed? Loading history...
15		* @return mixed
16		*/
17	162	public function handle($request, Closure $next, $guard = null, $field = null)
18		{
19	162	$ipsAuth = env('BASIC_AUTH_IP', '');
20	162	$ipsAuth = explode(',', $ipsAuth);
21
22
23	162	if (env('BASIC_AUTH', false) == true)
24		{
25		if (empty($ipsAuth) \|\| !in_array($request->ip(), $ipsAuth))
26		{
27		return $this->auth->guard($guard)->basic() ?: $next($request);
		0 ignored issues – show Bug introduced 2019-02-20 16:50 UTC by Report Bug Copy Issue Report Are you sure the usage of `$this->auth->guard($guard)->basic()` targeting `Illuminate\Auth\SessionGuard::basic()` seems to always return null. This check looks for function or method calls that always return null and whose return value is used. class A { function getObject() { return null; } } $a = new A(); if ($a->getObject()) { The method `getObject()` can return nothing but null, so it makes no sense to use the return value. The reason is most likely that a function or method is imcomplete or has been reduced for debug purposes. Loading history...
28		}
29
30		}
31
32	162	return $next($request);
33		}
34
35		}

Distilleries / Expendable

AuthenticateOnceWithBasicAuth::handle() A last analyzed 2019-07-10 10:00 UTC

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like

AuthenticateOnceWithBasicAuth::handle() A
last analyzed 2019-07-10 10:00 UTC