Distilleries\Expendable\Http\Middleware\AuthenticateOnceWithBasicAuth

Complexity

Total Complexity

5

Size/Duplication

Total Lines	27
Duplicated Lines	0 %

Test Coverage

Coverage

71.43%

Importance

Changes	2
Bugs	0	Features	0

1 Method

Rating	Name	Duplication	Size	Complexity
A	handle()	0	16	5

<?php namespace Distilleries\Expendable\Http\Middleware;

use Closure;
use Illuminate\Auth\Middleware\AuthenticateWithBasicAuth;

class AuthenticateOnceWithBasicAuth extends AuthenticateWithBasicAuth {


    /**
     * Handle an incoming request.
     * @param \Illuminate\Http\Request $request
     * @param Closure $next
     * @param null $guard

Are you sure the doc-type for parameter $guard is correct as it would always require null to be passed?

     * @param null $field

Are you sure the doc-type for parameter $field is correct as it would always require null to be passed?

     * @return mixed
     */
    public function handle($request, Closure $next, $guard = null, $field = null)
    {
        $ipsAuth = env('BASIC_AUTH_IP', '');
        $ipsAuth = explode(',', $ipsAuth);


        if (env('BASIC_AUTH', false) == true)
        {
            if (empty($ipsAuth) || !in_array($request->ip(), $ipsAuth))
            {
                return $this->auth->guard($guard)->basic() ?: $next($request);

Are you sure the usage of $this->auth->guard($guard)->basic() targeting Illuminate\Auth\SessionGuard::basic() seems to always return null.

            }

        }

        return $next($request);
    }

}