DevelopTech / AgilityBundle

Manager/ProjectManager.php

Unused Use Statements -4 removed lines

@@ -3,13 +3,9 @@
 namespace Developtech\AgilityBundle\Manager;
 
 use Doctrine\ORM\EntityManager;
-
 use Developtech\AgilityBundle\Entity\Project;
-
 use Symfony\Component\HttpKernel\Exception\NotFoundHttpException;
-
 use Symfony\Component\Security\Core\User\UserInterface;
-
 use Developtech\AgilityBundle\Utils\Slugger;
 
 class ProjectManager {

Spacing +2 added lines, -2 removed lines

@@ -43,7 +43,7 @@ 
      */
     public function getProject($slug) {
         $project = $this->em->getRepository($this->projectClass)->findOneBySlug($slug);
-        if($project === null) {
+        if ($project === null) {
             throw new NotFoundHttpException('Project not found');
         }
         return $project;
@@ -87,7 +87,7 @@ 
             ->setBetaTestStatus($betaTestStatus)
             ->setNbBetaTesters($nbBetaTesters)
         ;
-        if($productOwner !== null) {
+        if ($productOwner !== null) {
             $project->setProductOwner($productOwner);
         }
         $this->em->flush();

Doc Comments +2 added lines, -2 removed lines

@@ -19,7 +19,7 @@ 
     protected $slugger;
 
     /**
-     * @param Doctrine\ORM\EntityManager $em
+     * @param EntityManager $em
      * @param Slugger $slugger
      */
     public function __construct(EntityManager $em, Slugger $slugger) {
@@ -50,7 +50,7 @@ 
     /**
      * @param string $name
      * @param UserInterface $productOwner
-     * @return \DevelopTech\AgilityBundle\ProjectModel
+     * @return \Developtech\AgilityBundle\Model\ProjectModel
      */
     public function createProject($name, UserInterface $productOwner) {
         $project =

Tests/Manager/FeatureManagerTest.php

Spacing +1 added lines, -1 removed lines

@@ -77,7 +77,7 @@
     }
 
     public function getFeatureMock($id) {
-        if($id === 2) {
+        if ($id === 2) {
             return null;
         }
         return

Unused Use Statements -2 removed lines

@@ -3,10 +3,8 @@
 namespace Developtech\AgilityBundle\Manager;
 
 use Doctrine\ORM\EntityManager;
-
 use Developtech\AgilityBundle\Model\ProjectModel;
 use Developtech\AgilityBundle\Model\FeatureModel;
-
 use Symfony\Component\HttpKernel\Exception\NotFoundHttpException;
 
 class FeatureManager {

Doc Comments +3 added lines

@@ -71,6 +71,9 @@
         $this->assertEquals(3, $this->manager->countFeedbacksPerStatus((new Project())->setId(1), Feedback::STATUS_OPEN));
     }
 
+    /**
+     * @return \Doctrine\ORM\EntityManager
+     */
     public function getEntityManagerMock() {
         $entityManagerMock = $this
             ->getMockBuilder('Doctrine\ORM\EntityManager')

Tests/Manager/ProjectManagerTest.php

Spacing +1 added lines, -1 removed lines

@@ -77,7 +77,7 @@
     }
 
     public function getFeatureMock($id) {
-        if($id === 2) {
+        if ($id === 2) {
             return null;
         }
         return

Doc Comments +4 added lines, -1 removed lines

@@ -63,6 +63,9 @@ 
         $this->manager->editProject(2, 'Unknown project', 'closed', 0);
     }
 
+    /**
+     * @return \Doctrine\ORM\EntityManager
+     */
     public function getEntityManagerMock() {
         $entityManagerMock = $this
             ->getMockBuilder('Doctrine\ORM\EntityManager')
@@ -118,7 +121,7 @@ 
 
     /**
      * @param mixed $id
-     * @return Project|null
+     * @return null|\Developtech\AgilityBundle\Model\ProjectModel
      */
     public function getProjectMock($id) {
         if($id === 2) {

Unused Use Statements -3 removed lines

@@ -3,12 +3,9 @@
 namespace Developtech\AgilityBundle\Manager;
 
 use Doctrine\ORM\EntityManager;
-
 use Developtech\AgilityBundle\Model\ProjectModel;
 use Developtech\AgilityBundle\Model\FeatureModel;
-
 use Symfony\Component\HttpKernel\Exception\NotFoundHttpException;
-
 use Developtech\AgilityBundle\Utils\Slugger;
 
 class FeatureManager {

Manager/FeatureManager.php

Indentation +1 added lines, -1 removed lines

@@ -49,7 +49,7 @@
     }
 
     /**
-    *  @param ProjectModel $project
+     *  @param ProjectModel $project
      * @param string $name
      * @param string $description
      * @param integer $status

Spacing +1 added lines, -1 removed lines

@@ -41,7 +41,7 @@
      * @return FeatureModel
      */
     public function getFeature($id) {
-        if(($feature = $this->em->getRepository(Feature::class)->find($id)) === null) {
+        if (($feature = $this->em->getRepository(Feature::class)->find($id)) === null) {
             throw new NotFoundHttpException('Feature not found');
         }
         return $feature;

Tests/Manager/FeedbackManagerTest.php

Spacing +1 added lines, -1 removed lines

@@ -77,7 +77,7 @@
     }
 
     public function getFeatureMock($id) {
-        if($id === 2) {
+        if ($id === 2) {
             return null;
         }
         return

Doc Comments +3 added lines

@@ -71,6 +71,9 @@
         $this->assertEquals(3, $this->manager->countFeedbacksPerStatus((new Project())->setId(1), Feedback::STATUS_OPEN));
     }
 
+    /**
+     * @return \Doctrine\ORM\EntityManager
+     */
     public function getEntityManagerMock() {
         $entityManagerMock = $this
             ->getMockBuilder('Doctrine\ORM\EntityManager')

Unused Use Statements -2 removed lines

@@ -3,10 +3,8 @@
 namespace Developtech\AgilityBundle\Manager;
 
 use Doctrine\ORM\EntityManager;
-
 use Developtech\AgilityBundle\Model\ProjectModel;
 use Developtech\AgilityBundle\Model\FeatureModel;
-
 use Symfony\Component\HttpKernel\Exception\NotFoundHttpException;
 
 class FeatureManager {

Manager/FeedbackManager.php

Indentation +7 added lines, -7 removed lines

@@ -41,13 +41,13 @@
     }
 
     /**
-    * @param ProjectModel $project
-    * @param UserInterface $author
-    * @param array $orderBy
-    * @param integer $limit
-    * @param integer $offset
-    * @return array
-    */
+     * @param ProjectModel $project
+     * @param UserInterface $author
+     * @param array $orderBy
+     * @param integer $limit
+     * @param integer $offset
+     * @return array
+     */
     public function getProjectFeedbacksByAuthor(ProjectModel $project, UserInterface $author, $orderBy = null, $limit = null, $offset = null) {
         return $this->em->getRepository($this->feedbackClass)->findBy([
             'project' => $project,

Spacing +1 added lines, -1 removed lines

@@ -58,7 +58,7 @@
      * @return FeedbackModel
      */
     public function getFeedback($id) {
-        if(($feedback = $this->em->getRepository(Feedback::class)->find($id)) === null) {
+        if (($feedback = $this->em->getRepository(Feedback::class)->find($id)) === null) {
             throw new NotFoundHttpException('Feedback not found');
         }
         return $feedback;

Entity/Project.php

Unused Use Statements -1 removed lines

@@ -3,7 +3,6 @@
 namespace Developtech\AgilityBundle\Manager;
 
 use Doctrine\ORM\EntityManager;
-
 use Developtech\AgilityBundle\Model\ProjectModel;
 
 class FeedbackManager {

EventSubscriber/DynamicRelationSubscriber.php

Doc Comments +3 added lines, -3 removed lines

@@ -57,7 +57,7 @@ 
     }
 
     /**
-     * @param CLassMetadata $metadata
+     * @param ClassMetadata $metadata
      * @param UnderscoreNamingStrategy $namingStrategy
      */
     public function mapProject(ClassMetadata $metadata, UnderscoreNamingStrategy $namingStrategy) {
@@ -72,7 +72,7 @@ 
     }
 
     /**
-     * @param CLassMetadata $metadata
+     * @param ClassMetadata $metadata
      * @param UnderscoreNamingStrategy $namingStrategy
      */
     public function mapFeature(ClassMetadata $metadata, UnderscoreNamingStrategy $namingStrategy) {
@@ -87,7 +87,7 @@ 
     }
 
     /**
-     * @param CLassMetadata $metadata
+     * @param ClassMetadata $metadata
      * @param UnderscoreNamingStrategy $namingStrategy
      */
     public function mapFeedback(ClassMetadata $metadata, UnderscoreNamingStrategy $namingStrategy) {

Spacing +1 added lines, -1 removed lines

@@ -48,7 +48,7 @@
             ->getNamingStrategy()
         ;
 
-        switch($metadata->getName()) {
+        switch ($metadata->getName()) {
             case self::MODEL_PROJECT: return $this->mapProject($metadata, $namingStrategy);
             case self::MODEL_FEATURE: return $this->mapFeature($metadata, $namingStrategy);
             case self::MODEL_FEEDBACK: return $this->mapFeedback($metadata, $namingStrategy);

Model/ProjectModel.php

Unused Use Statements -2 removed lines

@@ -2,8 +2,6 @@
 
 namespace Developtech\AgilityBundle\Model;
 
-use Doctrine\ORM\Mapping as ORM;
-
 use Doctrine\Common\Collections\ArrayCollection;
 
 /**