Completed
Push — master ( 651cee...b2acd3 )
by Axel
05:20 queued 02:47
created
Entity/Project.php 1 patch
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -3,7 +3,6 @@
 block discarded – undo
3 3
 namespace Developtech\AgilityBundle\Manager;
4 4
 
5 5
 use Doctrine\ORM\EntityManager;
6
-
7 6
 use Developtech\AgilityBundle\Model\ProjectModel;
8 7
 
9 8
 class FeedbackManager {
Please login to merge, or discard this patch.
EventSubscriber/DynamicRelationSubscriber.php 2 patches
Doc Comments   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -57,7 +57,7 @@  discard block
 block discarded – undo
57 57
     }
58 58
 
59 59
     /**
60
-     * @param CLassMetadata $metadata
60
+     * @param ClassMetadata $metadata
61 61
      * @param UnderscoreNamingStrategy $namingStrategy
62 62
      */
63 63
     public function mapProject(ClassMetadata $metadata, UnderscoreNamingStrategy $namingStrategy) {
@@ -72,7 +72,7 @@  discard block
 block discarded – undo
72 72
     }
73 73
 
74 74
     /**
75
-     * @param CLassMetadata $metadata
75
+     * @param ClassMetadata $metadata
76 76
      * @param UnderscoreNamingStrategy $namingStrategy
77 77
      */
78 78
     public function mapFeature(ClassMetadata $metadata, UnderscoreNamingStrategy $namingStrategy) {
@@ -87,7 +87,7 @@  discard block
 block discarded – undo
87 87
     }
88 88
 
89 89
     /**
90
-     * @param CLassMetadata $metadata
90
+     * @param ClassMetadata $metadata
91 91
      * @param UnderscoreNamingStrategy $namingStrategy
92 92
      */
93 93
     public function mapFeedback(ClassMetadata $metadata, UnderscoreNamingStrategy $namingStrategy) {
Please login to merge, or discard this patch.
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -48,7 +48,7 @@
 block discarded – undo
48 48
             ->getNamingStrategy()
49 49
         ;
50 50
 
51
-        switch($metadata->getName()) {
51
+        switch ($metadata->getName()) {
52 52
             case self::MODEL_PROJECT: return $this->mapProject($metadata, $namingStrategy);
53 53
             case self::MODEL_FEATURE: return $this->mapFeature($metadata, $namingStrategy);
54 54
             case self::MODEL_FEEDBACK: return $this->mapFeedback($metadata, $namingStrategy);
Please login to merge, or discard this patch.
Manager/ProjectManager.php 1 patch
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -19,7 +19,7 @@  discard block
 block discarded – undo
19 19
     protected $slugger;
20 20
 
21 21
     /**
22
-     * @param Doctrine\ORM\EntityManager $em
22
+     * @param EntityManager $em
23 23
      * @param Slugger $slugger
24 24
      */
25 25
     public function __construct(EntityManager $em, Slugger $slugger) {
@@ -50,7 +50,7 @@  discard block
 block discarded – undo
50 50
     /**
51 51
      * @param string $name
52 52
      * @param UserInterface $productOwner
53
-     * @return \DevelopTech\AgilityBundle\ProjectModel
53
+     * @return \Developtech\AgilityBundle\Model\ProjectModel
54 54
      */
55 55
     public function createProject($name, UserInterface $productOwner) {
56 56
         $project =
Please login to merge, or discard this patch.
Model/ProjectModel.php 1 patch
Unused Use Statements   -2 removed lines patch added patch discarded remove patch
@@ -2,8 +2,6 @@
 block discarded – undo
2 2
 
3 3
 namespace Developtech\AgilityBundle\Model;
4 4
 
5
-use Doctrine\ORM\Mapping as ORM;
6
-
7 5
 use Doctrine\Common\Collections\ArrayCollection;
8 6
 
9 7
 /**
Please login to merge, or discard this patch.
Tests/Manager/FeatureManagerTest.php 2 patches
Unused Use Statements   -2 removed lines patch added patch discarded remove patch
@@ -3,10 +3,8 @@
 block discarded – undo
3 3
 namespace Developtech\AgilityBundle\Manager;
4 4
 
5 5
 use Doctrine\ORM\EntityManager;
6
-
7 6
 use Developtech\AgilityBundle\Model\ProjectModel;
8 7
 use Developtech\AgilityBundle\Model\FeatureModel;
9
-
10 8
 use Symfony\Component\HttpKernel\Exception\NotFoundHttpException;
11 9
 
12 10
 class FeatureManager {
Please login to merge, or discard this patch.
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -71,6 +71,9 @@
 block discarded – undo
71 71
         $this->assertEquals(3, $this->manager->countFeedbacksPerStatus((new Project())->setId(1), Feedback::STATUS_OPEN));
72 72
     }
73 73
 
74
+    /**
75
+     * @return \Doctrine\ORM\EntityManager
76
+     */
74 77
     public function getEntityManagerMock() {
75 78
         $entityManagerMock = $this
76 79
             ->getMockBuilder('Doctrine\ORM\EntityManager')
Please login to merge, or discard this patch.
Tests/Manager/FeedbackManagerTest.php 2 patches
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -71,6 +71,9 @@
 block discarded – undo
71 71
         $this->assertEquals(3, $this->manager->countFeedbacksPerStatus((new Project())->setId(1), Feedback::STATUS_OPEN));
72 72
     }
73 73
 
74
+    /**
75
+     * @return \Doctrine\ORM\EntityManager
76
+     */
74 77
     public function getEntityManagerMock() {
75 78
         $entityManagerMock = $this
76 79
             ->getMockBuilder('Doctrine\ORM\EntityManager')
Please login to merge, or discard this patch.
Unused Use Statements   -2 removed lines patch added patch discarded remove patch
@@ -3,10 +3,8 @@
 block discarded – undo
3 3
 namespace Developtech\AgilityBundle\Manager;
4 4
 
5 5
 use Doctrine\ORM\EntityManager;
6
-
7 6
 use Developtech\AgilityBundle\Model\ProjectModel;
8 7
 use Developtech\AgilityBundle\Model\FeatureModel;
9
-
10 8
 use Symfony\Component\HttpKernel\Exception\NotFoundHttpException;
11 9
 
12 10
 class FeatureManager {
Please login to merge, or discard this patch.
Tests/Manager/ProjectManagerTest.php 1 patch
Doc Comments   +4 added lines, -1 removed lines patch added patch discarded remove patch
@@ -63,6 +63,9 @@  discard block
 block discarded – undo
63 63
         $this->manager->editProject(2, 'Unknown project', 'closed', 0);
64 64
     }
65 65
 
66
+    /**
67
+     * @return \Doctrine\ORM\EntityManager
68
+     */
66 69
     public function getEntityManagerMock() {
67 70
         $entityManagerMock = $this
68 71
             ->getMockBuilder('Doctrine\ORM\EntityManager')
@@ -118,7 +121,7 @@  discard block
 block discarded – undo
118 121
 
119 122
     /**
120 123
      * @param mixed $id
121
-     * @return Project|null
124
+     * @return null|\Developtech\AgilityBundle\Model\ProjectModel
122 125
      */
123 126
     public function getProjectMock($id) {
124 127
         if($id === 2) {
Please login to merge, or discard this patch.
Manager/FeatureManager.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -41,7 +41,7 @@
 block discarded – undo
41 41
      * @return FeatureModel
42 42
      */
43 43
     public function getFeature($id) {
44
-        if(($feature = $this->em->getRepository(Feature::class)->find($id)) === null) {
44
+        if (($feature = $this->em->getRepository(Feature::class)->find($id)) === null) {
45 45
             throw new NotFoundHttpException('Feature not found');
46 46
         }
47 47
         return $feature;
Please login to merge, or discard this patch.
Manager/FeedbackManager.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -58,7 +58,7 @@
 block discarded – undo
58 58
      * @return FeedbackModel
59 59
      */
60 60
     public function getFeedback($id) {
61
-        if(($feedback = $this->em->getRepository(Feedback::class)->find($id)) === null) {
61
+        if (($feedback = $this->em->getRepository(Feedback::class)->find($id)) === null) {
62 62
             throw new NotFoundHttpException('Feedback not found');
63 63
         }
64 64
         return $feedback;
Please login to merge, or discard this patch.