DevelopTech / AgilityBundle

Manager/ProjectManager.php

Unused Use Statements -4 removed lines

@@ -3,13 +3,9 @@
 namespace Developtech\AgilityBundle\Manager;
 
 use Doctrine\ORM\EntityManager;
-
 use Developtech\AgilityBundle\Entity\Project;
-
 use Symfony\Component\HttpKernel\Exception\NotFoundHttpException;
-
 use Symfony\Component\Security\Core\User\UserInterface;
-
 use Developtech\AgilityBundle\Utils\Slugger;
 
 class ProjectManager {

Doc Comments +2 added lines, -2 removed lines

@@ -19,7 +19,7 @@ 
     protected $slugger;
 
     /**
-     * @param Doctrine\ORM\EntityManager $em
+     * @param EntityManager $em
      * @param Slugger $slugger
      */
     public function __construct(EntityManager $em, Slugger $slugger) {
@@ -51,7 +51,7 @@ 
      * @param string $name
 	 * @param string $description
      * @param UserInterface $productOwner
-     * @return \DevelopTech\AgilityBundle\ProjectModel
+     * @return \Developtech\AgilityBundle\Model\ProjectModel
      */
     public function createProject($name, $description, UserInterface $productOwner) {
         $project =

Indentation +4 added lines, -4 removed lines

@@ -49,7 +49,7 @@ 
 
     /**
      * @param string $name
-	 * @param string $description
+     * @param string $description
      * @param UserInterface $productOwner
      * @return \DevelopTech\AgilityBundle\ProjectModel
      */
@@ -58,7 +58,7 @@ 
             (new Project())
             ->setName($name)
             ->setSlug($this->slugger->slugify($name))
-			->setDescription($description)
+            ->setDescription($description)
             ->setProductOwner($productOwner)
         ;
 		
@@ -71,7 +71,7 @@ 
     /**
      * @param integer $id
      * @param string $name
-	 * @param string $description
+     * @param string $description
      * @param UserInterface $productOwner
      * @throws NotFoundHttpException
      * @return ProjectModel
@@ -83,7 +83,7 @@ 
         $project
             ->setName($name)
             ->setSlug($this->slugger->slugify($name))
-			->setDescription($description)
+            ->setDescription($description)
         ;
         if($productOwner !== null) {
             $project->setProductOwner($productOwner);

Spacing +2 added lines, -2 removed lines

@@ -41,7 +41,7 @@ 
      */
     public function getProject($slug) {
         $project = $this->em->getRepository(Project::class)->findOneBySlug($slug);
-        if($project === null) {
+        if ($project === null) {
             throw new NotFoundHttpException('Project not found');
         }
         return $project;
@@ -85,7 +85,7 @@ 
             ->setSlug($this->slugger->slugify($name))
 			->setDescription($description)
         ;
-        if($productOwner !== null) {
+        if ($productOwner !== null) {
             $project->setProductOwner($productOwner);
         }
 		

Tests/Manager/ProjectManagerTest.php

Spacing +1 added lines, -1 removed lines

@@ -121,7 +121,7 @@
      * @return Project|null
      */
     public function getProjectMock($id) {
-        if($id === 2) {
+        if ($id === 2) {
             return null;
         }
         return

Doc Comments +4 added lines, -1 removed lines

@@ -63,6 +63,9 @@ 
         $this->manager->editProject(2, 'Unknown project', 'Where is my project ?');
     }
 
+    /**
+     * @return \Doctrine\ORM\EntityManager
+     */
     public function getEntityManagerMock() {
         $entityManagerMock = $this
             ->getMockBuilder('Doctrine\ORM\EntityManager')
@@ -118,7 +121,7 @@ 
 
     /**
      * @param mixed $id
-     * @return Project|null
+     * @return null|\Developtech\AgilityBundle\Model\ProjectModel
      */
     public function getProjectMock($id) {
         if($id === 2) {

Unused Use Statements -3 removed lines

@@ -3,12 +3,9 @@
 namespace Developtech\AgilityBundle\Tests\Manager;
 
 use Developtech\AgilityBundle\Manager\ProjectManager;
-
 use Developtech\AgilityBundle\Entity\Project;
 use Developtech\AgilityBundle\Tests\Mock\User;
-
 use Developtech\AgilityBundle\Utils\Slugger;
-
 use Symfony\Component\HttpKernel\Exception\NotFoundHttpException;
 
 class ProjectManagerTest extends \PHPUnit_Framework_TestCase {

Tests/Manager/FeatureManagerTest.php

Spacing +1 added lines, -1 removed lines

@@ -77,7 +77,7 @@
     }
 
     public function getFeatureMock($id) {
-        if($id === 2) {
+        if ($id === 2) {
             return null;
         }
         return

Doc Comments +3 added lines

@@ -59,6 +59,9 @@
         $this->assertEquals(95, $feature->getProductOwnerValue());
     }
 
+    /**
+     * @return \Doctrine\ORM\EntityManager
+     */
     public function getEntityManagerMock() {
         $entityManagerMock = $this
             ->getMockBuilder('Doctrine\ORM\EntityManager')

Unused Use Statements -2 removed lines

@@ -3,11 +3,9 @@
 namespace Developtech\AgilityBundle\Tests\Manager;
 
 use Developtech\AgilityBundle\Manager\FeatureManager;
-
 use Developtech\AgilityBundle\Entity\Feature;
 use Developtech\AgilityBundle\Tests\Mock\User;
 use Developtech\AgilityBundle\Entity\Project;
-
 use Developtech\AgilityBundle\Utils\Slugger;
 
 class FeatureManagerTest extends \PHPUnit_Framework_TestCase {

Manager/FeatureManager.php

Indentation +1 added lines, -1 removed lines

@@ -49,7 +49,7 @@
     }
 
     /**
-    *  @param ProjectModel $project
+     *  @param ProjectModel $project
      * @param string $name
      * @param string $description
      * @param integer $status

Spacing +1 added lines, -1 removed lines

@@ -22,7 +22,7 @@
      * @return Feature
      */
     public function getFeature($id) {
-        if(($feature = $this->em->getRepository(Feature::class)->find($id)) === null) {
+        if (($feature = $this->em->getRepository(Feature::class)->find($id)) === null) {
             throw new NotFoundHttpException('Feature not found');
         }
         return $feature;

Tests/Manager/FeedbackManagerTest.php

Doc Comments +3 added lines

@@ -71,6 +71,9 @@
         $this->assertEquals(3, $this->manager->countFeedbacksPerStatus((new Project())->setId(1), Feedback::STATUS_OPEN));
     }
 
+    /**
+     * @return \Doctrine\ORM\EntityManager
+     */
     public function getEntityManagerMock() {
         $entityManagerMock = $this
             ->getMockBuilder('Doctrine\ORM\EntityManager')

Unused Use Statements -2 removed lines

@@ -3,11 +3,9 @@
 namespace Developtech\AgilityBundle\Tests\Manager;
 
 use Developtech\AgilityBundle\Manager\FeedbackManager;
-
 use Developtech\AgilityBundle\Entity\Feedback;
 use Developtech\AgilityBundle\Tests\Mock\User;
 use Developtech\AgilityBundle\Entity\Project;
-
 use Developtech\AgilityBundle\Utils\Slugger;
 
 class FeedbackManagerTest extends \PHPUnit_Framework_TestCase {

Spacing +1 added lines, -1 removed lines

@@ -131,7 +131,7 @@
     }
 
     public function getFeedbackMock($id) {
-        if($id === 2) {
+        if ($id === 2) {
             return null;
         }
         return

Manager/FeedbackManager.php

Spacing +1 added lines, -1 removed lines

@@ -58,7 +58,7 @@
      * @return FeedbackModel
      */
     public function getFeedback($id) {
-        if(($feedback = $this->em->getRepository(Feedback::class)->find($id)) === null) {
+        if (($feedback = $this->em->getRepository(Feedback::class)->find($id)) === null) {
             throw new NotFoundHttpException('Feedback not found');
         }
         return $feedback;

Indentation +7 added lines, -7 removed lines

@@ -26,13 +26,13 @@
     }
 
     /**
-    * @param ProjectModel $project
-    * @param UserInterface $author
-    * @param array $orderBy
-    * @param integer $limit
-    * @param integer $offset
-    * @return array
-    */
+     * @param ProjectModel $project
+     * @param UserInterface $author
+     * @param array $orderBy
+     * @param integer $limit
+     * @param integer $offset
+     * @return array
+     */
     public function getProjectFeedbacksByAuthor(ProjectModel $project, UserInterface $author, $orderBy = null, $limit = null, $offset = null) {
         return $this->em->getRepository(Feedback::class)->findBy([
             'project' => $project,

Tests/bootstrap.php

Spacing +1 added lines, -1 removed lines

@@ -1,6 +1,6 @@
 <?php
 
-$loader = @include __DIR__ . '/../vendor/autoload.php';
+$loader = @include __DIR__.'/../vendor/autoload.php';
 if (!$loader) {
     die(<<<'EOT'
 You must set up the project dependencies, run the following commands:

Model/JobModel.php

Doc Comments +9 added lines, -9 removed lines

@@ -27,7 +27,7 @@ 
 
   /**
    * @param string $name
-   * @return FeatureModel
+   * @return JobModel
    */
   public function setName($name) {
       $this->name = $name;
@@ -44,7 +44,7 @@ 
 
   /**
    * @param string $slug
-   * @return FeatureModel
+   * @return JobModel
    */
   public function setSlug($slug) {
       $this->slug = $slug;
@@ -61,7 +61,7 @@ 
 
   /**
    * @param string $description
-   * @return FeatureModel
+   * @return JobModel
    */
   public function setDescription($description) {
       $this->description = $description;
@@ -78,7 +78,7 @@ 
 
   /**
    * @param ProjectModel $project
-   * @return FeatureModel
+   * @return JobModel
    */
   public function setProject(ProjectModel $project) {
       $this->project = $project;
@@ -87,7 +87,7 @@ 
   }
 
   /**
-   * @return FeatureModel
+   * @return ProjectModel
    */
   public function getProject() {
       return $this->project;
@@ -95,7 +95,7 @@ 
 
   /**
    * @param integer $status
-   * @return FeatureModel
+   * @return JobModel
    */
   public function setStatus($status) {
       $this->status = $status;
@@ -112,7 +112,7 @@ 
 
   /**
    * @param UserInterface $responsible
-   * @return FeatureModel
+   * @return JobModel
    */
   public function setResponsible(UserInterface $responsible = null) {
       $this->responsible = $responsible;
@@ -133,7 +133,7 @@ 
    *
    * @param \DateTime $createdAt
    *
-   * @return ProjectModel
+   * @return JobModel
    */
   public function setCreatedAt($createdAt)
   {
@@ -157,7 +157,7 @@ 
    *
    * @param \DateTime $updatedAt
    *
-   * @return ProjectModel
+   * @return JobModel
    */
   public function setUpdatedAt($updatedAt)
   {

Indentation +170 added lines, -170 removed lines

@@ -5,174 +5,174 @@
 use Symfony\Component\Security\Core\User\UserInterface;
 
 abstract class JobModel {
-  /** @var string */
-  protected $name;
-  /** @var string */
-  protected $slug;
-  /** @var string*/
-  protected $description;
-  /** @var \DateTime*/
-  protected $createdAt;
-  /** @var \DateTime */
-  protected $updatedAt;
-  /** @var integer */
-  protected $status;
-  /** @var ProjectModel */
-  protected $project;
-  /** @var object */
-  protected $responsible;
-
-  const TYPE_FEATURE = 'US';
-  const TYPE_FEEDBACK = 'FB';
-
-  /**
-   * @param string $name
-   * @return FeatureModel
-   */
-  public function setName($name) {
-      $this->name = $name;
-
-      return $this;
-  }
-
-  /**
-   * @return string
-   */
-  public function getName() {
-      return $this->name;
-  }
-
-  /**
-   * @param string $slug
-   * @return FeatureModel
-   */
-  public function setSlug($slug) {
-      $this->slug = $slug;
-
-      return $this;
-  }
-
-  /**
-   * @return string
-   */
-  public function getSlug() {
-      return $this->slug;
-  }
-
-  /**
-   * @param string $description
-   * @return FeatureModel
-   */
-  public function setDescription($description) {
-      $this->description = $description;
-
-      return $this;
-  }
-
-  /**
-   * @return string
-   */
-  public function getDescription() {
-      return $this->description;
-  }
-
-  /**
-   * @param ProjectModel $project
-   * @return FeatureModel
-   */
-  public function setProject(ProjectModel $project) {
-      $this->project = $project;
-
-      return $this;
-  }
-
-  /**
-   * @return FeatureModel
-   */
-  public function getProject() {
-      return $this->project;
-  }
-
-  /**
-   * @param integer $status
-   * @return FeatureModel
-   */
-  public function setStatus($status) {
-      $this->status = $status;
-
-      return $this;
-  }
-
-  /**
-   * @return integer
-   */
-  public function getStatus() {
-      return $this->status;
-  }
-
-  /**
-   * @param UserInterface $responsible
-   * @return FeatureModel
-   */
-  public function setResponsible(UserInterface $responsible = null) {
-      $this->responsible = $responsible;
-
-      return $this;
-  }
-
-  /**
-   * @return object
-   */
-  public function getResponsible() {
-      return $this->responsible;
-  }
-
-
-  /**
-   * Set createdAt
-   *
-   * @param \DateTime $createdAt
-   *
-   * @return ProjectModel
-   */
-  public function setCreatedAt($createdAt)
-  {
-      $this->createdAt = $createdAt;
-
-      return $this;
-  }
-
-  /**
-   * Get createdAt
-   *
-   * @return \DateTime
-   */
-  public function getCreatedAt()
-  {
-      return $this->createdAt;
-  }
-
-  /**
-   * Set updatedAt
-   *
-   * @param \DateTime $updatedAt
-   *
-   * @return ProjectModel
-   */
-  public function setUpdatedAt($updatedAt)
-  {
-      $this->updatedAt = $updatedAt;
-
-      return $this;
-  }
-
-  /**
-   * Get updatedAt
-   *
-   * @return \DateTime
-   */
-  public function getUpdatedAt()
-  {
-      return $this->updatedAt;
-  }
+    /** @var string */
+    protected $name;
+    /** @var string */
+    protected $slug;
+    /** @var string*/
+    protected $description;
+    /** @var \DateTime*/
+    protected $createdAt;
+    /** @var \DateTime */
+    protected $updatedAt;
+    /** @var integer */
+    protected $status;
+    /** @var ProjectModel */
+    protected $project;
+    /** @var object */
+    protected $responsible;
+
+    const TYPE_FEATURE = 'US';
+    const TYPE_FEEDBACK = 'FB';
+
+    /**
+     * @param string $name
+     * @return FeatureModel
+     */
+    public function setName($name) {
+        $this->name = $name;
+
+        return $this;
+    }
+
+    /**
+     * @return string
+     */
+    public function getName() {
+        return $this->name;
+    }
+
+    /**
+     * @param string $slug
+     * @return FeatureModel
+     */
+    public function setSlug($slug) {
+        $this->slug = $slug;
+
+        return $this;
+    }
+
+    /**
+     * @return string
+     */
+    public function getSlug() {
+        return $this->slug;
+    }
+
+    /**
+     * @param string $description
+     * @return FeatureModel
+     */
+    public function setDescription($description) {
+        $this->description = $description;
+
+        return $this;
+    }
+
+    /**
+     * @return string
+     */
+    public function getDescription() {
+        return $this->description;
+    }
+
+    /**
+     * @param ProjectModel $project
+     * @return FeatureModel
+     */
+    public function setProject(ProjectModel $project) {
+        $this->project = $project;
+
+        return $this;
+    }
+
+    /**
+     * @return FeatureModel
+     */
+    public function getProject() {
+        return $this->project;
+    }
+
+    /**
+     * @param integer $status
+     * @return FeatureModel
+     */
+    public function setStatus($status) {
+        $this->status = $status;
+
+        return $this;
+    }
+
+    /**
+     * @return integer
+     */
+    public function getStatus() {
+        return $this->status;
+    }
+
+    /**
+     * @param UserInterface $responsible
+     * @return FeatureModel
+     */
+    public function setResponsible(UserInterface $responsible = null) {
+        $this->responsible = $responsible;
+
+        return $this;
+    }
+
+    /**
+     * @return object
+     */
+    public function getResponsible() {
+        return $this->responsible;
+    }
+
+
+    /**
+     * Set createdAt
+     *
+     * @param \DateTime $createdAt
+     *
+     * @return ProjectModel
+     */
+    public function setCreatedAt($createdAt)
+    {
+        $this->createdAt = $createdAt;
+
+        return $this;
+    }
+
+    /**
+     * Get createdAt
+     *
+     * @return \DateTime
+     */
+    public function getCreatedAt()
+    {
+        return $this->createdAt;
+    }
+
+    /**
+     * Set updatedAt
+     *
+     * @param \DateTime $updatedAt
+     *
+     * @return ProjectModel
+     */
+    public function setUpdatedAt($updatedAt)
+    {
+        $this->updatedAt = $updatedAt;
+
+        return $this;
+    }
+
+    /**
+     * Get updatedAt
+     *
+     * @return \DateTime
+     */
+    public function getUpdatedAt()
+    {
+        return $this->updatedAt;
+    }
 }

Repository/FeedbackRepository.php

Spacing +2 added lines, -2 removed lines

@@ -21,8 +21,8 @@
      */
     public function countPerStatus(ProjectModel $project, $status) {
         $statement = $this->getEntityManager()->getConnection()->prepare(
-            "SELECT COUNT(*) as nb_feedbacks FROM {$this->getEntityManager()->getClassMetadata(Job::class)->getTableName()} " .
-            "WHERE project_id = :project_id AND status = :status AND type = '" . Job::TYPE_FEEDBACK . "'"
+            "SELECT COUNT(*) as nb_feedbacks FROM {$this->getEntityManager()->getClassMetadata(Job::class)->getTableName()} ".
+            "WHERE project_id = :project_id AND status = :status AND type = '".Job::TYPE_FEEDBACK."'"
         );
         $statement->execute([
             'project_id' => $project->getId(),