Dev-Int / glsr

src/AppBundle/Controller/UserController.php

Doc Comments +1 added lines, -1 removed lines

@@ -216,7 +216,7 @@
      * @param  string        $name   route/entity name
      * @param  string        $route  route name, if different from entity name
      * @param  array         $params possible route parameters
-     * @return Response
+     * @return \Symfony\Component\HttpFoundation\RedirectResponse|null
      */
     protected function saveFilter(FormInterface $form, $name, $route = null, array $params = null)
     {

Spacing +3 added lines, -3 removed lines

@@ -204,11 +204,11 @@ 
         $url = $this->generateUrl($route ?: $name, is_null($params) ? array() : $params);
         if (isset($request)) {
             if ($request->query->has('submit-filter') && $form->handleRequest($request)->isValid()) {
-                $request->getSession()->set('filter.' . $name, $request->query->get($form->getName()));
+                $request->getSession()->set('filter.'.$name, $request->query->get($form->getName()));
 
                 return $this->redirect($url);
             } elseif ($request->query->has('reset-filter')) {
-                $request->getSession()->set('filter.' . $name, null);
+                $request->getSession()->set('filter.'.$name, null);
 
                 return $this->redirect($url);
             }
@@ -244,7 +244,7 @@ 
      */
     protected function getFilter($name)
     {
-        return $this->getRequest()->getSession()->get('filter.' . $name);
+        return $this->getRequest()->getSession()->get('filter.'.$name);
     }
 
     /**

Unused Use Statements +6 added lines, -6 removed lines

@@ -14,17 +14,17 @@
  */
 namespace AppBundle\Controller;
 
-use Symfony\Component\HttpFoundation\Request;
 use AppBundle\Controller\AbstractController;
+use AppBundle\Entity\User;
+use AppBundle\Form\Type\UserFilterType;
+use AppBundle\Form\Type\UserType;
+use Doctrine\ORM\QueryBuilder;
 use Sensio\Bundle\FrameworkExtraBundle\Configuration\Method;
 use Sensio\Bundle\FrameworkExtraBundle\Configuration\Route;
-use Sensio\Bundle\FrameworkExtraBundle\Configuration\Template;
 use Sensio\Bundle\FrameworkExtraBundle\Configuration\Security;
-use AppBundle\Entity\User;
-use AppBundle\Form\Type\UserType;
-use AppBundle\Form\Type\UserFilterType;
+use Sensio\Bundle\FrameworkExtraBundle\Configuration\Template;
 use Symfony\Component\Form\FormInterface;
-use Doctrine\ORM\QueryBuilder;
+use Symfony\Component\HttpFoundation\Request;
 
 /**
  * User controller.

src/AppBundle/Entity/Settings.php

Doc Comments +1 added lines, -1 removed lines

@@ -129,7 +129,7 @@
     /**
      * Set first_inventory.
      *
-     * @param datetime $firstInventory Date du premier inventaire
+     * @param \DateTime $firstInventory Date du premier inventaire
      *
      * @return Settings
      */

src/AppBundle/Tests/Controller/UserControllerTest.php

Indentation +2 added lines, -2 removed lines

@@ -94,8 +94,8 @@
     }
 
 /**
-     * @depends testCreate
-     */
+ * @depends testCreate
+ */
 
     public function testSort() {
         $client = static::createClient();

Braces +16 added lines, -8 removed lines

@@ -4,9 +4,11 @@ 
 
 use Symfony\Bundle\FrameworkBundle\Test\WebTestCase;
 
-class UserControllerTest extends WebTestCase {
+class UserControllerTest extends WebTestCase
+{
 
-    public function testCreate() {
+    public function testCreate()
+    {
         $client = static::createClient();
         $crawler = $client->request('GET', '/admin/users/');
         $this->assertCount(0, $crawler->filter('table.records_list tbody tr'));
@@ -19,7 +21,8 @@ 
         $this->assertCount(1, $crawler->filter('table.records_list tbody tr'));
     }
 
-    public function testCreateError() {
+    public function testCreateError()
+    {
         $client = static::createClient();
         $crawler = $client->request('GET', '/admin/users/new');
         $form = $crawler->filter('form button[type="submit"]')->form();
@@ -31,7 +34,8 @@ 
     /**
      * @depends testCreate
      */
-    public function testEdit() {
+    public function testEdit()
+    {
         $client = static::createClient();
         $crawler = $client->request('GET', '/admin/users/');
         $this->assertCount(1, $crawler->filter('table.records_list tbody tr:contains("First value")'));
@@ -50,7 +54,8 @@ 
     /**
      * @depends testCreate
      */
-    public function testEditError() {
+    public function testEditError()
+    {
         $client = static::createClient();
         $crawler = $client->request('GET', '/admin/users/');
         $crawler = $client->click($crawler->filter('table.records_list tbody tr td .btn-group a')->eq(1)->link());
@@ -65,7 +70,8 @@ 
     /**
      * @depends testCreate
      */
-    public function testDelete() {
+    public function testDelete()
+    {
         $client = static::createClient();
         $crawler = $client->request('GET', '/admin/users/');
         $this->assertTrue($client->getResponse()->isSuccessful());
@@ -79,7 +85,8 @@ 
     /**
      * @depends testCreate
      */
-    public function testFilter() {
+    public function testFilter()
+    {
         $client = static::createClient();
         $crawler = $client->request('GET', '/admin/users/');
         $form = $crawler->filter('div#filter form button[type="submit"]')->form(array(
@@ -97,7 +104,8 @@ 
      * @depends testCreate
      */
 
-    public function testSort() {
+    public function testSort()
+    {
         $client = static::createClient();
         $crawler = $client->request('GET', '/admin/users/');
         $this->assertCount(1, $crawler->filter('table.records_list th')->eq(0)->filter('a i.fa-sort'));

src/AppBundle/Form/Type/UserFilterType.php

Spacing +1 added lines, -1 removed lines

@@ -22,7 +22,7 @@
                 'class' => 'AppBundle\Entity\Group',
                 'expanded' => true,
                 'multiple' => true,
-                'apply_filter' => function (QueryInterface $filterQuery, $field, $values) {
+                'apply_filter' => function(QueryInterface $filterQuery, $field, $values) {
                     $query = $filterQuery->getQueryBuilder();
                     $query->leftJoin($field, 'm');
                     // Filter results using orWhere matching ID

src/AppBundle/Controller/DefaultController.php

Doc Comments +1 added lines, -1 removed lines

@@ -70,7 +70,7 @@
     /**
      * Test des entités
      *
-     * @return array
+     * @return string|null
      */
     private function testEntities()
     {

Unused Use Statements +2 added lines, -2 removed lines

@@ -14,10 +14,10 @@
  */
 namespace AppBundle\Controller;
 
-use Symfony\Bundle\FrameworkBundle\Controller\Controller;
-use Sensio\Bundle\FrameworkExtraBundle\Configuration\Route;
 use Sensio\Bundle\FrameworkExtraBundle\Configuration\Method;
+use Sensio\Bundle\FrameworkExtraBundle\Configuration\Route;
 use Sensio\Bundle\FrameworkExtraBundle\Configuration\Template;
+use Symfony\Bundle\FrameworkBundle\Controller\Controller;
 use Symfony\Component\HttpFoundation\Response;
 
 /**

src/AppBundle/Menu/RequestVoter.php

Spacing +1 added lines, -1 removed lines

@@ -22,7 +22,7 @@
         if ($item->getUri() === $request->getRequestUri()) {
             // URL's completely match
             return true;
-        } elseif ($item->getUri() !== $request->getBaseUrl() . '/' &&
+        } elseif ($item->getUri() !== $request->getBaseUrl().'/' &&
             substr($request->getRequestUri(), 0, strlen($item->getUri()))
             === $item->getUri()) {
             // URL isn't just "/" and the first part of the URL match

src/AppBundle/Entity/Article.php

Doc Comments +4 added lines, -4 removed lines

@@ -296,7 +296,7 @@ 
     /**
      * Get supplier.
      *
-     * @return Supplier
+     * @return string
      */
     public function getSupplier()
     {
@@ -320,7 +320,7 @@ 
     /**
      * Get unit_storage.
      *
-     * @return UnitStorage
+     * @return string
      */
     public function getUnitStorage()
     {
@@ -357,7 +357,7 @@ 
     /**
      * Get zone_storages.
      *
-     * @return \Doctrine\Common\Collections\Collection
+     * @return string
      */
     public function getZoneStorages()
     {
@@ -381,7 +381,7 @@ 
     /**
      * Get family_log.
      *
-     * @return FamilyLog
+     * @return string
      */
     public function getFamilyLog()
     {

Unused Use Statements +6 added lines, -6 removed lines

@@ -15,15 +15,15 @@
  */
 namespace AppBundle\Entity;
 
-use Doctrine\ORM\Mapping as ORM;
-use Symfony\Component\Validator\Constraints as Assert;
-use Gedmo\Mapping\Annotation as Gedmo;
-use Symfony\Bridge\Doctrine\Validator\Constraints\UniqueEntity;
-use Doctrine\Common\Collections\ArrayCollection;
+use AppBundle\Entity\FamilyLog;
 use AppBundle\Entity\Supplier;
 use AppBundle\Entity\UnitStorage;
 use AppBundle\Entity\ZoneStorage;
-use AppBundle\Entity\FamilyLog;
+use Doctrine\Common\Collections\ArrayCollection;
+use Doctrine\ORM\Mapping as ORM;
+use Gedmo\Mapping\Annotation as Gedmo;
+use Symfony\Bridge\Doctrine\Validator\Constraints\UniqueEntity;
+use Symfony\Component\Validator\Constraints as Assert;
 
 /**
  * Article.

src/AppBundle/Entity/Supplier.php

Doc Comments +1 added lines, -1 removed lines

@@ -147,7 +147,7 @@
     /**
      * Get familylog.
      *
-     * @return FamilyLog
+     * @return string
      */
     public function getFamilylog()
     {

Unused Use Statements +3 added lines, -3 removed lines

@@ -15,12 +15,12 @@
  */
 namespace AppBundle\Entity;
 
+use AppBundle\Entity\Contact;
+use AppBundle\Entity\FamilyLog;
 use Doctrine\ORM\Mapping as ORM;
-use Symfony\Component\Validator\Constraints as Assert;
 use Gedmo\Mapping\Annotation as Gedmo;
 use Symfony\Bridge\Doctrine\Validator\Constraints\UniqueEntity;
-use AppBundle\Entity\Contact;
-use AppBundle\Entity\FamilyLog;
+use Symfony\Component\Validator\Constraints as Assert;
 
 /**
  * Supplier Entité Supplier.

src/AppBundle/Entity/FamilyLog.php

Spacing +2 added lines, -2 removed lines

@@ -249,9 +249,9 @@
     
     public function getIndentedName() {
         if ($this->parent !== null) {
-            return " >> " . $this->name;
+            return " >> ".$this->name;
         } else {
-            return "- " . $this->name;
+            return "- ".$this->name;
         }
     }
 }