Inspection of "Feat/create user bounded context" - Dev-Int/glsr - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — develop (#171)

by Laurent

created 2021-05-02 13:36 UTC

Status

Spacing +60 added lines, -60 removed lines patch added patch discarded remove patch

@@ -30,78 +30,78 @@
 block discarded – undo
     {
         // this up() migration is auto-generated, please modify it to your needs
         $this->addSql(
-            'CREATE TABLE company (' .
-            'uuid CHAR(36) NOT NULL COMMENT \'(DC2Type:guid)\', ' .
-            'company_name VARCHAR(255) NOT NULL, ' .
-            'address VARCHAR(255) NOT NULL, ' .
-            'zip_code VARCHAR(5) NOT NULL, ' .
-            'town VARCHAR(255) NOT NULL, ' .
-            'country VARCHAR(255) NOT NULL, ' .
-            'phone VARCHAR(14) NOT NULL, ' .
-            'facsimile VARCHAR(14) DEFAULT NULL, ' .
-            'email VARCHAR(255) NOT NULL, ' .
-            'contact_name VARCHAR(255) NOT NULL, ' .
-            'cellphone VARCHAR(14) NOT NULL, ' .
-            'slug VARCHAR(255) NOT NULL, ' .
-            'UNIQUE INDEX UNIQ_4FBF094F1D4E64E8 (company_name), ' .
-            'UNIQUE INDEX UNIQ_4FBF094F989D9B62 (slug), ' .
-            'PRIMARY KEY(uuid)' .
+            'CREATE TABLE company ('.
+            'uuid CHAR(36) NOT NULL COMMENT \'(DC2Type:guid)\', '.
+            'company_name VARCHAR(255) NOT NULL, '.
+            'address VARCHAR(255) NOT NULL, '.
+            'zip_code VARCHAR(5) NOT NULL, '.
+            'town VARCHAR(255) NOT NULL, '.
+            'country VARCHAR(255) NOT NULL, '.
+            'phone VARCHAR(14) NOT NULL, '.
+            'facsimile VARCHAR(14) DEFAULT NULL, '.
+            'email VARCHAR(255) NOT NULL, '.
+            'contact_name VARCHAR(255) NOT NULL, '.
+            'cellphone VARCHAR(14) NOT NULL, '.
+            'slug VARCHAR(255) NOT NULL, '.
+            'UNIQUE INDEX UNIQ_4FBF094F1D4E64E8 (company_name), '.
+            'UNIQUE INDEX UNIQ_4FBF094F989D9B62 (slug), '.
+            'PRIMARY KEY(uuid)'.
             ') DEFAULT CHARACTER SET utf8mb4 COLLATE `utf8mb4_unicode_ci` ENGINE = InnoDB'
         );
         $this->addSql(
-            'CREATE TABLE settings (' .
-            'uuid CHAR(36) NOT NULL COMMENT \'(DC2Type:guid)\', ' .
-            'locale VARCHAR(255) NOT NULL, ' .
-            'currency VARCHAR(255) NOT NULL, ' .
-            'PRIMARY KEY(uuid)' .
+            'CREATE TABLE settings ('.
+            'uuid CHAR(36) NOT NULL COMMENT \'(DC2Type:guid)\', '.
+            'locale VARCHAR(255) NOT NULL, '.
+            'currency VARCHAR(255) NOT NULL, '.
+            'PRIMARY KEY(uuid)'.
             ') DEFAULT CHARACTER SET utf8mb4 COLLATE `utf8mb4_unicode_ci` ENGINE = InnoDB'
         );
         $this->addSql(
-            'CREATE TABLE supplier (' .
-            'uuid CHAR(36) NOT NULL COMMENT \'(DC2Type:guid)\', ' .
-            'family_log VARCHAR(255) NOT NULL, ' .
-            'delay_delivery INT NOT NULL, ' .
-            'order_days LONGTEXT NOT NULL COMMENT \'(DC2Type:array)\', ' .
-            'active TINYINT(1) NOT NULL, ' .
-            'company_name VARCHAR(255) NOT NULL, ' .
-            'address VARCHAR(255) NOT NULL, ' .
-            'zip_code VARCHAR(5) NOT NULL, ' .
-            'town VARCHAR(255) NOT NULL, ' .
-            'country VARCHAR(255) NOT NULL, ' .
-            'phone VARCHAR(14) NOT NULL, ' .
-            'facsimile VARCHAR(14) DEFAULT NULL, ' .
-            'email VARCHAR(255) NOT NULL, ' .
-            'contact_name VARCHAR(255) NOT NULL, ' .
-            'cellphone VARCHAR(14) NOT NULL, s' .
-            'lug VARCHAR(255) NOT NULL, ' .
-            'UNIQUE INDEX UNIQ_9B2A6C7E1D4E64E8 (company_name), ' .
-            'UNIQUE INDEX UNIQ_9B2A6C7E989D9B62 (slug), ' .
-            'PRIMARY KEY(uuid)' .
+            'CREATE TABLE supplier ('.
+            'uuid CHAR(36) NOT NULL COMMENT \'(DC2Type:guid)\', '.
+            'family_log VARCHAR(255) NOT NULL, '.
+            'delay_delivery INT NOT NULL, '.
+            'order_days LONGTEXT NOT NULL COMMENT \'(DC2Type:array)\', '.
+            'active TINYINT(1) NOT NULL, '.
+            'company_name VARCHAR(255) NOT NULL, '.
+            'address VARCHAR(255) NOT NULL, '.
+            'zip_code VARCHAR(5) NOT NULL, '.
+            'town VARCHAR(255) NOT NULL, '.
+            'country VARCHAR(255) NOT NULL, '.
+            'phone VARCHAR(14) NOT NULL, '.
+            'facsimile VARCHAR(14) DEFAULT NULL, '.
+            'email VARCHAR(255) NOT NULL, '.
+            'contact_name VARCHAR(255) NOT NULL, '.
+            'cellphone VARCHAR(14) NOT NULL, s'.
+            'lug VARCHAR(255) NOT NULL, '.
+            'UNIQUE INDEX UNIQ_9B2A6C7E1D4E64E8 (company_name), '.
+            'UNIQUE INDEX UNIQ_9B2A6C7E989D9B62 (slug), '.
+            'PRIMARY KEY(uuid)'.
             ') DEFAULT CHARACTER SET utf8mb4 COLLATE `utf8mb4_unicode_ci` ENGINE = InnoDB'
         );
         $this->addSql(
-            'CREATE TABLE user (' .
-            'uuid CHAR(36) NOT NULL COMMENT \'(DC2Type:guid)\', ' .
-            'username VARCHAR(150) NOT NULL, ' .
-            'email VARCHAR(255) NOT NULL, ' .
-            'password VARCHAR(120) NOT NULL, ' .
-            'roles LONGTEXT NOT NULL COMMENT \'(DC2Type:array)\', ' .
-            'PRIMARY KEY(uuid)' .
+            'CREATE TABLE user ('.
+            'uuid CHAR(36) NOT NULL COMMENT \'(DC2Type:guid)\', '.
+            'username VARCHAR(150) NOT NULL, '.
+            'email VARCHAR(255) NOT NULL, '.
+            'password VARCHAR(120) NOT NULL, '.
+            'roles LONGTEXT NOT NULL COMMENT \'(DC2Type:array)\', '.
+            'PRIMARY KEY(uuid)'.
             ') DEFAULT CHARACTER SET utf8mb4 COLLATE `utf8mb4_unicode_ci` ENGINE = InnoDB'
         );
         $this->addSql(
-            'CREATE TABLE messenger_messages (' .
-            'id BIGINT AUTO_INCREMENT NOT NULL, ' .
-            'body LONGTEXT NOT NULL, ' .
-            'headers LONGTEXT NOT NULL, ' .
-            'queue_name VARCHAR(190) NOT NULL, ' .
-            'created_at DATETIME NOT NULL, ' .
-            'available_at DATETIME NOT NULL, ' .
-            'delivered_at DATETIME DEFAULT NULL, ' .
-            'INDEX IDX_75EA56E0FB7336F0 (queue_name), ' .
-            'INDEX IDX_75EA56E0E3BD61CE (available_at), ' .
-            'INDEX IDX_75EA56E016BA31DB (delivered_at), ' .
-            'PRIMARY KEY(id)' .
+            'CREATE TABLE messenger_messages ('.
+            'id BIGINT AUTO_INCREMENT NOT NULL, '.
+            'body LONGTEXT NOT NULL, '.
+            'headers LONGTEXT NOT NULL, '.
+            'queue_name VARCHAR(190) NOT NULL, '.
+            'created_at DATETIME NOT NULL, '.
+            'available_at DATETIME NOT NULL, '.
+            'delivered_at DATETIME DEFAULT NULL, '.
+            'INDEX IDX_75EA56E0FB7336F0 (queue_name), '.
+            'INDEX IDX_75EA56E0E3BD61CE (available_at), '.
+            'INDEX IDX_75EA56E016BA31DB (delivered_at), '.
+            'PRIMARY KEY(id)'.
             ') DEFAULT CHARACTER SET utf8mb4 COLLATE `utf8mb4_unicode_ci` ENGINE = InnoDB'
         );
     }

Please login to merge, or discard this patch.

		@@ -30,78 +30,78 @@
		block discarded – undo
30	30	{
31	31	// this up() migration is auto-generated, please modify it to your needs
32	32	$this->addSql(
33		- 'CREATE TABLE company (' .
34		- 'uuid CHAR(36) NOT NULL COMMENT \'(DC2Type:guid)\', ' .
35		- 'company_name VARCHAR(255) NOT NULL, ' .
36		- 'address VARCHAR(255) NOT NULL, ' .
37		- 'zip_code VARCHAR(5) NOT NULL, ' .
38		- 'town VARCHAR(255) NOT NULL, ' .
39		- 'country VARCHAR(255) NOT NULL, ' .
40		- 'phone VARCHAR(14) NOT NULL, ' .
41		- 'facsimile VARCHAR(14) DEFAULT NULL, ' .
42		- 'email VARCHAR(255) NOT NULL, ' .
43		- 'contact_name VARCHAR(255) NOT NULL, ' .
44		- 'cellphone VARCHAR(14) NOT NULL, ' .
45		- 'slug VARCHAR(255) NOT NULL, ' .
46		- 'UNIQUE INDEX UNIQ_4FBF094F1D4E64E8 (company_name), ' .
47		- 'UNIQUE INDEX UNIQ_4FBF094F989D9B62 (slug), ' .
48		- 'PRIMARY KEY(uuid)' .
	33	+ 'CREATE TABLE company ('.
	34	+ 'uuid CHAR(36) NOT NULL COMMENT \'(DC2Type:guid)\', '.
	35	+ 'company_name VARCHAR(255) NOT NULL, '.
	36	+ 'address VARCHAR(255) NOT NULL, '.
	37	+ 'zip_code VARCHAR(5) NOT NULL, '.
	38	+ 'town VARCHAR(255) NOT NULL, '.
	39	+ 'country VARCHAR(255) NOT NULL, '.
	40	+ 'phone VARCHAR(14) NOT NULL, '.
	41	+ 'facsimile VARCHAR(14) DEFAULT NULL, '.
	42	+ 'email VARCHAR(255) NOT NULL, '.
	43	+ 'contact_name VARCHAR(255) NOT NULL, '.
	44	+ 'cellphone VARCHAR(14) NOT NULL, '.
	45	+ 'slug VARCHAR(255) NOT NULL, '.
	46	+ 'UNIQUE INDEX UNIQ_4FBF094F1D4E64E8 (company_name), '.
	47	+ 'UNIQUE INDEX UNIQ_4FBF094F989D9B62 (slug), '.
	48	+ 'PRIMARY KEY(uuid)'.
49	49	') DEFAULT CHARACTER SET utf8mb4 COLLATE `utf8mb4_unicode_ci` ENGINE = InnoDB'
50	50	);
51	51	$this->addSql(
52		- 'CREATE TABLE settings (' .
53		- 'uuid CHAR(36) NOT NULL COMMENT \'(DC2Type:guid)\', ' .
54		- 'locale VARCHAR(255) NOT NULL, ' .
55		- 'currency VARCHAR(255) NOT NULL, ' .
56		- 'PRIMARY KEY(uuid)' .
	52	+ 'CREATE TABLE settings ('.
	53	+ 'uuid CHAR(36) NOT NULL COMMENT \'(DC2Type:guid)\', '.
	54	+ 'locale VARCHAR(255) NOT NULL, '.
	55	+ 'currency VARCHAR(255) NOT NULL, '.
	56	+ 'PRIMARY KEY(uuid)'.
57	57	') DEFAULT CHARACTER SET utf8mb4 COLLATE `utf8mb4_unicode_ci` ENGINE = InnoDB'
58	58	);
59	59	$this->addSql(
60		- 'CREATE TABLE supplier (' .
61		- 'uuid CHAR(36) NOT NULL COMMENT \'(DC2Type:guid)\', ' .
62		- 'family_log VARCHAR(255) NOT NULL, ' .
63		- 'delay_delivery INT NOT NULL, ' .
64		- 'order_days LONGTEXT NOT NULL COMMENT \'(DC2Type:array)\', ' .
65		- 'active TINYINT(1) NOT NULL, ' .
66		- 'company_name VARCHAR(255) NOT NULL, ' .
67		- 'address VARCHAR(255) NOT NULL, ' .
68		- 'zip_code VARCHAR(5) NOT NULL, ' .
69		- 'town VARCHAR(255) NOT NULL, ' .
70		- 'country VARCHAR(255) NOT NULL, ' .
71		- 'phone VARCHAR(14) NOT NULL, ' .
72		- 'facsimile VARCHAR(14) DEFAULT NULL, ' .
73		- 'email VARCHAR(255) NOT NULL, ' .
74		- 'contact_name VARCHAR(255) NOT NULL, ' .
75		- 'cellphone VARCHAR(14) NOT NULL, s' .
76		- 'lug VARCHAR(255) NOT NULL, ' .
77		- 'UNIQUE INDEX UNIQ_9B2A6C7E1D4E64E8 (company_name), ' .
78		- 'UNIQUE INDEX UNIQ_9B2A6C7E989D9B62 (slug), ' .
79		- 'PRIMARY KEY(uuid)' .
	60	+ 'CREATE TABLE supplier ('.
	61	+ 'uuid CHAR(36) NOT NULL COMMENT \'(DC2Type:guid)\', '.
	62	+ 'family_log VARCHAR(255) NOT NULL, '.
	63	+ 'delay_delivery INT NOT NULL, '.
	64	+ 'order_days LONGTEXT NOT NULL COMMENT \'(DC2Type:array)\', '.
	65	+ 'active TINYINT(1) NOT NULL, '.
	66	+ 'company_name VARCHAR(255) NOT NULL, '.
	67	+ 'address VARCHAR(255) NOT NULL, '.
	68	+ 'zip_code VARCHAR(5) NOT NULL, '.
	69	+ 'town VARCHAR(255) NOT NULL, '.
	70	+ 'country VARCHAR(255) NOT NULL, '.
	71	+ 'phone VARCHAR(14) NOT NULL, '.
	72	+ 'facsimile VARCHAR(14) DEFAULT NULL, '.
	73	+ 'email VARCHAR(255) NOT NULL, '.
	74	+ 'contact_name VARCHAR(255) NOT NULL, '.
	75	+ 'cellphone VARCHAR(14) NOT NULL, s'.
	76	+ 'lug VARCHAR(255) NOT NULL, '.
	77	+ 'UNIQUE INDEX UNIQ_9B2A6C7E1D4E64E8 (company_name), '.
	78	+ 'UNIQUE INDEX UNIQ_9B2A6C7E989D9B62 (slug), '.
	79	+ 'PRIMARY KEY(uuid)'.
80	80	') DEFAULT CHARACTER SET utf8mb4 COLLATE `utf8mb4_unicode_ci` ENGINE = InnoDB'
81	81	);
82	82	$this->addSql(
83		- 'CREATE TABLE user (' .
84		- 'uuid CHAR(36) NOT NULL COMMENT \'(DC2Type:guid)\', ' .
85		- 'username VARCHAR(150) NOT NULL, ' .
86		- 'email VARCHAR(255) NOT NULL, ' .
87		- 'password VARCHAR(120) NOT NULL, ' .
88		- 'roles LONGTEXT NOT NULL COMMENT \'(DC2Type:array)\', ' .
89		- 'PRIMARY KEY(uuid)' .
	83	+ 'CREATE TABLE user ('.
	84	+ 'uuid CHAR(36) NOT NULL COMMENT \'(DC2Type:guid)\', '.
	85	+ 'username VARCHAR(150) NOT NULL, '.
	86	+ 'email VARCHAR(255) NOT NULL, '.
	87	+ 'password VARCHAR(120) NOT NULL, '.
	88	+ 'roles LONGTEXT NOT NULL COMMENT \'(DC2Type:array)\', '.
	89	+ 'PRIMARY KEY(uuid)'.
90	90	') DEFAULT CHARACTER SET utf8mb4 COLLATE `utf8mb4_unicode_ci` ENGINE = InnoDB'
91	91	);
92	92	$this->addSql(
93		- 'CREATE TABLE messenger_messages (' .
94		- 'id BIGINT AUTO_INCREMENT NOT NULL, ' .
95		- 'body LONGTEXT NOT NULL, ' .
96		- 'headers LONGTEXT NOT NULL, ' .
97		- 'queue_name VARCHAR(190) NOT NULL, ' .
98		- 'created_at DATETIME NOT NULL, ' .
99		- 'available_at DATETIME NOT NULL, ' .
100		- 'delivered_at DATETIME DEFAULT NULL, ' .
101		- 'INDEX IDX_75EA56E0FB7336F0 (queue_name), ' .
102		- 'INDEX IDX_75EA56E0E3BD61CE (available_at), ' .
103		- 'INDEX IDX_75EA56E016BA31DB (delivered_at), ' .
104		- 'PRIMARY KEY(id)' .
	93	+ 'CREATE TABLE messenger_messages ('.
	94	+ 'id BIGINT AUTO_INCREMENT NOT NULL, '.
	95	+ 'body LONGTEXT NOT NULL, '.
	96	+ 'headers LONGTEXT NOT NULL, '.
	97	+ 'queue_name VARCHAR(190) NOT NULL, '.
	98	+ 'created_at DATETIME NOT NULL, '.
	99	+ 'available_at DATETIME NOT NULL, '.
	100	+ 'delivered_at DATETIME DEFAULT NULL, '.
	101	+ 'INDEX IDX_75EA56E0FB7336F0 (queue_name), '.
	102	+ 'INDEX IDX_75EA56E0E3BD61CE (available_at), '.
	103	+ 'INDEX IDX_75EA56E016BA31DB (delivered_at), '.
	104	+ 'PRIMARY KEY(id)'.
105	105	') DEFAULT CHARACTER SET utf8mb4 COLLATE `utf8mb4_unicode_ci` ENGINE = InnoDB'
106	106	);
107	107	}

Dev-Int / glsr

Pull Request — develop (#171)

Status

Category

Spacing +60 added lines, -60 removed lines patch added patch discarded remove patch