Inspection of "exclude site models from scrutinizer" - DakuTree/manga-tracker - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 222f63...75778e )

by Angus

created 2017-12-20 22:03 UTC

Status

Indentation +22 added lines, -22 removed lines patch added patch discarded remove patch

@@ -15,11 +15,11 @@  discard block
 block discarded – undo
 	 */
 	public function getID(string $titleURL, int $siteID, bool $create = TRUE, bool $returnData = FALSE) {
 		$query = $this->db->select('tracker_titles.id, tracker_titles.title, tracker_titles.title_url, tracker_titles.latest_chapter, tracker_titles.status, tracker_sites.site_class, (tracker_titles.last_checked > DATE_SUB(NOW(), INTERVAL 3 DAY)) AS active', FALSE)
-		                  ->from('tracker_titles')
-		                  ->join('tracker_sites', 'tracker_sites.id = tracker_titles.site_id', 'left')
-		                  ->where('tracker_titles.title_url', $titleURL)
-		                  ->where('tracker_titles.site_id', $siteID)
-		                  ->get();
+						  ->from('tracker_titles')
+						  ->join('tracker_sites', 'tracker_sites.id = tracker_titles.site_id', 'left')
+						  ->where('tracker_titles.title_url', $titleURL)
+						  ->where('tracker_titles.site_id', $siteID)
+						  ->get();
 
 		if($query->num_rows() > 0) {
 			$id = (int) $query->row('id');
@@ -32,8 +32,8 @@  discard block
 block discarded – undo
 						//Make sure last_checked is always updated on successful run.
 						//CHECK: Is there a reason we aren't just doing this in updateTitleById?
 						$this->db->set('last_checked', 'CURRENT_TIMESTAMP', FALSE)
-						         ->where('id', $id)
-						         ->update('tracker_titles');
+								 ->where('id', $id)
+								 ->update('tracker_titles');
 					}
 				} else {
 					log_message('error', "{$query->row('title')} failed to update successfully");
@@ -73,9 +73,9 @@  discard block
 block discarded – undo
 	 */
 	private function addTitle(string $titleURL, int $siteID) : int {
 		$query = $this->db->select('site, site_class')
-		                  ->from('tracker_sites')
-		                  ->where('id', $siteID)
-		                  ->get();
+						  ->from('tracker_sites')
+						  ->where('id', $siteID)
+						  ->get();
 
 		$titleData = $this->sites->{$query->row()->site_class}->getTitleData($titleURL, TRUE);
 
@@ -101,21 +101,21 @@  discard block
 block discarded – undo
 	public function updateByID(int $titleID, string $latestChapter) : bool {
 		//FIXME: Really not too happy with how we're doing history stuff here, it just feels messy.
 		$query = $this->db->select('latest_chapter AS current_chapter')
-		                  ->from('tracker_titles')
-		                  ->where('id', $titleID)
-		                  ->get();
+						  ->from('tracker_titles')
+						  ->where('id', $titleID)
+						  ->get();
 		$row = $query->row();
 
 		//TODO (CHECK): If failed_checks changes won't that trigger affected_rows?
 		$success = $this->db->set(['latest_chapter' => $latestChapter, 'failed_checks' => 0]) //last_updated gets updated via a trigger if something changes
-		                    ->where('id', $titleID)
-		                    ->update('tracker_titles');
+							->where('id', $titleID)
+							->update('tracker_titles');
 
 		if($this->db->affected_rows() > 0) {
 			//Clear hidden latest chapter
 			$this->db->set(['ignore_chapter' => 'NULL', 'last_updated' => 'last_updated'], NULL, FALSE)
-			         ->where('title_id', $titleID)
-			         ->update('tracker_chapters');
+					 ->where('title_id', $titleID)
+					 ->update('tracker_chapters');
 		}
 
 		//Update History
@@ -128,8 +128,8 @@  discard block
 block discarded – undo
 
 	public function updateFailedChecksByID(int $titleID) : bool {
 		$success = $this->db->set('failed_checks', 'failed_checks + 1', FALSE)
-		                    ->where('id', $titleID)
-		                    ->update('tracker_titles');
+							->where('id', $titleID)
+							->update('tracker_titles');
 
 		return $success;
 	}
@@ -141,9 +141,9 @@  discard block
 block discarded – undo
 	 */
 	public function getSiteDataFromURL(string $site_url) {
 		$query = $this->db->select('*')
-		                  ->from('tracker_sites')
-		                  ->where('site', $site_url)
-		                  ->get();
+						  ->from('tracker_sites')
+						  ->where('site', $site_url)
+						  ->get();
 
 		return $query->row();
 	}

Please login to merge, or discard this patch.

application/models/Tracker/Tracker_Admin_Model.php 1 patch

Indentation +28 added lines, -28 removed lines patch added patch discarded remove patch

@@ -74,8 +74,8 @@  discard block
 block discarded – undo
 						//Make sure last_checked is always updated on successful run.
 						//CHECK: Is there a reason we aren't just doing this in updateByID?
 						$this->db->set('last_checked', 'CURRENT_TIMESTAMP', FALSE)
-						         ->where('id', $row->title_id)
-						         ->update('tracker_titles');
+								 ->where('id', $row->title_id)
+								 ->update('tracker_titles');
 
 						print " - ({$titleData['latest_chapter']})\n";
 					} else {
@@ -152,8 +152,8 @@  discard block
 block discarded – undo
 						//Make sure last_checked is always updated on successful run.
 						//CHECK: Is there a reason we aren't just doing this in updateByID?
 						$this->db->set('last_checked', 'CURRENT_TIMESTAMP', FALSE)
-						         ->where('id', $row->title_id)
-						         ->update('tracker_titles');
+								 ->where('id', $row->title_id)
+								 ->update('tracker_titles');
 
 						print " - ({$titleData['latest_chapter']})\n";
 					} else {
@@ -177,10 +177,10 @@  discard block
 block discarded – undo
 	 */
 	public function updateCustom() {
 		$query = $this->db->select('*')
-		                  ->from('tracker_sites')
-		                  ->where('status', 'enabled')
-		                  ->where('tracker_sites.use_custom', 'Y')
-		                  ->get();
+						  ->from('tracker_sites')
+						  ->where('status', 'enabled')
+						  ->where('tracker_sites.use_custom', 'Y')
+						  ->get();
 
 		$sites = $query->result_array();
 		foreach ($sites as $site) {
@@ -196,8 +196,8 @@  discard block
 block discarded – undo
 									//Make sure last_checked is always updated on successful run.
 									//CHECK: Is there a reason we aren't just doing this in updateByID?
 									$this->db->set('last_checked', 'CURRENT_TIMESTAMP', FALSE)
-									         ->where('id', $titleID)
-									         ->update('tracker_titles');
+											 ->where('id', $titleID)
+											 ->update('tracker_titles');
 
 									print " - ({$titleData['latest_chapter']})\n";
 								} else {
@@ -224,13 +224,13 @@  discard block
 block discarded – undo
 
 	public function refollowCustom() {
 		$query = $this->db->select('tracker_titles.id, tracker_titles.title_url, tracker_sites.site_class')
-		                  ->from('tracker_titles')
-		                  ->join('tracker_sites', 'tracker_sites.id = tracker_titles.site_id', 'left')
-		                  ->where('tracker_titles.followed','N')
-		                  ->where('tracker_titles !=', '255')
-		                  ->where('tracker_sites.status', 'enabled')
-		                  ->where('tracker_sites.use_custom', 'Y')
-		                  ->get();
+						  ->from('tracker_titles')
+						  ->join('tracker_sites', 'tracker_sites.id = tracker_titles.site_id', 'left')
+						  ->where('tracker_titles.followed','N')
+						  ->where('tracker_titles !=', '255')
+						  ->where('tracker_sites.status', 'enabled')
+						  ->where('tracker_sites.use_custom', 'Y')
+						  ->get();
 
 		if($query->num_rows() > 0) {
 			foreach($query->result() as $row) {
@@ -241,8 +241,8 @@  discard block
 block discarded – undo
 
 					if(!empty($titleData)) {
 						$this->db->set($titleData)
-						         ->where('id', $row->id)
-						         ->update('tracker_titles');
+								 ->where('id', $row->id)
+								 ->update('tracker_titles');
 
 						print "> {$row->site_class}:{$row->id}:{$row->title_url} FOLLOWED\n";
 					} else {
@@ -290,8 +290,8 @@  discard block
 block discarded – undo
 				if($titleData['title'] && is_array($titleData) && !is_null($titleData['latest_chapter'])) {
 					if($titleData['title'] !== $row->title) {
 						$this->db->set('title', $titleData['title'])
-						         ->where('id', $row->id)
-						         ->update('tracker_titles');
+								 ->where('id', $row->id)
+								 ->update('tracker_titles');
 						//TODO: Add to history somehow?
 						print " - NEW TITLE ({$titleData['title']})\n";
 					} else {
@@ -301,8 +301,8 @@  discard block
 block discarded – undo
 					//We might as well try to update as well.
 					if($this->Tracker->title->updateByID((int) $row->id, $titleData['latest_chapter'])) {
 						$this->db->set('last_checked', 'CURRENT_TIMESTAMP', FALSE)
-						         ->where('id', $row->id)
-						         ->update('tracker_titles');
+								 ->where('id', $row->id)
+								 ->update('tracker_titles');
 					}
 				} else {
 					log_message('error', "{$row->title} failed to update title successfully");
@@ -318,14 +318,14 @@  discard block
 block discarded – undo
 		$date = $temp_now->format('Y-m-d');
 
 		$query = $this->db->select('1')
-		                  ->from('site_stats')
-		                  ->where('date', $date)
-		                  ->get();
+						  ->from('site_stats')
+						  ->where('date', $date)
+						  ->get();
 
 		if($query->num_rows() > 0) {
 			$this->db->set('total_requests', 'total_requests+1', FALSE)
-			         ->where('date', $date)
-			         ->update('site_stats');
+					 ->where('date', $date)
+					 ->update('site_stats');
 		} else {
 			$this->db->insert('site_stats', [
 				'date'           => $date,

Please login to merge, or discard this patch.

		@@ -15,11 +15,11 @@ discard block
		block discarded – undo
15	15	*/
16	16	public function getID(string $titleURL, int $siteID, bool $create = TRUE, bool $returnData = FALSE) {
17	17	$query = $this->db->select('tracker_titles.id, tracker_titles.title, tracker_titles.title_url, tracker_titles.latest_chapter, tracker_titles.status, tracker_sites.site_class, (tracker_titles.last_checked > DATE_SUB(NOW(), INTERVAL 3 DAY)) AS active', FALSE)
18		- ->from('tracker_titles')
19		- ->join('tracker_sites', 'tracker_sites.id = tracker_titles.site_id', 'left')
20		- ->where('tracker_titles.title_url', $titleURL)
21		- ->where('tracker_titles.site_id', $siteID)
22		- ->get();
	18	+ ->from('tracker_titles')
	19	+ ->join('tracker_sites', 'tracker_sites.id = tracker_titles.site_id', 'left')
	20	+ ->where('tracker_titles.title_url', $titleURL)
	21	+ ->where('tracker_titles.site_id', $siteID)
	22	+ ->get();
23	23
24	24	if($query->num_rows() > 0) {
25	25	$id = (int) $query->row('id');
		@@ -32,8 +32,8 @@ discard block
		block discarded – undo
32	32	//Make sure last_checked is always updated on successful run.
33	33	//CHECK: Is there a reason we aren't just doing this in updateTitleById?
34	34	$this->db->set('last_checked', 'CURRENT_TIMESTAMP', FALSE)
35		- ->where('id', $id)
36		- ->update('tracker_titles');
	35	+ ->where('id', $id)
	36	+ ->update('tracker_titles');
37	37	}
38	38	} else {
39	39	log_message('error', "{$query->row('title')} failed to update successfully");
		@@ -73,9 +73,9 @@ discard block
		block discarded – undo
73	73	*/
74	74	private function addTitle(string $titleURL, int $siteID) : int {
75	75	$query = $this->db->select('site, site_class')
76		- ->from('tracker_sites')
77		- ->where('id', $siteID)
78		- ->get();
	76	+ ->from('tracker_sites')
	77	+ ->where('id', $siteID)
	78	+ ->get();
79	79
80	80	$titleData = $this->sites->{$query->row()->site_class}->getTitleData($titleURL, TRUE);
81	81
		@@ -101,21 +101,21 @@ discard block
		block discarded – undo
101	101	public function updateByID(int $titleID, string $latestChapter) : bool {
102	102	//FIXME: Really not too happy with how we're doing history stuff here, it just feels messy.
103	103	$query = $this->db->select('latest_chapter AS current_chapter')
104		- ->from('tracker_titles')
105		- ->where('id', $titleID)
106		- ->get();
	104	+ ->from('tracker_titles')
	105	+ ->where('id', $titleID)
	106	+ ->get();
107	107	$row = $query->row();
108	108
109	109	//TODO (CHECK): If failed_checks changes won't that trigger affected_rows?
110	110	$success = $this->db->set(['latest_chapter' => $latestChapter, 'failed_checks' => 0]) //last_updated gets updated via a trigger if something changes
111		- ->where('id', $titleID)
112		- ->update('tracker_titles');
	111	+ ->where('id', $titleID)
	112	+ ->update('tracker_titles');
113	113
114	114	if($this->db->affected_rows() > 0) {
115	115	//Clear hidden latest chapter
116	116	$this->db->set(['ignore_chapter' => 'NULL', 'last_updated' => 'last_updated'], NULL, FALSE)
117		- ->where('title_id', $titleID)
118		- ->update('tracker_chapters');
	117	+ ->where('title_id', $titleID)
	118	+ ->update('tracker_chapters');
119	119	}
120	120
121	121	//Update History
		@@ -128,8 +128,8 @@ discard block
		block discarded – undo
128	128
129	129	public function updateFailedChecksByID(int $titleID) : bool {
130	130	$success = $this->db->set('failed_checks', 'failed_checks + 1', FALSE)
131		- ->where('id', $titleID)
132		- ->update('tracker_titles');
	131	+ ->where('id', $titleID)
	132	+ ->update('tracker_titles');
133	133
134	134	return $success;
135	135	}
		@@ -141,9 +141,9 @@ discard block
		block discarded – undo
141	141	*/
142	142	public function getSiteDataFromURL(string $site_url) {
143	143	$query = $this->db->select('*')
144		- ->from('tracker_sites')
145		- ->where('site', $site_url)
146		- ->get();
	144	+ ->from('tracker_sites')
	145	+ ->where('site', $site_url)
	146	+ ->get();
147	147
148	148	return $query->row();
149	149	}

		@@ -74,8 +74,8 @@ discard block
		block discarded – undo
74	74	//Make sure last_checked is always updated on successful run.
75	75	//CHECK: Is there a reason we aren't just doing this in updateByID?
76	76	$this->db->set('last_checked', 'CURRENT_TIMESTAMP', FALSE)
77		- ->where('id', $row->title_id)
78		- ->update('tracker_titles');
	77	+ ->where('id', $row->title_id)
	78	+ ->update('tracker_titles');
79	79
80	80	print " - ({$titleData['latest_chapter']})\n";
81	81	} else {
		@@ -152,8 +152,8 @@ discard block
		block discarded – undo
152	152	//Make sure last_checked is always updated on successful run.
153	153	//CHECK: Is there a reason we aren't just doing this in updateByID?
154	154	$this->db->set('last_checked', 'CURRENT_TIMESTAMP', FALSE)
155		- ->where('id', $row->title_id)
156		- ->update('tracker_titles');
	155	+ ->where('id', $row->title_id)
	156	+ ->update('tracker_titles');
157	157
158	158	print " - ({$titleData['latest_chapter']})\n";
159	159	} else {
		@@ -177,10 +177,10 @@ discard block
		block discarded – undo
177	177	*/
178	178	public function updateCustom() {
179	179	$query = $this->db->select('*')
180		- ->from('tracker_sites')
181		- ->where('status', 'enabled')
182		- ->where('tracker_sites.use_custom', 'Y')
183		- ->get();
	180	+ ->from('tracker_sites')
	181	+ ->where('status', 'enabled')
	182	+ ->where('tracker_sites.use_custom', 'Y')
	183	+ ->get();
184	184
185	185	$sites = $query->result_array();
186	186	foreach ($sites as $site) {
		@@ -196,8 +196,8 @@ discard block
		block discarded – undo
196	196	//Make sure last_checked is always updated on successful run.
197	197	//CHECK: Is there a reason we aren't just doing this in updateByID?
198	198	$this->db->set('last_checked', 'CURRENT_TIMESTAMP', FALSE)
199		- ->where('id', $titleID)
200		- ->update('tracker_titles');
	199	+ ->where('id', $titleID)
	200	+ ->update('tracker_titles');
201	201
202	202	print " - ({$titleData['latest_chapter']})\n";
203	203	} else {
		@@ -224,13 +224,13 @@ discard block
		block discarded – undo
224	224
225	225	public function refollowCustom() {
226	226	$query = $this->db->select('tracker_titles.id, tracker_titles.title_url, tracker_sites.site_class')
227		- ->from('tracker_titles')
228		- ->join('tracker_sites', 'tracker_sites.id = tracker_titles.site_id', 'left')
229		- ->where('tracker_titles.followed','N')
230		- ->where('tracker_titles !=', '255')
231		- ->where('tracker_sites.status', 'enabled')
232		- ->where('tracker_sites.use_custom', 'Y')
233		- ->get();
	227	+ ->from('tracker_titles')
	228	+ ->join('tracker_sites', 'tracker_sites.id = tracker_titles.site_id', 'left')
	229	+ ->where('tracker_titles.followed','N')
	230	+ ->where('tracker_titles !=', '255')
	231	+ ->where('tracker_sites.status', 'enabled')
	232	+ ->where('tracker_sites.use_custom', 'Y')
	233	+ ->get();
234	234
235	235	if($query->num_rows() > 0) {
236	236	foreach($query->result() as $row) {
		@@ -241,8 +241,8 @@ discard block
		block discarded – undo
241	241
242	242	if(!empty($titleData)) {
243	243	$this->db->set($titleData)
244		- ->where('id', $row->id)
245		- ->update('tracker_titles');
	244	+ ->where('id', $row->id)
	245	+ ->update('tracker_titles');
246	246
247	247	print "> {$row->site_class}:{$row->id}:{$row->title_url} FOLLOWED\n";
248	248	} else {
		@@ -290,8 +290,8 @@ discard block
		block discarded – undo
290	290	if($titleData['title'] && is_array($titleData) && !is_null($titleData['latest_chapter'])) {
291	291	if($titleData['title'] !== $row->title) {
292	292	$this->db->set('title', $titleData['title'])
293		- ->where('id', $row->id)
294		- ->update('tracker_titles');
	293	+ ->where('id', $row->id)
	294	+ ->update('tracker_titles');
295	295	//TODO: Add to history somehow?
296	296	print " - NEW TITLE ({$titleData['title']})\n";
297	297	} else {
		@@ -301,8 +301,8 @@ discard block
		block discarded – undo
301	301	//We might as well try to update as well.
302	302	if($this->Tracker->title->updateByID((int) $row->id, $titleData['latest_chapter'])) {
303	303	$this->db->set('last_checked', 'CURRENT_TIMESTAMP', FALSE)
304		- ->where('id', $row->id)
305		- ->update('tracker_titles');
	304	+ ->where('id', $row->id)
	305	+ ->update('tracker_titles');
306	306	}
307	307	} else {
308	308	log_message('error', "{$row->title} failed to update title successfully");
		@@ -318,14 +318,14 @@ discard block
		block discarded – undo
318	318	$date = $temp_now->format('Y-m-d');
319	319
320	320	$query = $this->db->select('1')
321		- ->from('site_stats')
322		- ->where('date', $date)
323		- ->get();
	321	+ ->from('site_stats')
	322	+ ->where('date', $date)
	323	+ ->get();
324	324
325	325	if($query->num_rows() > 0) {
326	326	$this->db->set('total_requests', 'total_requests+1', FALSE)
327		- ->where('date', $date)
328		- ->update('site_stats');
	327	+ ->where('date', $date)
	328	+ ->update('site_stats');
329	329	} else {
330	330	$this->db->insert('site_stats', [
331	331	'date' => $date,

DakuTree / manga-tracker

Push — master ( 222f63...75778e )

Status

Category

Indentation +22 added lines, -22 removed lines patch added patch discarded remove patch

Indentation +28 added lines, -28 removed lines patch added patch discarded remove patch