Passed
Push — master ( dbd8ef...8368ac )
by Daimona
11:17
created
src/Request/RequestBase.php 1 patch
Spacing   +23 added lines, -23 removed lines patch added patch discarded remove patch
@@ -1,4 +1,4 @@  discard block
 block discarded – undo
1
-<?php declare( strict_types=1 );
1
+<?php declare(strict_types=1);
2 2
 
3 3
 namespace BotRiconferme\Request;
4 4
 
@@ -41,7 +41,7 @@  discard block
 block discarded – undo
41 41
 	/** @var string */
42 42
 	protected $method = self::METHOD_GET;
43 43
 	/** @var string[] */
44
-	protected $newCookies = [];
44
+	protected $newCookies = [ ];
45 45
 
46 46
 	/** @var LoggerInterface */
47 47
 	protected $logger;
@@ -54,7 +54,7 @@  discard block
 block discarded – undo
54 54
 	 * @phan-param array<int|string|bool> $params
55 55
 	 * @param string $domain
56 56
 	 */
57
-	public function __construct( LoggerInterface $logger, array $params, string $domain ) {
57
+	public function __construct ( LoggerInterface $logger, array $params, string $domain ) {
58 58
 		$this->logger = $logger;
59 59
 		$this->params = [ 'format' => 'json' ] + $params;
60 60
 		$this->url = $domain;
@@ -65,7 +65,7 @@  discard block
 block discarded – undo
65 65
 	 *
66 66
 	 * @return self For chaining
67 67
 	 */
68
-	public function setPost(): self {
68
+	public function setPost (): self {
69 69
 		$this->method = self::METHOD_POST;
70 70
 		return $this;
71 71
 	}
@@ -74,12 +74,12 @@  discard block
 block discarded – undo
74 74
 	 * Execute a query request
75 75
 	 * @return Generator
76 76
 	 */
77
-	public function executeAsQuery(): Generator {
78
-		if ( ( $this->params['action'] ?? false ) !== 'query' ) {
77
+	public function executeAsQuery (): Generator {
78
+		if ( ( $this->params[ 'action' ] ?? false ) !== 'query' ) {
79 79
 			throw new BadMethodCallException( 'Not an ApiQuery!' );
80 80
 		}
81 81
 		// TODO Is this always correct?
82
-		$key = $this->params['list'] ?? 'pages';
82
+		$key = $this->params[ 'list' ] ?? 'pages';
83 83
 		$curParams = $this->params;
84 84
 		$lim = $this->parseLimit();
85 85
 		do {
@@ -108,7 +108,7 @@  discard block
 block discarded – undo
108 108
 	 * Execute a request that doesn't need any continuation.
109 109
 	 * @return stdClass
110 110
 	 */
111
-	public function executeSingle(): stdClass {
111
+	public function executeSingle (): stdClass {
112 112
 		$curParams = $this->params;
113 113
 		$res = $this->makeRequestInternal( $curParams );
114 114
 		$this->handleErrorAndWarnings( $res );
@@ -118,7 +118,7 @@  discard block
 block discarded – undo
118 118
 	/**
119 119
 	 * @return int
120 120
 	 */
121
-	private function parseLimit(): int {
121
+	private function parseLimit (): int {
122 122
 		foreach ( $this->params as $name => $val ) {
123 123
 			if ( substr( $name, -strlen( 'limit' ) ) === 'limit' ) {
124 124
 				return $val === 'max' ? -1 : (int)$val;
@@ -135,7 +135,7 @@  discard block
 block discarded – undo
135 135
 	 * @param string $resKey
136 136
 	 * @return int|null
137 137
 	 */
138
-	private function countQueryResults( stdClass $res, string $resKey ): ?int {
138
+	private function countQueryResults ( stdClass $res, string $resKey ): ?int {
139 139
 		if ( !isset( $res->query->$resKey ) ) {
140 140
 			return null;
141 141
 		}
@@ -163,9 +163,9 @@  discard block
 block discarded – undo
163 163
 	 * @phan-param array<int|string|bool> $params
164 164
 	 * @return stdClass
165 165
 	 */
166
-	private function makeRequestInternal( array $params ): stdClass {
166
+	private function makeRequestInternal ( array $params ): stdClass {
167 167
 		if ( $this->method === self::METHOD_POST ) {
168
-			$params['maxlag'] = self::MAXLAG;
168
+			$params[ 'maxlag' ] = self::MAXLAG;
169 169
 		}
170 170
 		$query = http_build_query( $params );
171 171
 
@@ -186,18 +186,18 @@  discard block
 block discarded – undo
186 186
 	 * @param string $params
187 187
 	 * @return string
188 188
 	 */
189
-	abstract protected function reallyMakeRequest( string $params ): string;
189
+	abstract protected function reallyMakeRequest ( string $params ): string;
190 190
 
191 191
 	/**
192 192
 	 * After a request, set cookies for the next ones
193 193
 	 *
194 194
 	 * @param string[] $cookies
195 195
 	 */
196
-	protected function setCookies( array $cookies ): void {
196
+	protected function setCookies ( array $cookies ): void {
197 197
 		foreach ( $cookies as $cookie ) {
198 198
 			/** @var string[] $bits */
199 199
 			$bits = explode( ';', $cookie );
200
-			[ $name, $value ] = explode( '=', $bits[0] );
200
+			[ $name, $value ] = explode( '=', $bits[ 0 ] );
201 201
 			self::$cookiesToSet[ $name ] = $value;
202 202
 		}
203 203
 	}
@@ -208,7 +208,7 @@  discard block
 block discarded – undo
208 208
 	 * @param stdClass $res
209 209
 	 * @return APIRequestException
210 210
 	 */
211
-	private function getException( stdClass $res ): APIRequestException {
211
+	private function getException ( stdClass $res ): APIRequestException {
212 212
 		switch ( $res->error->code ) {
213 213
 			case 'missingtitle':
214 214
 				$ex = new MissingPageException;
@@ -234,7 +234,7 @@  discard block
 block discarded – undo
234 234
 	 * @param stdClass $res
235 235
 	 * @throws APIRequestException
236 236
 	 */
237
-	protected function handleErrorAndWarnings( stdClass $res ): void {
237
+	protected function handleErrorAndWarnings ( stdClass $res ): void {
238 238
 		if ( isset( $res->error ) ) {
239 239
 			throw $this->getException( $res );
240 240
 		}
@@ -250,14 +250,14 @@  discard block
 block discarded – undo
250 250
 	 *
251 251
 	 * @return string[]
252 252
 	 */
253
-	protected function getHeaders(): array {
253
+	protected function getHeaders (): array {
254 254
 		$ret = self::HEADERS;
255 255
 		if ( self::$cookiesToSet ) {
256
-			$cookies = [];
256
+			$cookies = [ ];
257 257
 			foreach ( self::$cookiesToSet as $cname => $cval ) {
258
-				$cookies[] = trim( "$cname=$cval" );
258
+				$cookies[ ] = trim( "$cname=$cval" );
259 259
 			}
260
-			$ret[] = 'Cookie: ' . implode( '; ', $cookies );
260
+			$ret[ ] = 'Cookie: ' . implode( '; ', $cookies );
261 261
 		}
262 262
 		return $ret;
263 263
 	}
@@ -268,7 +268,7 @@  discard block
 block discarded – undo
268 268
 	 * @param string[] $headers
269 269
 	 * @return string
270 270
 	 */
271
-	protected function buildHeadersString( array $headers ): string {
271
+	protected function buildHeadersString ( array $headers ): string {
272 272
 		$ret = '';
273 273
 		foreach ( $headers as $header ) {
274 274
 			$ret .= "$header\r\n";
@@ -280,7 +280,7 @@  discard block
 block discarded – undo
280 280
 	 * @param string $actualParams
281 281
 	 * @return string
282 282
 	 */
283
-	protected function getDebugURL( string $actualParams ): string {
283
+	protected function getDebugURL ( string $actualParams ): string {
284 284
 		return strpos( $this->url, 'login' ) !== false
285 285
 			? '[Login request]'
286 286
 			: "{$this->url}?$actualParams";
Please login to merge, or discard this patch.
src/Wiki/LoginInfo.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -1,4 +1,4 @@  discard block
 block discarded – undo
1
-<?php declare( strict_types=1 );
1
+<?php declare(strict_types=1);
2 2
 
3 3
 namespace BotRiconferme\Wiki;
4 4
 
@@ -15,7 +15,7 @@  discard block
 block discarded – undo
15 15
 	 * @param string $username
16 16
 	 * @param string $password
17 17
 	 */
18
-	public function __construct( string $username, string $password ) {
18
+	public function __construct ( string $username, string $password ) {
19 19
 		$this->username = $username;
20 20
 		$this->password = $password;
21 21
 	}
@@ -23,14 +23,14 @@  discard block
 block discarded – undo
23 23
 	/**
24 24
 	 * @return string
25 25
 	 */
26
-	public function getUsername(): string {
26
+	public function getUsername (): string {
27 27
 		return $this->username;
28 28
 	}
29 29
 
30 30
 	/**
31 31
 	 * @return string
32 32
 	 */
33
-	public function getPassword(): string {
33
+	public function getPassword (): string {
34 34
 		return $this->password;
35 35
 	}
36 36
 }
Please login to merge, or discard this patch.
src/Wiki/WikiGroup.php 1 patch
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -1,4 +1,4 @@  discard block
 block discarded – undo
1
-<?php declare( strict_types=1 );
1
+<?php declare(strict_types=1);
2 2
 
3 3
 namespace BotRiconferme\Wiki;
4 4
 
@@ -18,7 +18,7 @@  discard block
 block discarded – undo
18 18
 	 * @param Wiki $centralWiki
19 19
 	 * @param Wiki $privateWiki
20 20
 	 */
21
-	public function __construct( Wiki $mainWiki, Wiki $centralWiki, Wiki $privateWiki ) {
21
+	public function __construct ( Wiki $mainWiki, Wiki $centralWiki, Wiki $privateWiki ) {
22 22
 		$this->mainWiki = $mainWiki;
23 23
 		$this->centralWiki = $centralWiki;
24 24
 		$this->privateWiki = $privateWiki;
@@ -27,21 +27,21 @@  discard block
 block discarded – undo
27 27
 	/**
28 28
 	 * @return Wiki
29 29
 	 */
30
-	public function getMainWiki(): Wiki {
30
+	public function getMainWiki (): Wiki {
31 31
 		return $this->mainWiki;
32 32
 	}
33 33
 
34 34
 	/**
35 35
 	 * @return Wiki
36 36
 	 */
37
-	public function getCentralWiki(): Wiki {
37
+	public function getCentralWiki (): Wiki {
38 38
 		return $this->centralWiki;
39 39
 	}
40 40
 
41 41
 	/**
42 42
 	 * @return Wiki
43 43
 	 */
44
-	public function getPrivateWiki(): Wiki {
44
+	public function getPrivateWiki (): Wiki {
45 45
 		return $this->privateWiki;
46 46
 	}
47 47
 }
Please login to merge, or discard this patch.
src/Wiki/User.php 1 patch
Spacing   +13 added lines, -13 removed lines patch added patch discarded remove patch
@@ -1,4 +1,4 @@  discard block
 block discarded – undo
1
-<?php declare( strict_types=1 );
1
+<?php declare(strict_types=1);
2 2
 
3 3
 namespace BotRiconferme\Wiki;
4 4
 
@@ -23,7 +23,7 @@  discard block
 block discarded – undo
23 23
 	 * @param UserInfo $ui
24 24
 	 * @param Wiki $wiki
25 25
 	 */
26
-	public function __construct( UserInfo $ui, Wiki $wiki ) {
26
+	public function __construct ( UserInfo $ui, Wiki $wiki ) {
27 27
 		$this->wiki = $wiki;
28 28
 		$this->name = $ui->getName();
29 29
 		$this->ui = $ui;
@@ -32,7 +32,7 @@  discard block
 block discarded – undo
32 32
 	/**
33 33
 	 * @return string
34 34
 	 */
35
-	public function getName(): string {
35
+	public function getName (): string {
36 36
 		return $this->name;
37 37
 	}
38 38
 
@@ -41,7 +41,7 @@  discard block
 block discarded – undo
41 41
 	 *
42 42
 	 * @return string[]
43 43
 	 */
44
-	public function getGroups(): array {
44
+	public function getGroups (): array {
45 45
 		return $this->ui->extractGroups();
46 46
 	}
47 47
 
@@ -50,7 +50,7 @@  discard block
 block discarded – undo
50 50
 	 *
51 51
 	 * @return string[] [ group => date ]
52 52
 	 */
53
-	public function getGroupsWithDates(): array {
53
+	public function getGroupsWithDates (): array {
54 54
 		return $this->ui->extractGroupsWithDates();
55 55
 	}
56 56
 
@@ -60,7 +60,7 @@  discard block
 block discarded – undo
60 60
 	 * @param string $groupName
61 61
 	 * @return bool
62 62
 	 */
63
-	public function inGroup( string $groupName ): bool {
63
+	public function inGroup ( string $groupName ): bool {
64 64
 		return in_array( $groupName, $this->getGroups(), true );
65 65
 	}
66 66
 
@@ -69,9 +69,9 @@  discard block
 block discarded – undo
69 69
 	 *
70 70
 	 * @inheritDoc
71 71
 	 */
72
-	public function getRegex( string $delimiter = '/' ): string {
72
+	public function getRegex ( string $delimiter = '/' ): string {
73 73
 		$bits = $this->getAliases();
74
-		$bits[] = $this->name;
74
+		$bits[ ] = $this->name;
75 75
 		$regexify = static function ( string $el ) use ( $delimiter ): string {
76 76
 			return str_replace( ' ', '[ _]', preg_quote( $el, $delimiter ) );
77 77
 		};
@@ -83,14 +83,14 @@  discard block
 block discarded – undo
83 83
 	 *
84 84
 	 * @return string[]
85 85
 	 */
86
-	public function getAliases(): array {
86
+	public function getAliases (): array {
87 87
 		return $this->ui->getAliases();
88 88
 	}
89 89
 
90 90
 	/**
91 91
 	 * @return Page
92 92
 	 */
93
-	public function getTalkPage(): Page {
93
+	public function getTalkPage (): Page {
94 94
 		return new Page( "User talk:{$this->name}", $this->wiki );
95 95
 	}
96 96
 
@@ -98,7 +98,7 @@  discard block
 block discarded – undo
98 98
 	 * Get the default base page, e.g. WP:A/Riconferma annuale/XXX
99 99
 	 * @return Page
100 100
 	 */
101
-	public function getBasePage(): Page {
101
+	public function getBasePage (): Page {
102 102
 		$prefix = Config::getInstance()->get( 'main-page-title' );
103 103
 		return new Page( "$prefix/$this", $this->wiki );
104 104
 	}
@@ -110,7 +110,7 @@  discard block
 block discarded – undo
110 110
 	 * @throws MissingPageException
111 111
 	 * @return Page
112 112
 	 */
113
-	public function getExistingBasePage(): Page {
113
+	public function getExistingBasePage (): Page {
114 114
 		$basePage = $this->getBasePage();
115 115
 		if ( !$basePage->exists() ) {
116 116
 			$basePage = null;
@@ -134,7 +134,7 @@  discard block
 block discarded – undo
134 134
 	/**
135 135
 	 * @return string
136 136
 	 */
137
-	public function __toString(): string {
137
+	public function __toString (): string {
138 138
 		return $this->name;
139 139
 	}
140 140
 }
Please login to merge, or discard this patch.
src/Wiki/Page/PageBotList.php 1 patch
Spacing   +25 added lines, -27 removed lines patch added patch discarded remove patch
@@ -1,4 +1,4 @@  discard block
 block discarded – undo
1
-<?php declare( strict_types=1 );
1
+<?php declare(strict_types=1);
2 2
 
3 3
 namespace BotRiconferme\Wiki\Page;
4 4
 
@@ -20,7 +20,7 @@  discard block
 block discarded – undo
20 20
 	 * @param string $listTitle
21 21
 	 * @param Wiki $wiki
22 22
 	 */
23
-	private function __construct( string $listTitle, Wiki $wiki ) {
23
+	private function __construct ( string $listTitle, Wiki $wiki ) {
24 24
 		parent::__construct( $listTitle, $wiki );
25 25
 	}
26 26
 
@@ -31,7 +31,7 @@  discard block
 block discarded – undo
31 31
 	 * @param string $listTitle
32 32
 	 * @return self
33 33
 	 */
34
-	public static function get( Wiki $wiki, string $listTitle ): self {
34
+	public static function get ( Wiki $wiki, string $listTitle ): self {
35 35
 		static $instance = null;
36 36
 		if ( $instance === null ) {
37 37
 			$instance = new self( $listTitle, $wiki );
@@ -43,7 +43,7 @@  discard block
 block discarded – undo
43 43
 	 * @param UserInfo $ui
44 44
 	 * @return int|null
45 45
 	 */
46
-	public function getOverrideTimestamp( UserInfo $ui ): ?int {
46
+	public function getOverrideTimestamp ( UserInfo $ui ): ?int {
47 47
 		$info = $ui->getInfo();
48 48
 		if ( !array_intersect_key( $info, [ 'override-perm' => true, 'override' => true ] ) ) {
49 49
 			return null;
@@ -51,9 +51,9 @@  discard block
 block discarded – undo
51 51
 
52 52
 		// A one-time override takes precedence
53 53
 		if ( array_key_exists( 'override', $info ) ) {
54
-			$date = $info['override'];
54
+			$date = $info[ 'override' ];
55 55
 		} else {
56
-			$date = $info['override-prem'] . '/' . date( 'Y' );
56
+			$date = $info[ 'override-prem' ] . '/' . date( 'Y' );
57 57
 		}
58 58
 		return DateTime::createFromFormat( 'd/m/Y', $date )->getTimestamp();
59 59
 	}
@@ -65,18 +65,18 @@  discard block
 block discarded – undo
65 65
 	 * @return int
66 66
 	 * @suppress PhanPluginComparisonObjectOrdering DateTime objects can be compared (phan issue #2907)
67 67
 	 */
68
-	public function getNextTimestamp( string $user ): int {
68
+	public function getNextTimestamp ( string $user ): int {
69 69
 		$userInfo = $this->getUserInfo( $user )->getInfo();
70 70
 		$now = new DateTime();
71
-		if ( isset( $userInfo['override-perm'] ) ) {
71
+		if ( isset( $userInfo[ 'override-perm' ] ) ) {
72 72
 			$date = DateTime::createFromFormat(
73 73
 				'd/m/Y',
74
-				$userInfo['override-perm'] . '/' . date( 'Y' )
74
+				$userInfo[ 'override-perm' ] . '/' . date( 'Y' )
75 75
 			);
76 76
 		} else {
77 77
 			$date = null;
78
-			if ( isset( $userInfo['override'] ) ) {
79
-				$date = DateTime::createFromFormat( 'd/m/Y', $userInfo['override'] );
78
+			if ( isset( $userInfo[ 'override' ] ) ) {
79
+				$date = DateTime::createFromFormat( 'd/m/Y', $userInfo[ 'override' ] );
80 80
 			}
81 81
 			if ( !$date || $date <= $now ) {
82 82
 				$ts = self::getValidFlagTimestamp( $userInfo );
@@ -97,17 +97,15 @@  discard block
 block discarded – undo
97 97
 	 * @param string[] $groups
98 98
 	 * @return int
99 99
 	 */
100
-	public static function getValidFlagTimestamp( array $groups ): int {
101
-		$checkuser = isset( $groups['checkuser'] ) ?
102
-			DateTime::createFromFormat( 'd/m/Y', $groups['checkuser'] )->getTimestamp() :
103
-			0;
104
-		$bureaucrat = isset( $groups['bureaucrat'] ) ?
105
-			DateTime::createFromFormat( 'd/m/Y', $groups['bureaucrat'] )->getTimestamp() :
106
-			0;
100
+	public static function getValidFlagTimestamp ( array $groups ): int {
101
+		$checkuser = isset( $groups[ 'checkuser' ] ) ?
102
+			DateTime::createFromFormat( 'd/m/Y', $groups[ 'checkuser' ] )->getTimestamp() : 0;
103
+		$bureaucrat = isset( $groups[ 'bureaucrat' ] ) ?
104
+			DateTime::createFromFormat( 'd/m/Y', $groups[ 'bureaucrat' ] )->getTimestamp() : 0;
107 105
 
108 106
 		$timestamp = max( $bureaucrat, $checkuser );
109 107
 		if ( $timestamp === 0 ) {
110
-			$timestamp = DateTime::createFromFormat( 'd/m/Y', $groups['sysop'] )->getTimestamp();
108
+			$timestamp = DateTime::createFromFormat( 'd/m/Y', $groups[ 'sysop' ] )->getTimestamp();
111 109
 		}
112 110
 		return $timestamp;
113 111
 	}
@@ -121,14 +119,14 @@  discard block
 block discarded – undo
121 119
 	 * @param string[] $groups
122 120
 	 * @return bool
123 121
 	 */
124
-	public static function isOverrideExpired( array $groups ): bool {
125
-		if ( !isset( $groups['override'] ) ) {
122
+	public static function isOverrideExpired ( array $groups ): bool {
123
+		if ( !isset( $groups[ 'override' ] ) ) {
126 124
 			return false;
127 125
 		}
128 126
 
129 127
 		$flagTS = self::getValidFlagTimestamp( $groups );
130 128
 		$usualTS = strtotime( date( 'Y' ) . '-' . date( 'm-d', $flagTS ) );
131
-		$overrideTS = DateTime::createFromFormat( 'd/m/Y', $groups['override'] )->getTimestamp();
129
+		$overrideTS = DateTime::createFromFormat( 'd/m/Y', $groups[ 'override' ] )->getTimestamp();
132 130
 		$delay = 60 * 60 * 24 * 3;
133 131
 
134 132
 		return time() > $usualTS + $delay && time() > $overrideTS + $delay;
@@ -139,9 +137,9 @@  discard block
 block discarded – undo
139 137
 	 *
140 138
 	 * @return UserInfo[]
141 139
 	 */
142
-	public function getAdminsList(): array {
140
+	public function getAdminsList (): array {
143 141
 		if ( $this->adminsList === null ) {
144
-			$this->adminsList = [];
142
+			$this->adminsList = [ ];
145 143
 			foreach ( $this->getDecodedContent() as $user => $info ) {
146 144
 				$this->adminsList[ $user ] = new UserInfo( $user, $info );
147 145
 			}
@@ -153,8 +151,8 @@  discard block
 block discarded – undo
153 151
 	 * @param string $user
154 152
 	 * @return UserInfo
155 153
 	 */
156
-	public function getUserInfo( string $user ): UserInfo {
157
-		return $this->getAdminsList()[$user];
154
+	public function getUserInfo ( string $user ): UserInfo {
155
+		return $this->getAdminsList()[ $user ];
158 156
 	}
159 157
 
160 158
 	/**
@@ -162,7 +160,7 @@  discard block
 block discarded – undo
162 160
 	 *
163 161
 	 * @return string[][]
164 162
 	 */
165
-	public function getDecodedContent(): array {
163
+	public function getDecodedContent (): array {
166 164
 		return json_decode( $this->getContent(), true );
167 165
 	}
168 166
 }
Please login to merge, or discard this patch.
src/Wiki/Page/PageRiconferma.php 1 patch
Spacing   +21 added lines, -21 removed lines patch added patch discarded remove patch
@@ -1,4 +1,4 @@  discard block
 block discarded – undo
1
-<?php declare( strict_types=1 );
1
+<?php declare(strict_types=1);
2 2
 
3 3
 namespace BotRiconferme\Wiki\Page;
4 4
 
@@ -16,7 +16,7 @@  discard block
 block discarded – undo
16 16
 	/** @var int|null */
17 17
 	private $opposeSection;
18 18
 	/** @var int[] Counts of votes for each section */
19
-	private $sectionCounts = [];
19
+	private $sectionCounts = [ ];
20 20
 
21 21
 	// Possible outcomes of a vote
22 22
 	public const OUTCOME_OK = 0;
@@ -35,7 +35,7 @@  discard block
 block discarded – undo
35 35
 	 * because they can vary depending on whether the page is a vote, which is relatively
36 36
 	 * expensive to know since it requires parsing the content of the page.
37 37
 	 */
38
-	private function defineSections(): void {
38
+	private function defineSections (): void {
39 39
 		$this->supportSection = $this->isVote() ? 3 : 0;
40 40
 		$this->opposeSection = $this->isVote() ? 4 : 3;
41 41
 	}
@@ -45,8 +45,8 @@  discard block
 block discarded – undo
45 45
 	 *
46 46
 	 * @return string
47 47
 	 */
48
-	public function getUserName(): string {
49
-		return explode( '/', $this->title )[2];
48
+	public function getUserName (): string {
49
+		return explode( '/', $this->title )[ 2 ];
50 50
 	}
51 51
 
52 52
 	/**
@@ -54,7 +54,7 @@  discard block
 block discarded – undo
54 54
 	 *
55 55
 	 * @return int
56 56
 	 */
57
-	public function getNum(): int {
57
+	public function getNum (): int {
58 58
 		$bits = explode( '/', $this->getTitle() );
59 59
 		return (int)end( $bits );
60 60
 	}
@@ -64,8 +64,8 @@  discard block
 block discarded – undo
64 64
 	 *
65 65
 	 * @return string
66 66
 	 */
67
-	public function getUserNum(): string {
68
-		return explode( '/', $this->getTitle(), 3 )[2];
67
+	public function getUserNum (): string {
68
+		return explode( '/', $this->getTitle(), 3 )[ 2 ];
69 69
 	}
70 70
 
71 71
 	/**
@@ -73,7 +73,7 @@  discard block
 block discarded – undo
73 73
 	 *
74 74
 	 * @return int
75 75
 	 */
76
-	public function getOpposingCount(): int {
76
+	public function getOpposingCount (): int {
77 77
 		$this->defineSections();
78 78
 		return $this->getCountForSection( $this->opposeSection );
79 79
 	}
@@ -84,7 +84,7 @@  discard block
 block discarded – undo
84 84
 	 * @return int
85 85
 	 * @throws BadMethodCallException
86 86
 	 */
87
-	public function getSupportCount(): int {
87
+	public function getSupportCount (): int {
88 88
 		if ( !$this->isVote() ) {
89 89
 			throw new BadMethodCallException( 'Cannot get support for a non-vote page.' );
90 90
 		}
@@ -98,13 +98,13 @@  discard block
 block discarded – undo
98 98
 	 * @param int $secNum
99 99
 	 * @return int
100 100
 	 */
101
-	protected function getCountForSection( int $secNum ): int {
101
+	protected function getCountForSection ( int $secNum ): int {
102 102
 		if ( !isset( $this->sectionCounts[ $secNum ] ) ) {
103 103
 			$content = $this->wiki->getPageContent( $this->title, $secNum );
104 104
 			// Let's hope that this is good enough...
105
-			$this->sectionCounts[$secNum] = preg_match_all( "/^# *(?![# *:]|\.\.\.$)/m", $content );
105
+			$this->sectionCounts[ $secNum ] = preg_match_all( "/^# *(?![# *:]|\.\.\.$)/m", $content );
106 106
 		}
107
-		return $this->sectionCounts[$secNum];
107
+		return $this->sectionCounts[ $secNum ];
108 108
 	}
109 109
 
110 110
 	/**
@@ -112,9 +112,9 @@  discard block
 block discarded – undo
112 112
 	 *
113 113
 	 * @return int
114 114
 	 */
115
-	protected function getQuorum(): int {
115
+	protected function getQuorum (): int {
116 116
 		$reg = "!soddisfare il \[\[[^|\]]+\|quorum]] di '''(\d+) voti'''!";
117
-		return (int)$this->getMatch( $reg )[1];
117
+		return (int)$this->getMatch( $reg )[ 1 ];
118 118
 	}
119 119
 
120 120
 	/**
@@ -122,7 +122,7 @@  discard block
 block discarded – undo
122 122
 	 *
123 123
 	 * @return bool
124 124
 	 */
125
-	public function hasOpposition(): bool {
125
+	public function hasOpposition (): bool {
126 126
 		return $this->getOpposingCount() >= self::REQUIRED_OPPOSE;
127 127
 	}
128 128
 
@@ -131,7 +131,7 @@  discard block
 block discarded – undo
131 131
 	 *
132 132
 	 * @return int One of the OUTCOME_* constants
133 133
 	 */
134
-	public function getOutcome(): int {
134
+	public function getOutcome (): int {
135 135
 		if ( !$this->isVote() ) {
136 136
 			return self::OUTCOME_OK;
137 137
 		}
@@ -154,7 +154,7 @@  discard block
 block discarded – undo
154 154
 	 * @throws BadMethodCallException
155 155
 	 * @throws LogicException
156 156
 	 */
157
-	public function getOutcomeText(): string {
157
+	public function getOutcomeText (): string {
158 158
 		if ( !$this->isVote() ) {
159 159
 			throw new BadMethodCallException( 'No need for an outcome text.' );
160 160
 		}
@@ -188,7 +188,7 @@  discard block
 block discarded – undo
188 188
 	 *
189 189
 	 * @return bool
190 190
 	 */
191
-	public function isVote(): bool {
191
+	public function isVote (): bool {
192 192
 		$sectionReg = '/<!-- SEZIONE DA UTILIZZARE PER/';
193 193
 		return !$this->matches( $sectionReg );
194 194
 	}
@@ -198,7 +198,7 @@  discard block
 block discarded – undo
198 198
 	 *
199 199
 	 * @return int
200 200
 	 */
201
-	public function getCreationTimestamp(): int {
201
+	public function getCreationTimestamp (): int {
202 202
 		return $this->wiki->getPageCreationTS( $this->title );
203 203
 	}
204 204
 
@@ -207,7 +207,7 @@  discard block
 block discarded – undo
207 207
 	 *
208 208
 	 * @return int
209 209
 	 */
210
-	public function getEndTimestamp(): int {
210
+	public function getEndTimestamp (): int {
211 211
 		if ( $this->isVote() ) {
212 212
 			$reg = "!La votazione ha inizio il.+ alle ore ([\d:]+) e ha termine il (.+) alla stessa ora!";
213 213
 			[ , $hours, $day ] = $this->getMatch( $reg );
Please login to merge, or discard this patch.
src/Wiki/Page/Page.php 1 patch
Spacing   +17 added lines, -17 removed lines patch added patch discarded remove patch
@@ -1,4 +1,4 @@  discard block
 block discarded – undo
1
-<?php declare( strict_types=1 );
1
+<?php declare(strict_types=1);
2 2
 
3 3
 namespace BotRiconferme\Wiki\Page;
4 4
 
@@ -22,7 +22,7 @@  discard block
 block discarded – undo
22 22
 	 * @param string $title
23 23
 	 * @param Wiki $wiki For the site where the page lives
24 24
 	 */
25
-	public function __construct( string $title, Wiki $wiki ) {
25
+	public function __construct ( string $title, Wiki $wiki ) {
26 26
 		$this->wiki = $wiki;
27 27
 		$this->title = $title;
28 28
 	}
@@ -30,7 +30,7 @@  discard block
 block discarded – undo
30 30
 	/**
31 31
 	 * @return string
32 32
 	 */
33
-	public function getTitle(): string {
33
+	public function getTitle (): string {
34 34
 		return $this->title;
35 35
 	}
36 36
 
@@ -40,7 +40,7 @@  discard block
 block discarded – undo
40 40
 	 * @param int|null $section A section number to retrieve the content of that section
41 41
 	 * @return string
42 42
 	 */
43
-	public function getContent( int $section = null ): string {
43
+	public function getContent ( int $section = null ): string {
44 44
 		if ( $this->content === null ) {
45 45
 			$this->content = $this->wiki->getPageContent( $this->title, $section );
46 46
 		}
@@ -54,18 +54,18 @@  discard block
 block discarded – undo
54 54
 	 * @phan-param array<int|string|bool> $params
55 55
 	 * @throws LogicException
56 56
 	 */
57
-	public function edit( array $params ): void {
57
+	public function edit ( array $params ): void {
58 58
 		$params = [
59 59
 			'title' => $this->getTitle()
60 60
 		] + $params;
61 61
 
62 62
 		$this->wiki->editPage( $params );
63
-		if ( isset( $params['text'] ) ) {
64
-			$this->content = $params['text'];
65
-		} elseif ( isset( $params['appendtext'] ) ) {
66
-			$this->content .= $params['appendtext'];
67
-		} elseif ( isset( $params['prependtext'] ) ) {
68
-			$this->content = $params['prependtext'] . $this->content;
63
+		if ( isset( $params[ 'text' ] ) ) {
64
+			$this->content = $params[ 'text' ];
65
+		} elseif ( isset( $params[ 'appendtext' ] ) ) {
66
+			$this->content .= $params[ 'appendtext' ];
67
+		} elseif ( isset( $params[ 'prependtext' ] ) ) {
68
+			$this->content = $params[ 'prependtext' ] . $this->content;
69 69
 		} else {
70 70
 			throw new LogicException(
71 71
 				'Unrecognized text param for edit. Params: ' . var_export( $params, true )
@@ -78,7 +78,7 @@  discard block
 block discarded – undo
78 78
 	 *
79 79
 	 * @return bool
80 80
 	 */
81
-	public function exists(): bool {
81
+	public function exists (): bool {
82 82
 		$pages = $this->wiki->getRequestFactory()->newFromParams( [
83 83
 			'action' => 'query',
84 84
 			'titles' => $this->getTitle()
@@ -92,7 +92,7 @@  discard block
 block discarded – undo
92 92
 	 * @param string $regex
93 93
 	 * @return bool
94 94
 	 */
95
-	public function matches( string $regex ): bool {
95
+	public function matches ( string $regex ): bool {
96 96
 		return (bool)preg_match( $regex, $this->getContent() );
97 97
 	}
98 98
 
@@ -104,8 +104,8 @@  discard block
 block discarded – undo
104 104
 	 * @return string[]
105 105
 	 * @throws MissingMatchException
106 106
 	 */
107
-	public function getMatch( string $regex ): array {
108
-		$ret = [];
107
+	public function getMatch ( string $regex ): array {
108
+		$ret = [ ];
109 109
 		if ( preg_match( $regex, $this->getContent(), $ret ) === 0 ) {
110 110
 			throw new MissingMatchException( "The content of $this does not match the given regex $regex" );
111 111
 		}
@@ -117,7 +117,7 @@  discard block
 block discarded – undo
117 117
 	 *
118 118
 	 * @inheritDoc
119 119
 	 */
120
-	public function getRegex( string $delimiter = '/' ): string {
120
+	public function getRegex ( string $delimiter = '/' ): string {
121 121
 		return str_replace( ' ', '[ _]', preg_quote( $this->title, $delimiter ) );
122 122
 	}
123 123
 
@@ -126,7 +126,7 @@  discard block
 block discarded – undo
126 126
 	 *
127 127
 	 * @return string
128 128
 	 */
129
-	public function __toString(): string {
129
+	public function __toString (): string {
130 130
 		return $this->getTitle();
131 131
 	}
132 132
 }
Please login to merge, or discard this patch.
src/Wiki/UserInfo.php 1 patch
Spacing   +8 added lines, -8 removed lines patch added patch discarded remove patch
@@ -1,4 +1,4 @@  discard block
 block discarded – undo
1
-<?php declare( strict_types=1 );
1
+<?php declare(strict_types=1);
2 2
 
3 3
 namespace BotRiconferme\Wiki;
4 4
 
@@ -21,7 +21,7 @@  discard block
 block discarded – undo
21 21
 	 * @param array $info
22 22
 	 * @phan-param array<string,string|string[]> $info
23 23
 	 */
24
-	public function __construct( string $name, array $info ) {
24
+	public function __construct ( string $name, array $info ) {
25 25
 		$this->name = $name;
26 26
 		$this->info = $info;
27 27
 	}
@@ -29,7 +29,7 @@  discard block
 block discarded – undo
29 29
 	/**
30 30
 	 * @return string
31 31
 	 */
32
-	public function getName(): string {
32
+	public function getName (): string {
33 33
 		return $this->name;
34 34
 	}
35 35
 
@@ -37,28 +37,28 @@  discard block
 block discarded – undo
37 37
 	 * @return array
38 38
 	 * @phan-return array<string,string|string[]>
39 39
 	 */
40
-	public function getInfo(): array {
40
+	public function getInfo (): array {
41 41
 		return $this->info;
42 42
 	}
43 43
 
44 44
 	/**
45 45
 	 * @return string[]
46 46
 	 */
47
-	public function extractGroups(): array {
47
+	public function extractGroups (): array {
48 48
 		return array_keys( $this->extractGroupsWithDates() );
49 49
 	}
50 50
 
51 51
 	/**
52 52
 	 * @return string[]
53 53
 	 */
54
-	public function extractGroupsWithDates(): array {
54
+	public function extractGroupsWithDates (): array {
55 55
 		return array_intersect_key( $this->getInfo(), array_fill_keys( self::GROUP_KEYS, 1 ) );
56 56
 	}
57 57
 
58 58
 	/**
59 59
 	 * @return string[]
60 60
 	 */
61
-	public function getAliases(): array {
62
-		return $this->getInfo()['aliases'] ?? [];
61
+	public function getAliases (): array {
62
+		return $this->getInfo()[ 'aliases' ] ?? [ ];
63 63
 	}
64 64
 }
Please login to merge, or discard this patch.
src/Wiki/Wiki.php 1 patch
Spacing   +21 added lines, -21 removed lines patch added patch discarded remove patch
@@ -1,4 +1,4 @@  discard block
 block discarded – undo
1
-<?php declare( strict_types=1 );
1
+<?php declare(strict_types=1);
2 2
 
3 3
 namespace BotRiconferme\Wiki;
4 4
 
@@ -36,7 +36,7 @@  discard block
 block discarded – undo
36 36
 	 * @param LoggerInterface $logger
37 37
 	 * @param RequestFactory $requestFactory
38 38
 	 */
39
-	public function __construct(
39
+	public function __construct (
40 40
 		LoginInfo $li,
41 41
 		LoggerInterface $logger,
42 42
 		RequestFactory $requestFactory
@@ -49,35 +49,35 @@  discard block
 block discarded – undo
49 49
 	/**
50 50
 	 * @return LoginInfo
51 51
 	 */
52
-	public function getLoginInfo(): LoginInfo {
52
+	public function getLoginInfo (): LoginInfo {
53 53
 		return $this->loginInfo;
54 54
 	}
55 55
 
56 56
 	/**
57 57
 	 * @return RequestFactory
58 58
 	 */
59
-	public function getRequestFactory(): RequestFactory {
59
+	public function getRequestFactory (): RequestFactory {
60 60
 		return $this->requestFactory;
61 61
 	}
62 62
 
63 63
 	/**
64 64
 	 * @param string $prefix
65 65
 	 */
66
-	public function setPagePrefix( string $prefix ): void {
66
+	public function setPagePrefix ( string $prefix ): void {
67 67
 		$this->pagePrefix = $prefix;
68 68
 	}
69 69
 
70 70
 	/**
71 71
 	 * @param string $ident
72 72
 	 */
73
-	public function setLocalUserIdentifier( string $ident ): void {
73
+	public function setLocalUserIdentifier ( string $ident ): void {
74 74
 		$this->localUserIdentifier = $ident;
75 75
 	}
76 76
 
77 77
 	/**
78 78
 	 * @return string
79 79
 	 */
80
-	public function getLocalUserIdentifier(): string {
80
+	public function getLocalUserIdentifier (): string {
81 81
 		return $this->localUserIdentifier;
82 82
 	}
83 83
 
@@ -85,7 +85,7 @@  discard block
 block discarded – undo
85 85
 	 * @param string $title
86 86
 	 * @param int|null $section
87 87
 	 */
88
-	private function logRead( string $title, int $section = null ): void {
88
+	private function logRead ( string $title, int $section = null ): void {
89 89
 		$fullTitle = $this->pagePrefix . $title;
90 90
 		$msg = "Retrieving content of $fullTitle" . ( $section !== null ? ", section $section" : '' );
91 91
 		$this->logger->info( $msg );
@@ -100,7 +100,7 @@  discard block
 block discarded – undo
100 100
 	 * @throws MissingPageException
101 101
 	 * @throws MissingSectionException
102 102
 	 */
103
-	public function getPageContent( string $title, int $section = null ): string {
103
+	public function getPageContent ( string $title, int $section = null ): string {
104 104
 		$this->logRead( $title, $section );
105 105
 		$params = [
106 106
 			'action' => 'query',
@@ -111,7 +111,7 @@  discard block
 block discarded – undo
111 111
 		];
112 112
 
113 113
 		if ( $section !== null ) {
114
-			$params['rvsection'] = $section;
114
+			$params[ 'rvsection' ] = $section;
115 115
 		}
116 116
 
117 117
 		$req = $this->buildRequest( $params );
@@ -120,7 +120,7 @@  discard block
 block discarded – undo
120 120
 			throw new MissingPageException( $title );
121 121
 		}
122 122
 
123
-		$mainSlot = $page->revisions[0]->slots->main;
123
+		$mainSlot = $page->revisions[ 0 ]->slots->main;
124 124
 
125 125
 		if ( $section !== null && isset( $mainSlot->nosuchsection ) ) {
126 126
 			throw new MissingSectionException( $title, $section );
@@ -135,7 +135,7 @@  discard block
 block discarded – undo
135 135
 	 * @phan-param array<int|string|bool> $params
136 136
 	 * @throws EditException
137 137
 	 */
138
-	public function editPage( array $params ): void {
138
+	public function editPage ( array $params ): void {
139 139
 		$this->login();
140 140
 
141 141
 		$params = [
@@ -144,7 +144,7 @@  discard block
 block discarded – undo
144 144
 		] + $params;
145 145
 
146 146
 		if ( BOT_EDITS === true ) {
147
-			$params['bot'] = 1;
147
+			$params[ 'bot' ] = 1;
148 148
 		}
149 149
 
150 150
 		$res = $this->buildRequest( $params )->setPost()->executeSingle();
@@ -162,7 +162,7 @@  discard block
 block discarded – undo
162 162
 	 * Login wrapper. Checks if we're already logged in and clears tokens cache
163 163
 	 * @throws LoginException
164 164
 	 */
165
-	public function login(): void {
165
+	public function login (): void {
166 166
 		if ( $this->loginInfo === null ) {
167 167
 			throw new CannotLoginException( 'Missing login data' );
168 168
 		}
@@ -192,7 +192,7 @@  discard block
 block discarded – undo
192 192
 
193 193
 		$this->loggedIn = true;
194 194
 		// Clear tokens cache
195
-		$this->tokens = [];
195
+		$this->tokens = [ ];
196 196
 		$this->logger->info( 'Login succeeded' );
197 197
 	}
198 198
 
@@ -202,7 +202,7 @@  discard block
 block discarded – undo
202 202
 	 * @param string $type
203 203
 	 * @return string
204 204
 	 */
205
-	public function getToken( string $type ): string {
205
+	public function getToken ( string $type ): string {
206 206
 		if ( !isset( $this->tokens[ $type ] ) ) {
207 207
 			$params = [
208 208
 				'action' => 'query',
@@ -222,7 +222,7 @@  discard block
 block discarded – undo
222 222
 	 * @param string $title
223 223
 	 * @return int
224 224
 	 */
225
-	public function getPageCreationTS( string $title ): int {
225
+	public function getPageCreationTS ( string $title ): int {
226 226
 		$params = [
227 227
 			'action' => 'query',
228 228
 			'prop' => 'revisions',
@@ -234,7 +234,7 @@  discard block
 block discarded – undo
234 234
 		];
235 235
 
236 236
 		$page = $this->buildRequest( $params )->executeAsQuery()->current();
237
-		return strtotime( $page->revisions[0]->timestamp );
237
+		return strtotime( $page->revisions[ 0 ]->timestamp );
238 238
 	}
239 239
 
240 240
 	/**
@@ -243,7 +243,7 @@  discard block
 block discarded – undo
243 243
 	 * @param string $title
244 244
 	 * @param string $reason
245 245
 	 */
246
-	public function protectPage( string $title, string $reason ): void {
246
+	public function protectPage ( string $title, string $reason ): void {
247 247
 		$fullTitle = $this->pagePrefix . $title;
248 248
 		$this->logger->info( "Protecting page $fullTitle" );
249 249
 		$this->login();
@@ -266,7 +266,7 @@  discard block
 block discarded – undo
266 266
 	 * @param string $username
267 267
 	 * @param string $reason
268 268
 	 */
269
-	public function blockUser( string $username, string $reason ): void {
269
+	public function blockUser ( string $username, string $reason ): void {
270 270
 		$this->logger->info( "Blocking user $username" );
271 271
 		$this->login();
272 272
 
@@ -293,7 +293,7 @@  discard block
 block discarded – undo
293 293
 	 * @phan-param array<int|string|bool> $params
294 294
 	 * @return RequestBase
295 295
 	 */
296
-	private function buildRequest( array $params ): RequestBase {
296
+	private function buildRequest ( array $params ): RequestBase {
297 297
 		return $this->requestFactory->newFromParams( $params );
298 298
 	}
299 299
 }
Please login to merge, or discard this patch.