Daimona / BotRiconferme

src/Task/Subtask/FailedUpdates.php

Spacing +20 added lines, -20 removed lines

@@ -1,4 +1,4 @@ 
-<?php declare( strict_types=1 );
+<?php declare(strict_types=1);
 
 namespace BotRiconferme\Task\Subtask;
 
@@ -16,7 +16,7 @@ 
 	/**
 	 * @inheritDoc
 	 */
-	public function runInternal(): int {
+	public function runInternal (): int {
 		$failed = $this->getFailures();
 		if ( !$failed ) {
 			return TaskResult::STATUS_NOTHING;
@@ -41,12 +41,12 @@ 
 	 *
 	 * @return PageRiconferma[]
 	 */
-	private function getFailures(): array {
-		$ret = [];
+	private function getFailures (): array {
+		$ret = [ ];
 		$allPages = $this->getDataProvider()->getPagesToClose();
 		foreach ( $allPages as $page ) {
 			if ( $page->getOutcome() & PageRiconferma::OUTCOME_FAIL ) {
-				$ret[] = $page;
+				$ret[ ] = $page;
 			}
 		}
 		return $ret;
@@ -55,7 +55,7 @@ 
 	/**
 	 * @param User[] $users
 	 */
-	protected function updateBurList( array $users ): void {
+	protected function updateBurList ( array $users ): void {
 		$this->getLogger()->info( 'Updating bur list. Removing: ' . implode( ', ', $users ) );
 		$remList = RegexUtils::regexFromArray( '!', ...$users );
 		$burList = $this->getPage( $this->getOpt( 'bur-list-title' ) );
@@ -78,7 +78,7 @@ 
 	 *
 	 * @param PageRiconferma[] $pages
 	 */
-	protected function requestRemoval( array $pages ): void {
+	protected function requestRemoval ( array $pages ): void {
 		$this->getLogger()->info( 'Requesting flag removal for: ' . implode( ', ', $pages ) );
 
 		$metaWiki = $this->getWikiGroup()->getCentralWiki();
@@ -115,21 +115,21 @@ 
 	 *
 	 * @param PageRiconferma[] $pages
 	 */
-	protected function updateAnnunci( array $pages ): void {
+	protected function updateAnnunci ( array $pages ): void {
 		$this->getLogger()->info( 'Updating annunci' );
 		$section = 1;
 
-		$names = [];
+		$names = [ ];
 		$text = '';
 		foreach ( $pages as $page ) {
 			$user = $page->getUserName();
-			$names[] = $user;
+			$names[ ] = $user;
 			$text .= $this->msg( 'annunci-text' )->params( [ '$user' => $user ] )->text();
 		}
 
 		/** @var string $curMonth */
 		$curMonth = date( 'F' );
-		$month = ucfirst( Message::MONTHS[$curMonth] );
+		$month = ucfirst( Message::MONTHS[ $curMonth ] );
 
 		$annunciPage = $this->getPage( $this->getOpt( 'annunci-page-title' ) );
 		$content = $annunciPage->getContent( $section );
@@ -157,16 +157,16 @@ 
 	 *
 	 * @param PageRiconferma[] $pages
 	 */
-	protected function updateUltimeNotizie( array $pages ): void {
+	protected function updateUltimeNotizie ( array $pages ): void {
 		$this->getLogger()->info( 'Updating ultime notizie' );
 		$notiziePage = $this->getPage( $this->getOpt( 'ultimenotizie-page-title' ) );
 
-		$names = [];
+		$names = [ ];
 		$text = '';
 		$msg = $this->msg( 'ultimenotizie-text' );
 		foreach ( $pages as $page ) {
 			$user = $page->getUserName();
-			$names[] = $user;
+			$names[ ] = $user;
 			$text .= $msg->params( [ '$user' => $user, '$title' => $page->getTitle() ] )->text();
 		}
 
@@ -194,7 +194,7 @@ 
 	 *
 	 * @param PageRiconferma[] $pages
 	 */
-	protected function updateTimeline( array $pages ): void {
+	protected function updateTimeline ( array $pages ): void {
 		$this->getLogger()->info( 'Updating timeline' );
 		$timelinePage = $this->getPage( $this->getOpt( 'timeline-page-title' ) );
 		$content = $timelinePage->getContent();
@@ -222,7 +222,7 @@ 
 	 *
 	 * @param PageRiconferma[] $pages
 	 */
-	private function updateCronologia( array $pages ): void {
+	private function updateCronologia ( array $pages ): void {
 		$this->getLogger()->info( 'Updating cronologia' );
 		$timelinePage = $this->getPage( $this->getOpt( 'cronologia-page-title' ) );
 		$content = $timelinePage->getContent();
@@ -249,7 +249,7 @@ 
 	 *
 	 * @param PageRiconferma[] $pages
 	 */
-	private function blockOnPrivate( array $pages ): void {
+	private function blockOnPrivate ( array $pages ): void {
 		$this->getLogger()->info( 'Blocking on private wiki: ' . implode( ', ', $pages ) );
 
 		$privWiki = $this->getWikiGroup()->getPrivateWiki();
@@ -266,12 +266,12 @@ 
 	 * @param PageRiconferma[] $pages
 	 * @return User[]
 	 */
-	private function getFailedBureaucrats( array $pages ): array {
-		$ret = [];
+	private function getFailedBureaucrats ( array $pages ): array {
+		$ret = [ ];
 		foreach ( $pages as $page ) {
 			$user = $this->getUser( $page->getUserName() );
 			if ( $user->inGroup( 'bureaucrat' ) ) {
-				$ret[] = $user;
+				$ret[ ] = $user;
 			}
 		}
 		return $ret;

src/Task/Subtask/ArchivePages.php

Spacing +14 added lines, -14 removed lines

@@ -1,4 +1,4 @@ 
-<?php declare( strict_types=1 );
+<?php declare(strict_types=1);
 
 namespace BotRiconferme\Task\Subtask;
 
@@ -13,7 +13,7 @@ 
 	/**
 	 * @inheritDoc
 	 */
-	public function runInternal(): int {
+	public function runInternal (): int {
 		$pages = $this->getDataProvider()->getPagesToClose();
 
 		if ( !$pages ) {
@@ -32,18 +32,18 @@ 
 	 * @param PageRiconferma[] $pages
 	 * @see OpenUpdates::addToMainPage()
 	 */
-	protected function removeFromMainPage( array $pages ): void {
+	protected function removeFromMainPage ( array $pages ): void {
 		$this->getLogger()->info(
 			'Removing from main: ' . implode( ', ', $pages )
 		);
 
 		$mainPage = $this->getPage( $this->getOpt( 'main-page-title' ) );
-		$remove = [];
+		$remove = [ ];
 		foreach ( $pages as $page ) {
 			// Order matters here. It's not guaranteed that there'll be a newline, but avoid
 			// regexps for that single character.
-			$remove[] = '{{' . $page->getTitle() . "}}\n";
-			$remove[] = '{{' . $page->getTitle() . '}}';
+			$remove[ ] = '{{' . $page->getTitle() . "}}\n";
+			$remove[ ] = '{{' . $page->getTitle() . '}}';
 		}
 
 		$newContent = str_replace( $remove, '', $mainPage->getContent() );
@@ -72,17 +72,17 @@ 
 	 *
 	 * @param PageRiconferma[] $pages
 	 */
-	protected function addToArchive( array $pages ): void {
+	protected function addToArchive ( array $pages ): void {
 		$this->getLogger()->info(
 			'Adding to archive: ' . implode( ', ', $pages )
 		);
 
-		$simple = $votes = [];
+		$simple = $votes = [ ];
 		foreach ( $pages as $page ) {
 			if ( $page->isVote() ) {
-				$votes[] = $page;
+				$votes[ ] = $page;
 			} else {
-				$simple[] = $page;
+				$simple[ ] = $page;
 			}
 		}
 
@@ -103,15 +103,15 @@ 
 	 * @param string $archiveTitle
 	 * @param PageRiconferma[] $pages
 	 */
-	private function reallyAddToArchive( string $archiveTitle, array $pages ): void {
+	private function reallyAddToArchive ( string $archiveTitle, array $pages ): void {
 		$archivePage = $this->getPage( "$archiveTitle/" . date( 'Y' ) );
 		$existed = $archivePage->exists();
 
 		$append = "\n";
-		$archivedList = [];
+		$archivedList = [ ];
 		foreach ( $pages as $page ) {
 			$append .= '{{' . $page->getTitle() . "}}\n";
-			$archivedList[] = $page->getUserNum();
+			$archivedList[ ] = $page->getUserNum();
 		}
 
 		$summary = $this->msg( 'close-archive-summary' )
@@ -132,7 +132,7 @@ 
 	 *
 	 * @param string $archiveTitle
 	 */
-	private function addArchiveYear( string $archiveTitle ): void {
+	private function addArchiveYear ( string $archiveTitle ): void {
 		$page = $this->getPage( $archiveTitle );
 		$year = date( 'Y' );
 

src/Task/Subtask/SimpleUpdates.php

Spacing +18 added lines, -18 removed lines

@@ -1,4 +1,4 @@ 
-<?php declare( strict_types=1 );
+<?php declare(strict_types=1);
 
 namespace BotRiconferme\Task\Subtask;
 
@@ -14,7 +14,7 @@ 
 	/**
 	 * @inheritDoc
 	 */
-	public function runInternal(): int {
+	public function runInternal (): int {
 		$pages = $this->getDataProvider()->getPagesToClose();
 
 		if ( !$pages ) {
@@ -36,15 +36,15 @@ 
 	 * @param PageRiconferma[] $pages
 	 * @see OpenUpdates::addToVotazioni()
 	 */
-	protected function updateVotazioni( array $pages ): void {
+	protected function updateVotazioni ( array $pages ): void {
 		$this->getLogger()->info(
 			'Updating votazioni: ' . implode( ', ', $pages )
 		);
 		$votePage = $this->getPage( $this->getOpt( 'vote-page-title' ) );
 
-		$users = [];
+		$users = [ ];
 		foreach ( $pages as $page ) {
-			$users[] = $this->getUser( $page->getUserName() );
+			$users[ ] = $this->getUser( $page->getUserName() );
 		}
 		$usersReg = RegexUtils::regexFromArray( '!', ...$users );
 
@@ -65,7 +65,7 @@ 
 	 * @param PageRiconferma[] $pages
 	 * @see OpenUpdates::addToNews()
 	 */
-	protected function updateNews( array $pages ): void {
+	protected function updateNews ( array $pages ): void {
 		$simpleAmount = $voteAmount = 0;
 		foreach ( $pages as $page ) {
 			if ( $page->isVote() ) {
@@ -85,8 +85,8 @@ 
 		$simpleMatches = $newsPage->getMatch( $simpleReg );
 		$voteMatches = $newsPage->getMatch( $voteReg );
 
-		$newSimp = ( (int)$simpleMatches[2] - $simpleAmount ) ?: '';
-		$newVote = ( (int)$voteMatches[2] - $voteAmount ) ?: '';
+		$newSimp = ( (int)$simpleMatches[ 2 ] - $simpleAmount ) ?: '';
+		$newVote = ( (int)$voteMatches[ 2 ] - $voteAmount ) ?: '';
 		$newContent = preg_replace( $simpleReg, '${1}' . $newSimp, $newsPage->getContent() );
 		$newContent = preg_replace( $voteReg, '${1}' . $newVote, $newContent );
 
@@ -104,12 +104,12 @@ 
 	 *
 	 * @param bool[] $outcomes
 	 */
-	protected function updateAdminList( array $outcomes ): void {
+	protected function updateAdminList ( array $outcomes ): void {
 		$this->getLogger()->info( 'Updating admin list' );
 		$adminsPage = $this->getPage( $this->getOpt( 'admins-list-title' ) );
 		$newContent = $adminsPage->getContent();
 
-		$riconfNames = $removeNames = [];
+		$riconfNames = $removeNames = [ ];
 		foreach ( $outcomes as $username => $confirmed ) {
 			$user = $this->getUser( $username );
 			$userReg = $user->getRegex( '!' );
@@ -124,10 +124,10 @@ 
 					'${1}{{subst:#timel:Ymd}}|' . $nextDate . '$2',
 					$newContent
 				);
-				$riconfNames[] = $username;
+				$riconfNames[ ] = $username;
 			} else {
 				$newContent = preg_replace( $reg, '', $newContent );
-				$removeNames[] = $username;
+				$removeNames[ ] = $username;
 			}
 		}
 
@@ -153,21 +153,21 @@ 
 	/**
 	 * @param bool[] $outcomes
 	 */
-	protected function updateCUList( array $outcomes ): void {
+	protected function updateCUList ( array $outcomes ): void {
 		$this->getLogger()->info( 'Updating CU list.' );
 		$cuList = $this->getPage( $this->getOpt( 'cu-list-title' ) );
 		$newContent = $cuList->getContent();
 
-		$riconfNames = $removeNames = [];
+		$riconfNames = $removeNames = [ ];
 		foreach ( $outcomes as $user => $confirmed ) {
 			$userReg = $this->getUser( $user )->getRegex( '!' );
 			$reg = "!(\{\{ *Checkuser *\| *$userReg *\|[^}]+\| *)[\w \d]+(}}.*\n)!";
 			if ( $confirmed ) {
 				$newContent = preg_replace( $reg, '${1}{{subst:#time:j F Y}}$2', $newContent );
-				$riconfNames[] = $user;
+				$riconfNames[ ] = $user;
 			} else {
 				$newContent = preg_replace( $reg, '', $newContent );
-				$removeNames[] = $user;
+				$removeNames[ ] = $user;
 			}
 		}
 
@@ -197,8 +197,8 @@ 
 	 * @param PageRiconferma[] $pages
 	 * @return bool[]
 	 */
-	private function getGroupOutcomes( string $group, array $pages ): array {
-		$ret = [];
+	private function getGroupOutcomes ( string $group, array $pages ): array {
+		$ret = [ ];
 		foreach ( $pages as $page ) {
 			$user = $this->getUser( $page->getUserName() );
 			if ( $user->inGroup( $group ) ) {

src/Task/Subtask/ClosePages.php

Spacing +5 added lines, -6 removed lines

@@ -1,4 +1,4 @@ 
-<?php declare( strict_types=1 );
+<?php declare(strict_types=1);
 
 namespace BotRiconferme\Task\Subtask;
 
@@ -13,7 +13,7 @@ 
 	/**
 	 * @inheritDoc
 	 */
-	public function runInternal(): int {
+	public function runInternal (): int {
 		$pages = $this->getDataProvider()->getPagesToClose();
 
 		if ( !$pages ) {
@@ -35,7 +35,7 @@ 
 	/**
 	 * @param PageRiconferma $page
 	 */
-	protected function addVoteCloseText( PageRiconferma $page ): void {
+	protected function addVoteCloseText ( PageRiconferma $page ): void {
 		$content = $page->getContent();
 		$beforeReg = '!è necessario ottenere una maggioranza .+ votanti\.!u';
 		$newContent = preg_replace( $beforeReg, '$0' . "\n" . $page->getOutcomeText(), $content );
@@ -50,7 +50,7 @@ 
 	 * @param PageRiconferma $page
 	 * @see CreatePages::updateBasePage()
 	 */
-	protected function updateBasePage( PageRiconferma $page ): void {
+	protected function updateBasePage ( PageRiconferma $page ): void {
 		$this->getLogger()->info( "Updating base page for $page" );
 
 		if ( $page->getNum() === 1 ) {
@@ -62,8 +62,7 @@ 
 		$current = $basePage->getContent();
 
 		$outcomeText = ( $page->getOutcome() & PageRiconferma::OUTCOME_FAIL ) ?
-			'non riconfermato' :
-			'riconfermato';
+			'non riconfermato' : 'riconfermato';
 		$text = $page->isVote() ? "votazione di riconferma: $outcomeText" : 'riconferma tacita';
 
 		$newContent = preg_replace( '/^(#: *)(votazione di )?riconferma in corso/m', '$1' . $text, $current );

src/Task/Subtask/OpenUpdates.php

Spacing +6 added lines, -6 removed lines

@@ -1,4 +1,4 @@ 
-<?php declare( strict_types=1 );
+<?php declare(strict_types=1);
 
 namespace BotRiconferme\Task\Subtask;
 
@@ -13,7 +13,7 @@ 
 	/**
 	 * @inheritDoc
 	 */
-	public function runInternal(): int {
+	public function runInternal (): int {
 		$pages = $this->getDataProvider()->getCreatedPages();
 
 		if ( !$pages ) {
@@ -35,7 +35,7 @@ 
 	 *
 	 * @param PageRiconferma[] $pages
 	 */
-	protected function addToMainPage( array $pages ): void {
+	protected function addToMainPage ( array $pages ): void {
 		$this->getLogger()->info(
 			'Adding the following to main: ' . implode( ', ', $pages )
 		);
@@ -68,7 +68,7 @@ 
 	 *
 	 * @param PageRiconferma[] $pages
 	 */
-	protected function addToVotazioni( array $pages ): void {
+	protected function addToVotazioni ( array $pages ): void {
 		$this->getLogger()->info(
 			'Adding the following to votes: ' . implode( ', ', $pages )
 		);
@@ -105,7 +105,7 @@ 
 	 * @param int $amount
 	 * @throws TaskException
 	 */
-	protected function addToNews( int $amount ): void {
+	protected function addToNews ( int $amount ): void {
 		$this->getLogger()->info( "Increasing the news counter by $amount" );
 		$newsPage = $this->getPage( $this->getOpt( 'news-page-title' ) );
 
@@ -118,7 +118,7 @@ 
 
 		$matches = $newsPage->getMatch( $reg );
 
-		$newNum = (int)$matches[2] + $amount;
+		$newNum = (int)$matches[ 2 ] + $amount;
 		$newContent = preg_replace( $reg, '${1}' . $newNum, $content );
 
 		$summary = $this->msg( 'news-page-summary' )

src/Task/Subtask/CreatePages.php

Spacing +13 added lines, -13 removed lines

@@ -1,4 +1,4 @@ 
-<?php declare( strict_types=1 );
+<?php declare(strict_types=1);
 
 namespace BotRiconferme\Task\Subtask;
 
@@ -17,7 +17,7 @@ 
 	/**
 	 * @inheritDoc
 	 */
-	public function runInternal(): int {
+	public function runInternal (): int {
 		$users = $this->getDataProvider()->getUsersToProcess();
 
 		if ( !$users ) {
@@ -36,7 +36,7 @@ 
 	 *
 	 * @param User $user
 	 */
-	protected function processUser( User $user ): void {
+	protected function processUser ( User $user ): void {
 		$this->getLogger()->info( "Processing user $user" );
 		try {
 			$num = $this->getLastPageNum( $user ) + 1;
@@ -71,14 +71,14 @@ 
 	 * @return int
 	 * @throws TaskException
 	 */
-	protected function getLastPageNum( User $user ): int {
+	protected function getLastPageNum ( User $user ): int {
 		$this->getLogger()->info( "Retrieving previous pages for $user" );
 
-		$unprefixedTitle = explode( ':', $this->getOpt( 'main-page-title' ), 2 )[1];
+		$unprefixedTitle = explode( ':', $this->getOpt( 'main-page-title' ), 2 )[ 1 ];
 
 		$prefixes = [ "$unprefixedTitle/$user/" ];
 		foreach ( $user->getAliases() as $alias ) {
-			$prefixes[] = "$unprefixedTitle/$alias/";
+			$prefixes[ ] = "$unprefixedTitle/$alias/";
 		}
 
 		$params = [
@@ -90,7 +90,7 @@ 
 		];
 		$pagesIterator = new AppendIterator();
 		foreach ( $prefixes as $prefix ) {
-			$params['apprefix'] = $prefix;
+			$params[ 'apprefix' ] = $prefix;
 			$res = $this->getRequestFactory()->newFromParams( $params )->executeAsQuery();
 			$pagesIterator->append( new NoRewindIterator( $res ) );
 		}
@@ -116,14 +116,14 @@ 
 	 * @param string $title
 	 * @param User $user
 	 */
-	protected function createPage( string $title, User $user ): void {
+	protected function createPage ( string $title, User $user ): void {
 		$this->getLogger()->info( "Creating page $title" );
 		$groups = $user->getGroupsWithDates();
 		$textParams = [
 			'$user' => $user->getName(),
-			'$date' => $groups['sysop'],
-			'$burocrate' => $groups['bureaucrat'] ?? '',
-			'$checkuser' => $groups['checkuser'] ?? ''
+			'$date' => $groups[ 'sysop' ],
+			'$burocrate' => $groups[ 'bureaucrat' ] ?? '',
+			'$checkuser' => $groups[ 'checkuser' ] ?? ''
 		];
 
 		$params = [
@@ -141,7 +141,7 @@ 
 	 * @param Page $basePage
 	 * @param string $newText
 	 */
-	protected function createBasePage( Page $basePage, string $newText ): void {
+	protected function createBasePage ( Page $basePage, string $newText ): void {
 		$this->getLogger()->info( "Creating base page $basePage" );
 
 		$params = [
@@ -157,7 +157,7 @@ 
 	 * @param Page $basePage
 	 * @param string $newText
 	 */
-	protected function updateBasePage( Page $basePage, string $newText ): void {
+	protected function updateBasePage ( Page $basePage, string $newText ): void {
 		$this->getLogger()->info( "Updating base page $basePage" );
 
 		$params = [

src/Task/Subtask/UserNotice.php

Spacing +4 added lines, -4 removed lines

@@ -1,4 +1,4 @@ 
-<?php declare( strict_types=1 );
+<?php declare(strict_types=1);
 
 namespace BotRiconferme\Task\Subtask;
 
@@ -12,7 +12,7 @@ 
 	/**
 	 * @inheritDoc
 	 */
-	public function runInternal(): int {
+	public function runInternal (): int {
 		$pages = $this->getDataProvider()->getCreatedPages();
 		$users = $this->getDataProvider()->getUsersToProcess();
 
@@ -20,7 +20,7 @@ 
 			return TaskResult::STATUS_NOTHING;
 		}
 
-		$ricNums = [];
+		$ricNums = [ ];
 		foreach ( $pages as $page ) {
 			$ricNums[ $page->getUserName() ] = $page->getNum();
 		}
@@ -38,7 +38,7 @@ 
 	 * @param User $user
 	 * @param int $ricNum
 	 */
-	protected function addMsg( User $user, int $ricNum ): void {
+	protected function addMsg ( User $user, int $ricNum ): void {
 		$this->getLogger()->info( "Leaving msg to $user" );
 		$msg = $this->msg( 'user-notice-msg' )->params( [ '$num' => $ricNum ] )->text();
 

src/Task/CloseOld.php

Spacing +3 added lines, -3 removed lines

@@ -1,4 +1,4 @@ 
-<?php declare( strict_types=1 );
+<?php declare(strict_types=1);
 
 namespace BotRiconferme\Task;
 
@@ -15,7 +15,7 @@ 
 	/**
 	 * @inheritDoc
 	 */
-	public function runInternal(): int {
+	public function runInternal (): int {
 		$orderedList = [
 			'close-pages',
 			'archive-pages',
@@ -34,7 +34,7 @@ 
 	/**
 	 * @inheritDoc
 	 */
-	protected function getSubtasksMap(): array {
+	protected function getSubtasksMap (): array {
 		return [
 			'archive-pages' => ArchivePages::class,
 			'close-pages' => ClosePages::class,

src/Task/Task.php

Spacing +5 added lines, -5 removed lines

@@ -1,4 +1,4 @@ 
-<?php declare( strict_types=1 );
+<?php declare(strict_types=1);
 
 namespace BotRiconferme\Task;
 
@@ -15,13 +15,13 @@ 
 	 *
 	 * @return string[]
 	 */
-	abstract protected function getSubtasksMap(): array;
+	abstract protected function getSubtasksMap (): array;
 
 	/**
 	 * @param string $subtask Defined in self::SUBTASKS_MAP
 	 * @return TaskResult
 	 */
-	protected function runSubtask( string $subtask ): TaskResult {
+	protected function runSubtask ( string $subtask ): TaskResult {
 		$map = $this->getSubtasksMap();
 		if ( !isset( $map[ $subtask ] ) ) {
 			throw new InvalidArgumentException( "'$subtask' is not a valid task." );
@@ -34,7 +34,7 @@ 
 	/**
 	 * @inheritDoc
 	 */
-	final public function getOperationName(): string {
+	final public function getOperationName (): string {
 		return 'task';
 	}
 
@@ -44,7 +44,7 @@ 
 	 * @param string $class
 	 * @return Subtask
 	 */
-	private function getSubtaskInstance( string $class ): Subtask {
+	private function getSubtaskInstance ( string $class ): Subtask {
 		return new $class(
 			$this->getLogger(),
 			$this->getWikiGroup(),