Daimona / BotRiconferme

src/Task/StartVote.php

Spacing +15 added lines, -15 removed lines

@@ -1,4 +1,4 @@ 
-<?php declare( strict_types=1 );
+<?php declare(strict_types=1);
 
 namespace BotRiconferme\Task;
 
@@ -14,15 +14,15 @@ 
 	/**
 	 * @inheritDoc
 	 */
-	protected function getSubtasksMap(): array {
+	protected function getSubtasksMap (): array {
 		// Everything is done here.
-		return [];
+		return [ ];
 	}
 
 	/**
 	 * @inheritDoc
 	 */
-	public function runInternal(): int {
+	public function runInternal (): int {
 		$pages = $this->getDataProvider()->getOpenPages();
 
 		if ( !$pages ) {
@@ -36,13 +36,13 @@ 
 	 * @param PageRiconferma[] $pages
 	 * @return int a STATUS_* constant
 	 */
-	protected function processPages( array $pages ): int {
-		$donePages = [];
+	protected function processPages ( array $pages ): int {
+		$donePages = [ ];
 		foreach ( $pages as $page ) {
 			if ( $page->hasOpposition() && !$page->isVote() ) {
 				$this->openVote( $page );
 				$this->updateBasePage( $page );
-				$donePages[] = $page;
+				$donePages[ ] = $page;
 			}
 		}
 
@@ -60,7 +60,7 @@ 
 	 *
 	 * @param PageRiconferma $page
 	 */
-	protected function openVote( PageRiconferma $page ): void {
+	protected function openVote ( PageRiconferma $page ): void {
 		$this->getLogger()->info( "Starting vote on $page" );
 
 		$content = $page->getContent();
@@ -99,12 +99,12 @@ 
 	 * @see SimpleUpdates::updateVotazioni()
 	 * @see OpenUpdates::addToVotazioni()
 	 */
-	protected function updateVotazioni( array $pages ): void {
+	protected function updateVotazioni ( array $pages ): void {
 		$votePage = $this->getPage( $this->getOpt( 'vote-page-title' ) );
 
-		$users = [];
+		$users = [ ];
 		foreach ( $pages as $page ) {
-			$users[] = $this->getUser( $page->getUserName() );
+			$users[ ] = $this->getUser( $page->getUserName() );
 		}
 		$usersReg = RegexUtils::regexFromArray( '!', ...$users );
 
@@ -138,7 +138,7 @@ 
 	 * @param PageRiconferma $page
 	 * @see \BotRiconferme\Task\Subtask\ClosePages::updateBasePage()
 	 */
-	protected function updateBasePage( PageRiconferma $page ): void {
+	protected function updateBasePage ( PageRiconferma $page ): void {
 		$this->getLogger()->info( "Updating base page for $page" );
 
 		if ( $page->getNum() === 1 ) {
@@ -165,7 +165,7 @@ 
 	 * @see SimpleUpdates::updateNews()
 	 * @see OpenUpdates::addToNews()
 	 */
-	protected function updateNews( int $amount ): void {
+	protected function updateNews ( int $amount ): void {
 		$this->getLogger()->info( "Turning $amount pages into votes" );
 		$newsPage = $this->getPage( $this->getOpt( 'news-page-title' ) );
 
@@ -180,8 +180,8 @@ 
 			throw new TaskException( 'Param "voto" not found in news page' );
 		}
 
-		$newTac = ( (int)$newsPage->getMatch( $regTac )[2] - $amount ) ?: '';
-		$newVot = ( (int)$newsPage->getMatch( $regVot )[2] + $amount ) ?: '';
+		$newTac = ( (int)$newsPage->getMatch( $regTac )[ 2 ] - $amount ) ?: '';
+		$newVot = ( (int)$newsPage->getMatch( $regVot )[ 2 ] + $amount ) ?: '';
 
 		$newContent = preg_replace( $regTac, '${1}' . $newTac, $content );
 		$newContent = preg_replace( $regVot, '${1}' . $newVot, $newContent );

src/Task/UpdateList.php

Spacing +30 added lines, -30 removed lines

@@ -1,4 +1,4 @@ 
-<?php declare( strict_types=1 );
+<?php declare(strict_types=1);
 
 namespace BotRiconferme\Task;
 
@@ -22,15 +22,15 @@ 
 	/**
 	 * @inheritDoc
 	 */
-	protected function getSubtasksMap(): array {
+	protected function getSubtasksMap (): array {
 		// Everything is done here.
-		return [];
+		return [ ];
 	}
 
 	/**
 	 * @inheritDoc
 	 */
-	public function runInternal(): int {
+	public function runInternal (): int {
 		$this->actualList = $this->getActualAdmins();
 		$pageBotList = $this->getBotList();
 		$this->botList = $pageBotList->getDecodedContent();
@@ -58,7 +58,7 @@ 
 	 * @return string[][]
 	 * @phan-return array<string,string[]>
 	 */
-	protected function getActualAdmins(): array {
+	protected function getActualAdmins (): array {
 		$params = [
 			'action' => 'query',
 			'list' => 'allusers',
@@ -76,8 +76,8 @@ 
 	 * @return string[][]
 	 * @phan-return array<string,string[]>
 	 */
-	protected function extractAdmins( Generator $data ): array {
-		$ret = [];
+	protected function extractAdmins ( Generator $data ): array {
+		$ret = [ ];
 		$blacklist = $this->getOpt( 'exclude-admins' );
 		foreach ( $data as $u ) {
 			if ( in_array( $u->name, $blacklist, true ) ) {
@@ -94,16 +94,16 @@ 
 	 *
 	 * @return string[][]
 	 */
-	protected function getMissingGroups(): array {
-		$missing = [];
+	protected function getMissingGroups (): array {
+		$missing = [ ];
 		foreach ( $this->actualList as $adm => $groups ) {
-			$curMissing = array_diff( $groups, array_keys( $this->botList[$adm] ?? [] ) );
+			$curMissing = array_diff( $groups, array_keys( $this->botList[ $adm ] ?? [ ] ) );
 
 			foreach ( $curMissing as $group ) {
 				try {
 					$missing[ $adm ][ $group ] = $this->getFlagDate( $adm, $group );
 				} catch ( TaskException $e ) {
-					$this->errors[] = $e->getMessage();
+					$this->errors[ ] = $e->getMessage();
 				}
 			}
 		}
@@ -118,7 +118,7 @@ 
 	 * @return string
 	 * @throws TaskException
 	 */
-	protected function getFlagDate( string $admin, string $group ): string {
+	protected function getFlagDate ( string $admin, string $group ): string {
 		$this->getLogger()->info( "Retrieving $group flag date for $admin" );
 
 		$wiki = $this->getWiki();
@@ -153,7 +153,7 @@ 
 	 * @param string $group
 	 * @return string|null
 	 */
-	private function extractTimestamp( Generator $data, string $group ): ?string {
+	private function extractTimestamp ( Generator $data, string $group ): ?string {
 		$ts = null;
 		foreach ( $data as $entry ) {
 			if (
@@ -172,8 +172,8 @@ 
 	 *
 	 * @return string[][]
 	 */
-	protected function getExtraGroups(): array {
-		$extra = [];
+	protected function getExtraGroups (): array {
+		$extra = [ ];
 		foreach ( $this->botList as $name => $groups ) {
 			$groups = array_diff_key( $groups, array_fill_keys( PageBotList::NON_GROUP_KEYS, 1 ) );
 			if ( !isset( $this->actualList[ $name ] ) ) {
@@ -189,7 +189,7 @@ 
 	 * @param string[] $names
 	 * @return Generator
 	 */
-	private function getRenameEntries( array $names ): Generator {
+	private function getRenameEntries ( array $names ): Generator {
 		$titles = array_map( static function ( string $x ): string {
 			return "Utente:$x";
 		}, $names );
@@ -213,14 +213,14 @@ 
 	 * @param string[] $names
 	 * @return string[] [ old_name => new_name ]
 	 */
-	protected function getRenamedUsers( array $names ): array {
+	protected function getRenamedUsers ( array $names ): array {
 		if ( !$names ) {
-			return [];
+			return [ ];
 		}
 		$this->getLogger()->info( 'Checking rename for ' . implode( ', ', $names ) );
 
 		$data = $this->getRenameEntries( $names );
-		$ret = [];
+		$ret = [ ];
 		foreach ( $data as $entry ) {
 			// 1 month is arbitrary
 			if ( strtotime( $entry->timestamp ) > strtotime( '-1 month' ) ) {
@@ -239,18 +239,18 @@ 
 	 * @phan-param array<string,array<string,string|string[]>> $newContent
 	 * @param string[][] $removed
 	 */
-	private function handleRenames( array &$newContent, array $removed ): void {
+	private function handleRenames ( array &$newContent, array $removed ): void {
 		$renameMap = $this->getRenamedUsers( array_keys( $removed ) );
 		foreach ( $removed as $oldName => $info ) {
 			if (
 				array_key_exists( $oldName, $renameMap ) &&
-				array_key_exists( $renameMap[$oldName], $newContent )
+				array_key_exists( $renameMap[ $oldName ], $newContent )
 			) {
 				// This user was renamed! Add this name as alias, if they're still listed
 				$newName = $renameMap[ $oldName ];
 				$this->getLogger()->info( "Found rename $oldName -> $newName" );
-				$aliases = array_unique( array_merge( $newContent[ $newName ]['aliases'], [ $oldName ] ) );
-				$newContent[ $newName ]['aliases'] = $aliases;
+				$aliases = array_unique( array_merge( $newContent[ $newName ][ 'aliases' ], [ $oldName ] ) );
+				$newContent[ $newName ][ 'aliases' ] = $aliases;
 				// Transfer overrides to the new name.
 				$overrides = array_diff_key( $info, [ 'override' => 1, 'override-perm' => 1 ] );
 				$newContent[ $newName ] = array_merge( $newContent[ $newName ], $overrides );
@@ -265,12 +265,12 @@ 
 	 * @param string[][] $extra
 	 * @return string[][] Removed users
 	 */
-	private function handleExtraAndMissing(
+	private function handleExtraAndMissing (
 		array &$newContent,
 		array $missing,
 		array $extra
 	): array {
-		$removed = [];
+		$removed = [ ];
 		foreach ( $newContent as $user => $groups ) {
 			if ( isset( $missing[ $user ] ) ) {
 				$newContent[ $user ] = array_merge( $groups, $missing[ $user ] );
@@ -280,7 +280,7 @@ 
 				if ( array_diff_key( $newGroups, array_fill_keys( PageBotList::NON_GROUP_KEYS, 1 ) ) ) {
 					$newContent[ $user ] = $newGroups;
 				} else {
-					$removed[$user] = $newContent[$user];
+					$removed[ $user ] = $newContent[ $user ];
 					unset( $newContent[ $user ] );
 				}
 			}
@@ -297,7 +297,7 @@ 
 	 * @param string[][] $extra
 	 * @return array[]
 	 */
-	protected function getNewContent( array $missing, array $extra ): array {
+	protected function getNewContent ( array $missing, array $extra ): array {
 		$newContent = $this->botList;
 
 		$removed = $this->handleExtraAndMissing( $newContent, $missing, $extra );
@@ -316,12 +316,12 @@ 
 	 *
 	 * @param array[] &$newContent
 	 */
-	protected function removeOverrides( array &$newContent ): void {
-		$removed = [];
+	protected function removeOverrides ( array &$newContent ): void {
+		$removed = [ ];
 		foreach ( $newContent as $user => $groups ) {
 			if ( PageBotList::isOverrideExpired( $groups ) ) {
 				unset( $newContent[ $user ][ 'override' ] );
-				$removed[] = $user;
+				$removed[ ] = $user;
 			}
 		}
 

src/Task/StartNew.php

Spacing +3 added lines, -3 removed lines

@@ -1,4 +1,4 @@ 
-<?php declare( strict_types=1 );
+<?php declare(strict_types=1);
 
 namespace BotRiconferme\Task;
 
@@ -14,7 +14,7 @@ 
 	/**
 	 * @inheritDoc
 	 */
-	public function runInternal(): int {
+	public function runInternal (): int {
 		$orderedList = [
 			'create-pages',
 			'open-updates',
@@ -32,7 +32,7 @@ 
 	/**
 	 * @inheritDoc
 	 */
-	protected function getSubtasksMap(): array {
+	protected function getSubtasksMap (): array {
 		return [
 			'create-pages' => CreatePages::class,
 			'open-updates' => OpenUpdates::class,

src/TaskManager.php

Spacing +9 added lines, -9 removed lines

@@ -1,4 +1,4 @@ 
-<?php declare( strict_types=1 );
+<?php declare(strict_types=1);
 
 namespace BotRiconferme;
 
@@ -72,7 +72,7 @@ 
 	 * @param MessageProvider $mp
 	 * @param PageBotList $pbl
 	 */
-	public function __construct(
+	public function __construct (
 		LoggerInterface $logger,
 		WikiGroup $wikiGroup,
 		MessageProvider $mp,
@@ -97,7 +97,7 @@ 
 	 * @param string[] $tasks Only used in MODE_TASK and MODE_SUBTASK
 	 * @return TaskResult
 	 */
-	public function run( string $mode, array $tasks = [] ): TaskResult {
+	public function run ( string $mode, array $tasks = [ ] ): TaskResult {
 		if ( $mode === self::MODE_COMPLETE ) {
 			return $this->runTasks( self::FULL_RUN_ORDERED );
 		}
@@ -113,7 +113,7 @@ 
 	 * @param string[] $tasks
 	 * @return TaskResult
 	 */
-	private function runTasks( array $tasks ): TaskResult {
+	private function runTasks ( array $tasks ): TaskResult {
 		$res = new TaskResult( TaskResult::STATUS_GOOD );
 		do {
 			$res->merge( $this->runTask( current( $tasks ) ) );
@@ -128,7 +128,7 @@ 
 	 * @param string $name
 	 * @return TaskResult
 	 */
-	protected function runTask( string $name ): TaskResult {
+	protected function runTask ( string $name ): TaskResult {
 		if ( !isset( self::TASKS_MAP[ $name ] ) ) {
 			throw new InvalidArgumentException( "'$name' is not a valid task." );
 		}
@@ -142,7 +142,7 @@ 
 	 * @param string[] $subtasks
 	 * @return TaskResult
 	 */
-	private function runSubtasks( array $subtasks ): TaskResult {
+	private function runSubtasks ( array $subtasks ): TaskResult {
 		$res = new TaskResult( TaskResult::STATUS_GOOD );
 		do {
 			$res->merge( $this->runSubtask( current( $subtasks ) ) );
@@ -157,7 +157,7 @@ 
 	 * @param string $name
 	 * @return TaskResult
 	 */
-	protected function runSubtask( string $name ): TaskResult {
+	protected function runSubtask ( string $name ): TaskResult {
 		if ( !isset( self::SUBTASKS_MAP[ $name ] ) ) {
 			throw new InvalidArgumentException( "'$name' is not a valid subtask." );
 		}
@@ -172,7 +172,7 @@ 
 	 * @param string $name
 	 * @return Task
 	 */
-	private function getTaskInstance( string $name ): Task {
+	private function getTaskInstance ( string $name ): Task {
 		$class = self::TASKS_MAP[ $name ];
 		return new $class(
 			$this->logger,
@@ -189,7 +189,7 @@ 
 	 * @param string $class
 	 * @return Subtask
 	 */
-	private function getSubtaskInstance( string $class ): Subtask {
+	private function getSubtaskInstance ( string $class ): Subtask {
 		return new $class(
 			$this->logger,
 			$this->wikiGroup,

src/MessageProvider.php

Spacing +5 added lines, -5 removed lines

@@ -1,4 +1,4 @@ 
-<?php declare( strict_types = 1 );
+<?php declare(strict_types=1);
 
 namespace BotRiconferme;
 
@@ -21,7 +21,7 @@ 
 	 * @param Wiki $wiki
 	 * @param string $msgTitle
 	 */
-	public function __construct( Wiki $wiki, string $msgTitle ) {
+	public function __construct ( Wiki $wiki, string $msgTitle ) {
 		$this->wiki = $wiki;
 		$this->msgTitle = $msgTitle;
 	}
@@ -29,7 +29,7 @@ 
 	/**
 	 * @throws MessagesPageDoesNotExistException
 	 */
-	private function grabWikiMessages(): void {
+	private function grabWikiMessages (): void {
 		if ( self::$messages !== null ) {
 			return;
 		}
@@ -46,12 +46,12 @@ 
 	 * @return Message
 	 * @throws MessageNotFoundException
 	 */
-	public function getMessage( string $key ): Message {
+	public function getMessage ( string $key ): Message {
 		$this->grabWikiMessages();
 		if ( !isset( self::$messages[ $key ] ) ) {
 			throw new MessageNotFoundException( "Message '$key' does not exist." );
 		}
 		// @phan-suppress-next-line PhanTypeArraySuspiciousNullable
-		return new Message( self::$messages[$key] );
+		return new Message( self::$messages[ $key ] );
 	}
 }

src/TaskHelper/TaskDataProvider.php

Spacing +15 added lines, -15 removed lines

@@ -1,4 +1,4 @@ 
-<?php declare( strict_types=1 );
+<?php declare(strict_types=1);
 
 namespace BotRiconferme\TaskHelper;
 
@@ -15,7 +15,7 @@ 
 	/** @var User[]|null */
 	private $processUsers;
 	/** @var PageRiconferma[] */
-	private $createdPages = [];
+	private $createdPages = [ ];
 	/** @var PageRiconferma[]|null */
 	private $openPages;
 	/** @var PageRiconferma[]|null */
@@ -26,9 +26,9 @@ 
 	 *
 	 * @return User[]
 	 */
-	public function getUsersToProcess(): array {
+	public function getUsersToProcess (): array {
 		if ( $this->processUsers === null ) {
-			$this->processUsers = [];
+			$this->processUsers = [ ];
 			foreach ( $this->getBotList()->getAdminsList() as $name => $userInfo ) {
 				if ( $this->shouldAddUser( $userInfo ) ) {
 					$this->processUsers[ $name ] = new User( $userInfo, $this->getWiki() );
@@ -45,7 +45,7 @@ 
 	 * @param UserInfo $ui
 	 * @return bool
 	 */
-	private function shouldAddUser( UserInfo $ui ): bool {
+	private function shouldAddUser ( UserInfo $ui ): bool {
 		$timestamp = $this->getBotList()->getOverrideTimestamp( $ui );
 		$override = $timestamp !== null;
 
@@ -63,9 +63,9 @@ 
 	 *
 	 * @return PageRiconferma[]
 	 */
-	public function getOpenPages(): array {
+	public function getOpenPages (): array {
 		if ( $this->openPages === null ) {
-			$this->openPages = [];
+			$this->openPages = [ ];
 			$mainTitle = $this->getOpt( 'main-page-title' );
 			$params = [
 				'action' => 'query',
@@ -79,7 +79,7 @@ 
 			$pages = $this->getRequestFactory()->newFromParams( $params )->executeAsQuery();
 			foreach ( $pages->current()->templates as $page ) {
 				if ( preg_match( "!$titleReg/[^/]+/\d!", $page->title ) ) {
-					$this->openPages[] = new PageRiconferma( $page->title, $this->getWiki() );
+					$this->openPages[ ] = new PageRiconferma( $page->title, $this->getWiki() );
 				}
 			}
 		}
@@ -92,12 +92,12 @@ 
 	 *
 	 * @return PageRiconferma[]
 	 */
-	public function getPagesToClose(): array {
+	public function getPagesToClose (): array {
 		if ( $this->pagesToClose === null ) {
-			$this->pagesToClose = [];
+			$this->pagesToClose = [ ];
 			foreach ( $this->getOpenPages() as $page ) {
 				if ( time() > $page->getEndTimestamp() ) {
-					$this->pagesToClose[] = $page;
+					$this->pagesToClose[ ] = $page;
 				}
 			}
 		}
@@ -109,21 +109,21 @@ 
 	 *
 	 * @param string $name
 	 */
-	public function removeUser( string $name ): void {
+	public function removeUser ( string $name ): void {
 		unset( $this->processUsers[ $name ] );
 	}
 
 	/**
 	 * @return PageRiconferma[]
 	 */
-	public function getCreatedPages(): array {
+	public function getCreatedPages (): array {
 		return $this->createdPages;
 	}
 
 	/**
 	 * @param PageRiconferma $page
 	 */
-	public function addCreatedPage( PageRiconferma $page ): void {
-		$this->createdPages[] = $page;
+	public function addCreatedPage ( PageRiconferma $page ): void {
+		$this->createdPages[ ] = $page;
 	}
 }

src/TaskHelper/TaskResult.php

Spacing +9 added lines, -9 removed lines

@@ -1,4 +1,4 @@ 
-<?php declare( strict_types=1 );
+<?php declare(strict_types=1);
 
 namespace BotRiconferme\TaskHelper;
 
@@ -21,7 +21,7 @@ 
 	 * @param int $status One of the Task::STATUS_* constants
 	 * @param string[] $errors
 	 */
-	public function __construct( int $status, array $errors = [] ) {
+	public function __construct ( int $status, array $errors = [ ] ) {
 		$this->status = $status;
 		$this->errors = $errors;
 	}
@@ -29,7 +29,7 @@ 
 	/**
 	 * @return int
 	 */
-	public function getStatus(): int {
+	public function getStatus (): int {
 		return $this->status;
 	}
 
@@ -37,14 +37,14 @@ 
 	 * @return string[]
 	 * @suppress PhanUnreferencedPublicMethod
 	 */
-	public function getErrors(): array {
+	public function getErrors (): array {
 		return $this->errors;
 	}
 
 	/**
 	 * @param TaskResult $that
 	 */
-	public function merge( TaskResult $that ): void {
+	public function merge ( TaskResult $that ): void {
 		$this->status |= $that->status;
 		$this->errors = array_merge( $this->errors, $that->errors );
 	}
@@ -52,15 +52,15 @@ 
 	/**
 	 * @return string
 	 */
-	public function __toString(): string {
+	public function __toString (): string {
 		if ( $this->isOK() ) {
 			$stat = 'OK';
 			$errs = "\tNo errors.";
 		} else {
 			$stat = 'ERROR';
-			$formattedErrs = [];
+			$formattedErrs = [ ];
 			foreach ( $this->errors as $err ) {
-				$formattedErrs[] = "\t - $err";
+				$formattedErrs[ ] = "\t - $err";
 			}
 			$errs = implode( "\n", $formattedErrs );
 		}
@@ -72,7 +72,7 @@ 
 	 *
 	 * @return bool
 	 */
-	public function isOK(): bool {
+	public function isOK (): bool {
 		return ( $this->status | self::STATUS_GOOD ) === self::STATUS_GOOD;
 	}
 }

src/Config.php

Spacing +7 added lines, -7 removed lines

@@ -1,4 +1,4 @@ 
-<?php declare( strict_types=1 );
+<?php declare(strict_types=1);
 
 namespace BotRiconferme;
 
@@ -11,12 +11,12 @@ 
 	/** @var self */
 	private static $instance;
 	/** @var string[] */
-	private $opts = [];
+	private $opts = [ ];
 
 	/**
 	 * Use self::init() and self::getInstance()
 	 */
-	private function __construct() {
+	private function __construct () {
 	}
 
 	/**
@@ -25,7 +25,7 @@ 
 	 * @param string[] $confValues
 	 * @throws ConfigException
 	 */
-	public static function init( array $confValues ): void {
+	public static function init ( array $confValues ): void {
 		if ( self::$instance ) {
 			throw new ConfigException( 'Config was already initialized' );
 		}
@@ -44,7 +44,7 @@ 
 	 * @param string $key
 	 * @param mixed $value
 	 */
-	protected function set( string $key, $value ): void {
+	protected function set ( string $key, $value ): void {
 		$this->opts[ $key ] = $value;
 	}
 
@@ -54,7 +54,7 @@ 
 	 * @return self
 	 * @throws ConfigException
 	 */
-	public static function getInstance(): self {
+	public static function getInstance (): self {
 		if ( !self::$instance ) {
 			throw new ConfigException( 'Config not yet initialized' );
 		}
@@ -68,7 +68,7 @@ 
 	 * @return mixed
 	 * @throws ConfigException
 	 */
-	public function get( string $opt ) {
+	public function get ( string $opt ) {
 		if ( !isset( $this->opts[ $opt ] ) ) {
 			throw new ConfigException( "Config option '$opt' not set." );
 		}

src/Logger/IFlushingAwareLogger.php

Spacing +2 added lines, -2 removed lines

@@ -1,4 +1,4 @@ 
-<?php declare( strict_types=1 );
+<?php declare(strict_types=1);
 
 namespace BotRiconferme\Logger;
 
@@ -11,5 +11,5 @@ 
 	/**
 	 * Flush the buffer
 	 */
-	public function flush(): void;
+	public function flush (): void;
 }