Inspection of "sniffs" - Daimona/BotRiconferme - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 6697c9...98e5c5 )

by Daimona

created 2019-04-06 13:23 UTC

Status

Spacing +55 added lines, -56 removed lines patch added patch discarded remove patch

@@ -1,4 +1,4 @@  discard block
 block discarded – undo
-<?php declare( strict_types=1 );
+<?php declare(strict_types=1);
 
 namespace BotRiconferme\Task;
 
@@ -14,7 +14,7 @@  discard block
 block discarded – undo
 	/**
 	 * @inheritDoc
 	 */
-	public function run() : TaskResult {
+	public function run () : TaskResult {
 		$this->getLogger()->info( 'Starting task ClosePages' );
 
 		$pages = $this->getPagesList();
@@ -51,12 +51,12 @@  discard block
 block discarded – undo
 	 *
 	 * @return PageRiconferma[]
 	 */
-	protected function getPagesList() : array {
+	protected function getPagesList () : array {
 		$allPages = $this->getDataProvider()->getOpenPages();
-		$ret = [];
+		$ret = [ ];
 		foreach ( $allPages as $page ) {
 			if ( time() > $page->getEndTimestamp() ) {
-				$ret[] = $page;
+				$ret[ ] = $page;
 			}
 		}
 		return $ret;
@@ -68,11 +68,11 @@  discard block
 block discarded – undo
 	 * @param PageRiconferma[] $pages
 	 * @return PageRiconferma[]
 	 */
-	private function getFailures( array $pages ) : array {
-		$ret = [];
+	private function getFailures ( array $pages ) : array {
+		$ret = [ ];
 		foreach ( $pages as $page ) {
 			if ( $page->getOutcome() & PageRiconferma::OUTCOME_FAIL ) {
-				$ret[] = $page;
+				$ret[ ] = $page;
 			}
 		}
 		return $ret;
@@ -81,7 +81,7 @@  discard block
 block discarded – undo
 	/**
 	 * @param PageRiconferma $page
 	 */
-	protected function addVoteCloseText( PageRiconferma $page ) {
+	protected function addVoteCloseText ( PageRiconferma $page ) {
 		$content = $page->getContent();
 		$beforeReg = '!è necessario ottenere una maggioranza .+ votanti\.!';
 		$newContent = preg_replace( $beforeReg, '$0' . "\n" . $page->getOutcomeText(), $content );
@@ -99,14 +99,14 @@  discard block
 block discarded – undo
 	 * @param PageRiconferma[] $pages
 	 * @see UpdatesAround::addToMainPage()
 	 */
-	protected function removeFromMainPage( array $pages ) {
+	protected function removeFromMainPage ( array $pages ) {
 		$this->getLogger()->info(
 			'Removing from main: ' . implode( ', ', array_map( 'strval', $pages ) )
 		);
 
 		$mainPage = $this->getConfig()->get( 'ric-main-page' );
 		$content = $this->getController()->getPageContent( $mainPage );
-		$translations = [];
+		$translations = [ ];
 		foreach ( $pages as $page ) {
 			$translations[ '{{' . $page->getTitle() . '}}' ] = '';
 		}
@@ -124,17 +124,17 @@  discard block
 block discarded – undo
 	 *
 	 * @param PageRiconferma[] $pages
 	 */
-	protected function addToArchive( array $pages ) {
+	protected function addToArchive ( array $pages ) {
 		$this->getLogger()->info(
 			'Adding to archive: ' . implode( ', ', array_map( 'strval', $pages ) )
 		);
 
-		$simple = $votes = [];
+		$simple = $votes = [ ];
 		foreach ( $pages as $page ) {
 			if ( $page->isVote() ) {
-				$votes[] = $page;
+				$votes[ ] = $page;
 			} else {
-				$simple[] = $page;
+				$simple[ ] = $page;
 			}
 		}
 
@@ -151,21 +151,21 @@  discard block
 block discarded – undo
 	 * @param string $archiveTitle
 	 * @param array $pages
 	 */
-	private function reallyAddToArchive( string $archiveTitle, array $pages ) {
+	private function reallyAddToArchive ( string $archiveTitle, array $pages ) {
 		$curTitle = "$archiveTitle/" . date( 'Y' );
 
 		$append = '';
-		$archivedList = [];
+		$archivedList = [ ];
 		foreach ( $pages as $page ) {
 			$append .= '{{' . $page->getTitle() . "}}\n";
-			$archivedList[] = $page->getUserNum();
+			$archivedList[ ] = $page->getUserNum();
 		}
 
 		if ( count( $archivedList ) > 1 ) {
 			$last = array_pop( $archivedList );
 			$userNums = implode( ', ', $archivedList ) . " e $last";
 		} else {
-			$userNums = $archivedList[0];
+			$userNums = $archivedList[ 0 ];
 		}
 
 		$summary = strtr(
@@ -186,14 +186,13 @@  discard block
 block discarded – undo
 	 * @param PageRiconferma $page
 	 * @see CreatePages::updateBasePage()
 	 */
-	protected function updateBasePage( PageRiconferma $page ) {
+	protected function updateBasePage ( PageRiconferma $page ) {
 		$this->getLogger()->info( "Updating base page for $page" );
 
 		$current = $this->getController()->getPageContent( $page->getBaseTitle() );
 
 		$outcomeText = $page->getOutcome() & PageRiconferma::OUTCOME_FAIL ?
-			'non riconfermato' :
-			'riconfermato';
+			'non riconfermato' : 'riconfermato';
 		$text = $page->isVote() ? "votazione: $outcomeText" : 'riconferma tacita';
 
 		$newContent = str_replace( 'riconferma in corso', $text, $current );
@@ -210,13 +209,13 @@  discard block
 block discarded – undo
 	 * @param PageRiconferma[] $pages
 	 * @see UpdatesAround::addVote()
 	 */
-	protected function updateVote( array $pages ) {
+	protected function updateVote ( array $pages ) {
 		$votePage = $this->getConfig()->get( 'ric-vote-page' );
 		$content = $this->getController()->getPageContent( $votePage );
 
-		$titles = [];
+		$titles = [ ];
 		foreach ( $pages as $page ) {
-			$titles[] = preg_quote( $page->getTitle() );
+			$titles[ ] = preg_quote( $page->getTitle() );
 		}
 
 		$titleReg = implode( '|', array_map( 'preg_quote', $titles ) );
@@ -239,7 +238,7 @@  discard block
 block discarded – undo
 		$summary = preg_replace_callback(
 			'!\{\{$plur|(\d+)|([^|]+)|([^|]+)}}!',
 			function ( $matches ) {
-				return intval( $matches[1] ) > 1 ? trim( $matches[3] ) : trim( $matches[2] );
+				return intval( $matches[ 1 ] ) > 1 ? trim( $matches[ 3 ] ) : trim( $matches[ 2 ] );
 			},
 			$summary
 		);
@@ -257,7 +256,7 @@  discard block
 block discarded – undo
 	 * @param array $pages
 	 * @see UpdatesAround::addNews()
 	 */
-	protected function updateNews( array $pages ) {
+	protected function updateNews ( array $pages ) {
 		$simpleAmount = $voteAmount = 0;
 		foreach ( $pages as $page ) {
 			if ( $page->isVote() ) {
@@ -277,12 +276,12 @@  discard block
 block discarded – undo
 		$simpleReg = '!(\| *riconferme[ _]tacite[ _]amministratori *= *)(\d+)!';
 		$voteReg = '!(\| *riconferme[ _]voto[ _]amministratori *= *)(\d+)!';
 
-		$simpleMatches = $voteMatches = [];
+		$simpleMatches = $voteMatches = [ ];
 		preg_match( $simpleReg, $content, $simpleMatches );
 		preg_match( $voteReg, $content, $voteMatches );
 
-		$newSimp = (int)$simpleMatches[2] - $simpleAmount ?: '';
-		$newVote = (int)$voteMatches[2] - $voteAmount ?: '';
+		$newSimp = (int)$simpleMatches[ 2 ] - $simpleAmount ?: '';
+		$newVote = (int)$voteMatches[ 2 ] - $voteAmount ?: '';
 		$newContent = preg_replace( $simpleReg, '${1}' . $newSimp, $content );
 		$newContent = preg_replace( $voteReg, '${1}' . $newVote, $newContent );
 
@@ -293,7 +292,7 @@  discard block
 block discarded – undo
 		$summary = preg_replace_callback(
 			'!\{\{$plur|(\d+)|([^|]+)|([^|]+)}}!',
 			function ( $matches ) {
-				return intval( $matches[1] ) > 1 ? trim( $matches[3] ) : trim( $matches[2] );
+				return intval( $matches[ 1 ] ) > 1 ? trim( $matches[ 3 ] ) : trim( $matches[ 2 ] );
 			},
 			$summary
 		);
@@ -312,22 +311,22 @@  discard block
 block discarded – undo
 	 *
 	 * @param PageRiconferma[] $pages
 	 */
-	protected function updateAdminList( array $pages ) {
+	protected function updateAdminList ( array $pages ) {
 		$listTitle = $this->getConfig()->get( 'admins-list' );
 		$newContent = $this->getController()->getPageContent( $listTitle );
 		$newDate = date( 'Ymd', strtotime( '+1 year' ) );
 
-		$riconfNames = $removeNames = [];
+		$riconfNames = $removeNames = [ ];
 		foreach ( $pages as $page ) {
 			$user = $page->getUser();
 			$reg = "!(\{\{Amministratore\/riga\|$user.+\| *)\d+( *\|(?: *pausa)? *\}\}\n)!";
 			if ( $page->getOutcome() & PageRiconferma::OUTCOME_FAIL ) {
 				// Remove the line
 				$newContent = preg_replace( $reg, '', $newContent );
-				$removeNames[] = $user;
+				$removeNames[ ] = $user;
 			} else {
 				$newContent = preg_replace( $reg, '$1' . $newDate . '$2', $newContent );
-				$riconfNames[] = $user;
+				$riconfNames[ ] = $user;
 			}
 		}
 
@@ -335,7 +334,7 @@  discard block
 block discarded – undo
 			$lastUser = array_pop( $riconfNames );
 			$riconfList = implode( ', ', $riconfNames ) . " e $lastUser";
 		} elseif ( $riconfNames ) {
-			$riconfList = $riconfNames[0];
+			$riconfList = $riconfNames[ 0 ];
 		} else {
 			$riconfList = 'nessuno';
 		}
@@ -344,7 +343,7 @@  discard block
 block discarded – undo
 			$lastUser = array_pop( $removeNames );
 			$removeList = implode( ', ', $removeNames ) . " e $lastUser";
 		} elseif ( $removeNames ) {
-			$removeList = $removeNames[0];
+			$removeList = $removeNames[ 0 ];
 		} else {
 			$removeList = 'nessuno';
 		}
@@ -369,13 +368,13 @@  discard block
 block discarded – undo
 	/**
 	 * @param PageRiconferma[] $pages
 	 */
-	protected function updateCUList( array $pages ) {
+	protected function updateCUList ( array $pages ) {
 		$cuListTitle = $this->getConfig()->get( 'cu-list-title' );
 		$listTitle = $this->getConfig()->get( 'list-title' );
 		$admins = json_decode( $this->getController()->getPageContent( $listTitle ), true );
 		$newContent = $this->getController()->getPageContent( $cuListTitle );
 
-		$riconfNames = $removeNames = [];
+		$riconfNames = $removeNames = [ ];
 		foreach ( $pages as $page ) {
 			$user = $page->getUser();
 			if ( array_key_exists( 'checkuser', $admins[ $user ] ) ) {
@@ -383,10 +382,10 @@  discard block
 block discarded – undo
 				if ( $page->getOutcome() & PageRiconferma::OUTCOME_FAIL ) {
 					// Remove the line
 					$newContent = preg_replace( $reg, '', $newContent );
-					$removeNames[] = $user;
+					$removeNames[ ] = $user;
 				} else {
 					$newContent = preg_replace( $reg, '$1{{subst:#time:j F Y}}$2', $newContent );
-					$riconfNames[] = $user;
+					$riconfNames[ ] = $user;
 				}
 			}
 		}
@@ -399,7 +398,7 @@  discard block
 block discarded – undo
 			$lastUser = array_pop( $riconfNames );
 			$riconfList = implode( ', ', $riconfNames ) . " e $lastUser";
 		} elseif ( $riconfNames ) {
-			$riconfList = $riconfNames[0];
+			$riconfList = $riconfNames[ 0 ];
 		} else {
 			$riconfList = 'nessuno';
 		}
@@ -408,7 +407,7 @@  discard block
 block discarded – undo
 			$lastUser = array_pop( $removeNames );
 			$removeList = implode( ', ', $removeNames ) . " e $lastUser";
 		} elseif ( $removeNames ) {
-			$removeList = $removeNames[0];
+			$removeList = $removeNames[ 0 ];
 		} else {
 			$removeList = 'nessuno';
 		}
@@ -432,17 +431,17 @@  discard block
 block discarded – undo
 	/**
 	 * @param PageRiconferma[] $pages
 	 */
-	protected function updateBurList( array $pages ) {
+	protected function updateBurList ( array $pages ) {
 		$listTitle = $this->getConfig()->get( 'list-title' );
 		$admins = json_decode( $this->getController()->getPageContent( $listTitle ), true );
 
-		$remove = [];
+		$remove = [ ];
 		foreach ( $pages as $page ) {
 			$user = $page->getUser();
 			if ( array_key_exists( 'bureaucrat', $admins[ $user ] ) &&
 				$page->getOutcome() & PageRiconferma::OUTCOME_FAIL
 			) {
-				$remove[] = $user;
+				$remove[ ] = $user;
 			}
 		}
 
@@ -460,7 +459,7 @@  discard block
 block discarded – undo
 			$lastUser = array_pop( $remove );
 			$removeList = implode( ', ', $remove ) . " e $lastUser";
 		} else {
-			$removeList = $remove[0];
+			$removeList = $remove[ 0 ];
 		}
 
 		$summary = strtr(
@@ -483,7 +482,7 @@  discard block
 block discarded – undo
 	 *
 	 * @param PageRiconferma[] $pages
 	 */
-	protected function requestRemoval( array $pages ) {
+	protected function requestRemoval ( array $pages ) {
 		$listTitle = $this->getConfig()->get( 'list-title' );
 		$admins = json_decode( $this->getController()->getPageContent( $listTitle ), true );
 
@@ -528,14 +527,14 @@  discard block
 block discarded – undo
 	 *
 	 * @param PageRiconferma[] $pages
 	 */
-	protected function updateAnnunci( array $pages ) {
+	protected function updateAnnunci ( array $pages ) {
 		$title = $this->getConfig()->get( 'annunci-title' );
 
-		$names = [];
+		$names = [ ];
 		$text = '';
 		foreach ( $pages as $page ) {
 			$user = $page->getUser();
-			$names[] = $user;
+			$names[ ] = $user;
 			$text .= "{{Breve|admin|{{subst:#time:j}}|[[Utente:$user|]] " .
 				"non è stato riconfermato [[WP:A|amministratore]].}}\n";
 		}
@@ -557,7 +556,7 @@  discard block
 block discarded – undo
 			$lastUser = array_pop( $names );
 			$namesList = implode( ', ', $names ) . " e $lastUser";
 		} else {
-			$namesList = $names[0];
+			$namesList = $names[ 0 ];
 		}
 
 		$summary = strtr(
@@ -578,15 +577,15 @@  discard block
 block discarded – undo
 	 *
 	 * @param PageRiconferma[] $pages
 	 */
-	protected function updateUltimeNotizie( array $pages ) {
+	protected function updateUltimeNotizie ( array $pages ) {
 		$title = $this->getConfig()->get( 'ultimenotizie-title' );
 
-		$names = [];
+		$names = [ ];
 		$text = '';
 		foreach ( $pages as $page ) {
 			$user = $page->getUser();
 			$title = $page->getTitle();
-			$names[] = $user;
+			$names[ ] = $user;
 			$text .= "'''{{subst:#time:j F}}''': [[Utente:$user|]] non è stato [[$title|riconfermato]] " .
 				'[[WP:A|amministratore]]; ora gli admin sono {{subst:#expr: {{NUMBEROFADMINS}} - 1}}.';
 		}
@@ -605,7 +604,7 @@  discard block
 block discarded – undo
 			$lastUser = array_pop( $names );
 			$namesList = implode( ', ', $names ) . " e $lastUser";
 		} else {
-			$namesList = $names[0];
+			$namesList = $names[ 0 ];
 		}
 
 		$summary = strtr(

Please login to merge, or discard this patch.

		@@ -1,4 +1,4 @@ discard block
		block discarded – undo
1		-<?php declare( strict_types=1 );
	1	+<?php declare(strict_types=1);
2	2
3	3	namespace BotRiconferme\Task;
4	4
		@@ -14,7 +14,7 @@ discard block
		block discarded – undo
14	14	/**
15	15	* @inheritDoc
16	16	*/
17		- public function run() : TaskResult {
	17	+ public function run () : TaskResult {
18	18	$this->getLogger()->info( 'Starting task ClosePages' );
19	19
20	20	$pages = $this->getPagesList();
		@@ -51,12 +51,12 @@ discard block
		block discarded – undo
51	51	*
52	52	* @return PageRiconferma[]
53	53	*/
54		- protected function getPagesList() : array {
	54	+ protected function getPagesList () : array {
55	55	$allPages = $this->getDataProvider()->getOpenPages();
56		- $ret = [];
	56	+ $ret = [ ];
57	57	foreach ( $allPages as $page ) {
58	58	if ( time() > $page->getEndTimestamp() ) {
59		- $ret[] = $page;
	59	+ $ret[ ] = $page;
60	60	}
61	61	}
62	62	return $ret;
		@@ -68,11 +68,11 @@ discard block
		block discarded – undo
68	68	* @param PageRiconferma[] $pages
69	69	* @return PageRiconferma[]
70	70	*/
71		- private function getFailures( array $pages ) : array {
72		- $ret = [];
	71	+ private function getFailures ( array $pages ) : array {
	72	+ $ret = [ ];
73	73	foreach ( $pages as $page ) {
74	74	if ( $page->getOutcome() & PageRiconferma::OUTCOME_FAIL ) {
75		- $ret[] = $page;
	75	+ $ret[ ] = $page;
76	76	}
77	77	}
78	78	return $ret;
		@@ -81,7 +81,7 @@ discard block
		block discarded – undo
81	81	/**
82	82	* @param PageRiconferma $page
83	83	*/
84		- protected function addVoteCloseText( PageRiconferma $page ) {
	84	+ protected function addVoteCloseText ( PageRiconferma $page ) {
85	85	$content = $page->getContent();
86	86	$beforeReg = '!è necessario ottenere una maggioranza .+ votanti\.!';
87	87	$newContent = preg_replace( $beforeReg, '$0' . "\n" . $page->getOutcomeText(), $content );
		@@ -99,14 +99,14 @@ discard block
		block discarded – undo
99	99	* @param PageRiconferma[] $pages
100	100	* @see UpdatesAround::addToMainPage()
101	101	*/
102		- protected function removeFromMainPage( array $pages ) {
	102	+ protected function removeFromMainPage ( array $pages ) {
103	103	$this->getLogger()->info(
104	104	'Removing from main: ' . implode( ', ', array_map( 'strval', $pages ) )
105	105	);
106	106
107	107	$mainPage = $this->getConfig()->get( 'ric-main-page' );
108	108	$content = $this->getController()->getPageContent( $mainPage );
109		- $translations = [];
	109	+ $translations = [ ];
110	110	foreach ( $pages as $page ) {
111	111	$translations[ '{{' . $page->getTitle() . '}}' ] = '';
112	112	}
		@@ -124,17 +124,17 @@ discard block
		block discarded – undo
124	124	*
125	125	* @param PageRiconferma[] $pages
126	126	*/
127		- protected function addToArchive( array $pages ) {
	127	+ protected function addToArchive ( array $pages ) {
128	128	$this->getLogger()->info(
129	129	'Adding to archive: ' . implode( ', ', array_map( 'strval', $pages ) )
130	130	);
131	131
132		- $simple = $votes = [];
	132	+ $simple = $votes = [ ];
133	133	foreach ( $pages as $page ) {
134	134	if ( $page->isVote() ) {
135		- $votes[] = $page;
	135	+ $votes[ ] = $page;
136	136	} else {
137		- $simple[] = $page;
	137	+ $simple[ ] = $page;
138	138	}
139	139	}
140	140
		@@ -151,21 +151,21 @@ discard block
		block discarded – undo
151	151	* @param string $archiveTitle
152	152	* @param array $pages
153	153	*/
154		- private function reallyAddToArchive( string $archiveTitle, array $pages ) {
	154	+ private function reallyAddToArchive ( string $archiveTitle, array $pages ) {
155	155	$curTitle = "$archiveTitle/" . date( 'Y' );
156	156
157	157	$append = '';
158		- $archivedList = [];
	158	+ $archivedList = [ ];
159	159	foreach ( $pages as $page ) {
160	160	$append .= '{{' . $page->getTitle() . "}}\n";
161		- $archivedList[] = $page->getUserNum();
	161	+ $archivedList[ ] = $page->getUserNum();
162	162	}
163	163
164	164	if ( count( $archivedList ) > 1 ) {
165	165	$last = array_pop( $archivedList );
166	166	$userNums = implode( ', ', $archivedList ) . " e $last";
167	167	} else {
168		- $userNums = $archivedList[0];
	168	+ $userNums = $archivedList[ 0 ];
169	169	}
170	170
171	171	$summary = strtr(
		@@ -186,14 +186,13 @@ discard block
		block discarded – undo
186	186	* @param PageRiconferma $page
187	187	* @see CreatePages::updateBasePage()
188	188	*/
189		- protected function updateBasePage( PageRiconferma $page ) {
	189	+ protected function updateBasePage ( PageRiconferma $page ) {
190	190	$this->getLogger()->info( "Updating base page for $page" );
191	191
192	192	$current = $this->getController()->getPageContent( $page->getBaseTitle() );
193	193
194	194	$outcomeText = $page->getOutcome() & PageRiconferma::OUTCOME_FAIL ?
195		- 'non riconfermato' :
196		- 'riconfermato';
	195	+ 'non riconfermato' : 'riconfermato';
197	196	$text = $page->isVote() ? "votazione: $outcomeText" : 'riconferma tacita';
198	197
199	198	$newContent = str_replace( 'riconferma in corso', $text, $current );
		@@ -210,13 +209,13 @@ discard block
		block discarded – undo
210	209	* @param PageRiconferma[] $pages
211	210	* @see UpdatesAround::addVote()
212	211	*/
213		- protected function updateVote( array $pages ) {
	212	+ protected function updateVote ( array $pages ) {
214	213	$votePage = $this->getConfig()->get( 'ric-vote-page' );
215	214	$content = $this->getController()->getPageContent( $votePage );
216	215
217		- $titles = [];
	216	+ $titles = [ ];
218	217	foreach ( $pages as $page ) {
219		- $titles[] = preg_quote( $page->getTitle() );
	218	+ $titles[ ] = preg_quote( $page->getTitle() );
220	219	}
221	220
222	221	$titleReg = implode( '\|', array_map( 'preg_quote', $titles ) );
		@@ -239,7 +238,7 @@ discard block
		block discarded – undo
239	238	$summary = preg_replace_callback(
240	239	'!\{\{$plur\|(\d+)\|([^\|]+)\|([^\|]+)}}!',
241	240	function ( $matches ) {
242		- return intval( $matches[1] ) > 1 ? trim( $matches[3] ) : trim( $matches[2] );
	241	+ return intval( $matches[ 1 ] ) > 1 ? trim( $matches[ 3 ] ) : trim( $matches[ 2 ] );
243	242	},
244	243	$summary
245	244	);
		@@ -257,7 +256,7 @@ discard block
		block discarded – undo
257	256	* @param array $pages
258	257	* @see UpdatesAround::addNews()
259	258	*/
260		- protected function updateNews( array $pages ) {
	259	+ protected function updateNews ( array $pages ) {
261	260	$simpleAmount = $voteAmount = 0;
262	261	foreach ( $pages as $page ) {
263	262	if ( $page->isVote() ) {
		@@ -277,12 +276,12 @@ discard block
		block discarded – undo
277	276	$simpleReg = '!(\\| riconferme[ _]tacite[ _]amministratori = *)(\d+)!';
278	277	$voteReg = '!(\\| riconferme[ _]voto[ _]amministratori = *)(\d+)!';
279	278
280		- $simpleMatches = $voteMatches = [];
	279	+ $simpleMatches = $voteMatches = [ ];
281	280	preg_match( $simpleReg, $content, $simpleMatches );
282	281	preg_match( $voteReg, $content, $voteMatches );
283	282
284		- $newSimp = (int)$simpleMatches[2] - $simpleAmount ?: '';
285		- $newVote = (int)$voteMatches[2] - $voteAmount ?: '';
	283	+ $newSimp = (int)$simpleMatches[ 2 ] - $simpleAmount ?: '';
	284	+ $newVote = (int)$voteMatches[ 2 ] - $voteAmount ?: '';
286	285	$newContent = preg_replace( $simpleReg, '${1}' . $newSimp, $content );
287	286	$newContent = preg_replace( $voteReg, '${1}' . $newVote, $newContent );
288	287
		@@ -293,7 +292,7 @@ discard block
		block discarded – undo
293	292	$summary = preg_replace_callback(
294	293	'!\{\{$plur\|(\d+)\|([^\|]+)\|([^\|]+)}}!',
295	294	function ( $matches ) {
296		- return intval( $matches[1] ) > 1 ? trim( $matches[3] ) : trim( $matches[2] );
	295	+ return intval( $matches[ 1 ] ) > 1 ? trim( $matches[ 3 ] ) : trim( $matches[ 2 ] );
297	296	},
298	297	$summary
299	298	);
		@@ -312,22 +311,22 @@ discard block
		block discarded – undo
312	311	*
313	312	* @param PageRiconferma[] $pages
314	313	*/
315		- protected function updateAdminList( array $pages ) {
	314	+ protected function updateAdminList ( array $pages ) {
316	315	$listTitle = $this->getConfig()->get( 'admins-list' );
317	316	$newContent = $this->getController()->getPageContent( $listTitle );
318	317	$newDate = date( 'Ymd', strtotime( '+1 year' ) );
319	318
320		- $riconfNames = $removeNames = [];
	319	+ $riconfNames = $removeNames = [ ];
321	320	foreach ( $pages as $page ) {
322	321	$user = $page->getUser();
323	322	$reg = "!(\{\{Amministratore\/riga\\|$user.+\\| )\d+( \\|(?: pausa)? \}\}\n)!";
324	323	if ( $page->getOutcome() & PageRiconferma::OUTCOME_FAIL ) {
325	324	// Remove the line
326	325	$newContent = preg_replace( $reg, '', $newContent );
327		- $removeNames[] = $user;
	326	+ $removeNames[ ] = $user;
328	327	} else {
329	328	$newContent = preg_replace( $reg, '$1' . $newDate . '$2', $newContent );
330		- $riconfNames[] = $user;
	329	+ $riconfNames[ ] = $user;
331	330	}
332	331	}
333	332
		@@ -335,7 +334,7 @@ discard block
		block discarded – undo
335	334	$lastUser = array_pop( $riconfNames );
336	335	$riconfList = implode( ', ', $riconfNames ) . " e $lastUser";
337	336	} elseif ( $riconfNames ) {
338		- $riconfList = $riconfNames[0];
	337	+ $riconfList = $riconfNames[ 0 ];
339	338	} else {
340	339	$riconfList = 'nessuno';
341	340	}
		@@ -344,7 +343,7 @@ discard block
		block discarded – undo
344	343	$lastUser = array_pop( $removeNames );
345	344	$removeList = implode( ', ', $removeNames ) . " e $lastUser";
346	345	} elseif ( $removeNames ) {
347		- $removeList = $removeNames[0];
	346	+ $removeList = $removeNames[ 0 ];
348	347	} else {
349	348	$removeList = 'nessuno';
350	349	}
		@@ -369,13 +368,13 @@ discard block
		block discarded – undo
369	368	/**
370	369	* @param PageRiconferma[] $pages
371	370	*/
372		- protected function updateCUList( array $pages ) {
	371	+ protected function updateCUList ( array $pages ) {
373	372	$cuListTitle = $this->getConfig()->get( 'cu-list-title' );
374	373	$listTitle = $this->getConfig()->get( 'list-title' );
375	374	$admins = json_decode( $this->getController()->getPageContent( $listTitle ), true );
376	375	$newContent = $this->getController()->getPageContent( $cuListTitle );
377	376
378		- $riconfNames = $removeNames = [];
	377	+ $riconfNames = $removeNames = [ ];
379	378	foreach ( $pages as $page ) {
380	379	$user = $page->getUser();
381	380	if ( array_key_exists( 'checkuser', $admins[ $user ] ) ) {
		@@ -383,10 +382,10 @@ discard block
		block discarded – undo
383	382	if ( $page->getOutcome() & PageRiconferma::OUTCOME_FAIL ) {
384	383	// Remove the line
385	384	$newContent = preg_replace( $reg, '', $newContent );
386		- $removeNames[] = $user;
	385	+ $removeNames[ ] = $user;
387	386	} else {
388	387	$newContent = preg_replace( $reg, '$1{{subst:#time:j F Y}}$2', $newContent );
389		- $riconfNames[] = $user;
	388	+ $riconfNames[ ] = $user;
390	389	}
391	390	}
392	391	}
		@@ -399,7 +398,7 @@ discard block
		block discarded – undo
399	398	$lastUser = array_pop( $riconfNames );
400	399	$riconfList = implode( ', ', $riconfNames ) . " e $lastUser";
401	400	} elseif ( $riconfNames ) {
402		- $riconfList = $riconfNames[0];
	401	+ $riconfList = $riconfNames[ 0 ];
403	402	} else {
404	403	$riconfList = 'nessuno';
405	404	}
		@@ -408,7 +407,7 @@ discard block
		block discarded – undo
408	407	$lastUser = array_pop( $removeNames );
409	408	$removeList = implode( ', ', $removeNames ) . " e $lastUser";
410	409	} elseif ( $removeNames ) {
411		- $removeList = $removeNames[0];
	410	+ $removeList = $removeNames[ 0 ];
412	411	} else {
413	412	$removeList = 'nessuno';
414	413	}
		@@ -432,17 +431,17 @@ discard block
		block discarded – undo
432	431	/**
433	432	* @param PageRiconferma[] $pages
434	433	*/
435		- protected function updateBurList( array $pages ) {
	434	+ protected function updateBurList ( array $pages ) {
436	435	$listTitle = $this->getConfig()->get( 'list-title' );
437	436	$admins = json_decode( $this->getController()->getPageContent( $listTitle ), true );
438	437
439		- $remove = [];
	438	+ $remove = [ ];
440	439	foreach ( $pages as $page ) {
441	440	$user = $page->getUser();
442	441	if ( array_key_exists( 'bureaucrat', $admins[ $user ] ) &&
443	442	$page->getOutcome() & PageRiconferma::OUTCOME_FAIL
444	443	) {
445		- $remove[] = $user;
	444	+ $remove[ ] = $user;
446	445	}
447	446	}
448	447
		@@ -460,7 +459,7 @@ discard block
		block discarded – undo
460	459	$lastUser = array_pop( $remove );
461	460	$removeList = implode( ', ', $remove ) . " e $lastUser";
462	461	} else {
463		- $removeList = $remove[0];
	462	+ $removeList = $remove[ 0 ];
464	463	}
465	464
466	465	$summary = strtr(
		@@ -483,7 +482,7 @@ discard block
		block discarded – undo
483	482	*
484	483	* @param PageRiconferma[] $pages
485	484	*/
486		- protected function requestRemoval( array $pages ) {
	485	+ protected function requestRemoval ( array $pages ) {
487	486	$listTitle = $this->getConfig()->get( 'list-title' );
488	487	$admins = json_decode( $this->getController()->getPageContent( $listTitle ), true );
489	488
		@@ -528,14 +527,14 @@ discard block
		block discarded – undo
528	527	*
529	528	* @param PageRiconferma[] $pages
530	529	*/
531		- protected function updateAnnunci( array $pages ) {
	530	+ protected function updateAnnunci ( array $pages ) {
532	531	$title = $this->getConfig()->get( 'annunci-title' );
533	532
534		- $names = [];
	533	+ $names = [ ];
535	534	$text = '';
536	535	foreach ( $pages as $page ) {
537	536	$user = $page->getUser();
538		- $names[] = $user;
	537	+ $names[ ] = $user;
539	538	$text .= "{{Breve\|admin\|{{subst:#time:j}}\|[[Utente:$user\|]] " .
540	539	"non è stato riconfermato [[WP:A\|amministratore]].}}\n";
541	540	}
		@@ -557,7 +556,7 @@ discard block
		block discarded – undo
557	556	$lastUser = array_pop( $names );
558	557	$namesList = implode( ', ', $names ) . " e $lastUser";
559	558	} else {
560		- $namesList = $names[0];
	559	+ $namesList = $names[ 0 ];
561	560	}
562	561
563	562	$summary = strtr(
		@@ -578,15 +577,15 @@ discard block
		block discarded – undo
578	577	*
579	578	* @param PageRiconferma[] $pages
580	579	*/
581		- protected function updateUltimeNotizie( array $pages ) {
	580	+ protected function updateUltimeNotizie ( array $pages ) {
582	581	$title = $this->getConfig()->get( 'ultimenotizie-title' );
583	582
584		- $names = [];
	583	+ $names = [ ];
585	584	$text = '';
586	585	foreach ( $pages as $page ) {
587	586	$user = $page->getUser();
588	587	$title = $page->getTitle();
589		- $names[] = $user;
	588	+ $names[ ] = $user;
590	589	$text .= "'''{{subst:#time:j F}}''': [[Utente:$user\|]] non è stato [[$title\|riconfermato]] " .
591	590	'[[WP:A\|amministratore]]; ora gli admin sono {{subst:#expr: {{NUMBEROFADMINS}} - 1}}.';
592	591	}
		@@ -605,7 +604,7 @@ discard block
		block discarded – undo
605	604	$lastUser = array_pop( $names );
606	605	$namesList = implode( ', ', $names ) . " e $lastUser";
607	606	} else {
608		- $namesList = $names[0];
	607	+ $namesList = $names[ 0 ];
609	608	}
610	609
611	610	$summary = strtr(

Daimona / BotRiconferme

Push — master ( 6697c9...98e5c5 )

Status

Category

Spacing +55 added lines, -56 removed lines patch added patch discarded remove patch