Daimona / BotRiconferme

includes/Task/CloseOld.php

Spacing +3 added lines, -3 removed lines

@@ -1,4 +1,4 @@ 
-<?php declare( strict_types=1 );
+<?php declare(strict_types=1);
 
 namespace BotRiconferme\Task;
 
@@ -15,7 +15,7 @@ 
 	/**
 	 * @inheritDoc
 	 */
-	public function run() : TaskResult {
+	public function run () : TaskResult {
 		$orderedList = [
 			'close-pages',
 			'archive-pages',
@@ -34,7 +34,7 @@ 
 	/**
 	 * @inheritDoc
 	 */
-	protected function getSubtasksMap(): array {
+	protected function getSubtasksMap (): array {
 		return [
 			'archive-pages' => ArchivePages::class,
 			'close-pages' => ClosePages::class,

includes/Task/StartVote.php

Spacing +17 added lines, -17 removed lines

@@ -1,4 +1,4 @@ 
-<?php declare( strict_types=1 );
+<?php declare(strict_types=1);
 
 namespace BotRiconferme\Task;
 
@@ -16,15 +16,15 @@ 
 	/**
 	 * @inheritDoc
 	 */
-	protected function getSubtasksMap(): array {
+	protected function getSubtasksMap (): array {
 		// Everything is done here.
-		return [];
+		return [ ];
 	}
 
 	/**
 	 * @inheritDoc
 	 */
-	public function run() : TaskResult {
+	public function run () : TaskResult {
 		$this->getLogger()->info( 'Starting task StartVote' );
 
 		$pages = $this->getDataProvider()->getOpenPages();
@@ -42,12 +42,12 @@ 
 	/**
 	 * @param PageRiconferma[] $pages
 	 */
-	protected function processPages( array $pages ) {
-		$actualPages = [];
+	protected function processPages ( array $pages ) {
+		$actualPages = [ ];
 		foreach ( $pages as $page ) {
 			if ( $page->hasOpposition() && !$page->isVote() ) {
 				$this->openVote( $page );
-				$actualPages[] = $page;
+				$actualPages[ ] = $page;
 			}
 		}
 
@@ -64,7 +64,7 @@ 
 	 *
 	 * @param PageRiconferma $page
 	 */
-	protected function openVote( PageRiconferma $page ) {
+	protected function openVote ( PageRiconferma $page ) {
 		$this->getLogger()->info( "Starting vote on $page" );
 
 		$content = $page->getContent();
@@ -103,13 +103,13 @@ 
 	 * @see SimpleUpdates::updateVote()
 	 * @see UpdatesAround::addVote()
 	 */
-	protected function updateVotePage( array $pages ) {
+	protected function updateVotePage ( array $pages ) {
 		$votePage = new Page( $this->getConfig()->get( 'ric-vote-page' ) );
 		$content = $votePage->getContent();
 
-		$titles = [];
+		$titles = [ ];
 		foreach ( $pages as $page ) {
-			$titles[] = preg_quote( $page->getTitle() );
+			$titles[ ] = preg_quote( $page->getTitle() );
 		}
 		$titleReg = implode( '|', array_map( 'preg_quote', $titles ) );
 		$search = "!^\*.+ La \[\[($titleReg)\|procedura]] termina.+\n!gm";
@@ -132,14 +132,14 @@ 
 			$newContent = preg_replace( $introReg, '$0' . "\n$newLines", $newContent, 1 );
 		} else {
 			// Start section
-			$matches = [];
+			$matches = [ ];
 			if ( preg_match( $introReg, $content, $matches ) === false ) {
 				throw new TaskException( 'Intro not found in vote page' );
 			}
 			$beforeReg = '!INSERIRE LA NOTIZIA PIÙ NUOVA IN CIMA.+!m';
 			// Replace semicolon with full stop
 			$newLines = substr( $newLines, 0, -2 ) . ".\n";
-			$newContent = preg_replace( $beforeReg, '$0' . "\n{$matches[0]}\n$newLines", $newContent, 1 );
+			$newContent = preg_replace( $beforeReg, '$0' . "\n{$matches[ 0 ]}\n$newLines", $newContent, 1 );
 		}
 
 		$summary = $this->msg( 'vote-start-vote-page-summary' )
@@ -161,7 +161,7 @@ 
 	 * @see UpdatesAround::addNews()
 	 * @see SimpleUpdates::updateNews()
 	 */
-	protected function updateNews( int $amount ) {
+	protected function updateNews ( int $amount ) {
 		$this->getLogger()->info( "Turning $amount pages into votes" );
 		$newsPage = new Page( $this->getConfig()->get( 'ric-news-page' ) );
 
@@ -169,7 +169,7 @@ 
 		$regTac = '!(\| *riconferme[ _]tacite[ _]amministratori *= *)(\d+)!';
 		$regVot = '!(\| *riconferme[ _]voto[ _]amministratori *= *)(\d+)!';
 
-		$tacMatches = $votMatches = [];
+		$tacMatches = $votMatches = [ ];
 		if ( preg_match( $regTac, $content, $tacMatches ) === false ) {
 			throw new TaskException( 'Param "tacite" not found in news page' );
 		}
@@ -177,8 +177,8 @@ 
 			throw new TaskException( 'Param "voto" not found in news page' );
 		}
 
-		$newTac = (int)$tacMatches[2] - $amount ?: '';
-		$newVot = (int)$votMatches[2] + $amount ?: '';
+		$newTac = (int)$tacMatches[ 2 ] - $amount ?: '';
+		$newVot = (int)$votMatches[ 2 ] + $amount ?: '';
 
 		$newContent = preg_replace( $regTac, '${1}' . $newTac, $content );
 		$newContent = preg_replace( $regVot, '${1}' . $newVot, $newContent );

includes/Task/Subtask/FailedUpdates.php

Spacing +18 added lines, -18 removed lines

@@ -1,4 +1,4 @@ 
-<?php declare( strict_types=1 );
+<?php declare(strict_types=1);
 
 namespace BotRiconferme\Task\Subtask;
 
@@ -13,7 +13,7 @@ 
 	/**
 	 * @inheritDoc
 	 */
-	public function run() : TaskResult {
+	public function run () : TaskResult {
 		$this->getLogger()->info( 'Starting task FailedUpdates' );
 
 		$failed = $this->getFailures();
@@ -33,12 +33,12 @@ 
 	 *
 	 * @return PageRiconferma[]
 	 */
-	private function getFailures() : array {
-		$ret = [];
+	private function getFailures () : array {
+		$ret = [ ];
 		$allPages = $this->getDataProvider()->getPagesToClose();
 		foreach ( $allPages as $page ) {
 			if ( $page->getOutcome() & PageRiconferma::OUTCOME_FAIL ) {
-				$ret[] = $page;
+				$ret[ ] = $page;
 			}
 		}
 		return $ret;
@@ -47,17 +47,17 @@ 
 	/**
 	 * @param PageRiconferma[] $pages
 	 */
-	protected function updateBurList( array $pages ) {
+	protected function updateBurList ( array $pages ) {
 		$this->getLogger()->info( 'Checking if bur list needs updating.' );
 		$admins = $this->getDataProvider()->getUsersList();
 
-		$remove = [];
+		$remove = [ ];
 		foreach ( $pages as $page ) {
 			$user = $page->getUser();
 			if ( array_key_exists( 'bureaucrat', $admins[ $user ] ) &&
 				$page->getOutcome() & PageRiconferma::OUTCOME_FAIL
 			) {
-				$remove[] = $user;
+				$remove[ ] = $user;
 			}
 		}
 
@@ -76,7 +76,7 @@ 
 			$lastUser = array_pop( $remove );
 			$removeList = implode( ', ', $remove ) . " e $lastUser";
 		} else {
-			$removeList = $remove[0];
+			$removeList = $remove[ 0 ];
 		}
 
 		$summary = $this->msg( 'bur-list-update-summary' )
@@ -95,7 +95,7 @@ 
 	 *
 	 * @param PageRiconferma[] $pages
 	 */
-	protected function requestRemoval( array $pages ) {
+	protected function requestRemoval ( array $pages ) {
 		$this->getLogger()->info(
 			'Requesting removal on meta for: ' . implode( ', ', array_map( 'strval', $pages ) )
 		);
@@ -138,14 +138,14 @@ 
 	 *
 	 * @param PageRiconferma[] $pages
 	 */
-	protected function updateAnnunci( array $pages ) {
+	protected function updateAnnunci ( array $pages ) {
 		$this->getLogger()->info( 'Updating annunci' );
 
-		$names = [];
+		$names = [ ];
 		$text = '';
 		foreach ( $pages as $page ) {
 			$user = $page->getUser();
-			$names[] = $user;
+			$names[ ] = $user;
 			$text .= "{{Breve|admin|{{subst:#time:j}}|[[Utente:$user|]] " .
 				"non è stato riconfermato [[WP:A|amministratore]].}}\n";
 		}
@@ -168,7 +168,7 @@ 
 			$lastUser = array_pop( $names );
 			$namesList = implode( ', ', $names ) . " e $lastUser";
 		} else {
-			$namesList = $names[0];
+			$namesList = $names[ 0 ];
 		}
 
 		$summary = $this->msg( 'annunci-summary' )
@@ -187,16 +187,16 @@ 
 	 *
 	 * @param PageRiconferma[] $pages
 	 */
-	protected function updateUltimeNotizie( array $pages ) {
+	protected function updateUltimeNotizie ( array $pages ) {
 		$this->getLogger()->info( 'Updating ultime notizie' );
 		$notiziePage = new Page( $this->getConfig()->get( 'ultimenotizie-title' ) );
 
-		$names = [];
+		$names = [ ];
 		$text = '';
 		foreach ( $pages as $page ) {
 			$user = $page->getUser();
 			$title = $page->getTitle();
-			$names[] = $user;
+			$names[ ] = $user;
 			$text .= "'''{{subst:#time:j F}}''': [[Utente:$user|]] non è stato [[$title|riconfermato]] " .
 				'[[WP:A|amministratore]]; ora gli admin sono {{subst:#expr: {{NUMBEROFADMINS}} - 1}}.';
 		}
@@ -215,7 +215,7 @@ 
 			$lastUser = array_pop( $names );
 			$namesList = implode( ', ', $names ) . " e $lastUser";
 		} else {
-			$namesList = $names[0];
+			$namesList = $names[ 0 ];
 		}
 
 		$summary = $this->msg( 'ultimenotizie-summary' )

includes/Task/Subtask/SimpleUpdates.php

Spacing +21 added lines, -21 removed lines

@@ -1,4 +1,4 @@ 
-<?php declare( strict_types=1 );
+<?php declare(strict_types=1);
 
 namespace BotRiconferme\Task\Subtask;
 
@@ -13,7 +13,7 @@ 
 	/**
 	 * @inheritDoc
 	 */
-	public function run() : TaskResult {
+	public function run () : TaskResult {
 		$this->getLogger()->info( 'Starting task SimpleUpdates' );
 
 		$pages = $this->getDataProvider()->getPagesToClose();
@@ -31,16 +31,16 @@ 
 	 * @param PageRiconferma[] $pages
 	 * @see UpdatesAround::addVote()
 	 */
-	protected function updateVote( array $pages ) {
+	protected function updateVote ( array $pages ) {
 		$this->getLogger()->info(
 			'Updating votazioni: ' . implode( ', ', array_map( 'strval', $pages ) )
 		);
 		$votePage = new Page( $this->getConfig()->get( 'ric-vote-page' ) );
 		$content = $votePage->getContent();
 
-		$titles = [];
+		$titles = [ ];
 		foreach ( $pages as $page ) {
-			$titles[] = preg_quote( $page->getTitle() );
+			$titles[ ] = preg_quote( $page->getTitle() );
 		}
 
 		$titleReg = implode( '|', array_map( 'preg_quote', $titles ) );
@@ -71,7 +71,7 @@ 
 	 * @param array $pages
 	 * @see UpdatesAround::addNews()
 	 */
-	protected function updateNews( array $pages ) {
+	protected function updateNews ( array $pages ) {
 		$simpleAmount = $voteAmount = 0;
 		foreach ( $pages as $page ) {
 			if ( $page->isVote() ) {
@@ -91,12 +91,12 @@ 
 		$simpleReg = '!(\| *riconferme[ _]tacite[ _]amministratori *= *)(\d+)!';
 		$voteReg = '!(\| *riconferme[ _]voto[ _]amministratori *= *)(\d+)!';
 
-		$simpleMatches = $voteMatches = [];
+		$simpleMatches = $voteMatches = [ ];
 		preg_match( $simpleReg, $content, $simpleMatches );
 		preg_match( $voteReg, $content, $voteMatches );
 
-		$newSimp = (int)$simpleMatches[2] - $simpleAmount ?: '';
-		$newVote = (int)$voteMatches[2] - $voteAmount ?: '';
+		$newSimp = (int)$simpleMatches[ 2 ] - $simpleAmount ?: '';
+		$newVote = (int)$voteMatches[ 2 ] - $voteAmount ?: '';
 		$newContent = preg_replace( $simpleReg, '${1}' . $newSimp, $content );
 		$newContent = preg_replace( $voteReg, '${1}' . $newVote, $newContent );
 
@@ -116,7 +116,7 @@ 
 	 *
 	 * @param PageRiconferma[] $pages
 	 */
-	protected function updateAdminList( array $pages ) {
+	protected function updateAdminList ( array $pages ) {
 		$this->getLogger()->info(
 			'Updating admin list: ' . implode( ', ', array_map( 'strval', $pages ) )
 		);
@@ -124,17 +124,17 @@ 
 		$newContent = $adminsPage->getContent();
 		$newDate = date( 'Ymd', strtotime( '+1 year' ) );
 
-		$riconfNames = $removeNames = [];
+		$riconfNames = $removeNames = [ ];
 		foreach ( $pages as $page ) {
 			$user = $page->getUser();
 			$reg = "!(\{\{Amministratore\/riga\|$user.+\| *)\d+( *\|(?: *pausa)? *\}\}\n)!";
 			if ( $page->getOutcome() & PageRiconferma::OUTCOME_FAIL ) {
 				// Remove the line
 				$newContent = preg_replace( $reg, '', $newContent );
-				$removeNames[] = $user;
+				$removeNames[ ] = $user;
 			} else {
 				$newContent = preg_replace( $reg, '$1' . $newDate . '$2', $newContent );
-				$riconfNames[] = $user;
+				$riconfNames[ ] = $user;
 			}
 		}
 
@@ -142,7 +142,7 @@ 
 			$lastUser = array_pop( $riconfNames );
 			$riconfList = implode( ', ', $riconfNames ) . " e $lastUser";
 		} elseif ( $riconfNames ) {
-			$riconfList = $riconfNames[0];
+			$riconfList = $riconfNames[ 0 ];
 		} else {
 			$riconfList = 'nessuno';
 		}
@@ -151,7 +151,7 @@ 
 			$lastUser = array_pop( $removeNames );
 			$removeList = implode( ', ', $removeNames ) . " e $lastUser";
 		} elseif ( $removeNames ) {
-			$removeList = $removeNames[0];
+			$removeList = $removeNames[ 0 ];
 		} else {
 			$removeList = 'nessuno';
 		}
@@ -174,13 +174,13 @@ 
 	/**
 	 * @param PageRiconferma[] $pages
 	 */
-	protected function updateCUList( array $pages ) {
+	protected function updateCUList ( array $pages ) {
 		$this->getLogger()->info( 'Checking if CU list needs updating.' );
 		$cuList = new Page( $this->getConfig()->get( 'cu-list-title' ) );
 		$admins = $this->getDataProvider()->getUsersList();
 		$newContent = $cuList->getContent();
 
-		$riconfNames = $removeNames = [];
+		$riconfNames = $removeNames = [ ];
 		foreach ( $pages as $page ) {
 			$user = $page->getUser();
 			if ( array_key_exists( 'checkuser', $admins[ $user ] ) ) {
@@ -188,10 +188,10 @@ 
 				if ( $page->getOutcome() & PageRiconferma::OUTCOME_FAIL ) {
 					// Remove the line
 					$newContent = preg_replace( $reg, '', $newContent );
-					$removeNames[] = $user;
+					$removeNames[ ] = $user;
 				} else {
 					$newContent = preg_replace( $reg, '$1{{subst:#time:j F Y}}$2', $newContent );
-					$riconfNames[] = $user;
+					$riconfNames[ ] = $user;
 				}
 			}
 		}
@@ -208,7 +208,7 @@ 
 			$lastUser = array_pop( $riconfNames );
 			$riconfList = implode( ', ', $riconfNames ) . " e $lastUser";
 		} elseif ( $riconfNames ) {
-			$riconfList = $riconfNames[0];
+			$riconfList = $riconfNames[ 0 ];
 		} else {
 			$riconfList = 'nessuno';
 		}
@@ -217,7 +217,7 @@ 
 			$lastUser = array_pop( $removeNames );
 			$removeList = implode( ', ', $removeNames ) . " e $lastUser";
 		} elseif ( $removeNames ) {
-			$removeList = $removeNames[0];
+			$removeList = $removeNames[ 0 ];
 		} else {
 			$removeList = 'nessuno';
 		}

includes/Task/Subtask/ClosePages.php

Spacing +5 added lines, -6 removed lines

@@ -1,4 +1,4 @@ 
-<?php declare( strict_types=1 );
+<?php declare(strict_types=1);
 
 namespace BotRiconferme\Task\Subtask;
 
@@ -14,7 +14,7 @@ 
 	/**
 	 * @inheritDoc
 	 */
-	public function run() : TaskResult {
+	public function run () : TaskResult {
 		$this->getLogger()->info( 'Starting task ClosePages' );
 
 		$pages = $this->getDataProvider()->getPagesToClose();
@@ -34,7 +34,7 @@ 
 	/**
 	 * @param PageRiconferma $page
 	 */
-	protected function addVoteCloseText( PageRiconferma $page ) {
+	protected function addVoteCloseText ( PageRiconferma $page ) {
 		$content = $page->getContent();
 		$beforeReg = '!è necessario ottenere una maggioranza .+ votanti\.!';
 		$newContent = preg_replace( $beforeReg, '$0' . "\n" . $page->getOutcomeText(), $content );
@@ -50,15 +50,14 @@ 
 	 * @param PageRiconferma $page
 	 * @see CreatePages::updateBasePage()
 	 */
-	protected function updateBasePage( PageRiconferma $page ) {
+	protected function updateBasePage ( PageRiconferma $page ) {
 		$this->getLogger()->info( "Updating base page for $page" );
 
 		$basePage = new Page( $page->getBaseTitle() );
 		$current = $basePage->getContent();
 
 		$outcomeText = $page->getOutcome() & PageRiconferma::OUTCOME_FAIL ?
-			'non riconfermato' :
-			'riconfermato';
+			'non riconfermato' : 'riconfermato';
 		$text = $page->isVote() ? "votazione: $outcomeText" : 'riconferma tacita';
 
 		$newContent = str_replace( 'riconferma in corso', $text, $current );

includes/Task/Subtask/ArchivePages.php

Spacing +12 added lines, -12 removed lines

@@ -1,4 +1,4 @@ 
-<?php declare( strict_types=1 );
+<?php declare(strict_types=1);
 
 namespace BotRiconferme\Task\Subtask;
 
@@ -13,7 +13,7 @@ 
 	/**
 	 * @inheritDoc
 	 */
-	public function run() : TaskResult {
+	public function run () : TaskResult {
 		$this->getLogger()->info( 'Starting task ArchivePages' );
 
 		$pages = $this->getDataProvider()->getPagesToClose();
@@ -30,13 +30,13 @@ 
 	 * @param PageRiconferma[] $pages
 	 * @see UpdatesAround::addToMainPage()
 	 */
-	protected function removeFromMainPage( array $pages ) {
+	protected function removeFromMainPage ( array $pages ) {
 		$this->getLogger()->info(
 			'Removing from main: ' . implode( ', ', array_map( 'strval', $pages ) )
 		);
 
 		$mainPage = new Page( $this->getConfig()->get( 'ric-main-page' ) );
-		$translations = [];
+		$translations = [ ];
 		foreach ( $pages as $page ) {
 			$translations[ '{{' . $page->getTitle() . '}}' ] = '';
 		}
@@ -54,17 +54,17 @@ 
 	 *
 	 * @param PageRiconferma[] $pages
 	 */
-	protected function addToArchive( array $pages ) {
+	protected function addToArchive ( array $pages ) {
 		$this->getLogger()->info(
 			'Adding to archive: ' . implode( ', ', array_map( 'strval', $pages ) )
 		);
 
-		$simple = $votes = [];
+		$simple = $votes = [ ];
 		foreach ( $pages as $page ) {
 			if ( $page->isVote() ) {
-				$votes[] = $page;
+				$votes[ ] = $page;
 			} else {
-				$simple[] = $page;
+				$simple[ ] = $page;
 			}
 		}
 
@@ -81,21 +81,21 @@ 
 	 * @param string $archiveTitle
 	 * @param array $pages
 	 */
-	private function reallyAddToArchive( string $archiveTitle, array $pages ) {
+	private function reallyAddToArchive ( string $archiveTitle, array $pages ) {
 		$curTitle = "$archiveTitle/" . date( 'Y' );
 
 		$append = '';
-		$archivedList = [];
+		$archivedList = [ ];
 		foreach ( $pages as $page ) {
 			$append .= '{{' . $page->getTitle() . "}}\n";
-			$archivedList[] = $page->getUserNum();
+			$archivedList[ ] = $page->getUserNum();
 		}
 
 		if ( count( $archivedList ) > 1 ) {
 			$last = array_pop( $archivedList );
 			$userNums = implode( ', ', $archivedList ) . " e $last";
 		} else {
-			$userNums = $archivedList[0];
+			$userNums = $archivedList[ 0 ];
 		}
 
 		$summary = $this->msg( 'close-archive-summary' )