Passed
Push — master ( c33c94...db42f9 )
by Daimona
07:40 queued 02:01
created
includes/Task/StartNew.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -1,4 +1,4 @@  discard block
 block discarded – undo
1
-<?php declare( strict_types=1 );
1
+<?php declare(strict_types=1);
2 2
 
3 3
 namespace BotRiconferme\Task;
4 4
 
@@ -14,7 +14,7 @@  discard block
 block discarded – undo
14 14
 	/**
15 15
 	 * @inheritDoc
16 16
 	 */
17
-	public function runInternal() : int {
17
+	public function runInternal () : int {
18 18
 		$orderedList = [
19 19
 			'create-pages',
20 20
 			'updates-around',
@@ -32,7 +32,7 @@  discard block
 block discarded – undo
32 32
 	/**
33 33
 	 * @inheritDoc
34 34
 	 */
35
-	protected function getSubtasksMap() : array {
35
+	protected function getSubtasksMap () : array {
36 36
 		return [
37 37
 			'create-pages' => CreatePages::class,
38 38
 			'updates-around' => UpdatesAround::class,
Please login to merge, or discard this patch.
includes/Exception/MissingSectionException.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -1,4 +1,4 @@  discard block
 block discarded – undo
1
-<?php declare( strict_types=1 );
1
+<?php declare(strict_types=1);
2 2
 
3 3
 namespace BotRiconferme\Exception;
4 4
 
@@ -10,7 +10,7 @@  discard block
 block discarded – undo
10 10
 	 * @param string $title
11 11
 	 * @param int|string $section Number or title
12 12
 	 */
13
-	public function __construct( string $title = '[unavailable]', $section = '[unavailable]' ) {
13
+	public function __construct ( string $title = '[unavailable]', $section = '[unavailable]' ) {
14 14
 		parent::__construct( "The section $section in the page $title doesn't exist." );
15 15
 	}
16 16
 }
Please login to merge, or discard this patch.
includes/Task/Subtask/ClosePages.php 1 patch
Spacing   +5 added lines, -6 removed lines patch added patch discarded remove patch
@@ -1,4 +1,4 @@  discard block
 block discarded – undo
1
-<?php declare( strict_types=1 );
1
+<?php declare(strict_types=1);
2 2
 
3 3
 namespace BotRiconferme\Task\Subtask;
4 4
 
@@ -14,7 +14,7 @@  discard block
 block discarded – undo
14 14
 	/**
15 15
 	 * @inheritDoc
16 16
 	 */
17
-	public function runInternal() : int {
17
+	public function runInternal () : int {
18 18
 		$pages = $this->getDataProvider()->getPagesToClose();
19 19
 		$protectReason = $this->msg( 'close-protect-summary' )->text();
20 20
 		foreach ( $pages as $page ) {
@@ -31,7 +31,7 @@  discard block
 block discarded – undo
31 31
 	/**
32 32
 	 * @param PageRiconferma $page
33 33
 	 */
34
-	protected function addVoteCloseText( PageRiconferma $page ) {
34
+	protected function addVoteCloseText ( PageRiconferma $page ) {
35 35
 		$content = $page->getContent();
36 36
 		$beforeReg = '!è necessario ottenere una maggioranza .+ votanti\.!';
37 37
 		$newContent = preg_replace( $beforeReg, '$0' . "\n" . $page->getOutcomeText(), $content );
@@ -46,15 +46,14 @@  discard block
 block discarded – undo
46 46
 	 * @param PageRiconferma $page
47 47
 	 * @see CreatePages::updateBasePage()
48 48
 	 */
49
-	protected function updateBasePage( PageRiconferma $page ) {
49
+	protected function updateBasePage ( PageRiconferma $page ) {
50 50
 		$this->getLogger()->info( "Updating base page for $page" );
51 51
 
52 52
 		$basePage = new Page( $page->getBaseTitle() );
53 53
 		$current = $basePage->getContent();
54 54
 
55 55
 		$outcomeText = $page->getOutcome() & PageRiconferma::OUTCOME_FAIL ?
56
-			'non riconfermato' :
57
-			'riconfermato';
56
+			'non riconfermato' : 'riconfermato';
58 57
 		$text = $page->isVote() ? "votazione: $outcomeText" : 'riconferma tacita';
59 58
 
60 59
 		$newContent = str_replace( 'riconferma in corso', $text, $current );
Please login to merge, or discard this patch.
includes/Task/Subtask/Subtask.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -1,4 +1,4 @@  discard block
 block discarded – undo
1
-<?php declare( strict_types=1 );
1
+<?php declare(strict_types=1);
2 2
 
3 3
 namespace BotRiconferme\Task\Subtask;
4 4
 
@@ -11,7 +11,7 @@  discard block
 block discarded – undo
11 11
 	/**
12 12
 	 * @inheritDoc
13 13
 	 */
14
-	final public function getOperationName(): string {
14
+	final public function getOperationName (): string {
15 15
 		return 'subtask';
16 16
 	}
17 17
 }
Please login to merge, or discard this patch.
includes/Task/Task.php 1 patch
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -1,4 +1,4 @@  discard block
 block discarded – undo
1
-<?php declare( strict_types=1 );
1
+<?php declare(strict_types=1);
2 2
 
3 3
 namespace BotRiconferme\Task;
4 4
 
@@ -14,13 +14,13 @@  discard block
 block discarded – undo
14 14
 	 *
15 15
 	 * @return string[]
16 16
 	 */
17
-	abstract protected function getSubtasksMap() : array;
17
+	abstract protected function getSubtasksMap () : array;
18 18
 
19 19
 	/**
20 20
 	 * @param string $subtask Defined in self::SUBTASKS_MAP
21 21
 	 * @return TaskResult
22 22
 	 */
23
-	protected function runSubtask( string $subtask ) : TaskResult {
23
+	protected function runSubtask ( string $subtask ) : TaskResult {
24 24
 		$map = $this->getSubtasksMap();
25 25
 		if ( !isset( $map[ $subtask ] ) ) {
26 26
 			throw new \InvalidArgumentException( "'$subtask' is not a valid task." );
@@ -33,7 +33,7 @@  discard block
 block discarded – undo
33 33
 	/**
34 34
 	 * @inheritDoc
35 35
 	 */
36
-	final public function getOperationName(): string {
36
+	final public function getOperationName (): string {
37 37
 		return 'task';
38 38
 	}
39 39
 
@@ -43,7 +43,7 @@  discard block
 block discarded – undo
43 43
 	 * @param string $class
44 44
 	 * @return Subtask
45 45
 	 */
46
-	private function getSubtaskInstance( string $class ) : Subtask {
46
+	private function getSubtaskInstance ( string $class ) : Subtask {
47 47
 		return new $class( $this->getDataProvider() );
48 48
 	}
49 49
 }
Please login to merge, or discard this patch.
run.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -1,4 +1,4 @@  discard block
 block discarded – undo
1
-<?php declare( strict_types=1 );
1
+<?php declare(strict_types=1);
2 2
 /**
3 3
  * Entry point for the bot, called by CLI
4 4
  */
@@ -37,7 +37,7 @@  discard block
 block discarded – undo
37 37
 
38 38
 /* URL (for debugging purpose) */
39 39
 $urlParam = getopt( '', [ 'force-url:' ] );
40
-$url = $urlParam['force-url'] ?? 'https://it.wikipedia.org/w/api.php';
40
+$url = $urlParam[ 'force-url' ] ?? 'https://it.wikipedia.org/w/api.php';
41 41
 
42 42
 define( 'DEFAULT_URL', $url );
43 43
 
@@ -87,9 +87,9 @@  discard block
 block discarded – undo
87 87
 
88 88
 if ( count( $taskOpts ) === 2 ) {
89 89
 	throw new InvalidArgumentException( 'Cannot specify both task and subtask.' );
90
-} elseif ( isset( $taskOpts['task'] ) ) {
90
+} elseif ( isset( $taskOpts[ 'task' ] ) ) {
91 91
 	$bot->runTask( $taskOpts[ 'task' ] );
92
-} elseif ( isset( $taskOpts['subtask'] ) ) {
92
+} elseif ( isset( $taskOpts[ 'subtask' ] ) ) {
93 93
 	$bot->runSubtask( $taskOpts[ 'subtask' ] );
94 94
 } else {
95 95
 	$bot->runAll();
Please login to merge, or discard this patch.
includes/Task/Subtask/UserNotice.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -1,4 +1,4 @@  discard block
 block discarded – undo
1
-<?php declare( strict_types=1 );
1
+<?php declare(strict_types=1);
2 2
 
3 3
 namespace BotRiconferme\Task\Subtask;
4 4
 
@@ -11,7 +11,7 @@  discard block
 block discarded – undo
11 11
 	/**
12 12
 	 * @inheritDoc
13 13
 	 */
14
-	public function runInternal() : int {
14
+	public function runInternal () : int {
15 15
 		$pages = $this->getDataProvider()->getCreatedPages();
16 16
 		$users = $this->getDataProvider()->getUsersToProcess();
17 17
 
@@ -19,7 +19,7 @@  discard block
 block discarded – undo
19 19
 			return TaskResult::STATUS_NOTHING;
20 20
 		}
21 21
 
22
-		$ricNums = [];
22
+		$ricNums = [ ];
23 23
 		foreach ( $pages as $page ) {
24 24
 			$ricNums[ $page->getUser()->getName() ] = $page->getNum();
25 25
 		}
@@ -37,7 +37,7 @@  discard block
 block discarded – undo
37 37
 	 * @param string $user
38 38
 	 * @param int $ricNum
39 39
 	 */
40
-	protected function addMsg( string $user, int $ricNum ) {
40
+	protected function addMsg ( string $user, int $ricNum ) {
41 41
 		$this->getLogger()->info( "Leaving msg to $user" );
42 42
 		$msg = $this->msg( 'user-notice-msg' )->params( [ '$num' => $ricNum ] )->text();
43 43
 
Please login to merge, or discard this patch.
includes/Wiki/User.php 1 patch
Spacing   +7 added lines, -7 removed lines patch added patch discarded remove patch
@@ -1,4 +1,4 @@  discard block
 block discarded – undo
1
-<?php declare( strict_types=1 );
1
+<?php declare(strict_types=1);
2 2
 
3 3
 namespace BotRiconferme\Wiki;
4 4
 
@@ -16,21 +16,21 @@  discard block
 block discarded – undo
16 16
 	/**
17 17
 	 * @param string $name
18 18
 	 */
19
-	public function __construct( string $name ) {
19
+	public function __construct ( string $name ) {
20 20
 		$this->name = $name;
21 21
 	}
22 22
 
23 23
 	/**
24 24
 	 * @return string
25 25
 	 */
26
-	public function getName() : string {
26
+	public function getName () : string {
27 27
 		return $this->name;
28 28
 	}
29 29
 
30 30
 	/**
31 31
 	 * @return string[]
32 32
 	 */
33
-	public function getGroups() : array {
33
+	public function getGroups () : array {
34 34
 		if ( $this->groups === null ) {
35 35
 			$usersList = PageBotList::get()->getAdminsList();
36 36
 			$this->groups = array_keys( $usersList[ $this->name ] );
@@ -44,7 +44,7 @@  discard block
 block discarded – undo
44 44
 	 * @param string $groupName
45 45
 	 * @return bool
46 46
 	 */
47
-	public function inGroup( string $groupName ) : bool {
47
+	public function inGroup ( string $groupName ) : bool {
48 48
 		return in_array( $groupName, $this->getGroups() );
49 49
 	}
50 50
 
@@ -53,14 +53,14 @@  discard block
 block discarded – undo
53 53
 	 *
54 54
 	 * @inheritDoc
55 55
 	 */
56
-	public function getRegex() : string {
56
+	public function getRegex () : string {
57 57
 		return str_replace( ' ', '[ _]', preg_quote( $this->name ) );
58 58
 	}
59 59
 
60 60
 	/**
61 61
 	 * @return string
62 62
 	 */
63
-	public function __toString() {
63
+	public function __toString () {
64 64
 		return $this->name;
65 65
 	}
66 66
 }
Please login to merge, or discard this patch.
includes/TaskManager.php 1 patch
Spacing   +7 added lines, -7 removed lines patch added patch discarded remove patch
@@ -1,4 +1,4 @@  discard block
 block discarded – undo
1
-<?php declare( strict_types=1 );
1
+<?php declare(strict_types=1);
2 2
 
3 3
 namespace BotRiconferme;
4 4
 
@@ -52,7 +52,7 @@  discard block
 block discarded – undo
52 52
 	 * @param string|null $name Only used in MODE_TASK and MODE_SUBTASK
53 53
 	 * @return TaskResult
54 54
 	 */
55
-	public function run( string $mode, string $name = null ) : TaskResult {
55
+	public function run ( string $mode, string $name = null ) : TaskResult {
56 56
 		$this->provider = new TaskDataProvider;
57 57
 
58 58
 		if ( $mode === self::MODE_COMPLETE ) {
@@ -69,7 +69,7 @@  discard block
 block discarded – undo
69 69
 	 *
70 70
 	 * @return TaskResult
71 71
 	 */
72
-	protected function runAllTasks() : TaskResult {
72
+	protected function runAllTasks () : TaskResult {
73 73
 		$orderedList = [
74 74
 			'update-list',
75 75
 			'start-new',
@@ -91,7 +91,7 @@  discard block
 block discarded – undo
91 91
 	 * @param string $name
92 92
 	 * @return TaskResult
93 93
 	 */
94
-	protected function runTask( string $name ) : TaskResult {
94
+	protected function runTask ( string $name ) : TaskResult {
95 95
 		if ( !isset( self::TASKS_MAP[ $name ] ) ) {
96 96
 			throw new \InvalidArgumentException( "'$name' is not a valid task." );
97 97
 		}
@@ -106,7 +106,7 @@  discard block
 block discarded – undo
106 106
 	 * @param string $name
107 107
 	 * @return TaskResult
108 108
 	 */
109
-	protected function runSubtask( string $name ) : TaskResult {
109
+	protected function runSubtask ( string $name ) : TaskResult {
110 110
 		if ( !isset( self::SUBTASKS_MAP[ $name ] ) ) {
111 111
 			throw new \InvalidArgumentException( "'$name' is not a valid subtask." );
112 112
 		}
@@ -121,7 +121,7 @@  discard block
 block discarded – undo
121 121
 	 * @param string $class
122 122
 	 * @return Task
123 123
 	 */
124
-	private function getTaskInstance( string $class ) : Task {
124
+	private function getTaskInstance ( string $class ) : Task {
125 125
 		return new $class( $this->provider );
126 126
 	}
127 127
 
@@ -131,7 +131,7 @@  discard block
 block discarded – undo
131 131
 	 * @param string $class
132 132
 	 * @return Subtask
133 133
 	 */
134
-	private function getSubtaskInstance( string $class ) : Subtask {
134
+	private function getSubtaskInstance ( string $class ) : Subtask {
135 135
 		return new $class( $this->provider );
136 136
 	}
137 137
 }
Please login to merge, or discard this patch.