Inspection of "datefix" - Daimona/BotRiconferme - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( c33c94...db42f9 )

by Daimona

created 2019-04-30 14:54 UTC

Status

Spacing +18 added lines, -18 removed lines patch added patch discarded remove patch

@@ -1,4 +1,4 @@  discard block
 block discarded – undo
-<?php declare( strict_types=1 );
+<?php declare(strict_types=1);
 
 namespace BotRiconferme\Task\Subtask;
 
@@ -16,7 +16,7 @@  discard block
 block discarded – undo
 	/**
 	 * @inheritDoc
 	 */
-	public function runInternal() : int {
+	public function runInternal () : int {
 		$pages = $this->getDataProvider()->getPagesToClose();
 
 		if ( !$pages ) {
@@ -38,15 +38,15 @@  discard block
 block discarded – undo
 	 * @param PageRiconferma[] $pages
 	 * @see UpdatesAround::addToVotazioni()
 	 */
-	protected function updateVotazioni( array $pages ) {
+	protected function updateVotazioni ( array $pages ) {
 		$this->getLogger()->info(
 			'Updating votazioni: ' . implode( ', ', $pages )
 		);
 		$votePage = new Page( $this->getOpt( 'vote-page-title' ) );
 
-		$users = [];
+		$users = [ ];
 		foreach ( $pages as $page ) {
-			$users[] = $page->getUser();
+			$users[ ] = $page->getUser();
 		}
 		$usersReg = Element::regexFromArray( $users );
 
@@ -67,7 +67,7 @@  discard block
 block discarded – undo
 	 * @param array $pages
 	 * @see UpdatesAround::addToNews()
 	 */
-	protected function updateNews( array $pages ) {
+	protected function updateNews ( array $pages ) {
 		$simpleAmount = $voteAmount = 0;
 		foreach ( $pages as $page ) {
 			if ( $page->isVote() ) {
@@ -87,8 +87,8 @@  discard block
 block discarded – undo
 		$simpleMatches = $newsPage->getMatch( $simpleReg );
 		$voteMatches = $newsPage->getMatch( $voteReg );
 
-		$newSimp = (int)$simpleMatches[2] - $simpleAmount ?: '';
-		$newVote = (int)$voteMatches[2] - $voteAmount ?: '';
+		$newSimp = (int)$simpleMatches[ 2 ] - $simpleAmount ?: '';
+		$newVote = (int)$voteMatches[ 2 ] - $voteAmount ?: '';
 		$newContent = preg_replace( $simpleReg, '${1}' . $newSimp, $newsPage->getContent() );
 		$newContent = preg_replace( $voteReg, '${1}' . $newVote, $newContent );
 
@@ -106,21 +106,21 @@  discard block
 block discarded – undo
 	 *
 	 * @param bool[] $outcomes
 	 */
-	protected function updateAdminList( array $outcomes ) {
+	protected function updateAdminList ( array $outcomes ) {
 		$this->getLogger()->info( 'Updating admin list' );
 		$adminsPage = new Page( $this->getOpt( 'admins-list-title' ) );
 		$newContent = $adminsPage->getContent();
 
-		$riconfNames = $removeNames = [];
+		$riconfNames = $removeNames = [ ];
 		foreach ( $outcomes as $user => $confirmed ) {
 			$userReg = ( new User( $user ) )->getRegex();
 			$reg = "!(\{\{Amministratore\/riga\|$userReg.+\| *)\d+( *\|[ \w]*\}\}.*\n)!";
 			if ( $confirmed ) {
 				$newContent = preg_replace( $reg, '${1}{{subst:#time:Ymd}}$2', $newContent );
-				$riconfNames[] = $user;
+				$riconfNames[ ] = $user;
 			} else {
 				$newContent = preg_replace( $reg, '', $newContent );
-				$removeNames[] = $user;
+				$removeNames[ ] = $user;
 			}
 		}
 
@@ -140,21 +140,21 @@  discard block
 block discarded – undo
 	/**
 	 * @param bool[] $outcomes
 	 */
-	protected function updateCUList( array $outcomes ) {
+	protected function updateCUList ( array $outcomes ) {
 		$this->getLogger()->info( 'Updating CU list.' );
 		$cuList = new Page( $this->getOpt( 'cu-list-title' ) );
 		$newContent = $cuList->getContent();
 
-		$riconfNames = $removeNames = [];
+		$riconfNames = $removeNames = [ ];
 		foreach ( $outcomes as $user => $confirmed ) {
 			$userReg = ( new User( $user ) )->getRegex();
 			$reg = "!(\{\{ *Checkuser *\| *$userReg *\|[^}]+\| *)[\w \d]+(}}.*\n)!";
 			if ( $confirmed ) {
 				$newContent = preg_replace( $reg, '${1}{{subst:#time:j F Y}}$2', $newContent );
-				$riconfNames[] = $user;
+				$riconfNames[ ] = $user;
 			} else {
 				$newContent = preg_replace( $reg, '', $newContent );
-				$removeNames[] = $user;
+				$removeNames[ ] = $user;
 			}
 		}
 
@@ -178,8 +178,8 @@  discard block
 block discarded – undo
 	 * @param PageRiconferma[] $pages
 	 * @return bool[]
 	 */
-	private function getGroupOutcomes( string $group, array $pages ) : array {
-		$ret = [];
+	private function getGroupOutcomes ( string $group, array $pages ) : array {
+		$ret = [ ];
 		foreach ( $pages as $page ) {
 			$user = $page->getUser();
 			if ( $user->inGroup( $group ) ) {

Please login to merge, or discard this patch.

		@@ -1,4 +1,4 @@ discard block
		block discarded – undo
1		-<?php declare( strict_types=1 );
	1	+<?php declare(strict_types=1);
2	2
3	3	namespace BotRiconferme\Task\Subtask;
4	4
		@@ -16,7 +16,7 @@ discard block
		block discarded – undo
16	16	/**
17	17	* @inheritDoc
18	18	*/
19		- public function runInternal() : int {
	19	+ public function runInternal () : int {
20	20	$pages = $this->getDataProvider()->getPagesToClose();
21	21
22	22	if ( !$pages ) {
		@@ -38,15 +38,15 @@ discard block
		block discarded – undo
38	38	* @param PageRiconferma[] $pages
39	39	* @see UpdatesAround::addToVotazioni()
40	40	*/
41		- protected function updateVotazioni( array $pages ) {
	41	+ protected function updateVotazioni ( array $pages ) {
42	42	$this->getLogger()->info(
43	43	'Updating votazioni: ' . implode( ', ', $pages )
44	44	);
45	45	$votePage = new Page( $this->getOpt( 'vote-page-title' ) );
46	46
47		- $users = [];
	47	+ $users = [ ];
48	48	foreach ( $pages as $page ) {
49		- $users[] = $page->getUser();
	49	+ $users[ ] = $page->getUser();
50	50	}
51	51	$usersReg = Element::regexFromArray( $users );
52	52
		@@ -67,7 +67,7 @@ discard block
		block discarded – undo
67	67	* @param array $pages
68	68	* @see UpdatesAround::addToNews()
69	69	*/
70		- protected function updateNews( array $pages ) {
	70	+ protected function updateNews ( array $pages ) {
71	71	$simpleAmount = $voteAmount = 0;
72	72	foreach ( $pages as $page ) {
73	73	if ( $page->isVote() ) {
		@@ -87,8 +87,8 @@ discard block
		block discarded – undo
87	87	$simpleMatches = $newsPage->getMatch( $simpleReg );
88	88	$voteMatches = $newsPage->getMatch( $voteReg );
89	89
90		- $newSimp = (int)$simpleMatches[2] - $simpleAmount ?: '';
91		- $newVote = (int)$voteMatches[2] - $voteAmount ?: '';
	90	+ $newSimp = (int)$simpleMatches[ 2 ] - $simpleAmount ?: '';
	91	+ $newVote = (int)$voteMatches[ 2 ] - $voteAmount ?: '';
92	92	$newContent = preg_replace( $simpleReg, '${1}' . $newSimp, $newsPage->getContent() );
93	93	$newContent = preg_replace( $voteReg, '${1}' . $newVote, $newContent );
94	94
		@@ -106,21 +106,21 @@ discard block
		block discarded – undo
106	106	*
107	107	* @param bool[] $outcomes
108	108	*/
109		- protected function updateAdminList( array $outcomes ) {
	109	+ protected function updateAdminList ( array $outcomes ) {
110	110	$this->getLogger()->info( 'Updating admin list' );
111	111	$adminsPage = new Page( $this->getOpt( 'admins-list-title' ) );
112	112	$newContent = $adminsPage->getContent();
113	113
114		- $riconfNames = $removeNames = [];
	114	+ $riconfNames = $removeNames = [ ];
115	115	foreach ( $outcomes as $user => $confirmed ) {
116	116	$userReg = ( new User( $user ) )->getRegex();
117	117	$reg = "!(\{\{Amministratore\/riga\\|$userReg.+\\| )\d+( \\|[ \w]\}\}.\n)!";
118	118	if ( $confirmed ) {
119	119	$newContent = preg_replace( $reg, '${1}{{subst:#time:Ymd}}$2', $newContent );
120		- $riconfNames[] = $user;
	120	+ $riconfNames[ ] = $user;
121	121	} else {
122	122	$newContent = preg_replace( $reg, '', $newContent );
123		- $removeNames[] = $user;
	123	+ $removeNames[ ] = $user;
124	124	}
125	125	}
126	126
		@@ -140,21 +140,21 @@ discard block
		block discarded – undo
140	140	/**
141	141	* @param bool[] $outcomes
142	142	*/
143		- protected function updateCUList( array $outcomes ) {
	143	+ protected function updateCUList ( array $outcomes ) {
144	144	$this->getLogger()->info( 'Updating CU list.' );
145	145	$cuList = new Page( $this->getOpt( 'cu-list-title' ) );
146	146	$newContent = $cuList->getContent();
147	147
148		- $riconfNames = $removeNames = [];
	148	+ $riconfNames = $removeNames = [ ];
149	149	foreach ( $outcomes as $user => $confirmed ) {
150	150	$userReg = ( new User( $user ) )->getRegex();
151	151	$reg = "!(\{\{ Checkuser \\| $userReg \\|[^}]+\\| )[\w \d]+(}}.\n)!";
152	152	if ( $confirmed ) {
153	153	$newContent = preg_replace( $reg, '${1}{{subst:#time:j F Y}}$2', $newContent );
154		- $riconfNames[] = $user;
	154	+ $riconfNames[ ] = $user;
155	155	} else {
156	156	$newContent = preg_replace( $reg, '', $newContent );
157		- $removeNames[] = $user;
	157	+ $removeNames[ ] = $user;
158	158	}
159	159	}
160	160
		@@ -178,8 +178,8 @@ discard block
		block discarded – undo
178	178	* @param PageRiconferma[] $pages
179	179	* @return bool[]
180	180	*/
181		- private function getGroupOutcomes( string $group, array $pages ) : array {
182		- $ret = [];
	181	+ private function getGroupOutcomes ( string $group, array $pages ) : array {
	182	+ $ret = [ ];
183	183	foreach ( $pages as $page ) {
184	184	$user = $page->getUser();
185	185	if ( $user->inGroup( $group ) ) {

Daimona / BotRiconferme

Push — master ( c33c94...db42f9 )

Status

Category

Spacing +18 added lines, -18 removed lines patch added patch discarded remove patch